coreboot-gerrit April 2021

coreboot-gerrit@coreboot.org

1 participants
6269 discussions

Change in coreboot[master]: mb/msi/h81m-p33: Put MAINBOARD_DIR in double quotes
by Angel Pons (Code Review) 02 Apr '21

02 Apr '21

Attention is currently required from: Nico Huber. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52065 ) Change subject: mb/msi/h81m-p33: Put MAINBOARD_DIR in double quotes ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/52065 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I73160985c025cb0945a4ac16c8c3ebb988d3858f Gerrit-Change-Number: 52065 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Fri, 02 Apr 2021 20:09:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: device/Kconfig: Adapt PCIEXP_HOTPLUG_BUSES
by Nico Huber (Code Review) 02 Apr '21

02 Apr '21

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/52069 ) Change subject: device/Kconfig: Adapt PCIEXP_HOTPLUG_BUSES ...................................................................... device/Kconfig: Adapt PCIEXP_HOTPLUG_BUSES The default of 32 buses per hotplug bridge is rather high. Especially for platforms that limit MMConf space to 64 buses: they run out of numbers if there is more than a single hotplug bridge. Lower the default to * 8 if MMConf is limitted to 64 or less buses, * 16 if MMConf is limitted to 128 or less buses. Change-Id: I06d522dd92ceea9f4798273b26f947a5333800c3 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M src/device/Kconfig 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/52069/1 diff --git a/src/device/Kconfig b/src/device/Kconfig index 1bfc34a..63b7d6c 100644 --- a/src/device/Kconfig +++ b/src/device/Kconfig @@ -626,6 +626,8 @@ config PCIEXP_HOTPLUG_BUSES int "PCI Express Hotplug Buses" + default 8 if MMCONF_SUPPORT && MMCONF_BUS_NUMBER <= 64 + default 16 if MMCONF_SUPPORT && MMCONF_BUS_NUMBER <= 128 default 32 help This is the number of buses allocated for hotplug PCI express -- To view, visit https://review.coreboot.org/c/coreboot/+/52069 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I06d522dd92ceea9f4798273b26f947a5333800c3 Gerrit-Change-Number: 52069 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: util/kconfig_lint: Update handle_expressions()
by Nico Huber (Code Review) 02 Apr '21

02 Apr '21

Attention is currently required from: Martin Roth. Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/52068 ) Change subject: util/kconfig_lint: Update handle_expressions() ...................................................................... util/kconfig_lint: Update handle_expressions() More relational operators were added to Kconfig in 2015. Now we can make use of them. Change-Id: I640e5c3ee1485348f09fcb0b0d5035eb53a2c98e Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M util/lint/kconfig_lint 1 file changed, 9 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/52068/1 diff --git a/util/lint/kconfig_lint b/util/lint/kconfig_lint index 51cc226..b72d34a 100755 --- a/util/lint/kconfig_lint +++ b/util/lint/kconfig_lint @@ -988,20 +988,26 @@ my $balanced = qr/((?:$parens|$quotes|[^"])+)/; if ( $exprline =~ /^\s*$balanced\s*(?:\|\||&&)\s*(.+)$/ ) { - # <expr> '||' <expr>, <expr> '&&' <expr> (7)(6) + # <expr> '||' <expr>, <expr> '&&' <expr> (8)(7) my ( $lhs, $rhs ) = ( $1, $3 ); handle_expressions( $lhs, $inside_config, $filename, $line_no ); handle_expressions( $rhs, $inside_config, $filename, $line_no ); } elsif ( $exprline =~ /^\s*!(.+)$/ ) { - # '!' <expr> (5) + # '!' <expr> (6) handle_expressions( $1, $inside_config, $filename, $line_no ); } elsif ( $exprline =~ /^\s*$parens\s*$/ ) { - # '(' <expr> ')' (4) + # '(' <expr> ')' (5) $exprline =~ /^\s*$(.*)$\s*$/; handle_expressions( $1, $inside_config, $filename, $line_no ); } + elsif ( $exprline =~ /^\s*($quotes|[^"\s]+)\s*[<>]=?$strip$/ ) { + # <symbol> '<' <symbol>, <symbol> '<=' <symbol>, etc. (4) + my ( $lhs, $rhs ) = ( $1, $2 ); + handle_symbol( $lhs, $filename, $line_no ); + handle_symbol( $rhs, $filename, $line_no ); + } elsif ( $exprline =~ /^\s*($quotes|[^"\s]+)\s*!=$strip$/ ) { # <symbol> '!=' <symbol> (3) my ( $lhs, $rhs ) = ( $1, $2 ); -- To view, visit https://review.coreboot.org/c/coreboot/+/52068 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I640e5c3ee1485348f09fcb0b0d5035eb53a2c98e Gerrit-Change-Number: 52068 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: util/kconfig_lint: Turn handle_expressions() into a parser
by Nico Huber (Code Review) 02 Apr '21

02 Apr '21

Attention is currently required from: Martin Roth. Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/52067 ) Change subject: util/kconfig_lint: Turn handle_expressions() into a parser ...................................................................... util/kconfig_lint: Turn handle_expressions() into a parser I wished there was a way to do this in smaller steps, but with every line fixed an error somewhere else became visible. Here is a (probably incomplete) list of the issues: * Only one set of parentheses was supported. This is a hard to solve problem without a real parser (one solution is to use an recursive RE, see below). * The precedence order was wrong. Might have been adapted just to give a positive result for the arbitrary state of the tree. * Numbered match variables (e.g. $1, $2, etc.) are not local. Calling handle_expressions() recursively once with $1, then with $2, resulted in using the final $2 after the first recursive call (garbage, practically). Also, symbol and expression parsing was mixed, making things harder to follow. To remedy the issues: * Split handle_symbol() out. It is called with whitespace stripped, to keep the uglier REs in handle_expressions(). * Match balanced parentheses and quotes when splitting expressions. In this recursive RE /($(?:[^\($]++|(?-1))*\))/ the `(?-1)` references the outer-most group, thus the whole expression itself. So it matches a pair of parentheses with a mix of non-parentheses and the recursive rule itself inside. This allows us to: * Order the expression matches according to their precedence rules. Now we can match `<expr> '||' <expr>` first as we should and everything else falls into its place. * Remove the bail-out that silenced the undefined behavior. Change-Id: Ibc1be79adc07792f0721f0dc08b50422b6da88a9 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M util/lint/kconfig_lint 1 file changed, 58 insertions(+), 38 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/52067/1 diff --git a/util/lint/kconfig_lint b/util/lint/kconfig_lint index 43a3ca6..51cc226 100755 --- a/util/lint/kconfig_lint +++ b/util/lint/kconfig_lint @@ -947,57 +947,77 @@ } #------------------------------------------------------------------------------- -# handle_expressions - log which symbols are being used +# handle_symbol - log which symbols are being used +#------------------------------------------------------------------------------- +sub handle_symbol { + my ( $symbol, $filename, $line_no ) = @_; + + #filter constant symbols first + if ( $symbol =~ /^[yn]$/ ) { # constant y/n + return; + } + if ( $symbol =~ /^-?\d+$/ ) { # int values + return; + } + if ( $symbol =~ /^-?(?:0x)?\p{XDigit}+$/ ) { # hex values + return; + } + if ( $symbol =~ /^"[^"]*"$/ ) { # string values + return; + } + + if ( $symbol =~ /^([A-Za-z0-9_]+)$/ ) { # actual symbol + add_referenced_symbol( $1, $filename, $line_no, 'expression' ); + } + else { + show_error("Unrecognized expression: expected symbol, " + . "found '$symbol' in $filename line $line_no."); + } +} + +#------------------------------------------------------------------------------- +# handle_expressions - find symbols in expressions #------------------------------------------------------------------------------- sub handle_expressions { my ( $exprline, $inside_config, $filename, $line_no ) = @_; - return unless ($exprline); + my $strip = qr/\s*(.*[^\s]+)\s*/; - #filter constant symbols first - if ( $exprline =~ /^\s*"?([yn])"?\s*$/ ) { # constant y/n - return; - } - elsif ( $exprline =~ /^\s*"?((?:-)\d+)"?\s*$/ ) { # int values - return; - } - elsif ( $exprline =~ /^\s*"?((?:-)?(?:0x)?\p{XDigit})+"?\s*$/ ) { # hex values - return; - } - elsif ( $exprline =~ /^\s*("[^"]*")\s*$/ ) { # String values - return; - } - elsif ( $exprline =~ /^\s*([A-Za-z0-9_]+)\s*$/ ) { # <symbol> (1) - add_referenced_symbol( $1, $filename, $line_no, 'expression' ); - } - elsif ( $exprline =~ /^\s*!(.+)$/ ) { # '!' <expr> (5) + my $parens = qr/($(?:[^\($]++|(?-1))*\))/; + my $quotes = qr/"[^"]*"/; + my $balanced = qr/((?:$parens|$quotes|[^"])+)/; + if ( $exprline =~ /^\s*$balanced\s*(?:\|\||&&)\s*(.+)$/ ) { + # <expr> '||' <expr>, <expr> '&&' <expr> (7)(6) + my ( $lhs, $rhs ) = ( $1, $3 ); + handle_expressions( $lhs, $inside_config, $filename, $line_no ); + handle_expressions( $rhs, $inside_config, $filename, $line_no ); + } + elsif ( $exprline =~ /^\s*!(.+)$/ ) { + # '!' <expr> (5) handle_expressions( $1, $inside_config, $filename, $line_no ); } - elsif ( $exprline =~ /^\s*$([^)]+)$\s*$/ ) { # '(' <expr> ')' (4) + elsif ( $exprline =~ /^\s*$parens\s*$/ ) { + # '(' <expr> ')' (4) + $exprline =~ /^\s*$(.*)$\s*$/; handle_expressions( $1, $inside_config, $filename, $line_no ); } - elsif ( $exprline =~ /^\s*(.+)\s*!=\s*(.+)\s*$/ ) { # <symbol> '!=' <symbol> (3) - handle_expressions( $1, $inside_config, $filename, $line_no ); - handle_expressions( $2, $inside_config, $filename, $line_no ); + elsif ( $exprline =~ /^\s*($quotes|[^"\s]+)\s*!=$strip$/ ) { + # <symbol> '!=' <symbol> (3) + my ( $lhs, $rhs ) = ( $1, $2 ); + handle_symbol( $lhs, $filename, $line_no ); + handle_symbol( $rhs, $filename, $line_no ); } - elsif ( $exprline =~ /^\s*(.+)\s*=\s*(.+)\s*$/ ) { # <symbol> '=' <symbol> (2) - handle_expressions( $1, $inside_config, $filename, $line_no ); - handle_expressions( $2, $inside_config, $filename, $line_no ); + elsif ( $exprline =~ /^\s*($quotes|[^"\s]+)\s*=$strip$/ ) { + # <symbol> '=' <symbol> (2) + my ( $lhs, $rhs ) = ( $1, $2 ); + handle_symbol( $lhs, $filename, $line_no ); + handle_symbol( $rhs, $filename, $line_no ); } - elsif ( $exprline =~ /^\s*([^(]+|$.+$)\s*&&\s*(.+)\s*$/ ) { # <expr> '&&' <expr> (6) - handle_expressions( $1, $inside_config, $filename, $line_no ); - handle_expressions( $2, $inside_config, $filename, $line_no ); + elsif ( $exprline =~ /^$strip$/ ) { + # <symbol> (1) + handle_symbol( $1, $filename, $line_no ); } - elsif ( $exprline =~ /^\s*([^(]+|$.+$)\s*\|\|\s*(.+)\s*$/ ) { # <expr> '||' <expr> (7) - handle_expressions( $1, $inside_config, $filename, $line_no ); - handle_expressions( $2, $inside_config, $filename, $line_no ); - } - else { - show_error("Unrecognized expression '$exprline' in $filename line $line_no."); - } - - return; } #------------------------------------------------------------------------------- -- To view, visit https://review.coreboot.org/c/coreboot/+/52067 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibc1be79adc07792f0721f0dc08b50422b6da88a9 Gerrit-Change-Number: 52067 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: util/kconfig_lint: Drop exception for paths without quotes
by Nico Huber (Code Review) 02 Apr '21

02 Apr '21

Attention is currently required from: Martin Roth. Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/52066 ) Change subject: util/kconfig_lint: Drop exception for paths without quotes ...................................................................... util/kconfig_lint: Drop exception for paths without quotes The tree is clean at the moment. Change-Id: I1be3b6c2f3b54b5c10ad3d5c6f0a6fd7e490c6bc Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M util/lint/kconfig_lint 1 file changed, 0 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/52066/1 diff --git a/util/lint/kconfig_lint b/util/lint/kconfig_lint index 2341976..43a3ca6 100755 --- a/util/lint/kconfig_lint +++ b/util/lint/kconfig_lint @@ -993,11 +993,6 @@ handle_expressions( $1, $inside_config, $filename, $line_no ); handle_expressions( $2, $inside_config, $filename, $line_no ); } - - # work around kconfig spec violation for now - paths not in quotes - elsif ( $exprline =~ /^\s*([A-Za-z0-9_\-\/]+)\s*$/ ) { # <symbol> (1) - return; - } else { show_error("Unrecognized expression '$exprline' in $filename line $line_no."); } -- To view, visit https://review.coreboot.org/c/coreboot/+/52066 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1be3b6c2f3b54b5c10ad3d5c6f0a6fd7e490c6bc Gerrit-Change-Number: 52066 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/msi/h81m-p33: Put MAINBOARD_DIR in double quotes
by Nico Huber (Code Review) 02 Apr '21

02 Apr '21

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/52065 ) Change subject: mb/msi/h81m-p33: Put MAINBOARD_DIR in double quotes ...................................................................... mb/msi/h81m-p33: Put MAINBOARD_DIR in double quotes Change-Id: I73160985c025cb0945a4ac16c8c3ebb988d3858f Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M src/mainboard/msi/h81m-p33/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/52065/1 diff --git a/src/mainboard/msi/h81m-p33/Kconfig b/src/mainboard/msi/h81m-p33/Kconfig index 185c340..de21a55 100644 --- a/src/mainboard/msi/h81m-p33/Kconfig +++ b/src/mainboard/msi/h81m-p33/Kconfig @@ -17,7 +17,7 @@ config MAINBOARD_DIR string - default msi/h81m-p33 + default "msi/h81m-p33" config MAINBOARD_PART_NUMBER string -- To view, visit https://review.coreboot.org/c/coreboot/+/52065 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I73160985c025cb0945a4ac16c8c3ebb988d3858f Gerrit-Change-Number: 52065 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/amd: Make espi_clear_decodes private
by Raul Rangel (Code Review) 02 Apr '21

02 Apr '21

Attention is currently required from: Jason Glenesk, Marshall Dawson, Felix Held. Raul Rangel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/52064 ) Change subject: soc/amd: Make espi_clear_decodes private ...................................................................... soc/amd: Make espi_clear_decodes private espi_setup already clears most of the controller registers. So this change consolidates the clear logic into one spot. BUG=b:183524609 TEST=Boot guybrush to the OS Signed-off-by: Raul E Rangel <rrangel(a)chromium.org> Change-Id: Ic57689e50febd29796d8ac8d99c81e41fee5b41c --- M src/soc/amd/cezanne/early_fch.c M src/soc/amd/common/block/include/amdblocks/espi.h M src/soc/amd/common/block/lpc/espi_util.c 3 files changed, 3 insertions(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/52064/1 diff --git a/src/soc/amd/cezanne/early_fch.c b/src/soc/amd/cezanne/early_fch.c index 0e351a9..5dca211 100644 --- a/src/soc/amd/cezanne/early_fch.c +++ b/src/soc/amd/cezanne/early_fch.c @@ -67,8 +67,6 @@ if (CONFIG(DISABLE_SPI_FLASH_ROM_SHARING)) lpc_disable_spi_rom_sharing(); - if (CONFIG(SOC_AMD_COMMON_BLOCK_USE_ESPI)) { - espi_clear_decodes(); + if (CONFIG(SOC_AMD_COMMON_BLOCK_USE_ESPI)) espi_setup(); - } } diff --git a/src/soc/amd/common/block/include/amdblocks/espi.h b/src/soc/amd/common/block/include/amdblocks/espi.h index f5e7d31..435b81f 100644 --- a/src/soc/amd/common/block/include/amdblocks/espi.h +++ b/src/soc/amd/common/block/include/amdblocks/espi.h @@ -101,13 +101,6 @@ int espi_open_mmio_window(uint32_t base, size_t size); /* - * Clear all configured eSPI memory and I/O decode ranges. This is useful for changing - * the decodes, or if something else has previously setup decode windows that conflict - * with the windows that coreboot needs. - */ -void espi_clear_decodes(void); - -/* * In cases where eSPI BAR is statically provided by SoC, use that BAR instead of reading * SPIBASE. This is required for cases where verstage runs on PSP. */ diff --git a/src/soc/amd/common/block/lpc/espi_util.c b/src/soc/amd/common/block/lpc/espi_util.c index 0b690b8..f120082 100644 --- a/src/soc/amd/common/block/lpc/espi_util.c +++ b/src/soc/amd/common/block/lpc/espi_util.c @@ -98,7 +98,7 @@ return -1; } -void espi_clear_decodes(void) +static void espi_clear_decodes(void) { unsigned int idx; @@ -894,6 +894,7 @@ espi_write32(ESPI_GLOBAL_CONTROL_1, ESPI_RGCMD_INT(23) | ESPI_ERR_INT_SMI); espi_write32(ESPI_SLAVE0_INT_EN, 0); espi_clear_status(); + espi_clear_decodes(); /* * Boot sequence: Step 1 -- To view, visit https://review.coreboot.org/c/coreboot/+/52064 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic57689e50febd29796d8ac8d99c81e41fee5b41c Gerrit-Change-Number: 52064 Gerrit-PatchSet: 1 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/amd: Make espi_configure_decodes private
by Raul Rangel (Code Review) 02 Apr '21

02 Apr '21

Attention is currently required from: Jason Glenesk, Marshall Dawson, Felix Held. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52059 ) Change subject: soc/amd: Make espi_configure_decodes private ...................................................................... Patch Set 5: (1 comment) File src/soc/amd/common/block/lpc/espi_util.c: https://review.coreboot.org/c/coreboot/+/52059/comment/68b4175e_56058f9f PS4, Line 301: void Made this return an error code since it can fail. -- To view, visit https://review.coreboot.org/c/coreboot/+/52059 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I074e487d8768a578ee889a125b9948e3aa6c7269 Gerrit-Change-Number: 52059 Gerrit-PatchSet: 5 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 02 Apr 2021 20:05:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd: Make espi_configure_decodes private
by Raul Rangel (Code Review) 02 Apr '21

02 Apr '21

Attention is currently required from: Jason Glenesk, Marshall Dawson, Felix Held. Hello build bot (Jenkins), Jason Glenesk, Furquan Shaikh, Marshall Dawson, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/52059 to look at the new patch set (#5). Change subject: soc/amd: Make espi_configure_decodes private ...................................................................... soc/amd: Make espi_configure_decodes private This is only ever called after espi_setup. 55861 - AMD System Peripheral Bus Overview also says that io ranges should be configured before enabling the BUS_MASTER bit. BUG=b:183524609 TEST=Boot guybrush to OS Signed-off-by: Raul E Rangel <rrangel(a)chromium.org> Change-Id: I074e487d8768a578ee889a125b9948e3aa6c7269 --- M src/soc/amd/cezanne/early_fch.c M src/soc/amd/common/block/include/amdblocks/espi.h M src/soc/amd/common/block/lpc/espi_util.c M src/soc/amd/picasso/early_fch.c M src/soc/amd/picasso/psp_verstage/fch.c 5 files changed, 15 insertions(+), 18 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/52059/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/52059 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I074e487d8768a578ee889a125b9948e3aa6c7269 Gerrit-Change-Number: 52059 Gerrit-PatchSet: 5 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/amd/common/espi: Reset eSPI registers to known state
by Raul Rangel (Code Review) 02 Apr '21

02 Apr '21

Attention is currently required from: Jason Glenesk, Marshall Dawson, Felix Held. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52058 ) Change subject: soc/amd/common/espi: Reset eSPI registers to known state ...................................................................... Patch Set 5: (1 comment) File src/soc/amd/common/block/lpc/espi_util.c: https://review.coreboot.org/c/coreboot/+/52058/comment/2659b131_79ee77a1 PS4, Line 891: espi_write32(ESPI_SLAVE0_INT_STS, 0xFFFFFFFF); I switched this to use `espi_clear_status`. -- To view, visit https://review.coreboot.org/c/coreboot/+/52058 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic3a9860747aac78121358b4499d8a38052236c0c Gerrit-Change-Number: 52058 Gerrit-PatchSet: 5 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 02 Apr 2021 20:05:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2021