coreboot-gerrit April 2021

coreboot-gerrit@coreboot.org

1 participants
6269 discussions

Change in coreboot[master]: soc/amd/common/espi: Reset eSPI registers to known state
by Furquan Shaikh (Code Review) 02 Apr '21

02 Apr '21

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Felix Held. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52058 ) Change subject: soc/amd/common/espi: Reset eSPI registers to known state ...................................................................... Patch Set 5: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/52058/comment/42dd70c6_461cf312 PS2, Line 9: This sets the eSPI registers to the reset values specified in the PPR. : : On Cezanne, the PSP modifies these registers such that the eSPI > The PSP writes port 80s to signal where it in the boot processes. i.e. […] Ack. -- To view, visit https://review.coreboot.org/c/coreboot/+/52058 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic3a9860747aac78121358b4499d8a38052236c0c Gerrit-Change-Number: 52058 Gerrit-PatchSet: 5 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 02 Apr 2021 20:49:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org> Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/intel/adlrvp: Update VBT filenames
by Tim Wawrzynczak (Code Review) 02 Apr '21

02 Apr '21

Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/52032 ) Change subject: mb/intel/adlrvp: Update VBT filenames ...................................................................... mb/intel/adlrvp: Update VBT filenames These files were just renamed to put `adlrvp` in between `vbt` and the memory technology type. Change-Id: Icefbac462d0ec9c660541e9cf44686d6dcf82dfd Signed-off-by: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Reviewed-on: https://review.coreboot.org/c/coreboot/+/52032 Reviewed-by: Furquan Shaikh <furquan(a)google.com> Reviewed-by: YH Lin <yueherngl(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/intel/adlrvp/mainboard.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved YH Lin: Looks good to me, but someone else must approve diff --git a/src/mainboard/intel/adlrvp/mainboard.c b/src/mainboard/intel/adlrvp/mainboard.c index 3946204..0ab80d2 100644 --- a/src/mainboard/intel/adlrvp/mainboard.c +++ b/src/mainboard/intel/adlrvp/mainboard.c @@ -46,9 +46,9 @@ switch (sku_id) { case ADL_P_LP5_1: case ADL_P_LP5_2: - return "vbt_lp5.bin"; + return "vbt_adlrvp_lp5.bin"; case ADL_P_DDR5: - return "vbt_ddr5.bin"; + return "vbt_adlrvp_ddr5.bin"; default: return "vbt.bin"; } -- To view, visit https://review.coreboot.org/c/coreboot/+/52032 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icefbac462d0ec9c660541e9cf44686d6dcf82dfd Gerrit-Change-Number: 52032 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Spoorthi K <spoorthi.k(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: soc/amd: Make espi_configure_decodes private
by Furquan Shaikh (Code Review) 02 Apr '21

02 Apr '21

1 0

Change in coreboot[master]: soc/amd: Make espi_clear_decodes private
by Furquan Shaikh (Code Review) 02 Apr '21

02 Apr '21

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Felix Held. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52064 ) Change subject: soc/amd: Make espi_clear_decodes private ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/52064/comment/146f2207_f4c074a3 PS1, Line 10: change consolidates the clear logic into one spot. I think it would be good to mention here that this changes the behavior for Picasso since the decodes weren't cleared before. But, that shouldn't really have any impact as decodes are again set up as per the mainboard configuration. Just thinking out loud: * In case where verstage runs on PSP, verstage clears eSPI decodes and sets up as per mainboard configuration. Once PSP is done, x86 will clear decodes and reconfigure as per mainboard configuration. * In case where verstage does not run on PSP, x86 will clear decodes and reconfigure as per mainboard configuration. In both cases, the corresponding first stage on the PSP/x86 sets things up correctly before using it. -- To view, visit https://review.coreboot.org/c/coreboot/+/52064 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic57689e50febd29796d8ac8d99c81e41fee5b41c Gerrit-Change-Number: 52064 Gerrit-PatchSet: 1 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 02 Apr 2021 20:45:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in em100[master]: Clean up after SIGHUP
by Angel Pons (Code Review) 02 Apr '21

02 Apr '21

Attention is currently required from: Stefan Reinauer. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/em100/+/51346 ) Change subject: Clean up after SIGHUP ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/em100/+/51346 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: em100 Gerrit-Branch: master Gerrit-Change-Id: I3788a78dd68836e96d91f6c3dccefd4d070aeb05 Gerrit-Change-Number: 51346 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Fri, 02 Apr 2021 20:30:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: device/Kconfig: Adapt PCIEXP_HOTPLUG_BUSES
by Angel Pons (Code Review) 02 Apr '21

02 Apr '21

Attention is currently required from: Nico Huber. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52069 ) Change subject: device/Kconfig: Adapt PCIEXP_HOTPLUG_BUSES ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/52069/comment/4c400153_d0e377e2 PS1, Line 15: limitted typo: only one `t` in `limited` -- To view, visit https://review.coreboot.org/c/coreboot/+/52069 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I06d522dd92ceea9f4798273b26f947a5333800c3 Gerrit-Change-Number: 52069 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Fri, 02 Apr 2021 20:16:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: device/Kconfig: Adapt PCIEXP_HOTPLUG_BUSES
by Angel Pons (Code Review) 02 Apr '21

02 Apr '21

Attention is currently required from: Nico Huber. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52069 ) Change subject: device/Kconfig: Adapt PCIEXP_HOTPLUG_BUSES ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Commit Message: PS1: Was said on IRC: > don't merge this without the parent commits This is because the linter will complain otherwise. Leaving this comment unresolved to avoid out-of-order submission. -- To view, visit https://review.coreboot.org/c/coreboot/+/52069 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I06d522dd92ceea9f4798273b26f947a5333800c3 Gerrit-Change-Number: 52069 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Fri, 02 Apr 2021 20:15:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/kconfig_lint: Update handle_expressions()
by Angel Pons (Code Review) 02 Apr '21

02 Apr '21

Attention is currently required from: Nico Huber, Martin Roth. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52068 ) Change subject: util/kconfig_lint: Update handle_expressions() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/52068 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I640e5c3ee1485348f09fcb0b0d5035eb53a2c98e Gerrit-Change-Number: 52068 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Comment-Date: Fri, 02 Apr 2021 20:12:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/kconfig_lint: Turn handle_expressions() into a parser
by Angel Pons (Code Review) 02 Apr '21

02 Apr '21

Attention is currently required from: Nico Huber, Martin Roth. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52067 ) Change subject: util/kconfig_lint: Turn handle_expressions() into a parser ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/52067 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibc1be79adc07792f0721f0dc08b50422b6da88a9 Gerrit-Change-Number: 52067 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Comment-Date: Fri, 02 Apr 2021 20:12:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/kconfig_lint: Drop exception for paths without quotes
by Angel Pons (Code Review) 02 Apr '21

02 Apr '21

Attention is currently required from: Nico Huber, Martin Roth. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52066 ) Change subject: util/kconfig_lint: Drop exception for paths without quotes ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/52066 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1be3b6c2f3b54b5c10ad3d5c6f0a6fd7e490c6bc Gerrit-Change-Number: 52066 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Comment-Date: Fri, 02 Apr 2021 20:10:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2021