coreboot-gerrit April 2021

coreboot-gerrit@coreboot.org

1 participants
6269 discussions

Change in coreboot[master]: mb/lenovo/t420: Copy HDA verbs from vendor firmware
by build bot (Jenkins) (Code Review) 03 Apr '21

03 Apr '21

Attention is currently required from: Nico Huber, Peter Lemenkov, Paul Menzel, Patrick Rudolph. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51612 ) Change subject: mb/lenovo/t420: Copy HDA verbs from vendor firmware ...................................................................... Patch Set 5: (15 comments) File src/mainboard/lenovo/t420/hda_verb.c: https://review.coreboot.org/c/coreboot/+/51612/comment/f36acf41_876e851d PS5, Line 39: /* --- Codec #3 --- */ code indent should use tabs where possible https://review.coreboot.org/c/coreboot/+/51612/comment/b73408b8_df571b1b PS5, Line 40: 0x80862805, /* Codec Vendor / Device ID: Intel PantherPoint HDMI */ code indent should use tabs where possible https://review.coreboot.org/c/coreboot/+/51612/comment/9e317118_9327ffd1 PS5, Line 40: 0x80862805, /* Codec Vendor / Device ID: Intel PantherPoint HDMI */ please, no spaces at the start of a line https://review.coreboot.org/c/coreboot/+/51612/comment/a38240c0_9b1b63b7 PS5, Line 41: 0x80860101, /* Subsystem ID */ code indent should use tabs where possible https://review.coreboot.org/c/coreboot/+/51612/comment/51077134_0a7e5a58 PS5, Line 41: 0x80860101, /* Subsystem ID */ please, no spaces at the start of a line https://review.coreboot.org/c/coreboot/+/51612/comment/4c54ce97_0004fcdd PS5, Line 42: 4, /* Number of 4 dword sets */ code indent should use tabs where possible https://review.coreboot.org/c/coreboot/+/51612/comment/e4e4357b_185e4cc6 PS5, Line 42: 4, /* Number of 4 dword sets */ please, no spaces at the start of a line https://review.coreboot.org/c/coreboot/+/51612/comment/2d89e72e_29e4d2d8 PS5, Line 43: AZALIA_SUBVENDOR(3, 0x80860101), code indent should use tabs where possible https://review.coreboot.org/c/coreboot/+/51612/comment/c78e295a_214660c6 PS5, Line 43: AZALIA_SUBVENDOR(3, 0x80860101), please, no spaces at the start of a line https://review.coreboot.org/c/coreboot/+/51612/comment/a1ee267d_13373d5f PS5, Line 44: AZALIA_PIN_CFG(3, 0x05, 0x18560010), code indent should use tabs where possible https://review.coreboot.org/c/coreboot/+/51612/comment/a9b21653_12a87651 PS5, Line 44: AZALIA_PIN_CFG(3, 0x05, 0x18560010), please, no spaces at the start of a line https://review.coreboot.org/c/coreboot/+/51612/comment/1f33940e_58507dd3 PS5, Line 45: AZALIA_PIN_CFG(3, 0x06, 0x18560020), code indent should use tabs where possible https://review.coreboot.org/c/coreboot/+/51612/comment/e83135fb_0779669f PS5, Line 45: AZALIA_PIN_CFG(3, 0x06, 0x18560020), please, no spaces at the start of a line https://review.coreboot.org/c/coreboot/+/51612/comment/11574eb5_9d3a23ab PS5, Line 46: AZALIA_PIN_CFG(3, 0x07, 0x18560030), code indent should use tabs where possible https://review.coreboot.org/c/coreboot/+/51612/comment/f36e19aa_7a7cb4a7 PS5, Line 46: AZALIA_PIN_CFG(3, 0x07, 0x18560030), please, no spaces at the start of a line -- To view, visit https://review.coreboot.org/c/coreboot/+/51612 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie5eba84e5ea590b7db00e189cd68e714bee7e410 Gerrit-Change-Number: 51612 Gerrit-PatchSet: 5 Gerrit-Owner: szarpaj(a)grubelek.pl Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sat, 03 Apr 2021 21:53:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/lenovo/t420: Copy HDA verbs from vendor firmware
by Name of user not set (Code Review) 03 Apr '21

03 Apr '21

Attention is currently required from: szarpaj(a)grubelek.pl, Nico Huber, Peter Lemenkov, Paul Menzel, Patrick Rudolph. Hello build bot (Jenkins), Nico Huber, Peter Lemenkov, Angel Pons, Alexander Couzens, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/51612 to look at the new patch set (#5). Change subject: mb/lenovo/t420: Copy HDA verbs from vendor firmware ...................................................................... mb/lenovo/t420: Copy HDA verbs from vendor firmware Background story (I think that's what great in opensource - ppl leave there part of their lives): ;-) While trying to fix audio jack not working with coreboot and Windows 10 with some help from hell__ and nico_h on IRC nico_h discovered that t420 and t430 hda_verb.c are the same: <nico_h> oddly, in coreboot source T420 and T430 have the same numbers for very different codecs... I suspect copy-pasta Difference between /sys/class/sound/cardX/hwCXDY/init_pin_config in vendor BIOS helped with the updated config. Connecting audio jack now works flawless both in Linux and Windows. Audio-related keyboard buttons: volup, voldown, mute works fine both in Linux (Debian-based) and Windows 10. mutemic button works (tested ie. with xev) but both in Linux and Windows 10 wont light up or makes any effect. +-----------------------------------+ | init_pin_config dump from: | +----= VENDOR =---+---= coreboot =--+ | 0x19 0x04211040 | 0x19 0x04211040 | | 0x1a 0x61a19050 | 0x1a 0x61a19050 | | 0x1b 0x04a11060 | 0x1b 0x04a11060 | | 0x1c 0x6121401f | 0x1c 0x6121401f | | 0x1d 0x40f001f0 | 0x1d 0x40f001f0 | | 0x1e 0x40f001f0 | 0x1e 0x40f001f0 | | 0x1f 0x90170110 | 0x1f 0x90170110 | | 0x20 0x40f001f0 | 0x20 0x40f001f0 | | 0x22 0x40f001f0 | 0x22 0x40f001f0 | | 0x23 0x90a60170 | 0x23 0x90a60170 | +-----------------+-----------------+ Tested-by: Piotr Szymaniak Signed-off-by: Piotr Szymaniak <szarpaj(a)grubelek.pl> Change-Id: Ie5eba84e5ea590b7db00e189cd68e714bee7e410 --- M src/mainboard/lenovo/t420/hda_verb.c 1 file changed, 20 insertions(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/51612/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/51612 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie5eba84e5ea590b7db00e189cd68e714bee7e410 Gerrit-Change-Number: 51612 Gerrit-PatchSet: 5 Gerrit-Owner: szarpaj(a)grubelek.pl Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: szarpaj(a)grubelek.pl Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: spd.h: Move `DIMMx` macros to i440bx/raminit.h
by Angel Pons (Code Review) 03 Apr '21

03 Apr '21

Attention is currently required from: Nico Huber, Arthur Heymans, Michael Niewöhner, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52061 ) Change subject: spd.h: Move `DIMMx` macros to i440bx/raminit.h ...................................................................... Patch Set 2: (1 comment) File src/northbridge/intel/i440bx/raminit.h: https://review.coreboot.org/c/coreboot/+/52061/comment/cb44b27d_70df40f8 PS2, Line 9: /* DIMM SPD addresses */ : #define DIMM0 0x50 : > are dimm addresses common or controller/platform specific? if common, what about defining them at a […] They're mainboard-specific -- To view, visit https://review.coreboot.org/c/coreboot/+/52061 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie8d14849b4fb86d34a841d4a13ee3bbb46f9f71c Gerrit-Change-Number: 52061 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sat, 03 Apr 2021 20:33:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: nb/intel/i945/raminit.c: Replace `DIMM0`
by Angel Pons (Code Review) 03 Apr '21

03 Apr '21

Attention is currently required from: Nico Huber, Arthur Heymans, Michael Niewöhner, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52073 ) Change subject: nb/intel/i945/raminit.c: Replace `DIMM0` ...................................................................... Patch Set 1: (1 comment) File src/northbridge/intel/i945/raminit.c: https://review.coreboot.org/c/coreboot/+/52073/comment/e31a2fa7_f6bfc467 PS1, Line 48: 0x50 > hm, is that really "more informative"? I'd keep DIMM0 There's no rule saying that SPD index 0x50 is DIMM0. On BTX mainboards, DIMM0's SPD is often at address 0x53. -- To view, visit https://review.coreboot.org/c/coreboot/+/52073 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id3bd8ccdf79d1e3fdf97cda049f81271bb017ef7 Gerrit-Change-Number: 52073 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sat, 03 Apr 2021 20:32:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: nb/intel/i945: Refactor `dump_spd_registers` function
by Angel Pons (Code Review) 03 Apr '21

03 Apr '21

Attention is currently required from: Nico Huber, Stefan Reinauer, Arthur Heymans, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51899 ) Change subject: nb/intel/i945: Refactor `dump_spd_registers` function ...................................................................... Patch Set 4: (1 comment) File src/northbridge/intel/i945/debug.c: https://review.coreboot.org/c/coreboot/+/51899/comment/1f06d9d4_6e762b96 PS4, Line 63: const unsigned int device = spd_map[d]; > nit: needed? I didn't want to replace all instances of `device` with the more-cryptic `spd_map[d]` -- To view, visit https://review.coreboot.org/c/coreboot/+/51899 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2b5b71cff290343c1000d5613209049fa9724e3d Gerrit-Change-Number: 51899 Gerrit-PatchSet: 4 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sat, 03 Apr 2021 20:31:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: docs/mb/supermicro: add SUM tool for flashing with disabled ME
by Michael Niewöhner (Code Review) 03 Apr '21

03 Apr '21

Michael Niewöhner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/49887 ) Change subject: docs/mb/supermicro: add SUM tool for flashing with disabled ME ...................................................................... docs/mb/supermicro: add SUM tool for flashing with disabled ME Change-Id: I08543c0908a6cb4ef9fb46d0eb3a7aa481fb95d9 Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de> Reviewed-on: https://review.coreboot.org/c/coreboot/+/49887 Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M Documentation/mainboard/supermicro/flashing_on_vendorbmc.md 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved diff --git a/Documentation/mainboard/supermicro/flashing_on_vendorbmc.md b/Documentation/mainboard/supermicro/flashing_on_vendorbmc.md index e02c57b..c831302 100644 --- a/Documentation/mainboard/supermicro/flashing_on_vendorbmc.md +++ b/Documentation/mainboard/supermicro/flashing_on_vendorbmc.md @@ -30,3 +30,15 @@ Make sure that the ME isn't in recovery mode, otherwise you get an error message on updating the BIOS. + +## Flashing with disabled ME + +If ME is disabled via `me_cleaner` or the ME recovery jumper, it is still +possible to flash remotely with the [`Supermicro Update Manager`](SUM) (`SUM`). + +```sh +./sum -i <remote BMC IP> -u <user> -p <password> -c UpdateBios --reboot \ + --force_update --file build/coreboot.rom +``` + +[SUM]: https://www.supermicro.com/SwDownload/SwSelect_Free.aspx?cat=SUM -- To view, visit https://review.coreboot.org/c/coreboot/+/49887 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I08543c0908a6cb4ef9fb46d0eb3a7aa481fb95d9 Gerrit-Change-Number: 49887 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: drivers/intel/fsp1_1: Drop dead MMA code
by Michael Niewöhner (Code Review) 03 Apr '21

03 Apr '21

Attention is currently required from: Nico Huber, Martin Roth, Lee Leahy, Angel Pons, Huang Jin, Patrick Rudolph. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51951 ) Change subject: drivers/intel/fsp1_1: Drop dead MMA code ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/51951 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I819c3152bdea0fdad629793d96136ef134429fbd Gerrit-Change-Number: 51951 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Huang Jin <huang.jin(a)intel.com> Gerrit-Reviewer: Lee Leahy <leroy.p.leahy(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Lee Leahy <leroy.p.leahy(a)intel.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Huang Jin <huang.jin(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sat, 03 Apr 2021 20:25:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: nb/intel/sandybridge: Rename `pdwm_mode` enum
by Michael Niewöhner (Code Review) 03 Apr '21

03 Apr '21

Attention is currently required from: Nico Huber, Angel Pons, Arthur Heymans, Patrick Rudolph. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51901 ) Change subject: nb/intel/sandybridge: Rename `pdwm_mode` enum ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/51901 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7b83c71d4534b62e18ced04eebe6a65089e1d874 Gerrit-Change-Number: 51901 Gerrit-PatchSet: 5 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sat, 03 Apr 2021 20:22:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: spd.h: Move `DIMMx` macros to i440bx/raminit.h
by Michael Niewöhner (Code Review) 03 Apr '21

03 Apr '21

Attention is currently required from: Nico Huber, Angel Pons, Arthur Heymans, Patrick Rudolph. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52061 ) Change subject: spd.h: Move `DIMMx` macros to i440bx/raminit.h ...................................................................... Patch Set 2: (1 comment) File src/northbridge/intel/i440bx/raminit.h: https://review.coreboot.org/c/coreboot/+/52061/comment/68b635c6_5990db92 PS2, Line 9: /* DIMM SPD addresses */ : #define DIMM0 0x50 : are dimm addresses common or controller/platform specific? if common, what about defining them at a common place? -- To view, visit https://review.coreboot.org/c/coreboot/+/52061 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie8d14849b4fb86d34a841d4a13ee3bbb46f9f71c Gerrit-Change-Number: 52061 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sat, 03 Apr 2021 20:21:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: spd.h: Remove unused definitions
by Michael Niewöhner (Code Review) 03 Apr '21

03 Apr '21

Attention is currently required from: Nico Huber, Angel Pons, Arthur Heymans, Patrick Rudolph. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51900 ) Change subject: spd.h: Remove unused definitions ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/51900 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I40a824888701870b6713c1a16ab671c19b3770ae Gerrit-Change-Number: 51900 Gerrit-PatchSet: 5 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sat, 03 Apr 2021 20:20:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2021