coreboot-gerrit April 2021

coreboot-gerrit@coreboot.org

1 participants
6268 discussions

Change in coreboot[master]: soc/intel/jasperlake: Update CpuRatio settings
by Kaiyen Chang (Code Review) 04 Apr '21

04 Apr '21

Attention is currently required from: Kaiyen Chang, Patrick Rudolph. Hello build bot (Jenkins), Kaiyen Chang, Angel Pons, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/52029 to look at the new patch set (#4). Change subject: soc/intel/jasperlake: Update CpuRatio settings ...................................................................... soc/intel/jasperlake: Update CpuRatio settings An extra reset is observed on JSL platform while the flex ratio in CPU Straps is set to a non-zero value. The root cause is that the config of CpuRatio on JSL is fixed to zero in fsp_params.c. While FSP finds the value of CpuRatio from m_cfg is inconsistent with the value from CPU straps, it will invoke a system reset to apply the value from m_cfg. This change adds a mechanism to set CpuRatio to allowed maximum processor non-turbo ratio (from CPU Straps) when cpu_ratio_override is not set, or overriding CpuRatio with the value of cpu_ratio_override when cpu_ratio_override is set to a non-zero value instead of just fixing CpuRatio to zero. BUG=b:181588337 BRANCH=None TEST=Boot JSL platform with a non-zero flex ratio set in CPU Straps and observe there is no extra reset in meminit while cpu_ratio_override is not set. Change-Id: I20b9d5620b8e394201e82185eb28b67d6702b2d5 Signed-off-by: Kaiyen Chang <kaiyen.chang(a)intel.corp-partner.google.com> --- M src/soc/intel/jasperlake/romstage/fsp_params.c 1 file changed, 12 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/52029/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/52029 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I20b9d5620b8e394201e82185eb28b67d6702b2d5 Gerrit-Change-Number: 52029 Gerrit-PatchSet: 4 Gerrit-Owner: Kaiyen Chang <kaiyen.chang(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Kaiyen Chang <kaiyen.chang(a)intel.corp-partner.google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-CC: Kane Chen <kane.chen(a)intel.corp-partner.google.com> Gerrit-Attention: Kaiyen Chang <kaiyen.chang(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: timestamp: Add helper fucntions
by Furquan Shaikh (Code Review) 04 Apr '21

04 Apr '21

Attention is currently required from: Julius Werner, Angel Pons, Subrata Banik, Aaron Durbin. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51445 ) Change subject: timestamp: Add helper fucntions ...................................................................... Patch Set 3: (1 comment) File src/include/timestamp.h: https://review.coreboot.org/c/coreboot/+/51445/comment/15bdd1fd_af8bd35f PS3, Line 26: * Add a new raw timestamp in microseconds into timestamp_table at index 'n'. > This might be going a bit far, but what do we actually gain by keeping the timestamp table in TSC fr […] IIUC, the reason why x86 platforms store in TSC frequency is because the timestamp values are basically the raw values read by using `rdtsc` instruction. Thus, in the normal case, there is no need for conversion. If the values are to be stored in usecs, then for each timestamp_get() call, rdtsc value will have to be converted using TSC frequency. -- To view, visit https://review.coreboot.org/c/coreboot/+/51445 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6b7065ed26e231fc898ae44bcc15cba6fb42b308 Gerrit-Change-Number: 51445 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Comment-Date: Sun, 04 Apr 2021 04:01:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: timestamp: Add helper fucntions
by Furquan Shaikh (Code Review) 04 Apr '21

04 Apr '21

1 0

Change in coreboot[master]: timestamp: Add helper fucntions
by Furquan Shaikh (Code Review) 04 Apr '21

04 Apr '21

Attention is currently required from: Angel Pons, Subrata Banik, Aaron Durbin. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51445 ) Change subject: timestamp: Add helper fucntions ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/51445/comment/3ea25e95_66d80923 PS3, Line 7: Add helper fucntions I think we should add these helpers: // Rewind base_time in timestamp table using the delta provided in base_freq_mhz. // This function will perform the following steps: // 1. Calculate base_delta_tick in ts->tick_freq_mhz using base_delta * base_freq_mhz / ts->tick_freq_mhz. // 2. Update all entries in timestamp table by adding base_delta_tick // 3. Update ts->base_time as ts->base_time - base_delta_tick void timestamp_rewind_base(uint64_t base_delta, uint16_t base_freq_mhz); // Add a new entry to timestamp table using the time_from_base expressed in freq_mhz // This function will perform the following steps: // 1. Calculate time_from_base in ts->tick_freq_mhz using time_from_base * freq_mhz / ts->tick_freq_mhz // 2. Call timestamp_add_table_entry using ts_table, id, time_from_base_ticks void timestamp_add_time_from_base(enum timestamp_id id, uint64_t time_from_base, uint16_t freq_mhz); // Merge entries from provided table(new_table) into active timestamp table maintained by the library. The base_time in the provided table is expected to be the same as the active timestamp table. // This function will perform the following steps: // 1. Loop over each entry in provided table(new_table) and convert each entry from new_table->tick_freq_mhz to ts_table->tick_freq_mhz. // 2. Call timestamp_add_table_entry for each of these converted entries. void timestamp_merge(const struct timestamp_table *new_table); You can skip the last one for now if you want. It won't be required for your case, but I see some other users taking advantage of it. In follow-up CLs, what you will have to do is: // Use last timestamp from pre-x86 as equivalent to x86 being taken out of reset i.e. when TSC starts. So, base_time should be set to 0 (TSC start time) - ts[3] (last pre-x86 timestamp) // base_freq_mhz is 1000 since the base time is represented in ms. timestamp_rewind_base(0 - ts[3], 1000); // Add pre-x86 timestamps with freq_mhz as 1000. Assumption is that pre-x86 time starts from 0. So ts[*] contains time delta from base 0. timestamp_add_time_from_base(TS_ME_BOOT_STALL_DONE, ts[0], 1000); timestamp_add_time_from_base(TS_ME_ICC_CONFIG_START, ts[1], 1000); timestamp_add_time_from_base(TS_ME_HOST_BOOT_PREP_DONE, ts[2], 1000); timestamp_add_time_from_base(TS_ME_RECEIVED_CRDA_FROM_PMC, ts[3], 1000); -- To view, visit https://review.coreboot.org/c/coreboot/+/51445 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6b7065ed26e231fc898ae44bcc15cba6fb42b308 Gerrit-Change-Number: 51445 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Comment-Date: Sun, 04 Apr 2021 03:19:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/lenovo/t420: Copy HDA verbs from vendor firmware
by Angel Pons (Code Review) 03 Apr '21

03 Apr '21

Attention is currently required from: szarpaj(a)grubelek.pl, Nico Huber, Peter Lemenkov, Paul Menzel, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51612 ) Change subject: mb/lenovo/t420: Copy HDA verbs from vendor firmware ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/51612 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie5eba84e5ea590b7db00e189cd68e714bee7e410 Gerrit-Change-Number: 51612 Gerrit-PatchSet: 6 Gerrit-Owner: szarpaj(a)grubelek.pl Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: szarpaj(a)grubelek.pl Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sat, 03 Apr 2021 22:18:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/lenovo/t420: Copy HDA verbs from vendor firmware
by Name of user not set (Code Review) 03 Apr '21

03 Apr '21

Attention is currently required from: szarpaj(a)grubelek.pl, Nico Huber, Peter Lemenkov, Paul Menzel, Patrick Rudolph. Hello build bot (Jenkins), Nico Huber, Peter Lemenkov, Angel Pons, Alexander Couzens, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/51612 to look at the new patch set (#6). Change subject: mb/lenovo/t420: Copy HDA verbs from vendor firmware ...................................................................... mb/lenovo/t420: Copy HDA verbs from vendor firmware Background story (I think that's what great in opensource - ppl leave there part of their lives): ;-) While trying to fix audio jack not working with coreboot and Windows 10 with some help from hell__ and nico_h on IRC nico_h discovered that t420 and t430 hda_verb.c are the same: <nico_h> oddly, in coreboot source T420 and T430 have the same numbers for very different codecs... I suspect copy-pasta Difference between /sys/class/sound/cardX/hwCXDY/init_pin_config in vendor BIOS helped with the updated config. Connecting audio jack now works flawless both in Linux and Windows. Audio-related keyboard buttons: volup, voldown, mute works fine both in Linux (Debian-based) and Windows 10. mutemic button works (tested ie. with xev) but both in Linux and Windows 10 wont light up or makes any effect. +-----------------------------------+ | init_pin_config dump from: | +----= VENDOR =---+---= coreboot =--+ | 0x19 0x04211040 | 0x19 0x04211040 | | 0x1a 0x61a19050 | 0x1a 0x61a19050 | | 0x1b 0x04a11060 | 0x1b 0x04a11060 | | 0x1c 0x6121401f | 0x1c 0x6121401f | | 0x1d 0x40f001f0 | 0x1d 0x40f001f0 | | 0x1e 0x40f001f0 | 0x1e 0x40f001f0 | | 0x1f 0x90170110 | 0x1f 0x90170110 | | 0x20 0x40f001f0 | 0x20 0x40f001f0 | | 0x22 0x40f001f0 | 0x22 0x40f001f0 | | 0x23 0x90a60170 | 0x23 0x90a60170 | +-----------------+-----------------+ Tested-by: Piotr Szymaniak Signed-off-by: Piotr Szymaniak <szarpaj(a)grubelek.pl> Change-Id: Ie5eba84e5ea590b7db00e189cd68e714bee7e410 --- M src/mainboard/lenovo/t420/hda_verb.c 1 file changed, 20 insertions(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/51612/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/51612 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie5eba84e5ea590b7db00e189cd68e714bee7e410 Gerrit-Change-Number: 51612 Gerrit-PatchSet: 6 Gerrit-Owner: szarpaj(a)grubelek.pl Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: szarpaj(a)grubelek.pl Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: Docs/mb/lenovo/t420: List working, tested and non-working features
by Angel Pons (Code Review) 03 Apr '21

03 Apr '21

Attention is currently required from: szarpaj(a)grubelek.pl, Nico Huber. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51952 ) Change subject: Docs/mb/lenovo/t420: List working, tested and non-working features ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/51952 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6fb4a8da44125b4280d37d0cf7c372f8024fb2d1 Gerrit-Change-Number: 51952 Gerrit-PatchSet: 5 Gerrit-Owner: szarpaj(a)grubelek.pl Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: szarpaj(a)grubelek.pl Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Sat, 03 Apr 2021 22:06:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/lenovo/t420: Copy HDA verbs from vendor firmware
by Angel Pons (Code Review) 03 Apr '21

03 Apr '21

Attention is currently required from: szarpaj(a)grubelek.pl, Nico Huber, Peter Lemenkov, Paul Menzel, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51612 ) Change subject: mb/lenovo/t420: Copy HDA verbs from vendor firmware ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/51612 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie5eba84e5ea590b7db00e189cd68e714bee7e410 Gerrit-Change-Number: 51612 Gerrit-PatchSet: 5 Gerrit-Owner: szarpaj(a)grubelek.pl Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: szarpaj(a)grubelek.pl Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sat, 03 Apr 2021 22:05:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/lenovo/t420: Copy HDA verbs from vendor firmware
by Name of user not set (Code Review) 03 Apr '21

03 Apr '21

Attention is currently required from: Nico Huber, Peter Lemenkov, Paul Menzel, Patrick Rudolph. szarpaj(a)grubelek.pl has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51612 ) Change subject: mb/lenovo/t420: Copy HDA verbs from vendor firmware ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: With those changes (based on x220 hda_verbs.c, t420 vendor init_pin_config and testing) DisplayPort audio now works both under Windows 10 and Linux (Ubuntu). -- To view, visit https://review.coreboot.org/c/coreboot/+/51612 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie5eba84e5ea590b7db00e189cd68e714bee7e410 Gerrit-Change-Number: 51612 Gerrit-PatchSet: 5 Gerrit-Owner: szarpaj(a)grubelek.pl Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sat, 03 Apr 2021 21:57:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/lenovo/t420: Copy HDA verbs from vendor firmware
by build bot (Jenkins) (Code Review) 03 Apr '21

03 Apr '21

Attention is currently required from: Nico Huber, Peter Lemenkov, Paul Menzel, Patrick Rudolph. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51612 ) Change subject: mb/lenovo/t420: Copy HDA verbs from vendor firmware ...................................................................... Patch Set 5: (15 comments) File src/mainboard/lenovo/t420/hda_verb.c: https://review.coreboot.org/c/coreboot/+/51612/comment/f36acf41_876e851d PS5, Line 39: /* --- Codec #3 --- */ code indent should use tabs where possible https://review.coreboot.org/c/coreboot/+/51612/comment/b73408b8_df571b1b PS5, Line 40: 0x80862805, /* Codec Vendor / Device ID: Intel PantherPoint HDMI */ code indent should use tabs where possible https://review.coreboot.org/c/coreboot/+/51612/comment/9e317118_9327ffd1 PS5, Line 40: 0x80862805, /* Codec Vendor / Device ID: Intel PantherPoint HDMI */ please, no spaces at the start of a line https://review.coreboot.org/c/coreboot/+/51612/comment/a38240c0_9b1b63b7 PS5, Line 41: 0x80860101, /* Subsystem ID */ code indent should use tabs where possible https://review.coreboot.org/c/coreboot/+/51612/comment/51077134_0a7e5a58 PS5, Line 41: 0x80860101, /* Subsystem ID */ please, no spaces at the start of a line https://review.coreboot.org/c/coreboot/+/51612/comment/4c54ce97_0004fcdd PS5, Line 42: 4, /* Number of 4 dword sets */ code indent should use tabs where possible https://review.coreboot.org/c/coreboot/+/51612/comment/e4e4357b_185e4cc6 PS5, Line 42: 4, /* Number of 4 dword sets */ please, no spaces at the start of a line https://review.coreboot.org/c/coreboot/+/51612/comment/2d89e72e_29e4d2d8 PS5, Line 43: AZALIA_SUBVENDOR(3, 0x80860101), code indent should use tabs where possible https://review.coreboot.org/c/coreboot/+/51612/comment/c78e295a_214660c6 PS5, Line 43: AZALIA_SUBVENDOR(3, 0x80860101), please, no spaces at the start of a line https://review.coreboot.org/c/coreboot/+/51612/comment/a1ee267d_13373d5f PS5, Line 44: AZALIA_PIN_CFG(3, 0x05, 0x18560010), code indent should use tabs where possible https://review.coreboot.org/c/coreboot/+/51612/comment/a9b21653_12a87651 PS5, Line 44: AZALIA_PIN_CFG(3, 0x05, 0x18560010), please, no spaces at the start of a line https://review.coreboot.org/c/coreboot/+/51612/comment/1f33940e_58507dd3 PS5, Line 45: AZALIA_PIN_CFG(3, 0x06, 0x18560020), code indent should use tabs where possible https://review.coreboot.org/c/coreboot/+/51612/comment/e83135fb_0779669f PS5, Line 45: AZALIA_PIN_CFG(3, 0x06, 0x18560020), please, no spaces at the start of a line https://review.coreboot.org/c/coreboot/+/51612/comment/11574eb5_9d3a23ab PS5, Line 46: AZALIA_PIN_CFG(3, 0x07, 0x18560030), code indent should use tabs where possible https://review.coreboot.org/c/coreboot/+/51612/comment/f36e19aa_7a7cb4a7 PS5, Line 46: AZALIA_PIN_CFG(3, 0x07, 0x18560030), please, no spaces at the start of a line -- To view, visit https://review.coreboot.org/c/coreboot/+/51612 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie5eba84e5ea590b7db00e189cd68e714bee7e410 Gerrit-Change-Number: 51612 Gerrit-PatchSet: 5 Gerrit-Owner: szarpaj(a)grubelek.pl Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sat, 03 Apr 2021 21:53:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2021