Attention is currently required from: Furquan Shaikh, Henry Sun, SH Kim, Kyösti Mälkki, Edward Doan.
shkim has removed Paul Menzel from this change. ( https://review.coreboot.org/c/coreboot/+/51335 )
Change subject: mb/google/dedede/var/sasuke: Configure I2C times for touchpad/audio
......................................................................
Removed reviewer Paul Menzel.
--
To view, visit https://review.coreboot.org/c/coreboot/+/51335
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic92ee0379456e80260a8026bc38ee41325dad6d2
Gerrit-Change-Number: 51335
Gerrit-PatchSet: 3
Gerrit-Owner: shkim <sh_.kim(a)samsung.com>
Gerrit-Reviewer: Edward Doan <edoan(a)google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: SH Kim <sh_.kim(a)samsung.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: SH Kim <sh_.kim(a)samsung.corp-partner.google.com>
Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Attention: Edward Doan <edoan(a)google.com>
Gerrit-MessageType: deleteReviewer
Attention is currently required from: Furquan Shaikh, Henry Sun, SH Kim, Kyösti Mälkki, Edward Doan.
shkim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51335 )
Change subject: mb/google/dedede/var/sasuke: Configure I2C times for touchpad/audio
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
ping to submit
--
To view, visit https://review.coreboot.org/c/coreboot/+/51335
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic92ee0379456e80260a8026bc38ee41325dad6d2
Gerrit-Change-Number: 51335
Gerrit-PatchSet: 3
Gerrit-Owner: shkim <sh_.kim(a)samsung.com>
Gerrit-Reviewer: Edward Doan <edoan(a)google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: SH Kim <sh_.kim(a)samsung.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: SH Kim <sh_.kim(a)samsung.corp-partner.google.com>
Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Attention: Edward Doan <edoan(a)google.com>
Gerrit-Comment-Date: Mon, 05 Apr 2021 07:23:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Henry Sun, SH Kim.
shkim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51970 )
Change subject: mb/google/dedede/var/sasuke: Update DPTF parameters
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
ping to submit
--
To view, visit https://review.coreboot.org/c/coreboot/+/51970
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3182b96bf36c8d07299fe435a29e6b8c0b8a6927
Gerrit-Change-Number: 51970
Gerrit-PatchSet: 2
Gerrit-Owner: shkim <sh_.kim(a)samsung.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: SH Kim <sh_.kim(a)samsung.corp-partner.google.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: SH Kim <sh_.kim(a)samsung.corp-partner.google.com>
Gerrit-Comment-Date: Mon, 05 Apr 2021 07:20:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Wenbin Mei.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51966 )
Change subject: soc/mediatek: add new driver 'msdc' for eMMC
......................................................................
Patch Set 5:
(1 comment)
File src/soc/mediatek/common/msdc.c:
https://review.coreboot.org/c/coreboot/+/51966/comment/c2021df2_fbf14b33
PS5, Line 45: return MSDC_SUCCESS;
> I'd suggest using the timer API (timer.h): […]
Also see the wait_us() macro.
--
To view, visit https://review.coreboot.org/c/coreboot/+/51966
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I54a7749ed167c00cd631a76af7c67c654c7bc725
Gerrit-Change-Number: 51966
Gerrit-PatchSet: 5
Gerrit-Owner: Wenbin Mei <wenbin.mei(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com>
Gerrit-Reviewer: Yidi Lin <yidi.lin(a)mediatek.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Wenbin Mei <wenbin.mei(a)mediatek.corp-partner.google.com>
Gerrit-Comment-Date: Mon, 05 Apr 2021 03:16:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel, Wenbin Mei.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52014 )
Change subject: mb/google/asurada: select mmc storage config
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52014/comment/f9a6ab17_276134bc
PS3, Line 10: X
Please provide the number.
--
To view, visit https://review.coreboot.org/c/coreboot/+/52014
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iac656d57c2b834d1ce393fd991275b897e597b4b
Gerrit-Change-Number: 52014
Gerrit-PatchSet: 3
Gerrit-Owner: Wenbin Mei <wenbin.mei(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-CC: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Wenbin Mei <wenbin.mei(a)mediatek.corp-partner.google.com>
Gerrit-Comment-Date: Mon, 05 Apr 2021 03:14:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment