April 2021 - coreboot-gerrit - mail.coreboot.org

Change in coreboot[master]: soc/intel/skylake: Drop unnecessary `ignore_vtd` option
by Angel Pons (Code Review) April 5, 2021

April 5, 2021

Attention is currently required from: Michał Żygowski, Michael Niewöhner, Patrick Rudolph, Piotr Król. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52101 ) Change subject: soc/intel/skylake: Drop unnecessary `ignore_vtd` option ...................................................................... Patch Set 1: (1 comment) File src/soc/intel/skylake/systemagent.c: https://review.coreboot.org/c/coreboot/+/52101/comment/939eded6_f91eab13 PS1, Line 42: const struct soc_intel_skylake_config *const config = config_of(dev); > orphaned woups -- To view, visit https://review.coreboot.org/c/coreboot/+/52101 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I320c10317f3fabee5443c16ebdf1ffd0e24193b8 Gerrit-Change-Number: 52101 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Comment-Date: Mon, 05 Apr 2021 12:59:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel: Hook up `SOC_INTEL_DISABLE_IGD` to `InternalGfx` UPD
by Angel Pons (Code Review) April 5, 2021

April 5, 2021

Attention is currently required from: Nico Huber, Angel Pons, Subrata Banik, Arthur Heymans, Patrick Rudolph. Hello build bot (Jenkins), Nico Huber, Subrata Banik, Arthur Heymans, Michael Niewöhner, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/52100 to look at the new patch set (#2). Change subject: soc/intel: Hook up `SOC_INTEL_DISABLE_IGD` to `InternalGfx` UPD ...................................................................... soc/intel: Hook up `SOC_INTEL_DISABLE_IGD` to `InternalGfx` UPD Commit 0591348833f730a42e74039d8e2d957ec94a39d5 introduced this Kconfig option inside soc/intel/common scope. However, it was only hooked up in commit d74cd60b8159c3928dba318e6387f200ff3bb0e7 for Alder Lake, and in commit 99157c1f4a80556462ca22a4ade87b2c8d09e674 for Tiger Lake. Hook up the `SOC_INTEL_DISABLE_IGD` Kconfig option to all other platforms which have the `InternalGfx` UPD. Change-Id: Icd1379a835b445a6d4b028ebde5a3e355ee5b67b Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/soc/intel/cannonlake/romstage/fsp_params.c M src/soc/intel/icelake/romstage/fsp_params.c M src/soc/intel/jasperlake/romstage/fsp_params.c M src/soc/intel/skylake/romstage/fsp_params.c 4 files changed, 7 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/52100/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/52100 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icd1379a835b445a6d4b028ebde5a3e355ee5b67b Gerrit-Change-Number: 52100 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/skylake: Drop unnecessary `ignore_vtd` option
by Angel Pons (Code Review) April 5, 2021

April 5, 2021

Attention is currently required from: Michał Żygowski, Patrick Rudolph, Piotr Król. Hello build bot (Jenkins), Michał Żygowski, Michael Niewöhner, Patrick Rudolph, Piotr Król, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/52101 to look at the new patch set (#2). Change subject: soc/intel/skylake: Drop unnecessary `ignore_vtd` option ...................................................................... soc/intel/skylake: Drop unnecessary `ignore_vtd` option It is zero for all mainboards. If one really wanted to ignore VT-d support, a user-visible Kconfig option would be a better approach. Change-Id: I320c10317f3fabee5443c16ebdf1ffd0e24193b8 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/mainboard/protectli/vault_kbl/devicetree.cb M src/soc/intel/skylake/acpi.c M src/soc/intel/skylake/chip.c M src/soc/intel/skylake/chip.h M src/soc/intel/skylake/romstage/systemagent.c M src/soc/intel/skylake/systemagent.c 6 files changed, 3 insertions(+), 16 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/52101/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/52101 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I320c10317f3fabee5443c16ebdf1ffd0e24193b8 Gerrit-Change-Number: 52101 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/alderlake: Drop unreferenced `InternalGfx`
by Angel Pons (Code Review) April 5, 2021

April 5, 2021

Attention is currently required from: Michael Niewöhner, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52104 ) Change subject: soc/intel/alderlake: Drop unreferenced `InternalGfx` ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > did grep fail me? 😕 Uh, can you please point out the exact line you're referring to? Line 27 is ` PCH_PCIE_RP,` here. -- To view, visit https://review.coreboot.org/c/coreboot/+/52104 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie59de5399a9b1713109bf334d4ad1d7f7efb91f9 Gerrit-Change-Number: 52104 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Mon, 05 Apr 2021 12:55:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/skylake: Always use `CHIPSET_LOCKDOWN_COREBOOT`
by Angel Pons (Code Review) April 5, 2021

April 5, 2021

Attention is currently required from: Nico Huber, Michael Niewöhner, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52096 ) Change subject: soc/intel/skylake: Always use `CHIPSET_LOCKDOWN_COREBOOT` ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Uhm, this looks more like a hack than a real solution to me. […] I agree this isn't elegant. However, FSP lockdown is tied into soc/intel/common, so it's not like I can drop it in one patch. This change is a stopgap to prevent new boards from accidentally using CHIPSET_LOCKDOWN_FSP by omission. Another approach would be to invert the enum values for chipset lockdown to make CHIPSET_LOCKDOWN_COREBOOT the default value, but that also requires checking each and every board. I'll see what I can do. -- To view, visit https://review.coreboot.org/c/coreboot/+/52096 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I24a1a2fab166aa3bfe8e0b07f155f57f2bf745e3 Gerrit-Change-Number: 52096 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Mon, 05 Apr 2021 12:52:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/alderlake: Drop unreferenced `InternalGfx`
by Angel Pons (Code Review) April 5, 2021

April 5, 2021

Attention is currently required from: Michael Niewöhner, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52104 ) Change subject: soc/intel/alderlake: Drop unreferenced `InternalGfx` ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: > meh. […] did grep fail me? 😕 -- To view, visit https://review.coreboot.org/c/coreboot/+/52104 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie59de5399a9b1713109bf334d4ad1d7f7efb91f9 Gerrit-Change-Number: 52104 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Mon, 05 Apr 2021 12:49:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/intel/kblrvp: Always use `CHIPSET_LOCKDOWN_COREBOOT`
by Angel Pons (Code Review) April 5, 2021

April 5, 2021

Attention is currently required from: Subrata Banik, Michael Niewöhner. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52095 ) Change subject: mb/intel/kblrvp: Always use `CHIPSET_LOCKDOWN_COREBOOT` ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > should be tested, just to be sure I tested both settings on out-of-tree fujitsu/d3410-b1 and both booted fine. -- To view, visit https://review.coreboot.org/c/coreboot/+/52095 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2db1456d1734b2c0a6019002c211f608bcdf4a19 Gerrit-Change-Number: 52095 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Mon, 05 Apr 2021 12:42:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/asrock/h110m: Choose `CHIPSET_LOCKDOWN_COREBOOT`
by Angel Pons (Code Review) April 5, 2021

April 5, 2021

Attention is currently required from: Maxim Polyakov, Michael Niewöhner. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52094 ) Change subject: mb/asrock/h110m: Choose `CHIPSET_LOCKDOWN_COREBOOT` ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > should be tested, just to be sure I tested both settings on out-of-tree fujitsu/d3410-b1 and both booted fine. -- To view, visit https://review.coreboot.org/c/coreboot/+/52094 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5ef61f3d931abdb740411d8c58048cf21185802c Gerrit-Change-Number: 52094 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Mon, 05 Apr 2021 12:42:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/alderlake: Drop unused `PrmrrSize` from devicetree
by Michael Niewöhner (Code Review) April 5, 2021

April 5, 2021

Attention is currently required from: Angel Pons, Subrata Banik, Patrick Rudolph. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52108 ) Change subject: soc/intel/alderlake: Drop unused `PrmrrSize` from devicetree ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/52108 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib6fb77b03a4648adbd8b23c160cfba94d142a2d2 Gerrit-Change-Number: 52108 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Mon, 05 Apr 2021 12:35:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel: Replace open-coded buffer length calculation
by Michael Niewöhner (Code Review) April 5, 2021

April 5, 2021

Attention is currently required from: Angel Pons, Patrick Rudolph. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52107 ) Change subject: soc/intel: Replace open-coded buffer length calculation ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/52107 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibe49e40b1c4f2c0b661d94e59059a95bdb204197 Gerrit-Change-Number: 52107 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Mon, 05 Apr 2021 12:35:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0