April 2021 - coreboot-gerrit - mail.coreboot.org

Change in coreboot[master]: src: Put __weak on same line as function
by Martin Roth (Code Review) April 5, 2021

April 5, 2021

Martin Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/51906 ) Change subject: src: Put __weak on same line as function ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/51906 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I816f4afd497ec7bd6d660df2b7650c3ded289334 Gerrit-Change-Number: 51906 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: Makefile.inc: Quiet "Skipping submodule" noise unless V=1
by Martin Roth (Code Review) April 5, 2021

April 5, 2021

Martin Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/51882 ) Change subject: Makefile.inc: Quiet "Skipping submodule" noise unless V=1 ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/51882 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1ebc98f5e79a423a3a45c5fba9fa07cec617d2ed Gerrit-Change-Number: 51882 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: src: use __weak instead of __attribute__((weak))
by Martin Roth (Code Review) April 5, 2021

April 5, 2021

Martin Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/51907 ) Change subject: src: use __weak instead of __attribute__((weak)) ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/51907 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3609e9c0724d41355878fc61fdb33ae4f73c65f4 Gerrit-Change-Number: 51907 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Mariusz Szafrański <mariuszx.szafranski(a)intel.com> Gerrit-Reviewer: Michal Motyl <michalx.motyl(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: Documentation: Add the osource keyword to kconfig.md
by Martin Roth (Code Review) April 5, 2021

April 5, 2021

Martin Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48906 ) Change subject: Documentation: Add the osource keyword to kconfig.md ...................................................................... Documentation: Add the osource keyword to kconfig.md The 'source' kconfig keyword will soon return an error if the file being referenced does not exist. The 'osource' keyword has been added to allow for sourcing files that may or may not exist. Signed-off-by: Martin Roth <martin(a)coreboot.org> Change-Id: If22b9012a3c512720fcd4b84f396cc2b5e668d3c --- M Documentation/getting_started/kconfig.md 1 file changed, 41 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/48906/1 diff --git a/Documentation/getting_started/kconfig.md b/Documentation/getting_started/kconfig.md index 037371b..71fed2c 100644 --- a/Documentation/getting_started/kconfig.md +++ b/Documentation/getting_started/kconfig.md @@ -699,6 +699,47 @@ -------------------------------------------------------------------------------- +### osource + +The 'osource' keyword functions similarly to an 'include' statement in c or +the 'source' keyword in Kconfig, except that there is no error if the file +being sourced is not present. +This pulls one or more files into Kconfig at the location of the 'osource' +command. This statement is always parsed - there is no way to conditionally +source a file. coreboot's source and osource statements have been updated to +accept directory globbing. The '*' character will match with any directory. + + + +##### Usage: +osource <prompt> + + +##### Example: +# load site-local kconfig to allow user specific defaults and overrides +osource "site-local/Kconfig" + +##### Notes: +- As with all prompt values, the 'osource' prompt may be enclosed in single or + double quotes, or left without any quotes. Using quotes is highly recommended + however. +- The 'osource' keyword loads files relative to the working directory where the + Kconfig command was run. For coreboot, this is the root coreboot directory, so + all osource commands in the src directory need to start with ‘src/’. +- 'osource' pulls a file into the Kconfig tree at the location of the keyword. + This allows for files containing small bits of the Kconfig tree to be pulled + into a larger construct. A restriction on this is that the starting/ending + keyword pairs must be within the same file - ‘endif’ cannot appear in a + different file than the ‘if’ statement that it ends. The same is true of + menu/endmenu and choice/endchoice pairs. + +##### Restrictions: +- 'osource' keywords always load in the specified file or files if they exist. + This does not optionally pull in a file, it just doesn't error out if the + file does not exist. + +-------------------------------------------------------------------------------- + ### prompt The 'prompt' keyword sets the text displayed for a config symbol or choice in -- To view, visit https://review.coreboot.org/c/coreboot/+/48906 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If22b9012a3c512720fcd4b84f396cc2b5e668d3c Gerrit-Change-Number: 48906 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-MessageType: newchange

1 1

Change in coreboot[master]: util/lint/kconfig_lint: Add 'osource' keyword
by Martin Roth (Code Review) April 5, 2021

April 5, 2021

Martin Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48905 ) Change subject: util/lint/kconfig_lint: Add 'osource' keyword ...................................................................... util/lint/kconfig_lint: Add 'osource' keyword The 'osource' kconfig keyword is for sourcing files that may or may not exist. To this point, Kconfig just ignored sourced files that weren't present. This will be changed in the future, and any files that don't exist will give an error. Signed-off-by: Martin Roth <martin(a)coreboot.org> Change-Id: I7921801760fab409889951d9464e79f69ea49edf --- M util/lint/kconfig_lint 1 file changed, 15 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/48905/1 diff --git a/util/lint/kconfig_lint b/util/lint/kconfig_lint index 2341976..ecc8e7c 100755 --- a/util/lint/kconfig_lint +++ b/util/lint/kconfig_lint @@ -336,7 +336,7 @@ . " A 'bool' Kconfig should always be accessed through CONFIG($symbol)." ); } } else { - show_warning( "Unknown config option CONFIG_$symbol used at $file:$lineno." ); + show_warning( "Unknown config symbol CONFIG_$symbol used at $file:$lineno." ); } } } @@ -522,7 +522,7 @@ my %fileinfo; #start the tree off by loading the top level kconfig - @config_to_parse = load_kconfig_file( $top_level_kconfig, "", 0, 0, "", 0 ); + @config_to_parse = load_kconfig_file( $top_level_kconfig, "", 0, 0, "", 0, 0 ); while ( ( @parseline = shift(@config_to_parse) ) && ( exists $parseline[0]{text} ) ) { my $line = $parseline[0]{text}; @@ -717,9 +717,14 @@ } } - # source <prompt> + # osource and source <prompt> + elsif ( $line =~ /^\s*osource\s+"?([^"\s]+)"?\s*(?>#.*)?$/ ) { + my @newfile = load_kconfig_file( $1, $filename, $line_no, 0, $filename, $line_no, 1 ); + unshift( @config_to_parse, @newfile ); + $parseline[0]{text} = "# '$line'\n"; + } elsif ( $line =~ /^\s*source\s+"?([^"\s]+)"?\s*(?>#.*)?$/ ) { - my @newfile = load_kconfig_file( $1, $filename, $line_no, 0, $filename, $line_no ); + my @newfile = load_kconfig_file( $1, $filename, $line_no, 0, $filename, $line_no, 0 ); unshift( @config_to_parse, @newfile ); $parseline[0]{text} = "# '$line'\n"; } @@ -1199,7 +1204,7 @@ # load_kconfig_file - Loads a single Kconfig file or expands * wildcard #------------------------------------------------------------------------------- sub load_kconfig_file { - my ( $input_file, $loadfile, $loadline, $expanded, $topfile, $topline ) = @_; + my ( $input_file, $loadfile, $loadline, $expanded, $topfile, $topline, $optional ) = @_; my @file_data; my @dir_file_data; @@ -1222,14 +1227,16 @@ && ( $directory =~ /\Q$dir_glob_prefix\E.*\Q$dir_glob_suffix\E/ ) ) { push @dir_file_data, load_kconfig_file( "$dir_prefix/$directory/$dir_suffix", - $input_file, $loadline, 1, $loadfile, $loadline ); + $input_file, $loadline, 1, $loadfile, $loadline, $optional ); } } } #the directory should exist when using a glob else { - show_error("Could not find dir '$dir_prefix'"); + if ($optional == 0) { + show_error("Could not find dir '$dir_prefix'"); + } } } @@ -1249,7 +1256,7 @@ } # if the file isn't being loaded from a glob, it should exist. - elsif ( $expanded == 0 ) { + elsif ( $expanded == 0 && $optional == 0) { show_warning("Could not find file '$input_file' sourced at $loadfile:$loadline"); } -- To view, visit https://review.coreboot.org/c/coreboot/+/48905 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7921801760fab409889951d9464e79f69ea49edf Gerrit-Change-Number: 48905 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-MessageType: newchange

4 5

Change in coreboot[master]: soc/amd/common: Add ESPI_DEBUG_PRINT macro & Kconfig option
by Martin Roth (Code Review) April 5, 2021

April 5, 2021

Martin Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/51750 ) Change subject: soc/amd/common: Add ESPI_DEBUG_PRINT macro & Kconfig option ...................................................................... Abandoned Meh -- To view, visit https://review.coreboot.org/c/coreboot/+/51750 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibbd76f283e37ea3acbaf68735dc1bcbd13ddab8b Gerrit-Change-Number: 51750 Gerrit-PatchSet: 6 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-CC: Rob Barnes <robbarnes(a)google.com> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: soc/amd/common: Add some ESPI register definitions
by Martin Roth (Code Review) April 5, 2021

April 5, 2021

Attention is currently required from: Jason Glenesk, Raul Rangel, Furquan Shaikh, Felix Held. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51747 ) Change subject: soc/amd/common: Add some ESPI register definitions ...................................................................... Patch Set 6: (1 comment) File src/soc/amd/common/block/include/amdblocks/espi.h: https://review.coreboot.org/c/coreboot/+/51747/comment/d89ecc31_1fe27858 PS6, Line 20: #define ESPI_IO_BASE_OFFSET_REG1 0x48 > No, they're not required, but it seems useful to have them. Ack. -- To view, visit https://review.coreboot.org/c/coreboot/+/51747 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieae53b12e5303641fb3f180c47468aaa6906e9af Gerrit-Change-Number: 51747 Gerrit-PatchSet: 6 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 05 Apr 2021 17:14:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org> Comment-In-Reply-To: Martin Roth <martinroth(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/common: Add some ESPI register definitions
by Martin Roth (Code Review) April 5, 2021

April 5, 2021

Attention is currently required from: Jason Glenesk, Raul Rangel, Furquan Shaikh, Felix Held. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51747 ) Change subject: soc/amd/common: Add some ESPI register definitions ...................................................................... Patch Set 6: (1 comment) File src/soc/amd/common/block/include/amdblocks/espi.h: https://review.coreboot.org/c/coreboot/+/51747/comment/799ceab0_4017ea51 PS6, Line 20: #define ESPI_IO_BASE_OFFSET_REG1 0x48 > Do we need the _REG1,_REG2,_REG3? I don't see them being used as long as we have the ESPI_IO_RANGE_B […] No, they're not required, but it seems useful to have them. -- To view, visit https://review.coreboot.org/c/coreboot/+/51747 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieae53b12e5303641fb3f180c47468aaa6906e9af Gerrit-Change-Number: 51747 Gerrit-PatchSet: 6 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 05 Apr 2021 17:14:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/guybrush: Update GPIO configuration
by Raul Rangel (Code Review) April 5, 2021

April 5, 2021

Attention is currently required from: Martin Roth, Furquan Shaikh, Felix Held. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51675 ) Change subject: mb/google/guybrush: Update GPIO configuration ...................................................................... Patch Set 11: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/51675 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I512cb8b435dc8412cd46189e741ad94e5a24699e Gerrit-Change-Number: 51675 Gerrit-PatchSet: 11 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Mathew King <mathewk(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 05 Apr 2021 17:14:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/guybrush: Update GPIO configuration
by Martin Roth (Code Review) April 5, 2021

April 5, 2021

Attention is currently required from: Furquan Shaikh, Felix Held. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51675 ) Change subject: mb/google/guybrush: Update GPIO configuration ...................................................................... Patch Set 11: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/51675/comment/5adfce04_17db3e65 PS10, Line 9: Init I2C3 early for GSC communication. > This isn't done as part of this CL. Done File src/mainboard/google/guybrush/variants/baseboard/gpio.c: https://review.coreboot.org/c/coreboot/+/51675/comment/cf09620e_733a7a04 PS10, Line 59: // PAD_NF(GPIO_26, PCIE_RST_L, PULL_NONE), > I think it's best not to leave commented out code here. […] Done https://review.coreboot.org/c/coreboot/+/51675/comment/f084ea59_6f706890 PS10, Line 180: SPI_CLK2 > nit: Probably name this ESPI_SOC_CLK? That will make it clear that this is related to eSPI clock. Done, here and above. -- To view, visit https://review.coreboot.org/c/coreboot/+/51675 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I512cb8b435dc8412cd46189e741ad94e5a24699e Gerrit-Change-Number: 51675 Gerrit-PatchSet: 11 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Mathew King <mathewk(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 05 Apr 2021 17:12:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com> Gerrit-MessageType: comment

1 0