Attention is currently required from: Bill XIE.
Iru Cai (vimacs) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51670 )
Change subject: mb/hp/snb_ivb_laptops: Remove undefined variable in cmos.default
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/51670
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1d6bb68fb927882ddcc052b432bb34b42c58eac7
Gerrit-Change-Number: 51670
Gerrit-PatchSet: 1
Gerrit-Owner: Bill XIE <persmule(a)hardenedlinux.org>
Gerrit-Reviewer: Iru Cai (vimacs) <mytbk920423(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Bill XIE <persmule(a)hardenedlinux.org>
Gerrit-Comment-Date: Thu, 01 Apr 2021 06:16:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth, Isaac Lee, Eric Peers, EricR Lai.
Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51935 )
Change subject: mb/google/zork/var/vilboz: Update WiFi SAR for Vilboz/Vilboz360 LTE
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Hi Google,
Would you help to merge the CL?
Here are the positive result.
https://partnerissuetracker.corp.google.com/issues/183902165#comment8https://partnerissuetracker.corp.google.com/issues/183913210#comment5
--
To view, visit https://review.coreboot.org/c/coreboot/+/51935
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I37a40456970e3f1dc8b2eed26aa23e3d75748222
Gerrit-Change-Number: 51935
Gerrit-PatchSet: 2
Gerrit-Owner: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Eric Peers <epeers(a)google.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Isaac Lee <isaaclee(a)google.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alan Lee <alan_lee(a)compal.corp-partner.google.com>
Gerrit-CC: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Isaac Lee <isaaclee(a)google.com>
Gerrit-Attention: Eric Peers <epeers(a)google.com>
Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 01 Apr 2021 06:11:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Patrick Rudolph, EricR Lai.
Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52012 )
Change subject: soc/intel/alderlake: Enable RMT
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> We should mark this as WIP and not merge it. We don't really want RMT to be enabled all the time. […]
Correct, this is only for RMT. It shouldn't be merged to upstream.
--
To view, visit https://review.coreboot.org/c/coreboot/+/52012
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I509671714bb779b44ce1bffa9b6ab7bc217fdcc4
Gerrit-Change-Number: 52012
Gerrit-PatchSet: 1
Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 01 Apr 2021 06:04:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com>
Comment-In-Reply-To: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth, Julius Werner.
David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51827 )
Change subject: lint: checkpatch: Only exclude specific src/vendorcode/ subdirectories
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/51827
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1feaba37c469714217fff4d160e595849e0230b9
Gerrit-Change-Number: 51827
Gerrit-PatchSet: 2
Gerrit-Owner: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Thu, 01 Apr 2021 06:01:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth, Julius Werner.
David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51551 )
Change subject: lint: checkpatch: Ignore ASSIGN_IN_IF and UNNECESSARY_ELSE errors
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/51551
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I130598057c1800277a129ae6b927e961d6e26e42
Gerrit-Change-Number: 51551
Gerrit-PatchSet: 3
Gerrit-Owner: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Thu, 01 Apr 2021 05:59:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Xi Chen, Martin Roth, Wenbin Mei, Yidi Lin.
Hello Hung-Te Lin, Xi Chen, build bot (Jenkins), Patrick Georgi, Martin Roth, Yu-Ping Wu, Yidi Lin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/51966
to look at the new patch set (#4).
Change subject: soc/mediatek: add new driver 'msdc' for eMMC
......................................................................
soc/mediatek: add new driver 'msdc' for eMMC
Add MTK host mmc driver support.
MTK host controller support eMMC5.1 spec.
BUG=b:177389446
TEST=emerge-asurada coreboot
BRANCH=asurada
Signed-off-by: Wenbin Mei <wenbin.mei(a)mediatek.com>
Change-Id: I54a7749ed167c00cd631a76af7c67c654c7bc725
---
M src/commonlib/include/commonlib/sd_mmc_ctrlr.h
A src/soc/mediatek/common/include/soc/msdc.h
A src/soc/mediatek/common/msdc.c
M src/soc/mediatek/mt8192/Makefile.inc
4 files changed, 686 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/51966/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/51966
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I54a7749ed167c00cd631a76af7c67c654c7bc725
Gerrit-Change-Number: 51966
Gerrit-PatchSet: 4
Gerrit-Owner: Wenbin Mei <wenbin.mei(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com>
Gerrit-Reviewer: Yidi Lin <yidi.lin(a)mediatek.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Xi Chen <xixi.chen(a)mediatek.com>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Wenbin Mei <wenbin.mei(a)mediatek.corp-partner.google.com>
Gerrit-Attention: Yidi Lin <yidi.lin(a)mediatek.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Paul Menzel, Wenbin Mei.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/51973
to look at the new patch set (#2).
Change subject: mb/google/asurada: early-init eMMC
......................................................................
mb/google/asurada: early-init eMMC
Some eMMCs need 80+ms for CMD1 to complete. And the payload may need to
access eMMC in the very early stage (for example, Depthcharge needs it
20ms after started) so we have to start initialization in coreboot.
On Hayato Chromebook this can save ~100ms in total.
BUG=b:177389446
TEST=emerge-asurada coreboot
BRANCH=asurada
Signed-off-by: Wenbin Mei <wenbin.mei(a)mediatek.com>
Change-Id: I2f58d203e969dc1a13a479d7dc63b1b162a9ae3f
---
M src/mainboard/google/asurada/mainboard.c
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/51973/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/51973
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2f58d203e969dc1a13a479d7dc63b1b162a9ae3f
Gerrit-Change-Number: 51973
Gerrit-PatchSet: 2
Gerrit-Owner: Wenbin Mei <wenbin.mei(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Wenbin Mei <wenbin.mei(a)mediatek.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Chen-Tsung Hsieh, jitao shi, Jitao Shi, Yu-Ping Wu.
Shaoming Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51432 )
Change subject: soc/mediatek: dsi: fine tune the delta time for EoTp
......................................................................
Patch Set 5:
(2 comments)
File src/soc/mediatek/common/dsi.c:
https://review.coreboot.org/c/coreboot/+/51432/comment/6bf57fa0_15cc7fe0
PS2, Line 207: 10
> Your implementation in patchset_5 is not align with b/173603645#comment63. […]
The effect is the same with MIPI_DSI_MODE_EOT_PACKET, 12 byte also.
File src/soc/mediatek/common/dsi.c:
https://review.coreboot.org/c/coreboot/+/51432/comment/5cb276f2_0ed6b06e
PS5, Line 213: 6
> Do we need to modify it?
It's same with before, delta += 6
--
To view, visit https://review.coreboot.org/c/coreboot/+/51432
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0666068cfb04b78eb706278814163f050da32b9c
Gerrit-Change-Number: 51432
Gerrit-PatchSet: 5
Gerrit-Owner: jitao shi <jitao.shi(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Chen-Tsung Hsieh <chentsung(a)chromium.org>
Gerrit-CC: Chen-Tsung Hsieh <chentsung(a)google.com>
Gerrit-CC: Jitao Shi <jitao.shi(a)mediatek.corp-partner.google.com>
Gerrit-CC: Shaoming Chen <shaoming.chen(a)mediatek.corp-partner.google.com>
Gerrit-Attention: Chen-Tsung Hsieh <chentsung(a)google.com>
Gerrit-Attention: Chen-Tsung Hsieh <chentsung(a)chromium.org>
Gerrit-Attention: jitao shi <jitao.shi(a)mediatek.com>
Gerrit-Attention: Jitao Shi <jitao.shi(a)mediatek.corp-partner.google.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Thu, 01 Apr 2021 05:46:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Chen-Tsung Hsieh <chentsung(a)google.com>
Comment-In-Reply-To: Chen-Tsung Hsieh <chentsung(a)chromium.org>
Comment-In-Reply-To: Jitao Shi <jitao.shi(a)mediatek.corp-partner.google.com>
Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-MessageType: comment