Attention is currently required from: Justin van Son, Patrick Rudolph, Christian Walter.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51919 )
Change subject: mb/prodrive/hermes: Drop Vref configuration for older boards
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/prodrive/hermes/variants/r04/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/51919/comment/23503071_8dd57ff0
PS1, Line 42: return AZALIA_PIN_DESC(
> The driver won't detect a valid pin configuration when AZALIA_PIN_DESC is used. […]
Which hex value should be used here? I suspect the values in the AZALIA_PIN_DESC macro aren't correct.
--
To view, visit https://review.coreboot.org/c/coreboot/+/51919
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I41c207f97dad6c9107c1999eb46d2d6304a6c217
Gerrit-Change-Number: 51919
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Justin van Son <justin.van.son(a)prodrive-technologies.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Justin van Son <justin.van.son(a)prodrive-technologies.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Comment-Date: Thu, 01 Apr 2021 07:44:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Justin van Son <justin.van.son(a)prodrive-technologies.com>
Gerrit-MessageType: comment
Attention is currently required from: Patrick Rudolph, Christian Walter.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51919 )
Change subject: mb/prodrive/hermes: Drop Vref configuration for older boards
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/51919
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I41c207f97dad6c9107c1999eb46d2d6304a6c217
Gerrit-Change-Number: 51919
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Justin van Son <justin.van.son(a)prodrive-technologies.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Comment-Date: Thu, 01 Apr 2021 07:43:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth, Julius Werner.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51551 )
Change subject: lint: checkpatch: Ignore ASSIGN_IN_IF and UNNECESSARY_ELSE errors
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/51551
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I130598057c1800277a129ae6b927e961d6e26e42
Gerrit-Change-Number: 51551
Gerrit-PatchSet: 3
Gerrit-Owner: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Thu, 01 Apr 2021 07:42:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51949 )
Change subject: lib: Add obvious definition for `calloc`
......................................................................
Patch Set 7:
(1 comment)
File tests/lib/malloc-test.c:
https://review.coreboot.org/c/coreboot/+/51949/comment/4df6091f_f6a2d316
PS7, Line 150: assert_true(*p == 0);
There is assert_int_equal(a, b) macro. Please use that instead.
--
To view, visit https://review.coreboot.org/c/coreboot/+/51949
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I57a568e323344a97b35014b7b8bec16adc2fd720
Gerrit-Change-Number: 51949
Gerrit-PatchSet: 7
Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Comment-Date: Thu, 01 Apr 2021 07:40:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Mac Chiang, leeweitse_seven, Martin Roth, Furquan Shaikh, Tim Wawrzynczak, John Hsu, David Lin, EricR Lai.
leeweitse_seven has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51971 )
Change subject: src/drivers/generic/nau8315: Add nau8315 support
......................................................................
Patch Set 4:
(5 comments)
File src/drivers/generic/nau8315/chip.h:
https://review.coreboot.org/c/coreboot/+/51971/comment/b3046021_372ee6ec
PS1, Line 8: const char *hid;
> And I think we can fixed the HID name. Since kernel driver only look up specific name.
Done
https://review.coreboot.org/c/coreboot/+/51971/comment/8cb87951_d6d2eaad
PS1, Line 13: /* GPIO used to indicate if this device is present */
> I think we can remove this. We can have FW config for present now.
Done
File src/drivers/generic/nau8315/nau8315.c:
https://review.coreboot.org/c/coreboot/+/51971/comment/6cea25a7_104ae3eb
PS1, Line 11: #if CONFIG(HAVE_ACPI_TABLES)
> use depend for it. please refer my CL. https://review.coreboot. […]
Done
https://review.coreboot.org/c/coreboot/+/51971/comment/eb46cdf7_19d3f0c7
PS1, Line 53: enable-gpio
> enable-gpios
Done
File src/drivers/generic/nau8315/nau8315.c:
https://review.coreboot.org/c/coreboot/+/51971/comment/029de2c6_f6f5a258
PS3, Line 58: return NAU8315_ACPI_NAME;
> we can return string here, remove the define.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/51971
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie883d65ced3cd95fe318ba0914ed806ff592258d
Gerrit-Change-Number: 51971
Gerrit-PatchSet: 4
Gerrit-Owner: leeweitse_seven <scott.6986(a)hotmail.com>
Gerrit-Reviewer: David Lin <CTLIN0(a)nuvoton.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: John Hsu <KCHSU0(a)nuvoton.com>
Gerrit-Reviewer: Mac Chiang <mac.chiang(a)intel.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Mac Chiang <mac.chiang(a)intel.com>
Gerrit-Attention: leeweitse_seven <scott.6986(a)hotmail.com>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: John Hsu <KCHSU0(a)nuvoton.com>
Gerrit-Attention: David Lin <CTLIN0(a)nuvoton.com>
Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 01 Apr 2021 06:46:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: Shaoming Chen.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51432 )
Change subject: soc/mediatek: dsi: fine tune the delta time for EoTp
......................................................................
Patch Set 5: -Code-Review
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51432/comment/dec18b16_d5a28ea2
PS1, Line 9: We seperate the EoTp packet extra data
> so which change did this? we need a reference
Shaoming, please address hungte's comment.
Commit Message:
https://review.coreboot.org/c/coreboot/+/51432/comment/c38428d6_bf6ddfba
PS2, Line 7: when EoTp enable
> Either […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/51432
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0666068cfb04b78eb706278814163f050da32b9c
Gerrit-Change-Number: 51432
Gerrit-PatchSet: 5
Gerrit-Owner: jitao shi <jitao.shi(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Chen-Tsung Hsieh <chentsung(a)chromium.org>
Gerrit-CC: Chen-Tsung Hsieh <chentsung(a)google.com>
Gerrit-CC: Jitao Shi <jitao.shi(a)mediatek.corp-partner.google.com>
Gerrit-CC: Shaoming Chen <shaoming.chen(a)mediatek.corp-partner.google.com>
Gerrit-Attention: Shaoming Chen <shaoming.chen(a)mediatek.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 01 Apr 2021 06:45:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Hung-Te Lin <hungte(a)chromium.org>
Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-MessageType: comment