Attention is currently required from: Paul Menzel, Rob Barnes.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51775 )
Change subject: chromeec: Rewrite google_chromeec_status_check
......................................................................
Patch Set 4:
(3 comments)
File src/ec/google/chromeec/ec_lpc.c:
https://review.coreboot.org/c/coreboot/+/51775/comment/43cbeca7_db100a32
PS4, Line 100: 1
> > I'm playing with this value right now, but I think this is the source of our problems. […]
Issue has been fixed.
https://review.coreboot.org/c/coreboot/+/51775/comment/0bc9ce90_cc9ca961
PS4, Line 105: return 0;
> Print the stopwatch value in a spew message?
This call happens pretty frequently. I'm not sure that's really useful.
https://review.coreboot.org/c/coreboot/+/51775/comment/ab16a2e0_0f01dcf4
PS4, Line 108:
> Please print a warning/error with the timeout value.
As mentioned above, I don't think that it's particularly useful, except during board bringup.
--
To view, visit https://review.coreboot.org/c/coreboot/+/51775
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I363ff7453bcf81581884f92797629a6f96d42580
Gerrit-Change-Number: 51775
Gerrit-PatchSet: 4
Gerrit-Owner: Rob Barnes <robbarnes(a)google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Rob Barnes <robbarnes(a)google.com>
Gerrit-Comment-Date: Mon, 05 Apr 2021 17:45:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com>
Comment-In-Reply-To: Martin Roth <martinroth(a)google.com>
Comment-In-Reply-To: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-MessageType: comment
Martin Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/51913 )
Change subject: DNS: Give Guybrush's EC time to breathe
......................................................................
Abandoned
No longer needed.
--
To view, visit https://review.coreboot.org/c/coreboot/+/51913
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I101a63c6133900183192fc45fabf9fc09cb892be
Gerrit-Change-Number: 51913
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Furquan Shaikh <furquan(a)google.com>
Gerrit-CC: Rob Barnes <robbarnes(a)google.com>
Gerrit-MessageType: abandon
Martin Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/51751 )
Change subject: soc/amd/cezanne: add add_chipset_state_cbmem()
......................................................................
Abandoned
Letting felix handle this as part of the chipset code.
--
To view, visit https://review.coreboot.org/c/coreboot/+/51751
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3de3764c99fe89b962db88065575463b365ddaf5
Gerrit-Change-Number: 51751
Gerrit-PatchSet: 5
Gerrit-Owner: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Furquan Shaikh <furquan(a)google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-MessageType: abandon
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50654 )
Change subject: util/bincfg: Clean up Makefile
......................................................................
Patch Set 3:
(1 comment)
File util/bincfg/Makefile:
https://review.coreboot.org/c/coreboot/+/50654/comment/6c056dca_1fe08f4f
PS1, Line 30: ./bincfg
> Updating in a follow-on patch
When the follow-up patch is ready, mind linking to it in a reply to this comment thread? Thanks!
--
To view, visit https://review.coreboot.org/c/coreboot/+/50654
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic0302f663cbc931325334d0cce93d3b0bf937cc6
Gerrit-Change-Number: 50654
Gerrit-PatchSet: 3
Gerrit-Owner: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Mon, 05 Apr 2021 17:25:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth <martinroth(a)google.com>
Comment-In-Reply-To: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-MessageType: comment
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50654 )
Change subject: util/bincfg: Clean up Makefile
......................................................................
Patch Set 2:
(1 comment)
File util/bincfg/Makefile:
https://review.coreboot.org/c/coreboot/+/50654/comment/5026074e_be689404
PS1, Line 30: ./bincfg
> should these be $(abspath $(TARGET)) or something?
Updating in a follow-on patch
--
To view, visit https://review.coreboot.org/c/coreboot/+/50654
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic0302f663cbc931325334d0cce93d3b0bf937cc6
Gerrit-Change-Number: 50654
Gerrit-PatchSet: 2
Gerrit-Owner: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Mon, 05 Apr 2021 17:20:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-MessageType: comment