coreboot-gerrit April 2021

coreboot-gerrit@coreboot.org

1 participants
6269 discussions

Change in coreboot[master]: mb/intel/shadowmountain: Enable RTD3 for SD card
by Rizwan Qureshi (Code Review) 08 Apr '21

08 Apr '21

Attention is currently required from: Rizwan Qureshi. Hello build bot (Jenkins), Paul Menzel, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/52134 to look at the new patch set (#4). Change subject: mb/intel/shadowmountain: Enable RTD3 for SD card ...................................................................... mb/intel/shadowmountain: Enable RTD3 for SD card Enable the PCIe RTD3 driver for the PCIe attached SD card interface and specify the srcclk pin and reset GPIO. TEST=Tested on shadowmountain platform to ensure the system can enter the S0i3.2 substate and suspend/resume is stable Signed-off-by: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Change-Id: Ibeb99bea48d72b019cb2adcf38926c3ed39f7b84 --- M src/mainboard/intel/shadowmountain/variants/baseboard/devicetree.cb 1 file changed, 7 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/52134/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/52134 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibeb99bea48d72b019cb2adcf38926c3ed39f7b84 Gerrit-Change-Number: 52134 Gerrit-PatchSet: 4 Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/amd/cezanne: Add GRXS and GTXS method
by Felix Held (Code Review) 08 Apr '21

08 Apr '21

Attention is currently required from: Jason Glenesk, Raul Rangel, Martin Roth, Marshall Dawson, Mathew King, Ivy Jian. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52184 ) Change subject: soc/amd/cezanne: Add GRXS and GTXS method ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I feel like these should be moved to common code. that's what i was planning for this; i'll take over this one -- To view, visit https://review.coreboot.org/c/coreboot/+/52184 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2e3512562f92de230cf2e6967ec90527fb3d62ee Gerrit-Change-Number: 52184 Gerrit-PatchSet: 1 Gerrit-Owner: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Mathew King <mathewk(a)chromium.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Mathew King <mathewk(a)chromium.org> Gerrit-Attention: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Thu, 08 Apr 2021 16:36:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Mathew King <mathewk(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/cezanne: Add GRXS and GTXS method
by EricR Lai (Code Review) 08 Apr '21

08 Apr '21

Attention is currently required from: Jason Glenesk, Raul Rangel, Martin Roth, Marshall Dawson, Mathew King, Ivy Jian, Felix Held. EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52184 ) Change subject: soc/amd/cezanne: Add GRXS and GTXS method ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I feel like these should be moved to common code. yes, we can do like Intel do's. -- To view, visit https://review.coreboot.org/c/coreboot/+/52184 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2e3512562f92de230cf2e6967ec90527fb3d62ee Gerrit-Change-Number: 52184 Gerrit-PatchSet: 1 Gerrit-Owner: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Mathew King <mathewk(a)chromium.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Mathew King <mathewk(a)chromium.org> Gerrit-Attention: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 08 Apr 2021 16:31:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Mathew King <mathewk(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/alderlake: Enable PCIE RTD3 driver
by Rizwan Qureshi (Code Review) 08 Apr '21

08 Apr '21

Attention is currently required from: Patrick Rudolph. Rizwan Qureshi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/52195 ) Change subject: soc/intel/alderlake: Enable PCIE RTD3 driver ...................................................................... soc/intel/alderlake: Enable PCIE RTD3 driver Include the PCIE RTD3 driveri for Alder Lake SoC. Signed-off-by: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Change-Id: I4732e4663feff503b249b76aaf70ec142a888963 --- M src/soc/intel/alderlake/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/52195/1 diff --git a/src/soc/intel/alderlake/Kconfig b/src/soc/intel/alderlake/Kconfig index 37e6a94..2efe760 100644 --- a/src/soc/intel/alderlake/Kconfig +++ b/src/soc/intel/alderlake/Kconfig @@ -59,6 +59,7 @@ select SOC_INTEL_COMMON_BLOCK_HDA select SOC_INTEL_COMMON_BLOCK_IPU select SOC_INTEL_COMMON_BLOCK_MEMINIT + select SOC_INTEL_COMMON_BLOCK_PCIE_RTD3 select SOC_INTEL_COMMON_BLOCK_POWER_LIMIT select SOC_INTEL_COMMON_BLOCK_SA select SOC_INTEL_COMMON_BLOCK_SMM -- To view, visit https://review.coreboot.org/c/coreboot/+/52195 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4732e4663feff503b249b76aaf70ec142a888963 Gerrit-Change-Number: 52195 Gerrit-PatchSet: 1 Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: common/block/pcie/rtd3:[WIP] use the correct confing name for clkreq ...
by Rizwan Qureshi (Code Review) 08 Apr '21

08 Apr '21

Attention is currently required from: Patrick Rudolph. Rizwan Qureshi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/52194 ) Change subject: common/block/pcie/rtd3:[WIP] use the correct confing name for clkreq pin count ...................................................................... common/block/pcie/rtd3:[WIP] use the correct confing name for clkreq pin count Signed-off-by: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Change-Id: I747c94331b68c4ec0b6b5a04149856a4bb384829 --- M src/soc/intel/common/block/pcie/rtd3/rtd3.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/52194/1 diff --git a/src/soc/intel/common/block/pcie/rtd3/rtd3.c b/src/soc/intel/common/block/pcie/rtd3/rtd3.c index 5a04333..1a56aac 100644 --- a/src/soc/intel/common/block/pcie/rtd3/rtd3.c +++ b/src/soc/intel/common/block/pcie/rtd3/rtd3.c @@ -200,7 +200,7 @@ __func__, scope); return; } - if (config->srcclk_pin > CONFIG_MAX_PCIE_CLOCKS) { + if (config->srcclk_pin > CONFIG_MAX_PCIE_CLOCK_REQ) { printk(BIOS_ERR, "%s: Invalid clock pin %u for %s.\n", __func__, config->srcclk_pin, scope); return; -- To view, visit https://review.coreboot.org/c/coreboot/+/52194 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I747c94331b68c4ec0b6b5a04149856a4bb384829 Gerrit-Change-Number: 52194 Gerrit-PatchSet: 1 Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/intel/shadowmountain: Enable RTD3 for SD card
by Rizwan Qureshi (Code Review) 08 Apr '21

08 Apr '21

Attention is currently required from: Rizwan Qureshi. Hello build bot (Jenkins), Paul Menzel, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/52134 to look at the new patch set (#3). Change subject: mb/intel/shadowmountain: Enable RTD3 for SD card ...................................................................... mb/intel/shadowmountain: Enable RTD3 for SD card Enable the PCIe RTD3 driver for the PCIe attached SD card interface and specify the srcclk pin and reset GPIO. TEST=Tested on shadowmountain platform to ensure the system can enter the S0i3.2 substate and suspend/resume is stable Signed-off-by: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Change-Id: Ibeb99bea48d72b019cb2adcf38926c3ed39f7b84 --- M src/mainboard/intel/shadowmountain/variants/baseboard/devicetree.cb 1 file changed, 8 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/52134/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/52134 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibeb99bea48d72b019cb2adcf38926c3ed39f7b84 Gerrit-Change-Number: 52134 Gerrit-PatchSet: 3 Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/amd/cezanne: Add GRXS and GTXS method
by Mathew King (Code Review) 08 Apr '21

08 Apr '21

Attention is currently required from: Jason Glenesk, Raul Rangel, Martin Roth, Marshall Dawson, Ivy Jian, Felix Held. Mathew King has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52184 ) Change subject: soc/amd/cezanne: Add GRXS and GTXS method ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I feel like these should be moved to common code. -- To view, visit https://review.coreboot.org/c/coreboot/+/52184 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2e3512562f92de230cf2e6967ec90527fb3d62ee Gerrit-Change-Number: 52184 Gerrit-PatchSet: 1 Gerrit-Owner: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Mathew King <mathewk(a)chromium.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 08 Apr 2021 15:57:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/guybrush/var/guybrush: Add FPMCU configration
by Mathew King (Code Review) 08 Apr '21

08 Apr '21

Attention is currently required from: Furquan Shaikh, Bhanu Prakash Maiya, Ivy Jian. Mathew King has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52181 ) Change subject: mb/google/guybrush/var/guybrush: Add FPMCU configration ...................................................................... Patch Set 9: Code-Review+2 (1 comment) File src/mainboard/google/guybrush/variants/guybrush/overridetree.cb: https://review.coreboot.org/c/coreboot/+/52181/comment/26f7cd79_a282b3ab PS4, Line 101: > done Done -- To view, visit https://review.coreboot.org/c/coreboot/+/52181 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7c56b0db193be6804d07c2f333445c2a1dbf9f59 Gerrit-Change-Number: 52181 Gerrit-PatchSet: 9 Gerrit-Owner: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com> Gerrit-Reviewer: Bhanu Prakash Maiya <bhanumaiya(a)google.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Mathew King <mathewk(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Bhanu Prakash Maiya <bhanumaiya(a)google.com> Gerrit-Attention: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Thu, 08 Apr 2021 15:55:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com> Comment-In-Reply-To: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/mancomb: Add Codec configration
by Mathew King (Code Review) 08 Apr '21

08 Apr '21

Attention is currently required from: Raul Rangel, Martin Roth, EricR Lai, Karthik Ramasubramanian. Mathew King has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52179 ) Change subject: mb/google/mancomb: Add Codec configration ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/52179 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib75ef99cbca8b2f38268705704e7616b456f19d9 Gerrit-Change-Number: 52179 Gerrit-PatchSet: 1 Gerrit-Owner: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Mathew King <mathewk(a)chromium.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Thu, 08 Apr 2021 15:53:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/mancomb: Add Bluetooth configuration
by Mathew King (Code Review) 08 Apr '21

08 Apr '21

Attention is currently required from: Raul Rangel, Martin Roth, EricR Lai, Karthik Ramasubramanian. Mathew King has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52178 ) Change subject: mb/google/mancomb: Add Bluetooth configuration ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/52178 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7661dea682cbe0ae5e169d87e794ed6ed3c83b5e Gerrit-Change-Number: 52178 Gerrit-PatchSet: 1 Gerrit-Owner: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Mathew King <mathewk(a)chromium.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Thu, 08 Apr 2021 15:53:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2021