coreboot-gerrit April 2021

coreboot-gerrit@coreboot.org

1 participants
6269 discussions

Change in coreboot[master]: mb/google/dedede/var/galith: Support Wifi SAR for DVT phase
by Karthik Ramasubramanian (Code Review) 28 Apr '21

28 Apr '21

Attention is currently required from: Henry Sun, Frank Chu. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52565 ) Change subject: mb/google/dedede/var/galith: Support Wifi SAR for DVT phase ...................................................................... Patch Set 1: (1 comment) File src/mainboard/google/dedede/variants/galtic/variant.c: https://review.coreboot.org/c/coreboot/+/52565/comment/3f81dcff_e34185a6 PS1, Line 8: if (fw_config_probe(FW_CONFIG(TABLETMODE, TABLETMODE_DISABLED))) : return "wifi_sar-galtic.hex"; > because galtic series non support tablet mode so far If that is the case, why can't we just return "wifi_sar-galtic.hex" for now. Later when we want a different SAR file for converibles, that can be added to CBFS and returned after probing the FW_Config. -- To view, visit https://review.coreboot.org/c/coreboot/+/52565 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic9bb76c207ef033f81ecdd57849535b8ac8d13ae Gerrit-Change-Number: 52565 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com> Gerrit-CC: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com> Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-Comment-Date: Tue, 27 Apr 2021 18:27:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: ec/google/chromeec: Provide EC access for Retimer firmware upgrade
by John Zhao (Code Review) 28 Apr '21

28 Apr '21

John Zhao has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/52713 ) Change subject: ec/google/chromeec: Provide EC access for Retimer firmware upgrade ...................................................................... ec/google/chromeec: Provide EC access for Retimer firmware upgrade Coreboot needs to access EC RFWU entry in order to suspend and resume PD and modes setting. This change adds ec_retimer_fw_update implementation for Retimer firmware upgrade. BUG=b:186521258 TEST=Build image successfully. Signed-off-by: John Zhao <john.zhao(a)intel.com> Change-Id: Ib937d8bd72fc39487854773573b435bf2add672a --- M src/ec/google/chromeec/ec_acpi.c 1 file changed, 13 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/52713/1 diff --git a/src/ec/google/chromeec/ec_acpi.c b/src/ec/google/chromeec/ec_acpi.c index 8cfc7b1..4b3f781 100644 --- a/src/ec/google/chromeec/ec_acpi.c +++ b/src/ec/google/chromeec/ec_acpi.c @@ -241,3 +241,16 @@ { return "\\_SB_.PCI0.LPCB.EC0_.RFWU"; } + +void ec_retimer_fw_update(uint8_t data) +{ + const char *RFWU = ec_retimer_fw_update_path(); + + /* + * Write the EC RAM for Retimer Upgrade + * RFWU = data + */ + acpigen_write_store(); + acpigen_write_byte(data); + acpigen_emit_namestring(RFWU); +} -- To view, visit https://review.coreboot.org/c/coreboot/+/52713 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib937d8bd72fc39487854773573b435bf2add672a Gerrit-Change-Number: 52713 Gerrit-PatchSet: 1 Gerrit-Owner: John Zhao <john.zhao(a)intel.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: drivers/intel/usb4: Update driver to support Retimer firmware upgrade
by John Zhao (Code Review) 28 Apr '21

28 Apr '21

Attention is currently required from: Patrick Rudolph. John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52712 ) Change subject: drivers/intel/usb4: Update driver to support Retimer firmware upgrade ...................................................................... Patch Set 1: (5 comments) File src/drivers/intel/usb4/retimer/retimer.c: https://review.coreboot.org/c/coreboot/+/52712/comment/7e5ef1ea_de5d70e4 PS1, Line 69: * Return: -1 if timeout error occuring > 'occuring' may be misspelled - perhaps 'occurring'? Please fix. https://review.coreboot.org/c/coreboot/+/52712/comment/5870df41_5a69172e PS1, Line 243: * // Disable retimer online state > please, no space before tabs Please fix. https://review.coreboot.org/c/coreboot/+/52712/comment/642ad16f_5264ff6d PS1, Line 312: usb4_retimer_cb_get_power_state, /* Function 1 */ > please, no space before tabs Please fix. https://review.coreboot.org/c/coreboot/+/52712/comment/3c72bd05_c6d4d0ea PS1, Line 313: usb4_retimer_cb_set_power_state, /* Function 2 */ > please, no space before tabs Please fix. https://review.coreboot.org/c/coreboot/+/52712/comment/d0da81b5_c533e74a PS1, Line 355: for(port = 0; port < config->dfp_num; port++) { > space required before the open parenthesis '(' Please fix. -- To view, visit https://review.coreboot.org/c/coreboot/+/52712 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I81bef80729f6df57119f5523358620cb015e5406 Gerrit-Change-Number: 52712 Gerrit-PatchSet: 1 Gerrit-Owner: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Tue, 27 Apr 2021 18:14:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/intel/usb4: Update driver to support Retimer firmware upgrade
by John Zhao (Code Review) 28 Apr '21

28 Apr '21

Attention is currently required from: John Zhao, Patrick Rudolph. Hello build bot (Jenkins), Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/52712 to look at the new patch set (#2). Change subject: drivers/intel/usb4: Update driver to support Retimer firmware upgrade ...................................................................... drivers/intel/usb4: Update driver to support Retimer firmware upgrade Along with upstream kernel for Retimer firmware upgrade, coreboot provides DFPx under host router where each DFP has its PLD and DSM. The DFPx's functions encapsulates power control through GPIO, PD suspend/resume and modes setting for Retimer firmware update under NDA scenario. BUG=b:186521258 TEST=Booted to kernel and validated host router's DFPx properties after decomposing SSDT table. Signed-off-by: John Zhao <john.zhao(a)intel.com> Change-Id: I81bef80729f6df57119f5523358620cb015e5406 --- M src/drivers/intel/usb4/retimer/chip.h M src/drivers/intel/usb4/retimer/retimer.c M src/drivers/intel/usb4/retimer/retimer.h 3 files changed, 369 insertions(+), 75 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/52712/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/52712 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I81bef80729f6df57119f5523358620cb015e5406 Gerrit-Change-Number: 52712 Gerrit-PatchSet: 2 Gerrit-Owner: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: John Zhao <john.zhao(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/brya: Adjust WWAN power sequence
by Furquan Shaikh (Code Review) 28 Apr '21

28 Apr '21

Attention is currently required from: Tim Wawrzynczak, EricR Lai. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52694 ) Change subject: mb/google/brya: Adjust WWAN power sequence ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > We might need to think this over a little bit more w/r/t multiple WWAN modules and differing power s […] Traditionally, we have just relied on the time taken between stages to toggle pads in early stage and then in ramstage to meet the timing requirements. If that works for all WWAN modules, we can probably do the same thing here. We spend a good amount of time from bootblock->ramstage, so I think that should be sufficient for most(all?) modules. -- To view, visit https://review.coreboot.org/c/coreboot/+/52694 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I13357677bb1ab185abf1d4c915a762a9d6894312 Gerrit-Change-Number: 52694 Gerrit-PatchSet: 1 Gerrit-Owner: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Tue, 27 Apr 2021 18:04:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/alderlake: Add CrashLog implementation for Intel ADL
by Francois Toguo Fotso (Code Review) 28 Apr '21

28 Apr '21

Attention is currently required from: Tim Wawrzynczak, Paul Menzel. Francois Toguo Fotso has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52454 ) Change subject: soc/intel/alderlake: Add CrashLog implementation for Intel ADL ...................................................................... Patch Set 7: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/52454/comment/0d0ec575_49ad51bf PS6, Line 11: 183981959 > b:183981959 Done Patchset: PS7: Done -- To view, visit https://review.coreboot.org/c/coreboot/+/52454 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I15ba0b41f73c1772f09584f13bcf5585caa90782 Gerrit-Change-Number: 52454 Gerrit-PatchSet: 7 Gerrit-Owner: Francois Toguo Fotso <francois.toguo.fotso(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Raj Astekar <raj.astekar(a)intel.com> Gerrit-CC: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Comment-Date: Tue, 27 Apr 2021 18:03:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/alderlake: Add CrashLog implementation for Intel ADL
by Francois Toguo Fotso (Code Review) 28 Apr '21

28 Apr '21

Attention is currently required from: Francois Toguo Fotso, Paul Menzel, Tim Wawrzynczak. Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Tim Wawrzynczak, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/52454 to look at the new patch set (#7). Change subject: soc/intel/alderlake: Add CrashLog implementation for Intel ADL ...................................................................... soc/intel/alderlake: Add CrashLog implementation for Intel ADL This enables CrashLog for Intel ADL based platform. BUG=b:183981959 TEST=CrashLog data generated, extracted, processed and decoded sucessfully on adl-m RVP. Signed-off-by: Francois Toguo <francois.toguo.fotso(a)intel.com> Change-Id: I15ba0b41f73c1772f09584f13bcf5585caa90782 --- M src/soc/intel/alderlake/Kconfig M src/soc/intel/alderlake/Makefile.inc M src/soc/intel/alderlake/chipset.cb A src/soc/intel/alderlake/crashlog.c A src/soc/intel/alderlake/include/soc/crashlog.h M src/soc/intel/alderlake/include/soc/pci_devs.h M src/soc/intel/alderlake/romstage/fsp_params.c 7 files changed, 349 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/52454/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/52454 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I15ba0b41f73c1772f09584f13bcf5585caa90782 Gerrit-Change-Number: 52454 Gerrit-PatchSet: 7 Gerrit-Owner: Francois Toguo Fotso <francois.toguo.fotso(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Raj Astekar <raj.astekar(a)intel.com> Gerrit-CC: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Francois Toguo Fotso <francois.toguo.fotso(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: chromeec: Fix google_chromeec_status_check timeout
by Furquan Shaikh (Code Review) 28 Apr '21

28 Apr '21

Attention is currently required from: Martin Roth, Rob Barnes. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51775 ) Change subject: chromeec: Fix google_chromeec_status_check timeout ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/51775 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I363ff7453bcf81581884f92797629a6f96d42580 Gerrit-Change-Number: 51775 Gerrit-PatchSet: 6 Gerrit-Owner: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Rob Barnes <robbarnes(a)google.com> Gerrit-Comment-Date: Tue, 27 Apr 2021 17:58:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Adjust WWAN power sequence
by Tim Wawrzynczak (Code Review) 28 Apr '21

28 Apr '21

Attention is currently required from: EricR Lai. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52694 ) Change subject: mb/google/brya: Adjust WWAN power sequence ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: We might need to think this over a little bit more w/r/t multiple WWAN modules and differing power sequencing requirements. Depending on the different characteristics, we might want to just create an ACPI PowerResource and let the kernel handle it. This one is only on the order of 120ms long... Should we just move the whole power sequence to the kernel? It will always have the ~10s of initialization time regardless. That would allow the kernel to have the ability to perform a hard reset of the module as well, wouldn't it? -- To view, visit https://review.coreboot.org/c/coreboot/+/52694 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I13357677bb1ab185abf1d4c915a762a9d6894312 Gerrit-Change-Number: 52694 Gerrit-PatchSet: 1 Gerrit-Owner: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Tue, 27 Apr 2021 17:58:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/intel/usb4: Dummy
by build bot (Jenkins) (Code Review) 28 Apr '21

28 Apr '21

Attention is currently required from: Patrick Rudolph. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52712 ) Change subject: drivers/intel/usb4: Dummy ...................................................................... Patch Set 1: (5 comments) File src/drivers/intel/usb4/retimer/retimer.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117905): https://review.coreboot.org/c/coreboot/+/52712/comment/654d29ca_5b73dc34 PS1, Line 69: * Return: -1 if timeout error occuring 'occuring' may be misspelled - perhaps 'occurring'? Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117905): https://review.coreboot.org/c/coreboot/+/52712/comment/c804da4b_0d827914 PS1, Line 243: * // Disable retimer online state please, no space before tabs Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117905): https://review.coreboot.org/c/coreboot/+/52712/comment/5af964ee_c2b8b88d PS1, Line 312: usb4_retimer_cb_get_power_state, /* Function 1 */ please, no space before tabs Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117905): https://review.coreboot.org/c/coreboot/+/52712/comment/dffbaf5f_b8a54d52 PS1, Line 313: usb4_retimer_cb_set_power_state, /* Function 2 */ please, no space before tabs Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117905): https://review.coreboot.org/c/coreboot/+/52712/comment/bef516de_7bf89f72 PS1, Line 355: for(port = 0; port < config->dfp_num; port++) { space required before the open parenthesis '(' -- To view, visit https://review.coreboot.org/c/coreboot/+/52712 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I81bef80729f6df57119f5523358620cb015e5406 Gerrit-Change-Number: 52712 Gerrit-PatchSet: 1 Gerrit-Owner: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Tue, 27 Apr 2021 17:58:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2021