Attention is currently required from: Kevin Chang, Tim Wawrzynczak, Nick Vaccaro, YH Lin, Zhuohao Lee.
Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52698 )
Change subject: mb/google/volteer/variant/lindar: Modify ELAN touch screen IRQ trigger method
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/52698
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9237d9aad6166a5754afe464ce8453129a58d283
Gerrit-Change-Number: 52698
Gerrit-PatchSet: 3
Gerrit-Owner: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: YH Lin <yueherngl(a)chromium.org>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)chromium.org>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Lauren Ting <lauren.ting(a)lcfc.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: YH Lin <yueherngl(a)chromium.org>
Gerrit-Attention: Zhuohao Lee <zhuohao(a)chromium.org>
Gerrit-Comment-Date: Tue, 27 Apr 2021 13:15:37 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Julius Werner.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50879 )
Change subject: [WIP] soc/mediatek,qualcomm: Replace some CONFIG(CHROMEOS)
......................................................................
Patch Set 7:
(1 comment)
Patchset:
PS6:
> I think this only used to be tied to CONFIG_CHROMEOS because back when I wrote it all the TPM initia […]
Well as CONFIG(TPM) does not exist.. TPM1 || TPM2 or don't tie it at all?
--
To view, visit https://review.coreboot.org/c/coreboot/+/50879
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I40b72cd63b051a2649ff450f50946e5a0a00ed4f
Gerrit-Change-Number: 50879
Gerrit-PatchSet: 7
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Tue, 27 Apr 2021 12:37:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Timofey Komarov, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52692 )
Change subject: Add Amberlake Kconfig option and some FSP config changes
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> If these are Coffee Lake CPUs, why adding them here in soc/intel/skylake?
Z370, H310C and B365 use the same silicon as 200-series PCHs, and they work with the PCH code in skylake (we've tried the cannonlake code on H310C and it didn't work). Unlike other PCHs, these are usually paired with Coffee Lake CPUs.
IMHO, the way to go would be to factor out the CPU code. We'll get into that later with e.g. vr_config and the CPUs in report_platform.
--
To view, visit https://review.coreboot.org/c/coreboot/+/52692
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7b6b9c676da55088cb5a12a218ea58d349ee440c
Gerrit-Change-Number: 52692
Gerrit-PatchSet: 1
Gerrit-Owner: Timofey Komarov <happycorsair(a)yandex.ru>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <felixsinger(a)posteo.net>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Timofey Komarov <happycorsair(a)yandex.ru>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Tue, 27 Apr 2021 12:32:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net>
Gerrit-MessageType: comment
Attention is currently required from: Timofey Komarov, Patrick Rudolph.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52692 )
Change subject: Add Amberlake Kconfig option and some FSP config changes
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
If these are Coffee Lake CPUs, why adding them here in soc/intel/skylake?
--
To view, visit https://review.coreboot.org/c/coreboot/+/52692
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7b6b9c676da55088cb5a12a218ea58d349ee440c
Gerrit-Change-Number: 52692
Gerrit-PatchSet: 1
Gerrit-Owner: Timofey Komarov <happycorsair(a)yandex.ru>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <felixsinger(a)posteo.net>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Timofey Komarov <happycorsair(a)yandex.ru>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Tue, 27 Apr 2021 12:21:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/52707 )
Change subject: mb/prodrive/hermes: Send EOP at end of romstage
......................................................................
mb/prodrive/hermes: Send EOP at end of romstage
Allows to boot with CSME, which doesn't like ramstage and requests a global
reset on receiving EOP.
By requesting EOP in romstage, where ME is still fine, the system will boot with the
ME not in Normal mode.
Change-Id: I7312cda57e83d5acfeaaf1db4e788c913a6f62fb
Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com>
---
M src/mainboard/prodrive/hermes/ramstage.c
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/52707/1
diff --git a/src/mainboard/prodrive/hermes/ramstage.c b/src/mainboard/prodrive/hermes/ramstage.c
index 917f3b9..b827eea 100644
--- a/src/mainboard/prodrive/hermes/ramstage.c
+++ b/src/mainboard/prodrive/hermes/ramstage.c
@@ -13,6 +13,7 @@
program_gpio_pads();
params->SataLedEnable = 1;
+ supd->FspsTestConfig.EndOfPostMessage = 1;
/* Overwrite params */
if (!check_signature(offsetof(struct eeprom_layout, supd), FSPS_UPD_SIGNATURE))
--
To view, visit https://review.coreboot.org/c/coreboot/+/52707
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7312cda57e83d5acfeaaf1db4e788c913a6f62fb
Gerrit-Change-Number: 52707
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-MessageType: newchange
Attention is currently required from: Justin van Son, Patrick Rudolph, Christian Walter.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52549 )
Change subject: [TESTME] mb/prodrive/hermes: Fix R04 internal audio verb
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/prodrive/hermes/variants/r04/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/52549/comment/35cc047e_ca0784ec
PS1, Line 42: return 0x90100140;
> I'm still looking into this, probably we'll need a different verb.
Alright. Leaving this comment open until we know which verb to use.
--
To view, visit https://review.coreboot.org/c/coreboot/+/52549
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia9bf86aaa927500f3044edffffe9ad05607eeabb
Gerrit-Change-Number: 52549
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Justin van Son <justin.van.son(a)prodrive-technologies.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Justin van Son <justin.van.son(a)prodrive-technologies.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Comment-Date: Tue, 27 Apr 2021 11:51:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Justin van Son <justin.van.son(a)prodrive-technologies.com>
Gerrit-MessageType: comment
Attention is currently required from: Patrick Rudolph, Christian Walter, Angel Pons.
Justin van Son has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52549 )
Change subject: [TESTME] mb/prodrive/hermes: Fix R04 internal audio verb
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/prodrive/hermes/variants/r04/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/52549/comment/8af254d5_b42da1f4
PS1, Line 42: return 0x90100140;
I'm still looking into this, probably we'll need a different verb.
--
To view, visit https://review.coreboot.org/c/coreboot/+/52549
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia9bf86aaa927500f3044edffffe9ad05607eeabb
Gerrit-Change-Number: 52549
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Justin van Son <justin.van.son(a)prodrive-technologies.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Tue, 27 Apr 2021 11:48:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Rex-BC Chen, Yidi Lin.
Hello Hung-Te Lin, build bot (Jenkins), Yu-Ping Wu, Yidi Lin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/52668
to look at the new patch set (#3).
Change subject: soc/mediatek/mt8195: add pmif/spmi/pmic driver
......................................................................
soc/mediatek/mt8195: add pmif/spmi/pmic driver
MT8195 uses power management interface (PMIF) to access pmics by spmi
and spi, so we add pmif driver to control pmics.
Signed-off-by: henryc.chen <henryc.chen(a)mediatek.com>
Signed-off-by: Yidi Lin <yidi.lin(a)mediatek.com>
Change-Id: I73f9c9bf92837f262c15758f16dacf52261dd3a3
---
M src/mainboard/google/cherry/Makefile.inc
A src/mainboard/google/cherry/romstage.c
M src/soc/mediatek/common/include/soc/pmif_spmi.h
M src/soc/mediatek/mt8195/Makefile.inc
M src/soc/mediatek/mt8195/include/soc/addressmap.h
A src/soc/mediatek/mt8195/include/soc/iocfg.h
A src/soc/mediatek/mt8195/include/soc/pmif.h
A src/soc/mediatek/mt8195/mt6315.c
A src/soc/mediatek/mt8195/mt6359p.c
A src/soc/mediatek/mt8195/pmif_clk.c
A src/soc/mediatek/mt8195/pmif_spi.c
A src/soc/mediatek/mt8195/pmif_spmi.c
12 files changed, 945 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/52668/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/52668
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I73f9c9bf92837f262c15758f16dacf52261dd3a3
Gerrit-Change-Number: 52668
Gerrit-PatchSet: 3
Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidi.lin(a)mediatek.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-Attention: Yidi Lin <yidi.lin(a)mediatek.com>
Gerrit-MessageType: newpatchset