mail.coreboot.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2024
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
List overview
Download
coreboot-gerrit
April 2021
----- 2024 -----
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
coreboot-gerrit@coreboot.org
1 participants
6269 discussions
Start a n
N
ew thread
Change in coreboot[master]: sb/intel/common: Refactor _PRT generation to support GSI-based tables
by Nico Huber (Code Review)
27 Apr '21
27 Apr '21
Nico Huber has submitted this change. (
https://review.coreboot.org/c/coreboot/+/50857
) Change subject: sb/intel/common: Refactor _PRT generation to support GSI-based tables ...................................................................... sb/intel/common: Refactor _PRT generation to support GSI-based tables Newer Intel SoCs also support _PRT tables, but they route PCI devices to more than just PIRQs, and statically specify IRQs instead of using link devices. Extend/refactor intel_acpi_gen_def_acpi_pirq to support this additional use case. Signed-off-by: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Change-Id: Ica420a3d12fd1d64c8fe6e4b326fd779b3f10868 Reviewed-on:
https://review.coreboot.org/c/coreboot/+/50857
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-by: Nico Huber <nico.h(a)gmx.de> --- M src/southbridge/intel/bd82x6x/lpc.c M src/southbridge/intel/common/acpi_pirq_gen.c M src/southbridge/intel/common/acpi_pirq_gen.h M src/southbridge/intel/common/rcba_pirq.c M src/southbridge/intel/common/rcba_pirq.h M src/southbridge/intel/i82801gx/lpc.c M src/southbridge/intel/i82801ix/lpc.c M src/southbridge/intel/i82801jx/lpc.c M src/southbridge/intel/ibexpeak/lpc.c M src/southbridge/intel/lynxpoint/lpc.c 10 files changed, 174 insertions(+), 79 deletions(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Angel Pons: Looks good to me, approved diff --git a/src/southbridge/intel/bd82x6x/lpc.c b/src/southbridge/intel/bd82x6x/lpc.c index 4ba8863..43d0e04 100644 --- a/src/southbridge/intel/bd82x6x/lpc.c +++ b/src/southbridge/intel/bd82x6x/lpc.c @@ -21,6 +21,7 @@ #include <southbridge/intel/common/pciehp.h> #include <southbridge/intel/common/acpi_pirq_gen.h> #include <southbridge/intel/common/pmutil.h> +#include <southbridge/intel/common/rcba_pirq.h> #include <southbridge/intel/common/rtc.h> #include <southbridge/intel/common/spi.h> #include <types.h> diff --git a/src/southbridge/intel/common/acpi_pirq_gen.c b/src/southbridge/intel/common/acpi_pirq_gen.c index 18def9b..852ab85 100644 --- a/src/southbridge/intel/common/acpi_pirq_gen.c +++ b/src/southbridge/intel/common/acpi_pirq_gen.c @@ -2,101 +2,78 @@ #include <acpi/acpigen.h> #include <acpi/acpigen_pci.h> -#include <console/console.h> #include <device/pci_def.h> #include <device/pci_ops.h> #include <string.h> #include "acpi_pirq_gen.h" -enum emit_type { - EMIT_APIC, - EMIT_PICM, -}; - -static int create_pirq_matrix(char matrix[32][4]) +static void gen_apic_route(const struct slot_pin_irq_map *pin_irq_map, + unsigned int map_count) { - struct device *dev; - int num_devs = 0; + for (unsigned int i = 0; i < map_count; i++) + /* + * The reason for subtracting PCI_INT_A from the pin given is + * that PCI defines pins as 1-4, and _PRT uses 0-3. + */ + acpigen_write_PRT_GSI_entry(pin_irq_map[i].slot, + pin_irq_map[i].pin - PCI_INT_A, + pin_irq_map[i].apic_gsi); +} - for (dev = pcidev_on_root(0, 0); dev; dev = dev->sibling) { - u8 pci_dev; - u8 int_pin; - - pci_dev = PCI_SLOT(dev->path.pci.devfn); - int_pin = pci_read_config8(dev, PCI_INTERRUPT_PIN); - - if (int_pin == PCI_INT_NONE || int_pin > PCI_INT_D || - matrix[pci_dev][int_pin - PCI_INT_A] - != PIRQ_NONE) +static void gen_pic_route(const struct slot_pin_irq_map *pin_irq_map, + unsigned int map_count, + const struct pic_pirq_map *pirq_map) +{ + for (unsigned int i = 0; i < map_count; i++) { + enum pirq pirq = pin_irq_map[i].pic_pirq; + unsigned int pin = pin_irq_map[i].pin - PCI_INT_A; + if (pirq == PIRQ_INVALID) continue; - matrix[pci_dev][int_pin - PCI_INT_A] = - intel_common_map_pirq(dev, int_pin); - printk(BIOS_SPEW, "ACPI_PIRQ_GEN: %s: pin=%d pirq=%d\n", - dev_path(dev), int_pin - PCI_INT_A, - matrix[pci_dev][int_pin - PCI_INT_A] - PIRQ_A); - num_devs++; - } - return num_devs; -} - -static void gen_pirq_route(const enum emit_type emit, const char *lpcb_path, - char pci_int_mapping[32][4]) -{ - int pci_dev, int_pin; - char buffer[DEVICE_PATH_MAX]; - char pirq; - - for (pci_dev = 0; pci_dev < 32; pci_dev++) { - for (int_pin = 0; int_pin < 4; int_pin++) { - pirq = pci_int_mapping[pci_dev][int_pin]; - if (pirq == PIRQ_NONE) - continue; - - if (emit == EMIT_APIC) { - const unsigned int gsi = 16 + pirq - PIRQ_A; - acpigen_write_PRT_GSI_entry(pci_dev, int_pin, gsi); - } else { - snprintf(buffer, sizeof(buffer), - "%s.LNK%c", - lpcb_path, 'A' + pirq - PIRQ_A); - acpigen_write_PRT_source_entry(pci_dev, int_pin, buffer, 0); - } - } + if (pirq_map->type == PIRQ_GSI) + acpigen_write_PRT_GSI_entry(pin_irq_map[i].slot, + pin, + pirq_map->gsi[pirq]); + else + acpigen_write_PRT_source_entry(pin_irq_map[i].slot, + pin, + pirq_map->source_path[pirq], + 0); } } -void intel_acpi_gen_def_acpi_pirq(const struct device *dev) +void intel_write_pci0_PRT(const struct slot_pin_irq_map *pin_irq_map, + unsigned int map_count, + const struct pic_pirq_map *pirq_map) { - const char *lpcb_path = acpi_device_path(dev); - char pci_int_mapping[32][4]; - int num_devs; - - printk(BIOS_DEBUG, "Generating ACPI PIRQ entries\n"); - - if (!lpcb_path) { - printk(BIOS_ERR, "ACPI_PIRQ_GEN: Missing LPCB ACPI path\n"); - return; - } - - memset(pci_int_mapping, 0, sizeof(pci_int_mapping)); - num_devs = create_pirq_matrix(pci_int_mapping); - + /* \_SB.PCI0._PRT */ acpigen_write_scope("\\_SB.PCI0"); acpigen_write_method("_PRT", 0); acpigen_write_if(); acpigen_emit_namestring("PICM"); acpigen_emit_byte(RETURN_OP); - acpigen_write_package(num_devs); - gen_pirq_route(EMIT_APIC, lpcb_path, pci_int_mapping); + acpigen_write_package(map_count); + gen_apic_route(pin_irq_map, map_count); acpigen_pop_len(); /* package */ acpigen_write_else(); acpigen_emit_byte(RETURN_OP); - acpigen_write_package(num_devs); - gen_pirq_route(EMIT_PICM, lpcb_path, pci_int_mapping); + acpigen_write_package(map_count); + gen_pic_route(pin_irq_map, map_count, pirq_map); acpigen_pop_len(); /* package */ acpigen_pop_len(); /* else PICM */ acpigen_pop_len(); /* _PRT */ acpigen_pop_len(); /* \_SB */ } + +bool is_slot_pin_assigned(const struct slot_pin_irq_map *pin_irq_map, + unsigned int map_count, unsigned int slot, + enum pci_pin pin) +{ + for (size_t i = 0; i < map_count; i++) { + if (pin_irq_map[i].slot == slot && pin_irq_map[i].pin == pin) + return true; + } + + return false; +} diff --git a/src/southbridge/intel/common/acpi_pirq_gen.h b/src/southbridge/intel/common/acpi_pirq_gen.h index 3fc6b77..83476d1 100644 --- a/src/southbridge/intel/common/acpi_pirq_gen.h +++ b/src/southbridge/intel/common/acpi_pirq_gen.h @@ -3,16 +3,20 @@ #ifndef INTEL_COMMON_ACPI_PIRQ_GEN_H #define INTEL_COMMON_ACPI_PIRQ_GEN_H +#include <device/device.h> + +#define MAX_SLOTS 32 + enum pci_pin { PCI_INT_NONE = 0, PCI_INT_A, PCI_INT_B, PCI_INT_C, PCI_INT_D, + PCI_INT_MAX = PCI_INT_D, }; enum pirq { - PIRQ_NONE = 0, PIRQ_A, PIRQ_B, PIRQ_C, @@ -21,10 +25,63 @@ PIRQ_F, PIRQ_G, PIRQ_H, + PIRQ_COUNT, + PIRQ_INVALID = 0xff, }; -void intel_acpi_gen_def_acpi_pirq(const struct device *dev); -enum pirq intel_common_map_pirq(const struct device *dev, - const enum pci_pin pci_pin); +/* + * This struct represents an assignment of slot/pin -> IRQ. Some chipsets may + * want to provide both PIC-mode and APIC-mode IRQs (e.g. selected using PICM + * set by the OS), therefore a field for each of a PIRQ for PIC-mode and a + * GSI for APIC-mode are provided. + * + * For APIC mode, only GSIs are supported (`acpi_gsi`). + * + * For PIC mode, if the pirq_map_type is PIRQ_GSI, then `pic_pirq` is used as an + * index into `struct pic_pirq_map.gsi`, or for SOURCE_PATH, `pic_pirq` indexes + * into `struct pic_pirq_map.source_path` to pick the path to the LNKx device. + * + * The reasoning for this structure is related to older vs. newer Intel + * platforms; older platforms supported routing of PCI IRQs to a PIRQ + * only. Newer platforms support routing IRQs to either a PIRQ or (for some PCI + * devices) a non-PIRQ GSI. + */ +struct slot_pin_irq_map { + unsigned int slot; + enum pci_pin pin; + /* PIRQ # for PIC mode */ + unsigned int pic_pirq; + /* GSI # for APIC mode */ + unsigned int apic_gsi; +}; + +enum pirq_map_type { + PIRQ_GSI, + PIRQ_SOURCE_PATH, +}; + +/* + * A PIRQ can be either be statically assigned a GSI or OSPM can use the Methods + * on the ACPI device (source_path) to assign IRQs at runtime. + */ +struct pic_pirq_map { + enum pirq_map_type type; + union { + unsigned int gsi[PIRQ_COUNT]; + char source_path[PIRQ_COUNT][DEVICE_PATH_MAX]; + }; +}; + +/* + * Generate an ACPI _PRT table by providing PIRQ and/or GSI information for each + * slot/pin combination, and optionally providing paths to LNKx devices that can + * provide IRQs in PIC mode. + */ +void intel_write_pci0_PRT(const struct slot_pin_irq_map *pin_irq_map, + unsigned int map_count, + const struct pic_pirq_map *pirq_map); + +bool is_slot_pin_assigned(const struct slot_pin_irq_map *pin_irq_map, + unsigned int map_count, unsigned int slot, unsigned int pin); #endif diff --git a/src/southbridge/intel/common/rcba_pirq.c b/src/southbridge/intel/common/rcba_pirq.c index 42e4edc..1037231 100644 --- a/src/southbridge/intel/common/rcba_pirq.c +++ b/src/southbridge/intel/common/rcba_pirq.c @@ -1,8 +1,10 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#include <acpi/acpi_device.h> #include <console/console.h> #include <device/device.h> #include <device/pci.h> +#include <stdlib.h> #include <southbridge/intel/common/acpi_pirq_gen.h> #include <southbridge/intel/common/rcba_pirq.h> #include <southbridge/intel/common/rcba.h> @@ -15,7 +17,7 @@ D26IR, D27IR, D28IR, D29IR, D30IR, D31IR, }; -enum pirq intel_common_map_pirq(const struct device *dev, const enum pci_pin pci_pin) +static enum pirq map_pirq(const struct device *dev, const enum pci_pin pci_pin) { u8 slot = PCI_SLOT(dev->path.pci.devfn); u8 shift = 4 * (pci_pin - PCI_INT_A); @@ -25,18 +27,66 @@ if (pci_pin < PCI_INT_A || pci_pin > PCI_INT_D) { printk(BIOS_ERR, "ACPI_PIRQ_GEN: Slot %d PCI pin %d out of bounds\n", slot, pci_pin); - return PIRQ_NONE; + return PIRQ_INVALID; } /* Slot 24 should not exist and has no D24IR but better be safe here */ if (slot < MIN_SLOT || slot > MAX_SLOT || slot == 24) { /* non-PCH devices use 1:1 mapping. */ - return (enum pirq)pci_pin; + return (enum pirq)(pci_pin - PCI_INT_A); } reg = pirq_dir_route_reg[slot - MIN_SLOT]; pirq = (RCBA16(reg) >> shift) & 0x7; - return (enum pirq)(PIRQ_A + pirq); + return (enum pirq)pirq; +} + +void intel_acpi_gen_def_acpi_pirq(const struct device *lpc) +{ + struct slot_pin_irq_map *pin_irq_map; + const char *lpcb_path = acpi_device_path(lpc); + struct pic_pirq_map pirq_map = {0}; + unsigned int map_count = 0; + int i; + + if (!lpcb_path) { + printk(BIOS_ERR, "ACPI_PIRQ_GEN: Missing LPCB ACPI path\n"); + return; + } + + printk(BIOS_DEBUG, "Generating ACPI PIRQ entries\n"); + + pin_irq_map = calloc(sizeof(struct slot_pin_irq_map), MAX_SLOTS * PCI_INT_MAX); + pirq_map.type = PIRQ_SOURCE_PATH; + for (i = 0; i < PIRQ_COUNT; i++) + snprintf(pirq_map.source_path[i], sizeof(pirq_map.source_path[i]), + "%s.LNK%c", lpcb_path, 'A' + i); + + for (struct device *dev = pcidev_on_root(0, 0); dev; dev = dev->sibling) { + const u8 pci_dev = PCI_SLOT(dev->path.pci.devfn); + const u8 int_pin = pci_read_config8(dev, PCI_INTERRUPT_PIN); + + if (int_pin < PCI_INT_A || int_pin > PCI_INT_D) + continue; + + if (is_slot_pin_assigned(pin_irq_map, map_count, pci_dev, int_pin)) + continue; + + enum pirq pirq = map_pirq(dev, int_pin); + pin_irq_map[map_count].slot = pci_dev; + pin_irq_map[map_count].pin = (enum pci_pin)int_pin; + pin_irq_map[map_count].pic_pirq = pirq; + /* PIRQs are mapped to GSIs starting at 16 */ + pin_irq_map[map_count].apic_gsi = 16 + (unsigned int)pirq; + printk(BIOS_SPEW, "ACPI_PIRQ_GEN: %s: pin=%d pirq=%d\n", + dev_path(dev), int_pin - PCI_INT_A, + pin_irq_map[map_count].pic_pirq); + map_count++; + } + + intel_write_pci0_PRT(pin_irq_map, map_count, &pirq_map); + + free(pin_irq_map); } diff --git a/src/southbridge/intel/common/rcba_pirq.h b/src/southbridge/intel/common/rcba_pirq.h index 34d864c..eb6d0b8 100644 --- a/src/southbridge/intel/common/rcba_pirq.h +++ b/src/southbridge/intel/common/rcba_pirq.h @@ -3,6 +3,8 @@ #ifndef SOUTHBRIDGE_INTEL_COMMON_RCBA_PIRQ_H #define SOUTHBRIDGE_INTEL_COMMON_RCBA_PIRQ_H +#include <device/device.h> + /* * The DnnIR registers use common RCBA offsets across these chipsets: * bd82x6x, i82801, i89xx, ibexpeak, lynxpoint @@ -23,4 +25,7 @@ #define D20IR 0x3160 /* 16bit */ #define D19IR 0x3168 /* 16bit */ +/* Generate an ACPI _PRT table for chipsets that use PIRQs exclusively */ +void intel_acpi_gen_def_acpi_pirq(const struct device *dev); + #endif /* SOUTHBRIDGE_INTEL_COMMON_RCBA_PIRQ_H */ diff --git a/src/southbridge/intel/i82801gx/lpc.c b/src/southbridge/intel/i82801gx/lpc.c index 08019ac..9c3b0e9 100644 --- a/src/southbridge/intel/i82801gx/lpc.c +++ b/src/southbridge/intel/i82801gx/lpc.c @@ -16,6 +16,7 @@ #include <acpi/acpigen.h> #include <arch/smp/mpspec.h> #include <southbridge/intel/common/acpi_pirq_gen.h> +#include <southbridge/intel/common/rcba_pirq.h> #include <southbridge/intel/common/hpet.h> #include <southbridge/intel/common/pmbase.h> #include <southbridge/intel/common/spi.h> diff --git a/src/southbridge/intel/i82801ix/lpc.c b/src/southbridge/intel/i82801ix/lpc.c index 667d81d..32d4efc 100644 --- a/src/southbridge/intel/i82801ix/lpc.c +++ b/src/southbridge/intel/i82801ix/lpc.c @@ -19,6 +19,7 @@ #include <southbridge/intel/common/pciehp.h> #include <southbridge/intel/common/pmutil.h> #include <southbridge/intel/common/acpi_pirq_gen.h> +#include <southbridge/intel/common/rcba_pirq.h> #define NMI_OFF 0 diff --git a/src/southbridge/intel/i82801jx/lpc.c b/src/southbridge/intel/i82801jx/lpc.c index f70636d..55b4746 100644 --- a/src/southbridge/intel/i82801jx/lpc.c +++ b/src/southbridge/intel/i82801jx/lpc.c @@ -20,6 +20,7 @@ #include <southbridge/intel/common/pciehp.h> #include <southbridge/intel/common/pmutil.h> #include <southbridge/intel/common/acpi_pirq_gen.h> +#include <southbridge/intel/common/rcba_pirq.h> #define NMI_OFF 0 diff --git a/src/southbridge/intel/ibexpeak/lpc.c b/src/southbridge/intel/ibexpeak/lpc.c index ae3233c..6fe44c6 100644 --- a/src/southbridge/intel/ibexpeak/lpc.c +++ b/src/southbridge/intel/ibexpeak/lpc.c @@ -21,6 +21,7 @@ #include <southbridge/intel/common/pciehp.h> #include <southbridge/intel/common/acpi_pirq_gen.h> #include <southbridge/intel/common/spi.h> +#include <southbridge/intel/common/rcba_pirq.h> #define NMI_OFF 0 diff --git a/src/southbridge/intel/lynxpoint/lpc.c b/src/southbridge/intel/lynxpoint/lpc.c index 71e4d74..8d9b451 100644 --- a/src/southbridge/intel/lynxpoint/lpc.c +++ b/src/southbridge/intel/lynxpoint/lpc.c @@ -17,6 +17,7 @@ #include "pch.h" #include <acpi/acpigen.h> #include <southbridge/intel/common/acpi_pirq_gen.h> +#include <southbridge/intel/common/rcba_pirq.h> #include <southbridge/intel/common/rtc.h> #include <southbridge/intel/common/spi.h> #include <types.h> -- To view, visit
https://review.coreboot.org/c/coreboot/+/50857
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ica420a3d12fd1d64c8fe6e4b326fd779b3f10868 Gerrit-Change-Number: 50857 Gerrit-PatchSet: 22 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged
1
0
0
0
Change in coreboot[master]: sb/intel/common: Refactor _PRT generation to support GSI-based tables
by Nico Huber (Code Review)
27 Apr '21
27 Apr '21
Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Patrick Rudolph. Nico Huber has posted comments on this change. (
https://review.coreboot.org/c/coreboot/+/50857
) Change subject: sb/intel/common: Refactor _PRT generation to support GSI-based tables ...................................................................... Patch Set 21: Code-Review+2 -- To view, visit
https://review.coreboot.org/c/coreboot/+/50857
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ica420a3d12fd1d64c8fe6e4b326fd779b3f10868 Gerrit-Change-Number: 50857 Gerrit-PatchSet: 21 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Tue, 27 Apr 2021 11:06:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1
0
0
0
Change in coreboot[master]: drivers/intel/gma/Kconfig: Simplify conditions
by Felix Singer (Code Review)
27 Apr '21
27 Apr '21
Attention is currently required from: Angel Pons, Patrick Rudolph. Felix Singer has posted comments on this change. (
https://review.coreboot.org/c/coreboot/+/52704
) Change subject: drivers/intel/gma/Kconfig: Simplify conditions ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit
https://review.coreboot.org/c/coreboot/+/52704
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie69bde31b58bbd973db00bd578a51477c5b21cab Gerrit-Change-Number: 52704 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Timofey Komarov <happycorsair(a)yandex.ru> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Tue, 27 Apr 2021 10:55:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1
0
0
0
Change in coreboot[master]: soc/intel: Add Z370, H310C and B365 device IDs
by Felix Singer (Code Review)
27 Apr '21
27 Apr '21
Attention is currently required from: Angel Pons, Patrick Rudolph. Felix Singer has posted comments on this change. (
https://review.coreboot.org/c/coreboot/+/52703
) Change subject: soc/intel: Add Z370, H310C and B365 device IDs ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit
https://review.coreboot.org/c/coreboot/+/52703
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iea3c435713c46854c5271fbc266f47ba4573db52 Gerrit-Change-Number: 52703 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Timofey Komarov <happycorsair(a)yandex.ru> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Tue, 27 Apr 2021 10:51:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1
0
0
0
Change in coreboot[master]: soc/intel: Add Kaby Lake PCH-U base device ID
by Felix Singer (Code Review)
27 Apr '21
27 Apr '21
Attention is currently required from: Angel Pons, Patrick Rudolph. Felix Singer has posted comments on this change. (
https://review.coreboot.org/c/coreboot/+/52702
) Change subject: soc/intel: Add Kaby Lake PCH-U base device ID ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit
https://review.coreboot.org/c/coreboot/+/52702
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1d48c8868e1e5d453d599ecec835938ce09935d0 Gerrit-Change-Number: 52702 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Timofey Komarov <happycorsair(a)yandex.ru> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Tue, 27 Apr 2021 10:50:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1
0
0
0
Change in coreboot[master]: soc/intel/skylake: Shorten report_platform PCH-H names
by Felix Singer (Code Review)
27 Apr '21
27 Apr '21
Attention is currently required from: Angel Pons, Patrick Rudolph. Felix Singer has posted comments on this change. (
https://review.coreboot.org/c/coreboot/+/52701
) Change subject: soc/intel/skylake: Shorten report_platform PCH-H names ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit
https://review.coreboot.org/c/coreboot/+/52701
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib9e96683e3cb0b63a11344f3b5383292bff88e13 Gerrit-Change-Number: 52701 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Timofey Komarov <happycorsair(a)yandex.ru> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Tue, 27 Apr 2021 10:49:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1
0
0
0
Change in coreboot[master]: soc/intel: Rename 200-series PCH device IDs
by Felix Singer (Code Review)
27 Apr '21
27 Apr '21
Attention is currently required from: Angel Pons, Patrick Rudolph. Felix Singer has posted comments on this change. (
https://review.coreboot.org/c/coreboot/+/52700
) Change subject: soc/intel: Rename 200-series PCH device IDs ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit
https://review.coreboot.org/c/coreboot/+/52700
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1a49115ae7ac37e76ce8d440910fb59926f34fac Gerrit-Change-Number: 52700 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Timofey Komarov <happycorsair(a)yandex.ru> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Tue, 27 Apr 2021 10:48:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1
0
0
0
Change in coreboot[master]: soc/intel/skylake: Drop Lewisburg PCHs from report_platform
by Felix Singer (Code Review)
27 Apr '21
27 Apr '21
Attention is currently required from: Timofey Komarov, Angel Pons, Patrick Rudolph. Felix Singer has posted comments on this change. (
https://review.coreboot.org/c/coreboot/+/52699
) Change subject: soc/intel/skylake: Drop Lewisburg PCHs from report_platform ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit
https://review.coreboot.org/c/coreboot/+/52699
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I05f67cd57aa9f867e2fab88cd49e0384073a0b20 Gerrit-Change-Number: 52699 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Timofey Komarov <happycorsair(a)yandex.ru> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Timofey Komarov <happycorsair(a)yandex.ru> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Tue, 27 Apr 2021 10:47:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1
0
0
0
Change in coreboot[master]: Add Amberlake Kconfig option and some FSP config changes
by Angel Pons (Code Review)
27 Apr '21
27 Apr '21
Attention is currently required from: Timofey Komarov, Patrick Rudolph. Angel Pons has posted comments on this change. (
https://review.coreboot.org/c/coreboot/+/52692
) Change subject: Add Amberlake Kconfig option and some FSP config changes ...................................................................... Patch Set 1: (1 comment) File src/soc/intel/skylake/Kconfig:
https://review.coreboot.org/c/coreboot/+/52692/comment/b9946fd7_ad817a84
PS1, Line 95: default 8 > Needs an update: […] Actually, I think it's better to adjust this in CB:52693 as follows: config MAX_CPUS int default 16 if MAINBOARD_SUPPORTS_COFFEELAKE_CPU default 8 -- To view, visit
https://review.coreboot.org/c/coreboot/+/52692
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7b6b9c676da55088cb5a12a218ea58d349ee440c Gerrit-Change-Number: 52692 Gerrit-PatchSet: 1 Gerrit-Owner: Timofey Komarov <happycorsair(a)yandex.ru> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Timofey Komarov <happycorsair(a)yandex.ru> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Tue, 27 Apr 2021 10:29:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment
1
0
0
0
Change in coreboot[master]: Add microcodes for Coffeelake CPUs
by Angel Pons (Code Review)
27 Apr '21
27 Apr '21
Attention is currently required from: Timofey Komarov, Patrick Rudolph. Angel Pons has posted comments on this change. (
https://review.coreboot.org/c/coreboot/+/52693
) Change subject: Add microcodes for Coffeelake CPUs ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message:
https://review.coreboot.org/c/coreboot/+/52693/comment/8ef7f82a_2492b198
PS1, Line 7: Add microcodes for Coffeelake CPUs nit: Add a prefix, and spell it as `Coffee Lake`: soc/intel/skylake: Add microcodes for Coffee Lake CPUs -- To view, visit
https://review.coreboot.org/c/coreboot/+/52693
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I479c648e40c4c607d29f8cdd913fdbd6d7d7d991 Gerrit-Change-Number: 52693 Gerrit-PatchSet: 1 Gerrit-Owner: Timofey Komarov <happycorsair(a)yandex.ru> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Timofey Komarov <happycorsair(a)yandex.ru> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Tue, 27 Apr 2021 10:24:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1
0
0
0
← Newer
1
...
151
152
153
154
155
156
157
...
627
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
Results per page:
10
25
50
100
200