Attention is currently required from: Timofey Komarov, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52693 )
Change subject: soc/intel/skylake: Add microcodes for Coffee Lake CPUs
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52693/comment/7bb61a68_956686f4
PS5, Line 8:
It would be good to mention why this change is needed
--
To view, visit https://review.coreboot.org/c/coreboot/+/52693
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I479c648e40c4c607d29f8cdd913fdbd6d7d7d991
Gerrit-Change-Number: 52693
Gerrit-PatchSet: 5
Gerrit-Owner: Timofey Komarov <happycorsair(a)yandex.ru>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Timofey Komarov <happycorsair(a)yandex.ru>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Tue, 27 Apr 2021 20:33:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Patrick Rudolph.
Hello Felix Singer, Timofey Komarov, build bot (Jenkins), Nico Huber, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/52704
to look at the new patch set (#3).
Change subject: drivers/intel/gma/Kconfig: Simplify Skylake/Kaby Lake conditions
......................................................................
drivers/intel/gma/Kconfig: Simplify Skylake/Kaby Lake conditions
Use `SOC_INTEL_COMMON_SKYLAKE_BASE` to simplify conditions.
Change-Id: Ie69bde31b58bbd973db00bd578a51477c5b21cab
Signed-off-by: Angel Pons <th3fanbus(a)gmail.com>
---
M src/drivers/intel/gma/Kconfig
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/52704/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/52704
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie69bde31b58bbd973db00bd578a51477c5b21cab
Gerrit-Change-Number: 52704
Gerrit-PatchSet: 3
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Timofey Komarov <happycorsair(a)yandex.ru>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Angel Pons, Patrick Rudolph.
Hello Felix Singer, Timofey Komarov, build bot (Jenkins), Nico Huber, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/52704
to look at the new patch set (#2).
Change subject: drivers/intel/gma/Kconfig: Simplify Skylake/Kaby Lake conditions
......................................................................
drivers/intel/gma/Kconfig: Simplify Skylake/Kaby Lake conditions
Use `SOC_INTEL_COMMON_SKYLAKE_BASE` to simplify conditions.
Change-Id: Ie69bde31b58bbd973db00bd578a51477c5b21cab
Signed-off-by: Angel Pons <th3fanbus(a)gmail.com>
---
M src/drivers/intel/gma/Kconfig
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/52704/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/52704
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie69bde31b58bbd973db00bd578a51477c5b21cab
Gerrit-Change-Number: 52704
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Timofey Komarov <happycorsair(a)yandex.ru>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Nico Huber, Michael Niewöhner, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52679 )
Change subject: docs/mb/supermicro/x11ssm-f: rework flashing section
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/52679
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I37d55ffdbcfba4f3a1113a82f16ec8766bbb6e6c
Gerrit-Change-Number: 52679
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Tue, 27 Apr 2021 20:25:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Nico Huber, Angel Pons, Patrick Rudolph.
Timofey Komarov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52692 )
Change subject: soc/intel/skylake: Allow to use Amber Lake FSP
......................................................................
Patch Set 5:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52692/comment/ba2b4138_ef5eb132
PS1, Line 7: Add Amberlake Kconfig option and some FSP config changes
> CB:52704 takes care of the drivers/intel/gma stuff, so this change would only need to touch soc/inte […]
Done
File src/drivers/intel/gma/Kconfig:
https://review.coreboot.org/c/coreboot/+/52692/comment/b8d0a19d_5e0c6b4c
PS1, Line 88: SOC_INTEL_SKYLAKE
> Probably better to just change this to SOC_INTEL_COMMON_SKYLAKE_BASE.
This change moved to https://review.coreboot.org/c/coreboot/+/52704/https://review.coreboot.org/c/coreboot/+/52692/comment/267876d2_fc996e6f
PS1, Line 117: SOC_INTEL_SKYLAKE
> This too.
This change moved to https://review.coreboot.org/c/coreboot/+/52704/
File src/soc/intel/skylake/Kconfig:
https://review.coreboot.org/c/coreboot/+/52692/comment/6313fdef_a356b958
PS1, Line 95: default 8
> Actually, I think it's better to adjust this in CB:52693 as follows: […]
Done
https://review.coreboot.org/c/coreboot/+/52692/comment/485be9ed_1cb6eab1
PS1, Line 95: default 8
> Actually, I think it's better to adjust this in CB:52693 as follows: […]
Done
https://review.coreboot.org/c/coreboot/+/52692/comment/9e29448f_9192fec7
PS1, Line 264: default "3rdparty/fsp/AmberLakeFspBinPkg/Fsp.fd" if SOC_INTEL_AMBERLAKE
> I'd prefer to only add a condition for Amber Lake: […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/52692
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7b6b9c676da55088cb5a12a218ea58d349ee440c
Gerrit-Change-Number: 52692
Gerrit-PatchSet: 5
Gerrit-Owner: Timofey Komarov <happycorsair(a)yandex.ru>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <felixsinger(a)posteo.net>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Tue, 27 Apr 2021 19:55:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment