Attention is currently required from: Henry Sun, Karthik Ramasubramanian.
Frank Chu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52565 )
Change subject: mb/google/dedede/var/galith: Support Wifi SAR for DVT phase
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/dedede/variants/galtic/variant.c:
https://review.coreboot.org/c/coreboot/+/52565/comment/01cdd680_501e5ce7
PS1, Line 8: if (fw_config_probe(FW_CONFIG(TABLETMODE, TABLETMODE_DISABLED)))
: return "wifi_sar-galtic.hex";
> If that is the case, why can't we just return "wifi_sar-galtic.hex" for now. […]
that's right, this modification is to consider upgrading different cases in the future and for minimum modification,
if we have other define method for suport more wifi SAR later, we can only return wifi_sar-galtic.hex in this case
--
To view, visit https://review.coreboot.org/c/coreboot/+/52565
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic9bb76c207ef033f81ecdd57849535b8ac8d13ae
Gerrit-Change-Number: 52565
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com>
Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com>
Gerrit-CC: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com>
Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Wed, 28 Apr 2021 02:34:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Henry Sun, Paul2 Huang, Kirk Wang.
Alex1 Kao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52626 )
Change subject: mb/google/dedede: Create pirika variant
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/52626
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I57bf33deeadacc88800f9ce1d3d54385ba56c798
Gerrit-Change-Number: 52626
Gerrit-PatchSet: 1
Gerrit-Owner: Kirk Wang
Gerrit-Reviewer: Alex1 Kao <alex1_kao(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Kirk Wang <kirk_wang(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Paul2 Huang <paul2_huang(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Ariel Chang <ariel_chang(a)pegatron.corp-partner.google.com>
Gerrit-CC: Hao Chou <hao_chou(a)pegatron.corp-partner.google.com>
Gerrit-CC: Wayne3 Wang <wayne3_wang(a)pegatron.corp-partner.google.com>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: Paul2 Huang <paul2_huang(a)pegatron.corp-partner.google.com>
Gerrit-Attention: Kirk Wang
Gerrit-Comment-Date: Wed, 28 Apr 2021 02:14:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment