Attention is currently required from: Alexander Couzens, Patrick Rudolph, amersel.
Peter Lemenkov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52659 )
Change subject: mb/lenovo/w541: Add Lenovo Thinkpad W541
......................................................................
Patch Set 8:
(1 comment)
File src/mainboard/lenovo/w541/board_info.txt:
https://review.coreboot.org/c/coreboot/+/52659/comment/63bf404f_652a0efb
PS8, Line 2: FIXME: put ROM package, ROM socketed, ROM protocol, Flashrom support
One more thing. Could you please fill this up? I guess no flashrom support and what about the rest? Look at t440p/board_info.txt for the example.
--
To view, visit https://review.coreboot.org/c/coreboot/+/52659
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia43070f51bba3cf59ba9b7d9e29e4e778efbeb08
Gerrit-Change-Number: 52659
Gerrit-PatchSet: 8
Gerrit-Owner: amersel
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Peter Lemenkov <lemenkov(a)gmail.com>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: amersel
Gerrit-Comment-Date: Wed, 28 Apr 2021 09:03:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Yu-Ping Wu.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52722 )
Change subject: mb/google/asurada: Fix power on delay
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/52722
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If73747bdaec5ac069b048920d27e27178bc3cedc
Gerrit-Change-Number: 52722
Gerrit-PatchSet: 2
Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Wed, 28 Apr 2021 07:48:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
EricR Lai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/52726 )
Change subject: mb/google/brya: Add CHROMEOS_DRAM_PART_NUMBER_IN_CBI
......................................................................
mb/google/brya: Add CHROMEOS_DRAM_PART_NUMBER_IN_CBI
Brya is use CBI to store dram part number. So enable the config.
BUG=b:186571840
BRANCH=none
TEST=dmidecode -t 17 can show the dram part number.
Signed-off-by: Eric Lai <ericr_lai(a)compal.corp-partner.google.com>
Change-Id: I1b4fc4da31d8964763c3e671d84be71996fa5e2a
---
M src/mainboard/google/brya/Kconfig
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/52726/1
diff --git a/src/mainboard/google/brya/Kconfig b/src/mainboard/google/brya/Kconfig
index d53065f..567f15d 100644
--- a/src/mainboard/google/brya/Kconfig
+++ b/src/mainboard/google/brya/Kconfig
@@ -31,6 +31,7 @@
select SYSTEM_TYPE_LAPTOP
config CHROMEOS
+ select CHROMEOS_DRAM_PART_NUMBER_IN_CBI
select EC_GOOGLE_CHROMEEC_SWITCHES
select GBB_FLAG_DISABLE_EC_SOFTWARE_SYNC
select HAS_RECOVERY_MRC_CACHE
--
To view, visit https://review.coreboot.org/c/coreboot/+/52726
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1b4fc4da31d8964763c3e671d84be71996fa5e2a
Gerrit-Change-Number: 52726
Gerrit-PatchSet: 1
Gerrit-Owner: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-MessageType: newchange
Attention is currently required from: Tim Wawrzynczak.
Hello Tim Wawrzynczak,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/52725
to look at the new patch set (#2).
Change subject: mb/google/puff/var/dooly: enable touchscreen wakeup
......................................................................
mb/google/puff/var/dooly: enable touchscreen wakeup
Stop exposing ACPI Power Resouce for TS as a wake souce.
To ensure TS stays enabled across suspend-reumes.
BUG=b:186070097
BRANCH=puff
TEST=Build and make sure TS works. Touch TS can wakeup suspend/resume.
Change-Id: I2bbaab56924849a22a4d05ce53bf5bdcf00265dd
Signed-off-by: Tony Huang <tony-huang(a)quanta.corp-partner.google.com>
---
M src/mainboard/google/hatch/variants/dooly/gpio.c
M src/mainboard/google/hatch/variants/dooly/overridetree.cb
2 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/52725/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/52725
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2bbaab56924849a22a4d05ce53bf5bdcf00265dd
Gerrit-Change-Number: 52725
Gerrit-PatchSet: 2
Gerrit-Owner: Tony Huang <tony-huang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: newpatchset