Attention is currently required from: Keith Short, Li1 Feng, John Zhao, Tim Wawrzynczak.
Abe Levkoy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52716 )
Change subject: mb/google/volteer: Add EC_HOST_EVENT_USB_MUX
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/52716
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I53bd4fee21e2e2d1f16f558ab0341a50ef9a0e14
Gerrit-Change-Number: 52716
Gerrit-PatchSet: 1
Gerrit-Owner: John Zhao <john.zhao(a)intel.com>
Gerrit-Reviewer: Abe Levkoy <alevkoy(a)chromium.org>
Gerrit-Reviewer: Keith Short <keithshort(a)chromium.org>
Gerrit-Reviewer: Li1 Feng <li1.feng(a)intel.com>
Gerrit-Reviewer: Tanu Malhotra <tanu.malhotra(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Keith Short <keithshort(a)chromium.org>
Gerrit-Attention: Li1 Feng <li1.feng(a)intel.com>
Gerrit-Attention: John Zhao <john.zhao(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Comment-Date: Tue, 27 Apr 2021 22:01:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
John Zhao has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/52716 )
Change subject: mb/google/volteer: Add EC_HOST_EVENT_USB_MUX
......................................................................
mb/google/volteer: Add EC_HOST_EVENT_USB_MUX
This changes adds the EC_HOST_EVENT_USB_MUX to be dark resume source.
BUG=b:183140386
TEST=In S0ix, remove DP dongle, system does dark resume. AP and EC
synchronized. AP got port partner disconnection.
Signed-off-by: John Zhao <john.zhao(a)intel.com>
Change-Id: I53bd4fee21e2e2d1f16f558ab0341a50ef9a0e14
---
M src/mainboard/google/volteer/variants/baseboard/include/baseboard/ec.h
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/52716/1
diff --git a/src/mainboard/google/volteer/variants/baseboard/include/baseboard/ec.h b/src/mainboard/google/volteer/variants/baseboard/include/baseboard/ec.h
index 1428ec8..253ab68 100644
--- a/src/mainboard/google/volteer/variants/baseboard/include/baseboard/ec.h
+++ b/src/mainboard/google/volteer/variants/baseboard/include/baseboard/ec.h
@@ -37,6 +37,7 @@
EC_HOST_EVENT_MASK(EC_HOST_EVENT_AC_CONNECTED) |\
EC_HOST_EVENT_MASK(EC_HOST_EVENT_AC_DISCONNECTED) |\
EC_HOST_EVENT_MASK(EC_HOST_EVENT_KEY_PRESSED) |\
+ EC_HOST_EVENT_MASK(EC_HOST_EVENT_USB_MUX) |\
EC_HOST_EVENT_MASK(EC_HOST_EVENT_MODE_CHANGE))
#define MAINBOARD_EC_S0IX_WAKE_EVENTS (MAINBOARD_EC_S3_WAKE_EVENTS)
--
To view, visit https://review.coreboot.org/c/coreboot/+/52716
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I53bd4fee21e2e2d1f16f558ab0341a50ef9a0e14
Gerrit-Change-Number: 52716
Gerrit-PatchSet: 1
Gerrit-Owner: John Zhao <john.zhao(a)intel.com>
Gerrit-MessageType: newchange
Attention is currently required from: Peter Lemenkov, Alexander Couzens, Patrick Rudolph.
Hello build bot (Jenkins), Alexander Couzens, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/52659
to look at the new patch set (#8).
Change subject: mb/lenovo/w541: Add Lenovo Thinkpad W541
......................................................................
mb/lenovo/w541: Add Lenovo Thinkpad W541
Adds support for the Lenovo Thinkpad W541 based on Peter Lemenkov's initial W541 port.
Compiled and tested with SeaBIOS booting into Arch Linux 5.10.32-lts using a VGA BIOS ROM extracted using VBiosFinder.
Tested working:
1. SATA SSD
2. SATA DVD drive
3. All USB ports
4. Sdcard
5. Speakers/headphone jack
6. Keyboard/touchpad
7. VGA
8. mini DisplayPort (Thunderbolt untested)
9. eDP laptop screen
10. Camera
11. Smartcard reader
Not working:
- libgfxinit
- Keyboard backlight
Signed-off-by: Amersel <amersel(a)runbox.me>
Change-Id: Ia43070f51bba3cf59ba9b7d9e29e4e778efbeb08
---
A src/mainboard/lenovo/w541/Kconfig
A src/mainboard/lenovo/w541/Kconfig.name
A src/mainboard/lenovo/w541/Makefile.inc
A src/mainboard/lenovo/w541/acpi/ec.asl
A src/mainboard/lenovo/w541/acpi/platform.asl
A src/mainboard/lenovo/w541/acpi/superio.asl
A src/mainboard/lenovo/w541/acpi_tables.c
A src/mainboard/lenovo/w541/board_info.txt
A src/mainboard/lenovo/w541/cmos.default
A src/mainboard/lenovo/w541/cmos.layout
A src/mainboard/lenovo/w541/data.vbt
A src/mainboard/lenovo/w541/devicetree.cb
A src/mainboard/lenovo/w541/dsdt.asl
A src/mainboard/lenovo/w541/gma-mainboard.ads
A src/mainboard/lenovo/w541/gpio.c
A src/mainboard/lenovo/w541/hda_verb.c
A src/mainboard/lenovo/w541/mainboard.c
A src/mainboard/lenovo/w541/romstage.c
A src/mainboard/lenovo/w541/smihandler.c
19 files changed, 764 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/52659/8
--
To view, visit https://review.coreboot.org/c/coreboot/+/52659
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia43070f51bba3cf59ba9b7d9e29e4e778efbeb08
Gerrit-Change-Number: 52659
Gerrit-PatchSet: 8
Gerrit-Owner: amersel
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Peter Lemenkov <lemenkov(a)gmail.com>
Gerrit-Attention: Peter Lemenkov <lemenkov(a)gmail.com>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Peter Lemenkov, Alexander Couzens, Patrick Rudolph.
Hello build bot (Jenkins), Alexander Couzens, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/52659
to look at the new patch set (#7).
Change subject: mb/lenovo/w541: Add Thinkpad W541
......................................................................
mb/lenovo/w541: Add Thinkpad W541
Adds support for the Thinkpad W541 based on Peter Lemenkov's initial W541 port.
Compiled and tested with SeaBIOS booting into Arch Linux 5.10.32-lts using a VGA BIOS ROM extracted using VBiosFinder.
Tested working:
1. SATA SSD
2. SATA DVD drive
3. All USB ports
4. Sdcard
5. Speakers/headphone jack
6. Keyboard/touchpad
7. VGA
8. mini DisplayPort (Thunderbolt untested)
9. eDP laptop screen
10. Camera
11. Smartcard reader
Not working:
- libgfxinit
- Keyboard backlight
Signed-off-by: Amersel <amersel(a)runbox.me>
Change-Id: Ia43070f51bba3cf59ba9b7d9e29e4e778efbeb08
---
A src/mainboard/lenovo/w541/Kconfig
A src/mainboard/lenovo/w541/Kconfig.name
A src/mainboard/lenovo/w541/Makefile.inc
A src/mainboard/lenovo/w541/acpi/ec.asl
A src/mainboard/lenovo/w541/acpi/platform.asl
A src/mainboard/lenovo/w541/acpi/superio.asl
A src/mainboard/lenovo/w541/acpi_tables.c
A src/mainboard/lenovo/w541/board_info.txt
A src/mainboard/lenovo/w541/cmos.default
A src/mainboard/lenovo/w541/cmos.layout
A src/mainboard/lenovo/w541/data.vbt
A src/mainboard/lenovo/w541/devicetree.cb
A src/mainboard/lenovo/w541/dsdt.asl
A src/mainboard/lenovo/w541/gma-mainboard.ads
A src/mainboard/lenovo/w541/gpio.c
A src/mainboard/lenovo/w541/hda_verb.c
A src/mainboard/lenovo/w541/mainboard.c
A src/mainboard/lenovo/w541/romstage.c
A src/mainboard/lenovo/w541/smihandler.c
19 files changed, 764 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/52659/7
--
To view, visit https://review.coreboot.org/c/coreboot/+/52659
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia43070f51bba3cf59ba9b7d9e29e4e778efbeb08
Gerrit-Change-Number: 52659
Gerrit-PatchSet: 7
Gerrit-Owner: amersel
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Peter Lemenkov <lemenkov(a)gmail.com>
Gerrit-Attention: Peter Lemenkov <lemenkov(a)gmail.com>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Peter Lemenkov, Alexander Couzens, Patrick Rudolph.
amersel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52659 )
Change subject: mb/lenovo/w541: Add Thinkpad W541
......................................................................
Patch Set 6:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52659/comment/91de2ab2_0a0edae2
PS5, Line 7: mb/lenovo/w541: update thinkpad w541
> Commit message is abit misleading. […]
Done
Patchset:
PS6:
Just need to fix the newlines in cmos.layout now.
File src/mainboard/lenovo/w541/Kconfig:
https://review.coreboot.org/c/coreboot/+/52659/comment/06ecf6f9_d5b09a57
PS5, Line 13: #select HAVE_CMOS_DEFAULT
> Any issues with providing a default values? Copying over ones from t440p could be straightforward.
No, I just never thought to try it. I've tested it now, it boots fine with default values so I've added the default values.
File src/mainboard/lenovo/w541/cmos.layout:
https://review.coreboot.org/c/coreboot/+/52659/comment/b760351a_ec97c440
PS5, Line 108:
> A mostly cosmetic proposal - consider cleaning up this file. […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/52659
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia43070f51bba3cf59ba9b7d9e29e4e778efbeb08
Gerrit-Change-Number: 52659
Gerrit-PatchSet: 6
Gerrit-Owner: amersel
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Peter Lemenkov <lemenkov(a)gmail.com>
Gerrit-Attention: Peter Lemenkov <lemenkov(a)gmail.com>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Tue, 27 Apr 2021 21:26:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Peter Lemenkov <lemenkov(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Alexander Couzens, Patrick Rudolph, amersel.
Hello build bot (Jenkins), Alexander Couzens, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/52659
to look at the new patch set (#6).
Change subject: mb/lenovo/w541: Add Thinkpad W541
......................................................................
mb/lenovo/w541: Add Thinkpad W541
Adds support for the Thinkpad W541 based on Peter Lemenkov's initial W541 port.
Compiled and tested with SeaBIOS booting into Arch Linux 5.10.32-lts using a VGA BIOS ROM extracted using VBiosFinder.
Tested working:
1. SATA SSD
2. SATA DVD drive
3. All USB ports
4. Sdcard
5. Speakers/headphone jack
6. Keyboard/touchpad
7. VGA
8. mini DisplayPort (Thunderbolt untested)
9. eDP laptop screen
10. Camera
11. Smartcard reader
Not working:
- libgfxinit
- Keyboard backlight
Signed-off-by: Amersel <amersel(a)runbox.me>
Change-Id: Ia43070f51bba3cf59ba9b7d9e29e4e778efbeb08
---
A src/mainboard/lenovo/w541/Kconfig
A src/mainboard/lenovo/w541/Kconfig.name
A src/mainboard/lenovo/w541/Makefile.inc
A src/mainboard/lenovo/w541/acpi/ec.asl
A src/mainboard/lenovo/w541/acpi/platform.asl
A src/mainboard/lenovo/w541/acpi/superio.asl
A src/mainboard/lenovo/w541/acpi_tables.c
A src/mainboard/lenovo/w541/board_info.txt
A src/mainboard/lenovo/w541/cmos.default
A src/mainboard/lenovo/w541/cmos.layout
A src/mainboard/lenovo/w541/data.vbt
A src/mainboard/lenovo/w541/devicetree.cb
A src/mainboard/lenovo/w541/dsdt.asl
A src/mainboard/lenovo/w541/gma-mainboard.ads
A src/mainboard/lenovo/w541/gpio.c
A src/mainboard/lenovo/w541/hda_verb.c
A src/mainboard/lenovo/w541/mainboard.c
A src/mainboard/lenovo/w541/romstage.c
A src/mainboard/lenovo/w541/smihandler.c
19 files changed, 765 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/52659/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/52659
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia43070f51bba3cf59ba9b7d9e29e4e778efbeb08
Gerrit-Change-Number: 52659
Gerrit-PatchSet: 6
Gerrit-Owner: amersel
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Peter Lemenkov <lemenkov(a)gmail.com>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: amersel
Gerrit-MessageType: newpatchset
Attention is currently required from: Jakub Czapiga, Jan Dabros.
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52708 )
Change subject: tests/lib/crc_byte-test: Fix incorrect variable types
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/52708
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I61ee029a6950a8dfeb54520b634eaf4ed6bac576
Gerrit-Change-Number: 52708
Gerrit-PatchSet: 1
Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Jan Dabros <jsd(a)semihalf.com>
Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Attention: Jan Dabros <jsd(a)semihalf.com>
Gerrit-Comment-Date: Tue, 27 Apr 2021 20:53:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Timofey Komarov, Felix Singer, Nico Huber, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52692 )
Change subject: soc/intel/skylake: Allow to use Amber Lake FSP
......................................................................
Patch Set 5: Code-Review+1
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52692/comment/46b36800_51eb0157
PS5, Line 15: mainboard
nit: move to previous line
File src/soc/intel/skylake/Kconfig:
https://review.coreboot.org/c/coreboot/+/52692/comment/da1d257e_199425af
PS5, Line 95: default 16 if MAINBOARD_SUPPORTS_COFFEELAKE_CPU
I'd do this in CB:52693
https://review.coreboot.org/c/coreboot/+/52692/comment/e9e29bdf_1786dd22
PS5, Line 256: # SkylakeFsp is FSP 1.1 and therefore incompatible.
Why move the comment?
https://review.coreboot.org/c/coreboot/+/52692/comment/317a0fd1_a9da863c
PS5, Line 259: if SOC_INTEL_SKYLAKE_LGA1151_V2
No need to break the line, this fits in 96 characters
https://review.coreboot.org/c/coreboot/+/52692/comment/125347b7_76fb012b
PS5, Line 264: if SOC_INTEL_SKYLAKE_LGA1151_V2
No need to break the line, this fits in 96 characters
--
To view, visit https://review.coreboot.org/c/coreboot/+/52692
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7b6b9c676da55088cb5a12a218ea58d349ee440c
Gerrit-Change-Number: 52692
Gerrit-PatchSet: 5
Gerrit-Owner: Timofey Komarov <happycorsair(a)yandex.ru>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <felixsinger(a)posteo.net>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Timofey Komarov <happycorsair(a)yandex.ru>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Tue, 27 Apr 2021 20:36:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment