Attention is currently required from: Timofey Komarov, Felix Singer, Patrick Rudolph.
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/52692
to look at the new patch set (#5).
Change subject: soc/intel/skylake: Allow to use Amber Lake FSP
......................................................................
soc/intel/skylake: Allow to use Amber Lake FSP
The Z370, H310C and B365 PCHs use the same silicon as 200-series
PCHs, but are meant to be paired with Coffee Lake CPUs. Intel
provides AmberLakeFspBinPkg to support this combination, which
implements Intel FSP External Architecture Specification v2.1.
To allow using AmberLakeFspBinPkg with coreboot, introduce a new
SOC_INTEL_SKYLAKE_LGA1151_V2 Kconfig option to be selected by mainboards,
and use it to adjust other Kconfig options accordingly.
Signed-off-by: Timofey Komarov <happycorsair(a)yandex.ru>
Change-Id: I7b6b9c676da55088cb5a12a218ea58d349ee440c
---
M src/soc/intel/skylake/Kconfig
1 file changed, 25 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/52692/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/52692
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7b6b9c676da55088cb5a12a218ea58d349ee440c
Gerrit-Change-Number: 52692
Gerrit-PatchSet: 5
Gerrit-Owner: Timofey Komarov <happycorsair(a)yandex.ru>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <felixsinger(a)posteo.net>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Timofey Komarov <happycorsair(a)yandex.ru>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Felix Singer, Patrick Rudolph.
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/52692
to look at the new patch set (#3).
Change subject: Add Amberlake Kconfig option and some FSP config changes
......................................................................
Add Amberlake Kconfig option and some FSP config changes
Signed-off-by: Timofey Komarov <happycorsair(a)yandex.ru>
Change-Id: I7b6b9c676da55088cb5a12a218ea58d349ee440c
---
M src/soc/intel/skylake/Kconfig
1 file changed, 23 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/52692/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/52692
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7b6b9c676da55088cb5a12a218ea58d349ee440c
Gerrit-Change-Number: 52692
Gerrit-PatchSet: 3
Gerrit-Owner: Timofey Komarov <happycorsair(a)yandex.ru>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <felixsinger(a)posteo.net>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Nico Huber, Tim Wawrzynczak, Patrick Rudolph.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52679 )
Change subject: docs/mb/supermicro/x11ssm-f: rework flashing section
......................................................................
Patch Set 2:
(1 comment)
File Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/x11ssm-f.md:
https://review.coreboot.org/c/coreboot/+/52679/comment/1b149b3c_6ba0a300
PS1, Line 12: G2
> S5 is probably more common.
I should have checked the ACPI spec \o/ I wasn't aware that S5 is a G2 state... thanks!
--
To view, visit https://review.coreboot.org/c/coreboot/+/52679
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I37d55ffdbcfba4f3a1113a82f16ec8766bbb6e6c
Gerrit-Change-Number: 52679
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Tue, 27 Apr 2021 19:19:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Gerrit-MessageType: comment
Attention is currently required from: Alexander Couzens, Patrick Rudolph, amersel.
Peter Lemenkov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52659 )
Change subject: mb/lenovo/w541: update thinkpad w541
......................................................................
Patch Set 5:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52659/comment/148513f9_9c8258d1
PS5, Line 7: mb/lenovo/w541: update thinkpad w541
Commit message is abit misleading. There was no Lenovo w541 support before so it shouldn't use "update" word. Could you please rephrase is? Something like "Add Lenovo w541".
--
To view, visit https://review.coreboot.org/c/coreboot/+/52659
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia43070f51bba3cf59ba9b7d9e29e4e778efbeb08
Gerrit-Change-Number: 52659
Gerrit-PatchSet: 5
Gerrit-Owner: amersel
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Peter Lemenkov <lemenkov(a)gmail.com>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: amersel
Gerrit-Comment-Date: Tue, 27 Apr 2021 19:18:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth, Rob Barnes.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51775 )
Change subject: chromeec: Fix google_chromeec_status_check timeout
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/51775
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I363ff7453bcf81581884f92797629a6f96d42580
Gerrit-Change-Number: 51775
Gerrit-PatchSet: 6
Gerrit-Owner: Rob Barnes <robbarnes(a)google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Rob Barnes <robbarnes(a)google.com>
Gerrit-Comment-Date: Tue, 27 Apr 2021 19:02:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Bao Zheng, Zheng Bao.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52657 )
Change subject: amdfwtool: Remove the misleading option characters
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
Why? How are these misleading? It's very common for programs to have both short and long options.
I'm not completely opposed, but I'd like to understand the reason.
--
To view, visit https://review.coreboot.org/c/coreboot/+/52657
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8b0d53d5e5eb494741b7fac32029cf16cabe66d8
Gerrit-Change-Number: 52657
Gerrit-PatchSet: 4
Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Eric Peers <epeers(a)google.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Attention: Zheng Bao
Gerrit-Comment-Date: Tue, 27 Apr 2021 19:01:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Furquan Shaikh, EricR Lai.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52694 )
Change subject: mb/google/brya: Adjust WWAN power sequence
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> I trust the FSP-M to help provide longer boot time. […]
😄
--
To view, visit https://review.coreboot.org/c/coreboot/+/52694
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I13357677bb1ab185abf1d4c915a762a9d6894312
Gerrit-Change-Number: 52694
Gerrit-PatchSet: 1
Gerrit-Owner: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 27 Apr 2021 18:49:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com>
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: EricR Lai.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52694 )
Change subject: mb/google/brya: Adjust WWAN power sequence
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> Sure, but we're also looking at reducing the time spent in verstage too, so the time between bootblo […]
I trust the FSP-M to help provide longer boot time. :P
--
To view, visit https://review.coreboot.org/c/coreboot/+/52694
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I13357677bb1ab185abf1d4c915a762a9d6894312
Gerrit-Change-Number: 52694
Gerrit-PatchSet: 1
Gerrit-Owner: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 27 Apr 2021 18:47:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com>
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Furquan Shaikh, EricR Lai.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52694 )
Change subject: mb/google/brya: Adjust WWAN power sequence
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patchset:
PS1:
> Traditionally, we have just relied on the time taken between stages to toggle pads in early stage an […]
Sure, but we're also looking at reducing the time spent in verstage too, so the time between bootblock->ramstage might get shorter soon ;)
--
To view, visit https://review.coreboot.org/c/coreboot/+/52694
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I13357677bb1ab185abf1d4c915a762a9d6894312
Gerrit-Change-Number: 52694
Gerrit-PatchSet: 1
Gerrit-Owner: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 27 Apr 2021 18:42:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com>
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: comment