Attention is currently required from: Furquan Shaikh, Mario Scheithauer, Werner Zeh.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52721 )
Change subject: mb/siemens/mc_apl{1,2,3,5,6}: Tune I2C frequency
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> I think it's a little strange to set i2c speed twice, but the designware driver is built that way.
It's not really setting the i2c speed twice, the second one is telling the provided SCL hcnt/lcnt are ones to be used with the specified speed. If one should need to change the bus frequency during development, a different set of hcnt/lcnt need to be provided too.
AFAICS the .rise_time_ns approach is less hassle.
--
To view, visit https://review.coreboot.org/c/coreboot/+/52721
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iab634190bda5fa2a4fdf2ebaa1e45ac897d84deb
Gerrit-Change-Number: 52721
Gerrit-PatchSet: 1
Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Comment-Date: Thu, 29 Apr 2021 08:52:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-MessageType: comment
Zhuohao Lee has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/52754 )
Change subject: mb/google/brya: select GOOGLE_SMBIOS_MAINBOARD_VERSION
......................................................................
mb/google/brya: select GOOGLE_SMBIOS_MAINBOARD_VERSION
In order to use the function smbios_mainboard_version()
to query the board revision from the EC.
we need to select GOOGLE_SMBIOS_MAINBOARD_VERSION.
BUG=b:186721096
TEST=1. emerge-brya coreboot chromeos-bootimage
2. flash the image to the device and check board rev
by using command `dmidecode -t 1 | grep Version`
Change-Id: I8eeb958f73607afb801794f91fbf91ec7bd5cd8b
Signed-off-by: Zhuohao Lee <zhuohao(a)chromium.org>
---
M src/mainboard/google/brya/Kconfig
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/52754/1
diff --git a/src/mainboard/google/brya/Kconfig b/src/mainboard/google/brya/Kconfig
index d53065f..1489fbc 100644
--- a/src/mainboard/google/brya/Kconfig
+++ b/src/mainboard/google/brya/Kconfig
@@ -13,6 +13,7 @@
select EC_GOOGLE_CHROMEEC_BOARDID
select EC_GOOGLE_CHROMEEC_ESPI
select EC_GOOGLE_CHROMEEC_SKUID
+ select GOOGLE_SMBIOS_MAINBOARD_VERSION
select HAVE_ACPI_RESUME
select HAVE_ACPI_TABLES
select HAVE_SPD_IN_CBFS
--
To view, visit https://review.coreboot.org/c/coreboot/+/52754
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8eeb958f73607afb801794f91fbf91ec7bd5cd8b
Gerrit-Change-Number: 52754
Gerrit-PatchSet: 1
Gerrit-Owner: Zhuohao Lee <zhuohao(a)chromium.org>
Gerrit-MessageType: newchange
Attention is currently required from: Tim Wawrzynczak, Duncan Laurie.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52723 )
Change subject: drivers/i2c/designware: Use safe defaults for SCL parameters
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52723/comment/38853b1a_6fa08806
PS1, Line 11: If I2C bus step response has not been measured, assume
: the layout to be designed with a minimal capacitance and
: SCL rise and fall times of 0 ns. The calculations will
: add the required amount of reference clocks for the host
: to drive SCL high or low, such that the maximum bus
: frequency specification is met.
> nit: fill this out to 72 chars wide
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/52723
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icbafae22c83ffbc16c179fb5412fb4fd6b70813a
Gerrit-Change-Number: 52723
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Duncan Laurie <duncan(a)iceblink.org>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Duncan Laurie <duncan(a)iceblink.org>
Gerrit-Comment-Date: Thu, 29 Apr 2021 08:37:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Duncan Laurie, Kyösti Mälkki.
Hello build bot (Jenkins), Furquan Shaikh, Duncan Laurie, Tim Wawrzynczak, Werner Zeh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/52723
to look at the new patch set (#2).
Change subject: drivers/i2c/designware: Use safe defaults for SCL parameters
......................................................................
drivers/i2c/designware: Use safe defaults for SCL parameters
Inspired by discussion in CB:22822.
If I2C bus step response has not been measured, assume the layout to
have been designed with a minimal capacitance and SCL rise and fall
times of 0 ns. The calculations will add the required amount of
reference clocks for the host to drive SCL high or low, such that the
maximum bus frequency specification is met.
Change-Id: Icbafae22c83ffbc16c179fb5412fb4fd6b70813a
Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
---
M src/drivers/i2c/designware/dw_i2c.c
1 file changed, 2 insertions(+), 30 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/52723/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/52723
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icbafae22c83ffbc16c179fb5412fb4fd6b70813a
Gerrit-Change-Number: 52723
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Duncan Laurie <duncan(a)iceblink.org>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Duncan Laurie <duncan(a)iceblink.org>
Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Philipp Deppenwiese, Christian Walter.
Hello Philipp Deppenwiese, Christian Walter,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/52753
to look at the new patch set (#2).
Change subject: security/tpm/crtm: Measure FMAP into TPM
......................................................................
security/tpm/crtm: Measure FMAP into TPM
FMAP is used to look up cbfs files or other FMAP regions so it should
be measured too.
TESTED: on qemu q35 with swtpm
Change-Id: Ic424a094e7f790cce45c5a98b8bc6d46a8dcca1b
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M src/security/tpm/tspi/crtm.c
1 file changed, 11 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/52753/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/52753
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic424a094e7f790cce45c5a98b8bc6d46a8dcca1b
Gerrit-Change-Number: 52753
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Attention: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-MessageType: newpatchset
Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/52753 )
Change subject: security/tpm/crtm: Measure FMAP into TPM
......................................................................
security/tpm/crtm: Measure FMAP into TPM
FMAP is used to look up cbfs files or other FMAP region so it should
be measured too.
TESTED: on qemu q35 with swtpm
Change-Id: Ic424a094e7f790cce45c5a98b8bc6d46a8dcca1b
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M src/security/tpm/tspi/crtm.c
1 file changed, 11 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/52753/1
diff --git a/src/security/tpm/tspi/crtm.c b/src/security/tpm/tspi/crtm.c
index 80483d5..147fc76 100644
--- a/src/security/tpm/tspi/crtm.c
+++ b/src/security/tpm/tspi/crtm.c
@@ -59,6 +59,17 @@
return VB2_SUCCESS;
}
+ struct region_device fmap;
+ if (fmap_locate_area_as_rdev("FMAP", &fmap) == 0) {
+ if (tpm_measure_region(&fmap, TPM_CRTM_PCR, "FMAP: FMAP")) {
+ printk(BIOS_ERR,
+ "TSPI: Couldn't measure FMAP into CRTM!\n");
+ return VB2_ERROR_UNKNOWN;
+ }
+ } else {
+ printk(BIOS_ERR, "TSPI: Could not find FMAP!\n");
+ }
+
/* measure bootblock from RO */
struct cbfsf bootblock_data;
struct region_device bootblock_fmap;
--
To view, visit https://review.coreboot.org/c/coreboot/+/52753
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic424a094e7f790cce45c5a98b8bc6d46a8dcca1b
Gerrit-Change-Number: 52753
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: newchange
Attention is currently required from: Furquan Shaikh, Henry Sun, Tim Wawrzynczak, Karthik Ramasubramanian.
David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51279 )
Change subject: mb/google/dedede/var/magolor: Support VBT for Magister
......................................................................
Patch Set 7:
(1 comment)
File src/mainboard/google/dedede/variants/magolor/variant.c:
https://review.coreboot.org/c/coreboot/+/51279/comment/a6eb8743_ba897b27
PS7, Line 18: return "vbt_magister.bin";
> Just one example, it can depend on which DDI port to use for display, the resolution of the display, […]
Thank you for the suggestion. we will study it.
--
To view, visit https://review.coreboot.org/c/coreboot/+/51279
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I52c10452887312959f68cfc4e25d5897dae388f8
Gerrit-Change-Number: 51279
Gerrit-PatchSet: 7
Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Thu, 29 Apr 2021 06:54:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-MessageType: comment