coreboot-gerrit March 2021

coreboot-gerrit@coreboot.org

1 participants
7266 discussions

Change in coreboot[master]: soc/intel: Retype `CnviBtAudioOffload` devicetree option
by Tim Wawrzynczak (Code Review) 01 Mar '21

01 Mar '21

Attention is currently required from: Angel Pons, Subrata Banik, Patrick Rudolph. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51154 ) Change subject: soc/intel: Retype `CnviBtAudioOffload` devicetree option ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/51154 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2c9b4c6a2f210ffca946ca196299fa672a06ccc7 Gerrit-Change-Number: 51154 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Mon, 01 Mar 2021 21:11:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/purism/librem_mini: Implement `die_notify`
by Matt DeVillier (Code Review) 01 Mar '21

01 Mar '21

Attention is currently required from: Martin Roth, Angel Pons. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50013 ) Change subject: mb/purism/librem_mini: Implement `die_notify` ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/50013 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0ffac0ab02e52e9fbba7990f401d87e50a1b5154 Gerrit-Change-Number: 50013 Gerrit-PatchSet: 4 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 01 Mar 2021 21:07:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/tigerlake: Re-use existing define in CrashLog implementation
by Francois Toguo Fotso (Code Review) 01 Mar '21

01 Mar '21

Attention is currently required from: Angel Pons, Patrick Rudolph. Francois Toguo Fotso has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51096 ) Change subject: soc/intel/tigerlake: Re-use existing define in CrashLog implementation ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: > Please add some config to build-test the crashlog code. There is already one named SOC_INTEL_COMMON_BLOCK_CRASHLOG inside src/soc/intel/tigerlake/Kconfig. For now it is set to no. After this CL merges, you can set it to yes and build it locally. The feature is to be turned off by default on TGL. It will be turn on by default on ADL -- To view, visit https://review.coreboot.org/c/coreboot/+/51096 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If063d1ea4189dbc5a75f37d86ce158e8f1bd808d Gerrit-Change-Number: 51096 Gerrit-PatchSet: 4 Gerrit-Owner: Francois Toguo Fotso <francois.toguo.fotso(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Francois Toguo Fotso <francois.toguo.fotso(a)intel.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Mon, 01 Mar 2021 21:00:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/cezanne: Disable legacy DMA IO ports
by Raul Rangel (Code Review) 01 Mar '21

01 Mar '21

Attention is currently required from: Jason Glenesk, Marshall Dawson, Paul Menzel, Angel Pons, Felix Held. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51076 ) Change subject: soc/amd/cezanne: Disable legacy DMA IO ports ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/51076/comment/26d302c3_a7b8f795 PS2, Line 10: ports. > the only two things that still used legacy ISA DMA were the floppy drive controller and the parallel […] Ports 0x80-0x83 were not being router to the DMA controller either. So I'm not sure how functional it would even be. I think we should keep it disabled unless someone finds a specific reason to keep it enabled. -- To view, visit https://review.coreboot.org/c/coreboot/+/51076 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7792d1f8ea40eb1c7f6cca67e9907208884ac694 Gerrit-Change-Number: 51076 Gerrit-PatchSet: 2 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 01 Mar 2021 20:45:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)users.sourceforge.net> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/tigerlake: Re-use existing define in CrashLog implementation
by Angel Pons (Code Review) 01 Mar '21

01 Mar '21

Attention is currently required from: Francois Toguo Fotso, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51096 ) Change subject: soc/intel/tigerlake: Re-use existing define in CrashLog implementation ...................................................................... Patch Set 4: Code-Review+1 (1 comment) Patchset: PS4: Please add some config to build-test the crashlog code. -- To view, visit https://review.coreboot.org/c/coreboot/+/51096 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If063d1ea4189dbc5a75f37d86ce158e8f1bd808d Gerrit-Change-Number: 51096 Gerrit-PatchSet: 4 Gerrit-Owner: Francois Toguo Fotso <francois.toguo.fotso(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Francois Toguo Fotso <francois.toguo.fotso(a)intel.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Francois Toguo Fotso <francois.toguo.fotso(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Mon, 01 Mar 2021 20:42:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: sb/intel/common/pciehp: Replace HP dummy device with common code
by Angel Pons (Code Review) 01 Mar '21

01 Mar '21

Attention is currently required from: Nico Huber, Arthur Heymans, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51068 ) Change subject: sb/intel/common/pciehp: Replace HP dummy device with common code ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File src/southbridge/intel/i82801jx/Kconfig: https://review.coreboot.org/c/coreboot/+/51068/comment/b66d6fc7_29666337 PS2, Line 42: config PCIEXP_HOTPLUG Does any i82801jx board support hotplug? -- To view, visit https://review.coreboot.org/c/coreboot/+/51068 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3eec5214c9d200ef97d1ccfdc00e8ea0ee7cfbc6 Gerrit-Change-Number: 51068 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Mon, 01 Mar 2021 20:41:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/*/*: Don't select PCIEXP_HOTPLUG
by Angel Pons (Code Review) 01 Mar '21

01 Mar '21

Attention is currently required from: Nico Huber, Arthur Heymans. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51151 ) Change subject: mb/*/*: Don't select PCIEXP_HOTPLUG ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/51151 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie4248700f5ab5168bff551b740d347713273763c Gerrit-Change-Number: 51151 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Mon, 01 Mar 2021 20:38:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/chromeos: Use the same inventory each time and verify checksums
by Matt DeVillier (Code Review) 01 Mar '21

01 Mar '21

Attention is currently required from: Paul Menzel, Leah Rowe. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51144 ) Change subject: util/chromeos: Use the same inventory each time and verify checksums ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: who is going to continually update the config file URL so that new boards are supported? the last thing I want to do when I need to pull down a recovery image quickly for a new board is to have to check archive.org to try and figure out when support was added / update the URL/checksum. effort would be better spent fixing the shellball extraction for newer boards which contain multiple firmware images IMO -- To view, visit https://review.coreboot.org/c/coreboot/+/51144 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If0166518d252a36d8f9a9c17d375fbdd9e3116f6 Gerrit-Change-Number: 51144 Gerrit-PatchSet: 5 Gerrit-Owner: Leah Rowe <leahleahrowerowe(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Leah Rowe <leahleahrowerowe(a)gmail.com> Gerrit-Comment-Date: Mon, 01 Mar 2021 20:37:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/drawcia: Re-tune override GPIO table
by Karthik Ramasubramanian (Code Review) 01 Mar '21

01 Mar '21

Attention is currently required from: Furquan Shaikh, Henry Sun, Evan Green. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51153 ) Change subject: mb/google/dedede/var/drawcia: Re-tune override GPIO table ...................................................................... Patch Set 3: (1 comment) File src/mainboard/google/dedede/variants/drawcia/gpio.c: https://review.coreboot.org/c/coreboot/+/51153/comment/5a5ee586_da0474e4 PS3, Line 28: board_version == 6 || board_version == 8 > :(. […] Yes, HW engineer mentioned that the external pull-up is not going to be stuffed in the upcoming Drawlat/man build phases. Hence this arrangement. -- To view, visit https://review.coreboot.org/c/coreboot/+/51153 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I320de9a0c37ac033f3efda74eeb8f36e34667fd4 Gerrit-Change-Number: 51153 Gerrit-PatchSet: 3 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Evan Green <evgreen(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Evan Green <evgreen(a)chromium.org> Gerrit-Comment-Date: Mon, 01 Mar 2021 20:35:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/drawcia: Re-tune override GPIO table
by Furquan Shaikh (Code Review) 01 Mar '21

01 Mar '21

Attention is currently required from: Henry Sun, Evan Green, Karthik Ramasubramanian. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51153 ) Change subject: mb/google/dedede/var/drawcia: Re-tune override GPIO table ...................................................................... Patch Set 3: Code-Review+2 (1 comment) File src/mainboard/google/dedede/variants/drawcia/gpio.c: https://review.coreboot.org/c/coreboot/+/51153/comment/87330732_e09a7208 PS3, Line 28: board_version == 6 || board_version == 8 :(. I am guessing this is because of the no FW_CONFIG bit for pen support and inability to use external pull on the pen detect line? -- To view, visit https://review.coreboot.org/c/coreboot/+/51153 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I320de9a0c37ac033f3efda74eeb8f36e34667fd4 Gerrit-Change-Number: 51153 Gerrit-PatchSet: 3 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Evan Green <evgreen(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Evan Green <evgreen(a)chromium.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Mon, 01 Mar 2021 20:29:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2021