coreboot-gerrit March 2021

coreboot-gerrit@coreboot.org

1 participants
7266 discussions

Change in coreboot[master]: mb/google/dedede/var/drawcia: Re-tune override GPIO table
by Evan Green (Code Review) 02 Mar '21

02 Mar '21

Attention is currently required from: Furquan Shaikh, Henry Sun, Karthik Ramasubramanian. Evan Green has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51153 ) Change subject: mb/google/dedede/var/drawcia: Re-tune override GPIO table ...................................................................... Patch Set 3: -Code-Review (1 comment) File src/mainboard/google/dedede/variants/drawcia/gpio.c: https://review.coreboot.org/c/coreboot/+/51153/comment/3688c25b_61b3c632 PS3, Line 28: board_version == 6 || board_version == 8 > I was expecting version 7 to support the external pull-up. […] That makes sense. So my suggestion is still to change "== 8" to ">= 8". -- To view, visit https://review.coreboot.org/c/coreboot/+/51153 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I320de9a0c37ac033f3efda74eeb8f36e34667fd4 Gerrit-Change-Number: 51153 Gerrit-PatchSet: 3 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Evan Green <evgreen(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Mon, 01 Mar 2021 23:37:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com> Comment-In-Reply-To: Evan Green <evgreen(a)chromium.org> Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: elog: Support logging CSE Lite info in elog
by Tim Wawrzynczak (Code Review) 02 Mar '21

02 Mar '21

Attention is currently required from: Martin Roth, Furquan Shaikh, Jamie Ryu, Rizwan Qureshi, Sridhar Siricilla, Krishna P Bhat D, Patrick Rudolph, Karthik Ramasubramanian. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50472 ) Change subject: elog: Support logging CSE Lite info in elog ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/50472 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib183941d1fa0a9971e30b4092ea3d23daaa29334 Gerrit-Change-Number: 50472 Gerrit-PatchSet: 5 Gerrit-Owner: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Mon, 01 Mar 2021 23:01:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/drawcia: Re-tune override GPIO table
by Karthik Ramasubramanian (Code Review) 01 Mar '21

01 Mar '21

Attention is currently required from: Furquan Shaikh, Henry Sun, Evan Green. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51153 ) Change subject: mb/google/dedede/var/drawcia: Re-tune override GPIO table ...................................................................... Patch Set 3: (1 comment) File src/mainboard/google/dedede/variants/drawcia/gpio.c: https://review.coreboot.org/c/coreboot/+/51153/comment/2f38a4bf_bedcb60e PS3, Line 28: board_version == 6 || board_version == 8 > So the external pull is the desired future direction, right? And from reading this it seems like 6 a […] I was expecting version 7 to support the external pull-up. Unfortunately it did not happen because of other urgent needs taking precedence. -- To view, visit https://review.coreboot.org/c/coreboot/+/51153 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I320de9a0c37ac033f3efda74eeb8f36e34667fd4 Gerrit-Change-Number: 51153 Gerrit-PatchSet: 3 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Evan Green <evgreen(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Evan Green <evgreen(a)chromium.org> Gerrit-Comment-Date: Mon, 01 Mar 2021 22:12:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com> Comment-In-Reply-To: Evan Green <evgreen(a)chromium.org> Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: nb/intel/haswell: Finalize northbridge in ramstage
by Angel Pons (Code Review) 01 Mar '21

01 Mar '21

Attention is currently required from: Nico Huber, Martin Roth, Arthur Heymans, Patrick Rudolph. Hello Nico Huber, Patrick Georgi, Martin Roth, Arthur Heymans, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/51157 to look at the new patch set (#2). Change subject: nb/intel/haswell: Finalize northbridge in ramstage ...................................................................... nb/intel/haswell: Finalize northbridge in ramstage There's no need to finalize the northbridge in SMM. This also makes unification with Broadwell easier. Change-Id: I8b2c0d14a79e4fcd2e8985ce58542791cef9b1fe Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/northbridge/intel/haswell/Makefile.inc D src/northbridge/intel/haswell/finalize.c M src/northbridge/intel/haswell/haswell.h M src/northbridge/intel/haswell/northbridge.c M src/southbridge/intel/lynxpoint/smihandler.c 5 files changed, 33 insertions(+), 41 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/51157/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/51157 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8b2c0d14a79e4fcd2e8985ce58542791cef9b1fe Gerrit-Change-Number: 51157 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: nb/intel/haswell: Finalize northbridge in ramstage
by Angel Pons (Code Review) 01 Mar '21

01 Mar '21

Attention is currently required from: Martin Roth, Patrick Rudolph. Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/51157 ) Change subject: nb/intel/haswell: Finalize northbridge in ramstage ...................................................................... nb/intel/haswell: Finalize northbridge in ramstage There's no need to finalize the northbridge in SMM. Change-Id: I8b2c0d14a79e4fcd2e8985ce58542791cef9b1fe Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/northbridge/intel/haswell/Makefile.inc D src/northbridge/intel/haswell/finalize.c M src/northbridge/intel/haswell/haswell.h M src/northbridge/intel/haswell/northbridge.c M src/southbridge/intel/lynxpoint/smihandler.c 5 files changed, 33 insertions(+), 41 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/51157/1 diff --git a/src/northbridge/intel/haswell/Makefile.inc b/src/northbridge/intel/haswell/Makefile.inc index b2fd530..f718f9a 100644 --- a/src/northbridge/intel/haswell/Makefile.inc +++ b/src/northbridge/intel/haswell/Makefile.inc @@ -18,8 +18,6 @@ romstage-y += early_init.c romstage-y += report_platform.c -smm-y += finalize.c - # We don't ship that, but booting without it is bound to fail cbfs-files-$(CONFIG_HAVE_MRC) += mrc.bin mrc.bin-file := $(call strip_quotes,$(CONFIG_MRC_FILE)) diff --git a/src/northbridge/intel/haswell/finalize.c b/src/northbridge/intel/haswell/finalize.c deleted file mode 100644 index b95b3fe..0000000 --- a/src/northbridge/intel/haswell/finalize.c +++ /dev/null @@ -1,36 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#include <device/pci_ops.h> -#include "haswell.h" - -void intel_northbridge_haswell_finalize_smm(void) -{ - pci_or_config16(HOST_BRIDGE, GGC, 1 << 0); - pci_or_config32(HOST_BRIDGE, DPR, 1 << 0); - pci_or_config32(HOST_BRIDGE, MESEG_LIMIT, 1 << 10); - pci_or_config32(HOST_BRIDGE, REMAPBASE, 1 << 0); - pci_or_config32(HOST_BRIDGE, REMAPLIMIT, 1 << 0); - pci_or_config32(HOST_BRIDGE, TOM, 1 << 0); - pci_or_config32(HOST_BRIDGE, TOUUD, 1 << 0); - pci_or_config32(HOST_BRIDGE, BDSM, 1 << 0); - pci_or_config32(HOST_BRIDGE, BGSM, 1 << 0); - pci_or_config32(HOST_BRIDGE, TSEG, 1 << 0); - pci_or_config32(HOST_BRIDGE, TOLUD, 1 << 0); - - /* Memory Controller Lockdown */ - MCHBAR32(MC_LOCK) |= 0x8f; - - MCHBAR32_OR(MMIO_PAVP_MSG, 1 << 0); /* PAVP */ - MCHBAR32_OR(PCU_DDR_PTM_CTL, 1 << 5); /* DDR PTM */ - MCHBAR32_OR(DMIVCLIM, 1 << 31); - MCHBAR32_OR(CRDTLCK, 1 << 0); - MCHBAR32_OR(MCARBLCK, 1 << 0); - MCHBAR32_OR(REQLIM, 1 << 31); - MCHBAR32_OR(UMAGFXCTL, 1 << 0); /* UMA GFX */ - MCHBAR32_OR(VTDTRKLCK, 1 << 0); /* VTDTRK */ - - /* Read+write the following */ - MCHBAR32(VDMBDFBARKVM) = MCHBAR32(VDMBDFBARKVM); - MCHBAR32(VDMBDFBARPAVP) = MCHBAR32(VDMBDFBARPAVP); - MCHBAR32(HDAUDRID) = MCHBAR32(HDAUDRID); -} diff --git a/src/northbridge/intel/haswell/haswell.h b/src/northbridge/intel/haswell/haswell.h index f158c21..6a99074 100644 --- a/src/northbridge/intel/haswell/haswell.h +++ b/src/northbridge/intel/haswell/haswell.h @@ -75,8 +75,6 @@ #ifndef __ASSEMBLER__ -void intel_northbridge_haswell_finalize_smm(void); - void mb_late_romstage_setup(void); /* optional */ void haswell_early_initialization(void); diff --git a/src/northbridge/intel/haswell/northbridge.c b/src/northbridge/intel/haswell/northbridge.c index 7ccfdb1..ab42e72 100644 --- a/src/northbridge/intel/haswell/northbridge.c +++ b/src/northbridge/intel/haswell/northbridge.c @@ -546,11 +546,44 @@ set_power_limits(28); } +static void northbridge_final(struct device *dev) +{ + pci_or_config16(dev, GGC, 1 << 0); + pci_or_config32(dev, DPR, 1 << 0); + pci_or_config32(dev, MESEG_LIMIT, 1 << 10); + pci_or_config32(dev, REMAPBASE, 1 << 0); + pci_or_config32(dev, REMAPLIMIT, 1 << 0); + pci_or_config32(dev, TOM, 1 << 0); + pci_or_config32(dev, TOUUD, 1 << 0); + pci_or_config32(dev, BDSM, 1 << 0); + pci_or_config32(dev, BGSM, 1 << 0); + pci_or_config32(dev, TSEG, 1 << 0); + pci_or_config32(dev, TOLUD, 1 << 0); + + /* Memory Controller Lockdown */ + MCHBAR32(MC_LOCK) |= 0x8f; + + MCHBAR32_OR(MMIO_PAVP_MSG, 1 << 0); /* PAVP */ + MCHBAR32_OR(PCU_DDR_PTM_CTL, 1 << 5); /* DDR PTM */ + MCHBAR32_OR(DMIVCLIM, 1 << 31); + MCHBAR32_OR(CRDTLCK, 1 << 0); + MCHBAR32_OR(MCARBLCK, 1 << 0); + MCHBAR32_OR(REQLIM, 1 << 31); + MCHBAR32_OR(UMAGFXCTL, 1 << 0); /* UMA GFX */ + MCHBAR32_OR(VTDTRKLCK, 1 << 0); /* VTDTRK */ + + /* Read+write the following */ + MCHBAR32(VDMBDFBARKVM) = MCHBAR32(VDMBDFBARKVM); + MCHBAR32(VDMBDFBARPAVP) = MCHBAR32(VDMBDFBARPAVP); + MCHBAR32(HDAUDRID) = MCHBAR32(HDAUDRID); +} + static struct device_operations mc_ops = { .read_resources = mc_read_resources, .set_resources = pci_dev_set_resources, .enable_resources = pci_dev_enable_resources, .init = northbridge_init, + .final = northbridge_final, .acpi_fill_ssdt = generate_cpu_entries, .ops_pci = &pci_dev_ops_pci, }; diff --git a/src/southbridge/intel/lynxpoint/smihandler.c b/src/southbridge/intel/lynxpoint/smihandler.c index aebc038..8b13f16 100644 --- a/src/southbridge/intel/lynxpoint/smihandler.c +++ b/src/southbridge/intel/lynxpoint/smihandler.c @@ -274,7 +274,6 @@ intel_me_finalize_smm(); intel_pch_finalize_smm(); - intel_northbridge_haswell_finalize_smm(); intel_cpu_haswell_finalize_smm(); chipset_finalized = 1; -- To view, visit https://review.coreboot.org/c/coreboot/+/51157 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8b2c0d14a79e4fcd2e8985ce58542791cef9b1fe Gerrit-Change-Number: 51157 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: nb/intel/haswell: Indent PCI ops with tabs
by Angel Pons (Code Review) 01 Mar '21

01 Mar '21

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/51156 ) Change subject: nb/intel/haswell: Indent PCI ops with tabs ...................................................................... nb/intel/haswell: Indent PCI ops with tabs Change-Id: Ia338ce1a36aa0a14017201c1fc16f84915f55c07 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/northbridge/intel/haswell/northbridge.c 1 file changed, 5 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/51156/1 diff --git a/src/northbridge/intel/haswell/northbridge.c b/src/northbridge/intel/haswell/northbridge.c index b19e7bd..7ccfdb1 100644 --- a/src/northbridge/intel/haswell/northbridge.c +++ b/src/northbridge/intel/haswell/northbridge.c @@ -547,12 +547,12 @@ } static struct device_operations mc_ops = { - .read_resources = mc_read_resources, - .set_resources = pci_dev_set_resources, - .enable_resources = pci_dev_enable_resources, - .init = northbridge_init, + .read_resources = mc_read_resources, + .set_resources = pci_dev_set_resources, + .enable_resources = pci_dev_enable_resources, + .init = northbridge_init, .acpi_fill_ssdt = generate_cpu_entries, - .ops_pci = &pci_dev_ops_pci, + .ops_pci = &pci_dev_ops_pci, }; static const unsigned short mc_pci_device_ids[] = { -- To view, visit https://review.coreboot.org/c/coreboot/+/51156 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia338ce1a36aa0a14017201c1fc16f84915f55c07 Gerrit-Change-Number: 51156 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/dedede/var/drawcia: Re-tune override GPIO table
by Evan Green (Code Review) 01 Mar '21

01 Mar '21

Attention is currently required from: Furquan Shaikh, Henry Sun, Karthik Ramasubramanian. Evan Green has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51153 ) Change subject: mb/google/dedede/var/drawcia: Re-tune override GPIO table ...................................................................... Patch Set 3: Code-Review+2 (1 comment) File src/mainboard/google/dedede/variants/drawcia/gpio.c: https://review.coreboot.org/c/coreboot/+/51153/comment/26fb4027_e168964e PS3, Line 28: board_version == 6 || board_version == 8 > Yes, HW engineer mentioned that the external pull-up is not going to be stuffed in the upcoming Draw […] So the external pull is the desired future direction, right? And from reading this it seems like 6 and 8 have the external pull, but 7 doesn't. Wouldn't you expect versions 9+ to also have the external pull? So would (board_version == 6 || board_version >= 8) be better then? -- To view, visit https://review.coreboot.org/c/coreboot/+/51153 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I320de9a0c37ac033f3efda74eeb8f36e34667fd4 Gerrit-Change-Number: 51153 Gerrit-PatchSet: 3 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Evan Green <evgreen(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Mon, 01 Mar 2021 21:50:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com> Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: AGESA boards: Captilize ASL names
by Angel Pons (Code Review) 01 Mar '21

01 Mar '21

Attention is currently required from: Paul Menzel. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51152 ) Change subject: AGESA boards: Captilize ASL names ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/51152 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia458c98a4774fb5745825aecf996a476e66eaa3f Gerrit-Change-Number: 51152 Gerrit-PatchSet: 1 Gerrit-Owner: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Mon, 01 Mar 2021 21:35:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/lippert/frontrunner-af: Rename to `f14-halfboards`
by Angel Pons (Code Review) 01 Mar '21

01 Mar '21

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43289 ) Change subject: mb/lippert/frontrunner-af: Rename to `f14-halfboards` ...................................................................... mb/lippert/frontrunner-af: Rename to `f14-halfboards` There are two different boards inside this folder. Change-Id: I2a44af225f5e22dcee83009f0fdcb00d8a2bd1a0 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- R src/mainboard/lippert/f14-halfboards/Kconfig R src/mainboard/lippert/f14-halfboards/Kconfig.name R src/mainboard/lippert/f14-halfboards/Makefile.inc R src/mainboard/lippert/f14-halfboards/OptionsIds.h R src/mainboard/lippert/f14-halfboards/acpi/routing.asl R src/mainboard/lippert/f14-halfboards/acpi/sata.asl R src/mainboard/lippert/f14-halfboards/acpi/superio.asl R src/mainboard/lippert/f14-halfboards/acpi/usb.asl R src/mainboard/lippert/f14-halfboards/acpi_tables.c R src/mainboard/lippert/f14-halfboards/board_info.txt R src/mainboard/lippert/f14-halfboards/buildOpts.c R src/mainboard/lippert/f14-halfboards/cmos.layout R src/mainboard/lippert/f14-halfboards/dsdt.asl R src/mainboard/lippert/f14-halfboards/irq_tables.c R src/mainboard/lippert/f14-halfboards/mptable.c R src/mainboard/lippert/f14-halfboards/platform_cfg.h R src/mainboard/lippert/f14-halfboards/sema.c R src/mainboard/lippert/f14-halfboards/sema.h R src/mainboard/lippert/f14-halfboards/variants/frontrunner-af/BiosCallOuts.c R src/mainboard/lippert/f14-halfboards/variants/frontrunner-af/OemCustomize.c R src/mainboard/lippert/f14-halfboards/variants/frontrunner-af/board_info.txt R src/mainboard/lippert/f14-halfboards/variants/frontrunner-af/bootblock.c R src/mainboard/lippert/f14-halfboards/variants/frontrunner-af/devicetree.cb R src/mainboard/lippert/f14-halfboards/variants/frontrunner-af/mainboard.c R src/mainboard/lippert/f14-halfboards/variants/toucan-af/BiosCallOuts.c R src/mainboard/lippert/f14-halfboards/variants/toucan-af/OemCustomize.c R src/mainboard/lippert/f14-halfboards/variants/toucan-af/board_info.txt R src/mainboard/lippert/f14-halfboards/variants/toucan-af/bootblock.c R src/mainboard/lippert/f14-halfboards/variants/toucan-af/devicetree.cb R src/mainboard/lippert/f14-halfboards/variants/toucan-af/mainboard.c 30 files changed, 0 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/43289/1 diff --git a/src/mainboard/lippert/frontrunner-af/Kconfig b/src/mainboard/lippert/f14-halfboards/Kconfig similarity index 100% rename from src/mainboard/lippert/frontrunner-af/Kconfig rename to src/mainboard/lippert/f14-halfboards/Kconfig diff --git a/src/mainboard/lippert/frontrunner-af/Kconfig.name b/src/mainboard/lippert/f14-halfboards/Kconfig.name similarity index 100% rename from src/mainboard/lippert/frontrunner-af/Kconfig.name rename to src/mainboard/lippert/f14-halfboards/Kconfig.name diff --git a/src/mainboard/lippert/frontrunner-af/Makefile.inc b/src/mainboard/lippert/f14-halfboards/Makefile.inc similarity index 100% rename from src/mainboard/lippert/frontrunner-af/Makefile.inc rename to src/mainboard/lippert/f14-halfboards/Makefile.inc diff --git a/src/mainboard/lippert/frontrunner-af/OptionsIds.h b/src/mainboard/lippert/f14-halfboards/OptionsIds.h similarity index 100% rename from src/mainboard/lippert/frontrunner-af/OptionsIds.h rename to src/mainboard/lippert/f14-halfboards/OptionsIds.h diff --git a/src/mainboard/lippert/frontrunner-af/acpi/routing.asl b/src/mainboard/lippert/f14-halfboards/acpi/routing.asl similarity index 100% rename from src/mainboard/lippert/frontrunner-af/acpi/routing.asl rename to src/mainboard/lippert/f14-halfboards/acpi/routing.asl diff --git a/src/mainboard/lippert/frontrunner-af/acpi/sata.asl b/src/mainboard/lippert/f14-halfboards/acpi/sata.asl similarity index 100% rename from src/mainboard/lippert/frontrunner-af/acpi/sata.asl rename to src/mainboard/lippert/f14-halfboards/acpi/sata.asl diff --git a/src/mainboard/lippert/frontrunner-af/acpi/superio.asl b/src/mainboard/lippert/f14-halfboards/acpi/superio.asl similarity index 100% rename from src/mainboard/lippert/frontrunner-af/acpi/superio.asl rename to src/mainboard/lippert/f14-halfboards/acpi/superio.asl diff --git a/src/mainboard/lippert/frontrunner-af/acpi/usb.asl b/src/mainboard/lippert/f14-halfboards/acpi/usb.asl similarity index 100% rename from src/mainboard/lippert/frontrunner-af/acpi/usb.asl rename to src/mainboard/lippert/f14-halfboards/acpi/usb.asl diff --git a/src/mainboard/lippert/frontrunner-af/acpi_tables.c b/src/mainboard/lippert/f14-halfboards/acpi_tables.c similarity index 100% rename from src/mainboard/lippert/frontrunner-af/acpi_tables.c rename to src/mainboard/lippert/f14-halfboards/acpi_tables.c diff --git a/src/mainboard/lippert/frontrunner-af/board_info.txt b/src/mainboard/lippert/f14-halfboards/board_info.txt similarity index 100% rename from src/mainboard/lippert/frontrunner-af/board_info.txt rename to src/mainboard/lippert/f14-halfboards/board_info.txt diff --git a/src/mainboard/lippert/frontrunner-af/buildOpts.c b/src/mainboard/lippert/f14-halfboards/buildOpts.c similarity index 100% rename from src/mainboard/lippert/frontrunner-af/buildOpts.c rename to src/mainboard/lippert/f14-halfboards/buildOpts.c diff --git a/src/mainboard/lippert/frontrunner-af/cmos.layout b/src/mainboard/lippert/f14-halfboards/cmos.layout similarity index 100% rename from src/mainboard/lippert/frontrunner-af/cmos.layout rename to src/mainboard/lippert/f14-halfboards/cmos.layout diff --git a/src/mainboard/lippert/frontrunner-af/dsdt.asl b/src/mainboard/lippert/f14-halfboards/dsdt.asl similarity index 100% rename from src/mainboard/lippert/frontrunner-af/dsdt.asl rename to src/mainboard/lippert/f14-halfboards/dsdt.asl diff --git a/src/mainboard/lippert/frontrunner-af/irq_tables.c b/src/mainboard/lippert/f14-halfboards/irq_tables.c similarity index 100% rename from src/mainboard/lippert/frontrunner-af/irq_tables.c rename to src/mainboard/lippert/f14-halfboards/irq_tables.c diff --git a/src/mainboard/lippert/frontrunner-af/mptable.c b/src/mainboard/lippert/f14-halfboards/mptable.c similarity index 100% rename from src/mainboard/lippert/frontrunner-af/mptable.c rename to src/mainboard/lippert/f14-halfboards/mptable.c diff --git a/src/mainboard/lippert/frontrunner-af/platform_cfg.h b/src/mainboard/lippert/f14-halfboards/platform_cfg.h similarity index 100% rename from src/mainboard/lippert/frontrunner-af/platform_cfg.h rename to src/mainboard/lippert/f14-halfboards/platform_cfg.h diff --git a/src/mainboard/lippert/frontrunner-af/sema.c b/src/mainboard/lippert/f14-halfboards/sema.c similarity index 100% rename from src/mainboard/lippert/frontrunner-af/sema.c rename to src/mainboard/lippert/f14-halfboards/sema.c diff --git a/src/mainboard/lippert/frontrunner-af/sema.h b/src/mainboard/lippert/f14-halfboards/sema.h similarity index 100% rename from src/mainboard/lippert/frontrunner-af/sema.h rename to src/mainboard/lippert/f14-halfboards/sema.h diff --git a/src/mainboard/lippert/frontrunner-af/variants/frontrunner-af/BiosCallOuts.c b/src/mainboard/lippert/f14-halfboards/variants/frontrunner-af/BiosCallOuts.c similarity index 100% rename from src/mainboard/lippert/frontrunner-af/variants/frontrunner-af/BiosCallOuts.c rename to src/mainboard/lippert/f14-halfboards/variants/frontrunner-af/BiosCallOuts.c diff --git a/src/mainboard/lippert/frontrunner-af/variants/frontrunner-af/OemCustomize.c b/src/mainboard/lippert/f14-halfboards/variants/frontrunner-af/OemCustomize.c similarity index 100% rename from src/mainboard/lippert/frontrunner-af/variants/frontrunner-af/OemCustomize.c rename to src/mainboard/lippert/f14-halfboards/variants/frontrunner-af/OemCustomize.c diff --git a/src/mainboard/lippert/frontrunner-af/variants/frontrunner-af/board_info.txt b/src/mainboard/lippert/f14-halfboards/variants/frontrunner-af/board_info.txt similarity index 100% rename from src/mainboard/lippert/frontrunner-af/variants/frontrunner-af/board_info.txt rename to src/mainboard/lippert/f14-halfboards/variants/frontrunner-af/board_info.txt diff --git a/src/mainboard/lippert/frontrunner-af/variants/frontrunner-af/bootblock.c b/src/mainboard/lippert/f14-halfboards/variants/frontrunner-af/bootblock.c similarity index 100% rename from src/mainboard/lippert/frontrunner-af/variants/frontrunner-af/bootblock.c rename to src/mainboard/lippert/f14-halfboards/variants/frontrunner-af/bootblock.c diff --git a/src/mainboard/lippert/frontrunner-af/variants/frontrunner-af/devicetree.cb b/src/mainboard/lippert/f14-halfboards/variants/frontrunner-af/devicetree.cb similarity index 100% rename from src/mainboard/lippert/frontrunner-af/variants/frontrunner-af/devicetree.cb rename to src/mainboard/lippert/f14-halfboards/variants/frontrunner-af/devicetree.cb diff --git a/src/mainboard/lippert/frontrunner-af/variants/frontrunner-af/mainboard.c b/src/mainboard/lippert/f14-halfboards/variants/frontrunner-af/mainboard.c similarity index 100% rename from src/mainboard/lippert/frontrunner-af/variants/frontrunner-af/mainboard.c rename to src/mainboard/lippert/f14-halfboards/variants/frontrunner-af/mainboard.c diff --git a/src/mainboard/lippert/frontrunner-af/variants/toucan-af/BiosCallOuts.c b/src/mainboard/lippert/f14-halfboards/variants/toucan-af/BiosCallOuts.c similarity index 100% rename from src/mainboard/lippert/frontrunner-af/variants/toucan-af/BiosCallOuts.c rename to src/mainboard/lippert/f14-halfboards/variants/toucan-af/BiosCallOuts.c diff --git a/src/mainboard/lippert/frontrunner-af/variants/toucan-af/OemCustomize.c b/src/mainboard/lippert/f14-halfboards/variants/toucan-af/OemCustomize.c similarity index 100% rename from src/mainboard/lippert/frontrunner-af/variants/toucan-af/OemCustomize.c rename to src/mainboard/lippert/f14-halfboards/variants/toucan-af/OemCustomize.c diff --git a/src/mainboard/lippert/frontrunner-af/variants/toucan-af/board_info.txt b/src/mainboard/lippert/f14-halfboards/variants/toucan-af/board_info.txt similarity index 100% rename from src/mainboard/lippert/frontrunner-af/variants/toucan-af/board_info.txt rename to src/mainboard/lippert/f14-halfboards/variants/toucan-af/board_info.txt diff --git a/src/mainboard/lippert/frontrunner-af/variants/toucan-af/bootblock.c b/src/mainboard/lippert/f14-halfboards/variants/toucan-af/bootblock.c similarity index 100% rename from src/mainboard/lippert/frontrunner-af/variants/toucan-af/bootblock.c rename to src/mainboard/lippert/f14-halfboards/variants/toucan-af/bootblock.c diff --git a/src/mainboard/lippert/frontrunner-af/variants/toucan-af/devicetree.cb b/src/mainboard/lippert/f14-halfboards/variants/toucan-af/devicetree.cb similarity index 100% rename from src/mainboard/lippert/frontrunner-af/variants/toucan-af/devicetree.cb rename to src/mainboard/lippert/f14-halfboards/variants/toucan-af/devicetree.cb diff --git a/src/mainboard/lippert/frontrunner-af/variants/toucan-af/mainboard.c b/src/mainboard/lippert/f14-halfboards/variants/toucan-af/mainboard.c similarity index 100% rename from src/mainboard/lippert/frontrunner-af/variants/toucan-af/mainboard.c rename to src/mainboard/lippert/f14-halfboards/variants/toucan-af/mainboard.c -- To view, visit https://review.coreboot.org/c/coreboot/+/43289 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2a44af225f5e22dcee83009f0fdcb00d8a2bd1a0 Gerrit-Change-Number: 43289 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

1 6

Change in coreboot[master]: sb/intel/lynxpoint: Finalize ME in ramstage
by Aaron Durbin (Code Review) 01 Mar '21

01 Mar '21

Attention is currently required from: Martin Roth, Angel Pons, Arthur Heymans, Patrick Rudolph. Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51036 ) Change subject: sb/intel/lynxpoint: Finalize ME in ramstage ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: The current devices that shipped are bound to their fw branch so I think we should be good. If we ever moved to top of tree we'd be needing to reevaluate everything anyway. -- To view, visit https://review.coreboot.org/c/coreboot/+/51036 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9fde40a54f3fb8da2fba46c531443fdd2e067077 Gerrit-Change-Number: 51036 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Mon, 01 Mar 2021 21:34:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2021