coreboot-gerrit March 2021

coreboot-gerrit@coreboot.org

1 participants
7266 discussions

Change in coreboot[master]: sb/intel/lynxpoint: Finalize ME in ramstage
by Angel Pons (Code Review) 01 Mar '21

01 Mar '21

Attention is currently required from: Martin Roth, Arthur Heymans, Aaron Durbin, Patrick Rudolph. Hello build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth, Arthur Heymans, Aaron Durbin, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/51036 to look at the new patch set (#2). Change subject: sb/intel/lynxpoint: Finalize ME in ramstage ...................................................................... sb/intel/lynxpoint: Finalize ME in ramstage Performing ME finalization in SMM does not seem to be required. Tested on Asrock B85M Pro4, ME still gets finalized successfully. Change-Id: I9fde40a54f3fb8da2fba46c531443fdd2e067077 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/southbridge/intel/lynxpoint/Makefile.inc M src/southbridge/intel/lynxpoint/me.c M src/southbridge/intel/lynxpoint/me.h M src/southbridge/intel/lynxpoint/smihandler.c 4 files changed, 15 insertions(+), 47 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/51036/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/51036 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9fde40a54f3fb8da2fba46c531443fdd2e067077 Gerrit-Change-Number: 51036 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: sb/intel/lynxpoint: Retype `mei_base_address` pointer
by Angel Pons (Code Review) 01 Mar '21

01 Mar '21

Attention is currently required from: Nico Huber, Arthur Heymans, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51035 ) Change subject: sb/intel/lynxpoint: Retype `mei_base_address` pointer ...................................................................... Patch Set 2: (2 comments) File src/southbridge/intel/lynxpoint/me.c: https://review.coreboot.org/c/coreboot/+/51035/comment/b88b93bf_09d89d2a PS1, Line 541: 0xf > There's a macro for that 0xf mask Done https://review.coreboot.org/c/coreboot/+/51035/comment/43ff2465_8eaa5833 PS1, Line 541: mei_base_address = (u8 *)(pci_read_config32(PCH_ME_DEV, PCI_BASE_ADDRESS_0) & ~0xf); > Please cast to `uintptr_t` first. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/51035 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I32fdcc6b1ffde1b0701218a3bd0a61ab827081b5 Gerrit-Change-Number: 51035 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Mon, 01 Mar 2021 21:30:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: sb/intel/lynxpoint: Retype `mei_base_address` pointer
by Angel Pons (Code Review) 01 Mar '21

01 Mar '21

Attention is currently required from: Arthur Heymans, Patrick Rudolph. Hello build bot (Jenkins), Nico Huber, Arthur Heymans, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/51035 to look at the new patch set (#2). Change subject: sb/intel/lynxpoint: Retype `mei_base_address` pointer ...................................................................... sb/intel/lynxpoint: Retype `mei_base_address` pointer Also introduce uintptr_t cast and use PCI_BASE_ADDRESS_MEM_ATTR_MASK. Change-Id: I32fdcc6b1ffde1b0701218a3bd0a61ab827081b5 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/southbridge/intel/lynxpoint/me.c 1 file changed, 9 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/51035/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/51035 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I32fdcc6b1ffde1b0701218a3bd0a61ab827081b5 Gerrit-Change-Number: 51035 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: configs/config.google_volteer.build_test_purposes: Add file
by Tim Wawrzynczak (Code Review) 01 Mar '21

01 Mar '21

Attention is currently required from: Francois Toguo Fotso, Angel Pons. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51155 ) Change subject: configs/config.google_volteer.build_test_purposes: Add file ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: Thanks Angel! I think we're going to enable this on volteer soon too 😊 -- To view, visit https://review.coreboot.org/c/coreboot/+/51155 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie9bbfa538e38a4d835c1f8b0d45feb2f0fe803f8 Gerrit-Change-Number: 51155 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Francois Toguo Fotso <francois.toguo.fotso(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Francois Toguo Fotso <francois.toguo.fotso(a)intel.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 01 Mar 2021 21:17:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/tigerlake: Add CNVi Bluetooth flag at devicetree entry
by Cliff Huang (Code Review) 01 Mar '21

01 Mar '21

Attention is currently required from: Bora Guvendik, Anil Kumar K, Furquan Shaikh, Wonkyu Kim, Angel Pons, Bernardo Perez Priego, Srinidhi N Kaushik, Patrick Rudolph. Cliff Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50897 ) Change subject: soc/intel/tigerlake: Add CNVi Bluetooth flag at devicetree entry ...................................................................... Patch Set 6: (1 comment) File src/soc/intel/tigerlake/fsp_params.c: https://review.coreboot.org/c/coreboot/+/50897/comment/4506e3ef_16ba8140 PS6, Line 357: CnviBtCore > Made CB:51154 to drop the confusing values for the `CnviBtAudioOffload` devicetree option. […] one more change, add further condition for BT audio offload: dev = pcidev_path_on_root(PCH_DEVFN_CNVI_WIFI); params->CnviMode = is_dev_enabled(dev); if (params->CnviMode) { params->CnviBtCore = config->CnviBtCore; if (params->CnviBtCore) { params->CnviBtAudioOffload = config->CnviBtAudioOffload; } else { params->CnviBtAudioOffload = "FORCE_DISABLE"; } } else { params->CnviBtCore = 0; params->CnviBtAudioOffload = "FORCE_DISABLE"; } If agree, I will test on Volteer based on this. -- To view, visit https://review.coreboot.org/c/coreboot/+/50897 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I71c512fe884060e23ee26e7334c575c4c517b78d Gerrit-Change-Number: 50897 Gerrit-PatchSet: 6 Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: AndreX Andraos <andrex.andraos(a)intel.com> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-CC: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-CC: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com> Gerrit-Attention: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Mon, 01 Mar 2021 21:17:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Cliff Huang <cliff.huang(a)intel.com> Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/volteer: Fix FPMCU pwr/rst gpio handling
by Tim Wawrzynczak (Code Review) 01 Mar '21

01 Mar '21

Attention is currently required from: Nick Vaccaro, Craig Hesling. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50828 ) Change subject: mb/google/volteer: Fix FPMCU pwr/rst gpio handling ...................................................................... Patch Set 9: Code-Review+2 (1 comment) Patchset: PS9: Duncan's word is good enough for me 😊 -- To view, visit https://review.coreboot.org/c/coreboot/+/50828 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib51815349cea299907c10d6c56c27bd239e499e7 Gerrit-Change-Number: 50828 Gerrit-PatchSet: 9 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Craig Hesling <hesling(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Craig Hesling <hesling(a)chromium.org> Gerrit-Comment-Date: Mon, 01 Mar 2021 21:15:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/tigerlake: Re-use existing define in CrashLog implementation
by Angel Pons (Code Review) 01 Mar '21

01 Mar '21

Attention is currently required from: Francois Toguo Fotso, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51096 ) Change subject: soc/intel/tigerlake: Re-use existing define in CrashLog implementation ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: > There is already one named SOC_INTEL_COMMON_BLOCK_CRASHLOG inside […] I just added a config file to build-test Crashlog on TGL: CB:51155 -- To view, visit https://review.coreboot.org/c/coreboot/+/51096 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If063d1ea4189dbc5a75f37d86ce158e8f1bd808d Gerrit-Change-Number: 51096 Gerrit-PatchSet: 4 Gerrit-Owner: Francois Toguo Fotso <francois.toguo.fotso(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Francois Toguo Fotso <francois.toguo.fotso(a)intel.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Francois Toguo Fotso <francois.toguo.fotso(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Mon, 01 Mar 2021 21:14:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Francois Toguo Fotso <francois.toguo.fotso(a)intel.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: configs/config.google_volteer.build_test_purposes: Add file
by Angel Pons (Code Review) 01 Mar '21

01 Mar '21

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/51155 ) Change subject: configs/config.google_volteer.build_test_purposes: Add file ...................................................................... configs/config.google_volteer.build_test_purposes: Add file This is meant to build-test Crashlog and various debug options. Change-Id: Ie9bbfa538e38a4d835c1f8b0d45feb2f0fe803f8 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- A configs/config.google_volteer.build_test_purposes 1 file changed, 32 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/51155/1 diff --git a/configs/config.google_volteer.build_test_purposes b/configs/config.google_volteer.build_test_purposes new file mode 100644 index 0000000..7b0d47f --- /dev/null +++ b/configs/config.google_volteer.build_test_purposes @@ -0,0 +1,32 @@ +# Not meant for actual use, but rather to build-test individual options. +# If keeping this combination of options buildable becomes too hard in +# the future, then this config can be split into several smaller chunks. +# Exercises, among other things: +# + Debug options +# + Crashlog +# + Flashconsole +CONFIG_VENDOR_GOOGLE=y +CONFIG_CONSOLE_POST=y +CONFIG_BOARD_GOOGLE_VOLTEER2=y +CONFIG_USE_LEGACY_8254_TIMER=y +CONFIG_INTEL_TME=y +CONFIG_SOC_INTEL_CRASHLOG=y +CONFIG_NO_GFX_INIT=y +CONFIG_DISPLAY_HOBS=y +CONFIG_DISPLAY_UPD_DATA=y +CONFIG_CONSOLE_SPI_FLASH=y +CONFIG_DEFAULT_CONSOLE_LOGLEVEL_8=y +CONFIG_DISPLAY_MTRRS=y +CONFIG_DISPLAY_FSP_CALLS_AND_STATUS=y +CONFIG_DISPLAY_FSP_HEADER=y +CONFIG_VERIFY_HOBS=y +CONFIG_FATAL_ASSERTS=y +CONFIG_DEBUG_GPIO=y +CONFIG_DEBUG_CBFS=y +CONFIG_DEBUG_SMBUS=y +CONFIG_DEBUG_SMI=y +CONFIG_DEBUG_PERIODIC_SMI=y +CONFIG_DEBUG_MALLOC=y +CONFIG_DEBUG_CONSOLE_INIT=y +CONFIG_DEBUG_SPI_FLASH=y +CONFIG_DEBUG_BOOT_STATE=y -- To view, visit https://review.coreboot.org/c/coreboot/+/51155 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie9bbfa538e38a4d835c1f8b0d45feb2f0fe803f8 Gerrit-Change-Number: 51155 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/volteer: Fix FPMCU pwr/rst gpio handling
by Duncan Laurie (Code Review) 01 Mar '21

01 Mar '21

Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro, Craig Hesling. Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50828 ) Change subject: mb/google/volteer: Fix FPMCU pwr/rst gpio handling ...................................................................... Patch Set 9: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/50828/comment/c2d75066_22d9cbff PS8, Line 10: 2. Disable power and assert reset in ramstage gpio > Duncan, any chance to test this yet? I had tested the previous version, just tested this iteration and it still works. -- To view, visit https://review.coreboot.org/c/coreboot/+/50828 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib51815349cea299907c10d6c56c27bd239e499e7 Gerrit-Change-Number: 50828 Gerrit-PatchSet: 9 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Craig Hesling <hesling(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Craig Hesling <hesling(a)chromium.org> Gerrit-Comment-Date: Mon, 01 Mar 2021 21:12:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Comment-In-Reply-To: Duncan Laurie <dlaurie(a)chromium.org> Comment-In-Reply-To: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/cannonlake: Move `gpi_clear_int_cfg()` call
by Tim Wawrzynczak (Code Review) 01 Mar '21

01 Mar '21

Attention is currently required from: Furquan Shaikh, Angel Pons, Subrata Banik, Michael Niewöhner, Patrick Rudolph. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51148 ) Change subject: soc/intel/cannonlake: Move `gpi_clear_int_cfg()` call ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/51148 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0f40ee7fd47f7f9f582f314dfcd1b4b93b1db791 Gerrit-Change-Number: 51148 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Mon, 01 Mar 2021 21:12:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2021