coreboot-gerrit February 2021

coreboot-gerrit@coreboot.org

1 participants
7192 discussions

Change in coreboot[master]: mb/ocp/deltalake: Implement skipping TXT lockdown via VPD
by Angel Pons (Code Review) 02 Feb '21

02 Feb '21

Attention is currently required from: Anjaneya "Reddy" Chagam, Patrick Rudolph, Jonathan Zhang, Johnny Lin, Arthur Heymans, Morgan Jang. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50237 ) Change subject: mb/ocp/deltalake: Implement skipping TXT lockdown via VPD ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/50237 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic5daf96bdda9c36054c410b07b08bcd3482d777c Gerrit-Change-Number: 50237 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Comment-Date: Tue, 02 Feb 2021 18:43:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: security/intel/txt: Add weak function to skip TXT lockdown
by Angel Pons (Code Review) 02 Feb '21

02 Feb '21

Attention is currently required from: Patrick Rudolph, Jonathan Zhang, Arthur Heymans. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50236 ) Change subject: security/intel/txt: Add weak function to skip TXT lockdown ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/security/intel/txt/ramstage.c: https://review.coreboot.org/c/coreboot/+/50236/comment/eeda25fb_0ab33d61 PS1, Line 301: skip_intel_txt skip_intel_txt_lockdown ? -- To view, visit https://review.coreboot.org/c/coreboot/+/50236 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If9193a03be7e1345740ddc705f20dd4d05f3af26 Gerrit-Change-Number: 50236 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Tue, 02 Feb 2021 18:43:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/tgl: Disable S0i3.2 & S0i3.3 substates
by Furquan Shaikh (Code Review) 02 Feb '21

02 Feb '21

Attention is currently required from: Shreesh Chhabbi. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49766 ) Change subject: soc/intel/tgl: Disable S0i3.2 & S0i3.3 substates ...................................................................... Patch Set 8: (1 comment) File src/soc/intel/tigerlake/fsp_params.c: https://review.coreboot.org/c/coreboot/+/49766/comment/a0050c48_1e79d3f0 PS3, Line 236: LpmStateEnableMask > Hi Furquan, I did not find the upds for external bypass, external clk gate and external phy gate. […] Hi Shreesh, I was referring to adding configs for external bypass, external clk and phy gate to `soc_intel_alderlake_config` here: https://review.coreboot.org/cgit/coreboot.git/tree/src/soc/intel/alderlake/… And then update current boards (tglrvp and volteer) to set these as per their design. Then this function can set the disable mask appropriately. Does that make sense? -- To view, visit https://review.coreboot.org/c/coreboot/+/49766 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5f2ac8b72d0c9b05bc02c092188d0c742cc83af9 Gerrit-Change-Number: 49766 Gerrit-PatchSet: 8 Gerrit-Owner: Shreesh Chhabbi <shreesh.chhabbi(a)intel.com> Gerrit-Reviewer: Alex Levin <levinale(a)google.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Shreesh Chhabbi <shreesh.chhabbi(a)intel.corp-partner.google.com> Gerrit-Reviewer: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Shreesh Chhabbi <shreesh.chhabbi(a)intel.com> Gerrit-Comment-Date: Tue, 02 Feb 2021 18:32:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com> Comment-In-Reply-To: Shreesh Chhabbi <shreesh.chhabbi(a)intel.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/amd/majolica: add fmd for use when building chromeos
by Mathew King (Code Review) 02 Feb '21

02 Feb '21

Attention is currently required from: Jason Glenesk, Martin Roth, Marshall Dawson. Mathew King has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50208 ) Change subject: mb/amd/majolica: add fmd for use when building chromeos ...................................................................... Patch Set 2: (2 comments) Patchset: PS1: > maybe leave the board.fmd as it is right now and add a chromeos. […] Done Patchset: PS2: > looks good to me. […] Looks like CHROMEOS is correct. -- To view, visit https://review.coreboot.org/c/coreboot/+/50208 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5eb3c60fe60e4029485fae642c88c5c013ffb3f6 Gerrit-Change-Number: 50208 Gerrit-PatchSet: 2 Gerrit-Owner: Mathew King <mathewk(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Comment-Date: Tue, 02 Feb 2021 18:29:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Mathew King <mathewk(a)chromium.org> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/xeon_sp: Skip Locking down TXT related registers
by Arthur Heymans (Code Review) 02 Feb '21

02 Feb '21

Attention is currently required from: Patrick Rudolph. Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/50238 ) Change subject: soc/intel/xeon_sp: Skip Locking down TXT related registers ...................................................................... soc/intel/xeon_sp: Skip Locking down TXT related registers When Locking down TXT is skipped, e.g. to do error injection, Locking down DMI3 and IIO DFX related TXT registers should also be skipped. Change-Id: Ieef25c02ec103eaef65d8b44467ccb9e6917bb6c Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/soc/intel/xeon_sp/uncore.c 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/50238/1 diff --git a/src/soc/intel/xeon_sp/uncore.c b/src/soc/intel/xeon_sp/uncore.c index dede931..7fddb13 100644 --- a/src/soc/intel/xeon_sp/uncore.c +++ b/src/soc/intel/xeon_sp/uncore.c @@ -12,6 +12,7 @@ #include <soc/util.h> #include <fsp/util.h> #include <security/intel/txt/txt_platform.h> +#include <security/intel/txt/txt.h> struct map_entry { uint32_t reg; @@ -350,6 +351,8 @@ static void dmi3_init(struct device *dev) { + if (skip_intel_txt()) + return; /* Disable error injection */ pci_or_config16(dev, ERRINJCON, 1 << 0); @@ -376,6 +379,9 @@ static void iio_dfx_global_init(struct device *dev) { + if (skip_intel_txt()) + return; + uint16_t reg16; pci_or_config16(dev, IIO_DFX_LCK_CTL, 0x3ff); reg16 = pci_read_config16(dev, IIO_DFX_TSWCTL0); -- To view, visit https://review.coreboot.org/c/coreboot/+/50238 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieef25c02ec103eaef65d8b44467ccb9e6917bb6c Gerrit-Change-Number: 50238 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/ocp/deltalake: Implement skipping TXT lockdown via VPD
by Arthur Heymans (Code Review) 02 Feb '21

02 Feb '21

Attention is currently required from: Anjaneya "Reddy" Chagam, Jonathan Zhang, Johnny Lin, Morgan Jang. Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/50237 ) Change subject: mb/ocp/deltalake: Implement skipping TXT lockdown via VPD ...................................................................... mb/ocp/deltalake: Implement skipping TXT lockdown via VPD This allows to skip TXT Lockdown via "skip_intel_txt" VPD parameter. Change-Id: Ic5daf96bdda9c36054c410b07b08bcd3482d777c Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/mainboard/ocp/deltalake/ramstage.c M src/mainboard/ocp/deltalake/vpd.h 2 files changed, 23 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/50237/1 diff --git a/src/mainboard/ocp/deltalake/ramstage.c b/src/mainboard/ocp/deltalake/ramstage.c index 40810b6..7341e99 100644 --- a/src/mainboard/ocp/deltalake/ramstage.c +++ b/src/mainboard/ocp/deltalake/ramstage.c @@ -5,6 +5,8 @@ #include <bootstate.h> #include <drivers/ipmi/ipmi_ops.h> #include <drivers/ocp/dmi/ocp_dmi.h> +#include <drivers/vpd/vpd.h> +#include <security/intel/txt/txt.h> #include <soc/ramstage.h> #include <soc/soc_util.h> #include <stdio.h> @@ -18,6 +20,7 @@ #include <cpxsp_dl_gpio.h> #include "ipmi.h" +#include "vpd.h" #define SLOT_ID_LEN 2 @@ -359,3 +362,19 @@ .enable_dev = mainboard_enable, .final = mainboard_final, }; + +bool skip_intel_txt(void) +{ + static bool fetched_vpd = 0; + static uint8_t skip_txt = SKIP_INTEL_TXT_DEFAULT; + + if (fetched_vpd) + return (bool)skip_txt; + + if (!vpd_get_bool(SKIP_INTEL_TXT, VPD_RW_THEN_RO, &skip_txt)) + printk(BIOS_INFO, "Not able to get VPD %s, default set to %d\n", + SKIP_INTEL_TXT, SKIP_INTEL_TXT_DEFAULT); + fetched_vpd = 1; + + return (bool)skip_txt; +} diff --git a/src/mainboard/ocp/deltalake/vpd.h b/src/mainboard/ocp/deltalake/vpd.h index 82989ff..ca47010 100644 --- a/src/mainboard/ocp/deltalake/vpd.h +++ b/src/mainboard/ocp/deltalake/vpd.h @@ -37,4 +37,8 @@ #define FSPM_MEMREFRESHWATERMARK "fspm_mem_refresh_watermark" #define FSPM_MEMREFRESHWATERMARK_DEFAULT 1 +/* Skip TXT lockdown */ +#define SKIP_INTEL_TXT "skip_intel_txt" +#define SKIP_INTEL_TXT_DEFAULT 0 + #endif -- To view, visit https://review.coreboot.org/c/coreboot/+/50237 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic5daf96bdda9c36054c410b07b08bcd3482d777c Gerrit-Change-Number: 50237 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Attention: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: security/intel/txt: Add weak function to skip TXT lockdown
by Arthur Heymans (Code Review) 02 Feb '21

02 Feb '21

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/50236 ) Change subject: security/intel/txt: Add weak function to skip TXT lockdown ...................................................................... security/intel/txt: Add weak function to skip TXT lockdown RAS error injection requires TXT and other related lockdown steps to be skipped. Change-Id: If9193a03be7e1345740ddc705f20dd4d05f3af26 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/security/intel/txt/ramstage.c M src/security/intel/txt/txt.h 2 files changed, 10 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/50236/1 diff --git a/src/security/intel/txt/ramstage.c b/src/security/intel/txt/ramstage.c index 3401aef..f83193e 100644 --- a/src/security/intel/txt/ramstage.c +++ b/src/security/intel/txt/ramstage.c @@ -298,6 +298,11 @@ push_sinit_heap(&heap_struct, NULL, 0); } +__weak bool skip_intel_txt(void) +{ + return false; +} + /** * Finalize the TXT device. * @@ -309,6 +314,9 @@ */ static void lockdown_intel_txt(void *unused) { + if (skip_intel_txt()) + return; + const uint64_t status = read64((void *)TXT_SPAD); uint32_t txt_feature_flags = 0; diff --git a/src/security/intel/txt/txt.h b/src/security/intel/txt/txt.h index 976cc74..1b9c751 100644 --- a/src/security/intel/txt/txt.h +++ b/src/security/intel/txt/txt.h @@ -26,5 +26,7 @@ void intel_txt_run_sclean(void); int intel_txt_run_bios_acm(const u8 input_params); bool intel_txt_prepare_txt_env(void); +/* Allow platform override to skip TXT init, e.g. required for RAS error injection. */ +bool skip_intel_txt(void); #endif /* SECURITY_INTEL_TXT_H_ */ -- To view, visit https://review.coreboot.org/c/coreboot/+/50236 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If9193a03be7e1345740ddc705f20dd4d05f3af26 Gerrit-Change-Number: 50236 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/amd/majolica: add fmd for use when building chromeos
by Felix Held (Code Review) 02 Feb '21

02 Feb '21

Attention is currently required from: Jason Glenesk, Martin Roth, Marshall Dawson, Mathew King. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50208 ) Change subject: mb/amd/majolica: add fmd for use when building chromeos ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS2: looks good to me. or should that be an if VBOOT? not sure about that; you'll probably know that part better -- To view, visit https://review.coreboot.org/c/coreboot/+/50208 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5eb3c60fe60e4029485fae642c88c5c013ffb3f6 Gerrit-Change-Number: 50208 Gerrit-PatchSet: 2 Gerrit-Owner: Mathew King <mathewk(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Mathew King <mathewk(a)chromium.org> Gerrit-Comment-Date: Tue, 02 Feb 2021 18:22:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/volteer/variant/copano: support regular/numpad touchpad
by Tim Wawrzynczak (Code Review) 02 Feb '21

02 Feb '21

Attention is currently required from: Nick Vaccaro, Zhuohao Lee. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50129 ) Change subject: mb/google/volteer/variant/copano: support regular/numpad touchpad ...................................................................... Patch Set 1: Code-Review+2 (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/50129/comment/d6e18dfb_fae57b26 PS1, Line 13: BRANCH=firmware-volteer-13672.B-mai BRANCH=firmware-volteer-13672.B Patchset: PS1: Sorry, lost track of this one -- To view, visit https://review.coreboot.org/c/coreboot/+/50129 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic5d61f19fd385600cfdcdd045dab1e61b06e4663 Gerrit-Change-Number: 50129 Gerrit-PatchSet: 1 Gerrit-Owner: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Marco Chen <marcochen(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Comment-Date: Tue, 02 Feb 2021 18:18:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/amd/majolica: add fmd for use when building chromeos
by Mathew King (Code Review) 02 Feb '21

02 Feb '21

Attention is currently required from: Jason Glenesk, Martin Roth, Marshall Dawson, Mathew King. Hello build bot (Jenkins), Jason Glenesk, Martin Roth, Marshall Dawson, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/50208 to look at the new patch set (#2). Change subject: mb/amd/majolica: add fmd for use when building chromeos ...................................................................... mb/amd/majolica: add fmd for use when building chromeos BUG=b:177909472 TEST=builds Change-Id: I5eb3c60fe60e4029485fae642c88c5c013ffb3f6 Signed-off-by: Mathew King <mathewk(a)chromium.org> --- M src/mainboard/amd/majolica/Kconfig A src/mainboard/amd/majolica/chromeos.fmd 2 files changed, 15 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/50208/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/50208 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5eb3c60fe60e4029485fae642c88c5c013ffb3f6 Gerrit-Change-Number: 50208 Gerrit-PatchSet: 2 Gerrit-Owner: Mathew King <mathewk(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Mathew King <mathewk(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2021