Attention is currently required from: V Sowmya, Martin Roth, Tim Wawrzynczak, Sugnan Prabhu S, Angel Pons, Balaji Manigandan, Aamir Bohra.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49479 )
Change subject: mb/intel/shadowmountain: Add bootblock and verstage code
......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/intel/shadowmountain/Kconfig:
https://review.coreboot.org/c/coreboot/+/49479/comment/af82084c_2e23d263
PS6, Line 6: select CHROMEOS
> not by default.
@Sowmya, you don't need to select this by default.
--
To view, visit https://review.coreboot.org/c/coreboot/+/49479
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5f805baf42203306ff10e91a258d9117dd986c4a
Gerrit-Change-Number: 49479
Gerrit-PatchSet: 6
Gerrit-Owner: V Sowmya <v.sowmya(a)intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: V Sowmya <v.sowmya(a)intel.com>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-Attention: Aamir Bohra <aamir.bohra(a)intel.com>
Gerrit-Comment-Date: Thu, 04 Feb 2021 14:04:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: V Sowmya, Martin Roth, Tim Wawrzynczak, Sugnan Prabhu S, Angel Pons, Balaji Manigandan, Aamir Bohra.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49479 )
Change subject: mb/intel/shadowmountain: Add bootblock and verstage code
......................................................................
Patch Set 6: Code-Review-1
(2 comments)
Patchset:
PS6:
Selection of CHROMEOS seems unwarranted and should be explained in detail.
File src/mainboard/intel/shadowmountain/Kconfig:
https://review.coreboot.org/c/coreboot/+/49479/comment/0aba4582_3232a7cc
PS5, Line 24: default y
> @angel, This should never be disabled for this mainboard and i also verified that disabling it doesn […]
If that is true, this is the first board that requires CHROMEOS
selected. Can you please explain what makes this board special
wrt. CHROMEOS? What doesn't work as expected without it selected?
--
To view, visit https://review.coreboot.org/c/coreboot/+/49479
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5f805baf42203306ff10e91a258d9117dd986c4a
Gerrit-Change-Number: 49479
Gerrit-PatchSet: 6
Gerrit-Owner: V Sowmya <v.sowmya(a)intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: V Sowmya <v.sowmya(a)intel.com>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-Attention: Aamir Bohra <aamir.bohra(a)intel.com>
Gerrit-Comment-Date: Thu, 04 Feb 2021 13:57:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: V Sowmya <v.sowmya(a)intel.com>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Hung-Te Lin, Yu-Ping Wu.
Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50276 )
Change subject: mb/google/kukui: Add byte mode/single rank DRAM support for burnet/esche
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/50276/comment/0f8d07a0_809c971d
PS1, Line 7: mb/google/kukui: Add LPDDR4X byte mode/single rank DRAM support for burnet/esche
> Line too long
Done
https://review.coreboot.org/c/coreboot/+/50276/comment/09a5a080_437ccf17
PS1, Line 13: master
> none
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/50276
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaa735c23889860218f6f6571cf0bc0b21b304b51
Gerrit-Change-Number: 50276
Gerrit-PatchSet: 3
Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Thu, 04 Feb 2021 13:31:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Hung-Te Lin, Kevin Chiu.
Hello Hung-Te Lin, build bot (Jenkins), Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/50276
to look at the new patch set (#3).
Change subject: mb/google/kukui: Add byte mode/single rank DRAM support for burnet/esche
......................................................................
mb/google/kukui: Add byte mode/single rank DRAM support for burnet/esche
ID#5: Hynix - H9HCNNNFAMMLXR-NEE (Byte mode)
ID#7: MICRON - MT53E1G32D2NP-046 WT:A (Single rank)
BUG=b:165768895
TEST=1. emerge-jacuzzi coreboot
2. power on test ok
Change-Id: Iaa735c23889860218f6f6571cf0bc0b21b304b51
Signed-off-by: Kevin Chiu <kevin.chiu(a)quantatw.com>
---
M src/mainboard/google/kukui/sdram_configs.c
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/50276/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/50276
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaa735c23889860218f6f6571cf0bc0b21b304b51
Gerrit-Change-Number: 50276
Gerrit-PatchSet: 3
Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Hung-Te Lin, Kevin Chiu.
Hello Hung-Te Lin, build bot (Jenkins), Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/50276
to look at the new patch set (#2).
Change subject: mb/google/kukui: Add byte mode/single rank DRAM support for burnet/esche
......................................................................
mb/google/kukui: Add byte mode/single rank DRAM support for burnet/esche
ID#5: Hynix - H9HCNNNFAMMLXR-NEE (Byte mode)
ID#7: MICRON - MT53E1G32D2NP-046 WT:A (Single rank)
BUG=b:165768895
BRANCH=master
TEST=1. emerge-jacuzzi coreboot
2. power on test ok
Change-Id: Iaa735c23889860218f6f6571cf0bc0b21b304b51
Signed-off-by: Kevin Chiu <kevin.chiu(a)quantatw.com>
---
M src/mainboard/google/kukui/sdram_configs.c
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/50276/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/50276
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaa735c23889860218f6f6571cf0bc0b21b304b51
Gerrit-Change-Number: 50276
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Kevin Chiu, Martin Roth, Furquan Shaikh, Bhanu Prakash Maiya, Eric Peers.
Hello build bot (Jenkins), Martin Roth, Furquan Shaikh, Patrick Georgi, Bhanu Prakash Maiya, Eric Peers,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/50284
to look at the new patch set (#2).
Change subject: mb/google/zork: Adjust Dirinboz H1 I2C CLK
......................................................................
mb/google/zork: Adjust Dirinboz H1 I2C CLK
Adjust H1 I2C CLK:
404kHz -> 391 kHz
BUG=b:178656936
BRANCH=master
TEST=1. emerge-zork coreboot chromeos-bootimage
2. power on proto board successfully
3. measure i2c freq by scope is close to 400kHz
Change-Id: I9067db9fc7a4d6aa2ce33b86ba6a611dfd5d7838
Signed-off-by: Kevin Chiu <kevin.chiu(a)quantatw.com>
---
M src/mainboard/google/zork/variants/dirinboz/overridetree.cb
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/50284/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/50284
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9067db9fc7a4d6aa2ce33b86ba6a611dfd5d7838
Gerrit-Change-Number: 50284
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Reviewer: Bhanu Prakash Maiya <bhanumaiya(a)google.com>
Gerrit-Reviewer: Eric Peers <epeers(a)google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Bhanu Prakash Maiya <bhanumaiya(a)google.com>
Gerrit-Attention: Eric Peers <epeers(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Martin Roth, Tim Wawrzynczak, Sugnan Prabhu S, Angel Pons, Balaji Manigandan, Aamir Bohra.
V Sowmya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49479 )
Change subject: mb/intel/shadowmountain: Add bootblock and verstage code
......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/intel/shadowmountain/Kconfig:
https://review.coreboot.org/c/coreboot/+/49479/comment/9259112f_45aa0078
PS5, Line 24: default y
> Selecting it is even worse: now CHROMEOS can never be disabled...
@angel, This should never be disabled for this mainboard and i also verified that disabling it doesn't cause any build error (abuild), any suggestion on handling this since this needs to be enabled?
--
To view, visit https://review.coreboot.org/c/coreboot/+/49479
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5f805baf42203306ff10e91a258d9117dd986c4a
Gerrit-Change-Number: 49479
Gerrit-PatchSet: 6
Gerrit-Owner: V Sowmya <v.sowmya(a)intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-Attention: Aamir Bohra <aamir.bohra(a)intel.com>
Gerrit-Comment-Date: Thu, 04 Feb 2021 13:04:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: V Sowmya <v.sowmya(a)intel.com>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment