Attention is currently required from: Jonathan Zhang, Philipp Deppenwiese, Angel Pons.
Deomid "rojer" Ryabkov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50307 )
Change subject: Port locked MSR fix to Watson and Watson V2
......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/50307/comment/6fe432f2_d31628c3
PS1, Line 9: Original commit: 817994c1bec48733679c34fe717a07ad81af18ac
> Maybe we should move this to soc/intel/fsp_broadwell_de
good idea. can you suggest the right function to add it to?
--
To view, visit https://review.coreboot.org/c/coreboot/+/50307
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: 4.11_branch
Gerrit-Change-Id: Ica9557ff159321abed55f9402aee626f18fe526b
Gerrit-Change-Number: 50307
Gerrit-PatchSet: 4
Gerrit-Owner: Deomid "rojer" Ryabkov <rojer9(a)fb.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Philipp Deppenwiese <philipp.deppenwiese(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Attention: Philipp Deppenwiese <philipp.deppenwiese(a)9elements.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Fri, 05 Feb 2021 17:49:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jonathan Zhang <jonzhang(a)fb.com>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Jonathan Zhang, Philipp Deppenwiese, Deomid "rojer" Ryabkov.
Hello build bot (Jenkins), Jonathan Zhang, Philipp Deppenwiese, Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/50307
to look at the new patch set (#4).
Change subject: Port locked MSR fix to Watson and Watson V2
......................................................................
Port locked MSR fix to Watson and Watson V2
This change was made to both wedge100 and MonoLake that are BDW-DE based.
We found same problem happening with Watson.
Original change: CB:30290
Signed-off-by: Deomid "rojer" Ryabkov <rojer9(a)fb.com>
Change-Id: Ica9557ff159321abed55f9402aee626f18fe526b
---
M src/mainboard/facebook/watson/romstage.c
1 file changed, 17 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/50307/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/50307
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: 4.11_branch
Gerrit-Change-Id: Ica9557ff159321abed55f9402aee626f18fe526b
Gerrit-Change-Number: 50307
Gerrit-PatchSet: 4
Gerrit-Owner: Deomid "rojer" Ryabkov <rojer9(a)fb.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Philipp Deppenwiese <philipp.deppenwiese(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Attention: Philipp Deppenwiese <philipp.deppenwiese(a)9elements.com>
Gerrit-Attention: Deomid "rojer" Ryabkov <rojer9(a)fb.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Frans Hendriks, Julius Werner.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49960 )
Change subject: console/vtxprintf.c: Correct code style
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
> I was not aware of the previous discussions about the checkpatch on actual code. […]
Good questions for the mailing list.
IMO, our coding style is not mandatory, so there is no "should"
beside "the code should look good and reasonably similar to our
coding style". Hence, I don't like to bikeshed already merged
code (unless it can be made better without any doubt). And also
not new code if it looks like the author cared to make it
readable. Other people's opinions probably differ.
--
To view, visit https://review.coreboot.org/c/coreboot/+/49960
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibb200bf7dd1ef7632aa4e1213bce72d9165560c9
Gerrit-Change-Number: 49960
Gerrit-PatchSet: 2
Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Julius Werner <jwerner(a)chromium.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Fri, 05 Feb 2021 17:44:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-MessageType: comment
Attention is currently required from: Jonathan Zhang, Philipp Deppenwiese, Deomid "rojer" Ryabkov.
Hello build bot (Jenkins), Jonathan Zhang, Philipp Deppenwiese, Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/50307
to look at the new patch set (#3).
Change subject: Port locked MSR fix to Watson and Watson V2
......................................................................
Port locked MSR fix to Watson and Watson V2
This change was made to both wedge100 and MonoLake that are BDW-DE based.
We found same problem happening with Watson.
Original commit: [CB:817994c1bec48733679c34fe717a07ad81af18ac]
Signed-off-by: Deomid "rojer" Ryabkov <rojer9(a)fb.com>
Change-Id: Ica9557ff159321abed55f9402aee626f18fe526b
---
M src/mainboard/facebook/watson/romstage.c
1 file changed, 17 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/50307/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/50307
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: 4.11_branch
Gerrit-Change-Id: Ica9557ff159321abed55f9402aee626f18fe526b
Gerrit-Change-Number: 50307
Gerrit-PatchSet: 3
Gerrit-Owner: Deomid "rojer" Ryabkov <rojer9(a)fb.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Philipp Deppenwiese <philipp.deppenwiese(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Attention: Philipp Deppenwiese <philipp.deppenwiese(a)9elements.com>
Gerrit-Attention: Deomid "rojer" Ryabkov <rojer9(a)fb.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Jonathan Zhang, Philipp Deppenwiese, Deomid "rojer" Ryabkov.
Hello Jonathan Zhang, Philipp Deppenwiese, Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/50307
to look at the new patch set (#2).
Change subject: Port locked MSR fix to Watson and Watson V2
......................................................................
Port locked MSR fix to Watson and Watson V2
This change was made to both wedge100 and MonoLake that are BDW-DE based.
We found same problem happening with Watson.
Original commit: CB:817994c1bec48733679c34fe717a07ad81af18ac
Signed-off-by: Deomid "rojer" Ryabkov <rojer9(a)fb.com>
Change-Id: Ica9557ff159321abed55f9402aee626f18fe526b
---
M src/mainboard/facebook/watson/romstage.c
1 file changed, 17 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/50307/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/50307
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: 4.11_branch
Gerrit-Change-Id: Ica9557ff159321abed55f9402aee626f18fe526b
Gerrit-Change-Number: 50307
Gerrit-PatchSet: 2
Gerrit-Owner: Deomid "rojer" Ryabkov <rojer9(a)fb.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Philipp Deppenwiese <philipp.deppenwiese(a)9elements.com>
Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Attention: Philipp Deppenwiese <philipp.deppenwiese(a)9elements.com>
Gerrit-Attention: Deomid "rojer" Ryabkov <rojer9(a)fb.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Jonathan Zhang, Philipp Deppenwiese, Deomid "rojer" Ryabkov.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50307 )
Change subject: Port locked MSR fix to Watson and Watson V2
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/50307/comment/6ab5ce88_19a47530
PS1, Line 9: Original commit: 817994c1bec48733679c34fe717a07ad81af18ac
> The message could be more descriptive: […]
Maybe we should move this to soc/intel/fsp_broadwell_de
--
To view, visit https://review.coreboot.org/c/coreboot/+/50307
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: 4.11_branch
Gerrit-Change-Id: Ica9557ff159321abed55f9402aee626f18fe526b
Gerrit-Change-Number: 50307
Gerrit-PatchSet: 1
Gerrit-Owner: Deomid "rojer" Ryabkov <rojer9(a)fb.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Philipp Deppenwiese <philipp.deppenwiese(a)9elements.com>
Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Attention: Philipp Deppenwiese <philipp.deppenwiese(a)9elements.com>
Gerrit-Attention: Deomid "rojer" Ryabkov <rojer9(a)fb.com>
Gerrit-Comment-Date: Fri, 05 Feb 2021 17:41:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-MessageType: comment
Attention is currently required from: Philipp Deppenwiese, Angel Pons, Deomid "rojer" Ryabkov.
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50307 )
Change subject: Port locked MSR fix to Watson and Watson V2
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/50307/comment/c48fa599_d9fdc1ae
PS1, Line 9: Original commit: 817994c1bec48733679c34fe717a07ad81af18ac
The message could be more descriptive:
* This change was made to both wedge100 and MonoLake that are BDW-DE based. We found same problem happening with Watson.
* If you do [CB:nnnnn], it will show up as a link in gerrit UI. This makes other people's work easier.
--
To view, visit https://review.coreboot.org/c/coreboot/+/50307
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: 4.11_branch
Gerrit-Change-Id: Ica9557ff159321abed55f9402aee626f18fe526b
Gerrit-Change-Number: 50307
Gerrit-PatchSet: 1
Gerrit-Owner: Deomid "rojer" Ryabkov <rojer9(a)fb.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Philipp Deppenwiese <philipp.deppenwiese(a)9elements.com>
Gerrit-Attention: Philipp Deppenwiese <philipp.deppenwiese(a)9elements.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Deomid "rojer" Ryabkov <rojer9(a)fb.com>
Gerrit-Comment-Date: Fri, 05 Feb 2021 17:39:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Deomid "rojer" Ryabkov has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/50307 )
Change subject: Port locked MSR fix to Watson and Watson V2
......................................................................
Port locked MSR fix to Watson and Watson V2
Original commit: 817994c1bec48733679c34fe717a07ad81af18ac
Signed-off-by: Deomid "rojer" Ryabkov <rojer9(a)fb.com>
Change-Id: Ica9557ff159321abed55f9402aee626f18fe526b
---
M src/mainboard/facebook/watson/romstage.c
1 file changed, 17 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/50307/1
diff --git a/src/mainboard/facebook/watson/romstage.c b/src/mainboard/facebook/watson/romstage.c
index b8df798..8aa1a78 100644
--- a/src/mainboard/facebook/watson/romstage.c
+++ b/src/mainboard/facebook/watson/romstage.c
@@ -15,6 +15,9 @@
*/
#include <stddef.h>
+#include <cpu/x86/msr.h>
+#include <cf9_reset.h>
+#include <console/console.h>
#include <soc/romstage.h>
#include <drivers/intel/fsp1_0/fsp_util.h>
#include <variants.h>
@@ -25,7 +28,20 @@
*/
void early_mainboard_romstage_entry(void)
{
-
+ /*
+ * Sometimes the system boots in an invalid state, where random values
+ * have been written to MSRs and then the MSRs are locked.
+ * Seems to always happen on warm reset.
+ *
+ * Power cycling or a board_reset() isn't sufficient in this case, so
+ * issue a full_reset() to "fix" this issue.
+ */
+ msr_t msr = rdmsr(IA32_FEATURE_CONTROL);
+ if (msr.lo & 1) {
+ console_init();
+ printk(BIOS_EMERG, "Detected broken platform state. Issuing full reset\n");
+ full_reset();
+ }
}
/**
--
To view, visit https://review.coreboot.org/c/coreboot/+/50307
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: 4.11_branch
Gerrit-Change-Id: Ica9557ff159321abed55f9402aee626f18fe526b
Gerrit-Change-Number: 50307
Gerrit-PatchSet: 1
Gerrit-Owner: Deomid "rojer" Ryabkov <rojer9(a)fb.com>
Gerrit-MessageType: newchange