ritul guru has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/50281 )
Change subject: mainboard/amd/bilby: Add Bilby CRB board
......................................................................
Abandoned
raised other PR https://review.coreboot.org/c/coreboot/+/50315
--
To view, visit https://review.coreboot.org/c/coreboot/+/50281
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifa3228b95b359c4f37a6a844acdeefd51f0cc949
Gerrit-Change-Number: 50281
Gerrit-PatchSet: 1
Gerrit-Owner: ritul guru <ritul.bits(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-MessageType: abandon
Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45266 )
Change subject: sb/intel/bd82x6x: Read ME MBP HWA request
......................................................................
sb/intel/bd82x6x: Read ME MBP HWA request
On AMT-enabled systems, the ME can request some information about the
hardware with a HWA request, which is a specific type of MBP item.
Read the information provided by this item into the MBP data struct.
This silences a spurious error about an unknown MBP item. Handling the
HWA request is not simple, and does not appear to be necessary anyway.
Change-Id: I4bddad6cbfaaad6854266d760f86c9a90705a200
Signed-off-by: Angel Pons <th3fanbus(a)gmail.com>
---
M src/southbridge/intel/bd82x6x/me.h
M src/southbridge/intel/bd82x6x/me_8.x.c
2 files changed, 16 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/45266/1
diff --git a/src/southbridge/intel/bd82x6x/me.h b/src/southbridge/intel/bd82x6x/me.h
index 29089a9..2290c63 100644
--- a/src/southbridge/intel/bd82x6x/me.h
+++ b/src/southbridge/intel/bd82x6x/me.h
@@ -354,6 +354,17 @@
} __packed platform_type_rule_data;
typedef struct {
+ union {
+ u32 data;
+ struct {
+ u32 media_table_push : 1;
+ u32 reserved : 31;
+ } bits;
+ };
+ u8 available;
+} __packed mbp_hwa_request;
+
+typedef struct {
mefwcaps_sku fw_capabilities;
u8 available;
} mbp_fw_caps;
@@ -382,6 +393,7 @@
mbp_icc_profile icc_profile;
tdt_state_info at_state;
u32 mfsintegrity;
+ mbp_hwa_request hwa_request;
} me_bios_payload;
typedef struct {
diff --git a/src/southbridge/intel/bd82x6x/me_8.x.c b/src/southbridge/intel/bd82x6x/me_8.x.c
index 96e9a51..a701315 100644
--- a/src/southbridge/intel/bd82x6x/me_8.x.c
+++ b/src/southbridge/intel/bd82x6x/me_8.x.c
@@ -320,6 +320,10 @@
case MBP_IDENT(KERNEL, MFS_FAILURE):
SET_UP_COPY(mfsintegrity);
+ case MBP_IDENT(HWA, REQUEST):
+ mbp_data->hwa_request.available = 1;
+ SET_UP_COPY(hwa_request.data);
+
default:
printk(BIOS_ERR, "ME: Unknown MBP item! Skipping...\n");
while (copy_size--)
--
To view, visit https://review.coreboot.org/c/coreboot/+/45266
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4bddad6cbfaaad6854266d760f86c9a90705a200
Gerrit-Change-Number: 45266
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-MessageType: newchange
Attention is currently required from: Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50267 )
Change subject: mb/emulation/qemu-q35: Mark TSEG region as reserved
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/50267
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3ae3659349d2a88bc3575fe9675433c054e28832
Gerrit-Change-Number: 50267
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Comment-Date: Fri, 05 Feb 2021 18:50:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Patrick Rudolph.
Hello build bot (Jenkins), Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/50267
to look at the new patch set (#3).
Change subject: mb/emulation/qemu-q35: Mark TSEG region as reserved
......................................................................
mb/emulation/qemu-q35: Mark TSEG region as reserved
Mark TSEG as reserved, which is done on other platforms as well.
For some reason CorebootPayloadPkg crashes when using the region where
TSEG typically resides, which is basically RAM.
UefiPayloadPkg doesn't show this issue.
Change-Id: I3ae3659349d2a88bc3575fe9675433c054e28832
Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com>
---
M src/mainboard/emulation/qemu-q35/mainboard.c
1 file changed, 7 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/50267/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/50267
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3ae3659349d2a88bc3575fe9675433c054e28832
Gerrit-Change-Number: 50267
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-MessageType: newpatchset