Attention is currently required from: Furquan Shaikh, Ravishankar Sarawadi, Duncan Laurie, Alex Levin, Sukumar Ghorai, Raj Astekar, Patrick Rudolph, Shreesh Chhabbi.
Shreesh Chhabbi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49766 )
Change subject: soc/intel/tgl: Disable S0i3.2 & S0i3.3 substates
......................................................................
Patch Set 22:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/49766/comment/da1e7d23_292f6914
PS3, Line 11: Tigerlake
> I thought that this has coloration to cvni, not just TGL
Hi Alex, since this patch was for TGL, I mentioned TGL. Please let me know if I need to change it.
File src/soc/intel/tigerlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/49766/comment/4eb7e64c_79ac8692
PS19, Line 62: if ((cpu_id == CPUID_TIGERLAKE_A0) || (cpu_id == CPUID_TIGERLAKE_B0))
> You can return early here so that the block doesn't need to be shifted by another tab below. […]
Thanks. Changed the code accordingly.
--
To view, visit https://review.coreboot.org/c/coreboot/+/49766
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5f2ac8b72d0c9b05bc02c092188d0c742cc83af9
Gerrit-Change-Number: 49766
Gerrit-PatchSet: 22
Gerrit-Owner: Shreesh Chhabbi <shreesh.chhabbi(a)intel.com>
Gerrit-Reviewer: Alex Levin <levinale(a)google.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie(a)gmail.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com>
Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-Reviewer: Shreesh Chhabbi <shreesh.chhabbi(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Sukumar Ghorai <sukumar.ghorai(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-Attention: Duncan Laurie <dlaurie(a)chromium.org>
Gerrit-Attention: Alex Levin <levinale(a)google.com>
Gerrit-Attention: Duncan Laurie <dlaurie(a)gmail.com>
Gerrit-Attention: Sukumar Ghorai <sukumar.ghorai(a)intel.com>
Gerrit-Attention: Raj Astekar <raj.astekar(a)intel.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: Shreesh Chhabbi <shreesh.chhabbi(a)intel.corp-partner.google.com>
Gerrit-Comment-Date: Fri, 05 Feb 2021 20:03:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com>
Comment-In-Reply-To: Alex Levin <levinale(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Frans Hendriks, Kyösti Mälkki, Alexander Couzens, Aaron Durbin, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50040 )
Change subject: {src}: Assign values before if statement
......................................................................
Patch Set 3: Code-Review-1
--
To view, visit https://review.coreboot.org/c/coreboot/+/50040
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idd346d31f1da71271ad1545e5645e57530c7b374
Gerrit-Change-Number: 50040
Gerrit-PatchSet: 3
Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Attention: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Attention: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Fri, 05 Feb 2021 19:53:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Felix Held.
Chris Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50288 )
Change subject: [UNTESTED] soc/amd/picasso/iomap: change ACPI_CPU_CONTROL to match AGESA
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
validate on my FT5 machine, the CC6 works well.
--
To view, visit https://review.coreboot.org/c/coreboot/+/50288
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I80e11d9792ee4138cb376ebbe0438dc304b54527
Gerrit-Change-Number: 50288
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Chris Wang <chris.wang(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Fri, 05 Feb 2021 19:49:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Patrick Rudolph.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50324 )
Change subject: soc/intel/xeon_sp/include/soc/acpi_asl.h: Convert to ASL 2.0
......................................................................
Patch Set 1:
(4 comments)
File src/soc/intel/xeon_sp/include/soc/acpi_asl.h:
https://review.coreboot.org/c/coreboot/+/50324/comment/8484058c_c42c97ab
PS1, Line 50: IRQ0 = 1 << (^^PIR##id & ^^IREM) \
need consistent spacing around '^' (ctx:WxO)
https://review.coreboot.org/c/coreboot/+/50324/comment/146f1da9_86fc139f
PS1, Line 62: If (^^PIR##id & ^^IREN) { \
space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/50324/comment/2fd50566_7c963bb7
PS1, Line 62: If (^^PIR##id & ^^IREN) { \
need consistent spacing around '^' (ctx:WxO)
https://review.coreboot.org/c/coreboot/+/50324/comment/a8e1c256_ffa71dd9
PS1, Line 70: ^^PIR##id |= ^^IREN \
need consistent spacing around '^' (ctx:WxO)
--
To view, visit https://review.coreboot.org/c/coreboot/+/50324
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie1d31b9d02584b97b85afe970894cfe557174733
Gerrit-Change-Number: 50324
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Fri, 05 Feb 2021 19:47:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment