Attention is currently required from: Martin Roth, jacz(a)semihalf.com, Jan Dabros.
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50305 )
Change subject: tests: Add lib/stack-test test case
......................................................................
Patch Set 1:
(4 comments)
File tests/lib/stack-test.c:
https://review.coreboot.org/c/coreboot/+/50305/comment/e9963e22_02e41bb7
PS1, Line 49: succes
success
https://review.coreboot.org/c/coreboot/+/50305/comment/18a80707_6cf9bb63
PS1, Line 62: almost
almost-full
https://review.coreboot.org/c/coreboot/+/50305/comment/c99483d4_ca6217af
PS1, Line 87: almost
partially-filled
https://review.coreboot.org/c/coreboot/+/50305/comment/5765fd73_d86a886f
PS1, Line 102: stack[i] = 0x42420707;
just include this in the loop above as `stack[i+1] = 0x42420707;`?
--
To view, visit https://review.coreboot.org/c/coreboot/+/50305
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icf0cceac290618a50ecc4e65f1f9551dbf31bd32
Gerrit-Change-Number: 50305
Gerrit-PatchSet: 1
Gerrit-Owner: jacz(a)semihalf.com
Gerrit-Reviewer: Jan Dabros <jsd(a)semihalf.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: jacz(a)semihalf.com
Gerrit-Attention: Jan Dabros <jsd(a)semihalf.com>
Gerrit-Comment-Date: Fri, 05 Feb 2021 20:56:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Patrick Rudolph, HAOUAS Elyes.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50329 )
Change subject: sb/intel/lynxpoint/acpi/gpio.asl: Convert to ASL 2.0
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
File src/southbridge/intel/lynxpoint/acpi/gpio.asl:
https://review.coreboot.org/c/coreboot/+/50329/comment/0032089a_95ad2199
PS1, Line 80: 48
Since this is a register offset, it makes more sense to keep it in hex.
https://review.coreboot.org/c/coreboot/+/50329/comment/4ad5bd2f_879cdf70
PS1, Line 96: 256
Same here
--
To view, visit https://review.coreboot.org/c/coreboot/+/50329
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I37d6cf75ee5a5cb2ff92c89178cd4469dc059403
Gerrit-Change-Number: 50329
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Fri, 05 Feb 2021 20:55:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth, Felix Held.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50285 )
Change subject: mb/google/zork: Use Kconfig SPI speed & read mode in devicetree
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/50285
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I116adf4fe0de5a2790894618ccff8ebf629fab34
Gerrit-Change-Number: 50285
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Fri, 05 Feb 2021 20:54:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: HAOUAS Elyes.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50304 )
Change subject: arch/x86/cpu.c: Remove redundant <arch/cpu.h>
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/50304/comment/ae0d339e_b90a775f
PS1, Line 8:
Is it because we chain-include it from a different header? If so, please mention which one.
--
To view, visit https://review.coreboot.org/c/coreboot/+/50304
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iad7f23080814c6606603d9472a1bd34a6b1bd1a9
Gerrit-Change-Number: 50304
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Fri, 05 Feb 2021 20:48:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment