Attention is currently required from: Nico Huber, Arthur Heymans, Patrick Rudolph.
Hello build bot (Jenkins), Nico Huber, Patrick Georgi, Arthur Heymans, Patrick Rudolph, HAOUAS Elyes,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/49748
to look at the new patch set (#4).
Change subject: nb/intel/gm45: Factor out {DMI,EP,MCH}BAR accessors
......................................................................
nb/intel/gm45: Factor out {DMI,EP,MCH}BAR accessors
These accessors can be reused for several other northbridges.
Tested with BUILD_TIMELESS=1, Roda RK9 remains identical.
Change-Id: Ia16ccc63dddebf938f4e9a7f5518e4d25d3e7e66
Signed-off-by: Angel Pons <th3fanbus(a)gmail.com>
---
M src/Kconfig
A src/northbridge/intel/common/Kconfig.common
A src/northbridge/intel/common/fixed_bars.h
M src/northbridge/intel/gm45/Kconfig
M src/northbridge/intel/gm45/acpi/gm45.asl
M src/northbridge/intel/gm45/early_init.c
M src/northbridge/intel/gm45/gm45.h
M src/northbridge/intel/gm45/memmap.h
M src/northbridge/intel/gm45/pcie.c
M src/southbridge/intel/i82801ix/dmi_setup.c
10 files changed, 61 insertions(+), 26 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/49748/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/49748
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia16ccc63dddebf938f4e9a7f5518e4d25d3e7e66
Gerrit-Change-Number: 49748
Gerrit-PatchSet: 4
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Jason Glenesk, Martin Roth, Marshall Dawson, Felix Held.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50334 )
Change subject: soc/amd/cezanne/pcie_gpp: scan internal PCI buses
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/50334
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If7ff0f2ecde9189691548e071ddcfe1916933571
Gerrit-Change-Number: 50334
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Fri, 05 Feb 2021 22:36:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Jonathan Zhang, Philipp Deppenwiese, Patrick Rudolph, Deomid "rojer" Ryabkov.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50307 )
Change subject: Apply locked MSR check to all BDW-DE platforms
......................................................................
Patch Set 7: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/50307
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: 4.11_branch
Gerrit-Change-Id: Ica9557ff159321abed55f9402aee626f18fe526b
Gerrit-Change-Number: 50307
Gerrit-PatchSet: 7
Gerrit-Owner: Deomid "rojer" Ryabkov <rojer9(a)fb.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Philipp Deppenwiese <philipp.deppenwiese(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Attention: Philipp Deppenwiese <philipp.deppenwiese(a)9elements.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: Deomid "rojer" Ryabkov <rojer9(a)fb.com>
Gerrit-Comment-Date: Fri, 05 Feb 2021 22:25:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Jonathan Zhang, Philipp Deppenwiese, Angel Pons, Patrick Rudolph.
Deomid "rojer" Ryabkov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50307 )
Change subject: Apply locked MSR check to all BDW-DE platforms
......................................................................
Patch Set 7:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/50307/comment/f388ba13_6b66408c
PS1, Line 9: Original commit: 817994c1bec48733679c34fe717a07ad81af18ac
> Somewhere near the place where `early_mainboard_romstage_entry` gets called: […]
Done
Commit Message:
https://review.coreboot.org/c/coreboot/+/50307/comment/29a730f7_1c8c088c
PS6, Line 10: not
> no*w*
Done
https://review.coreboot.org/c/coreboot/+/50307/comment/a6f1609c_02c9c314
PS6, Line 12: [CB:30290]
> commit 817994c1be
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/50307
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: 4.11_branch
Gerrit-Change-Id: Ica9557ff159321abed55f9402aee626f18fe526b
Gerrit-Change-Number: 50307
Gerrit-PatchSet: 7
Gerrit-Owner: Deomid "rojer" Ryabkov <rojer9(a)fb.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Philipp Deppenwiese <philipp.deppenwiese(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Attention: Philipp Deppenwiese <philipp.deppenwiese(a)9elements.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Fri, 05 Feb 2021 22:08:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jonathan Zhang <jonzhang(a)fb.com>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Comment-In-Reply-To: Deomid "rojer" Ryabkov <rojer9(a)fb.com>
Gerrit-MessageType: comment
Attention is currently required from: Jonathan Zhang, Philipp Deppenwiese, Patrick Rudolph, Deomid "rojer" Ryabkov.
Hello build bot (Jenkins), Jonathan Zhang, Philipp Deppenwiese, Angel Pons, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/50307
to look at the new patch set (#7).
Change subject: Apply locked MSR check to all BDW-DE platforms
......................................................................
Apply locked MSR check to all BDW-DE platforms
It was initially applied to Wedge100 and MonoLake in CB:30290
and the issue has now been observed on Watson as well.
Original change: [CB:30290][commit 817994c1be]
Signed-off-by: Deomid "rojer" Ryabkov <rojer9(a)fb.com>
Change-Id: Ica9557ff159321abed55f9402aee626f18fe526b
---
M src/mainboard/ocp/monolake/romstage.c
M src/mainboard/ocp/wedge100s/romstage.c
M src/soc/intel/fsp_broadwell_de/romstage/romstage.c
3 files changed, 22 insertions(+), 39 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/50307/7
--
To view, visit https://review.coreboot.org/c/coreboot/+/50307
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: 4.11_branch
Gerrit-Change-Id: Ica9557ff159321abed55f9402aee626f18fe526b
Gerrit-Change-Number: 50307
Gerrit-PatchSet: 7
Gerrit-Owner: Deomid "rojer" Ryabkov <rojer9(a)fb.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Philipp Deppenwiese <philipp.deppenwiese(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Attention: Philipp Deppenwiese <philipp.deppenwiese(a)9elements.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: Deomid "rojer" Ryabkov <rojer9(a)fb.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50288 )
Change subject: soc/amd/picasso/iomap: change ACPI_CPU_CONTROL to match AGESA
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
oh, that wasn't the submit button. remove the accidental +2 again
--
To view, visit https://review.coreboot.org/c/coreboot/+/50288
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I80e11d9792ee4138cb376ebbe0438dc304b54527
Gerrit-Change-Number: 50288
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Chris Wang <chris.wang(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Comment-Date: Fri, 05 Feb 2021 22:05:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson.
Felix Held has removed a vote from this change. ( https://review.coreboot.org/c/coreboot/+/50288 )
Change subject: soc/amd/picasso/iomap: change ACPI_CPU_CONTROL to match AGESA
......................................................................
Removed Code-Review+2 by Felix Held <felix-coreboot(a)felixheld.de>
--
To view, visit https://review.coreboot.org/c/coreboot/+/50288
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I80e11d9792ee4138cb376ebbe0438dc304b54527
Gerrit-Change-Number: 50288
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Chris Wang <chris.wang(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-MessageType: deleteVote