coreboot-gerrit February 2021

coreboot-gerrit@coreboot.org

1 participants
7192 discussions

Change in coreboot[master]: src: Remove unused <cbmem.h>
by Angel Pons (Code Review) 07 Feb '21

07 Feb '21

Attention is currently required from: HAOUAS Elyes. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50182 ) Change subject: src: Remove unused <cbmem.h> ...................................................................... Patch Set 3: (2 comments) File src/soc/intel/baytrail/refcode.c: https://review.coreboot.org/c/coreboot/+/50182/comment/be04fb5e_ed7b3ce7 PS3, Line 30: CBMEM_ID_REFCODE um File src/soc/intel/broadwell/refcode.c: https://review.coreboot.org/c/coreboot/+/50182/comment/a0a270cb_b67deba2 PS3, Line 26: CBMEM_ID_REFCODE um -- To view, visit https://review.coreboot.org/c/coreboot/+/50182 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2279e2d7e6255a88953b2485c1f1a3b51a72c65e Gerrit-Change-Number: 50182 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sun, 07 Feb 2021 22:40:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: nb/intel/x4x: Constify write leveling arrays
by Patrick Georgi (Code Review) 07 Feb '21

07 Feb '21

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/49403 ) Change subject: nb/intel/x4x: Constify write leveling arrays ...................................................................... nb/intel/x4x: Constify write leveling arrays Change-Id: I3be3952aaba1fe2da5490b071b4e3609773e84a5 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/49403 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/northbridge/intel/x4x/dq_dqs.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved diff --git a/src/northbridge/intel/x4x/dq_dqs.c b/src/northbridge/intel/x4x/dq_dqs.c index 0a65165..867c862 100644 --- a/src/northbridge/intel/x4x/dq_dqs.c +++ b/src/northbridge/intel/x4x/dq_dqs.c @@ -766,9 +766,9 @@ u8 config, rank0, rank1, lane; struct dll_setting dq_setting; - u8 chanconfig_lut[16]={0, 6, 4, 6, 7, 3, 1, 3, 5, 2, 0, 2, 7, 3, 1, 3}; + const u8 chanconfig_lut[16] = {0, 6, 4, 6, 7, 3, 1, 3, 5, 2, 0, 2, 7, 3, 1, 3}; - u8 odt_force[8][4] = { /* [Config][leveling rank] */ + const u8 odt_force[8][4] = { /* [Config][leveling rank] */ {0x5, 0x6, 0x5, 0x9}, {0x5, 0x6, 0x5, 0x0}, {0x5, 0x0, 0x5, 0x9}, -- To view, visit https://review.coreboot.org/c/coreboot/+/49403 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3be3952aaba1fe2da5490b071b4e3609773e84a5 Gerrit-Change-Number: 49403 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Damien Zammit Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: nb/intel/x4x: Update write leveling comment
by Patrick Georgi (Code Review) 07 Feb '21

07 Feb '21

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/49402 ) Change subject: nb/intel/x4x: Update write leveling comment ...................................................................... nb/intel/x4x: Update write leveling comment Fix a typo and do some style improvements. Change-Id: Ibc7e1869faa6b9ae12a51b1c3d209bbd8e54b0d2 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/49402 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> --- M src/northbridge/intel/x4x/dq_dqs.c 1 file changed, 9 insertions(+), 9 deletions(-) Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved diff --git a/src/northbridge/intel/x4x/dq_dqs.c b/src/northbridge/intel/x4x/dq_dqs.c index 4722dfe..0a65165 100644 --- a/src/northbridge/intel/x4x/dq_dqs.c +++ b/src/northbridge/intel/x4x/dq_dqs.c @@ -746,19 +746,19 @@ * DDR3 uses flyby topology where the clock signal takes a different path * than the data signal, to allow for better signal intergrity. * Therefore the delay on the data signals needs to account for this. - * This is done by sampleling the DQS write (tx) signal back over - * the DQ signal and looking for delay values where the sample transitions + * This is done by sampling the DQS write (tx) signal back over the DQ + * signal and looking for delay values where the sample transitions * from high to low. * Here the following is done: - * - enable write levelling on the first populated rank - * - disable output on other populated ranks - * - start from safe DQS (tx) delays (other transitions can be - * found at different starting values but are generally bad) + * - Enable write levelling on the first populated rank. + * - Disable output on other populated ranks. + * - Start from safe DQS (tx) delays. Other transitions can be + * found at different starting values but are generally bad. * - loop0: decrease DQS (tx) delays until low is sampled, * loop1: increase DQS (tx) delays until high is sampled, - * That way we are sure to hit a low-high transition - * - put all ranks in normal mode of operation again - * - note: All ranks need to be leveled together + * This way, we are sure to have hit a low-high transition. + * - Put all ranks in normal mode of operation again. + * Note: All ranks need to be leveled together. */ void search_write_leveling(struct sysinfo *s) { -- To view, visit https://review.coreboot.org/c/coreboot/+/49402 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibc7e1869faa6b9ae12a51b1c3d209bbd8e54b0d2 Gerrit-Change-Number: 49402 Gerrit-PatchSet: 4 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Damien Zammit Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: nb/intel/x4x: Update write leveling comment
by Patrick Georgi (Code Review) 07 Feb '21

07 Feb '21

Attention is currently required from: Jacob Garber. Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49402 ) Change subject: nb/intel/x4x: Update write leveling comment ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/49402 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibc7e1869faa6b9ae12a51b1c3d209bbd8e54b0d2 Gerrit-Change-Number: 49402 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Damien Zammit Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-Comment-Date: Sun, 07 Feb 2021 22:36:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: superio/aspeed: setup early serial for AST2600
by Jonathan Zhang (Code Review) 07 Feb '21

07 Feb '21

Attention is currently required from: Marc Jones, Anjaneya "Reddy" Chagam, Patrick Rudolph, Daocheng Bu, Johnny Lin, Christian Walter. Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50374 ) Change subject: superio/aspeed: setup early serial for AST2600 ...................................................................... Patch Set 1: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/50374 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib21b054bea2e64e00521807e8aa13e536f643974 Gerrit-Change-Number: 50374 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Daocheng Bu <daocheng.bu(a)intel.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Attention: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Daocheng Bu <daocheng.bu(a)intel.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Comment-Date: Sun, 07 Feb 2021 22:26:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: nb/intel/x4x: Update write leveling comment
by Angel Pons (Code Review) 07 Feb '21

07 Feb '21

Attention is currently required from: Jacob Garber. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49402 ) Change subject: nb/intel/x4x: Update write leveling comment ...................................................................... Patch Set 3: (1 comment) File src/northbridge/intel/x4x/dq_dqs.c: https://review.coreboot.org/c/coreboot/+/49402/comment/dd0ae83d_c9220381 PS2, Line 749: * This is done by by sampling the the DQS write (tx) signal back over > Nit: `by` and `the` are doubled Thanks, done. -- To view, visit https://review.coreboot.org/c/coreboot/+/49402 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibc7e1869faa6b9ae12a51b1c3d209bbd8e54b0d2 Gerrit-Change-Number: 49402 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Damien Zammit Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-Comment-Date: Sun, 07 Feb 2021 22:23:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: nb/intel/x4x: Update write leveling comment
by Jacob Garber (Code Review) 07 Feb '21

07 Feb '21

Attention is currently required from: Angel Pons. Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49402 ) Change subject: nb/intel/x4x: Update write leveling comment ...................................................................... Patch Set 2: (1 comment) File src/northbridge/intel/x4x/dq_dqs.c: https://review.coreboot.org/c/coreboot/+/49402/comment/397af0d2_0390d0c6 PS2, Line 749: * This is done by by sampling the the DQS write (tx) signal back over Nit: `by` and `the` are doubled -- To view, visit https://review.coreboot.org/c/coreboot/+/49402 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibc7e1869faa6b9ae12a51b1c3d209bbd8e54b0d2 Gerrit-Change-Number: 49402 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Damien Zammit Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sun, 07 Feb 2021 22:20:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: nb/intel/x4x: Update write leveling comment
by Angel Pons (Code Review) 07 Feb '21

07 Feb '21

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49402 ) Change subject: nb/intel/x4x: Update write leveling comment ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > needs rebase done, thanks! -- To view, visit https://review.coreboot.org/c/coreboot/+/49402 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibc7e1869faa6b9ae12a51b1c3d209bbd8e54b0d2 Gerrit-Change-Number: 49402 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Damien Zammit Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Sun, 07 Feb 2021 22:08:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Georgi <pgeorgi(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: nb/intel/x4x: Update write leveling comment
by Angel Pons (Code Review) 07 Feb '21

07 Feb '21

Attention is currently required from: Angel Pons. Hello build bot (Jenkins), Damien Zammit, Arthur Heymans, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/49402 to look at the new patch set (#2). Change subject: nb/intel/x4x: Update write leveling comment ...................................................................... nb/intel/x4x: Update write leveling comment Fix a typo and do some style improvements. Change-Id: Ibc7e1869faa6b9ae12a51b1c3d209bbd8e54b0d2 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/northbridge/intel/x4x/dq_dqs.c 1 file changed, 8 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/49402/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/49402 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibc7e1869faa6b9ae12a51b1c3d209bbd8e54b0d2 Gerrit-Change-Number: 49402 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Damien Zammit Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/amd/common/memmap: add comment about types in memmap_early_dram
by Felix Held (Code Review) 07 Feb '21

07 Feb '21

Attention is currently required from: Jason Glenesk, Raul Rangel, Furquan Shaikh, Marshall Dawson, Kyösti Mälkki. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50370 ) Change subject: soc/amd/common/memmap: add comment about types in memmap_early_dram ...................................................................... Patch Set 3: (1 comment) File src/soc/amd/common/block/include/amdblocks/memmap.h: https://review.coreboot.org/c/coreboot/+/50370/comment/71c2b006_cc2ad628 PS2, Line 12: /* fixed size types, so the layout in CBFS won't change for 32 vs. 64 bit stages */ > CBMEM […] oh, you're right. yeah, it's a half-sentence so it's clear what it's about, but still fits into the 96 chars -- To view, visit https://review.coreboot.org/c/coreboot/+/50370 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I295bfcb05571492adbe81ffc579a835be4abffe1 Gerrit-Change-Number: 50370 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Sun, 07 Feb 2021 22:04:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2021