coreboot-gerrit February 2021

coreboot-gerrit@coreboot.org

1 participants
7192 discussions

Change in coreboot[master]: mb/prodrive/hermes: Configure 'internal audio'
by build bot (Jenkins) (Code Review) 08 Feb '21

08 Feb '21

Attention is currently required from: Christian Walter. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50383 ) Change subject: mb/prodrive/hermes: Configure 'internal audio' ...................................................................... Patch Set 1: (1 comment) File src/mainboard/prodrive/hermes/hda_verb.c: https://review.coreboot.org/c/coreboot/+/50383/comment/5118efa7_416096bb PS1, Line 224: } adding a line without newline at end of file -- To view, visit https://review.coreboot.org/c/coreboot/+/50383 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2bab0f2d36826c193b1af2b9ca2598a7bf00ac46 Gerrit-Change-Number: 50383 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Comment-Date: Mon, 08 Feb 2021 09:11:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/prodrive/hermes: Configure 'internal audio'
by Patrick Rudolph (Code Review) 08 Feb '21

08 Feb '21

Attention is currently required from: Christian Walter. Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/50383 ) Change subject: mb/prodrive/hermes: Configure 'internal audio' ...................................................................... mb/prodrive/hermes: Configure 'internal audio' Implement azalia_extra_verb_table and let the azalia driver configure the codec according to the EEPROM configuration internal_audio_connection: * 0 disabled * 1 Front HP out * 2 Internal speaker Change-Id: I2bab0f2d36826c193b1af2b9ca2598a7bf00ac46 Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> --- M src/mainboard/prodrive/hermes/hda_verb.c 1 file changed, 54 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/50383/1 diff --git a/src/mainboard/prodrive/hermes/hda_verb.c b/src/mainboard/prodrive/hermes/hda_verb.c index 59b8aa6..a97286c 100644 --- a/src/mainboard/prodrive/hermes/hda_verb.c +++ b/src/mainboard/prodrive/hermes/hda_verb.c @@ -1,6 +1,9 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <device/azalia_device.h> +#include <string.h> +#include <stdlib.h> +#include "variants/baseboard/include/eeprom.h" const u32 cim_verb_data[] = { 0x10ec0888, /* Codec Vendor / Device ID: Realtek ALC888 */ @@ -168,3 +171,54 @@ const u32 pc_beep_verbs[0] = {}; AZALIA_ARRAY_SIZES; + +u32 *azalia_extra_verb_table(u32 viddid, u32 *verb_table_size) +{ + const struct eeprom_board_settings *const board_cfg = get_board_settings(); + u32 *verbs; + + if (!board_cfg) + return NULL; + + if (viddid != 0x10ec0888) + return NULL; + + verbs = malloc(sizeof(u32) * 4); + if (!verbs) + return NULL; + + *verb_table_size = 0; + + if (board_cfg->internal_audio_connection == 0) { + static u32 verb_data[] = { + AZALIA_PIN_CFG(0, 0x1b, 0x411111f0), + }; + memcpy(&verbs[*verb_table_size], verb_data, sizeof(verb_data)); + *verb_table_size += sizeof(verb_data) / sizeof(u32); + + } else if (board_cfg->internal_audio_connection == 1) { + static u32 verb_data[] = { + AZALIA_PIN_CFG(0, 0x1b, 0x02214c40), + }; + memcpy(&verbs[*verb_table_size], verb_data, sizeof(verb_data)); + *verb_table_size += sizeof(verb_data) / sizeof(u32); + } else { + static u32 verb_data[] = { + AZALIA_PIN_CFG(0, 0x1b, AZALIA_PIN_DESC( + INTEGRATED, + INTERNAL, + NA, + SPEAKER, + TYPE_UNKNOWN, + COLOR_UNKNOWN, + false, + 0xf, + 0)), + }; + memcpy(&verbs[*verb_table_size], verb_data, sizeof(verb_data)); + *verb_table_size += sizeof(verb_data) / sizeof(u32); + } + + /* Leak verbs */ + return verbs; +} \ No newline at end of file -- To view, visit https://review.coreboot.org/c/coreboot/+/50383 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2bab0f2d36826c193b1af2b9ca2598a7bf00ac46 Gerrit-Change-Number: 50383 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: device/azalia: Add weak function for extra verbs
by Patrick Rudolph (Code Review) 08 Feb '21

08 Feb '21

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/50382 ) Change subject: device/azalia: Add weak function for extra verbs ...................................................................... device/azalia: Add weak function for extra verbs Introduce a weak function to be overwritten by mainboard to provide additional verbs for runtime based configuration. The mainboard must implement azalia_extra_verb_table, check the viddid and return a pointer to the buffer holding the additonal verbs. To be used for runtime detection of present jacks on prodrive/hermes. Change-Id: I983c62d26be68885bb2f5b3a85f989b9d6b77706 Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> --- M src/device/azalia_device.c M src/include/device/azalia_device.h 2 files changed, 28 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/50382/1 diff --git a/src/device/azalia_device.c b/src/device/azalia_device.c index e383821..999ac0e 100644 --- a/src/device/azalia_device.c +++ b/src/device/azalia_device.c @@ -188,10 +188,17 @@ return -1; } +__weak u32 *azalia_extra_verb_table(u32 viddid, u32 *verb_table_size) +{ + *verb_table_size = 0; + return NULL; +} + static void codec_init(struct device *dev, u8 *base, int addr) { u32 reg32; const u32 *verb; + u32 *extra_verbs; u32 verb_size; int i; @@ -233,6 +240,22 @@ return; } printk(BIOS_DEBUG, "azalia_audio: verb loaded.\n"); + + verb_size = 0; + extra_verbs = azalia_extra_verb_table(reg32, &verb_size); + if (extra_verbs != NULL && verb_size != 0) { + printk(BIOS_DEBUG, "azalia_audio: extra_verb_size: %d\n", verb_size); + for (i = 0; i < verb_size; i++) { + if (wait_for_ready(base) < 0) + return; + + write32(base + HDA_IC_REG, extra_verbs[i]); + + if (wait_for_valid(base) < 0) + return; + } + printk(BIOS_DEBUG, "azalia_audio: extra verb loaded.\n"); + } } static void codecs_init(struct device *dev, u8 *base, u32 codec_mask) diff --git a/src/include/device/azalia_device.h b/src/include/device/azalia_device.h index 1b4e769..095f7c2 100644 --- a/src/include/device/azalia_device.h +++ b/src/include/device/azalia_device.h @@ -25,6 +25,11 @@ void azalia_audio_init(struct device *dev); extern struct device_operations default_azalia_audio_ops; +/* + * Allows a mainboard to specify additional verb configured at runtime. + */ +u32 *azalia_extra_verb_table(u32 viddid, u32 *verb_table_size); + extern const u32 cim_verb_data[]; extern const u32 cim_verb_data_size; extern const u32 pc_beep_verbs[]; -- To view, visit https://review.coreboot.org/c/coreboot/+/50382 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I983c62d26be68885bb2f5b3a85f989b9d6b77706 Gerrit-Change-Number: 50382 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/prodrive/hermes: Set mb_hda_amp_enable based on cfg
by Patrick Rudolph (Code Review) 08 Feb '21

08 Feb '21

Attention is currently required from: Christian Walter. Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/50381 ) Change subject: mb/prodrive/hermes: Set mb_hda_amp_enable based on cfg ...................................................................... mb/prodrive/hermes: Set mb_hda_amp_enable based on cfg Change-Id: I13c2ece729128fe245de88c0d36ce7b4bcaf6b6d Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> --- M src/mainboard/prodrive/hermes/mainboard.c 1 file changed, 7 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/50381/1 diff --git a/src/mainboard/prodrive/hermes/mainboard.c b/src/mainboard/prodrive/hermes/mainboard.c index 822ed58..d9abb76 100644 --- a/src/mainboard/prodrive/hermes/mainboard.c +++ b/src/mainboard/prodrive/hermes/mainboard.c @@ -62,9 +62,16 @@ if (!board_cfg) return; + /* Set Deep Sx */ config_t *config = config_of_soc(); config->deep_s5_enable_ac = board_cfg->deep_sx_enabled; config->deep_s5_enable_dc = board_cfg->deep_sx_enabled; + + /* Enable internal speaker amplifier */ + if (board_cfg->internal_audio_connection == 2) + mb_hda_amp_enable(1); + else + mb_hda_amp_enable(0); } static void mainboard_final(struct device *dev) @@ -122,7 +129,6 @@ mb_configure_dp2_pwr(1); mb_configure_dp3_pwr(1); - mb_hda_amp_enable(1); mb_usb31_rp1_pwr_enable(1); mb_usb31_rp2_pwr_enable(1); mb_usb31_fp_pwr_enable(1); -- To view, visit https://review.coreboot.org/c/coreboot/+/50381 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I13c2ece729128fe245de88c0d36ce7b4bcaf6b6d Gerrit-Change-Number: 50381 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/prodrive/hermes: Drop reset functions
by Patrick Rudolph (Code Review) 08 Feb '21

08 Feb '21

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/50380 ) Change subject: mb/prodrive/hermes: Drop reset functions ...................................................................... mb/prodrive/hermes: Drop reset functions The reset GPIOs are already configured in bootblock. Drop the unused ramstage code. Change-Id: Ic99fcae2a3f00be7eebd7be618df838522dac69f Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> --- M src/mainboard/prodrive/hermes/mainboard.c 1 file changed, 1 insertion(+), 20 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/50380/1 diff --git a/src/mainboard/prodrive/hermes/mainboard.c b/src/mainboard/prodrive/hermes/mainboard.c index f2bbbba..822ed58 100644 --- a/src/mainboard/prodrive/hermes/mainboard.c +++ b/src/mainboard/prodrive/hermes/mainboard.c @@ -25,21 +25,6 @@ gpio_output(GPP_K5, enable); } -static void mb_pcie_reset_pch_slots(bool enable) -{ - gpio_output(GPP_K0, enable); -} - -static void mb_pcie_reset_cpu_slots(bool enable) -{ - gpio_output(GPP_K1, enable); -} - -static void mb_pcie_reset_cnvi_slot(bool enable) -{ - gpio_output(GPP_K2, enable); -} - static void mb_hda_amp_enable(bool enable) { gpio_output(GPP_C19, enable); @@ -136,11 +121,7 @@ mb_configure_dp1_pwr(1); mb_configure_dp2_pwr(1); mb_configure_dp3_pwr(1); - if (0) { - mb_pcie_reset_pch_slots(1); - mb_pcie_reset_cpu_slots(0); - mb_pcie_reset_cnvi_slot(0); - } + mb_hda_amp_enable(1); mb_usb31_rp1_pwr_enable(1); mb_usb31_rp2_pwr_enable(1); -- To view, visit https://review.coreboot.org/c/coreboot/+/50380 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic99fcae2a3f00be7eebd7be618df838522dac69f Gerrit-Change-Number: 50380 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: src: Add missing <cbmem.h>
by HAOUAS Elyes (Code Review) 08 Feb '21

08 Feb '21

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Aaron Durbin, Felix Held. HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50379 ) Change subject: src: Add missing <cbmem.h> ...................................................................... Patch Set 1: (3 comments) File src/include/imd_private.h: https://review.coreboot.org/c/coreboot/+/50379/comment/1000f27a_4bf664c9 PS1, Line 34: CBMEM_ID_IMD_SMALL needs <commonlib/cbmem_id.h> through <cbmem.h> File src/security/vboot/vboot_loader.c: https://review.coreboot.org/c/coreboot/+/50379/comment/af1868e7_89360f3f PS1, Line 95: CBMEM_ID_CBFS_RW_MCACHE needs <commonlib/cbmem_id.h> through <cbmem.h> File src/soc/amd/common/block/pi/refcode_loader.c: https://review.coreboot.org/c/coreboot/+/50379/comment/a648b4bc_4b45001b PS1, Line 47: CBMEM_ID_REFCODE needs <commonlib/cbmem_id.h> through <cbmem.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/50379 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I75a816c594b326df8a4aa5458bb055fca35e1741 Gerrit-Change-Number: 50379 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 08 Feb 2021 09:07:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: src: Add missing <cbmem.h>
by HAOUAS Elyes (Code Review) 08 Feb '21

08 Feb '21

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/50379 ) Change subject: src: Add missing <cbmem.h> ...................................................................... src: Add missing <cbmem.h> Change-Id: I75a816c594b326df8a4aa5458bb055fca35e1741 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/include/imd_private.h M src/security/vboot/vboot_loader.c M src/soc/amd/common/block/pi/refcode_loader.c 3 files changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/50379/1 diff --git a/src/include/imd_private.h b/src/include/imd_private.h index 43c3b7d..fea7315 100644 --- a/src/include/imd_private.h +++ b/src/include/imd_private.h @@ -1,6 +1,7 @@ #ifndef _IMD_PRIVATE_H_ #define _IMD_PRIVATE_H_ +#include <cbmem.h> #include <commonlib/bsd/helpers.h> /* In-memory data structures. */ diff --git a/src/security/vboot/vboot_loader.c b/src/security/vboot/vboot_loader.c index 234ae8f..56a0664 100644 --- a/src/security/vboot/vboot_loader.c +++ b/src/security/vboot/vboot_loader.c @@ -2,6 +2,7 @@ #include <boot_device.h> #include <cbfs.h> +#include <cbmem.h> #include <commonlib/bsd/cbfs_private.h> #include <console/console.h> #include <ec/google/chromeec/ec.h> diff --git a/src/soc/amd/common/block/pi/refcode_loader.c b/src/soc/amd/common/block/pi/refcode_loader.c index 9fc73d4..274291d 100644 --- a/src/soc/amd/common/block/pi/refcode_loader.c +++ b/src/soc/amd/common/block/pi/refcode_loader.c @@ -2,6 +2,7 @@ #include <acpi/acpi.h> #include <cbfs.h> +#include <cbmem.h> #include <console/console.h> #include <rmodule.h> #include <stage_cache.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/50379 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I75a816c594b326df8a4aa5458bb055fca35e1741 Gerrit-Change-Number: 50379 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: tests: Add lib/stack-test test case
by Name of user not set (Code Review) 08 Feb '21

08 Feb '21

Attention is currently required from: Martin Roth, Paul Fagerburg, Jan Dabros. jacz(a)semihalf.com has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50305 ) Change subject: tests: Add lib/stack-test test case ...................................................................... Patch Set 2: (4 comments) File tests/lib/stack-test.c: https://review.coreboot.org/c/coreboot/+/50305/comment/eae6af60_d5c731d2 PS1, Line 49: succes > success Done https://review.coreboot.org/c/coreboot/+/50305/comment/ba6fac3b_ddbd1cc0 PS1, Line 62: almost > almost-full Done https://review.coreboot.org/c/coreboot/+/50305/comment/2af6efd0_1406ab85 PS1, Line 87: almost > partially-filled Done https://review.coreboot.org/c/coreboot/+/50305/comment/502a6050_0d8c0622 PS1, Line 102: stack[i] = 0x42420707; > just include this in the loop above as `stack[i+1] = 0x42420707;`? I did it this way to prevent overflow with stack[i+1], but it seems to be unnecessary because the stack should have even size. -- To view, visit https://review.coreboot.org/c/coreboot/+/50305 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf0cceac290618a50ecc4e65f1f9551dbf31bd32 Gerrit-Change-Number: 50305 Gerrit-PatchSet: 2 Gerrit-Owner: jacz(a)semihalf.com Gerrit-Reviewer: Jan Dabros <jsd(a)semihalf.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Paul Fagerburg <pfagerburg(a)chromium.org> Gerrit-Attention: Jan Dabros <jsd(a)semihalf.com> Gerrit-Comment-Date: Mon, 08 Feb 2021 08:13:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Fagerburg <pfagerburg(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: tests: Add lib/stack-test test case
by Name of user not set (Code Review) 08 Feb '21

08 Feb '21

Attention is currently required from: Martin Roth, jacz(a)semihalf.com, Jan Dabros. Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Paul Fagerburg, Jan Dabros, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/50305 to look at the new patch set (#2). Change subject: tests: Add lib/stack-test test case ...................................................................... tests: Add lib/stack-test test case Signed-off-by: Jakub Czapiga <jacz(a)semihalf.com> Change-Id: Icf0cceac290618a50ecc4e65f1f9551dbf31bd32 --- M tests/lib/Makefile.inc A tests/lib/stack-test.c 2 files changed, 137 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/50305/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/50305 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf0cceac290618a50ecc4e65f1f9551dbf31bd32 Gerrit-Change-Number: 50305 Gerrit-PatchSet: 2 Gerrit-Owner: jacz(a)semihalf.com Gerrit-Reviewer: Jan Dabros <jsd(a)semihalf.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: jacz(a)semihalf.com Gerrit-Attention: Jan Dabros <jsd(a)semihalf.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/{baytrail,broadwell}: Add missing <cbmem.h>
by Patrick Georgi (Code Review) 08 Feb '21

08 Feb '21

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/50375 ) Change subject: soc/intel/{baytrail,broadwell}: Add missing <cbmem.h> ...................................................................... soc/intel/{baytrail,broadwell}: Add missing <cbmem.h> Change-Id: Ic4e55f8233e5cb5cea575ad0581adf457a45ba9a Fixes: commit 0322bc5ed8 (src: Remove unused <cbmem.h>) Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/50375 Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> Reviewed-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Reviewed-by: Felix Held <felix-coreboot(a)felixheld.de> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/soc/intel/baytrail/refcode.c M src/soc/intel/broadwell/refcode.c 2 files changed, 2 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Kyösti Mälkki: Looks good to me, approved Felix Held: Looks good to me, approved diff --git a/src/soc/intel/baytrail/refcode.c b/src/soc/intel/baytrail/refcode.c index d8623ae..8cd7336 100644 --- a/src/soc/intel/baytrail/refcode.c +++ b/src/soc/intel/baytrail/refcode.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <acpi/acpi.h> +#include <cbmem.h> #include <console/console.h> #include <console/streams.h> #include <cpu/x86/tsc.h> diff --git a/src/soc/intel/broadwell/refcode.c b/src/soc/intel/broadwell/refcode.c index 5d3ccce..31d6ad8 100644 --- a/src/soc/intel/broadwell/refcode.c +++ b/src/soc/intel/broadwell/refcode.c @@ -2,6 +2,7 @@ #include <string.h> #include <acpi/acpi.h> +#include <cbmem.h> #include <console/console.h> #include <console/streams.h> #include <program_loading.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/50375 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic4e55f8233e5cb5cea575ad0581adf457a45ba9a Gerrit-Change-Number: 50375 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2021