coreboot-gerrit February 2021

coreboot-gerrit@coreboot.org

1 participants
7192 discussions

Change in coreboot[master]: src: Add missing <cbmem.h>
by Angel Pons (Code Review) 08 Feb '21

08 Feb '21

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Aaron Durbin, HAOUAS Elyes, Felix Held. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50379 ) Change subject: src: Add missing <cbmem.h> ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/50379 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I75a816c594b326df8a4aa5458bb055fca35e1741 Gerrit-Change-Number: 50379 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 08 Feb 2021 14:45:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: src: Remove unused <boot_device.h>
by Angel Pons (Code Review) 08 Feb '21

08 Feb '21

Attention is currently required from: Patrick Rudolph, HAOUAS Elyes. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50201 ) Change subject: src: Remove unused <boot_device.h> ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/50201 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idbb4d72e1ba620f71e8bf882d434c103cb422615 Gerrit-Change-Number: 50201 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Comment-Date: Mon, 08 Feb 2021 14:41:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: rivers/spi/spi_flash.c: Remove unused <boot_device.h>
by HAOUAS Elyes (Code Review) 08 Feb '21

08 Feb '21

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45817 ) Change subject: rivers/spi/spi_flash.c: Remove unused <boot_device.h> ...................................................................... rivers/spi/spi_flash.c: Remove unused <boot_device.h> Change-Id: I7f6a5df455dff8bfdd9940b10bdbfd73454bc881 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/drivers/spi/spi_flash.c 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/45817/1 diff --git a/src/drivers/spi/spi_flash.c b/src/drivers/spi/spi_flash.c index f2610a1..66804ec 100644 --- a/src/drivers/spi/spi_flash.c +++ b/src/drivers/spi/spi_flash.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */ #include <assert.h> -#include <boot_device.h> #include <boot/coreboot_tables.h> #include <console/console.h> #include <string.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/45817 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7f6a5df455dff8bfdd9940b10bdbfd73454bc881 Gerrit-Change-Number: 45817 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

2 6

Change in coreboot[master]: src: Remove unused <boot_device.h>
by HAOUAS Elyes (Code Review) 08 Feb '21

08 Feb '21

Attention is currently required from: Patrick Rudolph. Hello build bot (Jenkins), Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/50201 to look at the new patch set (#2). Change subject: src: Remove unused <boot_device.h> ...................................................................... src: Remove unused <boot_device.h> Change-Id: Idbb4d72e1ba620f71e8bf882d434c103cb422615 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/drivers/spi/flashconsole.c M src/drivers/spi/spi_flash.c M src/soc/intel/common/block/cse/cse_lite.c M src/soc/samsung/exynos5250/spi.c 4 files changed, 2 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/50201/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/50201 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idbb4d72e1ba620f71e8bf882d434c103cb422615 Gerrit-Change-Number: 50201 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/prodrive/hermes: Configure 'internal audio'
by Patrick Rudolph (Code Review) 08 Feb '21

08 Feb '21

Attention is currently required from: Patrick Rudolph, Christian Walter, Angel Pons. Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50389 ) Change subject: mb/prodrive/hermes: Configure 'internal audio' ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/50389 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5e0013217838888977aaa9259e0cfb78c82f719f Gerrit-Change-Number: 50389 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 08 Feb 2021 13:34:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: device/azalia_device: Add mainboard hook to program codecs
by Patrick Rudolph (Code Review) 08 Feb '21

08 Feb '21

Attention is currently required from: Patrick Rudolph, Angel Pons. Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50388 ) Change subject: device/azalia_device: Add mainboard hook to program codecs ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/50388 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7efeba5c26051aeb5061cce191ace08c304a6c70 Gerrit-Change-Number: 50388 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 08 Feb 2021 13:33:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: device/azalia_device: Add function to program a verb table
by Patrick Rudolph (Code Review) 08 Feb '21

08 Feb '21

Attention is currently required from: Patrick Rudolph, Angel Pons. Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50387 ) Change subject: device/azalia_device: Add function to program a verb table ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/50387 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie9607f6e733df66f0ca26a4bb70e0864ce1d4512 Gerrit-Change-Number: 50387 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 08 Feb 2021 13:33:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: device/azalia_device.c: Correct print format
by Patrick Rudolph (Code Review) 08 Feb '21

08 Feb '21

Attention is currently required from: Patrick Rudolph, Angel Pons. Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50386 ) Change subject: device/azalia_device.c: Correct print format ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/50386 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2b353b940e881dc8b5f0b902509d97d89c997a70 Gerrit-Change-Number: 50386 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 08 Feb 2021 13:30:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/siemens/mc_apl2: Switch I2C bus for RX6110SA
by Mario Scheithauer (Code Review) 08 Feb '21

08 Feb '21

Mario Scheithauer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/50391 ) Change subject: mb/siemens/mc_apl2: Switch I2C bus for RX6110SA ...................................................................... mb/siemens/mc_apl2: Switch I2C bus for RX6110SA With a new HW revision of this board, the connection of the external RTC RX6110SA was changed from I2C bus 0 to I2C bus 3. Change-Id: I10dd44949973ea490b3c7e4ad83d56ce2e566adf Signed-off-by: Mario Scheithauer <mario.scheithauer(a)siemens.com> --- M src/mainboard/siemens/mc_apl1/variants/mc_apl2/devicetree.cb 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/50391/1 diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl2/devicetree.cb b/src/mainboard/siemens/mc_apl1/variants/mc_apl2/devicetree.cb index 047d9b1..bc70674 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl2/devicetree.cb +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl2/devicetree.cb @@ -81,7 +81,10 @@ end device pci 15.0 on end # - XHCI device pci 15.1 off end # - XDCI - device pci 16.0 on # - I2C 0 + device pci 16.0 on end # - I2C 0 + device pci 16.1 on end # - I2C 1 + device pci 16.2 on end # - I2C 2 + device pci 16.3 on # - I2C 3 # Enable external RTC chip chip drivers/i2c/rx6110sa register "pmon_sampling" = "PMON_SAMPL_256_MS" @@ -96,9 +99,6 @@ device i2c 0x32 on end # RTC RX6110 SA end end - device pci 16.1 on end # - I2C 1 - device pci 16.2 on end # - I2C 2 - device pci 16.3 on end # - I2C 3 device pci 17.0 on end # - I2C 4 device pci 17.1 on end # - I2C 5 device pci 17.2 on end # - I2C 6 -- To view, visit https://review.coreboot.org/c/coreboot/+/50391 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I10dd44949973ea490b3c7e4ad83d56ce2e566adf Gerrit-Change-Number: 50391 Gerrit-PatchSet: 1 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/prodrive/hermes: Configure 'internal audio'
by Angel Pons (Code Review) 08 Feb '21

08 Feb '21

Attention is currently required from: Patrick Rudolph, Christian Walter. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50383 ) Change subject: mb/prodrive/hermes: Configure 'internal audio' ...................................................................... Patch Set 2: (1 comment) File src/mainboard/prodrive/hermes/hda_verb.c: https://review.coreboot.org/c/coreboot/+/50383/comment/4ef999f0_f5f0366b PS2, Line 186: verbs = malloc(sizeof(u32) * 4); : if (!verbs) : return NULL; : : *verb_table_size = 0; : : if (board_cfg->internal_audio_connection == 0) { : static u32 verb_data[] = { : AZALIA_PIN_CFG(0, 0x1b, 0x411111f0), : }; : memcpy(&verbs[*verb_table_size], verb_data, sizeof(verb_data)); : *verb_table_size += sizeof(verb_data) / sizeof(u32); : : } else if (board_cfg->internal_audio_connection == 1) { : static u32 verb_data[] = { : AZALIA_PIN_CFG(0, 0x1b, 0x02214c40), : }; : memcpy(&verbs[*verb_table_size], verb_data, sizeof(verb_data)); : *verb_table_size += sizeof(verb_data) / sizeof(u32); : } else { : static u32 verb_data[] = { : AZALIA_PIN_CFG(0, 0x1b, AZALIA_PIN_DESC( : INTEGRATED, : INTERNAL, : NA, : SPEAKER, : TYPE_UNKNOWN, : COLOR_UNKNOWN, : false, : 0xf, : 0)), : }; : memcpy(&verbs[*verb_table_size], verb_data, sizeof(verb_data)); : *verb_table_size += sizeof(verb_data) / sizeof(u32); : } : : /* Leak verbs */ : return verbs; > It is. As the following (to be written) patch also configures verbs. Most of the boilerplate is because of the need to use a static array. If the mainboard callback can program the verb table, the result looks better IMHO: CB:50389 -- To view, visit https://review.coreboot.org/c/coreboot/+/50383 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2bab0f2d36826c193b1af2b9ca2598a7bf00ac46 Gerrit-Change-Number: 50383 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Patrick Rudolph Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Patrick Rudolph Gerrit-Comment-Date: Mon, 08 Feb 2021 12:42:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Patrick Rudolph Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2021