Attention is currently required from: Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50382 )
Change subject: device/azalia: Add weak function for extra verbs
......................................................................
Patch Set 1:
(1 comment)
File src/device/azalia_device.c:
https://review.coreboot.org/c/coreboot/+/50382/comment/9513a16f_60d3ec6e
PS1, Line 191: extra
nit: `runtime` ?
--
To view, visit https://review.coreboot.org/c/coreboot/+/50382
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I983c62d26be68885bb2f5b3a85f989b9d6b77706
Gerrit-Change-Number: 50382
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Comment-Date: Mon, 08 Feb 2021 10:23:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50382 )
Change subject: device/azalia: Add weak function for extra verbs
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patchset:
PS1:
Sounds better than making non-const verb tables
--
To view, visit https://review.coreboot.org/c/coreboot/+/50382
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I983c62d26be68885bb2f5b3a85f989b9d6b77706
Gerrit-Change-Number: 50382
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Comment-Date: Mon, 08 Feb 2021 10:21:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Patrick Rudolph, Christian Walter.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50381 )
Change subject: mb/prodrive/hermes: Set mb_hda_amp_enable based on cfg
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File src/mainboard/prodrive/hermes/mainboard.c:
https://review.coreboot.org/c/coreboot/+/50381/comment/42bf3425_696cda56
PS1, Line 71: if (board_cfg->internal_audio_connection == 2)
Should we add an enum?
--
To view, visit https://review.coreboot.org/c/coreboot/+/50381
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I13c2ece729128fe245de88c0d36ce7b4bcaf6b6d
Gerrit-Change-Number: 50381
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Comment-Date: Mon, 08 Feb 2021 10:19:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Patrick Rudolph, Christian Walter.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50380 )
Change subject: mb/prodrive/hermes: Drop reset functions
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/50380
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic99fcae2a3f00be7eebd7be618df838522dac69f
Gerrit-Change-Number: 50380
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Comment-Date: Mon, 08 Feb 2021 10:18:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Paul Menzel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/50385 )
Change subject: mb/google/zork: devicetree: Fix typo in *Coprocessor* in comment
......................................................................
mb/google/zork: devicetree: Fix typo in *Coprocessor* in comment
Fixes: b3c41329fd (mb/google/zork: Add Picasso based Zork mainboard and variants)
Change-Id: I68cd5ffc3117e714919bbce56e9af4c9982b3d54
Signed-off-by: Paul Menzel <pmenzel(a)molgen.mpg.de>
---
M src/mainboard/google/zork/variants/baseboard/devicetree_dalboz.cb
M src/mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/50385/1
diff --git a/src/mainboard/google/zork/variants/baseboard/devicetree_dalboz.cb b/src/mainboard/google/zork/variants/baseboard/devicetree_dalboz.cb
index 9b0dd9a..8bc87f7 100644
--- a/src/mainboard/google/zork/variants/baseboard/devicetree_dalboz.cb
+++ b/src/mainboard/google/zork/variants/baseboard/devicetree_dalboz.cb
@@ -264,7 +264,7 @@
device pci 8.1 on # Internal GPP Bridge 0 to Bus A
device pci 0.0 on end # Internal GPU
device pci 0.1 on end # Display HDA
- device pci 0.2 on end # Crypto Coprocesor
+ device pci 0.2 on end # Crypto Coprocessor
device pci 0.3 on # USB 3.1
chip drivers/usb/acpi
register "desc" = ""Root Hub""
diff --git a/src/mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb b/src/mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb
index a3c4573..f354991 100644
--- a/src/mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb
+++ b/src/mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb
@@ -266,7 +266,7 @@
device pci 8.1 on # Internal GPP Bridge 0 to Bus A
device pci 0.0 on end # Internal GPU
device pci 0.1 on end # Display HDA
- device pci 0.2 on end # Crypto Coprocesor
+ device pci 0.2 on end # Crypto Coprocessor
device pci 0.3 on # USB 3.1
chip drivers/usb/acpi
register "desc" = ""Root Hub""
--
To view, visit https://review.coreboot.org/c/coreboot/+/50385
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I68cd5ffc3117e714919bbce56e9af4c9982b3d54
Gerrit-Change-Number: 50385
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-MessageType: newchange
Attention is currently required from: Martin Roth, HAOUAS Elyes.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50384 )
Change subject: Makefile.inc: Don't ignore _HID & _ADR coexisting in Broadwell ASL code
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/50384
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I52beba66230a3542a7039f496b51be0aa4bdcce4
Gerrit-Change-Number: 50384
Gerrit-PatchSet: 2
Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Mon, 08 Feb 2021 09:32:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/50384 )
Change subject: Makefile.inc: Don't ignore _HID & _ADR coexisting in Broadwell ASL code
......................................................................
Makefile.inc: Don't ignore _HID & _ADR coexisting in Broadwell ASL code
Change-Id: I52beba66230a3542a7039f496b51be0aa4bdcce4
Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr>
---
M Makefile.inc
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/50384/1
diff --git a/Makefile.inc b/Makefile.inc
index 54adaa2..a57fac0 100644
--- a/Makefile.inc
+++ b/Makefile.inc
@@ -259,14 +259,14 @@
# Redundant offset remarks are not useful in any way and are masking useful
# ones that might indicate an issue so it is better to hide them.
REDUNDANT_OFFSET_REMARK = 2158
-# Ignore _HID & _ADR coexisting in Intel Lynxpoint and Broadwell ASL code.
-# See cb:38803 & cb:38802
+# Ignore _HID & _ADR coexisting in Intel Lynxpoint ASL code.
+# See cb:38802
# "Multiple types (Device object requires either a _HID or _ADR, but not both)"
MULTIPLE_TYPES_WARNING = 3073
IASL_WARNINGS_LIST = $(EMPTY_RESOURCE_TEMPLATE_WARNING) $(REDUNDANT_OFFSET_REMARK)
-ifeq ($(CONFIG_SOUTHBRIDGE_INTEL_LYNXPOINT)$(CONFIG_SOC_INTEL_BROADWELL),y)
+ifeq ($(CONFIG_SOUTHBRIDGE_INTEL_LYNXPOINT),y)
IASL_WARNINGS_LIST += $(MULTIPLE_TYPES_WARNING)
endif
--
To view, visit https://review.coreboot.org/c/coreboot/+/50384
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I52beba66230a3542a7039f496b51be0aa4bdcce4
Gerrit-Change-Number: 50384
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-MessageType: newchange
Attention is currently required from: Patrick Rudolph, Christian Walter.
Hello build bot (Jenkins), Christian Walter,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/50383
to look at the new patch set (#2).
Change subject: mb/prodrive/hermes: Configure 'internal audio'
......................................................................
mb/prodrive/hermes: Configure 'internal audio'
Implement azalia_extra_verb_table and let the azalia driver configure
the codec according to the EEPROM configuration
'internal_audio_connection' which encodes as:
* 0 disabled
* 1 Front HP out
* 2 Internal speaker
Change-Id: I2bab0f2d36826c193b1af2b9ca2598a7bf00ac46
Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com>
---
M src/mainboard/prodrive/hermes/hda_verb.c
1 file changed, 54 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/50383/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/50383
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2bab0f2d36826c193b1af2b9ca2598a7bf00ac46
Gerrit-Change-Number: 50383
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-MessageType: newpatchset