coreboot-gerrit February 2021

coreboot-gerrit@coreboot.org

1 participants
7192 discussions

Change in coreboot[master]: soc/amd/picasso: move bert_reserved_region to common/block/cpu/noncar
by Marshall Dawson (Code Review) 08 Feb '21

08 Feb '21

Attention is currently required from: Jason Glenesk, Raul Rangel, Felix Held. Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50401 ) Change subject: soc/amd/picasso: move bert_reserved_region to common/block/cpu/noncar ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS2: Out of scope for this patch but we should deprecate using FSP to reserve BERT memory. CB:45391. -- To view, visit https://review.coreboot.org/c/coreboot/+/50401 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib49124c2c774ad3352ea2f7d8d827388029be041 Gerrit-Change-Number: 50401 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 08 Feb 2021 19:52:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/picasso: move smm_region to soc/amd/common/block/cpu/noncar
by Marshall Dawson (Code Review) 08 Feb '21

08 Feb '21

Attention is currently required from: Jason Glenesk, Felix Held. Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50400 ) Change subject: soc/amd/picasso: move smm_region to soc/amd/common/block/cpu/noncar ...................................................................... Patch Set 2: Code-Review+2 (1 comment) File src/soc/amd/common/block/cpu/noncar/memmap.c: https://review.coreboot.org/c/coreboot/+/50400/comment/619c0784_c334d388 PS2, Line 40: clear_tvalid Out of scope for this patch but I believe this is common for all our products so it could also be commonized in a way that stoneyridge could use it too. -- To view, visit https://review.coreboot.org/c/coreboot/+/50400 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I40f9d2fe7d144e94369a417225bcca0a299d1f45 Gerrit-Change-Number: 50400 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 08 Feb 2021 19:50:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/picasso: move bert_reserved_region to common/block/cpu/noncar
by Felix Held (Code Review) 08 Feb '21

08 Feb '21

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50401 ) Change subject: soc/amd/picasso: move bert_reserved_region to common/block/cpu/noncar ...................................................................... Patch Set 2: (1 comment) File src/soc/amd/common/block/cpu/noncar/memmap.c: https://review.coreboot.org/c/coreboot/+/50401/comment/36fc6ddf_97a40eb3 PS2, Line 84: bert_reserved_region > same comment as last patch. Maybe this function could be renamed to have a verb in a future patch. basically same comment as on the last one, but it's called from src/arch/x86/acpi_bert_storage.c in this case -- To view, visit https://review.coreboot.org/c/coreboot/+/50401 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib49124c2c774ad3352ea2f7d8d827388029be041 Gerrit-Change-Number: 50401 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Comment-Date: Mon, 08 Feb 2021 19:45:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin Roth <martinroth(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: vc/amd/fsp/cezanne: add FspGuids.h
by Marshall Dawson (Code Review) 08 Feb '21

08 Feb '21

Attention is currently required from: Felix Held. Marshall Dawson has uploaded a new patch set (#2) to the change originally created by Felix Held. ( https://review.coreboot.org/c/coreboot/+/50402 ) Change subject: vc/amd/fsp/cezanne: add FspGuids.h ...................................................................... vc/amd/fsp/cezanne: add FspGuids.h Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: I54579a7998d1a4a232cb5286d3f481e2e63a4476 --- A src/vendorcode/amd/fsp/cezanne/FspGuids.h 1 file changed, 16 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/50402/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/50402 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I54579a7998d1a4a232cb5286d3f481e2e63a4476 Gerrit-Change-Number: 50402 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/amd/picasso/memmap: drop __SIMPLE_DEVICE__
by Marshall Dawson (Code Review) 08 Feb '21

08 Feb '21

Attention is currently required from: Jason Glenesk, Felix Held. Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50399 ) Change subject: soc/amd/picasso/memmap: drop __SIMPLE_DEVICE__ ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: Hmm, we've been carrying that around for a long time. -- To view, visit https://review.coreboot.org/c/coreboot/+/50399 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I577e2ecdc59dbd09e739ae800cbe021168a34812 Gerrit-Change-Number: 50399 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 08 Feb 2021 19:44:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/picasso: move smm_region to soc/amd/common/block/cpu/noncar
by Felix Held (Code Review) 08 Feb '21

08 Feb '21

Attention is currently required from: Jason Glenesk, Marshall Dawson. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50400 ) Change subject: soc/amd/picasso: move smm_region to soc/amd/common/block/cpu/noncar ...................................................................... Patch Set 2: (1 comment) File src/soc/amd/common/block/cpu/noncar/memmap.c: https://review.coreboot.org/c/coreboot/+/50400/comment/468fb53f_af04a660 PS2, Line 58: smm_region > smm_region doesn't mean very much. Naming functions with verbs is good. […] that function is called by smm_subregion in src/cpu/x86/smm/tseg_region.c, so that would be a coreboot-wide change and shouldn't contain hob in it, since that's only the case for fsp-based chipset support -- To view, visit https://review.coreboot.org/c/coreboot/+/50400 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I40f9d2fe7d144e94369a417225bcca0a299d1f45 Gerrit-Change-Number: 50400 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Comment-Date: Mon, 08 Feb 2021 19:43:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin Roth <martinroth(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cbfstool: Remove location pointer from parse_elf_to_stage()
by Aaron Durbin (Code Review) 08 Feb '21

08 Feb '21

Attention is currently required from: Furquan Shaikh, Julius Werner. Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49369 ) Change subject: cbfstool: Remove location pointer from parse_elf_to_stage() ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/49369 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia7f850c0edd7536ed3bef643efaae7271599313d Gerrit-Change-Number: 49369 Gerrit-PatchSet: 4 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Mon, 08 Feb 2021 19:42:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/picasso: move smm_region to soc/amd/common/block/cpu/noncar
by Martin Roth (Code Review) 08 Feb '21

08 Feb '21

Attention is currently required from: Jason Glenesk, Marshall Dawson, Felix Held. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50400 ) Change subject: soc/amd/picasso: move smm_region to soc/amd/common/block/cpu/noncar ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/50400 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I40f9d2fe7d144e94369a417225bcca0a299d1f45 Gerrit-Change-Number: 50400 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 08 Feb 2021 19:34:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/picasso: move bert_reserved_region to common/block/cpu/noncar
by Martin Roth (Code Review) 08 Feb '21

08 Feb '21

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Felix Held. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50401 ) Change subject: soc/amd/picasso: move bert_reserved_region to common/block/cpu/noncar ...................................................................... Patch Set 2: Code-Review+2 (1 comment) File src/soc/amd/common/block/cpu/noncar/memmap.c: https://review.coreboot.org/c/coreboot/+/50401/comment/571db219_e7b8ce69 PS2, Line 84: bert_reserved_region same comment as last patch. Maybe this function could be renamed to have a verb in a future patch. -- To view, visit https://review.coreboot.org/c/coreboot/+/50401 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib49124c2c774ad3352ea2f7d8d827388029be041 Gerrit-Change-Number: 50401 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 08 Feb 2021 19:34:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/picasso: move smm_region to soc/amd/common/block/cpu/noncar
by Martin Roth (Code Review) 08 Feb '21

08 Feb '21

Attention is currently required from: Jason Glenesk, Marshall Dawson, Felix Held. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50400 ) Change subject: soc/amd/picasso: move smm_region to soc/amd/common/block/cpu/noncar ...................................................................... Patch Set 2: (1 comment) File src/soc/amd/common/block/cpu/noncar/memmap.c: https://review.coreboot.org/c/coreboot/+/50400/comment/0c37ede4_a998e989 PS2, Line 58: smm_region smm_region doesn't mean very much. Naming functions with verbs is good. Maybe init_smm_region_from_hob? could be done in a future change? -- To view, visit https://review.coreboot.org/c/coreboot/+/50400 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I40f9d2fe7d144e94369a417225bcca0a299d1f45 Gerrit-Change-Number: 50400 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 08 Feb 2021 19:33:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2021