coreboot-gerrit February 2021

coreboot-gerrit@coreboot.org

1 participants
7192 discussions

Change in coreboot[master]: soc/qualcomm: Remove unused <console/console.h>
by HAOUAS Elyes (Code Review) 11 Feb '21

11 Feb '21

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/50530 ) Change subject: soc/qualcomm: Remove unused <console/console.h> ...................................................................... soc/qualcomm: Remove unused <console/console.h> Change-Id: Idd93ed91e854c8775cbcf721e4e332aef7b36e42 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/soc/qualcomm/sc7180/display/dsi_phy_pll.c M src/soc/qualcomm/sc7180/qclib.c M src/soc/qualcomm/sc7180/watchdog.c 3 files changed, 0 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/50530/1 diff --git a/src/soc/qualcomm/sc7180/display/dsi_phy_pll.c b/src/soc/qualcomm/sc7180/display/dsi_phy_pll.c index b01fc2e..88754ee 100644 --- a/src/soc/qualcomm/sc7180/display/dsi_phy_pll.c +++ b/src/soc/qualcomm/sc7180/display/dsi_phy_pll.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <device/mmio.h> -#include <console/console.h> #include <string.h> #include <stdint.h> #include <delay.h> diff --git a/src/soc/qualcomm/sc7180/qclib.c b/src/soc/qualcomm/sc7180/qclib.c index 2bff80d..e6d54be 100644 --- a/src/soc/qualcomm/sc7180/qclib.c +++ b/src/soc/qualcomm/sc7180/qclib.c @@ -2,7 +2,6 @@ #include <cbfs.h> #include <fmap.h> -#include <console/console.h> #include <soc/symbols.h> #include <soc/qclib_common.h> diff --git a/src/soc/qualcomm/sc7180/watchdog.c b/src/soc/qualcomm/sc7180/watchdog.c index 954f68a..0b7dd6d 100644 --- a/src/soc/qualcomm/sc7180/watchdog.c +++ b/src/soc/qualcomm/sc7180/watchdog.c @@ -2,7 +2,6 @@ #include <soc/watchdog.h> #include <soc/clock.h> -#include <console/console.h> #include <device/mmio.h> #include <vendorcode/google/chromeos/chromeos.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/50530 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idd93ed91e854c8775cbcf721e4e332aef7b36e42 Gerrit-Change-Number: 50530 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/mediatek: Remove unused <console/console.h>
by HAOUAS Elyes (Code Review) 11 Feb '21

11 Feb '21

Attention is currently required from: Hung-Te Lin. HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/50529 ) Change subject: soc/mediatek: Remove unused <console/console.h> ...................................................................... soc/mediatek: Remove unused <console/console.h> Change-Id: If025d4c0b2ba9868d8df699fcddfcec349cdc0ea Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/soc/mediatek/mt8192/devapc.c M src/soc/mediatek/mt8192/dpm.c M src/soc/mediatek/mt8192/sspm.c 3 files changed, 0 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/50529/1 diff --git a/src/soc/mediatek/mt8192/devapc.c b/src/soc/mediatek/mt8192/devapc.c index 77d5fc5..d297d52 100644 --- a/src/soc/mediatek/mt8192/devapc.c +++ b/src/soc/mediatek/mt8192/devapc.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <console/console.h> #include <soc/devapc.h> static void *getreg(uintptr_t base, unsigned int offset) diff --git a/src/soc/mediatek/mt8192/dpm.c b/src/soc/mediatek/mt8192/dpm.c index 7acdf68..991441e 100644 --- a/src/soc/mediatek/mt8192/dpm.c +++ b/src/soc/mediatek/mt8192/dpm.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <console/console.h> #include <device/mmio.h> #include <soc/dpm.h> #include <soc/mcu_common.h> diff --git a/src/soc/mediatek/mt8192/sspm.c b/src/soc/mediatek/mt8192/sspm.c index b36e0df..cce08c2 100644 --- a/src/soc/mediatek/mt8192/sspm.c +++ b/src/soc/mediatek/mt8192/sspm.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <console/console.h> #include <device/mmio.h> #include <soc/mcu_common.h> #include <soc/sspm.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/50529 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If025d4c0b2ba9868d8df699fcddfcec349cdc0ea Gerrit-Change-Number: 50529 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/intel: Remove unused <console/console.h>
by HAOUAS Elyes (Code Review) 11 Feb '21

11 Feb '21

Attention is currently required from: Andrey Petrov, Patrick Rudolph. HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/50528 ) Change subject: soc/intel: Remove unused <console/console.h> ...................................................................... soc/intel: Remove unused <console/console.h> Change-Id: I630b7b0b1d564bcd99358caaaef4afd78c22866c Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/soc/intel/alderlake/uart.c M src/soc/intel/apollolake/elog.c M src/soc/intel/apollolake/uart.c M src/soc/intel/baytrail/elog.c M src/soc/intel/braswell/elog.c M src/soc/intel/braswell/sata.c M src/soc/intel/braswell/scc.c M src/soc/intel/broadwell/pch/elog.c M src/soc/intel/cannonlake/smihandler.c M src/soc/intel/cannonlake/uart.c M src/soc/intel/elkhartlake/romstage/fsp_params.c M src/soc/intel/elkhartlake/smihandler.c M src/soc/intel/elkhartlake/uart.c M src/soc/intel/icelake/smihandler.c M src/soc/intel/icelake/uart.c M src/soc/intel/jasperlake/smihandler.c M src/soc/intel/jasperlake/uart.c M src/soc/intel/skylake/elog.c M src/soc/intel/skylake/graphics.c M src/soc/intel/skylake/uart.c M src/soc/intel/tigerlake/chip.c M src/soc/intel/tigerlake/smihandler.c M src/soc/intel/tigerlake/uart.c M src/soc/intel/xeon_sp/skx/romstage.c 24 files changed, 0 insertions(+), 24 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/50528/1 diff --git a/src/soc/intel/alderlake/uart.c b/src/soc/intel/alderlake/uart.c index 06618b2..e1a77b3 100644 --- a/src/soc/intel/alderlake/uart.c +++ b/src/soc/intel/alderlake/uart.c @@ -6,7 +6,6 @@ * Chapter number: 9 */ -#include <console/console.h> #include <device/pci_def.h> #include <intelblocks/gpio.h> #include <intelblocks/lpss.h> diff --git a/src/soc/intel/apollolake/elog.c b/src/soc/intel/apollolake/elog.c index 47b68f1..1f65040 100644 --- a/src/soc/intel/apollolake/elog.c +++ b/src/soc/intel/apollolake/elog.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <acpi/acpi_pm.h> -#include <console/console.h> #include <device/pci_type.h> #include <elog.h> #include <intelblocks/pmclib.h> diff --git a/src/soc/intel/apollolake/uart.c b/src/soc/intel/apollolake/uart.c index 2a2d7a2..b8758f5 100644 --- a/src/soc/intel/apollolake/uart.c +++ b/src/soc/intel/apollolake/uart.c @@ -6,7 +6,6 @@ * shouldn't cause any fragmentation. */ -#include <console/console.h> #include <intelblocks/uart.h> #include <soc/gpio.h> #include <soc/pci_devs.h> diff --git a/src/soc/intel/baytrail/elog.c b/src/soc/intel/baytrail/elog.c index b299c37..b49c7c8 100644 --- a/src/soc/intel/baytrail/elog.c +++ b/src/soc/intel/baytrail/elog.c @@ -2,7 +2,6 @@ #include <acpi/acpi.h> #include <acpi/acpi_pm.h> -#include <console/console.h> #include <device/device.h> #include <device/pci.h> #include <elog.h> diff --git a/src/soc/intel/braswell/elog.c b/src/soc/intel/braswell/elog.c index b299c37..b49c7c8 100644 --- a/src/soc/intel/braswell/elog.c +++ b/src/soc/intel/braswell/elog.c @@ -2,7 +2,6 @@ #include <acpi/acpi.h> #include <acpi/acpi_pm.h> -#include <console/console.h> #include <device/device.h> #include <device/pci.h> #include <elog.h> diff --git a/src/soc/intel/braswell/sata.c b/src/soc/intel/braswell/sata.c index d80edec..d88ee57 100644 --- a/src/soc/intel/braswell/sata.c +++ b/src/soc/intel/braswell/sata.c @@ -3,7 +3,6 @@ #include <soc/pci_devs.h> #include <soc/ramstage.h> #include <soc/sata.h> -#include <console/console.h> #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> diff --git a/src/soc/intel/braswell/scc.c b/src/soc/intel/braswell/scc.c index c6d4f52..902ee57 100644 --- a/src/soc/intel/braswell/scc.c +++ b/src/soc/intel/braswell/scc.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <acpi/acpi_gnvs.h> -#include <console/console.h> #include <device/device.h> #include <device/pci.h> #include <soc/iosf.h> diff --git a/src/soc/intel/broadwell/pch/elog.c b/src/soc/intel/broadwell/pch/elog.c index 3f62556..789b4e8 100644 --- a/src/soc/intel/broadwell/pch/elog.c +++ b/src/soc/intel/broadwell/pch/elog.c @@ -2,7 +2,6 @@ #include <acpi/acpi_pm.h> #include <bootstate.h> -#include <console/console.h> #include <stdint.h> #include <elog.h> #include <soc/lpc.h> diff --git a/src/soc/intel/cannonlake/smihandler.c b/src/soc/intel/cannonlake/smihandler.c index dd8db5b..bfee1c0 100644 --- a/src/soc/intel/cannonlake/smihandler.c +++ b/src/soc/intel/cannonlake/smihandler.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <console/console.h> #include <device/device.h> #include <intelblocks/cse.h> #include <intelblocks/smihandler.h> diff --git a/src/soc/intel/cannonlake/uart.c b/src/soc/intel/cannonlake/uart.c index cc44a61..da0306c 100644 --- a/src/soc/intel/cannonlake/uart.c +++ b/src/soc/intel/cannonlake/uart.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <console/console.h> #include <device/pci_def.h> #include <intelblocks/gpio.h> #include <intelblocks/lpss.h> diff --git a/src/soc/intel/elkhartlake/romstage/fsp_params.c b/src/soc/intel/elkhartlake/romstage/fsp_params.c index 50add6e..f6c59a6 100644 --- a/src/soc/intel/elkhartlake/romstage/fsp_params.c +++ b/src/soc/intel/elkhartlake/romstage/fsp_params.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <assert.h> -#include <console/console.h> #include <device/device.h> #include <fsp/util.h> #include <soc/pci_devs.h> diff --git a/src/soc/intel/elkhartlake/smihandler.c b/src/soc/intel/elkhartlake/smihandler.c index 7d2a15e..6637847 100644 --- a/src/soc/intel/elkhartlake/smihandler.c +++ b/src/soc/intel/elkhartlake/smihandler.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <console/console.h> #include <device/pci_def.h> #include <intelblocks/cse.h> #include <intelblocks/smihandler.h> diff --git a/src/soc/intel/elkhartlake/uart.c b/src/soc/intel/elkhartlake/uart.c index cc44a61..da0306c 100644 --- a/src/soc/intel/elkhartlake/uart.c +++ b/src/soc/intel/elkhartlake/uart.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <console/console.h> #include <device/pci_def.h> #include <intelblocks/gpio.h> #include <intelblocks/lpss.h> diff --git a/src/soc/intel/icelake/smihandler.c b/src/soc/intel/icelake/smihandler.c index fbbbbdb..2ca2816 100644 --- a/src/soc/intel/icelake/smihandler.c +++ b/src/soc/intel/icelake/smihandler.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <console/console.h> #include <device/pci_def.h> #include <intelblocks/cse.h> #include <intelblocks/smihandler.h> diff --git a/src/soc/intel/icelake/uart.c b/src/soc/intel/icelake/uart.c index cc44a61..da0306c 100644 --- a/src/soc/intel/icelake/uart.c +++ b/src/soc/intel/icelake/uart.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <console/console.h> #include <device/pci_def.h> #include <intelblocks/gpio.h> #include <intelblocks/lpss.h> diff --git a/src/soc/intel/jasperlake/smihandler.c b/src/soc/intel/jasperlake/smihandler.c index 6d31adf..448c053 100644 --- a/src/soc/intel/jasperlake/smihandler.c +++ b/src/soc/intel/jasperlake/smihandler.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <console/console.h> #include <device/pci_def.h> #include <intelblocks/cse.h> #include <intelblocks/smihandler.h> diff --git a/src/soc/intel/jasperlake/uart.c b/src/soc/intel/jasperlake/uart.c index cc44a61..da0306c 100644 --- a/src/soc/intel/jasperlake/uart.c +++ b/src/soc/intel/jasperlake/uart.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <console/console.h> #include <device/pci_def.h> #include <intelblocks/gpio.h> #include <intelblocks/lpss.h> diff --git a/src/soc/intel/skylake/elog.c b/src/soc/intel/skylake/elog.c index d325a93..c6be670 100644 --- a/src/soc/intel/skylake/elog.c +++ b/src/soc/intel/skylake/elog.c @@ -3,7 +3,6 @@ #include <acpi/acpi_pm.h> #include <bootstate.h> #include <commonlib/helpers.h> -#include <console/console.h> #include <device/mmio.h> #include <device/pci_ops.h> #include <stdint.h> diff --git a/src/soc/intel/skylake/graphics.c b/src/soc/intel/skylake/graphics.c index d41c4aa..786ba2d 100644 --- a/src/soc/intel/skylake/graphics.c +++ b/src/soc/intel/skylake/graphics.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <commonlib/helpers.h> -#include <console/console.h> #include <device/mmio.h> #include <device/pci_rom.h> #include <device/resource.h> diff --git a/src/soc/intel/skylake/uart.c b/src/soc/intel/skylake/uart.c index 4235788..6eb8c3f 100644 --- a/src/soc/intel/skylake/uart.c +++ b/src/soc/intel/skylake/uart.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <console/console.h> #include <device/pci_def.h> #include <gpio.h> #include <intelblocks/lpss.h> diff --git a/src/soc/intel/tigerlake/chip.c b/src/soc/intel/tigerlake/chip.c index 8be04b6..4aa818e 100644 --- a/src/soc/intel/tigerlake/chip.c +++ b/src/soc/intel/tigerlake/chip.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <console/console.h> #include <device/device.h> #include <device/pci.h> #include <fsp/api.h> diff --git a/src/soc/intel/tigerlake/smihandler.c b/src/soc/intel/tigerlake/smihandler.c index 40ed25e..67d21f8 100644 --- a/src/soc/intel/tigerlake/smihandler.c +++ b/src/soc/intel/tigerlake/smihandler.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <console/console.h> #include <device/pci_def.h> #include <intelblocks/cse.h> #include <intelblocks/smihandler.h> diff --git a/src/soc/intel/tigerlake/uart.c b/src/soc/intel/tigerlake/uart.c index a3aee39..da392f4 100644 --- a/src/soc/intel/tigerlake/uart.c +++ b/src/soc/intel/tigerlake/uart.c @@ -6,7 +6,6 @@ * Chapter number: 9 */ -#include <console/console.h> #include <device/pci_def.h> #include <intelblocks/gpio.h> #include <intelblocks/lpss.h> diff --git a/src/soc/intel/xeon_sp/skx/romstage.c b/src/soc/intel/xeon_sp/skx/romstage.c index a1c370d..a5c78f6 100644 --- a/src/soc/intel/xeon_sp/skx/romstage.c +++ b/src/soc/intel/xeon_sp/skx/romstage.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <arch/romstage.h> -#include <console/console.h> #include <intelblocks/rtc.h> #include <soc/romstage.h> #include <soc/soc_util.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/50528 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I630b7b0b1d564bcd99358caaaef4afd78c22866c Gerrit-Change-Number: 50528 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/amd: Remove unused <console/console.h>
by HAOUAS Elyes (Code Review) 11 Feb '21

11 Feb '21

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Felix Held. HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/50527 ) Change subject: soc/amd: Remove unused <console/console.h> ...................................................................... soc/amd: Remove unused <console/console.h> Change-Id: I84cea1a15d1fb220cf95d7ce469728bc6e299685 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/soc/amd/cezanne/cpu.c M src/soc/amd/cezanne/early_fch.c M src/soc/amd/common/block/pi/refcode_loader.c M src/soc/amd/picasso/early_fch.c M src/soc/amd/picasso/fch.c M src/soc/amd/stoneyridge/memmap.c 6 files changed, 0 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/50527/1 diff --git a/src/soc/amd/cezanne/cpu.c b/src/soc/amd/cezanne/cpu.c index 3e0a7db..1f9d001 100644 --- a/src/soc/amd/cezanne/cpu.c +++ b/src/soc/amd/cezanne/cpu.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <console/console.h> #include <cpu/cpu.h> #include <device/device.h> #include <soc/cpu.h> diff --git a/src/soc/amd/cezanne/early_fch.c b/src/soc/amd/cezanne/early_fch.c index 8353cb1..82b3cba 100644 --- a/src/soc/amd/cezanne/early_fch.c +++ b/src/soc/amd/cezanne/early_fch.c @@ -3,7 +3,6 @@ #include <amdblocks/acpimmio.h> #include <amdblocks/lpc.h> #include <amdblocks/smbus.h> -#include <console/console.h> #include <soc/southbridge.h> #include <soc/uart.h> diff --git a/src/soc/amd/common/block/pi/refcode_loader.c b/src/soc/amd/common/block/pi/refcode_loader.c index 274291d..9270c8b 100644 --- a/src/soc/amd/common/block/pi/refcode_loader.c +++ b/src/soc/amd/common/block/pi/refcode_loader.c @@ -3,7 +3,6 @@ #include <acpi/acpi.h> #include <cbfs.h> #include <cbmem.h> -#include <console/console.h> #include <rmodule.h> #include <stage_cache.h> #include <amdblocks/agesawrapper.h> diff --git a/src/soc/amd/picasso/early_fch.c b/src/soc/amd/picasso/early_fch.c index a9118ad..f5ad3f1 100644 --- a/src/soc/amd/picasso/early_fch.c +++ b/src/soc/amd/picasso/early_fch.c @@ -5,7 +5,6 @@ #include <amdblocks/lpc.h> #include <amdblocks/smbus.h> #include <amdblocks/spi.h> -#include <console/console.h> #include <soc/i2c.h> #include <soc/southbridge.h> #include <soc/uart.h> diff --git a/src/soc/amd/picasso/fch.c b/src/soc/amd/picasso/fch.c index 5d62e8e..1f410ca 100644 --- a/src/soc/amd/picasso/fch.c +++ b/src/soc/amd/picasso/fch.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <console/console.h> #include <device/mmio.h> #include <bootstate.h> #include <cpu/amd/msr.h> diff --git a/src/soc/amd/stoneyridge/memmap.c b/src/soc/amd/stoneyridge/memmap.c index 9da3e65..06f80de 100644 --- a/src/soc/amd/stoneyridge/memmap.c +++ b/src/soc/amd/stoneyridge/memmap.c @@ -3,7 +3,6 @@ #include <amdblocks/smm.h> #include <assert.h> #include <stdint.h> -#include <console/console.h> #include <cpu/x86/msr.h> #include <cpu/x86/smm.h> #include <cpu/amd/msr.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/50527 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I84cea1a15d1fb220cf95d7ce469728bc6e299685 Gerrit-Change-Number: 50527 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: src/security: Remove unused <console/console.h>
by HAOUAS Elyes (Code Review) 11 Feb '21

11 Feb '21

Attention is currently required from: Aaron Durbin. HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/50526 ) Change subject: src/security: Remove unused <console/console.h> ...................................................................... src/security: Remove unused <console/console.h> Change-Id: I2b81a57ded80ef9c5cbdff06d8ca9d6b4f599777 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/security/vboot/common.c 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/50526/1 diff --git a/src/security/vboot/common.c b/src/security/vboot/common.c index 0121f56..f3e2e4b 100644 --- a/src/security/vboot/common.c +++ b/src/security/vboot/common.c @@ -2,7 +2,6 @@ #include <assert.h> #include <cbmem.h> -#include <console/console.h> #include <fmap.h> #include <vb2_api.h> #include <security/vboot/misc.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/50526 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2b81a57ded80ef9c5cbdff06d8ca9d6b4f599777 Gerrit-Change-Number: 50526 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Attention: Aaron Durbin <adurbin(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: src/nb: Remove unused <console/console.h>
by HAOUAS Elyes (Code Review) 11 Feb '21

11 Feb '21

Attention is currently required from: Angel Pons, Patrick Rudolph. HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/50525 ) Change subject: src/nb: Remove unused <console/console.h> ...................................................................... src/nb: Remove unused <console/console.h> Change-Id: I55aa05f72e06b509c85f0754320c389de7e75f8d Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/northbridge/intel/i945/romstage.c M src/northbridge/intel/sandybridge/raminit_iosav.c 2 files changed, 0 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/50525/1 diff --git a/src/northbridge/intel/i945/romstage.c b/src/northbridge/intel/i945/romstage.c index 2c9bdbb..248fe14 100644 --- a/src/northbridge/intel/i945/romstage.c +++ b/src/northbridge/intel/i945/romstage.c @@ -3,7 +3,6 @@ #include <stdint.h> #include <cf9_reset.h> #include <cpu/x86/lapic.h> -#include <console/console.h> #include <arch/romstage.h> #include <northbridge/intel/i945/i945.h> #include <northbridge/intel/i945/raminit.h> diff --git a/src/northbridge/intel/sandybridge/raminit_iosav.c b/src/northbridge/intel/sandybridge/raminit_iosav.c index 86b3baa..b9533baf 100644 --- a/src/northbridge/intel/sandybridge/raminit_iosav.c +++ b/src/northbridge/intel/sandybridge/raminit_iosav.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <commonlib/helpers.h> -#include <console/console.h> #include <delay.h> #include <types.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/50525 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I55aa05f72e06b509c85f0754320c389de7e75f8d Gerrit-Change-Number: 50525 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: src/mb: Remove unused <console/console.h>
by HAOUAS Elyes (Code Review) 11 Feb '21

11 Feb '21

Attention is currently required from: Michał Żygowski, Werner Zeh, Evgeny Zinoviev, Piotr Król. HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/50524 ) Change subject: src/mb: Remove unused <console/console.h> ...................................................................... src/mb: Remove unused <console/console.h> Change-Id: I6e0f33172fbcecebddfccdf64c22685636a23936 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/mainboard/apple/macbook21/smihandler.c M src/mainboard/dell/optiplex_9010/smihandler.c M src/mainboard/emulation/qemu-q35/romstage.c M src/mainboard/google/auron/variants/auron_paine/spd/spd.c M src/mainboard/google/auron/variants/auron_yuna/spd/spd.c M src/mainboard/google/auron/variants/gandof/spd/spd.c M src/mainboard/google/auron/variants/lulu/spd/spd.c M src/mainboard/google/auron/variants/samus/spd/spd.c M src/mainboard/google/dedede/romstage.c M src/mainboard/google/dedede/variants/drawcia/gpio.c M src/mainboard/google/fizz/variants/endeavour/board.c M src/mainboard/google/hatch/romstage_spd_cbfs.c M src/mainboard/google/zork/smihandler.c M src/mainboard/google/zork/variants/dirinboz/variant.c M src/mainboard/google/zork/variants/gumboz/variant.c M src/mainboard/intel/dcp847ske/early_southbridge.c M src/mainboard/intel/elkhartlake_crb/romstage_fsp_params.c M src/mainboard/intel/jasperlake_rvp/romstage_fsp_params.c M src/mainboard/packardbell/ms2290/smihandler.c M src/mainboard/pcengines/apu2/romstage.c M src/mainboard/siemens/mc_apl1/variants/mc_apl1/mainboard.c M src/mainboard/siemens/mc_apl1/variants/mc_apl2/mainboard.c M src/mainboard/siemens/mc_apl1/variants/mc_apl3/mainboard.c M src/mainboard/siemens/mc_apl1/variants/mc_apl5/mainboard.c M src/mainboard/siemens/mc_apl1/variants/mc_apl6/mainboard.c 25 files changed, 1 insertion(+), 25 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/50524/1 diff --git a/src/mainboard/apple/macbook21/smihandler.c b/src/mainboard/apple/macbook21/smihandler.c index 8219d60..b96d948 100644 --- a/src/mainboard/apple/macbook21/smihandler.c +++ b/src/mainboard/apple/macbook21/smihandler.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <console/console.h> #include <cpu/x86/smm.h> #include <soc/nvs.h> #include <southbridge/intel/common/pmutil.h> diff --git a/src/mainboard/dell/optiplex_9010/smihandler.c b/src/mainboard/dell/optiplex_9010/smihandler.c index 1c7d328..3ed0d11 100644 --- a/src/mainboard/dell/optiplex_9010/smihandler.c +++ b/src/mainboard/dell/optiplex_9010/smihandler.c @@ -2,7 +2,6 @@ #include <stdint.h> #include <arch/io.h> -#include <console/console.h> #include <cpu/x86/smm.h> #include <superio/smsc/sch5545/sch5545.h> diff --git a/src/mainboard/emulation/qemu-q35/romstage.c b/src/mainboard/emulation/qemu-q35/romstage.c index c9bc339..ff06640 100644 --- a/src/mainboard/emulation/qemu-q35/romstage.c +++ b/src/mainboard/emulation/qemu-q35/romstage.c @@ -2,7 +2,6 @@ #include <arch/romstage.h> #include <cbmem.h> -#include <console/console.h> #include <southbridge/intel/i82801ix/i82801ix.h> #include <device/pci_ops.h> diff --git a/src/mainboard/google/auron/variants/auron_paine/spd/spd.c b/src/mainboard/google/auron/variants/auron_paine/spd/spd.c index 59e949a..1084b26 100644 --- a/src/mainboard/google/auron/variants/auron_paine/spd/spd.c +++ b/src/mainboard/google/auron/variants/auron_paine/spd/spd.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <console/console.h> #include <endian.h> #include <string.h> #include <soc/gpio.h> diff --git a/src/mainboard/google/auron/variants/auron_yuna/spd/spd.c b/src/mainboard/google/auron/variants/auron_yuna/spd/spd.c index 59e949a..1084b26 100644 --- a/src/mainboard/google/auron/variants/auron_yuna/spd/spd.c +++ b/src/mainboard/google/auron/variants/auron_yuna/spd/spd.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <console/console.h> #include <endian.h> #include <string.h> #include <soc/gpio.h> diff --git a/src/mainboard/google/auron/variants/gandof/spd/spd.c b/src/mainboard/google/auron/variants/gandof/spd/spd.c index 093a88c..a107632 100644 --- a/src/mainboard/google/auron/variants/gandof/spd/spd.c +++ b/src/mainboard/google/auron/variants/gandof/spd/spd.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <console/console.h> #include <endian.h> #include <string.h> #include <soc/gpio.h> diff --git a/src/mainboard/google/auron/variants/lulu/spd/spd.c b/src/mainboard/google/auron/variants/lulu/spd/spd.c index 67f71d6e..bb554d4 100644 --- a/src/mainboard/google/auron/variants/lulu/spd/spd.c +++ b/src/mainboard/google/auron/variants/lulu/spd/spd.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <console/console.h> #include <endian.h> #include <string.h> #include <soc/gpio.h> diff --git a/src/mainboard/google/auron/variants/samus/spd/spd.c b/src/mainboard/google/auron/variants/samus/spd/spd.c index 8ba76ac..43d1e54 100644 --- a/src/mainboard/google/auron/variants/samus/spd/spd.c +++ b/src/mainboard/google/auron/variants/samus/spd/spd.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <console/console.h> #include <endian.h> #include <string.h> #include <soc/gpio.h> diff --git a/src/mainboard/google/dedede/romstage.c b/src/mainboard/google/dedede/romstage.c index 02ebfac..f6a94ec 100644 --- a/src/mainboard/google/dedede/romstage.c +++ b/src/mainboard/google/dedede/romstage.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */ #include <baseboard/variants.h> -#include <console/console.h> #include <ec/google/chromeec/ec.h> #include <gpio.h> #include <memory_info.h> diff --git a/src/mainboard/google/dedede/variants/drawcia/gpio.c b/src/mainboard/google/dedede/variants/drawcia/gpio.c index a91a94e..863d289 100644 --- a/src/mainboard/google/dedede/variants/drawcia/gpio.c +++ b/src/mainboard/google/dedede/variants/drawcia/gpio.c @@ -3,7 +3,6 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <fw_config.h> -#include <console/console.h> #include <ec/google/chromeec/ec.h> /* Pad configuration in ramstage*/ diff --git a/src/mainboard/google/fizz/variants/endeavour/board.c b/src/mainboard/google/fizz/variants/endeavour/board.c index 0fdc914..3da8f22 100644 --- a/src/mainboard/google/fizz/variants/endeavour/board.c +++ b/src/mainboard/google/fizz/variants/endeavour/board.c @@ -1,6 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ + #include <baseboard/variants.h> -#include <console/console.h> #include <nhlt.h> #include <soc/nhlt.h> diff --git a/src/mainboard/google/hatch/romstage_spd_cbfs.c b/src/mainboard/google/hatch/romstage_spd_cbfs.c index f3c38bb..8a12d70 100644 --- a/src/mainboard/google/hatch/romstage_spd_cbfs.c +++ b/src/mainboard/google/hatch/romstage_spd_cbfs.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <baseboard/variants.h> -#include <console/console.h> #include <ec/google/chromeec/ec.h> #include <gpio.h> #include <memory_info.h> diff --git a/src/mainboard/google/zork/smihandler.c b/src/mainboard/google/zork/smihandler.c index 1c26d45..802487b 100644 --- a/src/mainboard/google/zork/smihandler.c +++ b/src/mainboard/google/zork/smihandler.c @@ -8,7 +8,6 @@ #include <soc/smi.h> #include <variant/ec.h> #include <variant/gpio.h> -#include <console/console.h> void mainboard_smi_gpi(u32 gpi_sts) { diff --git a/src/mainboard/google/zork/variants/dirinboz/variant.c b/src/mainboard/google/zork/variants/dirinboz/variant.c index ff57f50..4dd371a 100644 --- a/src/mainboard/google/zork/variants/dirinboz/variant.c +++ b/src/mainboard/google/zork/variants/dirinboz/variant.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */ #include <baseboard/variants.h> -#include <console/console.h> #include <device/device.h> #include <drivers/i2c/generic/chip.h> #include <soc/pci_devs.h> diff --git a/src/mainboard/google/zork/variants/gumboz/variant.c b/src/mainboard/google/zork/variants/gumboz/variant.c index ff57f50..4dd371a 100644 --- a/src/mainboard/google/zork/variants/gumboz/variant.c +++ b/src/mainboard/google/zork/variants/gumboz/variant.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */ #include <baseboard/variants.h> -#include <console/console.h> #include <device/device.h> #include <drivers/i2c/generic/chip.h> #include <soc/pci_devs.h> diff --git a/src/mainboard/intel/dcp847ske/early_southbridge.c b/src/mainboard/intel/dcp847ske/early_southbridge.c index c18aa83..d09da01 100644 --- a/src/mainboard/intel/dcp847ske/early_southbridge.c +++ b/src/mainboard/intel/dcp847ske/early_southbridge.c @@ -3,7 +3,6 @@ #include <bootblock_common.h> #include <stdint.h> #include <cf9_reset.h> -#include <console/console.h> #include <northbridge/intel/sandybridge/raminit_native.h> #include <southbridge/intel/bd82x6x/pch.h> diff --git a/src/mainboard/intel/elkhartlake_crb/romstage_fsp_params.c b/src/mainboard/intel/elkhartlake_crb/romstage_fsp_params.c index 3240834..809ea1f 100644 --- a/src/mainboard/intel/elkhartlake_crb/romstage_fsp_params.c +++ b/src/mainboard/intel/elkhartlake_crb/romstage_fsp_params.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <baseboard/variants.h> -#include <console/console.h> #include <soc/meminit.h> #include <soc/romstage.h> diff --git a/src/mainboard/intel/jasperlake_rvp/romstage_fsp_params.c b/src/mainboard/intel/jasperlake_rvp/romstage_fsp_params.c index 6516131..467dbc6 100644 --- a/src/mainboard/intel/jasperlake_rvp/romstage_fsp_params.c +++ b/src/mainboard/intel/jasperlake_rvp/romstage_fsp_params.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <baseboard/variants.h> -#include <console/console.h> #include <soc/meminit.h> #include <soc/romstage.h> #include "board_id.h" diff --git a/src/mainboard/packardbell/ms2290/smihandler.c b/src/mainboard/packardbell/ms2290/smihandler.c index 517c5e5..467e721 100644 --- a/src/mainboard/packardbell/ms2290/smihandler.c +++ b/src/mainboard/packardbell/ms2290/smihandler.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <console/console.h> #include <cpu/x86/smm.h> #include <device/pci_ops.h> #include <soc/nvs.h> diff --git a/src/mainboard/pcengines/apu2/romstage.c b/src/mainboard/pcengines/apu2/romstage.c index e0a63f0..09a0309 100644 --- a/src/mainboard/pcengines/apu2/romstage.c +++ b/src/mainboard/pcengines/apu2/romstage.c @@ -2,7 +2,6 @@ #include <stdint.h> #include <amdblocks/acpimmio.h> -#include <console/console.h> #include <device/pci_def.h> #include <device/pci_ops.h> #include <gpio.h> diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl1/mainboard.c b/src/mainboard/siemens/mc_apl1/variants/mc_apl1/mainboard.c index 5dbc4b9..769c9f0 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl1/mainboard.c +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl1/mainboard.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <bootstate.h> -#include <console/console.h> #include <device/pci_ids.h> #include <device/pci_ops.h> #include <gpio.h> diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl2/mainboard.c b/src/mainboard/siemens/mc_apl1/variants/mc_apl2/mainboard.c index 9cfd86f..e8cc2e6 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl2/mainboard.c +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl2/mainboard.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <bootstate.h> -#include <console/console.h> #include <device/pci_def.h> #include <device/pci_ids.h> #include <device/pci_ops.h> diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl3/mainboard.c b/src/mainboard/siemens/mc_apl1/variants/mc_apl3/mainboard.c index 22d2388..842f377 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl3/mainboard.c +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl3/mainboard.c @@ -3,7 +3,6 @@ #include <arch/io.h> #include <bootstate.h> #include <cf9_reset.h> -#include <console/console.h> #include <device/pci_def.h> #include <device/pci_ids.h> #include <device/pci_ops.h> diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl5/mainboard.c b/src/mainboard/siemens/mc_apl1/variants/mc_apl5/mainboard.c index 5a4c01f..7554fee 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl5/mainboard.c +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl5/mainboard.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <bootstate.h> -#include <console/console.h> #include <device/pci_def.h> #include <device/pci_ids.h> #include <device/pci_ops.h> diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl6/mainboard.c b/src/mainboard/siemens/mc_apl1/variants/mc_apl6/mainboard.c index 15c170b..1cecef7 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl6/mainboard.c +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl6/mainboard.c @@ -3,7 +3,6 @@ #include <arch/io.h> #include <bootstate.h> #include <cf9_reset.h> -#include <console/console.h> #include <device/pci_def.h> #include <device/pci_ids.h> #include <device/pci_ops.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/50524 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6e0f33172fbcecebddfccdf64c22685636a23936 Gerrit-Change-Number: 50524 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: src/drivers: Remove unused <console/console.h>
by HAOUAS Elyes (Code Review) 11 Feb '21

11 Feb '21

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/50523 ) Change subject: src/drivers: Remove unused <console/console.h> ...................................................................... src/drivers: Remove unused <console/console.h> Change-Id: I38d565f82d078cb75f74f8502fcafdedd907b97d Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/drivers/gfx/generic/generic.c M src/drivers/spi/adesto.c M src/drivers/spi/amic.c M src/drivers/spi/atmel.c M src/drivers/spi/eon.c M src/drivers/spi/gigadevice.c M src/drivers/spi/macronix.c M src/drivers/spi/spansion.c M src/drivers/spi/stmicro.c M src/drivers/wifi/generic/generic.c 10 files changed, 0 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/50523/1 diff --git a/src/drivers/gfx/generic/generic.c b/src/drivers/gfx/generic/generic.c index d3a4518..c07739f 100644 --- a/src/drivers/gfx/generic/generic.c +++ b/src/drivers/gfx/generic/generic.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <acpi/acpigen.h> -#include <console/console.h> #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> diff --git a/src/drivers/spi/adesto.c b/src/drivers/spi/adesto.c index 6538905..093199d 100644 --- a/src/drivers/spi/adesto.c +++ b/src/drivers/spi/adesto.c @@ -5,7 +5,6 @@ * based on winbond.c */ -#include <console/console.h> #include <commonlib/helpers.h> #include <spi_flash.h> #include <spi-generic.h> diff --git a/src/drivers/spi/amic.c b/src/drivers/spi/amic.c index 5e74616..dd16ace 100644 --- a/src/drivers/spi/amic.c +++ b/src/drivers/spi/amic.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */ -#include <console/console.h> #include <commonlib/helpers.h> #include <spi_flash.h> #include <spi-generic.h> diff --git a/src/drivers/spi/atmel.c b/src/drivers/spi/atmel.c index 4dcc5b5..2d191d9 100644 --- a/src/drivers/spi/atmel.c +++ b/src/drivers/spi/atmel.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */ -#include <console/console.h> #include <commonlib/helpers.h> #include <spi_flash.h> #include <spi-generic.h> diff --git a/src/drivers/spi/eon.c b/src/drivers/spi/eon.c index 1212c6b..015b500 100644 --- a/src/drivers/spi/eon.c +++ b/src/drivers/spi/eon.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */ -#include <console/console.h> #include <commonlib/helpers.h> #include <spi_flash.h> #include <spi-generic.h> diff --git a/src/drivers/spi/gigadevice.c b/src/drivers/spi/gigadevice.c index 6c5a167..15ad907 100644 --- a/src/drivers/spi/gigadevice.c +++ b/src/drivers/spi/gigadevice.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */ -#include <console/console.h> #include <commonlib/helpers.h> #include <spi_flash.h> #include <spi-generic.h> diff --git a/src/drivers/spi/macronix.c b/src/drivers/spi/macronix.c index f3f7e2d..69e7a9f 100644 --- a/src/drivers/spi/macronix.c +++ b/src/drivers/spi/macronix.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */ -#include <console/console.h> #include <commonlib/helpers.h> #include <spi_flash.h> #include <spi-generic.h> diff --git a/src/drivers/spi/spansion.c b/src/drivers/spi/spansion.c index fe0e265..05c4019 100644 --- a/src/drivers/spi/spansion.c +++ b/src/drivers/spi/spansion.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */ -#include <console/console.h> #include <commonlib/helpers.h> #include <spi_flash.h> #include <spi-generic.h> diff --git a/src/drivers/spi/stmicro.c b/src/drivers/spi/stmicro.c index 4cd8c1b..2f5a8b0 100644 --- a/src/drivers/spi/stmicro.c +++ b/src/drivers/spi/stmicro.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */ -#include <console/console.h> #include <commonlib/helpers.h> #include <spi_flash.h> #include <spi-generic.h> diff --git a/src/drivers/wifi/generic/generic.c b/src/drivers/wifi/generic/generic.c index 31c6816..5429f6b 100644 --- a/src/drivers/wifi/generic/generic.c +++ b/src/drivers/wifi/generic/generic.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <console/console.h> #include <device/device.h> #include <device/pci.h> #include <device/pci_def.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/50523 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I38d565f82d078cb75f74f8502fcafdedd907b97d Gerrit-Change-Number: 50523 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: src/device: Remove unused <console/console.h>
by HAOUAS Elyes (Code Review) 11 Feb '21

11 Feb '21

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/50522 ) Change subject: src/device: Remove unused <console/console.h> ...................................................................... src/device: Remove unused <console/console.h> Change-Id: I30ed9661d8e84be49d362baafbb2bc624952c287 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/device/resource_allocator_common.c 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/50522/1 diff --git a/src/device/resource_allocator_common.c b/src/device/resource_allocator_common.c index 202318b..1cb1895 100644 --- a/src/device/resource_allocator_common.c +++ b/src/device/resource_allocator_common.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <console/console.h> #include <device/device.h> struct pick_largest_state { -- To view, visit https://review.coreboot.org/c/coreboot/+/50522 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I30ed9661d8e84be49d362baafbb2bc624952c287 Gerrit-Change-Number: 50522 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: src/arch: Remove unused <console/console.h>
by HAOUAS Elyes (Code Review) 11 Feb '21

11 Feb '21

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/50521 ) Change subject: src/arch: Remove unused <console/console.h> ...................................................................... src/arch: Remove unused <console/console.h> Change-Id: Idb80b21bb5dc4b461f89a3414d51b7d98a8328d8 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/arch/arm/fit_payload.c M src/arch/x86/ebda.c 2 files changed, 0 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/50521/1 diff --git a/src/arch/arm/fit_payload.c b/src/arch/arm/fit_payload.c index 9777e3c..19f46a8 100644 --- a/src/arch/arm/fit_payload.c +++ b/src/arch/arm/fit_payload.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */ -#include <console/console.h> #include <bootmem.h> #include <program_loading.h> #include <fit.h> diff --git a/src/arch/x86/ebda.c b/src/arch/x86/ebda.c index ea2d9d3..0e3465a0 100644 --- a/src/arch/x86/ebda.c +++ b/src/arch/x86/ebda.c @@ -4,7 +4,6 @@ #include <acpi/acpi.h> #include <arch/ebda.h> #include <commonlib/endian.h> -#include <console/console.h> static void *get_ebda_start(void) { -- To view, visit https://review.coreboot.org/c/coreboot/+/50521 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idb80b21bb5dc4b461f89a3414d51b7d98a8328d8 Gerrit-Change-Number: 50521 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2021