Attention is currently required from: Michał Kopeć.
Michał Kopeć has uploaded a new patch set (#3). ( https://review.coreboot.org/c/coreboot/+/59807 )
Change subject: src/northbridge/amd/agesa/family14: Enable PARALLEL_MP
......................................................................
src/northbridge/amd/agesa/family14: Enable PARALLEL_MP
Disable LEGACY_SMP_INIT to enable PARALLEL_MP.
Tested on a PC Engines apu1 board.
Inspired by CB:59693
Signed-off-by: Michał Kopeć <michal.kopec(a)3mdeb.com>
Change-Id: I39a0779bdf115eebe31290591152b920acde773e
Signed-off-by: Michał Kopeć <michal.kopec(a)3mdeb.com>
---
M src/northbridge/amd/agesa/family14/Kconfig
M src/northbridge/amd/agesa/family14/northbridge.c
2 files changed, 16 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/59807/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/59807
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I39a0779bdf115eebe31290591152b920acde773e
Gerrit-Change-Number: 59807
Gerrit-PatchSet: 3
Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Michał Kopeć.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59807 )
Change subject: src/northbridge/amd/agesa/family14: Enable PARALLEL_MP
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59807/comment/e4defbf2_8216385e
PS1, Line 10:
Missing `TEST=...` with description how it was tested
--
To view, visit https://review.coreboot.org/c/coreboot/+/59807
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I39a0779bdf115eebe31290591152b920acde773e
Gerrit-Change-Number: 59807
Gerrit-PatchSet: 1
Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Comment-Date: Wed, 01 Dec 2021 13:48:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Michał Kopeć has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/59807 )
Change subject: src/northbridge/amd/agesa/family14: Enable PARALLEL_MP
......................................................................
src/northbridge/amd/agesa/family14: Enable PARALLEL_MP
src/northbridge/amd/agesa/family14: Enable PARALLEL_MP
Disable LEGACY_SMP_INIT to enable PARALLEL_MP.
Tested on a PC Engines apu1 board.
Inspired by CB:59693
Signed-off-by: Michał Kopeć <michal.kopec(a)3mdeb.com>
Change-Id: I39a0779bdf115eebe31290591152b920acde773e
---
M src/northbridge/amd/agesa/family14/Kconfig
M src/northbridge/amd/agesa/family14/northbridge.c
2 files changed, 16 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/59807/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/59807
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I39a0779bdf115eebe31290591152b920acde773e
Gerrit-Change-Number: 59807
Gerrit-PatchSet: 2
Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Michał Żygowski, Michał Kopeć.
Michał Kopeć has uploaded a new patch set (#7) to the change originally created by Michał Żygowski. ( https://review.coreboot.org/c/coreboot/+/52781 )
Change subject: cpu/amd/agesa/family14/model_14_init.c: create correct MTRR solution
......................................................................
cpu/amd/agesa/family14/model_14_init.c: create correct MTRR solution
Create the correct MTRR solution based on the physical address space
provided by RESOURCE_ALLOCATOR_V4. Previously CPU initialization did not
account for lost C6 DRAM storage MTRR during postcar frame creation.
The BSP on 2GB has been stripped from UC MTRR covering C6 DRAM and
overlapping with usable DRAM WB MTRR. However this UC MTRR remained on
APs which caused inconsistent MTRRs warning in Linux. Use generic MTRR
function to create correct MTRR solution that propagates to APs. This
also fixes the inconsistent MTRRs warning.
TEST=boot Debian with Linux 4.14 on apu1 2GB
Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Change-Id: If706f8851ed0b1d45729e81175d82abb1d9193be
Signed-off-by: Michał Kopeć <michal.kopec(a)3mdeb.com>
---
M src/cpu/amd/agesa/family14/model_14_init.c
1 file changed, 30 insertions(+), 40 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/52781/7
--
To view, visit https://review.coreboot.org/c/coreboot/+/52781
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If706f8851ed0b1d45729e81175d82abb1d9193be
Gerrit-Change-Number: 52781
Gerrit-PatchSet: 7
Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Nico Huber, Michał Żygowski.
Michał Kopeć has uploaded a new patch set (#7) to the change originally created by Michał Żygowski. ( https://review.coreboot.org/c/coreboot/+/52780 )
Change subject: northbridge/amd/agesa/family14: enable RESOURCE_ALLOCATOR_V4
......................................................................
northbridge/amd/agesa/family14: enable RESOURCE_ALLOCATOR_V4
TEST=boot Debian with Linux 4.14 on apu1 2GB
Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Change-Id: Ia01c5e238d53f719bb0d15e106517b99432a0c31
---
M src/northbridge/amd/agesa/family14/Kconfig
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/52780/7
--
To view, visit https://review.coreboot.org/c/coreboot/+/52780
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia01c5e238d53f719bb0d15e106517b99432a0c31
Gerrit-Change-Number: 52780
Gerrit-PatchSet: 7
Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Nico Huber, Michał Kopeć, Angel Pons, Felix Held.
Michał Kopeć has uploaded a new patch set (#6) to the change originally created by Michał Żygowski. ( https://review.coreboot.org/c/coreboot/+/52935 )
Change subject: nb/amd/agesa/family14/northbridge.c: Report missing resources
......................................................................
nb/amd/agesa/family14/northbridge.c: Report missing resources
Not all resources were being reported, add them.
TEST=boot Debian with Linux 4.14 on apu1 2GB
Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Change-Id: I0b1b5f585ff6e0c7aecad250a75600e0c76331e1
Signed-off-by: Michał Kopeć <michal.kopec(a)3mdeb.com>
---
M src/northbridge/amd/agesa/family14/northbridge.c
1 file changed, 48 insertions(+), 44 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/52935/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/52935
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0b1b5f585ff6e0c7aecad250a75600e0c76331e1
Gerrit-Change-Number: 52935
Gerrit-PatchSet: 6
Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: Jakub Czapiga, Julius Werner, Jan Dabros, Yu-Ping Wu.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59697 )
Change subject: libpayload: Add coreboot commonlib/bsd include path
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/59697
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I09f475d399ab785f3d3ffdb4b42950d2b397845e
Gerrit-Change-Number: 59697
Gerrit-PatchSet: 2
Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Jan Dabros <jsd(a)semihalf.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Jan Dabros <jsd(a)semihalf.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Wed, 01 Dec 2021 13:32:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/59806 )
Change subject: Documentation: Update SSH key procedure
......................................................................
Documentation: Update SSH key procedure
Use ed25519 keys because recent changes to RSA keys in OpenSSH are
making a mess.
Also update references to the Gerrit UI to match the current version.
Change-Id: Ib13836feb6968307d2c8b3022cb0c859dac89bb8
Signed-off-by: Patrick Georgi <patrick(a)coreboot.org>
---
M Documentation/tutorial/part2.md
1 file changed, 8 insertions(+), 21 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/59806/1
diff --git a/Documentation/tutorial/part2.md b/Documentation/tutorial/part2.md
index 964057e..f24b0b6 100644
--- a/Documentation/tutorial/part2.md
+++ b/Documentation/tutorial/part2.md
@@ -12,37 +12,24 @@
username for the account will be the username of the account you used to
sign-in with. (ex. your Google username).
-## Step 2a: Set up RSA Private/Public Key
+## Step 2a: Set up SSH keys
If you prefer to use an HTTP password instead, skip to Step 2b.
-For the most up-to-date instructions on how to set up SSH keys with Gerrit go to
-<https://gerrit-documentation.storage.googleapis.com/Documentation/2.14.2/us…>
-and follow the instructions there. Then, skip to Step 3.
-
-Additionally, that section of the Web site provides explanation on starting
-an ssh-agent, which may be particularly helpful for those who anticipate
-frequently uploading changes.
-
-If you instead prefer to have review.coreboot.org specific instructions,
-follow the steps below. Note that this particular section may have the
-most up-to-date instructions.
-
-If you do not have an RSA key set up on your account already (as is the case
+If you do not have an SSH key set up on your account already (as is the case
with a newly created account), follow the instructions below; otherwise,
doing so could overwrite an existing key.
-In the upper right corner, select your name and click on **Settings**.
-Select **SSH Public Keys** on the left-hand side.
-
-In a terminal, run `ssh-keygen` and confirm the default path `.ssh/id_rsa`.
+In a terminal, run `ssh-keygen -t ed25519` and confirm the default path
+`.ssh/id_ed25519`.
Make a passphrase -- remember this phrase. It will be needed whenever you use
-this RSA Public Key. **Note:** You might want to use a short password, or
+this public key. **Note:** You might want to use a short password, or
forego the password altogether as you will be using it very often.
-Open `id_rsa.pub`, copy all contents and paste into the textbox under
-"Add SSH Public Key" in the https://review.coreboot.org webpage.
+Copy the content of `.ssh/id_ed25519.pub` (notice the ".pub" suffix
+as you need to send the public key) into the textbox "New SSH Key" at
+https://review.coreboot.org/settings/#SSHKeys and save it.
## Step 2b: Set up an HTTP Password
--
To view, visit https://review.coreboot.org/c/coreboot/+/59806
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib13836feb6968307d2c8b3022cb0c859dac89bb8
Gerrit-Change-Number: 59806
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-MessageType: newchange