Attention is currently required from: Maulik V Vaghela, Tim Wawrzynczak, Paul Menzel, Reka Norman, Rizwan Qureshi, Subrata Banik, Sridhar Siricilla, Krishna P Bhat D, Patrick Rudolph.
Usha P has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59836 )
Change subject: soc/intel/alderlake: Add support for ADL-N CPU Type
......................................................................
Patch Set 3:
(1 comment)
File src/soc/intel/alderlake/cpu.c:
PS3:
> For another patch: do we still need this function? Or should we rely on the Kconfigs, e.g. […]
For another patch: do we still need this function?
>> Which patch are referring here ?
To get LPM Mask for ADL-N, we are adding a case here in the function.
Other things would be taken care by the Kconfig
--
To view, visit https://review.coreboot.org/c/coreboot/+/59836
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If2917ac356fd80f84bcaf70ed710d329e77f7a6d
Gerrit-Change-Number: 59836
Gerrit-PatchSet: 3
Gerrit-Owner: Usha P <usha.p(a)intel.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Mon, 06 Dec 2021 09:27:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Michał Kopeć.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59870 )
Change subject: northbridge/amd/pi/00730F01/northbridge.c: remove unneded global variables
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/59870
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I20a47f967093ef91355377c164656cabadc30fe6
Gerrit-Change-Number: 59870
Gerrit-PatchSet: 5
Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Comment-Date: Mon, 06 Dec 2021 09:24:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Michał Żygowski, Michał Kopeć, Paul Menzel, Angel Pons.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59808 )
Change subject: northbridge/amd/pi/00730F01: enable PARALLEL_MP
......................................................................
Patch Set 11:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59808/comment/c276ade2_42b8f05d
PS4, Line 12: TEST=Boot on PC Engines apu3
> Yes, that's with the serial console enabled and with loglevel 7
Hmm it could just be that the new code is just less verbose instead of actually faster. Could you try with serial console disabled?
--
To view, visit https://review.coreboot.org/c/coreboot/+/59808
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib49e7d3f5956ac7831664d50db5f233b70aa54db
Gerrit-Change-Number: 59808
Gerrit-PatchSet: 11
Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Mon, 06 Dec 2021 09:23:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michał Kopeć <michal.kopec(a)3mdeb.com>
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak, Ravindra, Arthur Heymans, Krishna P Bhat D, Patrick Rudolph, Ravindra N.
Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59895 )
Change subject: soc/intel/cse: config to enable oem key manifest
......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59895/comment/c5d38d49_6386dbc7
PS3, Line 13: ipu
OEM KM has Audio FW's key hash. So,CSE uses this information to authenticate Audio FW. The IPU is not dependent on OEM KM. Please update the commit with Kernel logs indicating audio authentication.
--
To view, visit https://review.coreboot.org/c/coreboot/+/59895
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3620adb2898efc002104e0ba8b2afd219c31f230
Gerrit-Change-Number: 59895
Gerrit-PatchSet: 4
Gerrit-Owner: Ravindra <ravindra(a)intel.com>
Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Ravindra N <ravindra(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Ravindra <ravindra(a)intel.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: Ravindra N <ravindra(a)intel.corp-partner.google.com>
Gerrit-Comment-Date: Mon, 06 Dec 2021 09:19:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Jakub Czapiga, Julius Werner.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59494 )
Change subject: libpayload/libc/fmap: Implement new FlashMap API
......................................................................
Patch Set 4:
(1 comment)
File payloads/libpayload/include/fmap.h:
https://review.coreboot.org/c/coreboot/+/59494/comment/866d1eb0_7d194703
PS4, Line 6: #include <commonlib/bsd/cb_err.h>
Before using commonlib in exported headers, you'll also need to ensure that libpayload-using payloads can find it. We have multiple ways of using libpayload:
- a tree generated by "make install" needs to contain these files as a copy
- lpgcc can work both in such a tree and from a source tree with build/ and needs to figure out the right locations
Food for thought:
It _might_ be easier to make this more regular by copying commonlib headers into build/ somewhere (in a similar layout to what will be used in a "make install" tree) as an early build step and then just always use the same path.
It might be even easier to just copy all headers into build/ early so that the only difference between using build/ and using "make install" is the base directory.
--
To view, visit https://review.coreboot.org/c/coreboot/+/59494
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idbf9016ce73aa58e17f3ee19920ab83dc6c25abb
Gerrit-Change-Number: 59494
Gerrit-PatchSet: 4
Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Julius Werner <jwerner(a)chromium.org>
Gerrit-CC: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Mon, 06 Dec 2021 08:41:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak, Sridhar Siricilla, Arthur Heymans, Krishna P Bhat D, Patrick Rudolph, Ravindra N.
Ravindra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59895 )
Change subject: soc/intel/cse: config to enable oem key manifest
......................................................................
Patch Set 4:
(2 comments)
Patchset:
PS4:
Please review the changes
File src/soc/intel/common/block/cse/Kconfig:
https://review.coreboot.org/c/coreboot/+/59895/comment/767ace15_18724529
PS3, Line 184: Name OEM KM file
> name *of*
Ack
--
To view, visit https://review.coreboot.org/c/coreboot/+/59895
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3620adb2898efc002104e0ba8b2afd219c31f230
Gerrit-Change-Number: 59895
Gerrit-PatchSet: 4
Gerrit-Owner: Ravindra <ravindra(a)intel.com>
Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Ravindra N <ravindra(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: Ravindra N <ravindra(a)intel.corp-partner.google.com>
Gerrit-Comment-Date: Mon, 06 Dec 2021 08:36:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak, Ravindra, Sridhar Siricilla, Krishna P Bhat D, Patrick Rudolph, Ravindra N.
Hello build bot (Jenkins), Tim Wawrzynczak, Sridhar Siricilla, Krishna P Bhat D, Patrick Rudolph, Ravindra N,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/59895
to look at the new patch set (#4).
Change subject: soc/intel/cse: config to enable oem key manifest
......................................................................
soc/intel/cse: config to enable oem key manifest
CB change will enable the CSE region sub-partition OEMP,
where the OEMP binary will be stitched.
BUG=b:207820413
TEST: Boot to kernel and check for the ipu authentication
is successful
localhost ~ # dmesg | grep -i ipu
[ 9.206568] intel-ipu6 intel-ipu: IPU in secure mode
[ 9.218917] intel-ipu6 intel-ipu: IPC reset done
[ 9.226160] intel-ipu6 intel-ipu: cpd file name: intel/ipu6ep_fw.bin
[ 9.265134] intel-ipu6 intel-ipu: FW version: 20201224
[ 9.298977] intel-ipu6 intel-ipu: Sending BOOT_LOAD to CSE
[ 9.314555] intel-ipu6 intel-ipu: Sending AUTHENTICATE_RUN to CSE
[ 9.390078] intel-ipu6 intel-ipu: CSE authenticate_run done
[ 9.396530] intel-ipu6 intel-ipu: IPU driver version 1.0
Cq-Depend: chromium:3291463 config.baseboard.brya: config to support oem key manifest
| https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-o…
Signed-off-by: Ravindra N <ravindra(a)intel.corp-partner.google.com>
Change-Id: I3620adb2898efc002104e0ba8b2afd219c31f230
---
M src/soc/intel/alderlake/Makefile.inc
M src/soc/intel/common/block/cse/Kconfig
2 files changed, 5 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/59895/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/59895
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3620adb2898efc002104e0ba8b2afd219c31f230
Gerrit-Change-Number: 59895
Gerrit-PatchSet: 4
Gerrit-Owner: Ravindra <ravindra(a)intel.com>
Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Ravindra N <ravindra(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Ravindra <ravindra(a)intel.com>
Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: Ravindra N <ravindra(a)intel.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Jakub Czapiga, Julius Werner, Jan Dabros.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59843 )
Change subject: libpayload/Makefile: Improve object files list creation
......................................................................
Patch Set 1:
(2 comments)
File payloads/libpayload/Makefile:
https://review.coreboot.org/c/coreboot/+/59843/comment/e2d80efb_73769d14
PS1, Line 322: # $1 lib name
the toplevel Makefile uses "stage name" here. Potential follow up: change both to call it "class name" as that's the generic name for that.
https://review.coreboot.org/c/coreboot/+/59843/comment/0f95891e_4a697cb1
PS1, Line 373: cscope -bR -s$(coreboottop)/src/commonlib/bsd
This seems to be unrelated?
--
To view, visit https://review.coreboot.org/c/coreboot/+/59843
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If1280c0a3f7e99aad2ecf8a0379a98af31ccefc3
Gerrit-Change-Number: 59843
Gerrit-PatchSet: 1
Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Jan Dabros <jsd(a)semihalf.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Jan Dabros <jsd(a)semihalf.com>
Gerrit-Comment-Date: Mon, 06 Dec 2021 08:34:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak, Ravindra, Sridhar Siricilla, Krishna P Bhat D, Patrick Rudolph, Ravindra N.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59895 )
Change subject: soc/intel/cse: config to enable oem key manifest
......................................................................
Patch Set 3:
(1 comment)
File src/soc/intel/common/block/cse/Kconfig:
https://review.coreboot.org/c/coreboot/+/59895/comment/9d356c23_b19d461b
PS3, Line 184: Name OEM KM file
name *of*
--
To view, visit https://review.coreboot.org/c/coreboot/+/59895
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3620adb2898efc002104e0ba8b2afd219c31f230
Gerrit-Change-Number: 59895
Gerrit-PatchSet: 3
Gerrit-Owner: Ravindra <ravindra(a)intel.com>
Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: Ravindra N <ravindra(a)intel.corp-partner.google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Ravindra <ravindra(a)intel.com>
Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: Ravindra N <ravindra(a)intel.corp-partner.google.com>
Gerrit-Comment-Date: Mon, 06 Dec 2021 08:32:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/59677 )
Change subject: Documentation: Add template for deprecation notices
......................................................................
Documentation: Add template for deprecation notices
Change-Id: Ia2cc4f799804c7d56db572823246c487cd19a726
Signed-off-by: Patrick Georgi <patrick(a)coreboot.org>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/59677
Reviewed-by: Felix Singer <felixsinger(a)posteo.net>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
---
M Documentation/releases/index.md
A Documentation/releases/templates.md
2 files changed, 88 insertions(+), 0 deletions(-)
Approvals:
build bot (Jenkins): Verified
Felix Singer: Looks good to me, approved
diff --git a/Documentation/releases/index.md b/Documentation/releases/index.md
index 16d2fef..90e8e40 100644
--- a/Documentation/releases/index.md
+++ b/Documentation/releases/index.md
@@ -23,6 +23,11 @@
* [checklist](checklist.md)
+For release related communications consider using a template so everything
+important is taken care of.
+
+* [templates](templates.md)
+
Upcoming release
----------------
diff --git a/Documentation/releases/templates.md b/Documentation/releases/templates.md
new file mode 100644
index 0000000..86973eb
--- /dev/null
+++ b/Documentation/releases/templates.md
@@ -0,0 +1,83 @@
+# Communication templates related to release management
+
+## Deprecation notices
+
+Deprecation notices are part of release notes to act as a warning: at some
+point in the future some part of coreboot gets removed. That point must be
+at least 6 months after the release of the notice and it must be right after
+some release: That is, the specified release must still contain the part in
+question while one git commit later it might be removed.
+
+The usual reason is progress: Infrastructure module X has been replaced by
+infrastructure module X+1. Removing X helps keep the sources manageable
+and likely opens opportunities to improve the codebase even more.
+Sometimes everything using some module has been converted to its successor
+already and it's natural for such modules to be removed. Even then it might
+be useful to add an entry to the release notes to make everybody aware of
+such a change, for maintainers of incomplete boards that they might keep in
+their local trees and also to give credit to the developers of that change.
+
+However this template isn't about such cases. Sometimes the tree contains
+mainboards that rely on X and can't be easily migrated to X+1, often because
+no active developer has access to these mainboards, and that is where this
+type of deprecation notice comes in:
+
+A deprecation notice shall outline what is being removed, when it is planned
+for removal (always directly _after_ a future release so it remains clear when
+something is part of coreboot and when it isn't anymore) and which devices
+would be affected at the time of writing. Since past deprecation notices have
+been read as "we plan to remove mainboards A, B, and C", sparking outrage
+with the devoted users of A, B, or C, some care is necessary to make clear
+which parts are slated for removal and which parts are merely consequences
+if no action is taken. Or put differently: It should be obvious that besides
+the deprecation plan, there is a call to action to save a couple of devices
+from becoming officially unsupported.
+
+As such, consider the following template when announcing a deprecation:
+
+### The Thing to remove
+
+A short description of the Thing slated for removal.
+
+A short rationale why it's being removed (e.g. new and better Thing exists
+in parallel; new Thing already demonstrated to work in this many releases;
+removing Thing enables this or that improvement)
+
+Timeline: Announced here, Thing will be removed right after the release X
+months out (where X >= 6)
+
+#### Call to action
+
+Removing Thing requires work on a number of (boards, chipsets, …) that didn't
+make the switch yet. The work approximately looks like this: (e.g. pointers to
+commits where a board has been successfully migrated from Thing to new Thing).
+
+Working on migrating away from Thing involves (hardware components, coreboot
+systems, …) 1, 2, and 3. It's difficult to do on the remaining devices because
+...
+
+Parts of the tree that need work to become independent of Thing.
+ - chipset A
+ - board A1
+ - board A2
+ - chipset B
+ - board B1
+
+We prefer to move them along, but if we don't see any maintenance in our tree
+we'll have to assume that there's no more interest in these platforms. As a
+consequence these devices either have to work without Thing by the removal
+date or they will be removed together with Thing. (side note: these removals
+aren't the law, so if there's work in progress to move boards off X and a
+roadmap that makes it probable to succeed, just not within the announced
+deprecation timeline, we can still decide to postpone the actual removal by
+one release. This needn't be put in the release notes themselves though or
+it might encourage people to look for simple escape hatches.)
+
+(If there are developers offering to write patches: )
+There are developers interested in helping move these forward but they can't
+test any changes for lack of equipment. If you have an affected device and
+can run tests on it, please reach out to developers α, β, and γ.
+
+(Otherwise maybe something more generic like this: )
+If you want to take this on, the coreboot developer community will try to
+help you: Reach out through one of our [forums](../community/forums.md).
--
To view, visit https://review.coreboot.org/c/coreboot/+/59677
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia2cc4f799804c7d56db572823246c487cd19a726
Gerrit-Change-Number: 59677
Gerrit-PatchSet: 6
Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: awokd(a)danwin1210.me
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Branden Waldner <scruffy99(a)gmail.com>
Gerrit-CC: Martin Roth <martinroth(a)google.com>
Gerrit-MessageType: merged