coreboot-gerrit December 2021

coreboot-gerrit@coreboot.org

1 participants
5525 discussions

Change in coreboot[master]: libpayload/Makefile: Improve object files list creation
by Patrick Georgi (Code Review) 06 Dec '21

06 Dec '21

Attention is currently required from: Jakub Czapiga, Julius Werner, Jan Dabros. Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59843 ) Change subject: libpayload/Makefile: Improve object files list creation ...................................................................... Patch Set 1: (2 comments) File payloads/libpayload/Makefile: https://review.coreboot.org/c/coreboot/+/59843/comment/e2d80efb_73769d14 PS1, Line 322: # $1 lib name the toplevel Makefile uses "stage name" here. Potential follow up: change both to call it "class name" as that's the generic name for that. https://review.coreboot.org/c/coreboot/+/59843/comment/0f95891e_4a697cb1 PS1, Line 373: cscope -bR -s$(coreboottop)/src/commonlib/bsd This seems to be unrelated? -- To view, visit https://review.coreboot.org/c/coreboot/+/59843 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If1280c0a3f7e99aad2ecf8a0379a98af31ccefc3 Gerrit-Change-Number: 59843 Gerrit-PatchSet: 1 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Jan Dabros <jsd(a)semihalf.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Jan Dabros <jsd(a)semihalf.com> Gerrit-Comment-Date: Mon, 06 Dec 2021 08:34:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/cse: config to enable oem key manifest
by Arthur Heymans (Code Review) 06 Dec '21

06 Dec '21

Attention is currently required from: Tim Wawrzynczak, Ravindra, Sridhar Siricilla, Krishna P Bhat D, Patrick Rudolph, Ravindra N. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59895 ) Change subject: soc/intel/cse: config to enable oem key manifest ...................................................................... Patch Set 3: (1 comment) File src/soc/intel/common/block/cse/Kconfig: https://review.coreboot.org/c/coreboot/+/59895/comment/9d356c23_b19d461b PS3, Line 184: Name OEM KM file name *of* -- To view, visit https://review.coreboot.org/c/coreboot/+/59895 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3620adb2898efc002104e0ba8b2afd219c31f230 Gerrit-Change-Number: 59895 Gerrit-PatchSet: 3 Gerrit-Owner: Ravindra <ravindra(a)intel.com> Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Ravindra N <ravindra(a)intel.corp-partner.google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Ravindra <ravindra(a)intel.com> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Ravindra N <ravindra(a)intel.corp-partner.google.com> Gerrit-Comment-Date: Mon, 06 Dec 2021 08:32:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Documentation: Add template for deprecation notices
by Patrick Georgi (Code Review) 06 Dec '21

06 Dec '21

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/59677 ) Change subject: Documentation: Add template for deprecation notices ...................................................................... Documentation: Add template for deprecation notices Change-Id: Ia2cc4f799804c7d56db572823246c487cd19a726 Signed-off-by: Patrick Georgi <patrick(a)coreboot.org> Reviewed-on: https://review.coreboot.org/c/coreboot/+/59677 Reviewed-by: Felix Singer <felixsinger(a)posteo.net> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M Documentation/releases/index.md A Documentation/releases/templates.md 2 files changed, 88 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved diff --git a/Documentation/releases/index.md b/Documentation/releases/index.md index 16d2fef..90e8e40 100644 --- a/Documentation/releases/index.md +++ b/Documentation/releases/index.md @@ -23,6 +23,11 @@ * [checklist](checklist.md) +For release related communications consider using a template so everything +important is taken care of. + +* [templates](templates.md) + Upcoming release ---------------- diff --git a/Documentation/releases/templates.md b/Documentation/releases/templates.md new file mode 100644 index 0000000..86973eb --- /dev/null +++ b/Documentation/releases/templates.md @@ -0,0 +1,83 @@ +# Communication templates related to release management + +## Deprecation notices + +Deprecation notices are part of release notes to act as a warning: at some +point in the future some part of coreboot gets removed. That point must be +at least 6 months after the release of the notice and it must be right after +some release: That is, the specified release must still contain the part in +question while one git commit later it might be removed. + +The usual reason is progress: Infrastructure module X has been replaced by +infrastructure module X+1. Removing X helps keep the sources manageable +and likely opens opportunities to improve the codebase even more. +Sometimes everything using some module has been converted to its successor +already and it's natural for such modules to be removed. Even then it might +be useful to add an entry to the release notes to make everybody aware of +such a change, for maintainers of incomplete boards that they might keep in +their local trees and also to give credit to the developers of that change. + +However this template isn't about such cases. Sometimes the tree contains +mainboards that rely on X and can't be easily migrated to X+1, often because +no active developer has access to these mainboards, and that is where this +type of deprecation notice comes in: + +A deprecation notice shall outline what is being removed, when it is planned +for removal (always directly _after_ a future release so it remains clear when +something is part of coreboot and when it isn't anymore) and which devices +would be affected at the time of writing. Since past deprecation notices have +been read as "we plan to remove mainboards A, B, and C", sparking outrage +with the devoted users of A, B, or C, some care is necessary to make clear +which parts are slated for removal and which parts are merely consequences +if no action is taken. Or put differently: It should be obvious that besides +the deprecation plan, there is a call to action to save a couple of devices +from becoming officially unsupported. + +As such, consider the following template when announcing a deprecation: + +### The Thing to remove + +A short description of the Thing slated for removal. + +A short rationale why it's being removed (e.g. new and better Thing exists +in parallel; new Thing already demonstrated to work in this many releases; +removing Thing enables this or that improvement) + +Timeline: Announced here, Thing will be removed right after the release X +months out (where X >= 6) + +#### Call to action + +Removing Thing requires work on a number of (boards, chipsets, …) that didn't +make the switch yet. The work approximately looks like this: (e.g. pointers to +commits where a board has been successfully migrated from Thing to new Thing). + +Working on migrating away from Thing involves (hardware components, coreboot +systems, …) 1, 2, and 3. It's difficult to do on the remaining devices because +... + +Parts of the tree that need work to become independent of Thing. + - chipset A + - board A1 + - board A2 + - chipset B + - board B1 + +We prefer to move them along, but if we don't see any maintenance in our tree +we'll have to assume that there's no more interest in these platforms. As a +consequence these devices either have to work without Thing by the removal +date or they will be removed together with Thing. (side note: these removals +aren't the law, so if there's work in progress to move boards off X and a +roadmap that makes it probable to succeed, just not within the announced +deprecation timeline, we can still decide to postpone the actual removal by +one release. This needn't be put in the release notes themselves though or +it might encourage people to look for simple escape hatches.) + +(If there are developers offering to write patches: ) +There are developers interested in helping move these forward but they can't +test any changes for lack of equipment. If you have an affected device and +can run tests on it, please reach out to developers α, β, and γ. + +(Otherwise maybe something more generic like this: ) +If you want to take this on, the coreboot developer community will try to +help you: Reach out through one of our [forums](../community/forums.md). -- To view, visit https://review.coreboot.org/c/coreboot/+/59677 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia2cc4f799804c7d56db572823246c487cd19a726 Gerrit-Change-Number: 59677 Gerrit-PatchSet: 6 Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: awokd(a)danwin1210.me Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Branden Waldner <scruffy99(a)gmail.com> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: Documentation: Update SSH key procedure
by Patrick Georgi (Code Review) 06 Dec '21

06 Dec '21

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/59806 ) Change subject: Documentation: Update SSH key procedure ...................................................................... Documentation: Update SSH key procedure Use ed25519 keys because recent changes to RSA keys in OpenSSH are making a mess. Also update references to the Gerrit UI to match the current version. Change-Id: Ib13836feb6968307d2c8b3022cb0c859dac89bb8 Signed-off-by: Patrick Georgi <patrick(a)coreboot.org> Reviewed-on: https://review.coreboot.org/c/coreboot/+/59806 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Paul Menzel <paulepanter(a)mailbox.org> Reviewed-by: Felix Singer <felixsinger(a)posteo.net> --- M Documentation/tutorial/part2.md 1 file changed, 8 insertions(+), 21 deletions(-) Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Felix Singer: Looks good to me, approved diff --git a/Documentation/tutorial/part2.md b/Documentation/tutorial/part2.md index 964057e..f24b0b6 100644 --- a/Documentation/tutorial/part2.md +++ b/Documentation/tutorial/part2.md @@ -12,37 +12,24 @@ username for the account will be the username of the account you used to sign-in with. (ex. your Google username). -## Step 2a: Set up RSA Private/Public Key +## Step 2a: Set up SSH keys If you prefer to use an HTTP password instead, skip to Step 2b. -For the most up-to-date instructions on how to set up SSH keys with Gerrit go to -<https://gerrit-documentation.storage.googleapis.com/Documentation/2.14.2/us…> -and follow the instructions there. Then, skip to Step 3. - -Additionally, that section of the Web site provides explanation on starting -an ssh-agent, which may be particularly helpful for those who anticipate -frequently uploading changes. - -If you instead prefer to have review.coreboot.org specific instructions, -follow the steps below. Note that this particular section may have the -most up-to-date instructions. - -If you do not have an RSA key set up on your account already (as is the case +If you do not have an SSH key set up on your account already (as is the case with a newly created account), follow the instructions below; otherwise, doing so could overwrite an existing key. -In the upper right corner, select your name and click on **Settings**. -Select **SSH Public Keys** on the left-hand side. - -In a terminal, run `ssh-keygen` and confirm the default path `.ssh/id_rsa`. +In a terminal, run `ssh-keygen -t ed25519` and confirm the default path +`.ssh/id_ed25519`. Make a passphrase -- remember this phrase. It will be needed whenever you use -this RSA Public Key. **Note:** You might want to use a short password, or +this public key. **Note:** You might want to use a short password, or forego the password altogether as you will be using it very often. -Open `id_rsa.pub`, copy all contents and paste into the textbox under -"Add SSH Public Key" in the https://review.coreboot.org webpage. +Copy the content of `.ssh/id_ed25519.pub` (notice the ".pub" suffix +as you need to send the public key) into the textbox "New SSH Key" at +https://review.coreboot.org/settings/#SSHKeys and save it. ## Step 2b: Set up an HTTP Password -- To view, visit https://review.coreboot.org/c/coreboot/+/59806 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib13836feb6968307d2c8b3022cb0c859dac89bb8 Gerrit-Change-Number: 59806 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: cbfstool: Fix offset calculation for aligned files
by Patrick Georgi (Code Review) 06 Dec '21

06 Dec '21

Attention is currently required from: Raul Rangel, Julius Werner, Tim Wawrzynczak. Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59877 ) Change subject: cbfstool: Fix offset calculation for aligned files ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: Thanks, it's already much clearer in the end, even with the stated remaining deficiencies. My main proposal would have been to split it up in smaller commits to ease review (e.g. moving the type argument to param.type, the if(A) {if(B) {...}} -> if(A && B) {...} change once the other part in if(A) is gone). OTOH I'm through now and if others don't see an issue with that during review, I'm not sure you need to bother. I'd give this +2, but I'd also appreciate a second opinion, so waiting for another day or two before upgrading my review score. -- To view, visit https://review.coreboot.org/c/coreboot/+/59877 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia49a585988f7a74944a6630b77b3ebd79b3a9897 Gerrit-Change-Number: 59877 Gerrit-PatchSet: 2 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Comment-Date: Mon, 06 Dec 2021 08:12:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Documentation: Update SSH key procedure
by Felix Singer (Code Review) 06 Dec '21

06 Dec '21

Attention is currently required from: Patrick Georgi. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59806 ) Change subject: Documentation: Update SSH key procedure ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/59806 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib13836feb6968307d2c8b3022cb0c859dac89bb8 Gerrit-Change-Number: 59806 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Comment-Date: Mon, 06 Dec 2021 08:04:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Documentation: Add template for deprecation notices
by Felix Singer (Code Review) 06 Dec '21

06 Dec '21

Attention is currently required from: Patrick Georgi, Martin Roth, David Hendricks. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59677 ) Change subject: Documentation: Add template for deprecation notices ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/59677 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia2cc4f799804c7d56db572823246c487cd19a726 Gerrit-Change-Number: 59677 Gerrit-PatchSet: 5 Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: awokd(a)danwin1210.me Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Branden Waldner <scruffy99(a)gmail.com> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Comment-Date: Mon, 06 Dec 2021 07:58:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Documentation: Add template for deprecation notices
by Patrick Georgi (Code Review) 06 Dec '21

06 Dec '21

Attention is currently required from: Martin Roth, David Hendricks. Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59677 ) Change subject: Documentation: Add template for deprecation notices ...................................................................... Patch Set 5: (1 comment) File Documentation/releases/templates.md: https://review.coreboot.org/c/coreboot/+/59677/comment/0013b9b1_c7d46b14 PS4, Line 25: line out > outline What was I thinking? Thanks, done. -- To view, visit https://review.coreboot.org/c/coreboot/+/59677 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia2cc4f799804c7d56db572823246c487cd19a726 Gerrit-Change-Number: 59677 Gerrit-PatchSet: 5 Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: awokd(a)danwin1210.me Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Branden Waldner <scruffy99(a)gmail.com> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Comment-Date: Mon, 06 Dec 2021 07:57:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: David Hendricks <david.hendricks(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Documentation: Add template for deprecation notices
by Patrick Georgi (Code Review) 06 Dec '21

06 Dec '21

Attention is currently required from: Patrick Georgi, Martin Roth. Hello Felix Singer, Mike Banon, build bot (Jenkins), awokd(a)danwin1210.me, David Hendricks, Paul Menzel, Angel Pons, Arthur Heymans, Mike Banon, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/59677 to look at the new patch set (#5). Change subject: Documentation: Add template for deprecation notices ...................................................................... Documentation: Add template for deprecation notices Change-Id: Ia2cc4f799804c7d56db572823246c487cd19a726 Signed-off-by: Patrick Georgi <patrick(a)coreboot.org> --- M Documentation/releases/index.md A Documentation/releases/templates.md 2 files changed, 88 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/59677/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/59677 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia2cc4f799804c7d56db572823246c487cd19a726 Gerrit-Change-Number: 59677 Gerrit-PatchSet: 5 Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: awokd(a)danwin1210.me Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Branden Waldner <scruffy99(a)gmail.com> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: [WIP]soc/intel/adl: Enable NPK for ADL
by Maulik V Vaghela (Code Review) 06 Dec '21

06 Dec '21

Maulik V Vaghela has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/59896 ) Change subject: [WIP]soc/intel/adl: Enable NPK for ADL ...................................................................... [WIP]soc/intel/adl: Enable NPK for ADL Change-Id: I2b716023bbac669ddcbccd510d47822c95d2212e Signed-off-by: MAULIK V VAGHELA <maulik.v.vaghela(a)intel.com> --- M src/soc/intel/alderlake/Kconfig M src/soc/intel/alderlake/romstage/fsp_params.c 2 files changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/59896/1 diff --git a/src/soc/intel/alderlake/Kconfig b/src/soc/intel/alderlake/Kconfig index 9fe2668..5f1cd90 100644 --- a/src/soc/intel/alderlake/Kconfig +++ b/src/soc/intel/alderlake/Kconfig @@ -99,6 +99,7 @@ select UDELAY_TSC select UDK_202005_BINDING select DISPLAY_FSP_VERSION_INFO + select SOC_INTEL_DEBUG_CONSENT config ALDERLAKE_CAR_ENHANCED_NEM bool diff --git a/src/soc/intel/alderlake/romstage/fsp_params.c b/src/soc/intel/alderlake/romstage/fsp_params.c index 2d63141..8614d03 100644 --- a/src/soc/intel/alderlake/romstage/fsp_params.c +++ b/src/soc/intel/alderlake/romstage/fsp_params.c @@ -320,6 +320,9 @@ /* Set debug probe type */ m_cfg->PlatformDebugConsent = CONFIG_SOC_INTEL_ALDERLAKE_DEBUG_CONSENT; + m_cfg->PchTraceHubMode = 2; + m_cfg->CpuTraceHubMode = 2; + /* CrashLog config */ m_cfg->CpuCrashLogDevice = CONFIG(SOC_INTEL_CRASHLOG) && is_devfn_enabled(SA_DEVFN_TMT); m_cfg->CpuCrashLogEnable = m_cfg->CpuCrashLogDevice; -- To view, visit https://review.coreboot.org/c/coreboot/+/59896 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2b716023bbac669ddcbccd510d47822c95d2212e Gerrit-Change-Number: 59896 Gerrit-PatchSet: 1 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-MessageType: newchange

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2021