coreboot-gerrit December 2021

coreboot-gerrit@coreboot.org

1 participants
5525 discussions

Change in coreboot[master]: tests: Disable -Wsource-mgr for clang
by Julius Werner (Code Review) 06 Dec '21

06 Dec '21

Attention is currently required from: Jakub Czapiga. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59814 ) Change subject: tests: Disable -Wsource-mgr for clang ...................................................................... Patch Set 1: (1 comment) File tests/Makefile.inc: https://review.coreboot.org/c/coreboot/+/59814/comment/ccaa3862_4b5d8cb4 PS1, Line 48: -Wno-source-mgr > It should probably be enclosed in check for correct version of clang. […] Right, I thought it did that already, forgot that it needs an extra flag. GCC just seems(?) to ignore all unknown -W... by default. -- To view, visit https://review.coreboot.org/c/coreboot/+/59814 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie49c9eef3c74592c068c899c6717621dbcb9f609 Gerrit-Change-Number: 59814 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Comment-Date: Mon, 06 Dec 2021 17:27:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: tests: Disable -Wmain-return-type for clang
by Julius Werner (Code Review) 06 Dec '21

06 Dec '21

Hello build bot (Jenkins), Jakub Czapiga, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/59815 to look at the new patch set (#3). Change subject: tests: Disable -Wmain-return-type for clang ...................................................................... tests: Disable -Wmain-return-type for clang Unit tests fail on clang 13.0 because Cmocka's main() function is declared with return type int, but through some of our chain-include games it sometimes gets coreboot's main_decl.h which declares the function as void. Compilers have traditionally always been very laissez-faire about the signature of the main function, but it seems that clang has been getting more strict by default recently. Explicitly disable the related warning to shut it up. Signed-off-by: Julius Werner <jwerner(a)chromium.org> Change-Id: I867c9dac659be86e7b7cf4cc41d6fa105aa9ac41 --- M payloads/libpayload/tests/Makefile.inc M tests/Makefile.inc 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/59815/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/59815 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I867c9dac659be86e7b7cf4cc41d6fa105aa9ac41 Gerrit-Change-Number: 59815 Gerrit-PatchSet: 3 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: tests: Disable -Wmain-return-type for clang
by Julius Werner (Code Review) 06 Dec '21

06 Dec '21

Hello build bot (Jenkins), Jakub Czapiga, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/59815 to look at the new patch set (#2). Change subject: tests: Disable -Wmain-return-type for clang ...................................................................... tests: Disable -Wmain-return-type for clang Unit tests fail on clang because Cmocka's main() function is declared with return type int, but through some of our chain-include games it sometimes gets coreboot's main_decl.h which declares the function as void. Compilers have traditionally always been very laissez-faire about the signature of the main function, but it seems that clang has been getting more strict by default recently. Explicitly disable the related warning to shut it up. Signed-off-by: Julius Werner <jwerner(a)chromium.org> Change-Id: I867c9dac659be86e7b7cf4cc41d6fa105aa9ac41 --- M payloads/libpayload/tests/Makefile.inc M tests/Makefile.inc 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/59815/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/59815 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I867c9dac659be86e7b7cf4cc41d6fa105aa9ac41 Gerrit-Change-Number: 59815 Gerrit-PatchSet: 2 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: tests: Disable -Wsource-mgr for clang
by Julius Werner (Code Review) 06 Dec '21

06 Dec '21

Attention is currently required from: Julius Werner. Hello build bot (Jenkins), Jakub Czapiga, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/59814 to look at the new patch set (#2). Change subject: tests: Disable -Wsource-mgr for clang ...................................................................... tests: Disable -Wsource-mgr for clang Unit tests fail on clang 13.0 with a cryptic error: _timestamp_size changed binding to STB_WEAK [-Werror,-Wsource-mgr] Probably something related to the weird things we do to mock memlayout areas. Too lazy to track it down. Let's just disable this (clang-specific, not properly documented) warning flag. Signed-off-by: Julius Werner <jwerner(a)chromium.org> Change-Id: Ie49c9eef3c74592c068c899c6717621dbcb9f609 --- M payloads/libpayload/tests/Makefile.inc M tests/Makefile.inc 2 files changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/59814/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/59814 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie49c9eef3c74592c068c899c6717621dbcb9f609 Gerrit-Change-Number: 59814 Gerrit-PatchSet: 2 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/intel/adlrvp_n: Add initial code for adl-n variant board
by Krishna P Bhat D (Code Review) 06 Dec '21

06 Dec '21

Krishna P Bhat D has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/59915 ) Change subject: mb/intel/adlrvp_n: Add initial code for adl-n variant board ...................................................................... mb/intel/adlrvp_n: Add initial code for adl-n variant board This patch adds the following list of changes: 1. Create a new devicetree for adlrvp-n and copy contents of adlrvp-p devictree. 2. Add support for 2 mainboards as ADL-N board with default EC (Windows SKU) and Chrome EC (Chrome SKU) and copy overridetree contents from adlrvp-p. 3. Add config options to pick the adlrvp_n devicetree. Change-Id: I4abf3bf62ec0398ae75e21575a2fab0d44b5c7ad Signed-off-by: Krishna Prasad Bhat <krishna.p.bhat.d(a)intel.com> --- M src/mainboard/intel/adlrvp/Kconfig A src/mainboard/intel/adlrvp/devicetree_n.cb A src/mainboard/intel/adlrvp/variants/adlrvp_n/overridetree.cb A src/mainboard/intel/adlrvp/variants/adlrvp_n_ext_ec/overridetree.cb 4 files changed, 514 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/59915/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/59915 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4abf3bf62ec0398ae75e21575a2fab0d44b5c7ad Gerrit-Change-Number: 59915 Gerrit-PatchSet: 2 Gerrit-Owner: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: [WIP]arch/x86: Tear down CAR in ramstage
by Paul Menzel (Code Review) 06 Dec '21

06 Dec '21

Attention is currently required from: Raul Rangel, Jonathan Zhang, Arthur Heymans, Kyösti Mälkki, Aaron Durbin, Patrick Rudolph, Jason Glenesk, Anjaneya "Reddy" Chagam, Marshall Dawson, Johnny Lin, Christian Walter, Morgan Jang, Tim Chu, Felix Held. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54301 ) Change subject: [WIP]arch/x86: Tear down CAR in ramstage ...................................................................... Patch Set 5: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/54301/comment/07bd91ea_593bc277 PS5, Line 10: setup set up -- To view, visit https://review.coreboot.org/c/coreboot/+/54301 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I02e5017ab2b6a6fd30b37edad19165c2531c8fd1 Gerrit-Change-Number: 54301 Gerrit-PatchSet: 5 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 06 Dec 2021 17:19:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Google/Nipperkin: Add board specific value for eDP tunning
by Paul Menzel (Code Review) 06 Dec '21

06 Dec '21

Attention is currently required from: Bao Zheng, Zheng Bao. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59919 ) Change subject: Google/Nipperkin: Add board specific value for eDP tunning ...................................................................... Patch Set 1: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/59919/comment/d70ef92b_fb37c598 PS1, Line 7: tunning tuning https://review.coreboot.org/c/coreboot/+/59919/comment/070be85f_ea5583f5 PS1, Line 8: Please document, where you got the values from. File src/mainboard/google/guybrush/variants/nipperkin/overridetree.cb: https://review.coreboot.org/c/coreboot/+/59919/comment/e6178304_1ef79e4e PS1, Line 97: #bit vector of phy, bit0=1: DP0, bit1=1: DP1, bit2=1: DP2, bit3=1: DP3 Add exactly a space after #. -- To view, visit https://review.coreboot.org/c/coreboot/+/59919 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7aa8c594d9f5caa6b2523dac079aef89e623c56f Gerrit-Change-Number: 59919 Gerrit-PatchSet: 1 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Zheng Bao Gerrit-Comment-Date: Mon, 06 Dec 2021 17:17:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Cezanne FSP wrapper: Add UPD entry for eDP tunning
by Paul Menzel (Code Review) 06 Dec '21

06 Dec '21

Attention is currently required from: Bao Zheng, Jason Glenesk, Marshall Dawson, Zheng Bao, Felix Held. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59918 ) Change subject: Cezanne FSP wrapper: Add UPD entry for eDP tunning ...................................................................... Patch Set 1: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/59918/comment/feab1247_4637f8ad PS1, Line 7: tunning tuning https://review.coreboot.org/c/coreboot/+/59918/comment/b9eb8015_04f3aadd PS1, Line 7: Cezanne FSP wrapper Maybe: > soc/amd/cezanne: FSP: … https://review.coreboot.org/c/coreboot/+/59918/comment/2e946efb_2bfb2cbe PS1, Line 8: Where is that documented? -- To view, visit https://review.coreboot.org/c/coreboot/+/59918 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9b85faac4f2fa1fb2c14bb85b615346d4379baac Gerrit-Change-Number: 59918 Gerrit-PatchSet: 1 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Zheng Bao Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 06 Dec 2021 17:16:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cpu/amd/pi/Kconfig: select NO_SMM
by Paul Menzel (Code Review) 06 Dec '21

06 Dec '21

Attention is currently required from: Michał Kopeć. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59810 ) Change subject: cpu/amd/pi/Kconfig: select NO_SMM ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/59810 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I47237421c3dd5bd043447831263d72c9956cdaf4 Gerrit-Change-Number: 59810 Gerrit-PatchSet: 3 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Comment-Date: Mon, 06 Dec 2021 17:14:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: src/northbridge/amd/agesa/family14: Enable PARALLEL_MP
by Paul Menzel (Code Review) 06 Dec '21

06 Dec '21

Attention is currently required from: Michał Kopeć. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59807 ) Change subject: src/northbridge/amd/agesa/family14: Enable PARALLEL_MP ...................................................................... Patch Set 4: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/59807/comment/6c6449cb_f5140e8b PS4, Line 7: northbridge Alternative would be *nb*. https://review.coreboot.org/c/coreboot/+/59807/comment/ca6978b8_a9f428a0 PS4, Line 7: src/ Please remove. https://review.coreboot.org/c/coreboot/+/59807/comment/84228fdb_0e301270 PS4, Line 11: TEST=Boot on PC Engines apu1 Boot time change would be nice to have documented. Patchset: PS4: Thank you for doing this. -- To view, visit https://review.coreboot.org/c/coreboot/+/59807 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I39a0779bdf115eebe31290591152b920acde773e Gerrit-Change-Number: 59807 Gerrit-PatchSet: 4 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Comment-Date: Mon, 06 Dec 2021 17:13:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2021