coreboot-gerrit December 2021

coreboot-gerrit@coreboot.org

1 participants
5525 discussions

Change in coreboot[master]: mb/google/brya/var/vell: update gpio override
by Robert Chen (Code Review) 14 Dec '21

14 Dec '21

Attention is currently required from: Paul Menzel, Tim Wawrzynczak, Kevin Chiu, Robert Chen, Nick Vaccaro, Wisley Chen. Robert Chen has uploaded a new patch set (#26) to the change originally created by Kevin Chiu. ( https://review.coreboot.org/c/coreboot/+/59305 ) Change subject: mb/google/brya/var/vell: update gpio override ...................................................................... mb/google/brya/var/vell: update gpio override Configure GPIOs according to schematics BUG=b:205908918 TEST=emerge-brya coreboot Change-Id: Icc91866f7555c294af7eed9e5d1550e73d8059d0 Signed-off-by: Kevin Chiu <Kevin.Chiu(a)quantatw.com> --- A src/mainboard/google/brya/variants/vell/Makefile.inc A src/mainboard/google/brya/variants/vell/gpio.c 2 files changed, 181 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/59305/26 -- To view, visit https://review.coreboot.org/c/coreboot/+/59305 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icc91866f7555c294af7eed9e5d1550e73d8059d0 Gerrit-Change-Number: 59305 Gerrit-PatchSet: 26 Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Kevin Chiu <Kevin.Chiu(a)quantatw.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Kevin Chiu <Kevin.Chiu(a)quantatw.com> Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/brya/var/vell: update overridetree
by Robert Chen (Code Review) 14 Dec '21

14 Dec '21

Attention is currently required from: Kevin Chiu, Tim Wawrzynczak, Paul Menzel, Nick Vaccaro, Wisley Chen, Shon Wang. Robert Chen has uploaded a new patch set (#17) to the change originally created by Kevin Chiu. ( https://review.coreboot.org/c/coreboot/+/59304 ) Change subject: mb/google/brya/var/vell: update overridetree ...................................................................... mb/google/brya/var/vell: update overridetree Init basic override devicetree based on schematics BUG=b:205908918 TEST=emerge-brya coreboot Change-Id: Ibaa910eb1c5584197907963781258035c668298e Signed-off-by: Kevin Chiu <Kevin.Chiu(a)quantatw.com> --- M src/mainboard/google/brya/Kconfig.name M src/mainboard/google/brya/variants/vell/overridetree.cb 2 files changed, 338 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/59304/17 -- To view, visit https://review.coreboot.org/c/coreboot/+/59304 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibaa910eb1c5584197907963781258035c668298e Gerrit-Change-Number: 59304 Gerrit-PatchSet: 17 Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Kevin Chiu <Kevin.Chiu(a)quantatw.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-CC: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kevin Chiu <Kevin.Chiu(a)quantatw.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mainboard/starlabs/labtop: Hook up Thunderbolt to CMOS
by Andy Pont (Code Review) 14 Dec '21

14 Dec '21

Attention is currently required from: Sean Rhodes. Andy Pont has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59705 ) Change subject: mainboard/starlabs/labtop: Hook up Thunderbolt to CMOS ...................................................................... Patch Set 16: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/59705 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibadc7464831242ae51982610b410ccf0a6811edd Gerrit-Change-Number: 59705 Gerrit-PatchSet: 16 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: Andy Pont <andy.pont(a)sdcsystems.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Comment-Date: Tue, 14 Dec 2021 06:39:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [TEST-ONLY] test vboot submodule
by Hsuan-ting Chen (Code Review) 14 Dec '21

14 Dec '21

Attention is currently required from: Hsuan Ting Chen. Hello Hsuan Ting Chen, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60097 to look at the new patch set (#2). Change subject: [TEST-ONLY] test vboot submodule ...................................................................... [TEST-ONLY] test vboot submodule TEST ONLY Signed-off-by: Hsuan Ting Chen <roccochen(a)chromium.org> Change-Id: I8b4aecbe34bd65bda67f4079efc3becdaf868ad6 --- M 3rdparty/vboot A a M util/docker/coreboot-jenkins-node/Dockerfile A util/scripts/update_vboot_submodules 4 files changed, 64 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/60097/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60097 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8b4aecbe34bd65bda67f4079efc3becdaf868ad6 Gerrit-Change-Number: 60097 Gerrit-PatchSet: 2 Gerrit-Owner: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: [TEST-ONLY] test vboot submodule
by Hsuan-ting Chen (Code Review) 14 Dec '21

14 Dec '21

Hsuan-ting Chen has removed Hsuan Ting Chen from this change. ( https://review.coreboot.org/c/coreboot/+/60097 ) Change subject: [TEST-ONLY] test vboot submodule ...................................................................... Removed reviewer Hsuan Ting Chen. -- To view, visit https://review.coreboot.org/c/coreboot/+/60097 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8b4aecbe34bd65bda67f4079efc3becdaf868ad6 Gerrit-Change-Number: 60097 Gerrit-PatchSet: 1 Gerrit-Owner: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-MessageType: deleteReviewer

1 0

Change in coreboot[master]: [TEST-ONLY] test vboot submodule
by Hsuan-ting Chen (Code Review) 14 Dec '21

14 Dec '21

Attention is currently required from: Hsuan Ting Chen. Hsuan-ting Chen has removed Martin Roth from this change. ( https://review.coreboot.org/c/coreboot/+/60097 ) Change subject: [TEST-ONLY] test vboot submodule ...................................................................... Removed reviewer Martin Roth. -- To view, visit https://review.coreboot.org/c/coreboot/+/60097 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8b4aecbe34bd65bda67f4079efc3becdaf868ad6 Gerrit-Change-Number: 60097 Gerrit-PatchSet: 1 Gerrit-Owner: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Attention: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-MessageType: deleteReviewer

1 0

Change in coreboot[master]: [TEST-ONLY] test vboot submodule
by Hsuan-ting Chen (Code Review) 14 Dec '21

14 Dec '21

Attention is currently required from: Hsuan Ting Chen. Hello Hsuan Ting Chen, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/60097 to review the following change. Change subject: [TEST-ONLY] test vboot submodule ...................................................................... [TEST-ONLY] test vboot submodule TEST ONLY Signed-off-by: Hsuan Ting Chen <roccochen(a)chromium.org> Change-Id: I8b4aecbe34bd65bda67f4079efc3becdaf868ad6 --- M 3rdparty/vboot A a M util/docker/coreboot-sdk/Dockerfile 3 files changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/60097/1 diff --git a/3rdparty/vboot b/3rdparty/vboot index 13f601f..8028cac 160000 --- a/3rdparty/vboot +++ b/3rdparty/vboot @@ -1 +1 @@ -Subproject commit 13f601fbd4c1b128f333391e4552082594f0ff25 +Subproject commit 8028cac33c9c408f90de9ceffc714a1a0ca9d583 diff --git a/a b/a new file mode 100644 index 0000000..e69de29 --- /dev/null +++ b/a diff --git a/util/docker/coreboot-sdk/Dockerfile b/util/docker/coreboot-sdk/Dockerfile index acd8242..734b56a 100644 --- a/util/docker/coreboot-sdk/Dockerfile +++ b/util/docker/coreboot-sdk/Dockerfile @@ -45,6 +45,7 @@ libcurl4 \ libcurl4-openssl-dev \ libelf-dev \ + libflashrom-dev \ libfreetype6-dev \ libftdi-dev \ libftdi1-dev \ -- To view, visit https://review.coreboot.org/c/coreboot/+/60097 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8b4aecbe34bd65bda67f4079efc3becdaf868ad6 Gerrit-Change-Number: 60097 Gerrit-PatchSet: 1 Gerrit-Owner: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Attention: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: coreboot-sdk/Dockerfile: Install libflashrom-dev
by Hsuan-ting Chen (Code Review) 14 Dec '21

14 Dec '21

Attention is currently required from: Martin Roth. Hsuan-ting Chen has removed Hsuan Ting Chen from this change. ( https://review.coreboot.org/c/coreboot/+/60095 ) Change subject: coreboot-sdk/Dockerfile: Install libflashrom-dev ...................................................................... Removed reviewer Hsuan Ting Chen. -- To view, visit https://review.coreboot.org/c/coreboot/+/60095 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7269a5140fb02da6d143b339116db2fd089f8da8 Gerrit-Change-Number: 60095 Gerrit-PatchSet: 2 Gerrit-Owner: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-MessageType: deleteReviewer

1 0

Change in coreboot[master]: coreboot-sdk/Dockerfile: Install libflashrom-dev
by Hsuan-ting Chen (Code Review) 14 Dec '21

14 Dec '21

Attention is currently required from: Hsuan Ting Chen, Martin Roth, Hsuan-ting Chen. Hello build bot (Jenkins), Hsuan Ting Chen, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60095 to look at the new patch set (#2). Change subject: coreboot-sdk/Dockerfile: Install libflashrom-dev ...................................................................... coreboot-sdk/Dockerfile: Install libflashrom-dev By updating vboot submodule to ToT in commit 18437a7b (Update vboot submodule to upstream master), crrev.com/c/3247852 (vboot_reference/futility: Port W path to using libflashrom) will be included as well. The vboot CL added a dependency of libflashrom because it included libflashrom.h header in futility/updater_utils.c. Missing this dependency will cause Jenkins build failure while building the vboot uprev CL. Add the dependency of apt-get install libflashrom-dev in coreboot-sdk to fix this issue. Change-Id: I7269a5140fb02da6d143b339116db2fd089f8da8 Signed-off-by: Hsuan Ting Chen <roccochen(a)chromium.org> --- M util/docker/coreboot-sdk/Dockerfile 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/60095/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60095 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7269a5140fb02da6d143b339116db2fd089f8da8 Gerrit-Change-Number: 60095 Gerrit-PatchSet: 2 Gerrit-Owner: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: coreboot-sdk/Dockerfile: Install libflashrom-dev
by Hsuan-ting Chen (Code Review) 14 Dec '21

14 Dec '21

Hsuan-ting Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60095 ) Change subject: coreboot-sdk/Dockerfile: Install libflashrom-dev ...................................................................... coreboot-sdk/Dockerfile: Install libflashrom-dev By updating vboot submodule to ToT in commit 18437a7b (Update vboot submodule to upstream master), crrev.com/c/3247852 (vboot_reference/futility: Port W path to using libflashrom) will be included as well. The vboot CL added a dependency of libflashrom because it included libflashrom.h header in futility/updater_utils.c. Missing this dependency will cause Jenkins build failure while building the vboot uprev CL. Add the dependency of apt-get install libflashrom-dev in coreboot-sdk to fix this issue. Change-Id: I7269a5140fb02da6d143b339116db2fd089f8da8 --- M 3rdparty/vboot M util/docker/coreboot-sdk/Dockerfile 2 files changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/60095/1 diff --git a/3rdparty/vboot b/3rdparty/vboot index 13f601f..8028cac 160000 --- a/3rdparty/vboot +++ b/3rdparty/vboot @@ -1 +1 @@ -Subproject commit 13f601fbd4c1b128f333391e4552082594f0ff25 +Subproject commit 8028cac33c9c408f90de9ceffc714a1a0ca9d583 diff --git a/util/docker/coreboot-sdk/Dockerfile b/util/docker/coreboot-sdk/Dockerfile index acd8242..734b56a 100644 --- a/util/docker/coreboot-sdk/Dockerfile +++ b/util/docker/coreboot-sdk/Dockerfile @@ -45,6 +45,7 @@ libcurl4 \ libcurl4-openssl-dev \ libelf-dev \ + libflashrom-dev \ libfreetype6-dev \ libftdi-dev \ libftdi1-dev \ -- To view, visit https://review.coreboot.org/c/coreboot/+/60095 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7269a5140fb02da6d143b339116db2fd089f8da8 Gerrit-Change-Number: 60095 Gerrit-PatchSet: 1 Gerrit-Owner: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-CC: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-MessageType: newchange

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2021