coreboot-gerrit December 2021

coreboot-gerrit@coreboot.org

1 participants
5525 discussions

Change in coreboot[master]: mb/google/brya/var/brask: Change TPM I2C to I2C1
by Zhuohao Lee (Code Review) 29 Dec '21

29 Dec '21

Attention is currently required from: Tim Wawrzynczak, Alan Huang, Zhuohao Lee. Hello build bot (Jenkins), Tim Wawrzynczak, Alan Huang, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60439 to look at the new patch set (#3). Change subject: mb/google/brya/var/brask: Change TPM I2C to I2C1 ...................................................................... mb/google/brya/var/brask: Change TPM I2C to I2C1 The latest schematics changes the TPM I2C from I2C3 to I2C1. This patch moves the TPM I2C setting from the board layer to the baseboard and fixes the TPM I2C bus assignment. BUG=b:211886429 TEST=build pass Change-Id: I70d5a8fde1866c5dd4587ab5af2d41724c60ee0c Signed-off-by: Zhuohao Lee <zhuohao(a)chromium.org> --- M src/mainboard/google/brya/Kconfig M src/mainboard/google/brya/variants/baseboard/brask/devicetree.cb M src/mainboard/google/brya/variants/baseboard/brask/gpio.c M src/mainboard/google/brya/variants/brask/gpio.c M src/mainboard/google/brya/variants/brask/overridetree.cb 5 files changed, 29 insertions(+), 27 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/60439/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/60439 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I70d5a8fde1866c5dd4587ab5af2d41724c60ee0c Gerrit-Change-Number: 60439 Gerrit-PatchSet: 3 Gerrit-Owner: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Reviewer: Alan Huang <alan-huang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-CC: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Alan Huang <alan-huang(a)quanta.corp-partner.google.com> Gerrit-Attention: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/brya/var/brask: Change TPM I2C to I2C1
by David Wu (Code Review) 29 Dec '21

29 Dec '21

Attention is currently required from: Tim Wawrzynczak, Alan Huang, Zhuohao Lee. David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60439 ) Change subject: mb/google/brya/var/brask: Change TPM I2C to I2C1 ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: Could you revise gpio.c in variants/brask as well? Thanks. https://source.chromium.org/chromiumos/chromiumos/codesearch/+/main:src/thi… -- To view, visit https://review.coreboot.org/c/coreboot/+/60439 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I70d5a8fde1866c5dd4587ab5af2d41724c60ee0c Gerrit-Change-Number: 60439 Gerrit-PatchSet: 2 Gerrit-Owner: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Reviewer: Alan Huang <alan-huang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-CC: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Alan Huang <alan-huang(a)quanta.corp-partner.google.com> Gerrit-Attention: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Comment-Date: Wed, 29 Dec 2021 10:45:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: crossgcc/buildgcc: Remove unused GCC_AUTOCONF_VERSION
by HAOUAS Elyes (Code Review) 29 Dec '21

29 Dec '21

Attention is currently required from: Felix Singer, Paul Menzel. HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59398 ) Change subject: crossgcc/buildgcc: Remove unused GCC_AUTOCONF_VERSION ...................................................................... Patch Set 6: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/59398/comment/5d1c58d8_5ae28813 PS5, Line 9: Drop unused GCC_AUTOCONF_VERSION. : Fixes: d0f83723 (buildgcc: Don't run autoconf) > Actually, this doesn't fix something. How about: […] Ack Patchset: PS6: Thx -- To view, visit https://review.coreboot.org/c/coreboot/+/59398 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7d293ae2c8663efdc9ad4146ff32671ffd3e176a Gerrit-Change-Number: 59398 Gerrit-PatchSet: 6 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Wed, 29 Dec 2021 10:43:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: crossgcc/Makefile: Remove obsolete target build_make
by HAOUAS Elyes (Code Review) 29 Dec '21

29 Dec '21

Attention is currently required from: Paul Menzel. HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59397 ) Change subject: crossgcc/Makefile: Remove obsolete target build_make ...................................................................... Patch Set 7: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/59397/comment/b456c2c4_b8b3007a PS6, Line 9: "Make" > gnumake Ack Patchset: PS7: Thx -- To view, visit https://review.coreboot.org/c/coreboot/+/59397 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0f159fc912d09ebde6ac7ba5be83933aa251f1d5 Gerrit-Change-Number: 59397 Gerrit-PatchSet: 7 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Wed, 29 Dec 2021 10:43:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: crossgcc/Makefile: Remove obsolete target build_make
by HAOUAS Elyes (Code Review) 29 Dec '21

29 Dec '21

Attention is currently required from: Paul Menzel, HAOUAS Elyes. Hello Felix Singer, build bot (Jenkins), Paul Menzel, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/59397 to look at the new patch set (#7). Change subject: crossgcc/Makefile: Remove obsolete target build_make ...................................................................... crossgcc/Makefile: Remove obsolete target build_make coreboot does not build gnumake anymore since commit 91fb139956bcbd5771fd7ec1e474c16122c1b547 Change-Id: I0f159fc912d09ebde6ac7ba5be83933aa251f1d5 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M util/crossgcc/Makefile 1 file changed, 1 insertion(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/59397/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/59397 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0f159fc912d09ebde6ac7ba5be83933aa251f1d5 Gerrit-Change-Number: 59397 Gerrit-PatchSet: 7 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: crossgcc/buildgcc: Remove unused GCC_AUTOCONF_VERSION
by HAOUAS Elyes (Code Review) 29 Dec '21

29 Dec '21

Attention is currently required from: Paul Menzel, HAOUAS Elyes. Hello Felix Singer, build bot (Jenkins), Paul Menzel, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/59398 to look at the new patch set (#6). Change subject: crossgcc/buildgcc: Remove unused GCC_AUTOCONF_VERSION ...................................................................... crossgcc/buildgcc: Remove unused GCC_AUTOCONF_VERSION Clean up leftovers from commit d0f83723 and drop unused GCC_AUTOCONF_VERSION. Change-Id: I7d293ae2c8663efdc9ad4146ff32671ffd3e176a Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M util/crossgcc/buildgcc 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/59398/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/59398 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7d293ae2c8663efdc9ad4146ff32671ffd3e176a Gerrit-Change-Number: 59398 Gerrit-PatchSet: 6 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/corsola: initialize krabby display
by Rex-BC Chen (Code Review) 29 Dec '21

29 Dec '21

Attention is currently required from: Hung-Te Lin. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60447 ) Change subject: mb/google/corsola: initialize krabby display ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: hi Hung-te and Yu-ping, There are some build errors for "Corsola". I think we just build for "Kingler" and "Krabby" Aby suggestion? CC ramstage/mainboard/google/corsola/display.o src/mainboard/google/corsola/display.c:100:1: error: static assertion failed: "Exactly one of KINGLER and KRABBY must be set" 100 | _Static_assert(CONFIG(BOARD_GOOGLE_KINGLER_COMMON) + CONFIG(BOARD_GOOGLE_KRABBY_COMMON) == 1, | ^~~~~~~~~~~~~~ make[1]: *** [Makefile:381: /cb-build/coreboot-gerrit.0/chromeos/GOOGLE_CORSOLA/ramstage/mainboard/google/corsola/display.o] Error 1 make[1]: Leaving directory '/home/coreboot/node-root/workspace/coreboot-gerrit' -- To view, visit https://review.coreboot.org/c/coreboot/+/60447 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I314d5407c40429bb7bc50f36fece58e396b27548 Gerrit-Change-Number: 60447 Gerrit-PatchSet: 1 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Comment-Date: Wed, 29 Dec 2021 10:19:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/corsola: initialize krabby display
by Yu-Ping Wu (Code Review) 29 Dec '21

29 Dec '21

Attention is currently required from: Hung-Te Lin, Rex-BC Chen. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60447 ) Change subject: mb/google/corsola: initialize krabby display ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60447 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I314d5407c40429bb7bc50f36fece58e396b27548 Gerrit-Change-Number: 60447 Gerrit-PatchSet: 1 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Comment-Date: Wed, 29 Dec 2021 10:01:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/mediatek/mt8186: Add support for regulator VRF12/VCN33
by Yu-Ping Wu (Code Review) 29 Dec '21

29 Dec '21

Attention is currently required from: Hung-Te Lin, Rex-BC Chen. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60446 ) Change subject: soc/mediatek/mt8186: Add support for regulator VRF12/VCN33 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60446 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I55a9ca16e1e335e9355d0a1b30c278a9969db197 Gerrit-Change-Number: 60446 Gerrit-PatchSet: 1 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Comment-Date: Wed, 29 Dec 2021 10:00:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: crossgcc/buildgcc: Remove unused GCC_AUTOCONF_VERSION
by Felix Singer (Code Review) 29 Dec '21

29 Dec '21

Attention is currently required from: Paul Menzel, HAOUAS Elyes. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59398 ) Change subject: crossgcc/buildgcc: Remove unused GCC_AUTOCONF_VERSION ...................................................................... Patch Set 5: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/59398/comment/e901cf92_f5294869 PS5, Line 9: Drop unused GCC_AUTOCONF_VERSION. : Fixes: d0f83723 (buildgcc: Don't run autoconf) Actually, this doesn't fix something. How about: Clean up leftovers from commit d0f83723 and drop unused GCC_AUTOCONF_VERSION. -- To view, visit https://review.coreboot.org/c/coreboot/+/59398 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7d293ae2c8663efdc9ad4146ff32671ffd3e176a Gerrit-Change-Number: 59398 Gerrit-PatchSet: 5 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Comment-Date: Wed, 29 Dec 2021 09:59:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2021