coreboot-gerrit December 2021

coreboot-gerrit@coreboot.org

1 participants
5525 discussions

Change in coreboot[master]: ec/google/chromeec/acpi: Use ACPI 2.0 syntax to access arrays
by Felix Singer (Code Review) 29 Dec '21

29 Dec '21

Attention is currently required from: Tim Wawrzynczak. Hello Tim Wawrzynczak, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60457 to look at the new patch set (#2). Change subject: ec/google/chromeec/acpi: Use ACPI 2.0 syntax to access arrays ...................................................................... ec/google/chromeec/acpi: Use ACPI 2.0 syntax to access arrays Replace Index(FOO, 1337) with FOO[1337]. Change-Id: I2fb96e338b332f4fbb3bd23fb07bb1ca36c19c49 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/ec/google/chromeec/acpi/battery.asl 1 file changed, 21 insertions(+), 21 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/60457/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60457 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2fb96e338b332f4fbb3bd23fb07bb1ca36c19c49 Gerrit-Change-Number: 60457 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: drivers/intel/gma/acpi: Use ACPI 2.0 syntax to access arrays
by Felix Singer (Code Review) 29 Dec '21

29 Dec '21

Attention is currently required from: Patrick Rudolph. Hello Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60456 to look at the new patch set (#2). Change subject: drivers/intel/gma/acpi: Use ACPI 2.0 syntax to access arrays ...................................................................... drivers/intel/gma/acpi: Use ACPI 2.0 syntax to access arrays Replace Index(FOO, 1337) with FOO[1337]. Change-Id: I534c1581e587908feeb06fd7725c5895649dcfb1 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/drivers/intel/gma/acpi/common.asl M src/drivers/intel/gma/acpi/configure_brightness_levels.asl 2 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/60456/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60456 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I534c1581e587908feeb06fd7725c5895649dcfb1 Gerrit-Change-Number: 60456 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: ec/quanta/it8518/acpi: Use ACPI 2.0 syntax to access arrays
by Felix Singer (Code Review) 29 Dec '21

29 Dec '21

Felix Singer has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/60455 ) Change subject: ec/quanta/it8518/acpi: Use ACPI 2.0 syntax to access arrays ...................................................................... ec/quanta/it8518/acpi: Use ACPI 2.0 syntax to access arrays Replace Index(FOO, 1337) with FOO[1337]. Change-Id: I0b1fe0fcdf2862dc76f07ef1478929f7c726ac47 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/ec/quanta/it8518/acpi/battery.asl 1 file changed, 16 insertions(+), 16 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/60455/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60455 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0b1fe0fcdf2862dc76f07ef1478929f7c726ac47 Gerrit-Change-Number: 60455 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/51nb/x210/acpi: Use ACPI 2.0 syntax to access arrays
by Felix Singer (Code Review) 29 Dec '21

29 Dec '21

Felix Singer has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/60454 ) Change subject: mb/51nb/x210/acpi: Use ACPI 2.0 syntax to access arrays ...................................................................... mb/51nb/x210/acpi: Use ACPI 2.0 syntax to access arrays Replace Index(FOO, 1337) with FOO[1337]. Change-Id: I5692d1be5a94d259bbed987a43ec17ad1c1f915c Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/mainboard/51nb/x210/acpi/battery.asl 1 file changed, 9 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/60454/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60454 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5692d1be5a94d259bbed987a43ec17ad1c1f915c Gerrit-Change-Number: 60454 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: ec/google/chromeec/acpi: Use ACPI 2.0 syntax for accessing arrays
by Felix Singer (Code Review) 29 Dec '21

29 Dec '21

Attention is currently required from: Tim Wawrzynczak. Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60457 ) Change subject: ec/google/chromeec/acpi: Use ACPI 2.0 syntax for accessing arrays ...................................................................... ec/google/chromeec/acpi: Use ACPI 2.0 syntax for accessing arrays Replace Index(FOO, 1337) with FOO[1337]. Change-Id: I2fb96e338b332f4fbb3bd23fb07bb1ca36c19c49 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/ec/google/chromeec/acpi/battery.asl 1 file changed, 21 insertions(+), 21 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/60457/1 diff --git a/src/ec/google/chromeec/acpi/battery.asl b/src/ec/google/chromeec/acpi/battery.asl index d9304c1..fc9edc9 100644 --- a/src/ec/google/chromeec/acpi/battery.asl +++ b/src/ec/google/chromeec/acpi/battery.asl @@ -68,27 +68,27 @@ Return (Arg1) } // Last Full Charge Capacity - Store (BTDF, Index (Arg1, 2)) + Store (BTDF, Arg1[2]) // Design Voltage - Store (BTDV, Index (Arg1, 4)) + Store (BTDV, Arg1[4]) // Design Capacity Store (BTDA, Local0) - Store (Local0, Index (Arg1, 1)) + Store (Local0, Arg1[1]) // Design Capacity of Warning Divide (Multiply (Local0, DWRN), 100, , Local2) - Store (Local2, Index (Arg1, 5)) + Store (Local2, Arg1[5]) // Design Capacity of Low Divide (Multiply (Local0, DLOW), 100, , Local2) - Store (Local2, Index (Arg1, 6)) + Store (Local2, Arg1[6]) // Get battery info from mainboard - Store (ToString(Concatenate(BMOD, 0x00)), Index (Arg1, 9)) - Store (ToString(Concatenate(BSER, 0x00)), Index (Arg1, 10)) - Store (ToString(Concatenate(BMFG, 0x00)), Index (Arg1, 12)) + Store (ToString(Concatenate(BMOD, 0x00)), Arg1[9]) + Store (ToString(Concatenate(BSER, 0x00)), Arg1[10]) + Store (ToString(Concatenate(BMFG, 0x00)), Arg1[12]) Release (^BATM) Return (Arg1) @@ -108,30 +108,30 @@ Return (Arg1) } // Last Full Charge Capacity - Store (BTDF, Index (Arg1, 3)) + Store (BTDF, Arg1[3]) // Design Voltage - Store (BTDV, Index (Arg1, 5)) + Store (BTDV, Arg1[5]) // Design Capacity Store (BTDA, Local0) - Store (Local0, Index (Arg1, 2)) + Store (Local0, Arg1[2]) // Design Capacity of Warning Divide (Multiply (Local0, DWRN), 100, , Local2) - Store (Local2, Index (Arg1, 6)) + Store (Local2, Arg1[6]) // Design Capacity of Low Divide (Multiply (Local0, DLOW), 100, , Local2) - Store (Local2, Index (Arg1, 7)) + Store (Local2, Arg1[7]) // Cycle Count - Store (BTCC, Index (Arg1, 8)) + Store (BTCC, Arg1[8]) // Get battery info from mainboard - Store (ToString(Concatenate(BMOD, 0x00)), Index (Arg1, 16)) - Store (ToString(Concatenate(BSER, 0x00)), Index (Arg1, 17)) - Store (ToString(Concatenate(BMFG, 0x00)), Index (Arg1, 19)) + Store (ToString(Concatenate(BMOD, 0x00)), Arg1[16]) + Store (ToString(Concatenate(BSER, 0x00)), Arg1[17]) + Store (ToString(Concatenate(BMFG, 0x00)), Arg1[19]) Release (^BATM) Return (Arg1) @@ -177,7 +177,7 @@ If (BFCR) { Or (Local1, 0x04, Local1) } - Store (Local1, Index (Arg1, 0)) + Store (Local1, Arg1[0]) // Notify if battery state has changed since last time If (LNotEqual (Local1, DeRefOf (Arg2))) { @@ -195,7 +195,7 @@ // // 1: BATTERY PRESENT RATE // - Store (BTPR, Index (Arg1, 1)) + Store (BTPR, Arg1[1]) // // 2: BATTERY REMAINING CAPACITY @@ -216,12 +216,12 @@ Store (Local2, Local1) } } - Store (Local1, Index (Arg1, 2)) + Store (Local1, Arg1[2]) // // 3: BATTERY PRESENT VOLTAGE // - Store (BTVO, Index (Arg1, 3)) + Store (BTVO, Arg1[3]) Release (^BATM) Return (Arg1) -- To view, visit https://review.coreboot.org/c/coreboot/+/60457 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2fb96e338b332f4fbb3bd23fb07bb1ca36c19c49 Gerrit-Change-Number: 60457 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: drivers/intel/gma/acpi: Use ACPI 2.0 syntax for accessing arrays
by Felix Singer (Code Review) 29 Dec '21

29 Dec '21

Attention is currently required from: Patrick Rudolph. Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60456 ) Change subject: drivers/intel/gma/acpi: Use ACPI 2.0 syntax for accessing arrays ...................................................................... drivers/intel/gma/acpi: Use ACPI 2.0 syntax for accessing arrays Replace Index(FOO, 1337) with FOO[1337]. Change-Id: I534c1581e587908feeb06fd7725c5895649dcfb1 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/drivers/intel/gma/acpi/common.asl M src/drivers/intel/gma/acpi/configure_brightness_levels.asl 2 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/60456/1 diff --git a/src/drivers/intel/gma/acpi/common.asl b/src/drivers/intel/gma/acpi/common.asl index 79960e1..254a66d 100644 --- a/src/drivers/intel/gma/acpi/common.asl +++ b/src/drivers/intel/gma/acpi/common.asl @@ -42,7 +42,7 @@ { Decrement (Local0) } - XBCM (DerefOf (Index (BRIG, Local0))) + XBCM (DerefOf (BRIG[Local0])) } } @@ -60,6 +60,6 @@ { Increment (Local0) } - XBCM (DerefOf (Index (BRIG, Local0))) + XBCM (DerefOf (BRIG[Local0])) } } diff --git a/src/drivers/intel/gma/acpi/configure_brightness_levels.asl b/src/drivers/intel/gma/acpi/configure_brightness_levels.asl index 0ab93d8..92ae766 100644 --- a/src/drivers/intel/gma/acpi/configure_brightness_levels.asl +++ b/src/drivers/intel/gma/acpi/configure_brightness_levels.asl @@ -123,8 +123,8 @@ Store (2, Local1) While (LLess (Local1, Subtract (SizeOf (BRIG), 1))) { /* Local[23]: adjacent values in BRIG */ - Store (DeRefOf (Index (BRIG, Local1)), Local2) - Store (DeRefOf (Index (BRIG, Add (Local1, 1))), Local3) + Store (DeRefOf (BRIG[Local1]), Local2) + Store (DeRefOf (BRIG[Add (Local1, 1)]), Local3) If (LLess (Local0, Local3)) { If (LOr (LLess (Local0, Local2), -- To view, visit https://review.coreboot.org/c/coreboot/+/60456 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I534c1581e587908feeb06fd7725c5895649dcfb1 Gerrit-Change-Number: 60456 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: ec/quanta/it8518/acpi: Use ACPI 2.0 syntax for accessing arrays
by Felix Singer (Code Review) 29 Dec '21

29 Dec '21

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60455 ) Change subject: ec/quanta/it8518/acpi: Use ACPI 2.0 syntax for accessing arrays ...................................................................... ec/quanta/it8518/acpi: Use ACPI 2.0 syntax for accessing arrays Replace Index(FOO, 1337) with FOO[1337]. Change-Id: I0b1fe0fcdf2862dc76f07ef1478929f7c726ac47 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/ec/quanta/it8518/acpi/battery.asl 1 file changed, 16 insertions(+), 16 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/60455/1 diff --git a/src/ec/quanta/it8518/acpi/battery.asl b/src/ec/quanta/it8518/acpi/battery.asl index 768f2b1..adbde93 100644 --- a/src/ec/quanta/it8518/acpi/battery.asl +++ b/src/ec/quanta/it8518/acpi/battery.asl @@ -106,7 +106,7 @@ // ACPI spec : 0 - mWh : 1 - mAh // Store(SBCM, Local7) - XOr (Local7, One, Index (PBIF, 0)) + XOr (Local7, One, PBIF[0]) // // Information ID 0 - @@ -119,11 +119,11 @@ // If (Local7) { - Multiply (SBFC, 10, Index (PBIF, 2)) + Multiply (SBFC, 10, PBIF[2]) } Else { - Store (SBFC, Index (PBIF, 2)) + Store (SBFC, PBIF[2]) } // @@ -143,24 +143,24 @@ { Store (SBDC, Local0) } - Store (Local0, Index(PBIF, One)) + Store (Local0, PBIF[1]) // // Design capacity of High (5%) // Design capacity of Low (1%) // - Divide (Local0, 20, , Index (PBIF, 5)) - Divide (Local0, 100, , Index (PBIF, 6)) + Divide (Local0, 20, , PBIF[5]) + Divide (Local0, 100, , PBIF[6]) // // Design voltage // - Store (SBDV, Index (PBIF, 4)) + Store (SBDV, PBIF[4]) // // Serial Number // - Store (ToHexString (SBSN), Index (PBIF, 10)) + Store (ToHexString (SBSN), PBIF[10]) // // Information ID 4 - @@ -171,7 +171,7 @@ // // Battery Type - Device Chemistry // - Store (ToString (Concatenate(SBCH, 0x00)), Index (PBIF, 11)) + Store (ToString (Concatenate(SBCH, 0x00)), PBIF[11]) // // Information ID 5 - @@ -182,7 +182,7 @@ // // OEM Information - Manufacturer Name // - Store (ToString (Concatenate(SBMN, 0x00)), Index (PBIF, 12)) + Store (ToString (Concatenate(SBMN, 0x00)), PBIF[12]) // // Information ID 6 - @@ -193,7 +193,7 @@ // // Model Number - Device Name // - Store (ToString (Concatenate(SBDN, 0x00)), Index (PBIF, 9)) + Store (ToString (Concatenate(SBDN, 0x00)), PBIF[9]) Return (PBIF) } @@ -255,7 +255,7 @@ // Flag if the battery level is critical And (Local0, 0x04, Local4) Or (Local1, Local4, Local1) - Store (Local1, Index (PBST, 0)) + Store (Local1, PBST[0]) // // 1: BATTERY PRESENT RATE/CURRENT @@ -282,14 +282,14 @@ } } - XOr (DerefOf (Index (PBIF, Zero)), One, Local6) + XOr (DerefOf (PBIF[0]), One, Local6) If (Local6) { Multiply (ECVO, Local1, Local1) Divide (Local1, 1000, , Local1) } - Store (Local1, Index (PBST, One)) + Store (Local1, PBST[1]) // // 2: BATTERY REMAINING CAPACITY @@ -323,12 +323,12 @@ Store (Local2, Local1) } } - Store (Local1, Index (PBST, 2)) + Store (Local1, PBST[2]) // // 3: BATTERY PRESENT VOLTAGE // - Store (ECVO, Index (PBST, 3)) + Store (ECVO, PBST[3]) Return (PBST) } -- To view, visit https://review.coreboot.org/c/coreboot/+/60455 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0b1fe0fcdf2862dc76f07ef1478929f7c726ac47 Gerrit-Change-Number: 60455 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/51nb/x210/acpi: Use ACPI 2.0 syntax for accessing arrays
by Felix Singer (Code Review) 29 Dec '21

29 Dec '21

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60454 ) Change subject: mb/51nb/x210/acpi: Use ACPI 2.0 syntax for accessing arrays ...................................................................... mb/51nb/x210/acpi: Use ACPI 2.0 syntax for accessing arrays Replace Index(FOO, 1337) with FOO[1337]. Change-Id: I5692d1be5a94d259bbed987a43ec17ad1c1f915c Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/mainboard/51nb/x210/acpi/battery.asl 1 file changed, 9 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/60454/1 diff --git a/src/mainboard/51nb/x210/acpi/battery.asl b/src/mainboard/51nb/x210/acpi/battery.asl index f9022a4..bf5c9b0 100644 --- a/src/mainboard/51nb/x210/acpi/battery.asl +++ b/src/mainboard/51nb/x210/acpi/battery.asl @@ -37,19 +37,19 @@ Method (_BIF, 0, Serialized) { /* Design Capacity */ - Store (DGCP * 10000 / DGVO, Index (PBIF, 1)) + Store (DGCP * 10000 / DGVO, PBIF[1]) /* Last Full Charge Capacity */ - Store (FLCP * 10000 / DGVO, Index (PBIF, 2)) + Store (FLCP * 10000 / DGVO, PBIF[2]) /* Design Voltage */ - Store (DGVO, Index (PBIF, 4)) + Store (DGVO, PBIF[4]) /* Design Capacity of Warning */ - Store (BDW * 10000 / DGVO, Index (PBIF, 5)) + Store (BDW * 10000 / DGVO, PBIF[5]) /* Design Capacity of Low */ - Store (BDL, Index (PBIF, 6)) + Store (BDL, PBIF[6]) Return (PBIF) } @@ -70,22 +70,22 @@ * bit 1 = charging * bit 2 = critical level */ - Store (BSTS, Index (PBST, 0)) + Store (BSTS, PBST[0]) /* * 1: BATTERY PRESENT RATE */ - Store (BPR, Index (PBST, 1)) + Store (BPR, PBST[1]) /* * 2: BATTERY REMAINING CAPACITY */ - Store (BRC * 10000 / DGVO, Index (PBST, 2)) + Store (BRC * 10000 / DGVO, PBST[2]) /* * 3: BATTERY PRESENT VOLTAGE */ - Store (BPV, Index (PBST, 3)) + Store (BPV, PBST[3]) Return (PBST) } -- To view, visit https://review.coreboot.org/c/coreboot/+/60454 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5692d1be5a94d259bbed987a43ec17ad1c1f915c Gerrit-Change-Number: 60454 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: northbridge/intel/haswell/acpi: Use Printf() for debug prints
by HAOUAS Elyes (Code Review) 29 Dec '21

29 Dec '21

Attention is currently required from: Felix Singer, Angel Pons, Patrick Rudolph. HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60450 ) Change subject: northbridge/intel/haswell/acpi: Use Printf() for debug prints ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60450 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3f500ec46a9046a4e8ca50a85965b8e1225f8a33 Gerrit-Change-Number: 60450 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Wed, 29 Dec 2021 13:03:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: northbridge/intel/sandybridge/acpi: Use Printf() for debug prints
by HAOUAS Elyes (Code Review) 29 Dec '21

29 Dec '21

Attention is currently required from: Felix Singer, Angel Pons, Patrick Rudolph. HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60451 ) Change subject: northbridge/intel/sandybridge/acpi: Use Printf() for debug prints ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60451 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I58c2545c881572127b6d34b5527c5d4bd7d97dfb Gerrit-Change-Number: 60451 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Wed, 29 Dec 2021 13:02:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2021