coreboot-gerrit December 2021

coreboot-gerrit@coreboot.org

1 participants
5525 discussions

Change in coreboot[master]: mb/google/cyan/acpi: Use ACPI 2.0 syntax to access arrays
by Felix Singer (Code Review) 29 Dec '21

29 Dec '21

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60461 ) Change subject: mb/google/cyan/acpi: Use ACPI 2.0 syntax to access arrays ...................................................................... mb/google/cyan/acpi: Use ACPI 2.0 syntax to access arrays Replace Index(FOO, 1337) with FOO[1337]. Change-Id: Ica59483c9e9f67361d269259708998f9152406f3 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/mainboard/google/cyan/variants/terra/include/variant/acpi/dptf.asl 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/60461/1 diff --git a/src/mainboard/google/cyan/variants/terra/include/variant/acpi/dptf.asl b/src/mainboard/google/cyan/variants/terra/include/variant/acpi/dptf.asl index d2a7208..2cfc256 100644 --- a/src/mainboard/google/cyan/variants/terra/include/variant/acpi/dptf.asl +++ b/src/mainboard/google/cyan/variants/terra/include/variant/acpi/dptf.asl @@ -173,7 +173,7 @@ Method (_OSC, 4, Serialized) { /* Check for Passive Policy UUID */ - If (LEqual (DeRefOf (Index (IDSP, 0)), Arg0)) { + If (LEqual (DeRefOf (IDSP[0]), Arg0)) { /* Initialize Thermal Devices */ ^TINI () -- To view, visit https://review.coreboot.org/c/coreboot/+/60461 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ica59483c9e9f67361d269259708998f9152406f3 Gerrit-Change-Number: 60461 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/intel/alderlake: Add option to make MRC log silent
by Nico Huber (Code Review) 29 Dec '21

29 Dec '21

Attention is currently required from: Felix Singer, Subrata Banik, Tim Wawrzynczak, Angel Pons, Arthur Heymans, Nick Vaccaro, Andrey Petrov, Patrick Rudolph. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60441 ) Change subject: soc/intel/alderlake: Add option to make MRC log silent ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: Why not map the console loglevel to this UPD? That would avoid adding more Kconfigs. -- To view, visit https://review.coreboot.org/c/coreboot/+/60441 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iea3b32feca0893a83fdf700798b0883d26ccc718 Gerrit-Change-Number: 60441 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Wed, 29 Dec 2021 13:39:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: ec/purism/librem-ec/acpi: Use Printf() for debug prints
by Felix Singer (Code Review) 29 Dec '21

29 Dec '21

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60382 ) Change subject: ec/purism/librem-ec/acpi: Use Printf() for debug prints ...................................................................... ec/purism/librem-ec/acpi: Use Printf() for debug prints Change-Id: Ic26c24d1246f8a40191e02229e66f6a893e488fa Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60382 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/ec/purism/librem-ec/acpi/ec.asl M src/ec/purism/librem-ec/acpi/librem-ec.asl 2 files changed, 30 insertions(+), 30 deletions(-) Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved diff --git a/src/ec/purism/librem-ec/acpi/ec.asl b/src/ec/purism/librem-ec/acpi/ec.asl index bc225e7..4e7b4a1 100644 --- a/src/ec/purism/librem-ec/acpi/ec.asl +++ b/src/ec/purism/librem-ec/acpi/ec.asl @@ -34,7 +34,7 @@ Name (ECOK, Zero) Method (_REG, 2, Serialized) // _REG: Region Availability { - Debug = Concatenate("EC: _REG", Concatenate(ToHexString(Arg0), Concatenate(" ", ToHexString(Arg1)))) + Printf ("EC: _REG %o %o", ToHexString(Arg0), ToHexString(Arg1)) If ((Arg0 == 0x03) && (Arg1 == One)) { // Enable hardware touchpad lock, airplane mode, and keyboard backlight keys ECOS = 1 @@ -63,7 +63,7 @@ } Method (PTS, 1, Serialized) { - Debug = Concatenate("EC: PTS: ", ToHexString(Arg0)) + Printf ("EC: PTS: %o", ToHexString(Arg0)) If (ECOK) { // Clear wake cause WFNO = Zero @@ -71,7 +71,7 @@ } Method (WAK, 1, Serialized) { - Debug = Concatenate("EC: WAK: ", ToHexString(Arg0)) + Printf ("EC: WAK: %o", ToHexString(Arg0)) If (ECOK) { // Set current AC state ^^^^AC.ACFG = ADP @@ -91,42 +91,42 @@ Method (_Q0A, 0, NotSerialized) // Touchpad Toggle { - Debug = "EC: Touchpad Toggle" + Printf ("EC: Touchpad Toggle") } Method (_Q0B, 0, NotSerialized) // Screen Toggle { - Debug = "EC: Screen Toggle" + Printf ("EC: Screen Toggle") } Method (_Q0C, 0, NotSerialized) // Mute { - Debug = "EC: Mute" + Printf ("EC: Mute") } Method (_Q0D, 0, NotSerialized) // Keyboard Backlight { - Debug = "EC: Keyboard Backlight" + Printf ("EC: Keyboard Backlight") } Method (_Q0E, 0, NotSerialized) // Volume Down { - Debug = "EC: Volume Down" + Printf ("EC: Volume Down") } Method (_Q0F, 0, NotSerialized) // Volume Up { - Debug = "EC: Volume Up" + Printf ("EC: Volume Up") } Method (_Q10, 0, NotSerialized) // Switch Video Mode { - Debug = "EC: Switch Video Mode" + Printf ("EC: Switch Video Mode") } Method (_Q11, 0, NotSerialized) // Brightness Down { - Debug = "EC: Brightness Down" + Printf ("EC: Brightness Down") if (^^^^HIDD.HRDY) { ^^^^HIDD.HPEM (20) } @@ -134,7 +134,7 @@ Method (_Q12, 0, NotSerialized) // Brightness Up { - Debug = "EC: Brightness Up" + Printf ("EC: Brightness Up") if (^^^^HIDD.HRDY) { ^^^^HIDD.HPEM (19) } @@ -142,12 +142,12 @@ Method (_Q13, 0, NotSerialized) // Camera Toggle { - Debug = "EC: Camera Toggle" + Printf ("EC: Camera Toggle") } Method (_Q14, 0, NotSerialized) // Airplane Mode { - Debug = "EC: Airplane Mode" + Printf ("EC: Airplane Mode") if (^^^^HIDD.HRDY) { ^^^^HIDD.HPEM (8) } @@ -156,13 +156,13 @@ Method (_Q15, 0, NotSerialized) // Suspend Button { - Debug = "EC: Suspend Button" + Printf ("EC: Suspend Button") Notify (SLPB, 0x80) } Method (_Q16, 0, NotSerialized) // AC Detect { - Debug = "EC: AC Detect" + Printf ("EC: AC Detect") ^^^^AC.ACFG = ADP Notify (AC, 0x80) // Status Change If (BAT0) @@ -174,25 +174,25 @@ Method (_Q17, 0, NotSerialized) // BAT0 Update { - Debug = "EC: BAT0 Update (17)" + Printf ("EC: BAT0 Update (17)") Notify (^^^^BAT0, 0x81) // Information Change } Method (_Q19, 0, NotSerialized) // BAT0 Update { - Debug = "EC: BAT0 Update (19)" + Printf ("EC: BAT0 Update (19)") Notify (^^^^BAT0, 0x81) // Information Change } Method (_Q1B, 0, NotSerialized) // Lid Close { - Debug = "EC: Lid Close" + Printf ("EC: Lid Close") Notify (LID0, 0x80) } Method (_Q1C, 0, NotSerialized) // Thermal Trip { - Debug = "EC: Thermal Trip" + Printf ("EC: Thermal Trip") /* TODO Notify (\_TZ.TZ0, 0x81) // Thermal Trip Point Change Notify (\_TZ.TZ0, 0x80) // Thermal Status Change @@ -201,7 +201,7 @@ Method (_Q1D, 0, NotSerialized) // Power Button { - Debug = "EC: Power Button" + Printf ("EC: Power Button") Notify (PWRB, 0x80) } @@ -209,22 +209,22 @@ { Local0 = OEM4 If (Local0 == 0x8A) { - Debug = "EC: White Keyboard Backlight" + Printf ("EC: White Keyboard Backlight") Notify (^^^^LIEC, 0x80) } ElseIf (Local0 == 0x9F) { - Debug = "EC: Color Keyboard Toggle" + Printf ("EC: Color Keyboard Toggle") Notify (^^^^LIEC, 0x81) } ElseIf (Local0 == 0x81) { - Debug = "EC: Color Keyboard Down" + Printf ("EC: Color Keyboard Down") Notify (^^^^LIEC, 0x82) } ElseIf (Local0 == 0x82) { - Debug = "EC: Color Keyboard Up" + Printf ("EC: Color Keyboard Up") Notify (^^^^LIEC, 0x83) } ElseIf (Local0 == 0x80) { - Debug = "EC: Color Keyboard Color Change" + Printf ("EC: Color Keyboard Color Change") Notify (^^^^LIEC, 0x84) } Else { - Debug = Concatenate("EC: Other: ", ToHexString(Local0)) + Printf ("EC: Other: %o", ToHexString(Local0)) } } diff --git a/src/ec/purism/librem-ec/acpi/librem-ec.asl b/src/ec/purism/librem-ec/acpi/librem-ec.asl index 5914d17..ea227c7 100644 --- a/src/ec/purism/librem-ec/acpi/librem-ec.asl +++ b/src/ec/purism/librem-ec/acpi/librem-ec.asl @@ -11,13 +11,13 @@ Name (_UID, 0) Method (RSET, 0, Serialized) { - Debug = "LIEC: RSET" + Printf ("LIEC: RSET") SAPL(0) SKBL(0) } Method (INIT, 0, Serialized) { - Debug = "LIEC: INIT" + Printf ("LIEC: INIT") RSET() If (^^PCI0.LPCB.EC0.ECOK) { // Set flags to use software control @@ -29,7 +29,7 @@ } Method (FINI, 0, Serialized) { - Debug = "LIEC: FINI" + Printf ("LIEC: FINI") RSET() If (^^PCI0.LPCB.EC0.ECOK) { // Set flags to use hardware control 4 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/coreboot/+/60382 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic26c24d1246f8a40191e02229e66f6a893e488fa Gerrit-Change-Number: 60382 Gerrit-PatchSet: 7 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: ec/hp/kbc1126/acpi: Use Printf() for debug prints
by Felix Singer (Code Review) 29 Dec '21

29 Dec '21

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60383 ) Change subject: ec/hp/kbc1126/acpi: Use Printf() for debug prints ...................................................................... ec/hp/kbc1126/acpi: Use Printf() for debug prints Built with BUILD_TIMELESS=1 and coreboot.rom remains identical. Change-Id: Id343bde61706d4d1de2102c3567141e427d8126d Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60383 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/ec/hp/kbc1126/acpi/ac.asl M src/ec/hp/kbc1126/acpi/battery.asl M src/ec/hp/kbc1126/acpi/ec.asl M src/ec/hp/kbc1126/acpi/lid.asl 4 files changed, 12 insertions(+), 12 deletions(-) Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved diff --git a/src/ec/hp/kbc1126/acpi/ac.asl b/src/ec/hp/kbc1126/acpi/ac.asl index f9d346b..f058cef 100644 --- a/src/ec/hp/kbc1126/acpi/ac.asl +++ b/src/ec/hp/kbc1126/acpi/ac.asl @@ -65,7 +65,7 @@ Method (_Q06, 0, NotSerialized) { - Store ("EC: AC STATUS", Debug) + Printf ("EC: AC STATUS") PWUP (0x05, (0x02 | 0x01)) If (BTDR (0x02)) { diff --git a/src/ec/hp/kbc1126/acpi/battery.asl b/src/ec/hp/kbc1126/acpi/battery.asl index 6669726..003e58b 100644 --- a/src/ec/hp/kbc1126/acpi/battery.asl +++ b/src/ec/hp/kbc1126/acpi/battery.asl @@ -437,7 +437,7 @@ Method (_Q03, 0, NotSerialized) { - Store ("EC: _Q03", Debug) + Printf ("EC: _Q03") Acquire (BTMX, 0xFFFF) Local0 = NDCB Release (BTMX) @@ -447,7 +447,7 @@ Method (_Q08, 0, NotSerialized) { - Store ("EC: PRIMARY BATTERY ATTACHED/DETACHED", Debug) + Printf ("EC: PRIMARY BATTERY ATTACHED/DETACHED") PWUP (0x06, 0x01) Local0 = GBAP () If ((Local0 != 0x02)) @@ -467,7 +467,7 @@ Method (_Q09, 0, NotSerialized) { - Store ("EC: PRIMARY BATTERY STATUS", Debug) + Printf ("EC: PRIMARY BATTERY STATUS") PWUP (0x04, 0x01) If (BTDR (0x02)) { @@ -477,7 +477,7 @@ Method (_Q18, 0, NotSerialized) { - Store("EC: SECONDARY BATTERY ATTACHED/DETACHED", Debug) + Printf ("EC: SECONDARY BATTERY ATTACHED/DETACHED") PWUP (0x06, 0x02) Local0 = GBAP () If ((Local0 != 0x01)) @@ -497,7 +497,7 @@ Method (_Q19, 0, NotSerialized) { - Store ("EC: SECONDARY BATTERY STATUS", Debug) + Printf ("EC: SECONDARY BATTERY STATUS") PWUP (0x04, 0x02) If (BTDR (0x02)) { diff --git a/src/ec/hp/kbc1126/acpi/ec.asl b/src/ec/hp/kbc1126/acpi/ec.asl index 81bdff9..4c0056d 100644 --- a/src/ec/hp/kbc1126/acpi/ec.asl +++ b/src/ec/hp/kbc1126/acpi/ec.asl @@ -202,27 +202,27 @@ Method (_Q04, 0, NotSerialized) { - Store ("EC: _Q04", Debug) + Printf ("EC: _Q04") PNOT() } Method (_Q05, 0, NotSerialized) { - Store ("EC: _Q05", Debug) + Printf ("EC: _Q05") } Method (_Q0B, 0, NotSerialized) { - Store ("EC: _Q0B", Debug) + Printf ("EC: _Q0B") } Method (_Q0C, 0, NotSerialized) { - Store ("EC: _Q0C", Debug) + Printf ("EC: _Q0C") } Method (_Q0D, 0, NotSerialized) { - Store ("EC: _Q0D", Debug) + Printf ("EC: _Q0D") } } diff --git a/src/ec/hp/kbc1126/acpi/lid.asl b/src/ec/hp/kbc1126/acpi/lid.asl index 2494168..1a5134f 100644 --- a/src/ec/hp/kbc1126/acpi/lid.asl +++ b/src/ec/hp/kbc1126/acpi/lid.asl @@ -12,6 +12,6 @@ Method (_Q0A, 0, NotSerialized) { - Store ("EC: LID STATUS", Debug) + Printf ("EC: LID STATUS") Notify (LID, 0x80) } 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/coreboot/+/60383 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id343bde61706d4d1de2102c3567141e427d8126d Gerrit-Change-Number: 60383 Gerrit-PatchSet: 5 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: ec/chromeec/ec/acpi: Use Printf() for debug prints
by Felix Singer (Code Review) 29 Dec '21

29 Dec '21

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60381 ) Change subject: ec/chromeec/ec/acpi: Use Printf() for debug prints ...................................................................... ec/chromeec/ec/acpi: Use Printf() for debug prints Built with BUILD_TIMELESS=1 and coreboot.rom remains identical. Change-Id: I2b06f74be155e0c4053a38a1c5fd30ff6715111e Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60381 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/ec/google/chromeec/acpi/ec.asl 1 file changed, 21 insertions(+), 21 deletions(-) Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved diff --git a/src/ec/google/chromeec/acpi/ec.asl b/src/ec/google/chromeec/acpi/ec.asl index 7b1a663..f521e27 100644 --- a/src/ec/google/chromeec/acpi/ec.asl +++ b/src/ec/google/chromeec/acpi/ec.asl @@ -209,7 +209,7 @@ // Lid Closed Event Method (_Q01, 0, NotSerialized) { - Store ("EC: LID CLOSE", Debug) + Printf ("EC: LID CLOSE") Store (LIDS, \LIDS) #ifdef EC_ENABLE_LID_SWITCH Notify (LID0, 0x80) @@ -219,7 +219,7 @@ // Lid Open Event Method (_Q02, 0, NotSerialized) { - Store ("EC: LID OPEN", Debug) + Printf ("EC: LID OPEN") Store (LIDS, \LIDS) Notify (CREC, 0x2) #ifdef EC_ENABLE_LID_SWITCH @@ -230,13 +230,13 @@ // Power Button Method (_Q03, 0, NotSerialized) { - Store ("EC: POWER BUTTON", Debug) + Printf ("EC: POWER BUTTON") } // AC Connected Method (_Q04, 0, NotSerialized) { - Store ("EC: AC CONNECTED", Debug) + Printf ("EC: AC CONNECTED") Store (ACEX, \PWRS) Notify (AC, 0x80) #ifdef DPTF_ENABLE_CHARGER @@ -250,7 +250,7 @@ // AC Disconnected Method (_Q05, 0, NotSerialized) { - Store ("EC: AC DISCONNECTED", Debug) + Printf ("EC: AC DISCONNECTED") Store (ACEX, \PWRS) Notify (AC, 0x80) #ifdef DPTF_ENABLE_CHARGER @@ -264,21 +264,21 @@ // Battery Low Event Method (_Q06, 0, NotSerialized) { - Store ("EC: BATTERY LOW", Debug) + Printf ("EC: BATTERY LOW") Notify (BAT0, 0x80) } // Battery Critical Event Method (_Q07, 0, NotSerialized) { - Store ("EC: BATTERY CRITICAL", Debug) + Printf ("EC: BATTERY CRITICAL") Notify (BAT0, 0x80) } // Battery Info Event Method (_Q08, 0, NotSerialized) { - Store ("EC: BATTERY INFO", Debug) + Printf ("EC: BATTERY INFO") Notify (BAT0, 0x81) #ifdef EC_ENABLE_SECOND_BATTERY_DEVICE If (CondRefOf (BAT1)) { @@ -290,41 +290,41 @@ // Thermal Overload Event Method (_Q0A, 0, NotSerialized) { - Store ("EC: THERMAL OVERLOAD", Debug) + Printf ("EC: THERMAL OVERLOAD") Notify (\_TZ, 0x80) } // Thermal Event Method (_Q0B, 0, NotSerialized) { - Store ("EC: THERMAL", Debug) + Printf ("EC: THERMAL") Notify (\_TZ, 0x80) } // USB Charger Method (_Q0C, 0, NotSerialized) { - Store ("EC: USB CHARGER", Debug) + Printf ("EC: USB CHARGER") } // Key Pressed Method (_Q0D, 0, NotSerialized) { - Store ("EC: KEY PRESSED", Debug) + Printf ("EC: KEY PRESSED") Notify (CREC, 0x2) } // Thermal Shutdown Imminent Method (_Q10, 0, NotSerialized) { - Store ("EC: THERMAL SHUTDOWN", Debug) + Printf ("EC: THERMAL SHUTDOWN") Notify (\_TZ, 0x80) } // Battery Shutdown Imminent Method (_Q11, 0, NotSerialized) { - Store ("EC: BATTERY SHUTDOWN", Debug) + Printf ("EC: BATTERY SHUTDOWN") Notify (BAT0, 0x80) } @@ -332,7 +332,7 @@ Method (_Q12, 0, NotSerialized) { #ifdef EC_ENABLE_THROTTLING_HANDLER - Store ("EC: THROTTLE START", Debug) + Printf ("EC: THROTTLE START") \_TZ.THRT (1) #endif } @@ -341,7 +341,7 @@ Method (_Q13, 0, NotSerialized) { #ifdef EC_ENABLE_THROTTLING_HANDLER - Store ("EC: THROTTLE STOP", Debug) + Printf ("EC: THROTTLE STOP") \_TZ.THRT (0) #endif } @@ -350,7 +350,7 @@ // PD event Method (_Q16, 0, NotSerialized) { - Store ("EC: GOT PD EVENT", Debug) + Printf ("EC: GOT PD EVENT") Notify (\_SB.PCI0.LPCB.EC0.CREC.ECPD, 0x80) } #endif @@ -358,7 +358,7 @@ // Battery Status Method (_Q17, 0, NotSerialized) { - Store ("EC: BATTERY STATUS", Debug) + Printf ("EC: BATTERY STATUS") Notify (BAT0, 0x80) #ifdef EC_ENABLE_SECOND_BATTERY_DEVICE If (CondRefOf (BAT1)) { @@ -370,7 +370,7 @@ // MKBP interrupt. Method (_Q1B, 0, NotSerialized) { - Store ("EC: MKBP", Debug) + Printf ("EC: MKBP") Notify (CREC, 0x80) } @@ -378,7 +378,7 @@ // USB MUX Interrupt Method (_Q1C, 0, NotSerialized) { - Store ("EC: USB MUX", Debug) + Printf ("EC: USB MUX") Notify (\_SB.PCI0.LPCB.EC0.CREC.ECPD, 0x80) } #endif @@ -386,7 +386,7 @@ // TABLET mode switch Event Method (_Q1D, 0, NotSerialized) { - Store ("EC: TABLET mode switch Event", Debug) + Printf ("EC: TABLET mode switch Event") Notify (CREC, 0x2) #ifdef EC_ENABLE_MULTIPLE_DPTF_PROFILES \_SB.DPTF.TPET() 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/coreboot/+/60381 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2b06f74be155e0c4053a38a1c5fd30ff6715111e Gerrit-Change-Number: 60381 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: ec/starlabs/merlin: Use Printf() for debug prints
by Felix Singer (Code Review) 29 Dec '21

29 Dec '21

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60380 ) Change subject: ec/starlabs/merlin: Use Printf() for debug prints ...................................................................... ec/starlabs/merlin: Use Printf() for debug prints Built with BUILD_TIMELESS=1 and coreboot.rom remains identical. Change-Id: Ib59cba7bf553e8323c20fd9aa3474f3ecccf465a Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60380 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/ec/starlabs/merlin/acpi/keyboard.asl M src/ec/starlabs/merlin/variants/apl/events.asl M src/ec/starlabs/merlin/variants/cml/events.asl M src/ec/starlabs/merlin/variants/glk/events.asl M src/ec/starlabs/merlin/variants/kbl/events.asl M src/ec/starlabs/merlin/variants/merlin/events.asl M src/ec/starlabs/merlin/variants/tgl/events.asl 7 files changed, 135 insertions(+), 135 deletions(-) Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved diff --git a/src/ec/starlabs/merlin/acpi/keyboard.asl b/src/ec/starlabs/merlin/acpi/keyboard.asl index 0078c4c..fc7b1e4 100644 --- a/src/ec/starlabs/merlin/acpi/keyboard.asl +++ b/src/ec/starlabs/merlin/acpi/keyboard.asl @@ -2,25 +2,25 @@ Method(_Q80) // Volume up { - Store ("-----> _Q80", Debug) + Printf ("-----> _Q80") Notify (\_SB.HIDD, 0xC4) Notify (\_SB.HIDD, 0xC5) - Store ("<----- _Q80", Debug) + Printf ("<----- _Q80") } Method(_Q81) // Volume down { - Store ("-----> _Q81", Debug) + Printf ("-----> _Q81") Notify (\_SB.HIDD, 0xC6) Notify (\_SB.HIDD, 0xC7) - Store ("<----- _Q81", Debug) + Printf ("<----- _Q81") } Method(_Q99) // Wireless mode { - Store ("-----> _Q99", Debug) + Printf ("-----> _Q99") ^^^^HIDD.HPEM (8) - Store ("<----- _Q99", Debug) + Printf ("<----- _Q99") } Method(_Q06) // Brightness decrease @@ -40,20 +40,20 @@ Method(_Q54) // Power Button Event { - Store ("-----> _Q54", Debug) - Store ("<----- _Q54", Debug) + Printf ("-----> _Q54") + Printf ("<----- _Q54") } Method(_QD5) // 10 second power button press { - Store ("-----> _QD5", Debug) + Printf ("-----> _QD5") \_SB.PWPR() - Store ("<----- _QD5", Debug) + Printf ("<----- _QD5") } Method(_QD6) // 10 second power button de-press { - Store ("-----> _QD6", Debug) + Printf ("-----> _QD6") \_SB.PWRR() - Store ("<----- _QD6", Debug) + Printf ("<----- _QD6") } diff --git a/src/ec/starlabs/merlin/variants/apl/events.asl b/src/ec/starlabs/merlin/variants/apl/events.asl index 5271d8e..d9e4913 100644 --- a/src/ec/starlabs/merlin/variants/apl/events.asl +++ b/src/ec/starlabs/merlin/variants/apl/events.asl @@ -70,27 +70,27 @@ Method (_Q22, 0, NotSerialized) // Event: CHARGER_T { - Store ("EC: CHARGER_T", Debug) + Printf ("EC: CHARGER_T") } Method (_Q80, 0, NotSerialized) // Event: Volume Up { - Store ("EC: VOLUME_UP", Debug) + Printf ("EC: VOLUME_UP") } Method (_Q81, 0, NotSerialized) // Event: Volume Down { - Store ("EC: VOLUME_DOWN", Debug) + Printf ("EC: VOLUME_DOWN") } Method (_Q54, 0, NotSerialized) // Event: Power Button Press { - Store ("EC: PWRBTN", Debug) + Printf ("EC: PWRBTN") } Method (_QF0, 0, NotSerialized) // Event: Temperature Report { - Store ("EC: Temperature Report", Debug) + Printf ("EC: Temperature Report") } Method (_QF1, 0, NotSerialized) // Event: Temperature Trigger diff --git a/src/ec/starlabs/merlin/variants/cml/events.asl b/src/ec/starlabs/merlin/variants/cml/events.asl index 9333c9e..bf7b967 100644 --- a/src/ec/starlabs/merlin/variants/cml/events.asl +++ b/src/ec/starlabs/merlin/variants/cml/events.asl @@ -69,7 +69,7 @@ Method (_Q22, 0, NotSerialized) // Event: CHARGER_T { - Store ("EC: CHARGER_T", Debug) + Printf ("EC: CHARGER_T") } Method (_Q40, 0, NotSerialized) // Event: AC and DC Power @@ -99,22 +99,22 @@ Method (_Q80, 0, NotSerialized) // Event: Volume Up { - Store ("EC: VOLUME_UP", Debug) + Printf ("EC: VOLUME_UP") } Method (_Q81, 0, NotSerialized) // Event: Volume Down { - Store ("EC: VOLUME_DOWN", Debug) + Printf ("EC: VOLUME_DOWN") } Method (_Q54, 0, NotSerialized) // Event: Power Button Press { - Store ("EC: PWRBTN", Debug) + Printf ("EC: PWRBTN") } Method (_QF0, 0, NotSerialized) // Event: Temperature Report { - Store ("EC: Temperature Report", Debug) + Printf ("EC: Temperature Report") } Method (_QF1, 0, NotSerialized) // Event: Temperature Trigger @@ -129,15 +129,15 @@ Method (_Q02, 0, NotSerialized) // Event: APP { - Store ("EC: APP", Debug) + Printf ("EC: APP") } Method (_Q82, 0, NotSerialized) // Event: MIC { - Store ("EC: MIC", Debug) + Printf ("EC: MIC") } Method (_Q83, 0, NotSerialized) // Event: MUTE { - Store ("EC: MUTE", Debug) + Printf ("EC: MUTE") } diff --git a/src/ec/starlabs/merlin/variants/glk/events.asl b/src/ec/starlabs/merlin/variants/glk/events.asl index 5271d8e..d9e4913 100644 --- a/src/ec/starlabs/merlin/variants/glk/events.asl +++ b/src/ec/starlabs/merlin/variants/glk/events.asl @@ -70,27 +70,27 @@ Method (_Q22, 0, NotSerialized) // Event: CHARGER_T { - Store ("EC: CHARGER_T", Debug) + Printf ("EC: CHARGER_T") } Method (_Q80, 0, NotSerialized) // Event: Volume Up { - Store ("EC: VOLUME_UP", Debug) + Printf ("EC: VOLUME_UP") } Method (_Q81, 0, NotSerialized) // Event: Volume Down { - Store ("EC: VOLUME_DOWN", Debug) + Printf ("EC: VOLUME_DOWN") } Method (_Q54, 0, NotSerialized) // Event: Power Button Press { - Store ("EC: PWRBTN", Debug) + Printf ("EC: PWRBTN") } Method (_QF0, 0, NotSerialized) // Event: Temperature Report { - Store ("EC: Temperature Report", Debug) + Printf ("EC: Temperature Report") } Method (_QF1, 0, NotSerialized) // Event: Temperature Trigger diff --git a/src/ec/starlabs/merlin/variants/kbl/events.asl b/src/ec/starlabs/merlin/variants/kbl/events.asl index d546632..c9eb1f9 100644 --- a/src/ec/starlabs/merlin/variants/kbl/events.asl +++ b/src/ec/starlabs/merlin/variants/kbl/events.asl @@ -71,7 +71,7 @@ Method (_Q22, 0, NotSerialized) // Event: CHARGER_T { - Store ("EC: CHARGER_T", Debug) + Printf ("EC: CHARGER_T") } // @@ -105,22 +105,22 @@ Method (_Q80, 0, NotSerialized) // Event: Volume Up { - Store ("EC: VOLUME_UP", Debug) + Printf ("EC: VOLUME_UP") } Method (_Q81, 0, NotSerialized) // Event: Volume Down { - Store ("EC: VOLUME_DOWN", Debug) + Printf ("EC: VOLUME_DOWN") } Method (_Q54, 0, NotSerialized) // Event: Power Button Press { - Store ("EC: PWRBTN", Debug) + Printf ("EC: PWRBTN") } Method (_QF0, 0, NotSerialized) // Event: Temperature Report { - Store ("EC: Temperature Report", Debug) + Printf ("EC: Temperature Report") } Method (_QF1, 0, NotSerialized) // Event: Temperature Trigger @@ -135,141 +135,141 @@ Method (_Q85, 0, NotSerialized) // Event: HOME { - Store ("EC: HOME", Debug) + Printf ("EC: HOME") } Method (_Q79, 0, NotSerialized) // Event: USB Type-C { - Store ("EC: USB Type-C", Debug) + Printf ("EC: USB Type-C") UCEV() } Method (_Q0E, 0, NotSerialized) // Event: SLEEP { - Store ("EC: SLEEP", Debug) + Printf ("EC: SLEEP") } Method (_Q13, 0, NotSerialized) // Event: BRIGHTNESS { - Store ("EC: BRIGHTNESS", Debug) + Printf ("EC: BRIGHTNESS") } Method (_Q20, 0, NotSerialized) // Event: CPU_T { - Store ("EC: CPU_T", Debug) + Printf ("EC: CPU_T") } Method (_Q21, 0, NotSerialized) // Event: SKIN_T { - Store ("EC: SKIN_T", Debug) + Printf ("EC: SKIN_T") } Method (_Q30, 0, NotSerialized) // Event: THROT_OFF { - Store ("EC: THROT_OFF", Debug) + Printf ("EC: THROT_OFF") } Method (_Q31, 0, NotSerialized) // Event: THROT_LV1 { - Store ("EC: THROT_LV1", Debug) + Printf ("EC: THROT_LV1") } Method (_Q32, 0, NotSerialized) // Event: THROT_LV2 { - Store ("EC: THROT_LV2", Debug) + Printf ("EC: THROT_LV2") } Method (_Q33, 0, NotSerialized) // Event: THROT_LV3 { - Store ("EC: THROT_LV3", Debug) + Printf ("EC: THROT_LV3") } Method (_Q34, 0, NotSerialized) // Event: THROT_LV4 { - Store ("EC: THROT_LV4", Debug) + Printf ("EC: THROT_LV4") } Method (_Q35, 0, NotSerialized) // Event: THROT_LV5 { - Store ("EC: THROT_LV5", Debug) + Printf ("EC: THROT_LV5") } Method (_Q36, 0, NotSerialized) // Event: THROT_LV6 { - Store ("EC: THROT_LV6", Debug) + Printf ("EC: THROT_LV6") } Method (_Q37, 0, NotSerialized) // Event: THROT_LV7 { - Store ("EC: THROT_LV7", Debug) + Printf ("EC: THROT_LV7") } Method (_Q38, 0, NotSerialized) // Event: CPU_DN_SPEED { - Store ("EC: CPU_DN_SPEED", Debug) + Printf ("EC: CPU_DN_SPEED") } Method (_Q3C, 0, NotSerialized) // Event: CPU_UP_SPEED { - Store ("EC: CPU_UP_SPEED", Debug) + Printf ("EC: CPU_UP_SPEED") } Method (_Q3D, 0, NotSerialized) // Event: CPU_TURBO_OFF { - Store ("EC: CPU_TURBO_OFF", Debug) + Printf ("EC: CPU_TURBO_OFF") } Method (_Q3E, 0, NotSerialized) // Event: CPU_TURBO_ON { - Store ("EC: CPU_TURBO_ON", Debug) + Printf ("EC: CPU_TURBO_ON") } Method (_Q3F, 0, NotSerialized) // Event: SHUTDOWN { - Store ("EC: SHUTDOWN", Debug) + Printf ("EC: SHUTDOWN") } Method (_Q01, 0, NotSerialized) // Event: F1 Hot Key { - Store ("EC: F1", Debug) + Printf ("EC: F1") } Method (_Q02, 0, NotSerialized) // Event: F2 Hot Key { - Store ("EC: F2", Debug) + Printf ("EC: F2") } Method (_Q03, 0, NotSerialized) // Event: F3 Hot Key { - Store ("EC: F3", Debug) + Printf ("EC: F3") } Method (_Q04, 0, NotSerialized) // Event: F4 Hot Key { - Store ("EC: F4", Debug) + Printf ("EC: F4") } Method (_Q05, 0, NotSerialized) // Event: F5 Hot Key { - Store ("EC: F5", Debug) + Printf ("EC: F5") } Method (_Q09, 0, NotSerialized) // Event: F9 Hot Key { - Store ("EC: F9", Debug) + Printf ("EC: F9") } Method (_Q10, 0, NotSerialized) // Event: F10 Hot Key { - Store ("EC: F10", Debug) + Printf ("EC: F10") } Method (_Q11, 0, NotSerialized) // Event: F11 Hot Key { - Store ("EC: F11", Debug) + Printf ("EC: F11") } Method (_Q12, 0, NotSerialized) // Event: F12 Hot Key { - Store ("EC: F6", Debug) + Printf ("EC: F6") } diff --git a/src/ec/starlabs/merlin/variants/merlin/events.asl b/src/ec/starlabs/merlin/variants/merlin/events.asl index bd1516e..3cb37d6 100644 --- a/src/ec/starlabs/merlin/variants/merlin/events.asl +++ b/src/ec/starlabs/merlin/variants/merlin/events.asl @@ -56,17 +56,17 @@ Method (_QD5) // Event: 10 Second Power Button Pressed { - Store ("EC: 10 Second Power Button Pressed", Debug) + Printf ("EC: 10 Second Power Button Pressed") } Method (_QD6) // Event: 10 Second Power Button Released { - Store ("EC: 10 Second Power Button Release", Debug) + Printf ("EC: 10 Second Power Button Release") } Method (_Q22, 0, NotSerialized) // Event: CHARGER_T { - Store ("EC: CHARGER_T", Debug) + Printf ("EC: CHARGER_T") } Method (_Q40) // Event: AC_DC @@ -96,22 +96,22 @@ Method (_Q80, 0, NotSerialized) // Event: VOLUME_UP { - Store ("EC: VOLUME_UP", Debug) + Printf ("EC: VOLUME_UP") } Method (_Q81, 0, NotSerialized) // Event: VOLUME_DOWN { - Store ("EC: VOLUME_DOWN", Debug) + Printf ("EC: VOLUME_DOWN") } Method (_Q54, 0, NotSerialized) // Event: PWRBTN { - Store ("EC: PWRBTN", Debug) + Printf ("EC: PWRBTN") } Method (_QF0) // Event: Temperature Report { - Store ("EC: Temperature Report", Debug) + Printf ("EC: Temperature Report") } Method (_QF1) // Event: Temperature Trigger @@ -125,143 +125,143 @@ Method (_Q79, 0, NotSerialized) // Event: USB Type-C { - Store ("EC: USB Type-C", Debug) + Printf ("EC: USB Type-C") UCEV() } Method (_Q85, 0, NotSerialized) // Event: HOME { - Store ("EC: HOME", Debug) + Printf ("EC: HOME") } Method (_Q01) // Event: F1 Hot Key { - Store ("EC: F1", Debug) + Printf ("EC: F1") } Method (_Q02) // Event: F2 Hot Key { - Store ("EC: F2", Debug) + Printf ("EC: F2") } Method (_Q03) // Event: F3 Hot Key { - Store ("EC: F3", Debug) + Printf ("EC: F3") } Method (_Q04) // Event: F4 Hot Key { - Store ("EC: F4", Debug) + Printf ("EC: F4") } Method (_Q08) // Event: F5 Hot Key { - Store ("EC: F5", Debug) + Printf ("EC: F5") } Method (_Q09) // Event: F6 Hot Key { - Store ("EC: F6", Debug) + Printf ("EC: F6") } Method (_Q07) // Event: F7 Hot Key { - Store ("EC: F7", Debug) + Printf ("EC: F7") } Method (_Q10) // Event: F10 Hot Key { - Store ("EC: F10", Debug) + Printf ("EC: F10") } Method (_Q12) // Event: F12 Hot Key { - Store ("EC: F6", Debug) + Printf ("EC: F6") } Method (_Q0E, 0, NotSerialized) // Event: SLEEP { - Store ("EC: SLEEP", Debug) + Printf ("EC: SLEEP") } Method (_Q13, 0, NotSerialized) // Event: BRIGHTNESS { - Store ("EC: BRIGHTNESS", Debug) + Printf ("EC: BRIGHTNESS") } Method (_Q20, 0, NotSerialized) // Event: CPU_T { - Store ("EC: CPU_T", Debug) + Printf ("EC: CPU_T") } Method (_Q21, 0, NotSerialized) // Event: SKIN_T { - Store ("EC: SKIN_T", Debug) + Printf ("EC: SKIN_T") } Method (_Q30, 0, NotSerialized) // Event: THROT_OFF { - Store ("EC: THROT_OFF", Debug) + Printf ("EC: THROT_OFF") } Method (_Q31, 0, NotSerialized) // Event: THROT_LV1 { - Store ("EC: THROT_LV1", Debug) + Printf ("EC: THROT_LV1") } Method (_Q32, 0, NotSerialized) // Event: THROT_LV2 { - Store ("EC: THROT_LV2", Debug) + Printf ("EC: THROT_LV2") } Method (_Q33, 0, NotSerialized) // Event: THROT_LV3 { - Store ("EC: THROT_LV3", Debug) + Printf ("EC: THROT_LV3") } Method (_Q34, 0, NotSerialized) // Event: THROT_LV4 { - Store ("EC: THROT_LV4", Debug) + Printf ("EC: THROT_LV4") } Method (_Q35, 0, NotSerialized) // Event: THROT_LV5 { - Store ("EC: THROT_LV5", Debug) + Printf ("EC: THROT_LV5") } Method (_Q36, 0, NotSerialized) // Event: THROT_LV6 { - Store ("EC: THROT_LV6", Debug) + Printf ("EC: THROT_LV6") } Method (_Q37, 0, NotSerialized) // Event: THROT_LV7 { - Store ("EC: THROT_LV7", Debug) + Printf ("EC: THROT_LV7") } Method (_Q38, 0, NotSerialized) // Event: CPU_DN_SPEED { - Store ("EC: CPU_DN_SPEED", Debug) + Printf ("EC: CPU_DN_SPEED") } Method (_Q3C, 0, NotSerialized) // Event: CPU_UP_SPEED { - Store ("EC: CPU_UP_SPEED", Debug) + Printf ("EC: CPU_UP_SPEED") } Method (_Q3D, 0, NotSerialized) // Event: CPU_TURBO_OFF { - Store ("EC: CPU_TURBO_OFF", Debug) + Printf ("EC: CPU_TURBO_OFF") } Method (_Q3E, 0, NotSerialized) // Event: CPU_TURBO_ON { - Store ("EC: CPU_TURBO_ON", Debug) + Printf ("EC: CPU_TURBO_ON") } Method (_Q3F, 0, NotSerialized) // Event: SHUTDOWN { - Store ("EC: SHUTDOWN", Debug) + Printf ("EC: SHUTDOWN") } Method (_Q45) // Event: SENSOR_T76 @@ -271,10 +271,10 @@ Method (_Q48, 0, NotSerialized) // Event: Fan Turbo On { - Store ("EC: Fan Turbo On", Debug) + Printf ("EC: Fan Turbo On") } Method (_Q49, 0, NotSerialized) // Event: Fan Turbo Off { - Store ("EC: Fan Turbo Off", Debug) + Printf ("EC: Fan Turbo Off") } diff --git a/src/ec/starlabs/merlin/variants/tgl/events.asl b/src/ec/starlabs/merlin/variants/tgl/events.asl index ba09c8a..9c74ac9 100644 --- a/src/ec/starlabs/merlin/variants/tgl/events.asl +++ b/src/ec/starlabs/merlin/variants/tgl/events.asl @@ -65,7 +65,7 @@ Method (_Q22, 0, NotSerialized) // Event: CHARGER_T { - Store ("EC: CHARGER_T", Debug) + Printf ("EC: CHARGER_T") } Method (_Q40, 0, NotSerialized) // Event: AC and DC Power @@ -95,22 +95,22 @@ Method (_Q80, 0, NotSerialized) // Event: Volume Up { - Store ("EC: VOLUME_UP", Debug) + Printf ("EC: VOLUME_UP") } Method (_Q81, 0, NotSerialized) // Event: Volume Down { - Store ("EC: VOLUME_DOWN", Debug) + Printf ("EC: VOLUME_DOWN") } Method (_Q54, 0, NotSerialized) // Event: Power Button Press { - Store ("EC: PWRBTN", Debug) + Printf ("EC: PWRBTN") } Method (_QF0, 0, NotSerialized) // Event: Temperature Report { - Store ("EC: Temperature Report", Debug) + Printf ("EC: Temperature Report") } Method (_QF1, 0, NotSerialized) // Event: Temperature Trigger @@ -124,143 +124,143 @@ Method (_Q79, 0, NotSerialized) // Event: USB Type-C { - Store ("EC: USB Type-C", Debug) + Printf ("EC: USB Type-C") UCEV() } Method (_Q85, 0, NotSerialized) // Event: HOME { - Store ("EC: HOME", Debug) + Printf ("EC: HOME") } Method (_Q01, 0, NotSerialized) // Event: F1 Hot Key { - Store ("EC: F1", Debug) + Printf ("EC: F1") } Method (_Q02, 0, NotSerialized) // Event: F2 Hot Key { - Store ("EC: F2", Debug) + Printf ("EC: F2") } Method (_Q03, 0, NotSerialized) // Event: F3 Hot Key { - Store ("EC: F3", Debug) + Printf ("EC: F3") } Method (_Q04, 0, NotSerialized) // Event: F4 Hot Key { - Store ("EC: F4", Debug) + Printf ("EC: F4") } Method (_Q08, 0, NotSerialized) // Event: F5 Hot Key { - Store ("EC: F5", Debug) + Printf ("EC: F5") } Method (_Q09, 0, NotSerialized) // Event: F6 Hot Key { - Store ("EC: F6", Debug) + Printf ("EC: F6") } Method (_Q07, 0, NotSerialized) // Event: F7 Hot Key { - Store ("EC: F7", Debug) + Printf ("EC: F7") } Method (_Q10, 0, NotSerialized) // Event: F10 Hot Key { - Store ("EC: F10", Debug) + Printf ("EC: F10") } Method (_Q12, 0, NotSerialized) // Event: F12 Hot Key { - Store ("EC: F6", Debug) + Printf ("EC: F6") } Method (_Q0E, 0, NotSerialized) // Event: SLEEP { - Store ("EC: SLEEP", Debug) + Printf ("EC: SLEEP") } Method (_Q13, 0, NotSerialized) // Event: BRIGHTNESS { - Store ("EC: BRIGHTNESS", Debug) + Printf ("EC: BRIGHTNESS") } Method (_Q20, 0, NotSerialized) // Event: CPU_T { - Store ("EC: CPU_T", Debug) + Printf ("EC: CPU_T") } Method (_Q21, 0, NotSerialized) // Event: SKIN_T { - Store ("EC: SKIN_T", Debug) + Printf ("EC: SKIN_T") } Method (_Q30, 0, NotSerialized) // Event: THROT_OFF { - Store ("EC: THROT_OFF", Debug) + Printf ("EC: THROT_OFF") } Method (_Q31, 0, NotSerialized) // Event: THROT_LV1 { - Store ("EC: THROT_LV1", Debug) + Printf ("EC: THROT_LV1") } Method (_Q32, 0, NotSerialized) // Event: THROT_LV2 { - Store ("EC: THROT_LV2", Debug) + Printf ("EC: THROT_LV2") } Method (_Q33, 0, NotSerialized) // Event: THROT_LV3 { - Store ("EC: THROT_LV3", Debug) + Printf ("EC: THROT_LV3") } Method (_Q34, 0, NotSerialized) // Event: THROT_LV4 { - Store ("EC: THROT_LV4", Debug) + Printf ("EC: THROT_LV4") } Method (_Q35, 0, NotSerialized) // Event: THROT_LV5 { - Store ("EC: THROT_LV5", Debug) + Printf ("EC: THROT_LV5") } Method (_Q36, 0, NotSerialized) // Event: THROT_LV6 { - Store ("EC: THROT_LV6", Debug) + Printf ("EC: THROT_LV6") } Method (_Q37, 0, NotSerialized) // Event: THROT_LV7 { - Store ("EC: THROT_LV7", Debug) + Printf ("EC: THROT_LV7") } Method (_Q38, 0, NotSerialized) // Event: CPU_DN_SPEED { - Store ("EC: CPU_DN_SPEED", Debug) + Printf ("EC: CPU_DN_SPEED") } Method (_Q3C, 0, NotSerialized) // Event: CPU_UP_SPEED { - Store ("EC: CPU_UP_SPEED", Debug) + Printf ("EC: CPU_UP_SPEED") } Method (_Q3D, 0, NotSerialized) // Event: CPU_TURBO_OFF { - Store ("EC: CPU_TURBO_OFF", Debug) + Printf ("EC: CPU_TURBO_OFF") } Method (_Q3E, 0, NotSerialized) // Event: CPU_TURBO_ON { - Store ("EC: CPU_TURBO_ON", Debug) + Printf ("EC: CPU_TURBO_ON") } Method (_Q3F, 0, NotSerialized) // Event: SHUTDOWN { - Store ("EC: SHUTDOWN", Debug) + Printf ("EC: SHUTDOWN") } Method (_Q45, 0, NotSerialized) // Event: SENSOR_T76 @@ -270,10 +270,10 @@ Method (_Q48, 0, NotSerialized) // Event: Fan Turbo On { - Store ("EC: Fan Turbo On", Debug) + Printf ("EC: Fan Turbo On") } Method (_Q49, 0, NotSerialized) // Event: Fan Turbo Off { - Store ("EC: Fan Turbo Off", Debug) + Printf ("EC: Fan Turbo Off") } 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/coreboot/+/60380 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib59cba7bf553e8323c20fd9aa3474f3ecccf465a Gerrit-Change-Number: 60380 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: mb/google/corsola: initialize krabby display
by Yu-Ping Wu (Code Review) 29 Dec '21

29 Dec '21

Attention is currently required from: Hung-Te Lin, Rex-BC Chen. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60447 ) Change subject: mb/google/corsola: initialize krabby display ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > hi Hung-te and Yu-ping, […] Can we remove corsola as a Coreboot board? Another solution is to select GOOGLE_KINGLER_COMMON for it. -- To view, visit https://review.coreboot.org/c/coreboot/+/60447 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I314d5407c40429bb7bc50f36fece58e396b27548 Gerrit-Change-Number: 60447 Gerrit-PatchSet: 1 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Comment-Date: Wed, 29 Dec 2021 13:33:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/skylake/acpi: Use ACPI 2.0 syntax to access arrays
by Felix Singer (Code Review) 29 Dec '21

29 Dec '21

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60460 ) Change subject: soc/intel/skylake/acpi: Use ACPI 2.0 syntax to access arrays ...................................................................... soc/intel/skylake/acpi: Use ACPI 2.0 syntax to access arrays Replace Index(FOO, 1337) with FOO[1337]. Change-Id: I3bc780a60e34fb72020d8dbba3db0ed096fa930d Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/soc/intel/skylake/acpi/xhci.asl 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/60460/1 diff --git a/src/soc/intel/skylake/acpi/xhci.asl b/src/soc/intel/skylake/acpi/xhci.asl index 734539b..196af97 100644 --- a/src/soc/intel/skylake/acpi/xhci.asl +++ b/src/soc/intel/skylake/acpi/xhci.asl @@ -223,11 +223,11 @@ }) // REV: Revision 0x02 for ACPI 5.0 - CreateField (DerefOf (Index (PCKG, Zero)), Zero, 0x07, REV) + CreateField (DerefOf (PCKG[0]), Zero, 0x07, REV) REV = 0x02 // VISI: Port visibility to user per port - CreateField (DerefOf (Index (PCKG, Zero)), 0x40, One, VISI) + CreateField (DerefOf (PCKG[0]), 0x40, One, VISI) VISI = Arg0 Return (PCKG) -- To view, visit https://review.coreboot.org/c/coreboot/+/60460 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3bc780a60e34fb72020d8dbba3db0ed096fa930d Gerrit-Change-Number: 60460 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: ec/smsc/mec1308/acpi: Use ACPI 2.0 syntax to access arrays
by Felix Singer (Code Review) 29 Dec '21

29 Dec '21

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60459 ) Change subject: ec/smsc/mec1308/acpi: Use ACPI 2.0 syntax to access arrays ...................................................................... ec/smsc/mec1308/acpi: Use ACPI 2.0 syntax to access arrays Replace Index(FOO, 1337) with FOO[1337]. Change-Id: I628a6108e12ba784542474ebe58285754f40169c Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/ec/smsc/mec1308/acpi/battery.asl 1 file changed, 11 insertions(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/60459/1 diff --git a/src/ec/smsc/mec1308/acpi/battery.asl b/src/ec/smsc/mec1308/acpi/battery.asl index fad69b8..a072c93 100644 --- a/src/ec/smsc/mec1308/acpi/battery.asl +++ b/src/ec/smsc/mec1308/acpi/battery.asl @@ -81,15 +81,15 @@ Method (_BIF, 0, Serialized) { // Update fields from EC - Store (SWAB (BTDA), Index (PBIF, 1)) - Store (SWAB (BTDF), Index (PBIF, 2)) - Store (SWAB (BTDV), Index (PBIF, 4)) - Store (SWAB (BTDL), Index (PBIF, 6)) + Store (SWAB (BTDA), PBIF[1]) + Store (SWAB (BTDF), PBIF[2]) + Store (SWAB (BTDV), PBIF[4]) + Store (SWAB (BTDL), PBIF[6]) // Get battery info from mainboard - Store (\BATM, Index (PBIF, 9)) - Store (\BATS, Index (PBIF, 10)) - Store (\BATV, Index (PBIF, 12)) + Store (\BATM, PBIF[9]) + Store (\BATS, PBIF[10]) + Store (\BATV, PBIF[12]) Return (PBIF) } @@ -120,7 +120,7 @@ // Flag if the battery level is critical And (Local0, 0x04, Local4) Or (Local1, Local4, Local1) - Store (Local1, Index (PBST, 0)) + Store (Local1, PBST[0]) // Notify if battery state has changed since last time If (LNotEqual (Local1, BSTP)) { @@ -138,7 +138,7 @@ Xor (Local1, 0xFFFF, Local1) Increment (Local1) } - Store (Local1, Index (PBST, 1)) + Store (Local1, PBST[1]) // // 2: BATTERY REMAINING CAPACITY @@ -165,12 +165,12 @@ Store (Local2, Local1) } } - Store (Local1, Index (PBST, 2)) + Store (Local1, PBST[2]) // // 3: BATTERY PRESENT VOLTAGE // - Store (SWAB (BTVO), Index (PBST, 3)) + Store (SWAB (BTVO), PBST[3]) Return (PBST) } -- To view, visit https://review.coreboot.org/c/coreboot/+/60459 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I628a6108e12ba784542474ebe58285754f40169c Gerrit-Change-Number: 60459 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: ec/hp/kbc1126/acpi: Use ACPI 2.0 syntax to access arrays
by Felix Singer (Code Review) 29 Dec '21

29 Dec '21

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60458 ) Change subject: ec/hp/kbc1126/acpi: Use ACPI 2.0 syntax to access arrays ...................................................................... ec/hp/kbc1126/acpi: Use ACPI 2.0 syntax to access arrays Replace Index(FOO, 1337) with FOO[1337]. Change-Id: Ie499f27acd13569095749e095d7898890da6985d Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/ec/hp/kbc1126/acpi/battery.asl 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/60458/1 diff --git a/src/ec/hp/kbc1126/acpi/battery.asl b/src/ec/hp/kbc1126/acpi/battery.asl index 003e58b..5a6e5dc 100644 --- a/src/ec/hp/kbc1126/acpi/battery.asl +++ b/src/ec/hp/kbc1126/acpi/battery.asl @@ -230,7 +230,7 @@ { Local1-- Divide (Local0, 10, Local2, Local0) - Add (Local2, 48, Index (NUMB, Local1)) + Add (Local2, 48, NUMB[Local1]) } ToString (NUMB, Arg1, Local3) Return (Local3) -- To view, visit https://review.coreboot.org/c/coreboot/+/60458 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie499f27acd13569095749e095d7898890da6985d Gerrit-Change-Number: 60458 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2021