coreboot-gerrit December 2021

coreboot-gerrit@coreboot.org

1 participants
5525 discussions

Change in coreboot[master]: northbridge/intel/ironlake/acpi: Use Printf() for debug prints
by HAOUAS Elyes (Code Review) 29 Dec '21

29 Dec '21

Attention is currently required from: Felix Singer, Patrick Rudolph. HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60452 ) Change subject: northbridge/intel/ironlake/acpi: Use Printf() for debug prints ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60452 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5d3af659255548e84ef676387ca994588c69438c Gerrit-Change-Number: 60452 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Wed, 29 Dec 2021 13:01:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: southbridge/intel/bd82x6x/acpi: Use Printf() for debug prints
by HAOUAS Elyes (Code Review) 29 Dec '21

29 Dec '21

Attention is currently required from: Felix Singer, Patrick Rudolph. HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60453 ) Change subject: southbridge/intel/bd82x6x/acpi: Use Printf() for debug prints ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60453 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I68488f120bc80ea4ba2aa4760e15c7175bf1fb41 Gerrit-Change-Number: 60453 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Wed, 29 Dec 2021 13:00:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: southbridge/intel/bd82x6x/acpi: Use Printf() for debug prints
by Felix Singer (Code Review) 29 Dec '21

29 Dec '21

Attention is currently required from: Patrick Rudolph. Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60453 ) Change subject: southbridge/intel/bd82x6x/acpi: Use Printf() for debug prints ...................................................................... southbridge/intel/bd82x6x/acpi: Use Printf() for debug prints Change-Id: I68488f120bc80ea4ba2aa4760e15c7175bf1fb41 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/southbridge/intel/bd82x6x/acpi/usb.asl 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/60453/1 diff --git a/src/southbridge/intel/bd82x6x/acpi/usb.asl b/src/southbridge/intel/bd82x6x/acpi/usb.asl index 15a2f9b..3e2ba78 100644 --- a/src/southbridge/intel/bd82x6x/acpi/usb.asl +++ b/src/southbridge/intel/bd82x6x/acpi/usb.asl @@ -149,7 +149,7 @@ // Query flag clear and xHCI in auto mode If(!(CDW1 & 0x1) && (XHCI == 2 || XHCI == 3)) { - Debug = "XHCI Switch" + Printf ("XHCI Switch") Local0 = 0 Local0 = XPRT & 0x03 If(Local0 == 0 || Local0 == 1) { -- To view, visit https://review.coreboot.org/c/coreboot/+/60453 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I68488f120bc80ea4ba2aa4760e15c7175bf1fb41 Gerrit-Change-Number: 60453 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: northbridge/intel/ironlake/acpi: Use Printf() for debug prints
by Felix Singer (Code Review) 29 Dec '21

29 Dec '21

Attention is currently required from: Patrick Rudolph. Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60452 ) Change subject: northbridge/intel/ironlake/acpi: Use Printf() for debug prints ...................................................................... northbridge/intel/ironlake/acpi: Use Printf() for debug prints Change-Id: I5d3af659255548e84ef676387ca994588c69438c Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/northbridge/intel/ironlake/acpi/hostbridge.asl 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/60452/1 diff --git a/src/northbridge/intel/ironlake/acpi/hostbridge.asl b/src/northbridge/intel/ironlake/acpi/hostbridge.asl index 5e6ad52..d2e5eb1 100644 --- a/src/northbridge/intel/ironlake/acpi/hostbridge.asl +++ b/src/northbridge/intel/ironlake/acpi/hostbridge.asl @@ -119,7 +119,7 @@ Return (0) } - Debug = "Set TDP Down" + Printf ("Set TDP Down") /* Set CTC */ CTCS = CTCD @@ -155,7 +155,7 @@ Return (0) } - Debug = "Set TDP Nominal" + Printf ("Set TDP Nominal") /* Set PL1 */ PL1V = CTDN -- To view, visit https://review.coreboot.org/c/coreboot/+/60452 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5d3af659255548e84ef676387ca994588c69438c Gerrit-Change-Number: 60452 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: northbridge/intel/sandybridge/acpi: Use Printf() for debug prints
by Felix Singer (Code Review) 29 Dec '21

29 Dec '21

Attention is currently required from: Angel Pons, Patrick Rudolph. Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60451 ) Change subject: northbridge/intel/sandybridge/acpi: Use Printf() for debug prints ...................................................................... northbridge/intel/sandybridge/acpi: Use Printf() for debug prints Change-Id: I58c2545c881572127b6d34b5527c5d4bd7d97dfb Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/northbridge/intel/sandybridge/acpi/hostbridge.asl 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/60451/1 diff --git a/src/northbridge/intel/sandybridge/acpi/hostbridge.asl b/src/northbridge/intel/sandybridge/acpi/hostbridge.asl index 4ce4cb6..5421725 100644 --- a/src/northbridge/intel/sandybridge/acpi/hostbridge.asl +++ b/src/northbridge/intel/sandybridge/acpi/hostbridge.asl @@ -156,7 +156,7 @@ Return (0) } - Debug = "Set TDP Down" + Printf ("Set TDP Down") /* Set CTC */ CTCS = CTCD @@ -192,7 +192,7 @@ Return (0) } - Debug = "Set TDP Nominal" + Printf ("Set TDP Nominal") /* Set PL1 */ PL1V = CTDN -- To view, visit https://review.coreboot.org/c/coreboot/+/60451 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I58c2545c881572127b6d34b5527c5d4bd7d97dfb Gerrit-Change-Number: 60451 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: northbridge/intel/haswell/acpi: Use Printf() for debug prints
by Felix Singer (Code Review) 29 Dec '21

29 Dec '21

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60450 ) Change subject: northbridge/intel/haswell/acpi: Use Printf() for debug prints ...................................................................... northbridge/intel/haswell/acpi: Use Printf() for debug prints Change-Id: I3f500ec46a9046a4e8ca50a85965b8e1225f8a33 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/northbridge/intel/haswell/acpi/ctdp.asl 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/60450/1 diff --git a/src/northbridge/intel/haswell/acpi/ctdp.asl b/src/northbridge/intel/haswell/acpi/ctdp.asl index 565b2d2..bc43a81 100644 --- a/src/northbridge/intel/haswell/acpi/ctdp.asl +++ b/src/northbridge/intel/haswell/acpi/ctdp.asl @@ -99,7 +99,7 @@ Return (0) } - Debug = "Set TDP Down" + Printf ("Set TDP Down") /* Set CTC */ CTCS = CTCD @@ -135,7 +135,7 @@ Return (0) } - Debug = "Set TDP Nominal" + Printf ("Set TDP Nominal") /* Set PL1 */ PL1V = CTDN @@ -173,7 +173,7 @@ Return (0) } - Debug = "Enable PL1 Limit" + Printf ("Enable PL1 Limit") /* Set _PPC to LFM */ Local0 = PSSS (LFM_) @@ -201,7 +201,7 @@ Return (0) } - Debug = "Disable PL1 Limit" + Printf ("Disable PL1 Limit") /* Clear PL1 CLAMP bit */ PL1C = 0 -- To view, visit https://review.coreboot.org/c/coreboot/+/60450 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3f500ec46a9046a4e8ca50a85965b8e1225f8a33 Gerrit-Change-Number: 60450 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/brya/var/kano: Enable stylus pen power
by David Wu (Code Review) 29 Dec '21

29 Dec '21

David Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60449 ) Change subject: mb/google/brya/var/kano: Enable stylus pen power ...................................................................... mb/google/brya/var/kano: Enable stylus pen power Set GPP_D16 (PEN_PWR_EN) to output high. BUG=b:195853169 TEST=build pass. Signed-off-by: David Wu <david_wu(a)quanta.corp-partner.google.com> Change-Id: I25b6d1a40ed0939b303a03984cb0087fb6cab4d7 --- M src/mainboard/google/brya/variants/kano/gpio.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/60449/1 diff --git a/src/mainboard/google/brya/variants/kano/gpio.c b/src/mainboard/google/brya/variants/kano/gpio.c index d77abea..b635d55 100644 --- a/src/mainboard/google/brya/variants/kano/gpio.c +++ b/src/mainboard/google/brya/variants/kano/gpio.c @@ -36,6 +36,8 @@ PAD_NC(GPP_D7, NONE), /* D8 : SRCCLKREQ3# ==> NC */ PAD_NC(GPP_D8, NONE), + /* D16 : ISH_UART0_CTS# ==> PEN_PWR_EN */ + PAD_CFG_GPO(GPP_D16, 1, DEEP), /* D17 : UART1_RXD ==> APU_PEN_DETECT_ODL */ PAD_CFG_GPI_SCI(GPP_D17, NONE, DEEP, EDGE_SINGLE, NONE), /* D18 : UART1_TXD ==> NC */ -- To view, visit https://review.coreboot.org/c/coreboot/+/60449 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I25b6d1a40ed0939b303a03984cb0087fb6cab4d7 Gerrit-Change-Number: 60449 Gerrit-PatchSet: 1 Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: crossgcc/buildgcc: Remove unused GCC_AUTOCONF_VERSION
by Felix Singer (Code Review) 29 Dec '21

29 Dec '21

Attention is currently required from: Paul Menzel, HAOUAS Elyes. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59398 ) Change subject: crossgcc/buildgcc: Remove unused GCC_AUTOCONF_VERSION ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/59398 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7d293ae2c8663efdc9ad4146ff32671ffd3e176a Gerrit-Change-Number: 59398 Gerrit-PatchSet: 6 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Comment-Date: Wed, 29 Dec 2021 11:38:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/alderlake: Add option to make MRC log silent
by Subrata Banik (Code Review) 29 Dec '21

29 Dec '21

Attention is currently required from: Felix Singer, Subrata Banik, Tim Wawrzynczak, Angel Pons, Arthur Heymans, Nick Vaccaro, Andrey Petrov, Patrick Rudolph. Hello Felix Singer, build bot (Jenkins), Tim Wawrzynczak, Angel Pons, Arthur Heymans, Nick Vaccaro, Tim Wawrzynczak, Andrey Petrov, Patrick Rudolph, EricR Lai, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60441 to look at the new patch set (#2). Change subject: soc/intel/alderlake: Add option to make MRC log silent ...................................................................... soc/intel/alderlake: Add option to make MRC log silent Typically, FSP-M aka MRC debug log level is default set to `3` meaning prints all `Load, Error, Warnings & Info` Messages. Sometime it's too much information to parse even when users aren't required to have such detailed information hence, added option to make the MRC serial debug message silent when user selects `SILENT_FSP_M_DEBUG_MESSAGE` config. TEST=FSP-M debug log suggested default `SerialDebugMrcLevel` UPD value is `3`. While user selects `SILENT_FSP_M_DEBUG_MESSAGE` config `SerialDebugMrcLevel` UPD value is overridden to '0' aka disable. Signed-off-by: Subrata Banik <subratabanik(a)google.com> Change-Id: Iea3b32feca0893a83fdf700798b0883d26ccc718 --- M src/drivers/intel/fsp2_0/Kconfig.debug_blob M src/soc/intel/alderlake/Kconfig M src/soc/intel/alderlake/romstage/fsp_params.c 3 files changed, 26 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/60441/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60441 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iea3b32feca0893a83fdf700798b0883d26ccc718 Gerrit-Change-Number: 60441 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/brya/var/brask: Change TPM I2C to I2C1
by Zhuohao Lee (Code Review) 29 Dec '21

29 Dec '21

Attention is currently required from: David Wu, Tim Wawrzynczak, Alan Huang, Zhuohao Lee. Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60439 ) Change subject: mb/google/brya/var/brask: Change TPM I2C to I2C1 ...................................................................... Patch Set 3: (1 comment) Patchset: PS2: > Could you revise gpio.c in variants/brask as well? Thanks. […] Yeah, we also need to change the default GPIO setting. -- To view, visit https://review.coreboot.org/c/coreboot/+/60439 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I70d5a8fde1866c5dd4587ab5af2d41724c60ee0c Gerrit-Change-Number: 60439 Gerrit-PatchSet: 3 Gerrit-Owner: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Reviewer: Alan Huang <alan-huang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-CC: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Alan Huang <alan-huang(a)quanta.corp-partner.google.com> Gerrit-Attention: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Comment-Date: Wed, 29 Dec 2021 11:15:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2021