coreboot-gerrit December 2021

coreboot-gerrit@coreboot.org

1 participants
5525 discussions

Change in coreboot[master]: ec/smsc/mec1308/acpi: Use ASL 2.0 syntax to access arrays
by Felix Singer (Code Review) 30 Dec '21

30 Dec '21

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60459 ) Change subject: ec/smsc/mec1308/acpi: Use ASL 2.0 syntax to access arrays ...................................................................... ec/smsc/mec1308/acpi: Use ASL 2.0 syntax to access arrays Replace Index(FOO, 1337) with FOO[1337]. Change-Id: I628a6108e12ba784542474ebe58285754f40169c Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60459 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> --- M src/ec/smsc/mec1308/acpi/battery.asl 1 file changed, 11 insertions(+), 11 deletions(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved diff --git a/src/ec/smsc/mec1308/acpi/battery.asl b/src/ec/smsc/mec1308/acpi/battery.asl index fad69b8..a072c93 100644 --- a/src/ec/smsc/mec1308/acpi/battery.asl +++ b/src/ec/smsc/mec1308/acpi/battery.asl @@ -81,15 +81,15 @@ Method (_BIF, 0, Serialized) { // Update fields from EC - Store (SWAB (BTDA), Index (PBIF, 1)) - Store (SWAB (BTDF), Index (PBIF, 2)) - Store (SWAB (BTDV), Index (PBIF, 4)) - Store (SWAB (BTDL), Index (PBIF, 6)) + Store (SWAB (BTDA), PBIF[1]) + Store (SWAB (BTDF), PBIF[2]) + Store (SWAB (BTDV), PBIF[4]) + Store (SWAB (BTDL), PBIF[6]) // Get battery info from mainboard - Store (\BATM, Index (PBIF, 9)) - Store (\BATS, Index (PBIF, 10)) - Store (\BATV, Index (PBIF, 12)) + Store (\BATM, PBIF[9]) + Store (\BATS, PBIF[10]) + Store (\BATV, PBIF[12]) Return (PBIF) } @@ -120,7 +120,7 @@ // Flag if the battery level is critical And (Local0, 0x04, Local4) Or (Local1, Local4, Local1) - Store (Local1, Index (PBST, 0)) + Store (Local1, PBST[0]) // Notify if battery state has changed since last time If (LNotEqual (Local1, BSTP)) { @@ -138,7 +138,7 @@ Xor (Local1, 0xFFFF, Local1) Increment (Local1) } - Store (Local1, Index (PBST, 1)) + Store (Local1, PBST[1]) // // 2: BATTERY REMAINING CAPACITY @@ -165,12 +165,12 @@ Store (Local2, Local1) } } - Store (Local1, Index (PBST, 2)) + Store (Local1, PBST[2]) // // 3: BATTERY PRESENT VOLTAGE // - Store (SWAB (BTVO), Index (PBST, 3)) + Store (SWAB (BTVO), PBST[3]) Return (PBST) } -- To view, visit https://review.coreboot.org/c/coreboot/+/60459 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I628a6108e12ba784542474ebe58285754f40169c Gerrit-Change-Number: 60459 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: ec/hp/kbc1126/acpi: Use ASL 2.0 syntax to access arrays
by Felix Singer (Code Review) 30 Dec '21

30 Dec '21

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60458 ) Change subject: ec/hp/kbc1126/acpi: Use ASL 2.0 syntax to access arrays ...................................................................... ec/hp/kbc1126/acpi: Use ASL 2.0 syntax to access arrays Replace Index(FOO, 1337) with FOO[1337]. Change-Id: Ie499f27acd13569095749e095d7898890da6985d Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60458 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> --- M src/ec/hp/kbc1126/acpi/battery.asl 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved diff --git a/src/ec/hp/kbc1126/acpi/battery.asl b/src/ec/hp/kbc1126/acpi/battery.asl index 003e58b..5a6e5dc 100644 --- a/src/ec/hp/kbc1126/acpi/battery.asl +++ b/src/ec/hp/kbc1126/acpi/battery.asl @@ -230,7 +230,7 @@ { Local1-- Divide (Local0, 10, Local2, Local0) - Add (Local2, 48, Index (NUMB, Local1)) + Add (Local2, 48, NUMB[Local1]) } ToString (NUMB, Arg1, Local3) Return (Local3) -- To view, visit https://review.coreboot.org/c/coreboot/+/60458 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie499f27acd13569095749e095d7898890da6985d Gerrit-Change-Number: 60458 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: ec/google/chromeec/acpi: Use ASL 2.0 syntax to access arrays
by Felix Singer (Code Review) 30 Dec '21

30 Dec '21

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60457 ) Change subject: ec/google/chromeec/acpi: Use ASL 2.0 syntax to access arrays ...................................................................... ec/google/chromeec/acpi: Use ASL 2.0 syntax to access arrays Replace Index(FOO, 1337) with FOO[1337]. Change-Id: I2fb96e338b332f4fbb3bd23fb07bb1ca36c19c49 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60457 Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/ec/google/chromeec/acpi/battery.asl 1 file changed, 21 insertions(+), 21 deletions(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved diff --git a/src/ec/google/chromeec/acpi/battery.asl b/src/ec/google/chromeec/acpi/battery.asl index d9304c1..fc9edc9 100644 --- a/src/ec/google/chromeec/acpi/battery.asl +++ b/src/ec/google/chromeec/acpi/battery.asl @@ -68,27 +68,27 @@ Return (Arg1) } // Last Full Charge Capacity - Store (BTDF, Index (Arg1, 2)) + Store (BTDF, Arg1[2]) // Design Voltage - Store (BTDV, Index (Arg1, 4)) + Store (BTDV, Arg1[4]) // Design Capacity Store (BTDA, Local0) - Store (Local0, Index (Arg1, 1)) + Store (Local0, Arg1[1]) // Design Capacity of Warning Divide (Multiply (Local0, DWRN), 100, , Local2) - Store (Local2, Index (Arg1, 5)) + Store (Local2, Arg1[5]) // Design Capacity of Low Divide (Multiply (Local0, DLOW), 100, , Local2) - Store (Local2, Index (Arg1, 6)) + Store (Local2, Arg1[6]) // Get battery info from mainboard - Store (ToString(Concatenate(BMOD, 0x00)), Index (Arg1, 9)) - Store (ToString(Concatenate(BSER, 0x00)), Index (Arg1, 10)) - Store (ToString(Concatenate(BMFG, 0x00)), Index (Arg1, 12)) + Store (ToString(Concatenate(BMOD, 0x00)), Arg1[9]) + Store (ToString(Concatenate(BSER, 0x00)), Arg1[10]) + Store (ToString(Concatenate(BMFG, 0x00)), Arg1[12]) Release (^BATM) Return (Arg1) @@ -108,30 +108,30 @@ Return (Arg1) } // Last Full Charge Capacity - Store (BTDF, Index (Arg1, 3)) + Store (BTDF, Arg1[3]) // Design Voltage - Store (BTDV, Index (Arg1, 5)) + Store (BTDV, Arg1[5]) // Design Capacity Store (BTDA, Local0) - Store (Local0, Index (Arg1, 2)) + Store (Local0, Arg1[2]) // Design Capacity of Warning Divide (Multiply (Local0, DWRN), 100, , Local2) - Store (Local2, Index (Arg1, 6)) + Store (Local2, Arg1[6]) // Design Capacity of Low Divide (Multiply (Local0, DLOW), 100, , Local2) - Store (Local2, Index (Arg1, 7)) + Store (Local2, Arg1[7]) // Cycle Count - Store (BTCC, Index (Arg1, 8)) + Store (BTCC, Arg1[8]) // Get battery info from mainboard - Store (ToString(Concatenate(BMOD, 0x00)), Index (Arg1, 16)) - Store (ToString(Concatenate(BSER, 0x00)), Index (Arg1, 17)) - Store (ToString(Concatenate(BMFG, 0x00)), Index (Arg1, 19)) + Store (ToString(Concatenate(BMOD, 0x00)), Arg1[16]) + Store (ToString(Concatenate(BSER, 0x00)), Arg1[17]) + Store (ToString(Concatenate(BMFG, 0x00)), Arg1[19]) Release (^BATM) Return (Arg1) @@ -177,7 +177,7 @@ If (BFCR) { Or (Local1, 0x04, Local1) } - Store (Local1, Index (Arg1, 0)) + Store (Local1, Arg1[0]) // Notify if battery state has changed since last time If (LNotEqual (Local1, DeRefOf (Arg2))) { @@ -195,7 +195,7 @@ // // 1: BATTERY PRESENT RATE // - Store (BTPR, Index (Arg1, 1)) + Store (BTPR, Arg1[1]) // // 2: BATTERY REMAINING CAPACITY @@ -216,12 +216,12 @@ Store (Local2, Local1) } } - Store (Local1, Index (Arg1, 2)) + Store (Local1, Arg1[2]) // // 3: BATTERY PRESENT VOLTAGE // - Store (BTVO, Index (Arg1, 3)) + Store (BTVO, Arg1[3]) Release (^BATM) Return (Arg1) -- To view, visit https://review.coreboot.org/c/coreboot/+/60457 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2fb96e338b332f4fbb3bd23fb07bb1ca36c19c49 Gerrit-Change-Number: 60457 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: drivers/intel/gma/acpi: Use ASL 2.0 syntax to access arrays
by Felix Singer (Code Review) 30 Dec '21

30 Dec '21

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60456 ) Change subject: drivers/intel/gma/acpi: Use ASL 2.0 syntax to access arrays ...................................................................... drivers/intel/gma/acpi: Use ASL 2.0 syntax to access arrays Replace Index(FOO, 1337) with FOO[1337]. Change-Id: I534c1581e587908feeb06fd7725c5895649dcfb1 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60456 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> --- M src/drivers/intel/gma/acpi/common.asl M src/drivers/intel/gma/acpi/configure_brightness_levels.asl 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved diff --git a/src/drivers/intel/gma/acpi/common.asl b/src/drivers/intel/gma/acpi/common.asl index 79960e1..254a66d 100644 --- a/src/drivers/intel/gma/acpi/common.asl +++ b/src/drivers/intel/gma/acpi/common.asl @@ -42,7 +42,7 @@ { Decrement (Local0) } - XBCM (DerefOf (Index (BRIG, Local0))) + XBCM (DerefOf (BRIG[Local0])) } } @@ -60,6 +60,6 @@ { Increment (Local0) } - XBCM (DerefOf (Index (BRIG, Local0))) + XBCM (DerefOf (BRIG[Local0])) } } diff --git a/src/drivers/intel/gma/acpi/configure_brightness_levels.asl b/src/drivers/intel/gma/acpi/configure_brightness_levels.asl index 0ab93d8..92ae766 100644 --- a/src/drivers/intel/gma/acpi/configure_brightness_levels.asl +++ b/src/drivers/intel/gma/acpi/configure_brightness_levels.asl @@ -123,8 +123,8 @@ Store (2, Local1) While (LLess (Local1, Subtract (SizeOf (BRIG), 1))) { /* Local[23]: adjacent values in BRIG */ - Store (DeRefOf (Index (BRIG, Local1)), Local2) - Store (DeRefOf (Index (BRIG, Add (Local1, 1))), Local3) + Store (DeRefOf (BRIG[Local1]), Local2) + Store (DeRefOf (BRIG[Add (Local1, 1)]), Local3) If (LLess (Local0, Local3)) { If (LOr (LLess (Local0, Local2), -- To view, visit https://review.coreboot.org/c/coreboot/+/60456 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I534c1581e587908feeb06fd7725c5895649dcfb1 Gerrit-Change-Number: 60456 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: ec/quanta/it8518/acpi: Use ASL 2.0 syntax to access arrays
by Felix Singer (Code Review) 30 Dec '21

30 Dec '21

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60455 ) Change subject: ec/quanta/it8518/acpi: Use ASL 2.0 syntax to access arrays ...................................................................... ec/quanta/it8518/acpi: Use ASL 2.0 syntax to access arrays Replace Index(FOO, 1337) with FOO[1337]. Change-Id: I0b1fe0fcdf2862dc76f07ef1478929f7c726ac47 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60455 Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/ec/quanta/it8518/acpi/battery.asl 1 file changed, 16 insertions(+), 16 deletions(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved diff --git a/src/ec/quanta/it8518/acpi/battery.asl b/src/ec/quanta/it8518/acpi/battery.asl index 768f2b1..adbde93 100644 --- a/src/ec/quanta/it8518/acpi/battery.asl +++ b/src/ec/quanta/it8518/acpi/battery.asl @@ -106,7 +106,7 @@ // ACPI spec : 0 - mWh : 1 - mAh // Store(SBCM, Local7) - XOr (Local7, One, Index (PBIF, 0)) + XOr (Local7, One, PBIF[0]) // // Information ID 0 - @@ -119,11 +119,11 @@ // If (Local7) { - Multiply (SBFC, 10, Index (PBIF, 2)) + Multiply (SBFC, 10, PBIF[2]) } Else { - Store (SBFC, Index (PBIF, 2)) + Store (SBFC, PBIF[2]) } // @@ -143,24 +143,24 @@ { Store (SBDC, Local0) } - Store (Local0, Index(PBIF, One)) + Store (Local0, PBIF[1]) // // Design capacity of High (5%) // Design capacity of Low (1%) // - Divide (Local0, 20, , Index (PBIF, 5)) - Divide (Local0, 100, , Index (PBIF, 6)) + Divide (Local0, 20, , PBIF[5]) + Divide (Local0, 100, , PBIF[6]) // // Design voltage // - Store (SBDV, Index (PBIF, 4)) + Store (SBDV, PBIF[4]) // // Serial Number // - Store (ToHexString (SBSN), Index (PBIF, 10)) + Store (ToHexString (SBSN), PBIF[10]) // // Information ID 4 - @@ -171,7 +171,7 @@ // // Battery Type - Device Chemistry // - Store (ToString (Concatenate(SBCH, 0x00)), Index (PBIF, 11)) + Store (ToString (Concatenate(SBCH, 0x00)), PBIF[11]) // // Information ID 5 - @@ -182,7 +182,7 @@ // // OEM Information - Manufacturer Name // - Store (ToString (Concatenate(SBMN, 0x00)), Index (PBIF, 12)) + Store (ToString (Concatenate(SBMN, 0x00)), PBIF[12]) // // Information ID 6 - @@ -193,7 +193,7 @@ // // Model Number - Device Name // - Store (ToString (Concatenate(SBDN, 0x00)), Index (PBIF, 9)) + Store (ToString (Concatenate(SBDN, 0x00)), PBIF[9]) Return (PBIF) } @@ -255,7 +255,7 @@ // Flag if the battery level is critical And (Local0, 0x04, Local4) Or (Local1, Local4, Local1) - Store (Local1, Index (PBST, 0)) + Store (Local1, PBST[0]) // // 1: BATTERY PRESENT RATE/CURRENT @@ -282,14 +282,14 @@ } } - XOr (DerefOf (Index (PBIF, Zero)), One, Local6) + XOr (DerefOf (PBIF[0]), One, Local6) If (Local6) { Multiply (ECVO, Local1, Local1) Divide (Local1, 1000, , Local1) } - Store (Local1, Index (PBST, One)) + Store (Local1, PBST[1]) // // 2: BATTERY REMAINING CAPACITY @@ -323,12 +323,12 @@ Store (Local2, Local1) } } - Store (Local1, Index (PBST, 2)) + Store (Local1, PBST[2]) // // 3: BATTERY PRESENT VOLTAGE // - Store (ECVO, Index (PBST, 3)) + Store (ECVO, PBST[3]) Return (PBST) } -- To view, visit https://review.coreboot.org/c/coreboot/+/60455 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0b1fe0fcdf2862dc76f07ef1478929f7c726ac47 Gerrit-Change-Number: 60455 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: mb/51nb/x210/acpi: Use ASL 2.0 syntax to access arrays
by Felix Singer (Code Review) 30 Dec '21

30 Dec '21

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60454 ) Change subject: mb/51nb/x210/acpi: Use ASL 2.0 syntax to access arrays ...................................................................... mb/51nb/x210/acpi: Use ASL 2.0 syntax to access arrays Replace Index(FOO, 1337) with FOO[1337]. Change-Id: I5692d1be5a94d259bbed987a43ec17ad1c1f915c Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60454 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> --- M src/mainboard/51nb/x210/acpi/battery.asl 1 file changed, 9 insertions(+), 9 deletions(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved diff --git a/src/mainboard/51nb/x210/acpi/battery.asl b/src/mainboard/51nb/x210/acpi/battery.asl index f9022a4..bf5c9b0 100644 --- a/src/mainboard/51nb/x210/acpi/battery.asl +++ b/src/mainboard/51nb/x210/acpi/battery.asl @@ -37,19 +37,19 @@ Method (_BIF, 0, Serialized) { /* Design Capacity */ - Store (DGCP * 10000 / DGVO, Index (PBIF, 1)) + Store (DGCP * 10000 / DGVO, PBIF[1]) /* Last Full Charge Capacity */ - Store (FLCP * 10000 / DGVO, Index (PBIF, 2)) + Store (FLCP * 10000 / DGVO, PBIF[2]) /* Design Voltage */ - Store (DGVO, Index (PBIF, 4)) + Store (DGVO, PBIF[4]) /* Design Capacity of Warning */ - Store (BDW * 10000 / DGVO, Index (PBIF, 5)) + Store (BDW * 10000 / DGVO, PBIF[5]) /* Design Capacity of Low */ - Store (BDL, Index (PBIF, 6)) + Store (BDL, PBIF[6]) Return (PBIF) } @@ -70,22 +70,22 @@ * bit 1 = charging * bit 2 = critical level */ - Store (BSTS, Index (PBST, 0)) + Store (BSTS, PBST[0]) /* * 1: BATTERY PRESENT RATE */ - Store (BPR, Index (PBST, 1)) + Store (BPR, PBST[1]) /* * 2: BATTERY REMAINING CAPACITY */ - Store (BRC * 10000 / DGVO, Index (PBST, 2)) + Store (BRC * 10000 / DGVO, PBST[2]) /* * 3: BATTERY PRESENT VOLTAGE */ - Store (BPV, Index (PBST, 3)) + Store (BPV, PBST[3]) Return (PBST) } -- To view, visit https://review.coreboot.org/c/coreboot/+/60454 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5692d1be5a94d259bbed987a43ec17ad1c1f915c Gerrit-Change-Number: 60454 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: southbridge/intel/bd82x6x/acpi: Use Printf() for debug prints
by Felix Singer (Code Review) 30 Dec '21

30 Dec '21

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60453 ) Change subject: southbridge/intel/bd82x6x/acpi: Use Printf() for debug prints ...................................................................... southbridge/intel/bd82x6x/acpi: Use Printf() for debug prints Change-Id: I68488f120bc80ea4ba2aa4760e15c7175bf1fb41 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60453 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> --- M src/southbridge/intel/bd82x6x/acpi/usb.asl 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved diff --git a/src/southbridge/intel/bd82x6x/acpi/usb.asl b/src/southbridge/intel/bd82x6x/acpi/usb.asl index 15a2f9b..3e2ba78 100644 --- a/src/southbridge/intel/bd82x6x/acpi/usb.asl +++ b/src/southbridge/intel/bd82x6x/acpi/usb.asl @@ -149,7 +149,7 @@ // Query flag clear and xHCI in auto mode If(!(CDW1 & 0x1) && (XHCI == 2 || XHCI == 3)) { - Debug = "XHCI Switch" + Printf ("XHCI Switch") Local0 = 0 Local0 = XPRT & 0x03 If(Local0 == 0 || Local0 == 1) { 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/coreboot/+/60453 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I68488f120bc80ea4ba2aa4760e15c7175bf1fb41 Gerrit-Change-Number: 60453 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: northbridge/intel/ironlake/acpi: Use Printf() for debug prints
by Felix Singer (Code Review) 30 Dec '21

30 Dec '21

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60452 ) Change subject: northbridge/intel/ironlake/acpi: Use Printf() for debug prints ...................................................................... northbridge/intel/ironlake/acpi: Use Printf() for debug prints Change-Id: I5d3af659255548e84ef676387ca994588c69438c Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60452 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> --- M src/northbridge/intel/ironlake/acpi/hostbridge.asl 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved diff --git a/src/northbridge/intel/ironlake/acpi/hostbridge.asl b/src/northbridge/intel/ironlake/acpi/hostbridge.asl index 5e6ad52..d2e5eb1 100644 --- a/src/northbridge/intel/ironlake/acpi/hostbridge.asl +++ b/src/northbridge/intel/ironlake/acpi/hostbridge.asl @@ -119,7 +119,7 @@ Return (0) } - Debug = "Set TDP Down" + Printf ("Set TDP Down") /* Set CTC */ CTCS = CTCD @@ -155,7 +155,7 @@ Return (0) } - Debug = "Set TDP Nominal" + Printf ("Set TDP Nominal") /* Set PL1 */ PL1V = CTDN 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/coreboot/+/60452 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5d3af659255548e84ef676387ca994588c69438c Gerrit-Change-Number: 60452 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: northbridge/intel/sandybridge/acpi: Use Printf() for debug prints
by Felix Singer (Code Review) 30 Dec '21

30 Dec '21

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60451 ) Change subject: northbridge/intel/sandybridge/acpi: Use Printf() for debug prints ...................................................................... northbridge/intel/sandybridge/acpi: Use Printf() for debug prints Change-Id: I58c2545c881572127b6d34b5527c5d4bd7d97dfb Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60451 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> --- M src/northbridge/intel/sandybridge/acpi/hostbridge.asl 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved diff --git a/src/northbridge/intel/sandybridge/acpi/hostbridge.asl b/src/northbridge/intel/sandybridge/acpi/hostbridge.asl index 4ce4cb6..5421725 100644 --- a/src/northbridge/intel/sandybridge/acpi/hostbridge.asl +++ b/src/northbridge/intel/sandybridge/acpi/hostbridge.asl @@ -156,7 +156,7 @@ Return (0) } - Debug = "Set TDP Down" + Printf ("Set TDP Down") /* Set CTC */ CTCS = CTCD @@ -192,7 +192,7 @@ Return (0) } - Debug = "Set TDP Nominal" + Printf ("Set TDP Nominal") /* Set PL1 */ PL1V = CTDN 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/coreboot/+/60451 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I58c2545c881572127b6d34b5527c5d4bd7d97dfb Gerrit-Change-Number: 60451 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: northbridge/intel/haswell/acpi: Use Printf() for debug prints
by Felix Singer (Code Review) 30 Dec '21

30 Dec '21

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60450 ) Change subject: northbridge/intel/haswell/acpi: Use Printf() for debug prints ...................................................................... northbridge/intel/haswell/acpi: Use Printf() for debug prints Change-Id: I3f500ec46a9046a4e8ca50a85965b8e1225f8a33 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60450 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> --- M src/northbridge/intel/haswell/acpi/ctdp.asl 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved diff --git a/src/northbridge/intel/haswell/acpi/ctdp.asl b/src/northbridge/intel/haswell/acpi/ctdp.asl index 565b2d2..bc43a81 100644 --- a/src/northbridge/intel/haswell/acpi/ctdp.asl +++ b/src/northbridge/intel/haswell/acpi/ctdp.asl @@ -99,7 +99,7 @@ Return (0) } - Debug = "Set TDP Down" + Printf ("Set TDP Down") /* Set CTC */ CTCS = CTCD @@ -135,7 +135,7 @@ Return (0) } - Debug = "Set TDP Nominal" + Printf ("Set TDP Nominal") /* Set PL1 */ PL1V = CTDN @@ -173,7 +173,7 @@ Return (0) } - Debug = "Enable PL1 Limit" + Printf ("Enable PL1 Limit") /* Set _PPC to LFM */ Local0 = PSSS (LFM_) @@ -201,7 +201,7 @@ Return (0) } - Debug = "Disable PL1 Limit" + Printf ("Disable PL1 Limit") /* Clear PL1 CLAMP bit */ PL1C = 0 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/coreboot/+/60450 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3f500ec46a9046a4e8ca50a85965b8e1225f8a33 Gerrit-Change-Number: 60450 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2021