coreboot-gerrit November 2021

coreboot-gerrit@coreboot.org

1 participants
6394 discussions

Change in coreboot[master]: mb/google/corsola: Add NOR-Flash support
by Rex-BC Chen (Code Review) 04 Nov '21

04 Nov '21

Attention is currently required from: Hung-Te Lin, Felix Held. Hello Hung-Te Lin, build bot (Jenkins), Yu-Ping Wu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/58838 to look at the new patch set (#4). Change subject: mb/google/corsola: Add NOR-Flash support ...................................................................... mb/google/corsola: Add NOR-Flash support Add NOR-Flash drivers to pass verification of flash at verstage. TEST=boot to romstage BUG=b:202871018 Signed-off-by: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Change-Id: Iee3dd336632b0cf998f5f7c1d118e01e8270e815 --- M src/mainboard/google/corsola/Kconfig M src/mainboard/google/corsola/bootblock.c 2 files changed, 6 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/58838/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/58838 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iee3dd336632b0cf998f5f7c1d118e01e8270e815 Gerrit-Change-Number: 58838 Gerrit-PatchSet: 4 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: Documentation/coding_style.md: Avoid weakly linked symbols
by Arthur Heymans (Code Review) 04 Nov '21

04 Nov '21

Attention is currently required from: Paul Menzel. Hello build bot (Jenkins), Paul Menzel, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/58934 to look at the new patch set (#2). Change subject: Documentation/coding_style.md: Avoid weakly linked symbols ...................................................................... Documentation/coding_style.md: Avoid weakly linked symbols Change-Id: If70d38c5c646c1e8365bb16d3292cebb2787eba2 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M Documentation/contributing/coding_style.md 1 file changed, 10 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/58934/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/58934 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If70d38c5c646c1e8365bb16d3292cebb2787eba2 Gerrit-Change-Number: 58934 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Hung-Te Lin <hungte(a)chromium.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: Documentation/coding_style.md: Avoid weakly linked symbols
by Arthur Heymans (Code Review) 04 Nov '21

04 Nov '21

Attention is currently required from: Paul Menzel. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58934 ) Change subject: Documentation/coding_style.md: Avoid weakly linked symbols ...................................................................... Patch Set 1: (2 comments) File Documentation/contributing/coding_style.md: https://review.coreboot.org/c/coreboot/+/58934/comment/6b600385_8e4a5fc2 PS1, Line 964: --------------- > Please underline the whole string. Done https://review.coreboot.org/c/coreboot/+/58934/comment/d964aea6_4808c912 PS1, Line 967: a stubs > stubs Done -- To view, visit https://review.coreboot.org/c/coreboot/+/58934 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If70d38c5c646c1e8365bb16d3292cebb2787eba2 Gerrit-Change-Number: 58934 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Hung-Te Lin <hungte(a)chromium.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Thu, 04 Nov 2021 08:39:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Documentation/coding_style.md: Avoid weakly linked symbols
by Paul Menzel (Code Review) 04 Nov '21

04 Nov '21

Attention is currently required from: Arthur Heymans. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58934 ) Change subject: Documentation/coding_style.md: Avoid weakly linked symbols ...................................................................... Patch Set 1: Code-Review+1 (2 comments) File Documentation/contributing/coding_style.md: https://review.coreboot.org/c/coreboot/+/58934/comment/a25ee111_8e731172 PS1, Line 964: --------------- Please underline the whole string. https://review.coreboot.org/c/coreboot/+/58934/comment/ff83e567_9b25add6 PS1, Line 967: a stubs stubs -- To view, visit https://review.coreboot.org/c/coreboot/+/58934 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If70d38c5c646c1e8365bb16d3292cebb2787eba2 Gerrit-Change-Number: 58934 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Hung-Te Lin <hungte(a)chromium.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 04 Nov 2021 08:37:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Documentation/coding_style.md: Avoid weakly linked symbols
by Arthur Heymans (Code Review) 04 Nov '21

04 Nov '21

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/58934 ) Change subject: Documentation/coding_style.md: Avoid weakly linked symbols ...................................................................... Documentation/coding_style.md: Avoid weakly linked symbols Change-Id: If70d38c5c646c1e8365bb16d3292cebb2787eba2 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M Documentation/contributing/coding_style.md 1 file changed, 10 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/58934/1 diff --git a/Documentation/contributing/coding_style.md b/Documentation/contributing/coding_style.md index e3c92af..e32c83c 100644 --- a/Documentation/contributing/coding_style.md +++ b/Documentation/contributing/coding_style.md @@ -960,6 +960,16 @@ : /* outputs */ : /* inputs */ : /* clobbers */); ``` +Weakly linked symbols +--------------- + +Weakly linked symbols should generally be avoided if possible. Weakly linked +symbols like functions, which are often just a stubs, result in runtime +problems due to the lack of a proper implementation, where they could +otherwise be caught at compiletime. When calling functions in common code +that might not be implemented by all platforms, it is better to guard the +call with a conditional using a Kconfig parameter. + References ---------- -- To view, visit https://review.coreboot.org/c/coreboot/+/58934 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If70d38c5c646c1e8365bb16d3292cebb2787eba2 Gerrit-Change-Number: 58934 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: Documentation/acpi/gpio.md: Update implementation details
by Arthur Heymans (Code Review) 04 Nov '21

04 Nov '21

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/58933 ) Change subject: Documentation/acpi/gpio.md: Update implementation details ...................................................................... Documentation/acpi/gpio.md: Update implementation details The weak functions were removed in bce7458 "acpi/acpigen.c: Remove weak gpio definition". Change-Id: Ia6e51698d6209fbf4f59b7fbc988a1aa696e366f Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M Documentation/acpi/gpio.md 1 file changed, 0 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/58933/1 diff --git a/Documentation/acpi/gpio.md b/Documentation/acpi/gpio.md index 470a55f..2d38f99 100644 --- a/Documentation/acpi/gpio.md +++ b/Documentation/acpi/gpio.md @@ -84,15 +84,6 @@ ## Implementation Details -ACPI library in coreboot will provide weak definitions for all the -above functions with error messages indicating that these functions -are being used. This allows drivers to conditionally make use of GPIOs -based on device-tree entries or any other config option. It is -recommended that the SoC code in coreboot should provide -implementations of all the above functions generating ACPI AML code -irrespective of them being used in any driver. This allows mainboards -to use any drivers and take advantage of this common infrastructure. - Platforms are restricted to using Local5, Local6 and Local7 variables only in implementations of the above functions. Any AML methods called by the above functions do not have any such restrictions on use of -- To view, visit https://review.coreboot.org/c/coreboot/+/58933 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia6e51698d6209fbf4f59b7fbc988a1aa696e366f Gerrit-Change-Number: 58933 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/dedede/var/bugzzy: Update charger performance control table
by Paul Menzel (Code Review) 04 Nov '21

04 Nov '21

Attention is currently required from: shkim, SH Kim, Karthik Ramasubramanian. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58840 ) Change subject: mb/google/dedede/var/bugzzy: Update charger performance control table ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/58840/comment/99fec89c_964a009c PS1, Line 9: Update charger performance control table of DPTF for bugzzy. Please amend the message, and document where you got the values from. -- To view, visit https://review.coreboot.org/c/coreboot/+/58840 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I33e176fcf5d380b315ff352c6c65af3b8b93c4b9 Gerrit-Change-Number: 58840 Gerrit-PatchSet: 1 Gerrit-Owner: shkim <sh_.kim(a)samsung.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: shkim <sh_.kim(a)samsung.com> Gerrit-Attention: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Thu, 04 Nov 2021 07:47:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: spd: Add new LP5 parts and generate SPDs
by Paul Menzel (Code Review) 04 Nov '21

04 Nov '21

Attention is currently required from: Reka Norman. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58929 ) Change subject: spd: Add new LP5 parts and generate SPDs ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/58929/comment/2e7a07dc_0fce977b PS2, Line 12: MT62F512M32D2DR-031 WT:B : MT62F1G32D4DR-031 WT:B : H9JCNNNCP3MLYR-N6E Please add the vendors. -- To view, visit https://review.coreboot.org/c/coreboot/+/58929 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifbcadfb78281b2b78a61a9b61180c421748193a0 Gerrit-Change-Number: 58929 Gerrit-PatchSet: 2 Gerrit-Owner: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-CC: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Comment-Date: Thu, 04 Nov 2021 07:46:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/mediatek/mt8186: Add a stub implementation of the MT8186 SoC
by Paul Menzel (Code Review) 04 Nov '21

04 Nov '21

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58640 ) Change subject: soc/mediatek/mt8186: Add a stub implementation of the MT8186 SoC ...................................................................... Patch Set 10: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/58640/comment/80b3681c_ca1081db PS2, Line 10: > I have added these comments for each module. Thank you for addressing my concers. -- To view, visit https://review.coreboot.org/c/coreboot/+/58640 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I579f79c15f4bf5e1daf6b35c70cfd00a985a0b81 Gerrit-Change-Number: 58640 Gerrit-PatchSet: 10 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Thu, 04 Nov 2021 07:43:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hung-Te Lin <hungte(a)chromium.org> Comment-In-Reply-To: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/var/felwinter: Correct typeC EC mux port
by EricR Lai (Code Review) 04 Nov '21

04 Nov '21

Attention is currently required from: Paul Menzel, Tim Wawrzynczak, Nick Vaccaro. EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58930 ) Change subject: mb/google/brya/var/felwinter: Correct typeC EC mux port ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/58930/comment/73b58132_67eedb07 PS1, Line 9: is used > uses? Done https://review.coreboot.org/c/coreboot/+/58930/comment/f11ce6f3_0594cfcc PS1, Line 9: Type C port2 is used EC mux port0. > … as per schematics? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/58930 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I85218c81018b248c41a2cdaf9360a86e2a7d4d7a Gerrit-Change-Number: 58930 Gerrit-PatchSet: 2 Gerrit-Owner: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Thu, 04 Nov 2021 07:42:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2021