Attention is currently required from: Felix Singer, Sean Rhodes, Tim Wawrzynczak, Patrick Rudolph.
Tim Crawford has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58798 )
Change subject: soc/intel/tigerlake/apci: Only use SCM for ChromeOS
......................................................................
Patch Set 9: Code-Review+1
(1 comment)
Patchset:
PS9:
Tested on system76/oryp8 using mainline Linux 5.15.
Previously on Linux 5.13+, without this change, TBT would fail with:
thunderbolt: probe of 0000:00:0d.2 failed with error -110
With this change, Linux is able to initialize the TBT device and GNOME allows configuring devices. USB 2 & 3 flash drives are detected before and after S3.
--
To view, visit https://review.coreboot.org/c/coreboot/+/58798
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib947c3c9cd843e54d4664509c15336178c0bc99e
Gerrit-Change-Number: 58798
Gerrit-PatchSet: 9
Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <felixsinger(a)posteo.net>
Gerrit-CC: Andy Pont <andy.pont(a)sdcsystems.com>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Sean Rhodes <admin(a)starlabs.systems>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Thu, 04 Nov 2021 20:56:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Jamie Ryu, Wonkyu Kim, Ravishankar Sarawadi, Julius Werner, Subrata Banik, Nick Vaccaro, Srinidhi N Kaushik, Raj Astekar.
Hello build bot (Jenkins), Jamie Ryu, Ravishankar Sarawadi, Tim Wawrzynczak, Julius Werner, Subrata Banik, Nick Vaccaro, Srinidhi N Kaushik, Raj Astekar,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/58839
to look at the new patch set (#11).
Change subject: src/lib: Add FW_CONFIG_SOURCE_VPD
......................................................................
src/lib: Add FW_CONFIG_SOURCE_VPD
Read fw_config value from VPD.
This new option can be used where chrome EC is not supported like
pre-silicon platform and fw_config can be updated by VPD tool in OS.
TEST= boot to OS and read fw_config from vpd
1. Boot to OS
2. Write "fw_config" in VPD
ex) vpd -i "RW_VPD" -s "fw_config"="1"
3. reboot and check fw_config value from coreboot log
Signed-off-by: Wonkyu Kim <wonkyu.kim(a)intel.com>
Change-Id: I4df7d5612e18957416a40ab854fa63c8b11b4216
---
M src/Kconfig
M src/lib/fw_config.c
2 files changed, 22 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/58839/11
--
To view, visit https://review.coreboot.org/c/coreboot/+/58839
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4df7d5612e18957416a40ab854fa63c8b11b4216
Gerrit-Change-Number: 58839
Gerrit-PatchSet: 11
Gerrit-Owner: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com>
Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com>
Gerrit-Attention: Raj Astekar <raj.astekar(a)intel.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Paul Fagerburg.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58634 )
Change subject: util/testing: add code coverage to jenkins
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
File util/testing/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/58634/comment/5fb9b377_7f51e661
PS5, Line 101: $(MAKE) coverage-report JUNIT_OUTPUT=y COV=1
> A future CL will have this make target also include the libpayload coverage data (generated in the l […]
Sounds good. Thanks.
--
To view, visit https://review.coreboot.org/c/coreboot/+/58634
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I96669c47d1a48e9ab678a4b9cb1d0c8032d727f0
Gerrit-Change-Number: 58634
Gerrit-PatchSet: 5
Gerrit-Owner: Paul Fagerburg <pfagerburg(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Paul Fagerburg <pfagerburg(a)chromium.org>
Gerrit-Comment-Date: Thu, 04 Nov 2021 20:34:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Martin Roth <martinroth(a)google.com>
Comment-In-Reply-To: Paul Fagerburg <pfagerburg(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth.
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58634 )
Change subject: util/testing: add code coverage to jenkins
......................................................................
Patch Set 5:
(1 comment)
File util/testing/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/58634/comment/fb8cae32_e35b1895
PS5, Line 101: $(MAKE) coverage-report JUNIT_OUTPUT=y COV=1
> Nit: Could we put this above the call to build libpayload?
A future CL will have this make target also include the libpayload coverage data (generated in the line above), but right now, this is just the coreboot coverage data.
--
To view, visit https://review.coreboot.org/c/coreboot/+/58634
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I96669c47d1a48e9ab678a4b9cb1d0c8032d727f0
Gerrit-Change-Number: 58634
Gerrit-PatchSet: 5
Gerrit-Owner: Paul Fagerburg <pfagerburg(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Comment-Date: Thu, 04 Nov 2021 20:32:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth <martinroth(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Paul Fagerburg.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58634 )
Change subject: util/testing: add code coverage to jenkins
......................................................................
Patch Set 5:
(1 comment)
File util/testing/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/58634/comment/f4cffbe7_7ccec053
PS5, Line 101: $(MAKE) coverage-report JUNIT_OUTPUT=y COV=1
Nit: Could we put this above the call to build libpayload?
--
To view, visit https://review.coreboot.org/c/coreboot/+/58634
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I96669c47d1a48e9ab678a4b9cb1d0c8032d727f0
Gerrit-Change-Number: 58634
Gerrit-PatchSet: 5
Gerrit-Owner: Paul Fagerburg <pfagerburg(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Paul Fagerburg <pfagerburg(a)chromium.org>
Gerrit-Comment-Date: Thu, 04 Nov 2021 20:29:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth.
Hello build bot (Jenkins), Martin Roth, Paul Menzel,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/58634
to look at the new patch set (#5).
Change subject: util/testing: add code coverage to jenkins
......................................................................
util/testing: add code coverage to jenkins
Add COV=1 and the `coverage-report` target to unit test build rules
in `what-jenkins-does` so that we get code coverage data from the
coreboot and libpayload unit tests.
Signed-off-by: Paul Fagerburg <pfagerburg(a)google.com>
Change-Id: I96669c47d1a48e9ab678a4b9cb1d0c8032d727f0
---
M util/testing/Makefile.inc
1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/58634/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/58634
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I96669c47d1a48e9ab678a4b9cb1d0c8032d727f0
Gerrit-Change-Number: 58634
Gerrit-PatchSet: 5
Gerrit-Owner: Paul Fagerburg <pfagerburg(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Jason Glenesk, Marshall Dawson, Julius Werner, Rob Barnes, Yu-Ping Wu, Andrey Pronin, Karthik Ramasubramanian, Felix Held.
Andrey Pronin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58870 )
Change subject: soc/amd/psp_verstage: Init TPM on S0i3 resume
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
Patchset:
PS3:
Lgtm for what we do with TPM on resume
--
To view, visit https://review.coreboot.org/c/coreboot/+/58870
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie511928da6a8b4be62621fd2c4c31a8d1e724d48
Gerrit-Change-Number: 58870
Gerrit-PatchSet: 3
Gerrit-Owner: Rob Barnes <robbarnes(a)google.com>
Gerrit-Reviewer: Andrey Pronin <apronin(a)chromium.org>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Rob Barnes <robbarnes(a)google.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Andrey Pronin <apronin(a)chromium.org>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Thu, 04 Nov 2021 20:05:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Tim Crawford, Tim Wawrzynczak, Patrick Rudolph.
Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58798 )
Change subject: soc/intel/tigerlake/apci: Only use SCM for ChromeOS
......................................................................
Patch Set 9:
(2 comments)
Patchset:
PS5:
> To be clear: you are trying to disable d3cold support for the TBT ports?
Yup - using S3 so disabling it is par for the course. It's all hardcoded though, and I'd guess I wonder get far proposing switching it off for everyone using S0ix...
TCSS_RTD3 maybe?
Patchset:
PS9:
> Seems OK for now, but let's keep an eye on how many different "configuration" options we need in thi […]
LINUXOS maybe? Seeing as most of the code is written for ChromeOS
--
To view, visit https://review.coreboot.org/c/coreboot/+/58798
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib947c3c9cd843e54d4664509c15336178c0bc99e
Gerrit-Change-Number: 58798
Gerrit-PatchSet: 9
Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <felixsinger(a)posteo.net>
Gerrit-CC: Andy Pont <andy.pont(a)sdcsystems.com>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Thu, 04 Nov 2021 20:00:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Rhodes <admin(a)starlabs.systems>
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: comment