coreboot-gerrit November 2021

coreboot-gerrit@coreboot.org

1 participants
6394 discussions

Change in coreboot[master]: mb/google/dedede/var/bugzzy: Update charger performance control table
by SH Kim (Code Review) 05 Nov '21

05 Nov '21

Attention is currently required from: shkim, Paul Menzel, Karthik Ramasubramanian. SH Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58840 ) Change subject: mb/google/dedede/var/bugzzy: Update charger performance control table ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/58840/comment/d98c8547_9b7fcbe3 PS1, Line 9: Update charger performance control table of DPTF for bugzzy. > Please amend the message, and document where you got the values from. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/58840 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I33e176fcf5d380b315ff352c6c65af3b8b93c4b9 Gerrit-Change-Number: 58840 Gerrit-PatchSet: 2 Gerrit-Owner: shkim <sh_.kim(a)samsung.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: shkim <sh_.kim(a)samsung.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Fri, 05 Nov 2021 00:49:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/bugzzy: Update charger performance control table
by SH Kim (Code Review) 05 Nov '21

05 Nov '21

Attention is currently required from: shkim, SH Kim, Karthik Ramasubramanian. SH Kim has uploaded a new patch set (#2) to the change originally created by shkim. ( https://review.coreboot.org/c/coreboot/+/58840 ) Change subject: mb/google/dedede/var/bugzzy: Update charger performance control table ...................................................................... mb/google/dedede/var/bugzzy: Update charger performance control table Update charger performance control table of DPTF for bugzzy. Since EC change chromium:197776876 modified maximum charging current to reduce skin temperature, this change adjusts the charging performance table with the modified value. BUG=b:197776876 BRANCH=dedede TEST=emerge-dedede coreboot Signed-off-by: Seunghwan Kim <sh_.kim(a)samsung.corp-partner.google.com> Change-Id: I33e176fcf5d380b315ff352c6c65af3b8b93c4b9 --- M src/mainboard/google/dedede/variants/bugzzy/overridetree.cb 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/58840/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/58840 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I33e176fcf5d380b315ff352c6c65af3b8b93c4b9 Gerrit-Change-Number: 58840 Gerrit-PatchSet: 2 Gerrit-Owner: shkim <sh_.kim(a)samsung.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: shkim <sh_.kim(a)samsung.com> Gerrit-Attention: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: src/drivers/wifi/generic/acpi.c: fix package_size to align with WLAN ...
by Kane Chen (Code Review) 05 Nov '21

05 Nov '21

Attention is currently required from: Sugnan Prabhu S, Matt Chen, Kane Chen. Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58951 ) Change subject: src/drivers/wifi/generic/acpi.c: fix package_size to align with WLAN driver ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/58951/comment/2cdbd798_3b50e977 PS3, Line 7: src/drivers/wifi/generic/acpi.c: fix package_size to align with WLAN driver drivers/wifi/generic -- To view, visit https://review.coreboot.org/c/coreboot/+/58951 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I18e7d5f658bbf42b7eeed3da330508f14b86c0f8 Gerrit-Change-Number: 58951 Gerrit-PatchSet: 3 Gerrit-Owner: Matt Chen <matt.chen(a)intel.corp-partner.google.com> Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com> Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.corp-partner.google.com> Gerrit-Reviewer: Matt Chen <matt.chen(a)intel.corp-partner.google.com> Gerrit-Reviewer: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Janiex Tu <janiex.tu(a)intel.corp-partner.google.com> Gerrit-Attention: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.corp-partner.google.com> Gerrit-Attention: Matt Chen <matt.chen(a)intel.corp-partner.google.com> Gerrit-Attention: Kane Chen <kane.chen(a)intel.com> Gerrit-Comment-Date: Fri, 05 Nov 2021 00:46:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [Do-Not-Merge] mb/intel/adlrvp: Remove EC region
by Zhixing Ma (Code Review) 04 Nov '21

04 Nov '21

Zhixing Ma has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/58964 ) Change subject: [Do-Not-Merge] mb/intel/adlrvp: Remove EC region ...................................................................... Abandoned commit for wrong repo -- To view, visit https://review.coreboot.org/c/coreboot/+/58964 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie96a5528696009e95df3f4eb662017e613a43e6d Gerrit-Change-Number: 58964 Gerrit-PatchSet: 1 Gerrit-Owner: Zhixing Ma <zhixing.ma(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: [Do-Not-Merge] mb/intel/adlrvp: Remove EC region
by Zhixing Ma (Code Review) 04 Nov '21

04 Nov '21

Attention is currently required from: Bora Guvendik, Selma Bensaid. Zhixing Ma has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58964 ) Change subject: [Do-Not-Merge] mb/intel/adlrvp: Remove EC region ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Hi all, this is a temporary patch used for building the latest coreboot image. Thanks -- To view, visit https://review.coreboot.org/c/coreboot/+/58964 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie96a5528696009e95df3f4eb662017e613a43e6d Gerrit-Change-Number: 58964 Gerrit-PatchSet: 1 Gerrit-Owner: Zhixing Ma <zhixing.ma(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Comment-Date: Thu, 04 Nov 2021 23:16:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [Do-Not-Merge] mb/intel/adlrvp: Remove EC region
by Zhixing Ma (Code Review) 04 Nov '21

04 Nov '21

Zhixing Ma has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/58964 ) Change subject: [Do-Not-Merge] mb/intel/adlrvp: Remove EC region ...................................................................... [Do-Not-Merge] mb/intel/adlrvp: Remove EC region Signed-off-by: zhixingma <zhixing.ma(a)intel.com> Change-Id: Ie96a5528696009e95df3f4eb662017e613a43e6d --- M src/mainboard/intel/adlrvp/chromeos.fmd 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/58964/1 diff --git a/src/mainboard/intel/adlrvp/chromeos.fmd b/src/mainboard/intel/adlrvp/chromeos.fmd index 84adad9..b799be1 100644 --- a/src/mainboard/intel/adlrvp/chromeos.fmd +++ b/src/mainboard/intel/adlrvp/chromeos.fmd @@ -1,13 +1,13 @@ FLASH 32M { SI_ALL 6M { SI_DESC 4K - SI_EC 512K + SI_ME { CSE_LAYOUT 8K CSE_RO 1588K CSE_DATA 512K # 64-KiB aligned to optimize RW erases during CSE update. - CSE_RW 3520K + CSE_RW 4032K } } SI_BIOS 26M { -- To view, visit https://review.coreboot.org/c/coreboot/+/58964 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie96a5528696009e95df3f4eb662017e613a43e6d Gerrit-Change-Number: 58964 Gerrit-PatchSet: 1 Gerrit-Owner: Zhixing Ma <zhixing.ma(a)intel.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: [WIP] util: Add coreboot Configurator
by build bot (Jenkins) (Code Review) 04 Nov '21

04 Nov '21

Attention is currently required from: Sean Rhodes, Martin Roth, Matt DeVillier, Tim Wawrzynczak, Angel Pons. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58854 ) Change subject: [WIP] util: Add coreboot Configurator ...................................................................... Patch Set 25: (352 comments) File util/coreboot-configurator/src/application/aboutwindow.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/ad7076ce_32d06c99 PS25, Line 16: public: spaces required around that ':' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/68a63273_9906f9b2 PS25, Line 17: explicit aboutWindow(QWidget *parent = nullptr); need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/b4071d5e_9869fdf2 PS25, Line 21: Ui::aboutWindow *ui; need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/b1663f39_9a0caa61 PS25, Line 21: Ui::aboutWindow *ui; labels should not be indented File util/coreboot-configurator/src/application/configuration.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/2fb7820b_e9bbe7d6 PS25, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/98ab642b_99e8277c PS25, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/56045b59_9d2e2eed PS25, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/e0bd50de_8e2dcea7 PS25, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/06232ff8_925cacf5 PS25, Line 15: QMap<QString,QString> fromNvramTool(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/0439e317_4cfd0017 PS25, Line 15: QMap<QString,QString> fromNvramTool(); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/52a1969c_f9564562 PS25, Line 15: QMap<QString,QString> fromNvramTool(); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/1fa871cf_677348e8 PS25, Line 17: QMap<QString,QString> mocked(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/46729727_8ba6ae26 PS25, Line 17: QMap<QString,QString> mocked(); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/1be50948_148abc6d PS25, Line 17: QMap<QString,QString> mocked(); spaces required around that '>' (ctx:VxW) File util/coreboot-configurator/src/application/coreboot_configurator.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/e982f9ab_bcb1e317 PS25, Line 29: public: spaces required around that ':' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/eba25fb5_e9f49f08 PS25, Line 30: coreboot_configurator(QWidget *parent = nullptr); need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/b319599e_148f489f PS25, Line 37: void showEvent(QShowEvent *ev); need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/693b7a12_3c5e77c5 PS25, Line 48: void displaySettings(); Bad function definition - void displaySettings() should probably be void displaySettings(void) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/e4ce6585_ae5977e9 PS25, Line 52: void writeToFile(const QString& out_file); need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/21daed3d_962143f3 PS25, Line 55: void updateValue(const QString& name); need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/9cb61327_991903fc PS25, Line 61: QMap<QString, QString> m_values; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/1884c3ee_7d4245eb PS25, Line 61: QMap<QString, QString> m_values; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/977fc3fd_22d0b3df PS25, Line 64: QMap<QString, QVBoxLayout*> m_tabs; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/586c89a7_63cb23df PS25, Line 64: QMap<QString, QVBoxLayout*> m_tabs; spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/6cf40294_a94af404 PS25, Line 67: YAML::Node m_categories; labels should not be indented Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/bfbe93e6_f826816c PS25, Line 70: QComboBox *textToDisplay(const QString &in_string); need consistent spacing around '&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/c7014c91_fdc66e90 PS25, Line 71: QCheckBox *checkToDisplay(const QString &in_string); need consistent spacing around '&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/18d31777_57897b7a PS25, Line 73: Ui::coreboot_configurator *ui; need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/55968632_07df287a PS25, Line 73: Ui::coreboot_configurator *ui; labels should not be indented File util/coreboot-configurator/src/application/coreboot_configurator.cpp: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/2984bb2c_d36787fd PS25, Line 206: trailing whitespace File util/coreboot-configurator/src/application/qtyaml.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/d5bd9a30_05294409 PS25, Line 30: template<> spaces required around that '<' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/78fde81a_1d507dd2 PS25, Line 30: template<> spaces required around that '>' (ctx:OxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/702bb4c4_7f422a97 PS25, Line 31: struct convert<QString> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/178804dd_bae2d265 PS25, Line 31: struct convert<QString> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/522dddf7_4234e69e PS25, Line 33: static Node encode(const QString& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/1be0c745_eee2457d PS25, Line 33: static Node encode(const QString& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/78f3fdf7_489691c0 PS25, Line 33: static Node encode(const QString& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/7dce3ed1_7407dba2 PS25, Line 34: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/95cf516c_8afea877 PS25, Line 35: return Node(rhs.toStdString()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/33fdea8e_b3464cc6 PS25, Line 35: return Node(rhs.toStdString()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/be3e0754_c39e7818 PS25, Line 36: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/4ceec24e_1f5a2caf PS25, Line 38: static bool decode(const Node& node, QString& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/848bb3a7_6e3b61b7 PS25, Line 38: static bool decode(const Node& node, QString& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/db27fd41_4cf631e9 PS25, Line 38: static bool decode(const Node& node, QString& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/fd018052_86ff38d2 PS25, Line 38: static bool decode(const Node& node, QString& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/4b75f10e_c5404262 PS25, Line 39: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/8be52993_7667313b PS25, Line 40: if (!node.IsScalar()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/a5ecaf10_92b76dfa PS25, Line 40: if (!node.IsScalar()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/3a0a3f79_b5383bcc PS25, Line 40: if (!node.IsScalar()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/5df4943b_8f2739f3 PS25, Line 41: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/f9e5b176_2c7b9ca6 PS25, Line 41: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/9cc6e045_8b18748e PS25, Line 42: rhs = QString::fromStdString(node.Scalar()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/6388aef2_24d141ae PS25, Line 42: rhs = QString::fromStdString(node.Scalar()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/3697e992_47a4afbd PS25, Line 43: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/8e4e9e32_fd84f6ef PS25, Line 43: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/f340334b_fab9f86d PS25, Line 44: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/d3dcb132_8a4f869e PS25, Line 48: template<typename Key, typename Value> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/3f820344_0f6e6333 PS25, Line 48: template<typename Key, typename Value> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/c643788c_cf742b04 PS25, Line 49: struct convert<QMap<Key, Value> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/351baa20_d84e44c8 PS25, Line 49: struct convert<QMap<Key, Value> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/cc8cb90f_25a1dba8 PS25, Line 49: struct convert<QMap<Key, Value> > spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/5789b72d_d9417055 PS25, Line 51: static Node encode(const QMap<Key,Value>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/1c1772bd_efb31365 PS25, Line 51: static Node encode(const QMap<Key,Value>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/4ab3a706_2f1fe2a5 PS25, Line 51: static Node encode(const QMap<Key,Value>& rhs) space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/98f172f6_03abc2a4 PS25, Line 51: static Node encode(const QMap<Key,Value>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/cc1db550_878f1447 PS25, Line 51: static Node encode(const QMap<Key,Value>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/549d746c_88c76c72 PS25, Line 51: static Node encode(const QMap<Key,Value>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/522b5ef7_53cbe7d9 PS25, Line 51: static Node encode(const QMap<Key,Value>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/1a3673cf_5e15e233 PS25, Line 52: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/ddd33c62_c8717821 PS25, Line 53: Node node(NodeType::Map); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/ef65c9e8_f6a72f07 PS25, Line 53: Node node(NodeType::Map); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/d5599501_1599532a PS25, Line 54: auto it = rhs.constBegin(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/c4cd8fab_c0718e40 PS25, Line 54: auto it = rhs.constBegin(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/4132d2b8_70e56704 PS25, Line 55: while (it != rhs.constEnd()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/f8b1ef69_31ef936c PS25, Line 55: while (it != rhs.constEnd()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/4c913717_d23fd41e PS25, Line 55: while (it != rhs.constEnd()) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/1c91e3d4_d5d31ae3 PS25, Line 55: while (it != rhs.constEnd()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/b9932f07_5b0987e8 PS25, Line 56: { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/df4120b2_b331c6a5 PS25, Line 56: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/11719c77_524eae38 PS25, Line 57: node.force_insert(it.key(), it.value()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/abf31415_5e3033d1 PS25, Line 57: node.force_insert(it.key(), it.value()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/3ffc4d3e_e88a62fb PS25, Line 58: ++it; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/60956816_6258c6bb PS25, Line 58: ++it; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/62a1ef14_8ebb4cf9 PS25, Line 59: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/86c414e4_7948afa7 PS25, Line 59: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/7932b3e6_ed91b9ed PS25, Line 60: return node; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/e04aa2a5_766927da PS25, Line 60: return node; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/13a57f5e_32edbe72 PS25, Line 61: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/f8b84799_1f2b9fd2 PS25, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/d793e2a1_1aed7a3e PS25, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/24726d7e_1ecf4019 PS25, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/bc44f7de_2596bc20 PS25, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/eeb90002_077bc4af PS25, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/0a1439a1_25cbd32d PS25, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/022cf827_cd66b1cf PS25, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/30e7c5f7_e681e28e PS25, Line 64: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/7096dfbf_4cc6ba7e PS25, Line 65: if (!node.IsMap()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/5ecbeed1_34bb923c PS25, Line 65: if (!node.IsMap()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/7c60eedf_78481991 PS25, Line 65: if (!node.IsMap()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/fb95bfe8_9979610f PS25, Line 66: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/4f2f05da_5bcbd20e PS25, Line 66: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/b573fb4c_2b809722 PS25, Line 68: rhs.clear(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/26783b82_b856bc2a PS25, Line 68: rhs.clear(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/b8438c13_b642ac18 PS25, Line 69: const_iterator it = node.begin(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/da510960_0713eb24 PS25, Line 69: const_iterator it = node.begin(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/7c5349a2_3c26eda7 PS25, Line 70: while (it != node.end()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/acdc6444_6f880465 PS25, Line 70: while (it != node.end()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/bcf7c45a_88a90359 PS25, Line 70: while (it != node.end()) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/18d52ec3_b6827e74 PS25, Line 70: while (it != node.end()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/c69b45f0_16243102 PS25, Line 71: { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/eed9e5bc_577720c8 PS25, Line 71: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/2c7a0b13_a6a59f95 PS25, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/3960d0d8_3ccb090e PS25, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/a187f35d_6dd61421 PS25, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/b92779e4_b3a5359a PS25, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/f9fd4c4a_00ff8206 PS25, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/7f8a2429_7a90526b PS25, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/778ab9cb_0aa599cc PS25, Line 73: ++it; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/25c459c7_9cceb3fa PS25, Line 73: ++it; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/ead99ffa_39ccb75f PS25, Line 74: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/f1175e2f_418c594b PS25, Line 74: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/3c1831ef_d4b1950a PS25, Line 75: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/72cf1e44_7280b561 PS25, Line 75: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/5a99ebcf_4259354f PS25, Line 76: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/ab7cacb3_b086b653 PS25, Line 80: template<typename T> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/391aab7f_e76b5584 PS25, Line 80: template<typename T> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/f5c63a45_4f3965a7 PS25, Line 81: struct convert<QVector<T> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/cc59d148_6d7fce37 PS25, Line 81: struct convert<QVector<T> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/2de9915e_145e20ef PS25, Line 81: struct convert<QVector<T> > spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/bfc3130e_590901f8 PS25, Line 83: static Node encode(const QVector<T>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/5b5b4d5a_b5eef4a1 PS25, Line 83: static Node encode(const QVector<T>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/21ca1646_3af9b2a3 PS25, Line 83: static Node encode(const QVector<T>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/5b77c10e_459397ab PS25, Line 83: static Node encode(const QVector<T>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/eed52860_5019f913 PS25, Line 83: static Node encode(const QVector<T>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/4eed9a33_07b1fd65 PS25, Line 83: static Node encode(const QVector<T>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/08189acf_e0fee97f PS25, Line 84: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/db224a06_231352d3 PS25, Line 85: Node node(NodeType::Sequence); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/68cebc8d_a08bb697 PS25, Line 85: Node node(NodeType::Sequence); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/585f3f33_fe6f32b8 PS25, Line 86: foreach (T value, rhs) { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/fb445b6b_034a111d PS25, Line 86: foreach (T value, rhs) { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/5de69c42_77811541 PS25, Line 86: foreach (T value, rhs) { space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/a44f7c5c_020745f2 PS25, Line 87: node.push_back(value); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/fb62619c_fe93687f PS25, Line 87: node.push_back(value); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/bf675e9e_963ddb8a PS25, Line 88: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/1b1d77c9_0872ed80 PS25, Line 88: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/12de161e_559ec80d PS25, Line 89: return node; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/68fb92c4_3cb5f0a4 PS25, Line 89: return node; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/62ca6ec5_ad7b4d6e PS25, Line 90: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/244115a6_b2cf13df PS25, Line 92: static bool decode(const Node& node, QVector<T>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/6614ac28_f98aab1e PS25, Line 92: static bool decode(const Node& node, QVector<T>& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/df09ca29_8f3fbd8a PS25, Line 92: static bool decode(const Node& node, QVector<T>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/a9c5c5e1_7d685547 PS25, Line 92: static bool decode(const Node& node, QVector<T>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/605d3f11_0c2e7b5c PS25, Line 92: static bool decode(const Node& node, QVector<T>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/c5d5b475_a4778416 PS25, Line 92: static bool decode(const Node& node, QVector<T>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/9b0e7410_1abd330b PS25, Line 92: static bool decode(const Node& node, QVector<T>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/f1ab6ae9_e2234dd8 PS25, Line 93: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/d6228947_adb20c93 PS25, Line 94: if (!node.IsSequence()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/5b7ef7ac_93e581aa PS25, Line 94: if (!node.IsSequence()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/d717672d_e0dc91ae PS25, Line 94: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/6a0aceba_37991146 PS25, Line 95: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/74b505b9_ebb00b9d PS25, Line 95: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/a22d52c8_ea10bbf2 PS25, Line 97: rhs.clear(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/5ee00936_608498a1 PS25, Line 97: rhs.clear(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/17c056ea_070aa346 PS25, Line 98: const_iterator it = node.begin(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/d7027bad_677647d0 PS25, Line 98: const_iterator it = node.begin(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/1c67047b_164d20a5 PS25, Line 99: while (it != node.end()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/2820d847_60d4fb59 PS25, Line 99: while (it != node.end()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/69188115_9bd38ea6 PS25, Line 99: while (it != node.end()) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/ad65641f_363540d5 PS25, Line 99: while (it != node.end()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/84fea297_e5e9d32a PS25, Line 100: { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/bc941cb5_ce97a457 PS25, Line 100: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/5589e2c1_d44b549d PS25, Line 101: rhs.push_back(it->as<T>()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/404b85fa_ac9ae868 PS25, Line 101: rhs.push_back(it->as<T>()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/1259def7_39c8f454 PS25, Line 101: rhs.push_back(it->as<T>()); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/79ee93b9_cd70a4e6 PS25, Line 101: rhs.push_back(it->as<T>()); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/11480ed3_de8f018e PS25, Line 102: ++it; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/7794d434_9d558d8e PS25, Line 102: ++it; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/557b8a03_9c148081 PS25, Line 103: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/447786c5_b6963ae8 PS25, Line 103: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/1f27e21e_954c8b00 PS25, Line 104: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/f223045e_c9ad02f1 PS25, Line 104: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/1540f5c4_56a920fa PS25, Line 105: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/97dfb560_0f4f06b2 PS25, Line 109: template<typename T> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/268987d5_567347f0 PS25, Line 109: template<typename T> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/cfb6e8ea_be39fa91 PS25, Line 110: struct convert<QList<T> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/e8f7ccda_cc14626e PS25, Line 110: struct convert<QList<T> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/956d8896_9debaf16 PS25, Line 110: struct convert<QList<T> > spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/61df1c1b_ce21886d PS25, Line 112: static Node encode(const QList<T>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/59218f8b_9a6684ba PS25, Line 112: static Node encode(const QList<T>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/45416dc3_ba6c41d1 PS25, Line 112: static Node encode(const QList<T>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/94be27ba_4c1dc145 PS25, Line 112: static Node encode(const QList<T>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/7616700e_73ba3855 PS25, Line 112: static Node encode(const QList<T>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/7312201d_be69e936 PS25, Line 112: static Node encode(const QList<T>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/0507bf23_75471fa0 PS25, Line 113: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/a8864106_e6c720d2 PS25, Line 114: Node node(NodeType::Sequence); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/b640024a_004610e4 PS25, Line 114: Node node(NodeType::Sequence); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/bcf01ded_4dec7a92 PS25, Line 115: foreach (T value, rhs) { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/92f3d339_a5fcb0ca PS25, Line 115: foreach (T value, rhs) { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/6d232965_f6fee811 PS25, Line 115: foreach (T value, rhs) { space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/469c9808_62a49650 PS25, Line 116: node.push_back(value); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/352fad86_be231c4a PS25, Line 116: node.push_back(value); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/7a5548b8_89507e61 PS25, Line 117: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/47ee9ea3_c9e00433 PS25, Line 117: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/b48ad44d_f9007f59 PS25, Line 118: return node; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/68e9b08f_177db308 PS25, Line 118: return node; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/46763acb_35a08fcb PS25, Line 119: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/ad2ab67f_6490790e PS25, Line 121: static bool decode(const Node& node, QList<T>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/48b8b039_c867b763 PS25, Line 121: static bool decode(const Node& node, QList<T>& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/462a5028_204b464b PS25, Line 121: static bool decode(const Node& node, QList<T>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/6b4fea6a_d6d14524 PS25, Line 121: static bool decode(const Node& node, QList<T>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/8248e974_52604aba PS25, Line 121: static bool decode(const Node& node, QList<T>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/20ae900c_74ce142f PS25, Line 121: static bool decode(const Node& node, QList<T>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/cd5e23e1_74ef9d5d PS25, Line 121: static bool decode(const Node& node, QList<T>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/b385e5e4_38bfc9b2 PS25, Line 122: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/b5238b85_46d9e805 PS25, Line 123: if (!node.IsSequence()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/5c298f41_ecd90df0 PS25, Line 123: if (!node.IsSequence()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/82d40ffc_51121a23 PS25, Line 123: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/591ad8eb_c11499d3 PS25, Line 124: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/10c52059_32e03857 PS25, Line 124: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/a60e49c2_52eb6cfe PS25, Line 126: rhs.clear(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/acd9dc54_24d957de PS25, Line 126: rhs.clear(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/38b6d927_76796ee9 PS25, Line 127: const_iterator it = node.begin(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/cbe8a19d_bc87c71d PS25, Line 127: const_iterator it = node.begin(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/a69acef5_bca0e104 PS25, Line 128: while (it != node.end()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/8831e1d9_8a105f4f PS25, Line 128: while (it != node.end()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/ebdcbbda_72465d5f PS25, Line 128: while (it != node.end()) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/8eae6912_8fca958d PS25, Line 128: while (it != node.end()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/01afb4a4_691ca09f PS25, Line 129: { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/ab320232_3ab0f961 PS25, Line 129: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/8fcafc42_79992658 PS25, Line 130: rhs.push_back(it->as<T>()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/69e9e7ec_704f5258 PS25, Line 130: rhs.push_back(it->as<T>()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/783824a0_d392e1bf PS25, Line 130: rhs.push_back(it->as<T>()); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/cc34f7b9_d6df6404 PS25, Line 130: rhs.push_back(it->as<T>()); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/3338be62_d67aac6f PS25, Line 131: ++it; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/632eebf0_885edf48 PS25, Line 131: ++it; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/7e68505a_1765537a PS25, Line 132: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/35fafaa6_981bdb49 PS25, Line 132: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/38a26993_e8b01ea1 PS25, Line 133: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/9d9d2f83_ceb23f60 PS25, Line 133: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/e63401c7_eb7820dc PS25, Line 134: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/a181ed9e_0b26f70a PS25, Line 138: template<typename T, typename U> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/f886a9d5_bdcb3a1c PS25, Line 138: template<typename T, typename U> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/56f772aa_dcba407b PS25, Line 139: struct convert<QPair<T,U> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/6411ed0e_38407708 PS25, Line 139: struct convert<QPair<T,U> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/e1e8796f_6703b364 PS25, Line 139: struct convert<QPair<T,U> > space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/dcef40c1_8434bd06 PS25, Line 139: struct convert<QPair<T,U> > spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/6dac2c32_ac065fd0 PS25, Line 141: static Node encode(const QPair<T,U>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/9e753363_da7d4544 PS25, Line 141: static Node encode(const QPair<T,U>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/785b1116_2de7a65a PS25, Line 141: static Node encode(const QPair<T,U>& rhs) space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/575c7c4d_f6817799 PS25, Line 141: static Node encode(const QPair<T,U>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/42465492_7d24f839 PS25, Line 141: static Node encode(const QPair<T,U>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/4c3d9d4f_ac45a5b0 PS25, Line 141: static Node encode(const QPair<T,U>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/e8a2123b_14e08d38 PS25, Line 141: static Node encode(const QPair<T,U>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/f21c353a_d2f4c477 PS25, Line 142: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/7c3b228f_7be7169a PS25, Line 143: Node node(NodeType::Sequence); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/0ad05e7b_82d097b6 PS25, Line 143: Node node(NodeType::Sequence); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/4077d75c_57bea6ac PS25, Line 144: node.push_back(rhs.first); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/14977fb3_1638c6d4 PS25, Line 144: node.push_back(rhs.first); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/ebd01c62_6db76ea7 PS25, Line 145: node.push_back(rhs.second); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/df574840_414d8df9 PS25, Line 145: node.push_back(rhs.second); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/2486be53_1bfcd2b8 PS25, Line 146: return node; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/09b697e8_743f3f5f PS25, Line 146: return node; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/f4f8defd_5d515f7d PS25, Line 147: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/4f5b74c4_0a4db3ea PS25, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/2dac5a4f_d7e1f0b9 PS25, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/6ef3b360_e477372c PS25, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/4e02e909_3e0eb7dc PS25, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/9ad09455_c2d4d456 PS25, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/b7a1bb76_0b9c50ae PS25, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/3ed78d09_09254fb0 PS25, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/b180696c_d12e2bc6 PS25, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/55e7407e_b3dfe847 PS25, Line 150: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/88cd8159_cc34e176 PS25, Line 151: if (!node.IsSequence()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/38953f55_3beb4d52 PS25, Line 151: if (!node.IsSequence()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/4ab2e8ef_3177a9af PS25, Line 151: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/a9f70c4b_369b12e0 PS25, Line 152: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/bd6bfa24_c724df82 PS25, Line 152: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/8b81bd9e_f8e4f7ff PS25, Line 153: if (node.size() != 2) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/a537694a_2d78fc5e PS25, Line 153: if (node.size() != 2) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/05dd994b_45c296bf PS25, Line 153: if (node.size() != 2) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/a88fcb25_8fe26840 PS25, Line 154: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/61c5c073_9d2bb025 PS25, Line 154: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/e1e1e48e_7a8b5237 PS25, Line 156: rhs.first = node[0].as<T>(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/e1e98baa_ffd74cd9 PS25, Line 156: rhs.first = node[0].as<T>(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/a4021057_7a35159d PS25, Line 156: rhs.first = node[0].as<T>(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/349c8452_801dcadd PS25, Line 156: rhs.first = node[0].as<T>(); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/9b46d070_ec49921e PS25, Line 157: rhs.second = node[1].as(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/3260487c_11c345ff PS25, Line 157: rhs.second = node[1].as(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/0d74425c_fb8e6f62 PS25, Line 157: rhs.second = node[1].as(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/62e61d18_fda3acab PS25, Line 157: rhs.second = node[1].as(); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/8adfcd30_d555942b PS25, Line 158: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/5fce273a_a371f158 PS25, Line 158: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/f9c1a888_e996f893 PS25, Line 159: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/26d508c8_5f66834d PS25, Line 163: template<> spaces required around that '<' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/b9b6b619_948f7df2 PS25, Line 163: template<> spaces required around that '>' (ctx:OxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/3cacaa71_c002fdc3 PS25, Line 164: struct convert<QStringList> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/b4c0d64b_c9101b0c PS25, Line 164: struct convert<QStringList> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/7d9e3b39_3d8010b3 PS25, Line 166: static Node encode(const QStringList& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/6d220b8d_c83ae1d2 PS25, Line 166: static Node encode(const QStringList& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/1a214d16_11dd1791 PS25, Line 166: static Node encode(const QStringList& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/517cb9ae_1cff2cca PS25, Line 167: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/b77439f0_fd559286 PS25, Line 168: Node node(NodeType::Sequence); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/bbf40b2b_813a67ee PS25, Line 168: Node node(NodeType::Sequence); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/90576744_753f7af1 PS25, Line 169: for (const auto &value: rhs) { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/a80141e2_ea76d72f PS25, Line 169: for (const auto &value: rhs) { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/be8e1bdc_c2861817 PS25, Line 169: for (const auto &value: rhs) { suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/ec5c1b1e_3b105ce1 PS25, Line 169: for (const auto &value: rhs) { need consistent spacing around '&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/1ffad4e2_482c4c31 PS25, Line 169: for (const auto &value: rhs) { spaces required around that ':' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/11343a80_0af8dda0 PS25, Line 169: for (const auto &value: rhs) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/0771efef_5342653d PS25, Line 170: node.push_back(value); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/290b92b2_5a119bc4 PS25, Line 170: node.push_back(value); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/539e06ff_c1a43632 PS25, Line 171: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/c18ebebd_d06ee5d4 PS25, Line 171: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/bec78132_e2adf64c PS25, Line 172: return node; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/b0306bbb_5b4c0c71 PS25, Line 172: return node; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/1f8e952c_b8a6a578 PS25, Line 173: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/58d72e6a_76d3255d PS25, Line 175: static bool decode(const Node& node, QStringList& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/63557f6a_088bf289 PS25, Line 175: static bool decode(const Node& node, QStringList& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/ae654daf_326c602e PS25, Line 175: static bool decode(const Node& node, QStringList& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/889eee77_c832a182 PS25, Line 175: static bool decode(const Node& node, QStringList& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/ac565f90_0c2df157 PS25, Line 176: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/2c8688fc_d67f8c55 PS25, Line 177: if (!node.IsSequence()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/5ce0ff4a_932d8f96 PS25, Line 177: if (!node.IsSequence()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/9a2dcef5_b157a951 PS25, Line 177: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/a09c3a66_3f8aafd6 PS25, Line 178: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/57e494be_d9fbba48 PS25, Line 178: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/c374d547_49089340 PS25, Line 180: rhs.clear(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/6e43a4cd_d0816120 PS25, Line 180: rhs.clear(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/83990f19_2773338b PS25, Line 181: const_iterator it = node.begin(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/c4a7cc88_680644c5 PS25, Line 181: const_iterator it = node.begin(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/689f76e4_afce7cd0 PS25, Line 182: while (it != node.end()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/6c4b863a_e366ca7e PS25, Line 182: while (it != node.end()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/349ce720_d02c2f98 PS25, Line 182: while (it != node.end()) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/aa1f8031_0dd64c96 PS25, Line 182: while (it != node.end()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/c789ac7d_bddf138c PS25, Line 183: { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/2861cfc4_5b9cd530 PS25, Line 183: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/dcd9c2b3_3e0a5234 PS25, Line 184: rhs.push_back(it->as<QString>()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/4686b791_0af0d311 PS25, Line 184: rhs.push_back(it->as<QString>()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/62111566_bed29460 PS25, Line 184: rhs.push_back(it->as<QString>()); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/dffa1c18_49287778 PS25, Line 184: rhs.push_back(it->as<QString>()); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/f330e5d3_dc552064 PS25, Line 185: ++it; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/30bad287_02b3a642 PS25, Line 185: ++it; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/4f2aa055_a5f4dde3 PS25, Line 186: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/991a58b4_4cfc199d PS25, Line 186: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/417e5bd6_57f0aab9 PS25, Line 187: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/246dc568_57d2adda PS25, Line 187: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/b8e3ba27_9c386aae PS25, Line 188: } please, no spaces at the start of a line File util/coreboot-configurator/src/application/toggleswitch.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/ccbb5562_8f17ad73 PS25, Line 16: public: spaces required around that ':' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/703d39e8_cfa697b5 PS25, Line 17: explicit ToggleSwitch(QWidget* parent = nullptr); need consistent spacing around '*' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/6dad9367_ad8665bc PS25, Line 25: void recolorToggleOn(const QPalette& palette); need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/e949fc26_bce03e05 PS25, Line 30: void paintEvent(QPaintEvent *event) override; need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/038a3cc4_4826d5c4 PS25, Line 34: bool hitButton(const QPoint &pos) const override need consistent spacing around '&' (ctx:WxV) -- To view, visit https://review.coreboot.org/c/coreboot/+/58854 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie654f6aca57a792be0c295afc081a95ed4d875d1 Gerrit-Change-Number: 58854 Gerrit-PatchSet: 25 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com> Gerrit-Comment-Date: Thu, 04 Nov 2021 22:57:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [WIP] util: Add coreboot Configurator
by build bot (Jenkins) (Code Review) 04 Nov '21

04 Nov '21

Attention is currently required from: Sean Rhodes, Martin Roth, Matt DeVillier, Tim Wawrzynczak, Angel Pons. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58854 ) Change subject: [WIP] util: Add coreboot Configurator ...................................................................... Patch Set 24: (352 comments) File util/coreboot-configurator/src/application/aboutwindow.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/8e38783d_1c1264db PS24, Line 16: public: spaces required around that ':' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/0ed5a27f_340c3156 PS24, Line 17: explicit aboutWindow(QWidget *parent = nullptr); need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/89fced39_6beb23ec PS24, Line 21: Ui::aboutWindow *ui; need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/8b4225d8_6de6e541 PS24, Line 21: Ui::aboutWindow *ui; labels should not be indented File util/coreboot-configurator/src/application/configuration.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/9796458b_6f80bb27 PS24, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/65d89890_d84820c0 PS24, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/36499586_58ddbe65 PS24, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/c16e07b9_a0710a8d PS24, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/798a4ea4_2d43cbd0 PS24, Line 15: QMap<QString,QString> fromNvramTool(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/915c7513_c7e79231 PS24, Line 15: QMap<QString,QString> fromNvramTool(); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/dbfa2278_4beab7e2 PS24, Line 15: QMap<QString,QString> fromNvramTool(); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/dee5f3bf_99fbabfb PS24, Line 17: QMap<QString,QString> mocked(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/3a6188b0_7bf50154 PS24, Line 17: QMap<QString,QString> mocked(); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/7d209eac_0d416614 PS24, Line 17: QMap<QString,QString> mocked(); spaces required around that '>' (ctx:VxW) File util/coreboot-configurator/src/application/coreboot_configurator.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/9565db7d_59c919f6 PS24, Line 29: public: spaces required around that ':' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/2ead3725_614a131e PS24, Line 30: coreboot_configurator(QWidget *parent = nullptr); need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/928d26ac_35e90ebf PS24, Line 37: void showEvent(QShowEvent *ev); need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/621d7977_c5477581 PS24, Line 48: void displaySettings(); Bad function definition - void displaySettings() should probably be void displaySettings(void) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/f3544ca4_5833fdb5 PS24, Line 52: void writeToFile(const QString& out_file); need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/0651d365_53c4c305 PS24, Line 55: void updateValue(const QString& name); need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/7c3db74c_a2d8aa17 PS24, Line 61: QMap<QString, QString> m_values; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/d98c2f4d_2d18060e PS24, Line 61: QMap<QString, QString> m_values; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/557e4821_d0e1e845 PS24, Line 64: QMap<QString, QVBoxLayout*> m_tabs; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/257cf41a_e07ddc78 PS24, Line 64: QMap<QString, QVBoxLayout*> m_tabs; spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/545aa950_70b4e6c7 PS24, Line 67: YAML::Node m_categories; labels should not be indented Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/d632bcf3_7e7c7c6c PS24, Line 70: QComboBox *textToDisplay(const QString &in_string); need consistent spacing around '&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/5caca82f_9c7663a8 PS24, Line 71: QCheckBox *checkToDisplay(const QString &in_string); need consistent spacing around '&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/fad30d69_3d15ecf5 PS24, Line 73: Ui::coreboot_configurator *ui; need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/f4f655ef_55d204f7 PS24, Line 73: Ui::coreboot_configurator *ui; labels should not be indented File util/coreboot-configurator/src/application/coreboot_configurator.cpp: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/d536a4a2_1d4b184b PS24, Line 206: trailing whitespace File util/coreboot-configurator/src/application/qtyaml.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/f1d4a892_d1c264fd PS24, Line 30: template<> spaces required around that '<' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/e9e0d954_682feee2 PS24, Line 30: template<> spaces required around that '>' (ctx:OxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/fd66594b_1cad36e2 PS24, Line 31: struct convert<QString> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/79001224_da7a60db PS24, Line 31: struct convert<QString> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/78344eff_003f8038 PS24, Line 33: static Node encode(const QString& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/10e723a0_03bddcfe PS24, Line 33: static Node encode(const QString& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/ff56fd24_2be94549 PS24, Line 33: static Node encode(const QString& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/4ea48d57_00e4256b PS24, Line 34: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/62512e6b_89226041 PS24, Line 35: return Node(rhs.toStdString()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/d20e3dcd_bde50cf4 PS24, Line 35: return Node(rhs.toStdString()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/048f3809_55e4e4a1 PS24, Line 36: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/91c20080_3fc6577c PS24, Line 38: static bool decode(const Node& node, QString& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/1d6aee5b_50812ea2 PS24, Line 38: static bool decode(const Node& node, QString& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/8e9175a8_65e9a1b9 PS24, Line 38: static bool decode(const Node& node, QString& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/696061a7_366bf43b PS24, Line 38: static bool decode(const Node& node, QString& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/004bb69a_a7bcbd9f PS24, Line 39: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/532e6982_cbae602a PS24, Line 40: if (!node.IsScalar()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/8b1b22b9_de134138 PS24, Line 40: if (!node.IsScalar()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/3bf69cdc_7177e5d2 PS24, Line 40: if (!node.IsScalar()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/bbef7aaf_f00feeef PS24, Line 41: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/56ed2cf0_6fc8d218 PS24, Line 41: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/54451d4f_4f1fa73c PS24, Line 42: rhs = QString::fromStdString(node.Scalar()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/d5150ef3_33bbae31 PS24, Line 42: rhs = QString::fromStdString(node.Scalar()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/233e670c_32e2759e PS24, Line 43: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/faf71aee_b6933fe3 PS24, Line 43: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/28b115ac_b3488b29 PS24, Line 44: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/651ec5ca_2bac63bf PS24, Line 48: template<typename Key, typename Value> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/1a509bf0_5d3a5c44 PS24, Line 48: template<typename Key, typename Value> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/d6704467_e9b816cb PS24, Line 49: struct convert<QMap<Key, Value> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/919e0344_32e88ced PS24, Line 49: struct convert<QMap<Key, Value> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/086ffa8b_c2ac8d5c PS24, Line 49: struct convert<QMap<Key, Value> > spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/1dfaaef0_03d350ab PS24, Line 51: static Node encode(const QMap<Key,Value>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/cc511bd8_a06a4014 PS24, Line 51: static Node encode(const QMap<Key,Value>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/bc5a0edc_81f6e5d2 PS24, Line 51: static Node encode(const QMap<Key,Value>& rhs) space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/10736e99_b975d6c5 PS24, Line 51: static Node encode(const QMap<Key,Value>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/71693235_caaf7807 PS24, Line 51: static Node encode(const QMap<Key,Value>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/62adc979_86512e5e PS24, Line 51: static Node encode(const QMap<Key,Value>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/c14b33e3_57a9821d PS24, Line 51: static Node encode(const QMap<Key,Value>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/65555cd9_5ac4b8d3 PS24, Line 52: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/b37ec385_a62fa2e2 PS24, Line 53: Node node(NodeType::Map); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/a9bf9788_386aeb9e PS24, Line 53: Node node(NodeType::Map); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/20ed71c1_5f41fe13 PS24, Line 54: auto it = rhs.constBegin(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/bce203e0_6360db46 PS24, Line 54: auto it = rhs.constBegin(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/c5251301_7ea64972 PS24, Line 55: while (it != rhs.constEnd()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/b59a3c7a_bc1bdb37 PS24, Line 55: while (it != rhs.constEnd()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/cea3e7d3_5c411caf PS24, Line 55: while (it != rhs.constEnd()) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/a1a5b99a_87010600 PS24, Line 55: while (it != rhs.constEnd()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/9330221c_bc6251b8 PS24, Line 56: { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/79c6f384_e0b4edac PS24, Line 56: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/0162a747_2d688249 PS24, Line 57: node.force_insert(it.key(), it.value()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/bffd749e_949126c6 PS24, Line 57: node.force_insert(it.key(), it.value()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/ed3553e7_5fb5eb44 PS24, Line 58: ++it; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/f508ea8c_f94aa47a PS24, Line 58: ++it; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/a70060ea_98660721 PS24, Line 59: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/6214be3e_0b63634f PS24, Line 59: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/ac29e781_7508bde4 PS24, Line 60: return node; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/a7aba15e_8abb745b PS24, Line 60: return node; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/478ffcd2_923118b5 PS24, Line 61: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/6f65c2c6_7a521092 PS24, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/1b529c5a_61a09890 PS24, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/14b9108a_ba491db4 PS24, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/eea3648f_a6d956ae PS24, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/dc1507d8_61d1c174 PS24, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/20024a82_00225e98 PS24, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/e7a453b8_77269467 PS24, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/08bf1116_a242b63d PS24, Line 64: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/78bf54d7_dcaef26f PS24, Line 65: if (!node.IsMap()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/b35d09d4_93651ede PS24, Line 65: if (!node.IsMap()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/1668966f_fafce36e PS24, Line 65: if (!node.IsMap()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/d3f06681_bbfa8114 PS24, Line 66: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/e805b3f8_4262eca3 PS24, Line 66: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/8fca728f_9efe9a81 PS24, Line 68: rhs.clear(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/5a0742be_5878332b PS24, Line 68: rhs.clear(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/c0e1dd22_ed700515 PS24, Line 69: const_iterator it = node.begin(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/25333885_39fc7dd0 PS24, Line 69: const_iterator it = node.begin(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/ef8caeab_9d547db9 PS24, Line 70: while (it != node.end()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/a70910e0_0651d766 PS24, Line 70: while (it != node.end()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/eade4970_d788990d PS24, Line 70: while (it != node.end()) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/cca2b19a_375dba33 PS24, Line 70: while (it != node.end()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/babccf04_3917dc1b PS24, Line 71: { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/f1ebc6e5_b921b615 PS24, Line 71: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/87f739b1_b4300c15 PS24, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/5249bc89_540090b5 PS24, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/22414148_43e7fd2a PS24, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/23a522b5_802b9416 PS24, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/e8d6ed14_faf80cb9 PS24, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/414277d3_f7a2047d PS24, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/39de8428_b006fa7e PS24, Line 73: ++it; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/299d292a_0bf6309a PS24, Line 73: ++it; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/710e4d8d_8d228108 PS24, Line 74: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/75a19f78_fdeb9843 PS24, Line 74: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/874947ab_74c3b291 PS24, Line 75: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/cbf1ce92_c1a0ad46 PS24, Line 75: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/5d6463b8_00a97f77 PS24, Line 76: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/9693588e_f6809095 PS24, Line 80: template<typename T> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/52c39535_cbe8d506 PS24, Line 80: template<typename T> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/7dd3d2d2_d615b2e2 PS24, Line 81: struct convert<QVector<T> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/7a57353b_1e401b7a PS24, Line 81: struct convert<QVector<T> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/ed07d85a_2496c0a4 PS24, Line 81: struct convert<QVector<T> > spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/9be81b21_56365aba PS24, Line 83: static Node encode(const QVector<T>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/4ac896b8_e3ff5712 PS24, Line 83: static Node encode(const QVector<T>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/6983f251_f703e6d6 PS24, Line 83: static Node encode(const QVector<T>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/a6229193_d6fab790 PS24, Line 83: static Node encode(const QVector<T>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/6b69ca0a_8714e173 PS24, Line 83: static Node encode(const QVector<T>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/7f53be0e_18777a90 PS24, Line 83: static Node encode(const QVector<T>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/e84fecf1_0e446f62 PS24, Line 84: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/cd42ad6e_4032a004 PS24, Line 85: Node node(NodeType::Sequence); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/a9bea95e_c550c985 PS24, Line 85: Node node(NodeType::Sequence); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/1b8147db_92ea0a99 PS24, Line 86: foreach (T value, rhs) { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/57c10ea2_be3db64f PS24, Line 86: foreach (T value, rhs) { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/55e16cf4_7c805aa3 PS24, Line 86: foreach (T value, rhs) { space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/580ed7b5_59b89b88 PS24, Line 87: node.push_back(value); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/86d290b0_90e129cb PS24, Line 87: node.push_back(value); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/121ccb8e_ea8592e8 PS24, Line 88: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/b8726ed0_6fc16876 PS24, Line 88: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/5fb92b7a_0c14b555 PS24, Line 89: return node; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/40a2a42f_87a36b9c PS24, Line 89: return node; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/9d6c16a6_bd179880 PS24, Line 90: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/ad7f9148_8748a40b PS24, Line 92: static bool decode(const Node& node, QVector<T>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/795bdd2d_1bacbc7d PS24, Line 92: static bool decode(const Node& node, QVector<T>& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/41a00749_4108f194 PS24, Line 92: static bool decode(const Node& node, QVector<T>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/5e75a550_2c55c777 PS24, Line 92: static bool decode(const Node& node, QVector<T>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/e8cb0dc4_f6ae9668 PS24, Line 92: static bool decode(const Node& node, QVector<T>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/a69ac13d_b7e9f4b5 PS24, Line 92: static bool decode(const Node& node, QVector<T>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/d110437d_d0c099eb PS24, Line 92: static bool decode(const Node& node, QVector<T>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/8adffcb7_95b4c025 PS24, Line 93: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/dc00ab57_c384ebec PS24, Line 94: if (!node.IsSequence()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/e4e9583f_ad8a7c84 PS24, Line 94: if (!node.IsSequence()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/8dc89149_51c0a93f PS24, Line 94: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/1d34af55_25089d72 PS24, Line 95: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/a394a062_7c20c13a PS24, Line 95: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/e4d03aa7_7f3052d6 PS24, Line 97: rhs.clear(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/771fccd6_d749bf86 PS24, Line 97: rhs.clear(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/ce7b9c90_c4d84d70 PS24, Line 98: const_iterator it = node.begin(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/b4dac010_a59dcbde PS24, Line 98: const_iterator it = node.begin(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/8021c4f4_561d3568 PS24, Line 99: while (it != node.end()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/b7b72738_6d04b38b PS24, Line 99: while (it != node.end()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/835d4457_ef9dc0aa PS24, Line 99: while (it != node.end()) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/b031a064_aea5ec1f PS24, Line 99: while (it != node.end()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/f0666095_df93f6a3 PS24, Line 100: { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/7e153ce9_6d5b7fa0 PS24, Line 100: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/3f4c0d3e_4e8e5ba7 PS24, Line 101: rhs.push_back(it->as<T>()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/4ff6cf89_7f2cacce PS24, Line 101: rhs.push_back(it->as<T>()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/4092453d_540a24ed PS24, Line 101: rhs.push_back(it->as<T>()); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/3e5f7f03_95852fdc PS24, Line 101: rhs.push_back(it->as<T>()); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/03c9bb3d_8b7c41e8 PS24, Line 102: ++it; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/de858e67_a5563292 PS24, Line 102: ++it; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/cc99a6ec_b895d7e1 PS24, Line 103: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/24480617_616c13ac PS24, Line 103: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/d9bfefad_9359fe8b PS24, Line 104: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/8d0daf8f_618e9afc PS24, Line 104: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/df3953c1_51d17b4d PS24, Line 105: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/5479d51f_77f5e3f1 PS24, Line 109: template<typename T> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/fae472ea_234d1d68 PS24, Line 109: template<typename T> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/e481df12_fd0820b6 PS24, Line 110: struct convert<QList<T> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/a89674ea_f6e3aaeb PS24, Line 110: struct convert<QList<T> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/1ca2f421_a3ad1f1a PS24, Line 110: struct convert<QList<T> > spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/40732f0d_9d9bdeb1 PS24, Line 112: static Node encode(const QList<T>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/ff078fe3_05c8f00d PS24, Line 112: static Node encode(const QList<T>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/7d900b7f_6535dad2 PS24, Line 112: static Node encode(const QList<T>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/9463b51b_1a490d3a PS24, Line 112: static Node encode(const QList<T>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/421c98de_a5d88789 PS24, Line 112: static Node encode(const QList<T>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/104c2f21_ba03f77d PS24, Line 112: static Node encode(const QList<T>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/874e1e67_bb334361 PS24, Line 113: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/51beb92d_8c05820e PS24, Line 114: Node node(NodeType::Sequence); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/3b5db442_5e12ca60 PS24, Line 114: Node node(NodeType::Sequence); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/2a59c941_5b47ce75 PS24, Line 115: foreach (T value, rhs) { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/252cfb3c_a2ccfc52 PS24, Line 115: foreach (T value, rhs) { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/99769905_d1c828dc PS24, Line 115: foreach (T value, rhs) { space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/407ca5b9_248344f2 PS24, Line 116: node.push_back(value); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/be71b6f9_44bbb364 PS24, Line 116: node.push_back(value); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/8cc55c52_6032b54c PS24, Line 117: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/cc2ba9c8_6d19a6c8 PS24, Line 117: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/9ee5c18c_e04f8860 PS24, Line 118: return node; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/e8337e7e_13e10f91 PS24, Line 118: return node; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/a361365d_8bcf50f5 PS24, Line 119: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/e2d96756_c4c53631 PS24, Line 121: static bool decode(const Node& node, QList<T>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/dd547cce_e6184e1c PS24, Line 121: static bool decode(const Node& node, QList<T>& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/e3225678_509ac332 PS24, Line 121: static bool decode(const Node& node, QList<T>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/5801d696_4da6f223 PS24, Line 121: static bool decode(const Node& node, QList<T>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/6a9b69fd_bf6eff67 PS24, Line 121: static bool decode(const Node& node, QList<T>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/55c6e0a7_f733d028 PS24, Line 121: static bool decode(const Node& node, QList<T>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/4e7d74b7_99c8a7ec PS24, Line 121: static bool decode(const Node& node, QList<T>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/5da5cb22_91b88212 PS24, Line 122: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/3c4dbdbf_9f6f581e PS24, Line 123: if (!node.IsSequence()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/72ab4ef7_418caa43 PS24, Line 123: if (!node.IsSequence()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/a5600a38_cd9c1a69 PS24, Line 123: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/bc5f745b_a93af4b2 PS24, Line 124: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/0044bbac_7f7ae34b PS24, Line 124: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/11778035_ebf73d80 PS24, Line 126: rhs.clear(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/1351edea_c8ae1fab PS24, Line 126: rhs.clear(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/08da48f0_7c374092 PS24, Line 127: const_iterator it = node.begin(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/a09cc523_5d906421 PS24, Line 127: const_iterator it = node.begin(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/e50e7281_df75db8f PS24, Line 128: while (it != node.end()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/34ecb2fd_4b290c76 PS24, Line 128: while (it != node.end()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/453fde74_73031e7c PS24, Line 128: while (it != node.end()) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/4228a882_6657a5e9 PS24, Line 128: while (it != node.end()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/46205348_d7267d14 PS24, Line 129: { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/c5a86090_4e9a7b05 PS24, Line 129: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/169ed215_9b418327 PS24, Line 130: rhs.push_back(it->as<T>()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/09fa843a_c845d376 PS24, Line 130: rhs.push_back(it->as<T>()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/f63a0f68_9c8885b6 PS24, Line 130: rhs.push_back(it->as<T>()); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/87050930_99f5f72a PS24, Line 130: rhs.push_back(it->as<T>()); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/3f23dfcb_69db4f11 PS24, Line 131: ++it; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/0a5d4962_0d82acaf PS24, Line 131: ++it; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/bdfe9d41_bc948149 PS24, Line 132: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/11aac793_3dd984d0 PS24, Line 132: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/25fd77e1_086e3e38 PS24, Line 133: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/c91ba5dd_27d98511 PS24, Line 133: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/51251d93_89b3561a PS24, Line 134: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/b270377c_51be4997 PS24, Line 138: template<typename T, typename U> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/abe967c0_0b36fd32 PS24, Line 138: template<typename T, typename U> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/be80276e_9ef86d63 PS24, Line 139: struct convert<QPair<T,U> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/acad3277_e4f9be8f PS24, Line 139: struct convert<QPair<T,U> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/8c7b4d8f_bb443885 PS24, Line 139: struct convert<QPair<T,U> > space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/cb6c5c1e_1e4ac1de PS24, Line 139: struct convert<QPair<T,U> > spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/81be134f_4c136c27 PS24, Line 141: static Node encode(const QPair<T,U>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/15d2cf08_51f72600 PS24, Line 141: static Node encode(const QPair<T,U>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/e7960e0b_83646bfc PS24, Line 141: static Node encode(const QPair<T,U>& rhs) space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/0d69a70f_b3b24f97 PS24, Line 141: static Node encode(const QPair<T,U>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/bf9b1c94_d63ceab7 PS24, Line 141: static Node encode(const QPair<T,U>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/cb3125d4_d1057466 PS24, Line 141: static Node encode(const QPair<T,U>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/8c694960_cc0db8d4 PS24, Line 141: static Node encode(const QPair<T,U>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/8e3ae5b6_49cba184 PS24, Line 142: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/0321f940_ee348d02 PS24, Line 143: Node node(NodeType::Sequence); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/050015ee_8e8ccb21 PS24, Line 143: Node node(NodeType::Sequence); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/10bb0c9b_2d3fce27 PS24, Line 144: node.push_back(rhs.first); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/8a611363_34a5ce42 PS24, Line 144: node.push_back(rhs.first); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/89456f75_711ce14a PS24, Line 145: node.push_back(rhs.second); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/5969433e_893b859b PS24, Line 145: node.push_back(rhs.second); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/8f1177e0_20bf2519 PS24, Line 146: return node; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/29fb51e3_53d85dcb PS24, Line 146: return node; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/80dada21_09e9a83f PS24, Line 147: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/1f1befdf_6d6d9aab PS24, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/f091edb8_1cf5defc PS24, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/be112a27_b4d7b1af PS24, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/3d615f67_05ffbf74 PS24, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/dea30921_339f2fd4 PS24, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/891f7497_031625f3 PS24, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/f90f8688_3f3217dd PS24, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/f067bf61_43e49151 PS24, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/09b06260_bdaee195 PS24, Line 150: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/4feaacf8_97b815c0 PS24, Line 151: if (!node.IsSequence()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/c2c7857b_00a69378 PS24, Line 151: if (!node.IsSequence()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/0a232731_5847a915 PS24, Line 151: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/bf7a2771_2f241924 PS24, Line 152: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/c3701803_9db9b7e5 PS24, Line 152: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/53e89f70_30b785f2 PS24, Line 153: if (node.size() != 2) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/75152048_09fa0a85 PS24, Line 153: if (node.size() != 2) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/bc2cd0e8_69cfa069 PS24, Line 153: if (node.size() != 2) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/3e87c49e_90e5a88d PS24, Line 154: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/3021a4fa_9c6e341f PS24, Line 154: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/8c7a7128_4236186b PS24, Line 156: rhs.first = node[0].as<T>(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/326ba743_7a930e20 PS24, Line 156: rhs.first = node[0].as<T>(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/c3d8dbd9_61797775 PS24, Line 156: rhs.first = node[0].as<T>(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/660876e6_42b207a0 PS24, Line 156: rhs.first = node[0].as<T>(); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/482c81a3_458dee1e PS24, Line 157: rhs.second = node[1].as(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/f1be12c6_4abd2ec6 PS24, Line 157: rhs.second = node[1].as(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/9a857403_306eac8f PS24, Line 157: rhs.second = node[1].as(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/51396f28_dbc46ea2 PS24, Line 157: rhs.second = node[1].as(); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/b982c7ff_4e708297 PS24, Line 158: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/01933616_a30ac23b PS24, Line 158: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/7843c3e4_9aa20af6 PS24, Line 159: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/6ee5adbb_43a91ac9 PS24, Line 163: template<> spaces required around that '<' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/9f1f11ac_ac46a36c PS24, Line 163: template<> spaces required around that '>' (ctx:OxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/bf7c4b9e_f94d52b1 PS24, Line 164: struct convert<QStringList> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/5e657a1e_f26f86b1 PS24, Line 164: struct convert<QStringList> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/eb709f2d_84084fc1 PS24, Line 166: static Node encode(const QStringList& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/f677f167_2f03cad5 PS24, Line 166: static Node encode(const QStringList& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/f58f9624_1be538ca PS24, Line 166: static Node encode(const QStringList& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/59826e3e_7ca3e122 PS24, Line 167: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/834bcf85_98e8e255 PS24, Line 168: Node node(NodeType::Sequence); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/c22ab672_e92a94d7 PS24, Line 168: Node node(NodeType::Sequence); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/7ae222b5_df9b9301 PS24, Line 169: for (const auto &value: rhs) { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/26bc54f3_4681c2e5 PS24, Line 169: for (const auto &value: rhs) { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/6e9bbcb1_2f417af6 PS24, Line 169: for (const auto &value: rhs) { suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/4df2c0f5_a117de32 PS24, Line 169: for (const auto &value: rhs) { need consistent spacing around '&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/c27e0bd8_14bf9cef PS24, Line 169: for (const auto &value: rhs) { spaces required around that ':' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/1a5f04a6_9ddab089 PS24, Line 169: for (const auto &value: rhs) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/8ead8c53_9eb61eca PS24, Line 170: node.push_back(value); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/61f388ac_541e043d PS24, Line 170: node.push_back(value); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/3f6a5a32_864f7f3e PS24, Line 171: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/f439a76b_f222a02d PS24, Line 171: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/e0bf50b2_bc3cd814 PS24, Line 172: return node; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/1eca27b0_f1c5b191 PS24, Line 172: return node; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/9b19da99_baf69bdf PS24, Line 173: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/13e71c67_f7ebad51 PS24, Line 175: static bool decode(const Node& node, QStringList& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/61e54530_6cb68da7 PS24, Line 175: static bool decode(const Node& node, QStringList& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/bc8345b1_11e5d5b3 PS24, Line 175: static bool decode(const Node& node, QStringList& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/197e6b97_3841ec30 PS24, Line 175: static bool decode(const Node& node, QStringList& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/a9f11ff8_b7d973bb PS24, Line 176: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/c49d3996_a68d09da PS24, Line 177: if (!node.IsSequence()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/8a1dff13_32cfa768 PS24, Line 177: if (!node.IsSequence()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/dc6cab1e_9464a377 PS24, Line 177: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/455f8274_fcadc152 PS24, Line 178: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/a6e769ea_e91c8648 PS24, Line 178: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/db05a9b3_cfdbbc26 PS24, Line 180: rhs.clear(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/cce6a26f_714d17af PS24, Line 180: rhs.clear(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/9dcab284_51c75b3a PS24, Line 181: const_iterator it = node.begin(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/da0bb3a0_2d2b2de9 PS24, Line 181: const_iterator it = node.begin(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/e544fb41_38486962 PS24, Line 182: while (it != node.end()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/f4db3a95_c1b94141 PS24, Line 182: while (it != node.end()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/076b20b8_ec1a0b1c PS24, Line 182: while (it != node.end()) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/b759aa12_8cf08e10 PS24, Line 182: while (it != node.end()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/a277834b_ea816ec6 PS24, Line 183: { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/494ebb81_d56fcd00 PS24, Line 183: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/c14da000_4b82f34f PS24, Line 184: rhs.push_back(it->as<QString>()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/4b431ba3_33cddabd PS24, Line 184: rhs.push_back(it->as<QString>()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/4f4713c7_99764895 PS24, Line 184: rhs.push_back(it->as<QString>()); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/272016d4_203eaa70 PS24, Line 184: rhs.push_back(it->as<QString>()); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/354123d8_ee5c3192 PS24, Line 185: ++it; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/fbe74f1a_a05b4128 PS24, Line 185: ++it; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/2059ff76_d8c044bf PS24, Line 186: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/51dd3ad7_1728e52b PS24, Line 186: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/ff642418_cae66e72 PS24, Line 187: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/08c6febf_87427e8b PS24, Line 187: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/1c66a4d9_8a93a587 PS24, Line 188: } please, no spaces at the start of a line File util/coreboot-configurator/src/application/toggleswitch.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/31dfa008_f447a8bb PS24, Line 16: public: spaces required around that ':' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/6965b4b5_e9a2cef9 PS24, Line 17: explicit ToggleSwitch(QWidget* parent = nullptr); need consistent spacing around '*' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/84933389_45150ec7 PS24, Line 25: void recolorToggleOn(const QPalette& palette); need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/740ccfea_517910a8 PS24, Line 30: void paintEvent(QPaintEvent *event) override; need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/9feb466c_564a4df2 PS24, Line 34: bool hitButton(const QPoint &pos) const override need consistent spacing around '&' (ctx:WxV) -- To view, visit https://review.coreboot.org/c/coreboot/+/58854 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie654f6aca57a792be0c295afc081a95ed4d875d1 Gerrit-Change-Number: 58854 Gerrit-PatchSet: 24 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com> Gerrit-Comment-Date: Thu, 04 Nov 2021 22:56:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [WIP] util: Add coreboot Configurator
by build bot (Jenkins) (Code Review) 04 Nov '21

04 Nov '21

Attention is currently required from: Martin Roth, Matt DeVillier, Tim Wawrzynczak, Angel Pons. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58854 ) Change subject: [WIP] util: Add coreboot Configurator ...................................................................... Patch Set 23: (352 comments) File util/coreboot-configurator/src/application/aboutwindow.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/69c76b67_b60292d4 PS23, Line 16: public: spaces required around that ':' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/2c35b1c3_6faf99da PS23, Line 17: explicit aboutWindow(QWidget *parent = nullptr); need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/d0b76c72_5e0986a5 PS23, Line 21: Ui::aboutWindow *ui; need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/e917ae32_5801bf75 PS23, Line 21: Ui::aboutWindow *ui; labels should not be indented File util/coreboot-configurator/src/application/configuration.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/89a3fa8f_76ff08f0 PS23, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/919f2f25_3cd83a21 PS23, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/9f6d22b9_97f3d62d PS23, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/db2cfd1a_53439b4e PS23, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/321cc729_9fb05b90 PS23, Line 15: QMap<QString,QString> fromNvramTool(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/ac751c31_95ab8613 PS23, Line 15: QMap<QString,QString> fromNvramTool(); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/0bf72640_f98d9292 PS23, Line 15: QMap<QString,QString> fromNvramTool(); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/7b513335_4b34729e PS23, Line 17: QMap<QString,QString> mocked(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/908fce84_b4c0de4a PS23, Line 17: QMap<QString,QString> mocked(); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/488e3a84_33ccae0f PS23, Line 17: QMap<QString,QString> mocked(); spaces required around that '>' (ctx:VxW) File util/coreboot-configurator/src/application/coreboot_configurator.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/52d71be3_dde34fd5 PS23, Line 29: public: spaces required around that ':' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/b200f0ad_d691b046 PS23, Line 30: coreboot_configurator(QWidget *parent = nullptr); need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/8f799a94_ebbbbeb8 PS23, Line 37: void showEvent(QShowEvent *ev); need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/48b76298_bad7eb08 PS23, Line 48: void displaySettings(); Bad function definition - void displaySettings() should probably be void displaySettings(void) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/bd0893d8_62df3d14 PS23, Line 52: void writeToFile(const QString& out_file); need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/5a55c61b_4874cc8a PS23, Line 55: void updateValue(const QString& name); need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/c227fe96_7e3cf28b PS23, Line 61: QMap<QString, QString> m_values; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/b9c70630_9a4485fa PS23, Line 61: QMap<QString, QString> m_values; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/7b63c47b_4fbc7d18 PS23, Line 64: QMap<QString, QVBoxLayout*> m_tabs; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/3788105c_95bc71a2 PS23, Line 64: QMap<QString, QVBoxLayout*> m_tabs; spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/4d2f2c0d_f6709242 PS23, Line 67: YAML::Node m_categories; labels should not be indented Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/6a4a4b56_0aa00493 PS23, Line 70: QComboBox *textToDisplay(const QString &in_string); need consistent spacing around '&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/b8577e72_fe75e13f PS23, Line 71: QCheckBox *checkToDisplay(const QString &in_string); need consistent spacing around '&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/9c509e43_f97b334b PS23, Line 73: Ui::coreboot_configurator *ui; need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/d9d6df36_8daa209e PS23, Line 73: Ui::coreboot_configurator *ui; labels should not be indented File util/coreboot-configurator/src/application/coreboot_configurator.cpp: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/ed5e9dda_19b7ddf1 PS23, Line 207: trailing whitespace File util/coreboot-configurator/src/application/qtyaml.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/10620786_77f6df8d PS23, Line 30: template<> spaces required around that '<' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/ae3ec3e0_b6ad193c PS23, Line 30: template<> spaces required around that '>' (ctx:OxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/caa9ce78_e782da2e PS23, Line 31: struct convert<QString> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/793875b2_35d77d5b PS23, Line 31: struct convert<QString> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/59752d46_5d96c301 PS23, Line 33: static Node encode(const QString& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/a138ed99_945ed933 PS23, Line 33: static Node encode(const QString& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/d3da97ef_7311602f PS23, Line 33: static Node encode(const QString& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/8ab39164_f8ac834b PS23, Line 34: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/64870097_4fd93d4c PS23, Line 35: return Node(rhs.toStdString()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/b27e0697_4d78313f PS23, Line 35: return Node(rhs.toStdString()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/41d13c06_07f5780d PS23, Line 36: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/69e6f402_5fd4cc4f PS23, Line 38: static bool decode(const Node& node, QString& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/8f8145ba_55b986d2 PS23, Line 38: static bool decode(const Node& node, QString& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/616f7ba9_1bed32dc PS23, Line 38: static bool decode(const Node& node, QString& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/b2a78122_b48709ee PS23, Line 38: static bool decode(const Node& node, QString& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/6f646d01_556c76ed PS23, Line 39: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/45b4cf3b_e24f21af PS23, Line 40: if (!node.IsScalar()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/11d842db_d7e331f9 PS23, Line 40: if (!node.IsScalar()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/b18a3d6c_88e8a36f PS23, Line 40: if (!node.IsScalar()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/70acb71c_b89e9bd9 PS23, Line 41: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/4d074772_4fcdc610 PS23, Line 41: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/da0886b8_a1ed6aa7 PS23, Line 42: rhs = QString::fromStdString(node.Scalar()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/d31fe226_9b284d30 PS23, Line 42: rhs = QString::fromStdString(node.Scalar()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/9fb65f7e_a5821816 PS23, Line 43: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/298cd2a2_cf9fd44d PS23, Line 43: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/16b0ba1b_882af7a0 PS23, Line 44: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/01112ae7_c46ee3cc PS23, Line 48: template<typename Key, typename Value> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/450582f9_430649aa PS23, Line 48: template<typename Key, typename Value> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/e29edb34_1420f21b PS23, Line 49: struct convert<QMap<Key, Value> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/648430dd_1e48e1b0 PS23, Line 49: struct convert<QMap<Key, Value> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/86553c69_ee435236 PS23, Line 49: struct convert<QMap<Key, Value> > spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/000629e1_8106afa1 PS23, Line 51: static Node encode(const QMap<Key,Value>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/387e61de_f54736e9 PS23, Line 51: static Node encode(const QMap<Key,Value>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/8d9c8ae8_626717c0 PS23, Line 51: static Node encode(const QMap<Key,Value>& rhs) space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/529f8c90_be4ee195 PS23, Line 51: static Node encode(const QMap<Key,Value>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/cb866320_f3a46dfd PS23, Line 51: static Node encode(const QMap<Key,Value>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/a96d5906_34b7a472 PS23, Line 51: static Node encode(const QMap<Key,Value>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/506c0b9c_a0cf9317 PS23, Line 51: static Node encode(const QMap<Key,Value>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/1b9c55b7_841daa50 PS23, Line 52: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/1ac709b5_67e35e8b PS23, Line 53: Node node(NodeType::Map); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/95563120_a97aa701 PS23, Line 53: Node node(NodeType::Map); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/798862f4_c4a7a331 PS23, Line 54: auto it = rhs.constBegin(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/cd808f61_e4be8dd5 PS23, Line 54: auto it = rhs.constBegin(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/dc10fd95_fc4e81a8 PS23, Line 55: while (it != rhs.constEnd()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/8eae6ed5_59a7684e PS23, Line 55: while (it != rhs.constEnd()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/ab9dc22a_152a3301 PS23, Line 55: while (it != rhs.constEnd()) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/af954614_4d19e164 PS23, Line 55: while (it != rhs.constEnd()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/33446c31_17a95745 PS23, Line 56: { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/cc797e95_04ac27e9 PS23, Line 56: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/77f5a40a_aa88aa55 PS23, Line 57: node.force_insert(it.key(), it.value()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/ade751f0_6a9d10fd PS23, Line 57: node.force_insert(it.key(), it.value()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/706ce303_baf99716 PS23, Line 58: ++it; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/025b47ef_5b17af81 PS23, Line 58: ++it; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/07a8b64d_54752339 PS23, Line 59: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/70dc6719_392b2a73 PS23, Line 59: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/1a6dcde5_75605005 PS23, Line 60: return node; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/de1e7c8c_0f2f47e6 PS23, Line 60: return node; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/6221a5ad_fa1ac832 PS23, Line 61: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/f866588a_d8e1bcc7 PS23, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/2ad7918c_fb6a309d PS23, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/2335a709_2f136089 PS23, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/f8c8875a_966d49ae PS23, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/bd6a1b02_cb99e61c PS23, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/bf5d2861_2a450253 PS23, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/c27ef375_6e359efc PS23, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/073a62a2_1ca3929d PS23, Line 64: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/f2bf1e7f_54d24d30 PS23, Line 65: if (!node.IsMap()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/46995b84_141b51fb PS23, Line 65: if (!node.IsMap()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/f039c50f_25435bdd PS23, Line 65: if (!node.IsMap()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/4e167fcf_f7fadd74 PS23, Line 66: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/e95e83a7_717ac7de PS23, Line 66: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/971d28cd_fe86e6ac PS23, Line 68: rhs.clear(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/f6d7b176_7dd5f621 PS23, Line 68: rhs.clear(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/94c32fa3_658d58ff PS23, Line 69: const_iterator it = node.begin(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/fb3dd08c_6230ffb8 PS23, Line 69: const_iterator it = node.begin(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/82664ea2_15f11833 PS23, Line 70: while (it != node.end()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/bd4c0688_37fc235c PS23, Line 70: while (it != node.end()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/0e36a54d_eb9ced27 PS23, Line 70: while (it != node.end()) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/9e504a95_8ec18c26 PS23, Line 70: while (it != node.end()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/9fa6a3c1_af83e51c PS23, Line 71: { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/46a6a61c_61271536 PS23, Line 71: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/467a0e4b_2edd7e9f PS23, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/3ee1fa51_50b0ff96 PS23, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/0674bf82_004db7df PS23, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/b1b2e51f_c510511d PS23, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/335d2104_da1a7a28 PS23, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/52d3db71_128993b8 PS23, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/c8deedb4_d76febbc PS23, Line 73: ++it; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/cb1d0999_e16be482 PS23, Line 73: ++it; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/05bd35e6_b560ded9 PS23, Line 74: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/bd4d1e00_cdce6fbb PS23, Line 74: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/7d9f9f6c_c35398c1 PS23, Line 75: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/f46ad4cd_f6dd30c1 PS23, Line 75: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/72acddf0_118d6dee PS23, Line 76: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/31572889_c881fad7 PS23, Line 80: template<typename T> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/e0a67310_aad1042b PS23, Line 80: template<typename T> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/b6badeb9_0a5f4d2a PS23, Line 81: struct convert<QVector<T> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/5dfbfd5a_0870ddee PS23, Line 81: struct convert<QVector<T> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/728ab070_0c347a45 PS23, Line 81: struct convert<QVector<T> > spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/e675d4c5_984ca55c PS23, Line 83: static Node encode(const QVector<T>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/fb9f3bec_3e048bf7 PS23, Line 83: static Node encode(const QVector<T>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/d5bc1b85_1781a78f PS23, Line 83: static Node encode(const QVector<T>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/4883a93f_c8acb0ce PS23, Line 83: static Node encode(const QVector<T>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/2eac9c2a_dbbefdad PS23, Line 83: static Node encode(const QVector<T>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/fd092787_1df87662 PS23, Line 83: static Node encode(const QVector<T>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/816dbb33_007180f7 PS23, Line 84: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/8a610aae_c191116e PS23, Line 85: Node node(NodeType::Sequence); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/01f4d4c5_56134fb9 PS23, Line 85: Node node(NodeType::Sequence); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/992a5fb9_afa28a3a PS23, Line 86: foreach (T value, rhs) { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/949554c9_1783136c PS23, Line 86: foreach (T value, rhs) { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/da8ea921_7f61f7ba PS23, Line 86: foreach (T value, rhs) { space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/f3217d9f_3e6398f6 PS23, Line 87: node.push_back(value); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/7f7125b7_3a887afb PS23, Line 87: node.push_back(value); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/5731d6eb_bf8d0188 PS23, Line 88: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/385c6df7_77c9f6a5 PS23, Line 88: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/3bf7a39a_70c74169 PS23, Line 89: return node; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/c991cc1c_82f7e19c PS23, Line 89: return node; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/119f6f28_9586b0e7 PS23, Line 90: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/1c2a4b40_067e43c1 PS23, Line 92: static bool decode(const Node& node, QVector<T>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/b91aeeda_4407dca2 PS23, Line 92: static bool decode(const Node& node, QVector<T>& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/47dbaaaf_eaf59886 PS23, Line 92: static bool decode(const Node& node, QVector<T>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/eab9cc74_76f44194 PS23, Line 92: static bool decode(const Node& node, QVector<T>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/540d0675_e7be01be PS23, Line 92: static bool decode(const Node& node, QVector<T>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/3bc5e017_d8e24c75 PS23, Line 92: static bool decode(const Node& node, QVector<T>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/2c131154_d152cd29 PS23, Line 92: static bool decode(const Node& node, QVector<T>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/e1d5bbc1_480460d5 PS23, Line 93: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/bc1e1516_98dee61f PS23, Line 94: if (!node.IsSequence()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/67457a31_ab5f0543 PS23, Line 94: if (!node.IsSequence()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/1983ec29_a3b49628 PS23, Line 94: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/dca078ef_eac43f30 PS23, Line 95: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/49f9a730_ea42f87e PS23, Line 95: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/8f07ddcb_05a577eb PS23, Line 97: rhs.clear(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/293c86f9_f825b5fb PS23, Line 97: rhs.clear(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/f386de8c_fd805f29 PS23, Line 98: const_iterator it = node.begin(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/a3b86876_4f19d523 PS23, Line 98: const_iterator it = node.begin(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/6168e94c_aa30c599 PS23, Line 99: while (it != node.end()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/451beb07_ad8dfbf6 PS23, Line 99: while (it != node.end()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/935a1b86_16ebb575 PS23, Line 99: while (it != node.end()) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/bebe2df4_8c4b4f18 PS23, Line 99: while (it != node.end()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/9eafa2d1_bcd1879a PS23, Line 100: { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/331191cc_23773a08 PS23, Line 100: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/7bce2cfd_9cfa4dce PS23, Line 101: rhs.push_back(it->as<T>()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/ec5cfb9b_eeb26380 PS23, Line 101: rhs.push_back(it->as<T>()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/057cb99d_6454675d PS23, Line 101: rhs.push_back(it->as<T>()); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/4be01b89_aedf5e59 PS23, Line 101: rhs.push_back(it->as<T>()); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/1651b3ee_91729431 PS23, Line 102: ++it; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/28f18a8b_3e194715 PS23, Line 102: ++it; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/16acbd84_c6f4d521 PS23, Line 103: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/a1b0c5e8_b2aa67da PS23, Line 103: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/5f8239dc_7015f38c PS23, Line 104: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/cbc0f8dd_0cf1019a PS23, Line 104: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/cd597530_22960d7c PS23, Line 105: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/c053de4b_a01800c9 PS23, Line 109: template<typename T> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/12e28c04_13547e05 PS23, Line 109: template<typename T> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/e691f516_2397cfe6 PS23, Line 110: struct convert<QList<T> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/862937f6_a554b7f6 PS23, Line 110: struct convert<QList<T> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/8bfce6cf_e5df9bc7 PS23, Line 110: struct convert<QList<T> > spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/c58103e0_3e0e3067 PS23, Line 112: static Node encode(const QList<T>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/0122240b_23718690 PS23, Line 112: static Node encode(const QList<T>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/34a18abd_9a6ef613 PS23, Line 112: static Node encode(const QList<T>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/d5db2996_f72b9868 PS23, Line 112: static Node encode(const QList<T>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/654a33b2_73a89a9c PS23, Line 112: static Node encode(const QList<T>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/c4bedb87_413d3cca PS23, Line 112: static Node encode(const QList<T>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/e5f088c9_61ef8911 PS23, Line 113: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/6c89b18e_9a7ba283 PS23, Line 114: Node node(NodeType::Sequence); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/4cfb6174_45ffe861 PS23, Line 114: Node node(NodeType::Sequence); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/c59e2c0f_275ec680 PS23, Line 115: foreach (T value, rhs) { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/a1832cfb_056bb17d PS23, Line 115: foreach (T value, rhs) { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/d0e3045a_4acd0d75 PS23, Line 115: foreach (T value, rhs) { space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/f3c70221_8834ab9a PS23, Line 116: node.push_back(value); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/c40854b2_b04af9cd PS23, Line 116: node.push_back(value); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/dfafb1cf_3dac297a PS23, Line 117: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/34f70603_95a52bb2 PS23, Line 117: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/c2a0ddd0_699dd498 PS23, Line 118: return node; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/df97d841_f5f734a4 PS23, Line 118: return node; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/dbb03e7a_c750ea93 PS23, Line 119: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/7d871afd_21c96ebf PS23, Line 121: static bool decode(const Node& node, QList<T>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/2a2fd244_005d77f6 PS23, Line 121: static bool decode(const Node& node, QList<T>& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/596e4a13_c50a79ee PS23, Line 121: static bool decode(const Node& node, QList<T>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/3b4d47d6_45b69d48 PS23, Line 121: static bool decode(const Node& node, QList<T>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/22b34c2c_7a599434 PS23, Line 121: static bool decode(const Node& node, QList<T>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/0e13e17d_b5dd04d0 PS23, Line 121: static bool decode(const Node& node, QList<T>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/63289b6f_65055239 PS23, Line 121: static bool decode(const Node& node, QList<T>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/ba309ef0_0f388f5a PS23, Line 122: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/e86f7ba7_fc5ded3f PS23, Line 123: if (!node.IsSequence()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/e81b93e2_f7d64b23 PS23, Line 123: if (!node.IsSequence()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/dff4c23f_ec325dd2 PS23, Line 123: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/5a0dce3a_b6d52269 PS23, Line 124: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/59592ed3_bdd1643a PS23, Line 124: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/f30fd89f_1918bb34 PS23, Line 126: rhs.clear(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/b1a9cf67_885010b6 PS23, Line 126: rhs.clear(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/f59575c5_b1f61fb4 PS23, Line 127: const_iterator it = node.begin(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/064cae7d_0ad6ab56 PS23, Line 127: const_iterator it = node.begin(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/2e961b38_a0b29489 PS23, Line 128: while (it != node.end()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/2e615935_d45f3da4 PS23, Line 128: while (it != node.end()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/a5f73197_8d6898e2 PS23, Line 128: while (it != node.end()) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/0cea26f6_41a15008 PS23, Line 128: while (it != node.end()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/1b8ec73a_717a8327 PS23, Line 129: { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/891a34dd_b48e27e1 PS23, Line 129: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/fdc4b0df_920fc94c PS23, Line 130: rhs.push_back(it->as<T>()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/cada4c51_336f5ef9 PS23, Line 130: rhs.push_back(it->as<T>()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/86f4670d_229e145e PS23, Line 130: rhs.push_back(it->as<T>()); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/e5d4acea_3aa66fc6 PS23, Line 130: rhs.push_back(it->as<T>()); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/ed4b001d_33d3cf03 PS23, Line 131: ++it; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/ae128f05_b82db3a4 PS23, Line 131: ++it; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/ae21485c_41a7731e PS23, Line 132: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/a29d0823_e2acfe93 PS23, Line 132: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/6b2f4b0c_0c2d968a PS23, Line 133: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/21921a41_95a03fbd PS23, Line 133: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/04f78a6c_90f65cc6 PS23, Line 134: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/62ce982b_1d730690 PS23, Line 138: template<typename T, typename U> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/a994a349_52d8926e PS23, Line 138: template<typename T, typename U> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/64d9c6a4_83da207d PS23, Line 139: struct convert<QPair<T,U> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/7f0919ab_9a529ca9 PS23, Line 139: struct convert<QPair<T,U> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/6f6bbee3_a09619d4 PS23, Line 139: struct convert<QPair<T,U> > space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/c62d05bf_f20be2e6 PS23, Line 139: struct convert<QPair<T,U> > spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/a705f875_02f74b59 PS23, Line 141: static Node encode(const QPair<T,U>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/596b255b_a12ce0c4 PS23, Line 141: static Node encode(const QPair<T,U>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/9ebcb3b2_99d7637b PS23, Line 141: static Node encode(const QPair<T,U>& rhs) space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/3afa3ede_5daf30f5 PS23, Line 141: static Node encode(const QPair<T,U>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/737a982f_a4b14aea PS23, Line 141: static Node encode(const QPair<T,U>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/e63bf3e3_733eff94 PS23, Line 141: static Node encode(const QPair<T,U>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/dfb43f26_d9552c1e PS23, Line 141: static Node encode(const QPair<T,U>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/71b5c04c_9e462268 PS23, Line 142: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/11c750ad_7d402eba PS23, Line 143: Node node(NodeType::Sequence); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/a19eff42_e0d9e143 PS23, Line 143: Node node(NodeType::Sequence); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/2fd322c6_2a5636ba PS23, Line 144: node.push_back(rhs.first); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/3e180ec5_c018b72a PS23, Line 144: node.push_back(rhs.first); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/2375e8b6_0caeeef5 PS23, Line 145: node.push_back(rhs.second); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/5c617d2b_ea62bdd8 PS23, Line 145: node.push_back(rhs.second); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/f26de770_9b8c2724 PS23, Line 146: return node; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/12293fc4_9823be4f PS23, Line 146: return node; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/10c6d532_576ba5a8 PS23, Line 147: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/846f3604_1227ee2a PS23, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/33d6c68b_689f403b PS23, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/452b5be6_6431a7ec PS23, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/e7650ed8_23832802 PS23, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/c2522057_c5b6e8cb PS23, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/7c19dd93_da53d06c PS23, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/8b2af4d7_78a4f3fc PS23, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/3d840013_5308330c PS23, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/8ea37143_0db0833b PS23, Line 150: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/fcdf7730_d4948cb9 PS23, Line 151: if (!node.IsSequence()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/f2bac408_155aa6b3 PS23, Line 151: if (!node.IsSequence()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/270090ee_b7e34449 PS23, Line 151: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/65197d8c_eefb91fc PS23, Line 152: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/62d96d31_6e641cf4 PS23, Line 152: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/23ca7e40_12bb8e0a PS23, Line 153: if (node.size() != 2) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/1a6e46e6_40701901 PS23, Line 153: if (node.size() != 2) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/8d21249c_db0442e6 PS23, Line 153: if (node.size() != 2) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/ddf08366_f33812d5 PS23, Line 154: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/67bcf07b_2228fb5f PS23, Line 154: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/887e91aa_be7ecfd8 PS23, Line 156: rhs.first = node[0].as<T>(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/4eab75ab_2d65aaac PS23, Line 156: rhs.first = node[0].as<T>(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/42f37e4f_08c7de1d PS23, Line 156: rhs.first = node[0].as<T>(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/bafa0f2f_400897cc PS23, Line 156: rhs.first = node[0].as<T>(); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/683ae327_f6354c37 PS23, Line 157: rhs.second = node[1].as(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/e3c9c8cc_66a957d2 PS23, Line 157: rhs.second = node[1].as(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/107cd6f0_4c27bc1a PS23, Line 157: rhs.second = node[1].as(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/68125909_099e4e43 PS23, Line 157: rhs.second = node[1].as(); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/f5078650_c22b9176 PS23, Line 158: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/54e196a6_a226bcbd PS23, Line 158: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/55be1a27_df846e04 PS23, Line 159: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/464601a2_358651e5 PS23, Line 163: template<> spaces required around that '<' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/ac9f37fe_9bc420de PS23, Line 163: template<> spaces required around that '>' (ctx:OxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/12de4e9f_7edfdfd6 PS23, Line 164: struct convert<QStringList> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/4d355eb3_822020fc PS23, Line 164: struct convert<QStringList> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/5c8e0898_73c8aaf1 PS23, Line 166: static Node encode(const QStringList& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/dd412be4_5e8133c2 PS23, Line 166: static Node encode(const QStringList& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/20750c4f_81314a95 PS23, Line 166: static Node encode(const QStringList& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/2d818c5f_187b8316 PS23, Line 167: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/8f630f69_65a5f2f6 PS23, Line 168: Node node(NodeType::Sequence); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/1cfc3291_67a532ad PS23, Line 168: Node node(NodeType::Sequence); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/16ce603a_53de7d87 PS23, Line 169: for (const auto &value: rhs) { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/34efd289_d07f7394 PS23, Line 169: for (const auto &value: rhs) { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/e5560727_28a464ed PS23, Line 169: for (const auto &value: rhs) { suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/ed0419ae_e2073aa1 PS23, Line 169: for (const auto &value: rhs) { need consistent spacing around '&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/275894f6_b8b9439e PS23, Line 169: for (const auto &value: rhs) { spaces required around that ':' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/09a000a3_133a3eb0 PS23, Line 169: for (const auto &value: rhs) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/0945cd39_e68f528b PS23, Line 170: node.push_back(value); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/f152a5a0_9a149c82 PS23, Line 170: node.push_back(value); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/7b303a88_23c363f0 PS23, Line 171: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/c75618e2_96e0ceb1 PS23, Line 171: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/841f821b_3eaa9e42 PS23, Line 172: return node; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/98005c9c_71ab77c2 PS23, Line 172: return node; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/5589cced_7d355bcd PS23, Line 173: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/d333c816_1a1a7497 PS23, Line 175: static bool decode(const Node& node, QStringList& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/30ef5451_e57b1609 PS23, Line 175: static bool decode(const Node& node, QStringList& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/96f9b19a_9452c7c5 PS23, Line 175: static bool decode(const Node& node, QStringList& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/82482ed9_9be86ce9 PS23, Line 175: static bool decode(const Node& node, QStringList& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/f4e60f7e_e5489aa7 PS23, Line 176: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/5fee72ce_9f17173f PS23, Line 177: if (!node.IsSequence()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/e9670b37_abb8c656 PS23, Line 177: if (!node.IsSequence()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/c905d681_f7e1f9ab PS23, Line 177: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/a46b9d94_d3a9a093 PS23, Line 178: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/754e8e41_9d07c683 PS23, Line 178: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/4772a886_e85a678e PS23, Line 180: rhs.clear(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/71244850_25060385 PS23, Line 180: rhs.clear(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/cc499a35_ba794641 PS23, Line 181: const_iterator it = node.begin(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/9f4f516a_caf2a0a6 PS23, Line 181: const_iterator it = node.begin(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/8da433cf_aaeab9f3 PS23, Line 182: while (it != node.end()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/ce726a8e_f69db7f8 PS23, Line 182: while (it != node.end()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/6279d112_636917b6 PS23, Line 182: while (it != node.end()) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/363e745d_674ded79 PS23, Line 182: while (it != node.end()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/76e82627_12338568 PS23, Line 183: { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/d22c9f4c_67a7000d PS23, Line 183: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/f5796f33_e3bd7664 PS23, Line 184: rhs.push_back(it->as<QString>()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/427fd8d4_70dbe021 PS23, Line 184: rhs.push_back(it->as<QString>()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/2ee882d9_7dedbf12 PS23, Line 184: rhs.push_back(it->as<QString>()); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/993a7912_90d6c141 PS23, Line 184: rhs.push_back(it->as<QString>()); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/3c1ec47c_1b26e152 PS23, Line 185: ++it; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/00664a86_ad8fb019 PS23, Line 185: ++it; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/3c504a1a_e958f152 PS23, Line 186: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/3790a7e1_8096328e PS23, Line 186: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/69e50b2f_9fbec05e PS23, Line 187: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/a50fb95b_8f16c4a0 PS23, Line 187: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/fdc1110e_d8ead411 PS23, Line 188: } please, no spaces at the start of a line File util/coreboot-configurator/src/application/toggleswitch.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/77ab51d9_43c6fc21 PS23, Line 16: public: spaces required around that ':' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/a37c0fe5_8371abdc PS23, Line 17: explicit ToggleSwitch(QWidget* parent = nullptr); need consistent spacing around '*' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/01cafe63_e4f40cc6 PS23, Line 25: void recolorToggleOn(const QPalette& palette); need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/2c1a4375_c51f53f2 PS23, Line 30: void paintEvent(QPaintEvent *event) override; need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/458efdf3_9270d931 PS23, Line 34: bool hitButton(const QPoint &pos) const override need consistent spacing around '&' (ctx:WxV) -- To view, visit https://review.coreboot.org/c/coreboot/+/58854 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie654f6aca57a792be0c295afc081a95ed4d875d1 Gerrit-Change-Number: 58854 Gerrit-PatchSet: 23 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com> Gerrit-Comment-Date: Thu, 04 Nov 2021 22:49:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [WIP] util: Add coreboot Configurator
by Sean Rhodes (Code Review) 04 Nov '21

04 Nov '21

Attention is currently required from: Martin Roth, Matt DeVillier, Tim Wawrzynczak, Angel Pons. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58854 ) Change subject: [WIP] util: Add coreboot Configurator ...................................................................... Patch Set 25: (1 comment) File util/coreboot-configurator/src/application/coreboot_configurator.h: https://review.coreboot.org/c/coreboot/+/58854/comment/204bc274_56c76123 PS11, Line 69: void closeEvent(QCloseEvent * ev); > > "foo * bar" should be "foo *bar" […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/58854 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie654f6aca57a792be0c295afc081a95ed4d875d1 Gerrit-Change-Number: 58854 Gerrit-PatchSet: 25 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com> Gerrit-Comment-Date: Thu, 04 Nov 2021 22:42:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sean Rhodes <admin(a)starlabs.systems> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2021