coreboot-gerrit November 2021

coreboot-gerrit@coreboot.org

1 participants
6394 discussions

Change in coreboot[master]: src/cpu,soc/amd/common/block/cpu: Add preload_microcode
by Raul Rangel (Code Review) 04 Nov '21

04 Nov '21

Raul Rangel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/58963 ) Change subject: src/cpu,soc/amd/common/block/cpu: Add preload_microcode ...................................................................... src/cpu,soc/amd/common/block/cpu: Add preload_microcode This will enable preloading the microcode. BUG=b:179699789 TEST=Boot guybrush with CL chain and see microcode preloading Signed-off-by: Raul E Rangel <rrangel(a)chromium.org> Change-Id: If0c634c692c97769e71acd1175fc464dc592c356 --- M src/cpu/Makefile.inc M src/include/cpu/amd/microcode.h M src/soc/amd/common/block/cpu/update_microcode.c 3 files changed, 20 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/58963/1 diff --git a/src/cpu/Makefile.inc b/src/cpu/Makefile.inc index ec2f19f..9f1e6c4 100644 --- a/src/cpu/Makefile.inc +++ b/src/cpu/Makefile.inc @@ -56,7 +56,12 @@ cpu_microcode_blob.bin-file ?= $(obj)/cpu_microcode_blob.bin cpu_microcode_blob.bin-type := microcode +# The AMD LPC SPI DMA controller requires source files to be 64 byte aligned. +ifeq ($(CONFIG_SOC_AMD_COMMON_BLOCK_LPC_SPI_DMA),y) +cpu_microcode_blob.bin-align := 64 +else cpu_microcode_blob.bin-align := 16 +endif ifneq ($(CONFIG_CPU_MICROCODE_CBFS_LOC),) cpu_microcode_blob.bin-COREBOOT-position := $(CONFIG_CPU_MICROCODE_CBFS_LOC) diff --git a/src/include/cpu/amd/microcode.h b/src/include/cpu/amd/microcode.h index 800661b..7407594 100644 --- a/src/include/cpu/amd/microcode.h +++ b/src/include/cpu/amd/microcode.h @@ -2,5 +2,6 @@ #define CPU_AMD_MICROCODE_H void amd_update_microcode_from_cbfs(void); +void preload_microcode(void); #endif /* CPU_AMD_MICROCODE_H */ diff --git a/src/soc/amd/common/block/cpu/update_microcode.c b/src/soc/amd/common/block/cpu/update_microcode.c index e6a57f5..9a89c55 100644 --- a/src/soc/amd/common/block/cpu/update_microcode.c +++ b/src/soc/amd/common/block/cpu/update_microcode.c @@ -10,6 +10,8 @@ #include <cbfs.h> #include <timestamp.h> +#define CPU_MICROCODE_BLOB_NAME "cpu_microcode_blob.bin" + _Static_assert(CONFIG_SOC_AMD_COMMON_BLOCK_UCODE_SIZE > 0, "SOC_AMD_COMMON_BLOCK_UCODE_SIZE is not set"); @@ -97,9 +99,10 @@ /* Cache the buffer so each CPU doesn't need to read the uCode from flash */ if (!cache_valid) { timestamp_add_now(TS_READ_UCODE_START); - ucode_list = cbfs_map("cpu_microcode_blob.bin", &ucode_len); + ucode_list = cbfs_map(CPU_MICROCODE_BLOB_NAME, &ucode_len); if (!ucode_list) { - printk(BIOS_WARNING, "cpu_microcode_blob.bin not found. Skipping updates.\n"); + printk(BIOS_WARNING, + CPU_MICROCODE_BLOB_NAME " not found. Skipping updates.\n"); return; } @@ -120,3 +123,12 @@ apply_microcode_patch(&ucode_cache); } + +void preload_microcode(void) +{ + if (!CONFIG(CBFS_PRELOAD)) + return; + + printk(BIOS_DEBUG, "Preloading microcode\n"); + cbfs_preload(CPU_MICROCODE_BLOB_NAME); +} -- To view, visit https://review.coreboot.org/c/coreboot/+/58963 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If0c634c692c97769e71acd1175fc464dc592c356 Gerrit-Change-Number: 58963 Gerrit-PatchSet: 1 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/amd/common/block/lpc/spi_dma: Add ability to verify SPI DMA hardware
by Raul Rangel (Code Review) 04 Nov '21

04 Nov '21

Attention is currently required from: Jason Glenesk, Marshall Dawson, Felix Held. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56322 ) Change subject: soc/amd/common/block/lpc/spi_dma: Add ability to verify SPI DMA hardware ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/56322 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2dd54cab86ad31b135a93d4667df346c60357337 Gerrit-Change-Number: 56322 Gerrit-PatchSet: 6 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 04 Nov 2021 22:33:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/cezanne: Add ASYNC_FILE_LOADING
by Raul Rangel (Code Review) 04 Nov '21

04 Nov '21

Attention is currently required from: Jason Glenesk, Marshall Dawson, Julius Werner, Rob Barnes, Karthik Ramasubramanian, Felix Held. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58861 ) Change subject: soc/amd/cezanne: Add ASYNC_FILE_LOADING ...................................................................... Patch Set 4: (1 comment) Patchset: PS3: > hmm, i see what the intention behind this one is, but i still find it rather odd I reworked it to add a new Kconfig. -- To view, visit https://review.coreboot.org/c/coreboot/+/58861 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie839e54fa38b81a5d18715f190c0c92467bd9371 Gerrit-Change-Number: 58861 Gerrit-PatchSet: 4 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Rob Barnes <robbarnes(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 04 Nov 2021 22:32:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: lib/prog_loaders, soc/amd/: Make payload_preload use cbfs_preload
by Raul Rangel (Code Review) 04 Nov '21

04 Nov '21

Attention is currently required from: Jason Glenesk, Marshall Dawson, Felix Held. Raul Rangel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/58962 ) Change subject: lib/prog_loaders, soc/amd/: Make payload_preload use cbfs_preload ...................................................................... lib/prog_loaders, soc/amd/: Make payload_preload use cbfs_preload Now that CBFS has this functionality built in, we no longer need to manually code it. payload_preload used to use the payload_preload_cache region to store the raw payload contents. This region was placed outside the firmware reserved region, so it was available for use by the OS. This was possible because the payload isn't loaded again on S3 resume. cbfs_preload only uses the cbfs_cache region. This region must be reserved because it gets used on the S3 resume path. Unfortunately this means that cbfs_cache must be increased to hold the payload. Cezanne is the only platform currently using payload_preload, and the size of cbfs_cache has already been adjusted. In the future we could look into adding an option to cbfs_preload that would allow it to use a different memory pool for the cache allocation. BUG=b:179699789 TEST=Boot guybrush and verify preloading the payload was successful CBFS DEBUG: get_preload_rdev(name='fallback/payload') preload successful Signed-off-by: Raul E Rangel <rrangel(a)chromium.org> Change-Id: Idc521b238620ff52b8ba481cd3c10e5c4f1394bd --- M src/include/symbols.h M src/lib/Kconfig M src/lib/prog_loaders.c M src/soc/amd/cezanne/Kconfig M src/soc/amd/common/block/cpu/Kconfig M src/soc/amd/common/block/cpu/noncar/memlayout_x86.ld 6 files changed, 9 insertions(+), 77 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/58962/1 diff --git a/src/include/symbols.h b/src/include/symbols.h index 52624d4..3e4694b 100644 --- a/src/include/symbols.h +++ b/src/include/symbols.h @@ -52,7 +52,6 @@ /* Regions for execution units. */ -DECLARE_REGION(payload_preload_cache) DECLARE_REGION(payload) /* "program" always refers to the current execution unit. */ DECLARE_REGION(program) diff --git a/src/lib/Kconfig b/src/lib/Kconfig index 41df1f1..d85d249 100644 --- a/src/lib/Kconfig +++ b/src/lib/Kconfig @@ -114,14 +114,3 @@ in the background before they are actually required. This feature depends on the read-only boot_device having a DMA controller to perform the background transfer. - -config PAYLOAD_PRELOAD - bool - depends on COOP_MULTITASKING - help - On some systems with SPI DMA controllers, it is possible to preload - the payload while ramstage is executing. This can be selected by the - SoC to enable payload preloading. - - The SoC needs to define a payload_preload_cache region where the - raw payload can be placed. diff --git a/src/lib/prog_loaders.c b/src/lib/prog_loaders.c index 1a361ea..8ad646a 100644 --- a/src/lib/prog_loaders.c +++ b/src/lib/prog_loaders.c @@ -127,71 +127,37 @@ static struct prog global_payload = PROG_INIT(PROG_PAYLOAD, CONFIG_CBFS_PREFIX "/payload"); -static struct thread_handle payload_preload_handle; - -static enum cb_err payload_preload_thread_entry(void *arg) -{ - size_t size; - struct prog *payload = &global_payload; - - printk(BIOS_DEBUG, "Preloading payload\n"); - - payload->cbfs_type = CBFS_TYPE_QUERY; - - size = cbfs_type_load(prog_name(payload), _payload_preload_cache, - REGION_SIZE(payload_preload_cache), &payload->cbfs_type); - - if (!size) { - printk(BIOS_ERR, "ERROR: Preloading payload failed\n"); - return CB_ERR; - } - - printk(BIOS_DEBUG, "Preloading payload complete\n"); - - return CB_SUCCESS; -} - void payload_preload(void) { - struct thread_handle *handle = &payload_preload_handle; - - if (!CONFIG(PAYLOAD_PRELOAD)) + if (!CONFIG(CBFS_PRELOAD)) return; - if (thread_run(handle, payload_preload_thread_entry, NULL)) - printk(BIOS_ERR, "ERROR: Failed to start payload preload thread\n"); + cbfs_preload(global_payload.name); } void payload_load(void) { struct prog *payload = &global_payload; - struct thread_handle *handle = &payload_preload_handle; - void *mapping = NULL; - void *buffer; + void *mapping; timestamp_add_now(TS_LOAD_PAYLOAD); if (prog_locate_hook(payload)) goto out; - if (CONFIG(PAYLOAD_PRELOAD) && thread_join(handle) == CB_SUCCESS) { - buffer = _payload_preload_cache; - } else { - payload->cbfs_type = CBFS_TYPE_QUERY; - mapping = cbfs_type_map(prog_name(payload), NULL, &payload->cbfs_type); - buffer = mapping; - } + payload->cbfs_type = CBFS_TYPE_QUERY; + mapping = cbfs_type_map(prog_name(payload), NULL, &payload->cbfs_type); - if (!buffer) + if (!mapping) goto out; switch (prog_cbfs_type(payload)) { case CBFS_TYPE_SELF: /* Simple ELF */ - selfload_mapped(payload, buffer, BM_MEM_RAM); + selfload_mapped(payload, mapping, BM_MEM_RAM); break; case CBFS_TYPE_FIT: /* Flattened image tree */ if (CONFIG(PAYLOAD_FIT_SUPPORT)) { - fit_payload(payload, buffer); + fit_payload(payload, mapping); break; } /* else fall-through */ default: @@ -200,8 +166,7 @@ break; } - if (mapping) - cbfs_unmap(mapping); + cbfs_unmap(mapping); out: if (prog_entry(payload) == NULL) die_with_post_code(POST_INVALID_ROM, "Payload not loaded.\n"); diff --git a/src/soc/amd/cezanne/Kconfig b/src/soc/amd/cezanne/Kconfig index dbafa8c..c3e688e 100644 --- a/src/soc/amd/cezanne/Kconfig +++ b/src/soc/amd/cezanne/Kconfig @@ -196,7 +196,6 @@ select COOP_MULTITASKING select SOC_AMD_COMMON_BLOCK_LPC_SPI_DMA select CBFS_PRELOAD - select PAYLOAD_PRELOAD help When enabled, the platform will use the LPC SPI DMA controller to asynchronously load contents from the SPI ROM. This will improve diff --git a/src/soc/amd/common/block/cpu/Kconfig b/src/soc/amd/common/block/cpu/Kconfig index 3dd1e33..7f50965 100644 --- a/src/soc/amd/common/block/cpu/Kconfig +++ b/src/soc/amd/common/block/cpu/Kconfig @@ -29,16 +29,6 @@ help The size of the cbfs_cache region. -config PAYLOAD_PRELOAD_CACHE_SIZE - hex - default 0x30000 - depends on PAYLOAD_PRELOAD - help - This config sets the size of the payload_preload_cache memory region. - It is used as the destination for the raw payload. This space is only - populated during non-S3, so it doesn't need to be reserved in the - EARLY_RESERVED_DRAM region. - endif # SOC_AMD_COMMON_BLOCK_NONCAR config SOC_AMD_COMMON_BLOCK_MCA_COMMON diff --git a/src/soc/amd/common/block/cpu/noncar/memlayout_x86.ld b/src/soc/amd/common/block/cpu/noncar/memlayout_x86.ld index a542b7d..e42174f 100644 --- a/src/soc/amd/common/block/cpu/noncar/memlayout_x86.ld +++ b/src/soc/amd/common/block/cpu/noncar/memlayout_x86.ld @@ -106,16 +106,6 @@ EARLY_RESERVED_DRAM_END(.) -#if CONFIG(PAYLOAD_PRELOAD) - /* - * This section is outside the early_reserved_dram section. We only read - * the payload on non-S3 boots, so we don't need to reserve it from the - * OS. The 64 byte alignment is required by the SPI DMA controller. - */ - . = ALIGN(ARCH_CACHELINE_ALIGN_SIZE); - REGION(payload_preload_cache, ., CONFIG_PAYLOAD_PRELOAD_CACHE_SIZE, ARCH_CACHELINE_ALIGN_SIZE) -#endif - RAMSTAGE(CONFIG_RAMBASE, 8M) } -- To view, visit https://review.coreboot.org/c/coreboot/+/58962 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idc521b238620ff52b8ba481cd3c10e5c4f1394bd Gerrit-Change-Number: 58962 Gerrit-PatchSet: 1 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/amd/cezanne: Enable CBFS_PRELOAD
by Raul Rangel (Code Review) 04 Nov '21

04 Nov '21

1 0

Change in coreboot[master]: soc/amd/cezanne: Add ASYNC_FILE_LOADING
by Raul Rangel (Code Review) 04 Nov '21

04 Nov '21

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Julius Werner, Karthik Ramasubramanian. Hello build bot (Jenkins), Jason Glenesk, Marshall Dawson, Julius Werner, Karthik Ramasubramanian, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/58861 to look at the new patch set (#4). Change subject: soc/amd/cezanne: Add ASYNC_FILE_LOADING ...................................................................... soc/amd/cezanne: Add ASYNC_FILE_LOADING This gives us a knob that can be controlled via a .config to enable/disable file preloading. I left the option disabled because there is currently a race condition that can cause data corruption when using the SPI DMA controller. The fix will actually introduce a boot time regression because the preloads are happening at the same time as the elog init. I want to keep preloading disabled for now until I get all the sequencing worked out. BUG=b:179699789 TEST=Boot guybrush and verify no preloading happens. Signed-off-by: Raul E Rangel <rrangel(a)chromium.org> Change-Id: Ie839e54fa38b81a5d18715f190c0c92467bd9371 --- M src/soc/amd/cezanne/Kconfig 1 file changed, 11 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/58861/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/58861 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie839e54fa38b81a5d18715f190c0c92467bd9371 Gerrit-Change-Number: 58861 Gerrit-PatchSet: 4 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: lib/thread: Start stopwatch after printk
by Raul Rangel (Code Review) 04 Nov '21

04 Nov '21

Raul Rangel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/58960 ) Change subject: lib/thread: Start stopwatch after printk ...................................................................... lib/thread: Start stopwatch after printk We are currently counting how long it takes to print the waiting message, in addition to the actual time we spent waiting. This results in inflating the measurement by 1.7ms when the serial console is enabled. This CL makes it so the print happens before the stopwatch starts. BUG=b:179699789 TEST=No longer see printk time taken into account on serial console Signed-off-by: Raul E Rangel <rrangel(a)chromium.org> Change-Id: Ib48e37c1b2cb462d634141bf767673936aa2dd26 --- M src/lib/thread.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/58960/1 diff --git a/src/lib/thread.c b/src/lib/thread.c index 7d5cdc5..0393ca7 100644 --- a/src/lib/thread.c +++ b/src/lib/thread.c @@ -398,10 +398,10 @@ if (handle->state == THREAD_UNINITIALIZED) return CB_ERR_ARG; - stopwatch_init(&sw); - printk(BIOS_SPEW, "waiting for thread\n"); + stopwatch_init(&sw); + while (handle->state != THREAD_DONE) assert(thread_yield() == 0); -- To view, visit https://review.coreboot.org/c/coreboot/+/58960 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib48e37c1b2cb462d634141bf767673936aa2dd26 Gerrit-Change-Number: 58960 Gerrit-PatchSet: 1 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: [WIP] util: Add coreboot Configurator
by build bot (Jenkins) (Code Review) 04 Nov '21

04 Nov '21

Attention is currently required from: Sean Rhodes, Martin Roth, Tim Wawrzynczak, Angel Pons. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58854 ) Change subject: [WIP] util: Add coreboot Configurator ...................................................................... Patch Set 22: (367 comments) File util/coreboot-configurator/src/application/aboutwindow.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/6cb7c2e2_ee194f56 PS22, Line 16: public: spaces required around that ':' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/5611a62f_9e9e2517 PS22, Line 17: explicit aboutWindow(QWidget *parent = nullptr); need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/d947617e_9feb1a5f PS22, Line 21: Ui::aboutWindow *ui; need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/9394f53e_73916696 PS22, Line 21: Ui::aboutWindow *ui; labels should not be indented File util/coreboot-configurator/src/application/configuration.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/de3f19d0_31f29963 PS22, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/d852b675_d80f0b41 PS22, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/4f5ceb37_9d23761d PS22, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/9731a0f9_793c1b4e PS22, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/c8335534_c489b009 PS22, Line 15: QMap<QString,QString> fromNvramTool(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/cec81005_31b5965f PS22, Line 15: QMap<QString,QString> fromNvramTool(); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/bf77d3b5_8b26a909 PS22, Line 15: QMap<QString,QString> fromNvramTool(); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/24a276fc_a1456261 PS22, Line 17: QMap<QString,QString> mocked(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/ae6088ac_bdcfc1e2 PS22, Line 17: QMap<QString,QString> mocked(); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/6e11891b_b5de7aae PS22, Line 17: QMap<QString,QString> mocked(); spaces required around that '>' (ctx:VxW) File util/coreboot-configurator/src/application/coreboot_configurator.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/9e39f74b_b051e015 PS22, Line 29: public: spaces required around that ':' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/c4c246f3_24056c0f PS22, Line 30: coreboot_configurator(QWidget *parent = nullptr); need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/e09f3185_9ec1dec6 PS22, Line 37: void showEvent(QShowEvent *ev); need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/7bf13b4f_b8affbdb PS22, Line 48: void displaySettings(); Bad function definition - void displaySettings() should probably be void displaySettings(void) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/1f55b15e_d3eb0bdd PS22, Line 52: void writeToFile(const QString& out_file); need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/303dea43_68bf80b6 PS22, Line 55: void updateValue(const QString& name); need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/1ded75e3_bc42b4a7 PS22, Line 61: QMap<QString, QString> m_values; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/e0649b30_dc1f275a PS22, Line 61: QMap<QString, QString> m_values; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/79c051ab_1ea9e405 PS22, Line 64: QMap<QString, QVBoxLayout*> m_tabs; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/46a88621_657b2935 PS22, Line 64: QMap<QString, QVBoxLayout*> m_tabs; spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/a740a508_eb8eb017 PS22, Line 67: YAML::Node m_categories; labels should not be indented Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/7d119a33_a1c720e0 PS22, Line 70: QComboBox *textToDisplay(const QString &in_string); need consistent spacing around '&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/16161fa0_73e61c58 PS22, Line 71: QCheckBox *checkToDisplay(const QString &in_string); need consistent spacing around '&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/8306e8a4_da5f3151 PS22, Line 73: Ui::coreboot_configurator *ui; need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/7a6d567c_05e48501 PS22, Line 73: Ui::coreboot_configurator *ui; labels should not be indented File util/coreboot-configurator/src/application/coreboot_configurator.cpp: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/58282180_b43b429b PS22, Line 207: trailing whitespace File util/coreboot-configurator/src/application/qtyaml.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/aa86d9b0_5aaf8d59 PS22, Line 30: template<> spaces required around that '<' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/25bc01db_3ff3495d PS22, Line 30: template<> spaces required around that '>' (ctx:OxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/50c5e6e1_cc91e198 PS22, Line 31: struct convert<QString> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/52b219e5_19f27ca5 PS22, Line 31: struct convert<QString> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/8ebeb172_a2894d43 PS22, Line 33: static Node encode(const QString& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/d3c817f8_ba94e80e PS22, Line 33: static Node encode(const QString& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/8877ef57_d1ab5691 PS22, Line 33: static Node encode(const QString& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/24da814e_966fb559 PS22, Line 34: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/a7e86ab3_6e19f7b4 PS22, Line 35: return Node(rhs.toStdString()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/27c07210_e9c0f41a PS22, Line 35: return Node(rhs.toStdString()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/389e5764_c46e5aeb PS22, Line 36: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/f97855d0_d2e88317 PS22, Line 38: static bool decode(const Node& node, QString& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/8843c807_e341e567 PS22, Line 38: static bool decode(const Node& node, QString& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/2552eae8_48b85f46 PS22, Line 38: static bool decode(const Node& node, QString& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/c1f764a1_83b79a96 PS22, Line 38: static bool decode(const Node& node, QString& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/fb894e71_1f0ddf11 PS22, Line 39: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/b529ae68_7cade90a PS22, Line 40: if (!node.IsScalar()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/3acb3362_52310ba2 PS22, Line 40: if (!node.IsScalar()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/2567c63e_13c78679 PS22, Line 40: if (!node.IsScalar()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/4ed6e357_b8092092 PS22, Line 41: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/f25000fa_f44a316b PS22, Line 41: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/45988adb_1510902b PS22, Line 42: rhs = QString::fromStdString(node.Scalar()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/cfdbc244_7c897669 PS22, Line 42: rhs = QString::fromStdString(node.Scalar()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/07b10fc5_e520a94c PS22, Line 43: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/6c5644ef_c7bc16fe PS22, Line 43: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/c6c7db95_a4be6b01 PS22, Line 44: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/0a92d46c_bf5a9b63 PS22, Line 48: template<typename Key, typename Value> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/62f265c8_2315f88b PS22, Line 48: template<typename Key, typename Value> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/038d8201_b792db13 PS22, Line 49: struct convert<QMap<Key, Value> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/9a16de5f_ce22f410 PS22, Line 49: struct convert<QMap<Key, Value> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/8b50507c_11b675a6 PS22, Line 49: struct convert<QMap<Key, Value> > spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/9f717bf0_245415d7 PS22, Line 51: static Node encode(const QMap<Key,Value>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/0ef02010_f2c1249e PS22, Line 51: static Node encode(const QMap<Key,Value>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/a2799a39_a4d3f9bf PS22, Line 51: static Node encode(const QMap<Key,Value>& rhs) space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/c77a9c10_b3922fd2 PS22, Line 51: static Node encode(const QMap<Key,Value>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/3199fc3d_bf5c0eb3 PS22, Line 51: static Node encode(const QMap<Key,Value>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/695e57d4_0b426394 PS22, Line 51: static Node encode(const QMap<Key,Value>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/847a98f0_8f3f86ad PS22, Line 51: static Node encode(const QMap<Key,Value>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/99a29a6c_d1f3a961 PS22, Line 52: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/23a3c36e_d28a9893 PS22, Line 53: Node node(NodeType::Map); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/00dfd9b3_283e6404 PS22, Line 53: Node node(NodeType::Map); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/66892804_05c57cee PS22, Line 54: auto it = rhs.constBegin(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/9e9e85fd_8c421676 PS22, Line 54: auto it = rhs.constBegin(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/8302474e_1445da46 PS22, Line 55: while (it != rhs.constEnd()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/3f7db1c9_db3a7fb9 PS22, Line 55: while (it != rhs.constEnd()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/baac9fe9_67daddb3 PS22, Line 55: while (it != rhs.constEnd()) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/244b5a71_383670af PS22, Line 55: while (it != rhs.constEnd()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/1de37a8c_c36fba01 PS22, Line 56: { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/2573e23b_98b920fe PS22, Line 56: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/7733a1bf_3d27e37a PS22, Line 57: node.force_insert(it.key(), it.value()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/7f4e92ee_f2ef62c6 PS22, Line 57: node.force_insert(it.key(), it.value()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/7891cd40_ed23c0dd PS22, Line 58: ++it; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/d826f03c_4626d420 PS22, Line 58: ++it; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/90fe7b7a_49d6033e PS22, Line 59: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/0cefa410_878a3566 PS22, Line 59: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/4c7df651_a0a4d5be PS22, Line 60: return node; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/3c49448f_4c11122e PS22, Line 60: return node; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/80ad7aad_2fcf7de0 PS22, Line 61: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/f0cc5e3a_f4dd443f PS22, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/c70404dc_9e5a6370 PS22, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/8117f574_711c8612 PS22, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/12b7e0d1_1b09f060 PS22, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/90171235_e8eeb0e6 PS22, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/867a39a7_c681336b PS22, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/715996cc_d0b180db PS22, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/45f681f7_b58416f6 PS22, Line 64: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/343d849c_d2dc52de PS22, Line 65: if (!node.IsMap()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/9aa92368_5259ca80 PS22, Line 65: if (!node.IsMap()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/e27b2f9d_78934c90 PS22, Line 65: if (!node.IsMap()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/31391bf8_5bbcfa23 PS22, Line 66: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/2e6fd692_93bc22f8 PS22, Line 66: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/267229b7_7d61ea4d PS22, Line 68: rhs.clear(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/96b47869_bfd45800 PS22, Line 68: rhs.clear(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/898caec6_ab6f95b7 PS22, Line 69: const_iterator it = node.begin(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/abb7d935_d3319018 PS22, Line 69: const_iterator it = node.begin(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/d435783b_ce0bfbef PS22, Line 70: while (it != node.end()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/7fd5e392_4b37f663 PS22, Line 70: while (it != node.end()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/809a778e_5de33b43 PS22, Line 70: while (it != node.end()) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/ca00dd96_820ab3f9 PS22, Line 70: while (it != node.end()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/76cac3bd_d08ac5d5 PS22, Line 71: { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/40ac0ed4_3f1a68be PS22, Line 71: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/7ef15ddc_4fe2eb58 PS22, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/16fa9693_37bb8817 PS22, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/c6db919f_337fb576 PS22, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/400ba16c_0f8bdda4 PS22, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/2e94e06c_d9a3d167 PS22, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/123c7ebc_635958b7 PS22, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/017d63bd_9d4f32d3 PS22, Line 73: ++it; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/710d566e_f00fc60b PS22, Line 73: ++it; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/7ce2c140_dec8a0d1 PS22, Line 74: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/d1c688aa_23184f7e PS22, Line 74: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/8746c982_b6534832 PS22, Line 75: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/30a2c8c2_9cd55bfc PS22, Line 75: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/b62b0a77_17500e85 PS22, Line 76: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/a9c4e6bc_f1dd8781 PS22, Line 80: template<typename T> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/de5ef2b6_584d5d65 PS22, Line 80: template<typename T> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/406e7d0a_3a272bb3 PS22, Line 81: struct convert<QVector<T> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/0b84d1c3_5dfbc0ba PS22, Line 81: struct convert<QVector<T> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/f05fd461_ee73b21d PS22, Line 81: struct convert<QVector<T> > spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/565ce981_7dd688a5 PS22, Line 83: static Node encode(const QVector<T>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/90369c36_3d0912a8 PS22, Line 83: static Node encode(const QVector<T>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/ff62cba3_0dcc7649 PS22, Line 83: static Node encode(const QVector<T>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/38f352e3_ca3597f3 PS22, Line 83: static Node encode(const QVector<T>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/2716183a_9543125e PS22, Line 83: static Node encode(const QVector<T>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/7d489106_1987f0f0 PS22, Line 83: static Node encode(const QVector<T>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/f8797f18_6adaa4e8 PS22, Line 84: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/109fd79c_b5970ed4 PS22, Line 85: Node node(NodeType::Sequence); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/f894d029_26ef7b59 PS22, Line 85: Node node(NodeType::Sequence); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/a52a6be5_f111dbe0 PS22, Line 86: foreach (T value, rhs) { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/c8796b67_122a63fd PS22, Line 86: foreach (T value, rhs) { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/22a9a492_05603701 PS22, Line 86: foreach (T value, rhs) { space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/89235751_bfd445c9 PS22, Line 87: node.push_back(value); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/8e3e5eb9_cc58cd45 PS22, Line 87: node.push_back(value); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/d184328a_fc0f4161 PS22, Line 88: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/aed6364c_905366d8 PS22, Line 88: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/caa46ed5_dfa855ed PS22, Line 89: return node; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/1f135312_82473cee PS22, Line 89: return node; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/20efc940_842e2977 PS22, Line 90: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/50f591b3_73958343 PS22, Line 92: static bool decode(const Node& node, QVector<T>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/82bd6125_79789276 PS22, Line 92: static bool decode(const Node& node, QVector<T>& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/60a5f0c7_943b0d46 PS22, Line 92: static bool decode(const Node& node, QVector<T>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/731e9616_555fe30d PS22, Line 92: static bool decode(const Node& node, QVector<T>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/64ba1cdc_e09f3550 PS22, Line 92: static bool decode(const Node& node, QVector<T>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/5cde61f8_67d375be PS22, Line 92: static bool decode(const Node& node, QVector<T>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/624ad5c4_0667ad5a PS22, Line 92: static bool decode(const Node& node, QVector<T>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/a10b9735_f4b98cad PS22, Line 93: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/67023810_9d5bd812 PS22, Line 94: if (!node.IsSequence()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/fe896e52_2fa44831 PS22, Line 94: if (!node.IsSequence()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/fc0273df_afcd9d2a PS22, Line 94: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/a296526a_fec9be2b PS22, Line 95: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/a6c34c43_107c6522 PS22, Line 95: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/67f9ec56_0a668f66 PS22, Line 97: rhs.clear(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/1e94025e_58c3abcd PS22, Line 97: rhs.clear(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/61c8b0d4_56d2b72c PS22, Line 98: const_iterator it = node.begin(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/377836af_8468a375 PS22, Line 98: const_iterator it = node.begin(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/a7598e27_32613a28 PS22, Line 99: while (it != node.end()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/1b5429c3_9b946380 PS22, Line 99: while (it != node.end()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/3accc7c0_dc616e44 PS22, Line 99: while (it != node.end()) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/d2f4cbb1_d1e4e29d PS22, Line 99: while (it != node.end()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/4ad36c86_0d6c6835 PS22, Line 100: { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/ee60b83e_95130d10 PS22, Line 100: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/006a8f82_22b86344 PS22, Line 101: rhs.push_back(it->as<T>()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/fca4c753_b4da7ae6 PS22, Line 101: rhs.push_back(it->as<T>()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/30709847_b7f14fe3 PS22, Line 101: rhs.push_back(it->as<T>()); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/51c8352a_157cf027 PS22, Line 101: rhs.push_back(it->as<T>()); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/ee360b7c_17d89b0e PS22, Line 102: ++it; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/6ce066ff_17178bb5 PS22, Line 102: ++it; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/f495bba7_9a4eb0e5 PS22, Line 103: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/d5f29e32_368f9a7a PS22, Line 103: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/4f6abd6e_430a0043 PS22, Line 104: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/530d4763_d0185237 PS22, Line 104: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/6a46e8b5_eacf9b70 PS22, Line 105: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/13a85f6f_7492043e PS22, Line 109: template<typename T> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/734a6681_26c7bff4 PS22, Line 109: template<typename T> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/d39efa85_5c93d78f PS22, Line 110: struct convert<QList<T> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/52be45bc_f77f012e PS22, Line 110: struct convert<QList<T> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/156ae69a_650fc406 PS22, Line 110: struct convert<QList<T> > spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/efecd286_0480acf3 PS22, Line 112: static Node encode(const QList<T>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/f6f22cff_c3be3f63 PS22, Line 112: static Node encode(const QList<T>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/b8b76e80_665783a1 PS22, Line 112: static Node encode(const QList<T>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/0b39ad89_c09531dc PS22, Line 112: static Node encode(const QList<T>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/4865ac0c_79aad257 PS22, Line 112: static Node encode(const QList<T>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/92eeaee9_21a8700b PS22, Line 112: static Node encode(const QList<T>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/3d9588bd_32629e36 PS22, Line 113: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/c8fa87d5_715131f5 PS22, Line 114: Node node(NodeType::Sequence); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/aada2970_aa70d04f PS22, Line 114: Node node(NodeType::Sequence); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/10e75339_7f957fac PS22, Line 115: foreach (T value, rhs) { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/de735d42_1a902abc PS22, Line 115: foreach (T value, rhs) { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/9fc5d675_8a25a3ae PS22, Line 115: foreach (T value, rhs) { space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/bdf6d0d1_92cd520d PS22, Line 116: node.push_back(value); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/5a9e3e9f_a3b76151 PS22, Line 116: node.push_back(value); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/d07a19e6_c01cd426 PS22, Line 117: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/5add8303_e2cd80a0 PS22, Line 117: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/4158e550_ee793ec5 PS22, Line 118: return node; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/47e832ea_0e9f3f85 PS22, Line 118: return node; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/6311733c_3bc974d1 PS22, Line 119: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/d8a2bd4a_34a769de PS22, Line 121: static bool decode(const Node& node, QList<T>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/980fe33a_0fa4f213 PS22, Line 121: static bool decode(const Node& node, QList<T>& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/3c9b665f_ec994d44 PS22, Line 121: static bool decode(const Node& node, QList<T>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/f051c46c_6ee001dc PS22, Line 121: static bool decode(const Node& node, QList<T>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/81ed0db4_37dac4bb PS22, Line 121: static bool decode(const Node& node, QList<T>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/8de60848_d99df82a PS22, Line 121: static bool decode(const Node& node, QList<T>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/af577613_43718e6b PS22, Line 121: static bool decode(const Node& node, QList<T>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/ede1937b_f00f75ef PS22, Line 122: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/e6426034_bb939b3a PS22, Line 123: if (!node.IsSequence()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/aa9aa281_fa3e06cc PS22, Line 123: if (!node.IsSequence()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/e40aca46_7ba32879 PS22, Line 123: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/3d23f9c0_fe6cb23a PS22, Line 124: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/25ac6483_c0251f88 PS22, Line 124: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/10764a59_a8098d85 PS22, Line 126: rhs.clear(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/20076911_f48ca35a PS22, Line 126: rhs.clear(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/41bb33a4_643b8326 PS22, Line 127: const_iterator it = node.begin(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/6af5a4b8_9b2386c8 PS22, Line 127: const_iterator it = node.begin(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/76c8fe8d_6d6ae9d7 PS22, Line 128: while (it != node.end()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/6cfdf1a8_0ab2fed1 PS22, Line 128: while (it != node.end()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/ad25efe6_f5021cbc PS22, Line 128: while (it != node.end()) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/2acb367b_6899b68f PS22, Line 128: while (it != node.end()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/956b4036_cea71822 PS22, Line 129: { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/b9c8cb8b_6e7a0a93 PS22, Line 129: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/06f0ed6e_faf9b764 PS22, Line 130: rhs.push_back(it->as<T>()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/17c817bc_01f5d029 PS22, Line 130: rhs.push_back(it->as<T>()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/ae6eb857_b2cd758e PS22, Line 130: rhs.push_back(it->as<T>()); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/9f58c0ad_8f6eb9f2 PS22, Line 130: rhs.push_back(it->as<T>()); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/76536a83_1c6e6b7a PS22, Line 131: ++it; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/8d5b1b8c_f1cdfff3 PS22, Line 131: ++it; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/9422a393_6224105c PS22, Line 132: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/ffbacbd3_f1511782 PS22, Line 132: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/a309c34e_33d65aac PS22, Line 133: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/83ae6f8b_f0eecc7e PS22, Line 133: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/47242016_158f8000 PS22, Line 134: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/343f25e4_4ef47b80 PS22, Line 138: template<typename T, typename U> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/cbba1c9d_3b67d738 PS22, Line 138: template<typename T, typename U> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/926e56d2_519eefb8 PS22, Line 139: struct convert<QPair<T,U> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/09f8b12b_20615758 PS22, Line 139: struct convert<QPair<T,U> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/eb07d3f9_9e702fc7 PS22, Line 139: struct convert<QPair<T,U> > space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/5908262f_155c24d9 PS22, Line 139: struct convert<QPair<T,U> > spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/2579760e_356f76b3 PS22, Line 141: static Node encode(const QPair<T,U>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/abed3c4f_a7089520 PS22, Line 141: static Node encode(const QPair<T,U>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/b12152b6_6cd77d4c PS22, Line 141: static Node encode(const QPair<T,U>& rhs) space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/d960060f_8fe5706b PS22, Line 141: static Node encode(const QPair<T,U>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/4147cce6_aeb560e3 PS22, Line 141: static Node encode(const QPair<T,U>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/8a577484_e3367c1e PS22, Line 141: static Node encode(const QPair<T,U>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/ab3b0b99_95ab89cb PS22, Line 141: static Node encode(const QPair<T,U>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/425d1816_60f4af63 PS22, Line 142: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/5db34f14_412119e9 PS22, Line 143: Node node(NodeType::Sequence); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/85a613d7_7d89302b PS22, Line 143: Node node(NodeType::Sequence); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/2a18f1df_21c13cdd PS22, Line 144: node.push_back(rhs.first); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/3a646683_2e8fdaa2 PS22, Line 144: node.push_back(rhs.first); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/922e8157_8e74afe5 PS22, Line 145: node.push_back(rhs.second); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/08a8b55a_c3da5866 PS22, Line 145: node.push_back(rhs.second); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/7a98a135_3d4a2ddf PS22, Line 146: return node; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/1525831b_e6c542e6 PS22, Line 146: return node; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/d18d34a6_0ac7c7cc PS22, Line 147: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/9ffc0a00_f6ad48c9 PS22, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/93556f8e_1a71576e PS22, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/717e2773_2201449e PS22, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/a5dc8e47_feea0e6b PS22, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/36b65d7b_7de2e6d1 PS22, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/d68798ae_fe8c27bb PS22, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/57909029_40be56a3 PS22, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/0f006828_75876a8b PS22, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/227f67ba_8ba37a9e PS22, Line 150: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/b276ebfe_232ba24f PS22, Line 151: if (!node.IsSequence()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/3aef7f61_36b54170 PS22, Line 151: if (!node.IsSequence()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/4eb66885_7e914dde PS22, Line 151: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/e89abf05_1e3543e5 PS22, Line 152: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/e6c91cca_71cdf612 PS22, Line 152: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/287f0058_569bc052 PS22, Line 153: if (node.size() != 2) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/5878d837_8a7f5f69 PS22, Line 153: if (node.size() != 2) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/4f6b0d81_c75d5e18 PS22, Line 153: if (node.size() != 2) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/9a637661_fac7b6d8 PS22, Line 154: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/57a4e5f7_bed6abc1 PS22, Line 154: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/8e5d0169_fb77b3ba PS22, Line 156: rhs.first = node[0].as<T>(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/0553b5d1_a2edda5f PS22, Line 156: rhs.first = node[0].as<T>(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/74564100_6c5ba489 PS22, Line 156: rhs.first = node[0].as<T>(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/7ed3ef66_876113b8 PS22, Line 156: rhs.first = node[0].as<T>(); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/18830fd1_2c173f23 PS22, Line 157: rhs.second = node[1].as(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/9b097df7_0600c221 PS22, Line 157: rhs.second = node[1].as(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/f2787934_481a7095 PS22, Line 157: rhs.second = node[1].as(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/57530f72_24c9400b PS22, Line 157: rhs.second = node[1].as(); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/aa05e6c2_c3ae2dd3 PS22, Line 158: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/032efddc_19d59fc5 PS22, Line 158: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/c1f73913_1f84ef42 PS22, Line 159: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/ac98b157_6e8d6430 PS22, Line 163: template<> spaces required around that '<' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/2ced70f7_50cf9652 PS22, Line 163: template<> spaces required around that '>' (ctx:OxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/b6f60b26_bee78d0b PS22, Line 164: struct convert<QStringList> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/39e991f5_ceb37ca7 PS22, Line 164: struct convert<QStringList> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/429e7f5c_97f16825 PS22, Line 166: static Node encode(const QStringList& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/95b321ff_3a418a53 PS22, Line 166: static Node encode(const QStringList& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/083b7448_56b300df PS22, Line 166: static Node encode(const QStringList& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/b67d88dc_4ab68af4 PS22, Line 167: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/6f0e3b03_e3fc8a66 PS22, Line 168: Node node(NodeType::Sequence); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/a1d47d64_20dc4155 PS22, Line 168: Node node(NodeType::Sequence); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/f4511b5d_9fafca2d PS22, Line 169: for (const auto &value: rhs) { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/008e8a38_95095ce1 PS22, Line 169: for (const auto &value: rhs) { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/15942c6c_7e6ae145 PS22, Line 169: for (const auto &value: rhs) { suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/d9779e40_c3e7cf0e PS22, Line 169: for (const auto &value: rhs) { need consistent spacing around '&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/3ffd7b6f_cc266adf PS22, Line 169: for (const auto &value: rhs) { spaces required around that ':' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/6daba129_9ab117b6 PS22, Line 169: for (const auto &value: rhs) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/ec5bcf94_3f3963fc PS22, Line 170: node.push_back(value); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/0361ff3a_69940544 PS22, Line 170: node.push_back(value); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/ff27d295_8ebf3623 PS22, Line 171: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/e852d69a_3d29f249 PS22, Line 171: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/01f9f3d7_70b4da11 PS22, Line 172: return node; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/448d1d1e_ccbd45cb PS22, Line 172: return node; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/8f3285c0_19258c36 PS22, Line 173: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/e70515a9_69ab042f PS22, Line 175: static bool decode(const Node& node, QStringList& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/a18133fa_6368dd6e PS22, Line 175: static bool decode(const Node& node, QStringList& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/3192e57d_c82f3d6a PS22, Line 175: static bool decode(const Node& node, QStringList& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/f2868817_5f709850 PS22, Line 175: static bool decode(const Node& node, QStringList& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/09e67cf1_149e1660 PS22, Line 176: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/31a4b327_f25a3f36 PS22, Line 177: if (!node.IsSequence()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/30ad5d77_38a855fe PS22, Line 177: if (!node.IsSequence()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/c8844996_98efeeab PS22, Line 177: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/402d6d23_dbb9b760 PS22, Line 178: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/a287d94d_64ec4ea3 PS22, Line 178: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/ecfcc627_0778fb79 PS22, Line 180: rhs.clear(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/3cefab4c_6f54c121 PS22, Line 180: rhs.clear(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/16ebbe40_2dbc24d3 PS22, Line 181: const_iterator it = node.begin(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/3b07e088_55a992ba PS22, Line 181: const_iterator it = node.begin(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/345e3d59_29093c83 PS22, Line 182: while (it != node.end()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/9f8bae2b_26ebcaaa PS22, Line 182: while (it != node.end()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/aa6058cb_231da4a9 PS22, Line 182: while (it != node.end()) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/42ca19a6_71283349 PS22, Line 182: while (it != node.end()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/d8f5a4be_d41a6e76 PS22, Line 183: { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/c5094385_cc140064 PS22, Line 183: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/61ccaca7_8d6fca2e PS22, Line 184: rhs.push_back(it->as<QString>()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/46fc1a00_3d79dfc7 PS22, Line 184: rhs.push_back(it->as<QString>()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/a1c73a32_4564d836 PS22, Line 184: rhs.push_back(it->as<QString>()); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/febd3c21_db4bce32 PS22, Line 184: rhs.push_back(it->as<QString>()); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/93ec428e_f5eeeb71 PS22, Line 185: ++it; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/e78b6e75_2f80771d PS22, Line 185: ++it; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/548af53e_0528fe9e PS22, Line 186: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/4e359f96_fa8da887 PS22, Line 186: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/c2b858bc_6504a9f8 PS22, Line 187: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/7cd77bbb_3c051f38 PS22, Line 187: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/96cb177e_85b078d7 PS22, Line 188: } please, no spaces at the start of a line File util/coreboot-configurator/src/application/toggleswitch.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/932caaac_708eb46d PS22, Line 9: /// \brief The ToggleSwitch class represents Toggle Switch widget based on QCheckBox and toggles svg with colorscheme support line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/b98a12ef_9eae8e86 PS22, Line 12: Q_OBJECT please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/ace3f3bb_36048771 PS22, Line 13: public: spaces required around that ':' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/fa012e9a_5f4abab1 PS22, Line 14: explicit ToggleSwitch(QWidget* parent = nullptr); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/cf46e4e7_976d324c PS22, Line 14: explicit ToggleSwitch(QWidget* parent = nullptr); need consistent spacing around '*' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/0333ad9f_55830503 PS22, Line 17: QSvgRenderer m_svgr; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/f5e6bdf6_313d282f PS22, Line 19: static const QByteArray s_toggleOnSvgContent; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/c400bf89_9447c104 PS22, Line 20: static const QByteArray s_toggleOffSvgContent; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/d4f790a7_5fc39e19 PS22, Line 22: void recolorToggleOn(const QPalette& palette); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/0f97bd4a_7179d9f2 PS22, Line 22: void recolorToggleOn(const QPalette& palette); need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/f402fc12_4e9cb4fd PS22, Line 23: QByteArray m_toggleOnSvgContentColored; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/58b14b33_590d1b09 PS22, Line 27: void paintEvent(QPaintEvent *event) override; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/7cbc20b5_6617432f PS22, Line 27: void paintEvent(QPaintEvent *event) override; need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/6d67fbe3_9096d0e8 PS22, Line 31: bool hitButton(const QPoint &pos) const override please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/f17271ac_2e9a7026 PS22, Line 31: bool hitButton(const QPoint &pos) const override need consistent spacing around '&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/72aebc4a_8e386c85 PS22, Line 32: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/ebce79d6_e3f98e10 PS22, Line 33: //needs to be clickable on code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/04024376_92766e75 PS22, Line 34: return rect().contains(pos); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/7efad0de_f8e0d2df PS22, Line 34: return rect().contains(pos); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/33b03798_efbe50cf PS22, Line 35: } please, no spaces at the start of a line -- To view, visit https://review.coreboot.org/c/coreboot/+/58854 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie654f6aca57a792be0c295afc081a95ed4d875d1 Gerrit-Change-Number: 58854 Gerrit-PatchSet: 22 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com> Gerrit-Comment-Date: Thu, 04 Nov 2021 22:28:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [WIP] util: Add coreboot Configurator
by build bot (Jenkins) (Code Review) 04 Nov '21

04 Nov '21

Attention is currently required from: Sean Rhodes, Martin Roth, Tim Wawrzynczak, Angel Pons. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58854 ) Change subject: [WIP] util: Add coreboot Configurator ...................................................................... Patch Set 21: (379 comments) File util/coreboot-configurator/src/application/aboutwindow.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/136393e2_c9ed898a PS21, Line 16: public: spaces required around that ':' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/d0cc06f4_78fe74de PS21, Line 17: explicit aboutWindow(QWidget *parent = nullptr); need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/0996c9ba_73524fa2 PS21, Line 21: Ui::aboutWindow *ui; need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/804b7fb2_940c9d7c PS21, Line 21: Ui::aboutWindow *ui; labels should not be indented File util/coreboot-configurator/src/application/categories.yaml: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/51c58d2d_44e2da67 PS21, Line 84: help: Adjust the amout of time before the keyboard backlight turns off when un-used 'amout' may be misspelled - perhaps 'amount'? File util/coreboot-configurator/src/application/configuration.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/e8c2b586_7676ee2f PS21, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/bf8578a7_f2d488a2 PS21, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/4c4b6004_707370aa PS21, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/2f8f3fe6_3426b7d4 PS21, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/d9f2b8bc_8c5c00ad PS21, Line 15: QMap<QString,QString> fromNvramTool(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/99e39411_7c71993b PS21, Line 15: QMap<QString,QString> fromNvramTool(); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/3b8b4ea5_b28f8cd0 PS21, Line 15: QMap<QString,QString> fromNvramTool(); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/1ba056ae_8d66e4de PS21, Line 17: QMap<QString,QString> mocked(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/026f6cfc_4f528bd3 PS21, Line 17: QMap<QString,QString> mocked(); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/83662e49_359cdb4a PS21, Line 17: QMap<QString,QString> mocked(); spaces required around that '>' (ctx:VxW) File util/coreboot-configurator/src/application/coreboot_configurator.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/e2ee4ca0_9245e488 PS21, Line 29: public: spaces required around that ':' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/9f4c170c_98769cdb PS21, Line 30: coreboot_configurator(QWidget *parent = nullptr); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/db04ebc3_48d61f5c PS21, Line 30: coreboot_configurator(QWidget *parent = nullptr); need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/e3bd53b5_0cff1621 PS21, Line 37: void showEvent(QShowEvent *ev); need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/fc1d2ba7_39746f8a PS21, Line 48: void displaySettings(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/3a8fa6d6_1871d4f8 PS21, Line 48: void displaySettings(); Bad function definition - void displaySettings() should probably be void displaySettings(void) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/1583a376_1b229785 PS21, Line 52: void writeToFile(const QString& out_file); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/e94dda34_06b09b85 PS21, Line 52: void writeToFile(const QString& out_file); need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/aecf568b_bab533ee PS21, Line 55: void updateValue(const QString& name); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/9451dfe2_90a018ff PS21, Line 55: void updateValue(const QString& name); need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/057d3f1d_f71e11aa PS21, Line 59: QString m_fileName; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/b71bebc2_1646564a PS21, Line 61: QMap<QString, QString> m_values; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/f568e1c7_b7cd599d PS21, Line 61: QMap<QString, QString> m_values; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/5b0c001a_277a7888 PS21, Line 61: QMap<QString, QString> m_values; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/e0e49095_176bfc69 PS21, Line 64: QMap<QString, QVBoxLayout*> m_tabs; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/84805218_5518476d PS21, Line 64: QMap<QString, QVBoxLayout*> m_tabs; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/b35819f4_1fc8853d PS21, Line 64: QMap<QString, QVBoxLayout*> m_tabs; spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/aa13a0b3_16bda8d1 PS21, Line 67: YAML::Node m_categories; labels should not be indented Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/bb3ef7a4_aef15f11 PS21, Line 70: QComboBox *textToDisplay(const QString &in_string); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/365aba8b_3ec77cd7 PS21, Line 70: QComboBox *textToDisplay(const QString &in_string); need consistent spacing around '&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/7e6d3d15_7694720d PS21, Line 71: QCheckBox *checkToDisplay(const QString &in_string); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/dec1a176_466d1132 PS21, Line 71: QCheckBox *checkToDisplay(const QString &in_string); need consistent spacing around '&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/cd7af1d1_fa225323 PS21, Line 73: Ui::coreboot_configurator *ui; need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/d168bad2_4d8cba96 PS21, Line 73: Ui::coreboot_configurator *ui; labels should not be indented File util/coreboot-configurator/src/application/coreboot_configurator.cpp: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/6d06e20c_fa883356 PS21, Line 25: static auto s_errorWindowTitle = "Error Occured"; 'Occured' may be misspelled - perhaps 'Occurred'? Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/a209e01b_37f2effa PS21, Line 207: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/7c067e46_e6eeb1df PS21, Line 413: QMessageBox::critical(this, "Error Occured", "Can't open file to write"); 'Occured' may be misspelled - perhaps 'Occurred'? File util/coreboot-configurator/src/application/qtyaml.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/41df8fb6_ee7dd8dd PS21, Line 30: template<> spaces required around that '<' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/f9db270e_6d3ffce3 PS21, Line 30: template<> spaces required around that '>' (ctx:OxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/1243aae8_52093984 PS21, Line 31: struct convert<QString> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/d61a141c_c33fb6f8 PS21, Line 31: struct convert<QString> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/ed2f20b9_34bf6731 PS21, Line 33: static Node encode(const QString& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/d4795344_ba587da9 PS21, Line 33: static Node encode(const QString& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/a2a3957f_879ea584 PS21, Line 33: static Node encode(const QString& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/59ffb31e_36cbae8b PS21, Line 34: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/810101c1_cca685c8 PS21, Line 35: return Node(rhs.toStdString()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/65fa78f9_c56daba7 PS21, Line 35: return Node(rhs.toStdString()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/e007cfd5_0a591d8b PS21, Line 36: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/d88df889_f434b810 PS21, Line 38: static bool decode(const Node& node, QString& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/d069c7c5_dd160a03 PS21, Line 38: static bool decode(const Node& node, QString& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/0b67a04e_7f1b5b23 PS21, Line 38: static bool decode(const Node& node, QString& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/0172ef63_1843cb5c PS21, Line 38: static bool decode(const Node& node, QString& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/f96730ed_7c38c594 PS21, Line 39: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/d4bcfb0f_6d3492cd PS21, Line 40: if (!node.IsScalar()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/0d673a9b_1d080fc5 PS21, Line 40: if (!node.IsScalar()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/e3a526da_d7069894 PS21, Line 40: if (!node.IsScalar()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/193311a6_b361cece PS21, Line 41: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/02cda0d6_0afc9dff PS21, Line 41: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/717281df_ded1e3fc PS21, Line 42: rhs = QString::fromStdString(node.Scalar()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/430cf3e2_23fec5e9 PS21, Line 42: rhs = QString::fromStdString(node.Scalar()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/75a059a6_7d8be8fc PS21, Line 43: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/fc27f302_7e4bb55e PS21, Line 43: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/32713fa2_a37d1ca8 PS21, Line 44: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/e604e467_28bc84d6 PS21, Line 48: template<typename Key, typename Value> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/74f0cb3a_f3b3aaa6 PS21, Line 48: template<typename Key, typename Value> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/25b31789_221b47dd PS21, Line 49: struct convert<QMap<Key, Value> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/076c6628_4ea9c49b PS21, Line 49: struct convert<QMap<Key, Value> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/cf35f380_68c56151 PS21, Line 49: struct convert<QMap<Key, Value> > spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/cca48a44_a7fffea9 PS21, Line 51: static Node encode(const QMap<Key,Value>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/e85b6ffb_69d977bd PS21, Line 51: static Node encode(const QMap<Key,Value>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/076823e1_96f6bfcb PS21, Line 51: static Node encode(const QMap<Key,Value>& rhs) space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/5b44bb1b_11d2e0eb PS21, Line 51: static Node encode(const QMap<Key,Value>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/0141a595_6d77209a PS21, Line 51: static Node encode(const QMap<Key,Value>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/9ba76e3f_2204a6cd PS21, Line 51: static Node encode(const QMap<Key,Value>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/7637dd42_87de68ff PS21, Line 51: static Node encode(const QMap<Key,Value>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/f800a0e4_7596a792 PS21, Line 52: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/e5242bf9_5f00ad7a PS21, Line 53: Node node(NodeType::Map); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/0a1e2529_4ea09ec4 PS21, Line 53: Node node(NodeType::Map); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/f3f97395_8d08b530 PS21, Line 54: auto it = rhs.constBegin(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/467b8990_26653fe5 PS21, Line 54: auto it = rhs.constBegin(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/9bcb778b_d52cfe83 PS21, Line 55: while (it != rhs.constEnd()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/adbfe0bd_deaf7cc6 PS21, Line 55: while (it != rhs.constEnd()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/112e74e3_0f07865d PS21, Line 55: while (it != rhs.constEnd()) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/e3b19fa6_89e0eeed PS21, Line 55: while (it != rhs.constEnd()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/dcbc5785_02345fba PS21, Line 56: { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/43414a01_7a3494c7 PS21, Line 56: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/b36cae63_5382e648 PS21, Line 57: node.force_insert(it.key(), it.value()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/d9705c42_fab5a588 PS21, Line 57: node.force_insert(it.key(), it.value()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/25e049c3_cd4b67b7 PS21, Line 58: ++it; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/95dd6937_59230f52 PS21, Line 58: ++it; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/340dad92_87ce3f8b PS21, Line 59: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/2c4176e5_04b45b11 PS21, Line 59: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/729b05e3_e0b6880f PS21, Line 60: return node; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/39002fd3_06374570 PS21, Line 60: return node; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/0d891957_011bbb10 PS21, Line 61: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/33df3fbe_90f20bb4 PS21, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/b0aee644_094d09bf PS21, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/19f29cf8_1ca65370 PS21, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/f0f076e9_f3ab1649 PS21, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/7fc12f77_159b5605 PS21, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/897f19f1_9b18242c PS21, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/1ba858a4_af5099ba PS21, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/a76c8104_5e8c555e PS21, Line 64: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/a0205db0_d5642bd2 PS21, Line 65: if (!node.IsMap()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/b3553fdb_b8a18eed PS21, Line 65: if (!node.IsMap()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/24289812_37b7f2db PS21, Line 65: if (!node.IsMap()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/c66fb7c4_72327dce PS21, Line 66: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/0dc3af52_316e36a6 PS21, Line 66: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/a64484b5_288a3a24 PS21, Line 68: rhs.clear(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/e53371e2_1808217a PS21, Line 68: rhs.clear(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/ebcb44db_85bd64b4 PS21, Line 69: const_iterator it = node.begin(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/b500fee9_50205041 PS21, Line 69: const_iterator it = node.begin(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/c508306a_50df0025 PS21, Line 70: while (it != node.end()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/fb414401_e8a5ac51 PS21, Line 70: while (it != node.end()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/d01bf8ef_a95a7473 PS21, Line 70: while (it != node.end()) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/712ce8bb_2f923f2f PS21, Line 70: while (it != node.end()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/f6172c50_c57d76b6 PS21, Line 71: { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/c2890824_f33e8bc7 PS21, Line 71: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/1dc98b95_d030ceaa PS21, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/8b64cbd3_9c20898f PS21, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/d073161a_3ed251eb PS21, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/834ef842_0d8ecb82 PS21, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/e07c4708_0cee5597 PS21, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/114ee0db_a9b486c0 PS21, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/46e362a3_5b233c41 PS21, Line 73: ++it; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/1580f24d_fc4a5dc3 PS21, Line 73: ++it; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/0bef7ac9_ccaab127 PS21, Line 74: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/798698df_e5125063 PS21, Line 74: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/d9739cf7_85070160 PS21, Line 75: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/e0517574_a8a4d90c PS21, Line 75: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/0889a7b7_1c82ec4a PS21, Line 76: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/53e89f20_9afadf60 PS21, Line 80: template<typename T> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/9136b182_ff78ac60 PS21, Line 80: template<typename T> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/fa6a5747_03d1514b PS21, Line 81: struct convert<QVector<T> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/24116db1_ed45a327 PS21, Line 81: struct convert<QVector<T> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/9829aec7_390a42d3 PS21, Line 81: struct convert<QVector<T> > spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/e0514d63_bf0861e9 PS21, Line 83: static Node encode(const QVector<T>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/1a1a24f5_f34358cb PS21, Line 83: static Node encode(const QVector<T>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/7cf0fb03_96977d7f PS21, Line 83: static Node encode(const QVector<T>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/4ac1f686_1c638b03 PS21, Line 83: static Node encode(const QVector<T>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/17144257_e1f6b7b8 PS21, Line 83: static Node encode(const QVector<T>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/8828d410_426d6b32 PS21, Line 83: static Node encode(const QVector<T>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/d76e9ef2_52f44e62 PS21, Line 84: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/3fa3bf42_de988e57 PS21, Line 85: Node node(NodeType::Sequence); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/cbe92ddd_e7674d21 PS21, Line 85: Node node(NodeType::Sequence); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/b93de4b5_4835f0df PS21, Line 86: foreach (T value, rhs) { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/80aaef7f_561c2a48 PS21, Line 86: foreach (T value, rhs) { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/0052229f_06080881 PS21, Line 86: foreach (T value, rhs) { space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/bc89c8f5_ccee1ec5 PS21, Line 87: node.push_back(value); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/27f55f27_d220cf8c PS21, Line 87: node.push_back(value); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/0db89e07_f2e981b1 PS21, Line 88: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/6f6c510c_4563b88c PS21, Line 88: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/3292c66b_63a0c912 PS21, Line 89: return node; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/cd820273_3063b520 PS21, Line 89: return node; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/262d7212_7d3a85b0 PS21, Line 90: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/4e1f89d2_dc035c87 PS21, Line 92: static bool decode(const Node& node, QVector<T>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/e830830e_085ddfd3 PS21, Line 92: static bool decode(const Node& node, QVector<T>& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/b25433d4_cc2ee6cd PS21, Line 92: static bool decode(const Node& node, QVector<T>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/097a2a11_d961e6e3 PS21, Line 92: static bool decode(const Node& node, QVector<T>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/371cbdd8_663e5290 PS21, Line 92: static bool decode(const Node& node, QVector<T>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/7be34ff1_905af368 PS21, Line 92: static bool decode(const Node& node, QVector<T>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/86c9220b_7281983d PS21, Line 92: static bool decode(const Node& node, QVector<T>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/320f8286_e3598242 PS21, Line 93: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/e2ce1e2a_f1bf6680 PS21, Line 94: if (!node.IsSequence()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/853b9b74_3e715432 PS21, Line 94: if (!node.IsSequence()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/f77a61c2_e21a8892 PS21, Line 94: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/7c0288d5_bef7d241 PS21, Line 95: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/a050ede1_79d6bb7e PS21, Line 95: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/7f0f27c0_86f6bde9 PS21, Line 97: rhs.clear(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/9841e0b4_08434cf5 PS21, Line 97: rhs.clear(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/2735a0ac_8167263b PS21, Line 98: const_iterator it = node.begin(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/7fa31669_df4991c6 PS21, Line 98: const_iterator it = node.begin(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/c94116ff_a4e072fa PS21, Line 99: while (it != node.end()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/a9658822_c91bb71c PS21, Line 99: while (it != node.end()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/83c183ff_fd1863bd PS21, Line 99: while (it != node.end()) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/58b51d19_170f0ad3 PS21, Line 99: while (it != node.end()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/e3efc6ac_5bb7d2f3 PS21, Line 100: { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/dfdabd21_de985b97 PS21, Line 100: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/548ab3a6_495447ce PS21, Line 101: rhs.push_back(it->as<T>()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/09b7ca87_578cadf2 PS21, Line 101: rhs.push_back(it->as<T>()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/98070269_175b72ec PS21, Line 101: rhs.push_back(it->as<T>()); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/b4479b00_55077b8b PS21, Line 101: rhs.push_back(it->as<T>()); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/332202ef_bfb7495c PS21, Line 102: ++it; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/771ce543_8b07e1c3 PS21, Line 102: ++it; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/d3538872_18343f36 PS21, Line 103: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/8a4f2cb2_f2173214 PS21, Line 103: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/d6f84f8d_a514ad2c PS21, Line 104: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/08d5e258_e823a238 PS21, Line 104: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/1ca2575e_f3da2c49 PS21, Line 105: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/f1e75665_280e0f2b PS21, Line 109: template<typename T> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/4bc1819c_07302fb2 PS21, Line 109: template<typename T> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/330f1b6a_8d8f2772 PS21, Line 110: struct convert<QList<T> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/86e170b6_deb6871c PS21, Line 110: struct convert<QList<T> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/3263b968_2c5aad11 PS21, Line 110: struct convert<QList<T> > spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/89c3be55_f13b51e6 PS21, Line 112: static Node encode(const QList<T>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/203f12c7_1499739b PS21, Line 112: static Node encode(const QList<T>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/e0a880c8_cf9bac22 PS21, Line 112: static Node encode(const QList<T>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/52bacbe1_92ed73b7 PS21, Line 112: static Node encode(const QList<T>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/81896dea_c6a5838e PS21, Line 112: static Node encode(const QList<T>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/cade1f4d_60ff14c1 PS21, Line 112: static Node encode(const QList<T>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/eba3bd49_1f7968b9 PS21, Line 113: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/29619269_6e7a41c5 PS21, Line 114: Node node(NodeType::Sequence); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/85ee9431_e430c8a4 PS21, Line 114: Node node(NodeType::Sequence); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/c5512c35_a0ea3098 PS21, Line 115: foreach (T value, rhs) { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/03fa9d04_7ef1db85 PS21, Line 115: foreach (T value, rhs) { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/fbc33593_aa05416b PS21, Line 115: foreach (T value, rhs) { space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/033c82eb_b9ceaa81 PS21, Line 116: node.push_back(value); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/8da6c211_5b73025a PS21, Line 116: node.push_back(value); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/b32a2982_1ffb9e03 PS21, Line 117: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/c1f339f2_a0a577e5 PS21, Line 117: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/5e83672b_e76b7d53 PS21, Line 118: return node; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/9f0bd0e5_f7d822d8 PS21, Line 118: return node; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/e660ed44_b12b7d0b PS21, Line 119: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/4a79d531_f4664c99 PS21, Line 121: static bool decode(const Node& node, QList<T>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/e117b6b6_94571402 PS21, Line 121: static bool decode(const Node& node, QList<T>& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/36cfca8e_6b5c17fd PS21, Line 121: static bool decode(const Node& node, QList<T>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/7da44db5_4fab7aff PS21, Line 121: static bool decode(const Node& node, QList<T>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/63477e5a_17c1f986 PS21, Line 121: static bool decode(const Node& node, QList<T>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/05892938_a05c5079 PS21, Line 121: static bool decode(const Node& node, QList<T>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/ed3a6da1_19887de5 PS21, Line 121: static bool decode(const Node& node, QList<T>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/ba305f38_87cb07c4 PS21, Line 122: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/1c7112e2_a9b633ff PS21, Line 123: if (!node.IsSequence()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/324933e8_3a5bb35d PS21, Line 123: if (!node.IsSequence()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/ccad744c_62ddcb62 PS21, Line 123: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/8d8b0709_b1f6a155 PS21, Line 124: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/315038d5_d5a0b345 PS21, Line 124: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/9ca76317_6a41af17 PS21, Line 126: rhs.clear(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/a0d8ea0a_9a835df2 PS21, Line 126: rhs.clear(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/753f7a0d_5de0a553 PS21, Line 127: const_iterator it = node.begin(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/567755ae_0ad1548a PS21, Line 127: const_iterator it = node.begin(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/fba93040_002fb557 PS21, Line 128: while (it != node.end()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/9d1e6c15_93d322f1 PS21, Line 128: while (it != node.end()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/2a5911b3_4ae42e5b PS21, Line 128: while (it != node.end()) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/ea33d454_1943b2a2 PS21, Line 128: while (it != node.end()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/23c8115e_bd770726 PS21, Line 129: { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/67f426ce_809c86e1 PS21, Line 129: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/639b9fa8_a489938c PS21, Line 130: rhs.push_back(it->as<T>()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/7e5b171d_88432ddb PS21, Line 130: rhs.push_back(it->as<T>()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/4d4849ae_71f4c475 PS21, Line 130: rhs.push_back(it->as<T>()); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/7f9cd97b_e6ab4c69 PS21, Line 130: rhs.push_back(it->as<T>()); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/b2235f4e_2955dcb8 PS21, Line 131: ++it; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/8b3083d2_bf31f453 PS21, Line 131: ++it; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/bc258605_e7877129 PS21, Line 132: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/40adb183_a78cf00b PS21, Line 132: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/5fe54f15_d990c319 PS21, Line 133: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/83598f87_c9f2802c PS21, Line 133: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/a8446f24_420dda0d PS21, Line 134: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/5f5677a9_c91fba93 PS21, Line 138: template<typename T, typename U> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/b8b9a321_c976e023 PS21, Line 138: template<typename T, typename U> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/b9ac9371_48587eaf PS21, Line 139: struct convert<QPair<T,U> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/9e927034_49eb1b61 PS21, Line 139: struct convert<QPair<T,U> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/d8e52122_19e446a5 PS21, Line 139: struct convert<QPair<T,U> > space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/3cc1ff68_c772e8b2 PS21, Line 139: struct convert<QPair<T,U> > spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/b10fcb61_8fa7502c PS21, Line 141: static Node encode(const QPair<T,U>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/f52cf432_4f28e351 PS21, Line 141: static Node encode(const QPair<T,U>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/d2f928ab_6ca97a6e PS21, Line 141: static Node encode(const QPair<T,U>& rhs) space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/ee66be0b_02c2801c PS21, Line 141: static Node encode(const QPair<T,U>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/b67b550c_5db7d8c7 PS21, Line 141: static Node encode(const QPair<T,U>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/085f32e7_bc43b39e PS21, Line 141: static Node encode(const QPair<T,U>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/348d5eeb_9f3f62ff PS21, Line 141: static Node encode(const QPair<T,U>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/f29d52fa_dec6e905 PS21, Line 142: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/92238545_1527da67 PS21, Line 143: Node node(NodeType::Sequence); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/80aa3415_c8480f7b PS21, Line 143: Node node(NodeType::Sequence); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/775716b9_1209621a PS21, Line 144: node.push_back(rhs.first); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/ff6f8f00_72ba1358 PS21, Line 144: node.push_back(rhs.first); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/33d89c38_eea8bc5b PS21, Line 145: node.push_back(rhs.second); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/30cba2a5_4088811c PS21, Line 145: node.push_back(rhs.second); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/2312e857_abc1bd16 PS21, Line 146: return node; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/66662971_59152814 PS21, Line 146: return node; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/52b01ba0_1c0deb8c PS21, Line 147: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/29731c76_a2c5f996 PS21, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/42a313d1_39994f53 PS21, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/6ec93da6_adbbcaac PS21, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/b0cfab8d_af155391 PS21, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/f76dd988_594ac9fb PS21, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/676c406e_be1b48c8 PS21, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/643314fa_7416624c PS21, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/6767b3d7_7d02a2b8 PS21, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/bcd9a6db_16e8dc77 PS21, Line 150: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/0faa1e6d_cd145d03 PS21, Line 151: if (!node.IsSequence()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/271f74f1_4039aeca PS21, Line 151: if (!node.IsSequence()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/6ab1d21a_d26beadd PS21, Line 151: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/d165a596_9cb173cf PS21, Line 152: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/db6f35f8_4a0ed475 PS21, Line 152: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/788ff2ea_1c8e03fc PS21, Line 153: if (node.size() != 2) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/55af6161_08bd3c3f PS21, Line 153: if (node.size() != 2) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/013a842a_a32c5b60 PS21, Line 153: if (node.size() != 2) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/3e2b2ba2_0c82f3a9 PS21, Line 154: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/bfc52604_5baaedeb PS21, Line 154: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/c1d5a5e2_dcf55a8e PS21, Line 156: rhs.first = node[0].as<T>(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/62cbd478_a63ac1c9 PS21, Line 156: rhs.first = node[0].as<T>(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/736c507d_706d67a6 PS21, Line 156: rhs.first = node[0].as<T>(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/74d8c58b_5eb60cd8 PS21, Line 156: rhs.first = node[0].as<T>(); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/68e8e9c8_12978a55 PS21, Line 157: rhs.second = node[1].as(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/987bbf8b_92a842ea PS21, Line 157: rhs.second = node[1].as(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/1577238c_e11f16d3 PS21, Line 157: rhs.second = node[1].as(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/b0ff3f4e_7d79b8bc PS21, Line 157: rhs.second = node[1].as(); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/6682d641_c9c4eb1b PS21, Line 158: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/4addab30_3d92df22 PS21, Line 158: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/cddd9fba_4383688a PS21, Line 159: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/4b108329_bfcd99ac PS21, Line 163: template<> spaces required around that '<' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/33858f50_b4441297 PS21, Line 163: template<> spaces required around that '>' (ctx:OxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/6858e58f_65b4ed99 PS21, Line 164: struct convert<QStringList> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/1b9d5ea1_39118376 PS21, Line 164: struct convert<QStringList> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/b4595255_23d753b6 PS21, Line 166: static Node encode(const QStringList& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/d8f7ce9a_e5c0c3f7 PS21, Line 166: static Node encode(const QStringList& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/dcff8177_e658a05b PS21, Line 166: static Node encode(const QStringList& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/6db732c0_cffa92fa PS21, Line 167: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/b81595c0_fd7c30bd PS21, Line 168: Node node(NodeType::Sequence); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/e8ceb32a_96a0b79a PS21, Line 168: Node node(NodeType::Sequence); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/3106af55_49a251d7 PS21, Line 169: for (const auto &value: rhs) { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/447ee81c_a0d94c6b PS21, Line 169: for (const auto &value: rhs) { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/877b3f95_a98948fb PS21, Line 169: for (const auto &value: rhs) { suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/44e258e6_dcd4a26d PS21, Line 169: for (const auto &value: rhs) { need consistent spacing around '&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/49bdfb97_39a43152 PS21, Line 169: for (const auto &value: rhs) { spaces required around that ':' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/bf28fc18_095cb064 PS21, Line 169: for (const auto &value: rhs) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/9f0ea189_9115e79c PS21, Line 170: node.push_back(value); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/c61b76aa_aef0017e PS21, Line 170: node.push_back(value); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/1509980b_5aed5c30 PS21, Line 171: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/b063e3d4_06f656fe PS21, Line 171: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/feae0798_f3f21939 PS21, Line 172: return node; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/bd359692_a1b4dbba PS21, Line 172: return node; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/7ff8095c_2715a0e2 PS21, Line 173: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/b4ee2620_f757bdf9 PS21, Line 175: static bool decode(const Node& node, QStringList& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/f3647009_b49ddef0 PS21, Line 175: static bool decode(const Node& node, QStringList& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/46afcb88_33070214 PS21, Line 175: static bool decode(const Node& node, QStringList& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/10cdc722_862488b4 PS21, Line 175: static bool decode(const Node& node, QStringList& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/962af779_6fdd50f8 PS21, Line 176: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/bc21abd2_ca58c826 PS21, Line 177: if (!node.IsSequence()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/bbab6345_9da21d4a PS21, Line 177: if (!node.IsSequence()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/8e6413f8_46ae80a1 PS21, Line 177: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/3b3a1788_5d7f46f8 PS21, Line 178: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/505b53d8_dd8df6c3 PS21, Line 178: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/6b717ed3_83c7dcd2 PS21, Line 180: rhs.clear(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/dd34c09b_c5130edf PS21, Line 180: rhs.clear(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/f70dccab_250bcb0e PS21, Line 181: const_iterator it = node.begin(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/5a40308c_931cb595 PS21, Line 181: const_iterator it = node.begin(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/2821673e_5c2328f3 PS21, Line 182: while (it != node.end()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/bb34c835_886b7e09 PS21, Line 182: while (it != node.end()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/7c7dd40a_2371397a PS21, Line 182: while (it != node.end()) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/ad2e2b6e_99d1780a PS21, Line 182: while (it != node.end()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/3ea6e4b6_b0df2d5a PS21, Line 183: { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/d8efb2a3_b61067a2 PS21, Line 183: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/40a345ad_c442a11c PS21, Line 184: rhs.push_back(it->as<QString>()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/d7075c18_7507d12c PS21, Line 184: rhs.push_back(it->as<QString>()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/10183cc1_3f21935f PS21, Line 184: rhs.push_back(it->as<QString>()); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/2c152c11_0916bcec PS21, Line 184: rhs.push_back(it->as<QString>()); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/2c32232d_71113c97 PS21, Line 185: ++it; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/f55ac098_a0ab4baa PS21, Line 185: ++it; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/323611c0_5bab376a PS21, Line 186: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/aba4f8bf_dd0e10a2 PS21, Line 186: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/860b5741_89b4c547 PS21, Line 187: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/f30b6ea3_bdfd1a34 PS21, Line 187: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/f08f90bd_aefb1e55 PS21, Line 188: } please, no spaces at the start of a line File util/coreboot-configurator/src/application/toggleswitch.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/98018e50_d9f4ee9d PS21, Line 9: /// \brief The ToggleSwitch class represents Toggle Switch widget based on QCheckBox and toggles svg with colorscheme support line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/7e72bd72_48d44823 PS21, Line 12: Q_OBJECT please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/4e70308d_50449637 PS21, Line 13: public: spaces required around that ':' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/13399076_d1471c7a PS21, Line 14: explicit ToggleSwitch(QWidget* parent = nullptr); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/b0d0203d_7d8718d3 PS21, Line 14: explicit ToggleSwitch(QWidget* parent = nullptr); need consistent spacing around '*' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/e17d1160_4dc8f359 PS21, Line 17: QSvgRenderer m_svgr; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/17693d46_12f289c1 PS21, Line 19: static const QByteArray s_toggleOnSvgContent; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/66d2b8cb_29787f60 PS21, Line 20: static const QByteArray s_toggleOffSvgContent; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/354ebbe9_5f1a7144 PS21, Line 22: void recolorToggleOn(const QPalette& palette); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/1de2741c_7ca73b3e PS21, Line 22: void recolorToggleOn(const QPalette& palette); need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/72825157_6e5b71c3 PS21, Line 23: QByteArray m_toggleOnSvgContentColored; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/db31dd3c_bf4da7c8 PS21, Line 27: void paintEvent(QPaintEvent *event) override; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/8fb1ea94_8cca60e8 PS21, Line 27: void paintEvent(QPaintEvent *event) override; need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/c0094227_194dc5ae PS21, Line 31: bool hitButton(const QPoint &pos) const override please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/20953d3f_96f5f737 PS21, Line 31: bool hitButton(const QPoint &pos) const override need consistent spacing around '&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/91dd1c13_5addc20b PS21, Line 32: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/0717454b_60971b1f PS21, Line 33: //needs to be clickable on code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/9a7ad6cc_0695dd84 PS21, Line 34: return rect().contains(pos); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/7ccb0c23_332b0edc PS21, Line 34: return rect().contains(pos); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/59773655_472409cd PS21, Line 35: } please, no spaces at the start of a line -- To view, visit https://review.coreboot.org/c/coreboot/+/58854 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie654f6aca57a792be0c295afc081a95ed4d875d1 Gerrit-Change-Number: 58854 Gerrit-PatchSet: 21 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com> Gerrit-Comment-Date: Thu, 04 Nov 2021 22:23:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [WIP] util: Add coreboot Configurator
by Sean Rhodes (Code Review) 04 Nov '21

04 Nov '21

Attention is currently required from: Sean Rhodes, Martin Roth, Tim Wawrzynczak, Angel Pons. Hello build bot (Jenkins), Martin Roth, Tim Wawrzynczak, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/58854 to look at the new patch set (#21). Change subject: [WIP] util: Add coreboot Configurator ...................................................................... [WIP] util: Add coreboot Configurator A simply GUI to change settings in coreboot's CBFS, via the nvramtool utility. Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: Ie654f6aca57a792be0c295afc081a95ed4d875d1 --- A util/coreboot-configurator/README.md A util/coreboot-configurator/contrib/PKGBUILD A util/coreboot-configurator/contrib/README.md A util/coreboot-configurator/contrib/debian/changelog A util/coreboot-configurator/contrib/debian/compat A util/coreboot-configurator/contrib/debian/control A util/coreboot-configurator/contrib/debian/files A util/coreboot-configurator/contrib/debian/rules A util/coreboot-configurator/contrib/debian/source/format A util/coreboot-configurator/contrib/flatpak/coreboot-configurator.json A util/coreboot-configurator/contrib/flatpak/org.coreboot.coreboot-configurator.json A util/coreboot-configurator/meson.build A util/coreboot-configurator/meson_options.txt A util/coreboot-configurator/screenshots/coreboot-configurator.gif A util/coreboot-configurator/screenshots/coreboot-configurator.png A util/coreboot-configurator/src/application/aboutwindow.cpp A util/coreboot-configurator/src/application/aboutwindow.h A util/coreboot-configurator/src/application/aboutwindow.ui A util/coreboot-configurator/src/application/categories.yaml A util/coreboot-configurator/src/application/configuration.cpp A util/coreboot-configurator/src/application/configuration.h A util/coreboot-configurator/src/application/coreboot_configurator.cpp A util/coreboot-configurator/src/application/coreboot_configurator.h A util/coreboot-configurator/src/application/coreboot_configurator.ui A util/coreboot-configurator/src/application/images.qrc A util/coreboot-configurator/src/application/main.cpp A util/coreboot-configurator/src/application/meson.build A util/coreboot-configurator/src/application/qtyaml.h A util/coreboot-configurator/src/application/toggle-off.svg A util/coreboot-configurator/src/application/toggle-on.svg A util/coreboot-configurator/src/application/toggleswitch.cpp A util/coreboot-configurator/src/application/toggleswitch.h A util/coreboot-configurator/src/meson.build A util/coreboot-configurator/src/static/aboutIcon.png A util/coreboot-configurator/src/static/coreboot-configurator.desktop A util/coreboot-configurator/src/static/coreboot_configurator.svg A util/coreboot-configurator/src/static/meson.build A util/coreboot-configurator/src/static/org.coreboot.nvramtool.policy A util/coreboot-configurator/src/static/org.coreboot.reboot.policy 39 files changed, 3,002 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/58854/21 -- To view, visit https://review.coreboot.org/c/coreboot/+/58854 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie654f6aca57a792be0c295afc081a95ed4d875d1 Gerrit-Change-Number: 58854 Gerrit-PatchSet: 21 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2021