coreboot-gerrit November 2021

coreboot-gerrit@coreboot.org

1 participants
6394 discussions

Change in coreboot[master]: [WIP] util: Add coreboot Configurator
by build bot (Jenkins) (Code Review) 04 Nov '21

04 Nov '21

Attention is currently required from: Sean Rhodes, Martin Roth, Tim Wawrzynczak, Angel Pons. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58854 ) Change subject: [WIP] util: Add coreboot Configurator ...................................................................... Patch Set 20: (408 comments) File util/coreboot-configurator/obj-x86_64-linux-gnu/meson-logs/meson-log.txt: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/9e700e06_1ae6a027 PS20, Line 63: PKG_CONFIG_PATH: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/38393922_5fc1a28a PS20, Line 66: PKG_CONFIG_PATH: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/c20d527d_a12b93e3 PS20, Line 69: PKG_CONFIG_PATH: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/0e3c9fe9_21476b0d PS20, Line 72: PKG_CONFIG_PATH: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/24f6d954_3145b6db PS20, Line 79: Command line: c++ /home/sean/Documents/gerrit/coreboot/util/coreboot-configurator/obj-x86_64-linux-gnu/meson-private/tmpovryma0u/testfile.cpp -o /home/sean/Documents/gerrit/coreboot/util/coreboot-configurator/obj-x86_64-linux-gnu/meson-private/tmpovryma0u/output.exe -pipe -g -O2 -ffile-prefix-map=/home/sean/Documents/gerrit/coreboot/util/coreboot-configurator=. -flto=auto -ffat-lto-objects -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -D_FILE_OFFSET_BITS=64 -O0 -fpermissive -Wl,--start-group -lQt5Core -Wl,--end-group -Wl,--allow-shlib-undefined -Wl,-Bsymbolic-functions -Wl,-z,relro trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/047bbe31_86d0206a PS20, Line 85: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/d1e644af_dd64f47e PS20, Line 87: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/1a3f7f1c_36616bc6 PS20, Line 90: PKG_CONFIG_PATH: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/dc84ac6a_27c89db4 PS20, Line 93: PKG_CONFIG_PATH: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/e027b407_07bf7602 PS20, Line 96: PKG_CONFIG_PATH: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/c8dd5423_09bf7063 PS20, Line 99: PKG_CONFIG_PATH: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/b0a45da0_518dfa4e PS20, Line 106: Command line: c++ /home/sean/Documents/gerrit/coreboot/util/coreboot-configurator/obj-x86_64-linux-gnu/meson-private/tmpkbtd4eu8/testfile.cpp -o /home/sean/Documents/gerrit/coreboot/util/coreboot-configurator/obj-x86_64-linux-gnu/meson-private/tmpkbtd4eu8/output.exe -pipe -g -O2 -ffile-prefix-map=/home/sean/Documents/gerrit/coreboot/util/coreboot-configurator=. -flto=auto -ffat-lto-objects -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -D_FILE_OFFSET_BITS=64 -O0 -fpermissive -Wl,--start-group -lQt5Gui -Wl,--end-group -Wl,--allow-shlib-undefined -Wl,-Bsymbolic-functions -Wl,-z,relro trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/8ed9b615_b3feebf0 PS20, Line 112: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/52598b46_db7657df PS20, Line 114: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/532abafe_d4ed1115 PS20, Line 117: PKG_CONFIG_PATH: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/cd3d7ce7_23551c0a PS20, Line 120: PKG_CONFIG_PATH: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/3931933c_f50aece6 PS20, Line 123: PKG_CONFIG_PATH: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/c1816143_06f04f57 PS20, Line 126: PKG_CONFIG_PATH: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/8bce49e0_33a68595 PS20, Line 133: Command line: c++ /home/sean/Documents/gerrit/coreboot/util/coreboot-configurator/obj-x86_64-linux-gnu/meson-private/tmpl5ncokvu/testfile.cpp -o /home/sean/Documents/gerrit/coreboot/util/coreboot-configurator/obj-x86_64-linux-gnu/meson-private/tmpl5ncokvu/output.exe -pipe -g -O2 -ffile-prefix-map=/home/sean/Documents/gerrit/coreboot/util/coreboot-configurator=. -flto=auto -ffat-lto-objects -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -D_FILE_OFFSET_BITS=64 -O0 -fpermissive -Wl,--start-group -lQt5Widgets -Wl,--end-group -Wl,--allow-shlib-undefined -Wl,-Bsymbolic-functions -Wl,-z,relro trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/a220826d_d53c63b8 PS20, Line 139: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/98bf07b0_36970c98 PS20, Line 141: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/ea71a07f_90b245e5 PS20, Line 144: PKG_CONFIG_PATH: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/cae7e4dd_5dc5ee91 PS20, Line 157: Command line: c++ /home/sean/Documents/gerrit/coreboot/util/coreboot-configurator/obj-x86_64-linux-gnu/meson-private/tmph5nfr_d_/testfile.cpp -o /home/sean/Documents/gerrit/coreboot/util/coreboot-configurator/obj-x86_64-linux-gnu/meson-private/tmph5nfr_d_/output.exe -pipe -g -O2 -ffile-prefix-map=/home/sean/Documents/gerrit/coreboot/util/coreboot-configurator=. -flto=auto -ffat-lto-objects -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -D_FILE_OFFSET_BITS=64 -O0 -fpermissive -Wl,-Bsymbolic-functions -Wl,-z,relro trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/5bd642ba_72899f02 PS20, Line 161: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/cb55f6c6_061a4eeb PS20, Line 167: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/d9c3be2b_414ba69e PS20, Line 169: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/86fdff6b_0e11ddd5 PS20, Line 179: Command line: c++ /home/sean/Documents/gerrit/coreboot/util/coreboot-configurator/obj-x86_64-linux-gnu/meson-private/tmp8dng8htx/testfile.cpp -o /home/sean/Documents/gerrit/coreboot/util/coreboot-configurator/obj-x86_64-linux-gnu/meson-private/tmp8dng8htx/output.obj -pipe -c -g -O2 -ffile-prefix-map=/home/sean/Documents/gerrit/coreboot/util/coreboot-configurator=. -flto=auto -ffat-lto-objects -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -D_FILE_OFFSET_BITS=64 -O0 -fpermissive --print-search-dirs trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/a9d6b090_cfa8aa8e PS20, Line 182: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/35586590_65fa845c PS20, Line 189: trailing whitespace File util/coreboot-configurator/src/application/aboutwindow.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/61f49e8d_c54d0948 PS20, Line 16: public: spaces required around that ':' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/9c2453aa_aa930dae PS20, Line 17: explicit aboutWindow(QWidget *parent = nullptr); need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/9ee18736_891896dd PS20, Line 21: Ui::aboutWindow *ui; need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/f51a2fce_d8d59e96 PS20, Line 21: Ui::aboutWindow *ui; labels should not be indented File util/coreboot-configurator/src/application/categories.yaml: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/a11b7e8b_a6e84197 PS20, Line 84: help: Adjust the amout of time before the keyboard backlight turns off when un-used 'amout' may be misspelled - perhaps 'amount'? File util/coreboot-configurator/src/application/configuration.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/e82d2f6c_fd2397fb PS20, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/b6635c8c_81249548 PS20, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/6c7a2362_d3b684c4 PS20, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/c1df9f47_e7823631 PS20, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/34d387e7_ba39dcc8 PS20, Line 15: QMap<QString,QString> fromNvramTool(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/876d5a1e_3878ce1e PS20, Line 15: QMap<QString,QString> fromNvramTool(); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/ed22bbd0_73bccbbd PS20, Line 15: QMap<QString,QString> fromNvramTool(); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/b7b9929d_1eeee485 PS20, Line 17: QMap<QString,QString> mocked(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/ade8a663_c51e1eb5 PS20, Line 17: QMap<QString,QString> mocked(); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/6f5b58fc_201ae41d PS20, Line 17: QMap<QString,QString> mocked(); spaces required around that '>' (ctx:VxW) File util/coreboot-configurator/src/application/coreboot_configurator.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/e9306ec6_a70df7d8 PS20, Line 29: public: spaces required around that ':' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/5e4c2d70_e2a1a0af PS20, Line 30: coreboot_configurator(QWidget *parent = nullptr); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/aef9fa0d_52e6e0f1 PS20, Line 30: coreboot_configurator(QWidget *parent = nullptr); need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/9d9c3df1_cc38bd3d PS20, Line 37: void showEvent(QShowEvent *ev); need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/32d3b1a8_4776b16c PS20, Line 48: void displaySettings(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/c8c07494_6d92393e PS20, Line 48: void displaySettings(); Bad function definition - void displaySettings() should probably be void displaySettings(void) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/ca689c76_0df0e09d PS20, Line 52: void writeToFile(const QString& out_file); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/c90b66a2_96e57a1e PS20, Line 52: void writeToFile(const QString& out_file); need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/305ff8ab_f14807f2 PS20, Line 55: void updateValue(const QString& name); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/b34e3ee6_0379cc8b PS20, Line 55: void updateValue(const QString& name); need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/31cac6b6_ca2dd173 PS20, Line 59: QString m_fileName; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/084aedca_532a9649 PS20, Line 61: QMap<QString, QString> m_values; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/2f5e10c8_bc333323 PS20, Line 61: QMap<QString, QString> m_values; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/9c61b247_32a46e83 PS20, Line 61: QMap<QString, QString> m_values; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/1bd7d4ca_a19b0852 PS20, Line 64: QMap<QString, QVBoxLayout*> m_tabs; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/adb199c5_920f6b31 PS20, Line 64: QMap<QString, QVBoxLayout*> m_tabs; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/a722d10e_a209e247 PS20, Line 64: QMap<QString, QVBoxLayout*> m_tabs; spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/c6fe45d3_899a061e PS20, Line 67: YAML::Node m_categories; labels should not be indented Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/af342db4_5457e2cb PS20, Line 70: QComboBox *textToDisplay(const QString &in_string); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/c83a1314_b736eedc PS20, Line 70: QComboBox *textToDisplay(const QString &in_string); need consistent spacing around '&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/20f8c084_de6263d9 PS20, Line 71: QCheckBox *checkToDisplay(const QString &in_string); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/d025b380_a7601089 PS20, Line 71: QCheckBox *checkToDisplay(const QString &in_string); need consistent spacing around '&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/2f7cd6d3_555d1ffb PS20, Line 73: Ui::coreboot_configurator *ui; need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/601fc2c1_81870d7a PS20, Line 73: Ui::coreboot_configurator *ui; labels should not be indented File util/coreboot-configurator/src/application/coreboot_configurator.cpp: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/9b296bb8_7a9f907b PS20, Line 25: static auto s_errorWindowTitle = "Error Occured"; 'Occured' may be misspelled - perhaps 'Occurred'? Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/82da9209_992d0224 PS20, Line 207: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/471247f1_8795593b PS20, Line 413: QMessageBox::critical(this, "Error Occured", "Can't open file to write"); 'Occured' may be misspelled - perhaps 'Occurred'? File util/coreboot-configurator/src/application/qtyaml.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/ca8659d9_d84b516c PS20, Line 30: template<> spaces required around that '<' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/c6161a3f_a49bfc40 PS20, Line 30: template<> spaces required around that '>' (ctx:OxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/1331e39a_bbba36bc PS20, Line 31: struct convert<QString> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/e118ad05_3522f029 PS20, Line 31: struct convert<QString> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/97fefd72_b09c5dff PS20, Line 33: static Node encode(const QString& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/b53d4c77_38b4b757 PS20, Line 33: static Node encode(const QString& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/ccb308da_b0bb2221 PS20, Line 33: static Node encode(const QString& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/50df73c3_9b34b914 PS20, Line 34: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/602694b9_aa83e412 PS20, Line 35: return Node(rhs.toStdString()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/1a284108_97d8cd72 PS20, Line 35: return Node(rhs.toStdString()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/25dcffff_d0d3a859 PS20, Line 36: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/7bd47959_84a12fb1 PS20, Line 38: static bool decode(const Node& node, QString& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/5b6589a4_443c4c6c PS20, Line 38: static bool decode(const Node& node, QString& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/d8556575_175daf84 PS20, Line 38: static bool decode(const Node& node, QString& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/5b74e40a_b29fb1c5 PS20, Line 38: static bool decode(const Node& node, QString& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/5b73f53a_278a621c PS20, Line 39: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/fe181bac_2477a350 PS20, Line 40: if (!node.IsScalar()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/0d823aa1_62378778 PS20, Line 40: if (!node.IsScalar()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/5f2b3739_8830b94c PS20, Line 40: if (!node.IsScalar()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/c753209e_79f3a57c PS20, Line 41: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/1f23a2d1_fc101eb1 PS20, Line 41: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/2a852bc1_1a71ffcc PS20, Line 42: rhs = QString::fromStdString(node.Scalar()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/9decb6bf_8f8c17ae PS20, Line 42: rhs = QString::fromStdString(node.Scalar()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/b48e54cf_c5112993 PS20, Line 43: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/99d0011f_638059c3 PS20, Line 43: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/a9a3eddf_3063451a PS20, Line 44: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/c0005e92_30dd0119 PS20, Line 48: template<typename Key, typename Value> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/ccf4be4e_558197d7 PS20, Line 48: template<typename Key, typename Value> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/ecc3c04b_5371ff58 PS20, Line 49: struct convert<QMap<Key, Value> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/eb24b579_509fe335 PS20, Line 49: struct convert<QMap<Key, Value> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/651289ad_9b5aec9f PS20, Line 49: struct convert<QMap<Key, Value> > spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/d94b0472_4099dfb8 PS20, Line 51: static Node encode(const QMap<Key,Value>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/25f62453_1ff2fd8a PS20, Line 51: static Node encode(const QMap<Key,Value>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/fa121c5d_351e2c6c PS20, Line 51: static Node encode(const QMap<Key,Value>& rhs) space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/b2b99f18_20c8c89d PS20, Line 51: static Node encode(const QMap<Key,Value>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/a8137132_501ef2cc PS20, Line 51: static Node encode(const QMap<Key,Value>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/d22cc2ba_bfba393f PS20, Line 51: static Node encode(const QMap<Key,Value>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/8ffdc416_ed688306 PS20, Line 51: static Node encode(const QMap<Key,Value>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/65aee7df_9fd7d811 PS20, Line 52: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/b7e05fe7_077af571 PS20, Line 53: Node node(NodeType::Map); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/1dd6a2cc_bef8d8aa PS20, Line 53: Node node(NodeType::Map); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/e2ce4588_9679de84 PS20, Line 54: auto it = rhs.constBegin(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/feef0c48_a5eef723 PS20, Line 54: auto it = rhs.constBegin(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/63207dcc_add7f88f PS20, Line 55: while (it != rhs.constEnd()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/54cbc71b_93692aa2 PS20, Line 55: while (it != rhs.constEnd()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/04531b34_f5817e74 PS20, Line 55: while (it != rhs.constEnd()) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/4a1f3707_defa4d54 PS20, Line 55: while (it != rhs.constEnd()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/39ea04fe_155a1cee PS20, Line 56: { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/1c0e6183_a643d61c PS20, Line 56: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/06aa79d7_9a76f9cf PS20, Line 57: node.force_insert(it.key(), it.value()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/4ae16d56_4181e0da PS20, Line 57: node.force_insert(it.key(), it.value()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/3fb4d9db_48cc076b PS20, Line 58: ++it; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/2a9e04ad_e6b52d29 PS20, Line 58: ++it; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/236e337c_3ae3217c PS20, Line 59: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/031f562f_a5f88ebd PS20, Line 59: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/8b0c4c1a_c11ccdfb PS20, Line 60: return node; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/bb7f060d_235e5a71 PS20, Line 60: return node; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/4557744b_f33750b1 PS20, Line 61: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/d7ea5d27_8cdd49a3 PS20, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/649e47d3_0f1c5f95 PS20, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/9705435f_4e2380fb PS20, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/2a3392ff_5340b059 PS20, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/3513ba0f_15650070 PS20, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/f5155895_d12b7332 PS20, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/f93bfd66_0c5fb2f1 PS20, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/20de607e_c59efa03 PS20, Line 64: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/3a49ef93_7f9bf83f PS20, Line 65: if (!node.IsMap()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/602915fa_18625bf8 PS20, Line 65: if (!node.IsMap()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/a5a2d2b8_a90e1d8e PS20, Line 65: if (!node.IsMap()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/e7322d31_becc7d53 PS20, Line 66: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/a1c36c0c_945a772b PS20, Line 66: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/12bfa88e_c7411e6d PS20, Line 68: rhs.clear(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/aea7c339_36e82815 PS20, Line 68: rhs.clear(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/56165d4c_4f45d26b PS20, Line 69: const_iterator it = node.begin(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/ae40cf27_11a92b49 PS20, Line 69: const_iterator it = node.begin(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/f35de309_714627c0 PS20, Line 70: while (it != node.end()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/4d210985_16f0a164 PS20, Line 70: while (it != node.end()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/2f6cc3d4_b95b427e PS20, Line 70: while (it != node.end()) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/fa838332_185d8966 PS20, Line 70: while (it != node.end()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/41abd37f_8eea7e65 PS20, Line 71: { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/f8b68c2a_08cb778a PS20, Line 71: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/cdff8a29_c370488d PS20, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/9c23144e_0b8955c7 PS20, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/0b10cf2a_2887b3aa PS20, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/adb7f793_20bf7242 PS20, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/93445607_fb6a51ce PS20, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/f76ee023_7ac57077 PS20, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/773a77f6_0652c937 PS20, Line 73: ++it; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/2c6bf312_c7d2c204 PS20, Line 73: ++it; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/fa8c444a_0caf1280 PS20, Line 74: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/64fa5782_31390a2a PS20, Line 74: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/cf61069d_155b5efc PS20, Line 75: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/7d740d25_4da290c6 PS20, Line 75: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/f39a7b61_d7cc85aa PS20, Line 76: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/62223e57_639d1dba PS20, Line 80: template<typename T> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/c6ba039f_c4b17a76 PS20, Line 80: template<typename T> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/1c89e1c3_39c7382a PS20, Line 81: struct convert<QVector<T> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/ba2e1393_fde43085 PS20, Line 81: struct convert<QVector<T> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/67c165f3_091bc4fd PS20, Line 81: struct convert<QVector<T> > spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/842ad27b_50f3dbb8 PS20, Line 83: static Node encode(const QVector<T>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/0c3b2790_dc86ec86 PS20, Line 83: static Node encode(const QVector<T>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/b00cf2d9_6a2bcc36 PS20, Line 83: static Node encode(const QVector<T>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/f1915ea7_a3739c97 PS20, Line 83: static Node encode(const QVector<T>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/81cd6ea5_bf831ba5 PS20, Line 83: static Node encode(const QVector<T>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/abeaf498_db6e2c43 PS20, Line 83: static Node encode(const QVector<T>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/b1bd50ae_32414f04 PS20, Line 84: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/14a0426f_c2813b76 PS20, Line 85: Node node(NodeType::Sequence); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/098081fa_1260aaf7 PS20, Line 85: Node node(NodeType::Sequence); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/482702c5_6a70b2e7 PS20, Line 86: foreach (T value, rhs) { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/3b03a752_b6e60bf8 PS20, Line 86: foreach (T value, rhs) { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/929cf5fd_903db172 PS20, Line 86: foreach (T value, rhs) { space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/bb059a2b_02a84b85 PS20, Line 87: node.push_back(value); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/c69f1f64_6538cbbe PS20, Line 87: node.push_back(value); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/4b7decca_29b64129 PS20, Line 88: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/3c393eec_eaec9a2c PS20, Line 88: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/0974d7a3_90ffa77c PS20, Line 89: return node; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/14f5cdd7_5b5add26 PS20, Line 89: return node; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/8625c937_38876af0 PS20, Line 90: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/2d4bec96_f5ddd43c PS20, Line 92: static bool decode(const Node& node, QVector<T>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/d02b4fce_47d88767 PS20, Line 92: static bool decode(const Node& node, QVector<T>& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/9f9e1ec1_c78b685f PS20, Line 92: static bool decode(const Node& node, QVector<T>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/c6d3b63f_245bb1c4 PS20, Line 92: static bool decode(const Node& node, QVector<T>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/d45ab1c9_a14f3ca2 PS20, Line 92: static bool decode(const Node& node, QVector<T>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/abfb8254_f0a49ccf PS20, Line 92: static bool decode(const Node& node, QVector<T>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/bad2ae66_a8941fd7 PS20, Line 92: static bool decode(const Node& node, QVector<T>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/cec15dd8_c146e11c PS20, Line 93: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/b4e1afc2_6c6272e4 PS20, Line 94: if (!node.IsSequence()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/050db54c_8377c305 PS20, Line 94: if (!node.IsSequence()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/4c28a871_149f52d8 PS20, Line 94: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/a4f60c31_7fc1b3c1 PS20, Line 95: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/4cda8288_51ea5033 PS20, Line 95: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/f6dcba24_97b22797 PS20, Line 97: rhs.clear(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/560d6034_909a994a PS20, Line 97: rhs.clear(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/5eb586d2_ea04478c PS20, Line 98: const_iterator it = node.begin(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/2f1c47db_a16e1430 PS20, Line 98: const_iterator it = node.begin(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/0d217f44_d136d05b PS20, Line 99: while (it != node.end()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/b2d76e33_df764aea PS20, Line 99: while (it != node.end()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/f203c389_5d3de0c2 PS20, Line 99: while (it != node.end()) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/211d07ac_8227ce38 PS20, Line 99: while (it != node.end()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/2af4008b_8a40835a PS20, Line 100: { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/10f9c1e6_077f767c PS20, Line 100: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/9fc14576_393359d4 PS20, Line 101: rhs.push_back(it->as<T>()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/08756c66_cd7a5cb4 PS20, Line 101: rhs.push_back(it->as<T>()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/af031e3f_edfdcf67 PS20, Line 101: rhs.push_back(it->as<T>()); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/63044ac5_2f1dc45a PS20, Line 101: rhs.push_back(it->as<T>()); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/00b35e6d_4d6f8f82 PS20, Line 102: ++it; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/2a5ffedc_33eea4ac PS20, Line 102: ++it; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/60d5bb91_6ef1e68f PS20, Line 103: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/7aaaa077_0c385262 PS20, Line 103: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/b0c3ed2a_7572ea83 PS20, Line 104: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/eeb0894b_e1192496 PS20, Line 104: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/f5c90980_044aa96a PS20, Line 105: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/60a21925_1549647a PS20, Line 109: template<typename T> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/f4209d2c_da1ee36f PS20, Line 109: template<typename T> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/cbd9bead_7d331e67 PS20, Line 110: struct convert<QList<T> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/037d4522_a04f03a0 PS20, Line 110: struct convert<QList<T> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/f91fa718_ecf8b351 PS20, Line 110: struct convert<QList<T> > spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/8009a8e9_92546c00 PS20, Line 112: static Node encode(const QList<T>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/ca88862c_0df60e0b PS20, Line 112: static Node encode(const QList<T>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/6ee84703_f2f529b6 PS20, Line 112: static Node encode(const QList<T>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/827dcb8b_9bbf730f PS20, Line 112: static Node encode(const QList<T>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/f3a5c1d0_dc4cb5fb PS20, Line 112: static Node encode(const QList<T>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/e9799d48_aa8d6c24 PS20, Line 112: static Node encode(const QList<T>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/df25dc94_64a05bd1 PS20, Line 113: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/d7d33cc8_84cfacb5 PS20, Line 114: Node node(NodeType::Sequence); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/43416fdd_64dcc5af PS20, Line 114: Node node(NodeType::Sequence); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/0cef94b6_7b5bb180 PS20, Line 115: foreach (T value, rhs) { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/33e275a9_96a312ff PS20, Line 115: foreach (T value, rhs) { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/8f2ef7e2_8e346fe1 PS20, Line 115: foreach (T value, rhs) { space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/4059dfae_215d07e5 PS20, Line 116: node.push_back(value); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/6cafa5d5_d6c43440 PS20, Line 116: node.push_back(value); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/200e5eea_bdd4563f PS20, Line 117: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/e6238242_d64ef474 PS20, Line 117: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/6f2c4478_36d508fa PS20, Line 118: return node; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/b96cd4d9_56811fd0 PS20, Line 118: return node; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/21b4ee24_ec6eeaf3 PS20, Line 119: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/720aa35c_e799811f PS20, Line 121: static bool decode(const Node& node, QList<T>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/88c01283_f4d3502c PS20, Line 121: static bool decode(const Node& node, QList<T>& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/504227f4_785bcb31 PS20, Line 121: static bool decode(const Node& node, QList<T>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/3719f2b6_e8cea1b6 PS20, Line 121: static bool decode(const Node& node, QList<T>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/95a5e654_aa483757 PS20, Line 121: static bool decode(const Node& node, QList<T>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/82eb7a35_4601efef PS20, Line 121: static bool decode(const Node& node, QList<T>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/1369f211_fc762573 PS20, Line 121: static bool decode(const Node& node, QList<T>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/5f8834e3_9b9d4840 PS20, Line 122: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/ff6ff3c7_443c3a3d PS20, Line 123: if (!node.IsSequence()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/48500d20_55cd36e2 PS20, Line 123: if (!node.IsSequence()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/f2b63077_fde6fe21 PS20, Line 123: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/dd8f5efa_4baef09c PS20, Line 124: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/e4f4323b_f4520109 PS20, Line 124: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/1092a053_d340b266 PS20, Line 126: rhs.clear(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/fcdb7c20_52b96a21 PS20, Line 126: rhs.clear(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/43e501c8_6b7af385 PS20, Line 127: const_iterator it = node.begin(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/2a63df27_ca533dc9 PS20, Line 127: const_iterator it = node.begin(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/36a3de8c_b929a441 PS20, Line 128: while (it != node.end()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/cdc4ea02_da2cc721 PS20, Line 128: while (it != node.end()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/66d41acd_d2c2bd74 PS20, Line 128: while (it != node.end()) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/e1064f71_10b4965a PS20, Line 128: while (it != node.end()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/f5bf598f_00507bce PS20, Line 129: { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/ce4a2429_4b432c7e PS20, Line 129: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/5d2dba64_f7737d74 PS20, Line 130: rhs.push_back(it->as<T>()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/8ae084e4_5f188735 PS20, Line 130: rhs.push_back(it->as<T>()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/259ab38a_9533dd3c PS20, Line 130: rhs.push_back(it->as<T>()); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/8c5b7bb4_42b91eed PS20, Line 130: rhs.push_back(it->as<T>()); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/f6370070_75ce8003 PS20, Line 131: ++it; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/af78de69_6a77dcc6 PS20, Line 131: ++it; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/61247ff6_c61c9d90 PS20, Line 132: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/e6fbf306_58e9c26c PS20, Line 132: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/dfdb6ab9_7fa8ddf7 PS20, Line 133: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/549c8160_974d4089 PS20, Line 133: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/3b9730d6_0dcab98b PS20, Line 134: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/076a15f5_f07c037d PS20, Line 138: template<typename T, typename U> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/1532ff87_05e59672 PS20, Line 138: template<typename T, typename U> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/f9ebfc4c_83e93d85 PS20, Line 139: struct convert<QPair<T,U> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/2bb82fd2_f5b944f5 PS20, Line 139: struct convert<QPair<T,U> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/b64c92c9_6f038fda PS20, Line 139: struct convert<QPair<T,U> > space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/f6a8f883_f7511760 PS20, Line 139: struct convert<QPair<T,U> > spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/4bf0b3a8_2c6a8cc9 PS20, Line 141: static Node encode(const QPair<T,U>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/151c737e_ae9b3cad PS20, Line 141: static Node encode(const QPair<T,U>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/b457e1d3_e8edb3c5 PS20, Line 141: static Node encode(const QPair<T,U>& rhs) space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/057eac85_267dc9e9 PS20, Line 141: static Node encode(const QPair<T,U>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/324bba89_36819041 PS20, Line 141: static Node encode(const QPair<T,U>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/5f708b6d_bc189b4c PS20, Line 141: static Node encode(const QPair<T,U>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/9eb34f4b_9f5660fc PS20, Line 141: static Node encode(const QPair<T,U>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/20cffe4b_de7a1c36 PS20, Line 142: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/aa4c5373_686d4b9a PS20, Line 143: Node node(NodeType::Sequence); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/a1d7f966_b6a29fe0 PS20, Line 143: Node node(NodeType::Sequence); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/a971c10e_fd8213f8 PS20, Line 144: node.push_back(rhs.first); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/5b77b5f4_1d44f482 PS20, Line 144: node.push_back(rhs.first); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/76f494f4_53846331 PS20, Line 145: node.push_back(rhs.second); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/187ad05f_32d327da PS20, Line 145: node.push_back(rhs.second); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/1a3ba8b7_3630b911 PS20, Line 146: return node; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/4e64539c_fc42e2b9 PS20, Line 146: return node; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/881310e4_292eca6f PS20, Line 147: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/686eca2d_0160963a PS20, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/65a398be_f35f9860 PS20, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/a4cbd4da_fc277c5f PS20, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/e5641d78_efca9014 PS20, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/77978672_72d6e2b7 PS20, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/3d441806_35be224c PS20, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/4ee71c2e_6d4812de PS20, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/b574fbb4_82dd9a05 PS20, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/fa94c6ff_4e01a93d PS20, Line 150: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/89e2655a_626d4050 PS20, Line 151: if (!node.IsSequence()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/f446f164_c6b93f43 PS20, Line 151: if (!node.IsSequence()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/2d1f3d58_5e5c0c8d PS20, Line 151: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/ca70bc0b_3746b476 PS20, Line 152: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/12021470_a1c5ef07 PS20, Line 152: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/84ac420a_79fb9cef PS20, Line 153: if (node.size() != 2) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/2158d4de_caea4bca PS20, Line 153: if (node.size() != 2) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/e9962042_1ff471d4 PS20, Line 153: if (node.size() != 2) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/7ab43175_e7f427bb PS20, Line 154: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/7a0e6cfb_47ca726d PS20, Line 154: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/96a6b5df_9729a625 PS20, Line 156: rhs.first = node[0].as<T>(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/3ab8ca65_e039000b PS20, Line 156: rhs.first = node[0].as<T>(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/8426fc4c_7b0eac46 PS20, Line 156: rhs.first = node[0].as<T>(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/5571095b_9244bc0b PS20, Line 156: rhs.first = node[0].as<T>(); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/09b21bd5_29f9d4dd PS20, Line 157: rhs.second = node[1].as(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/6228cc6c_4711d0f7 PS20, Line 157: rhs.second = node[1].as(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/aebb9346_52ae5093 PS20, Line 157: rhs.second = node[1].as(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/72677a22_69f09edd PS20, Line 157: rhs.second = node[1].as(); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/c1fe16c2_a35f63d7 PS20, Line 158: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/5d2c1c1c_2cda7ff3 PS20, Line 158: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/f9e99abd_180966d1 PS20, Line 159: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/1828277b_167fcf68 PS20, Line 163: template<> spaces required around that '<' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/a8e5a26b_48d71bdc PS20, Line 163: template<> spaces required around that '>' (ctx:OxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/74dd3de1_d2eafd09 PS20, Line 164: struct convert<QStringList> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/e395dabc_95a97ddf PS20, Line 164: struct convert<QStringList> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/d677759a_3973dbc9 PS20, Line 166: static Node encode(const QStringList& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/5827f182_9ee3c647 PS20, Line 166: static Node encode(const QStringList& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/ff241c78_355eb7c2 PS20, Line 166: static Node encode(const QStringList& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/db9d738c_c23ddb1e PS20, Line 167: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/6a53a76b_49a4f5af PS20, Line 168: Node node(NodeType::Sequence); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/05e51102_1bc1bc84 PS20, Line 168: Node node(NodeType::Sequence); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/62148830_912f2fc1 PS20, Line 169: for (const auto &value: rhs) { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/79f6170e_8a5d75a5 PS20, Line 169: for (const auto &value: rhs) { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/6fc48d69_66c90720 PS20, Line 169: for (const auto &value: rhs) { suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/5d5523ab_709aff6c PS20, Line 169: for (const auto &value: rhs) { need consistent spacing around '&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/0e38d3ac_8ddf7007 PS20, Line 169: for (const auto &value: rhs) { spaces required around that ':' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/ec6e3b03_7df6913d PS20, Line 169: for (const auto &value: rhs) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/de67daa3_536cff87 PS20, Line 170: node.push_back(value); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/a37ec8c6_93dc9cbd PS20, Line 170: node.push_back(value); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/4ff76156_92669618 PS20, Line 171: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/7ef6e66d_e607c0de PS20, Line 171: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/6b61ba1a_f2a3fc91 PS20, Line 172: return node; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/bdb1c35c_c9f0c247 PS20, Line 172: return node; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/e8a2b1a7_98dec32d PS20, Line 173: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/daa28435_dcdea975 PS20, Line 175: static bool decode(const Node& node, QStringList& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/51a7347f_492811d0 PS20, Line 175: static bool decode(const Node& node, QStringList& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/1d117d0e_ec080567 PS20, Line 175: static bool decode(const Node& node, QStringList& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/6b527968_da6d19a8 PS20, Line 175: static bool decode(const Node& node, QStringList& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/6cbe88bb_bfad1e54 PS20, Line 176: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/c9a08db8_442b5527 PS20, Line 177: if (!node.IsSequence()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/c87364a6_f6b9d5a9 PS20, Line 177: if (!node.IsSequence()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/5769b670_44f478a4 PS20, Line 177: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/1d2c0f67_dbc3bb99 PS20, Line 178: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/4df9ce7c_cfded5f9 PS20, Line 178: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/cc353228_77debaef PS20, Line 180: rhs.clear(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/2df06fd9_1bd84132 PS20, Line 180: rhs.clear(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/0224d6aa_53cb85d7 PS20, Line 181: const_iterator it = node.begin(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/63be89ce_d7da2afe PS20, Line 181: const_iterator it = node.begin(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/627b3d74_2518497f PS20, Line 182: while (it != node.end()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/3ba46ea5_4daae872 PS20, Line 182: while (it != node.end()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/a42a43c0_f7328774 PS20, Line 182: while (it != node.end()) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/d668fcfe_96acd574 PS20, Line 182: while (it != node.end()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/c9506fd0_a85f12af PS20, Line 183: { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/6580be79_eeb035a2 PS20, Line 183: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/77b97bde_39d435eb PS20, Line 184: rhs.push_back(it->as<QString>()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/76b666b4_7aaadef7 PS20, Line 184: rhs.push_back(it->as<QString>()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/02af3d6a_db21ae04 PS20, Line 184: rhs.push_back(it->as<QString>()); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/dd899dc0_f4414253 PS20, Line 184: rhs.push_back(it->as<QString>()); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/ea989a87_02deb6fb PS20, Line 185: ++it; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/e83bb037_d94748eb PS20, Line 185: ++it; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/9cc0bd48_1a6df38a PS20, Line 186: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/fe2f01f5_39bf7fde PS20, Line 186: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/67eca69a_23375fe4 PS20, Line 187: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/54b44953_aaa11bf4 PS20, Line 187: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/086f00a7_d961603c PS20, Line 188: } please, no spaces at the start of a line File util/coreboot-configurator/src/application/toggleswitch.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/cc79e118_786edba1 PS20, Line 9: /// \brief The ToggleSwitch class represents Toggle Switch widget based on QCheckBox and toggles svg with colorscheme support line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/d5772020_b1344eba PS20, Line 12: Q_OBJECT please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/666376d9_90dce83b PS20, Line 13: public: spaces required around that ':' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/203a6054_5b904c1e PS20, Line 14: explicit ToggleSwitch(QWidget* parent = nullptr); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/062806b6_c12ebd04 PS20, Line 14: explicit ToggleSwitch(QWidget* parent = nullptr); need consistent spacing around '*' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/3c567174_b69ebbce PS20, Line 17: QSvgRenderer m_svgr; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/733ea58d_bbacf29e PS20, Line 19: static const QByteArray s_toggleOnSvgContent; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/596a484c_b21eec2c PS20, Line 20: static const QByteArray s_toggleOffSvgContent; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/d67dd0f4_bf0e7ad7 PS20, Line 22: void recolorToggleOn(const QPalette& palette); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/091d0a1d_b6888d20 PS20, Line 22: void recolorToggleOn(const QPalette& palette); need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/c69d622b_b94bc9f5 PS20, Line 23: QByteArray m_toggleOnSvgContentColored; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/aee97ef7_353b5def PS20, Line 27: void paintEvent(QPaintEvent *event) override; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/964e1085_dd7d1fcc PS20, Line 27: void paintEvent(QPaintEvent *event) override; need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/13af89e1_dfc1e15e PS20, Line 31: bool hitButton(const QPoint &pos) const override please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/a4391415_6b60cfd0 PS20, Line 31: bool hitButton(const QPoint &pos) const override need consistent spacing around '&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/0c7940d4_7a53c404 PS20, Line 32: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/6e45907d_8d1d6b72 PS20, Line 33: //needs to be clickable on code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/587a0272_f0fa51ab PS20, Line 34: return rect().contains(pos); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/6f76525d_8ef40f17 PS20, Line 34: return rect().contains(pos); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132346): https://review.coreboot.org/c/coreboot/+/58854/comment/565b9604_b41805d0 PS20, Line 35: } please, no spaces at the start of a line -- To view, visit https://review.coreboot.org/c/coreboot/+/58854 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie654f6aca57a792be0c295afc081a95ed4d875d1 Gerrit-Change-Number: 58854 Gerrit-PatchSet: 20 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com> Gerrit-Comment-Date: Thu, 04 Nov 2021 22:21:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [WIP] util: Add coreboot Configurator
by Sean Rhodes (Code Review) 04 Nov '21

04 Nov '21

Attention is currently required from: Sean Rhodes, Martin Roth, Tim Wawrzynczak, Angel Pons. Hello build bot (Jenkins), Martin Roth, Tim Wawrzynczak, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/58854 to look at the new patch set (#20). Change subject: [WIP] util: Add coreboot Configurator ...................................................................... [WIP] util: Add coreboot Configurator A simply GUI to change settings in coreboot's CBFS, via the nvramtool utility. Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: Ie654f6aca57a792be0c295afc081a95ed4d875d1 --- A util/coreboot-configurator/README.md A util/coreboot-configurator/contrib/PKGBUILD A util/coreboot-configurator/contrib/README.md A util/coreboot-configurator/contrib/debian/changelog A util/coreboot-configurator/contrib/debian/compat A util/coreboot-configurator/contrib/debian/control A util/coreboot-configurator/contrib/debian/files A util/coreboot-configurator/contrib/debian/rules A util/coreboot-configurator/contrib/debian/source/format A util/coreboot-configurator/contrib/flatpak/coreboot-configurator.json A util/coreboot-configurator/contrib/flatpak/org.coreboot.coreboot-configurator.json A util/coreboot-configurator/meson.build A util/coreboot-configurator/meson_options.txt A util/coreboot-configurator/obj-x86_64-linux-gnu/meson-info/meson-info.json A util/coreboot-configurator/obj-x86_64-linux-gnu/meson-logs/meson-log.txt A util/coreboot-configurator/obj-x86_64-linux-gnu/meson-private/meson.lock A util/coreboot-configurator/obj-x86_64-linux-gnu/meson-private/sanitycheckcpp.cc A util/coreboot-configurator/obj-x86_64-linux-gnu/meson-private/sanitycheckcpp.exe A util/coreboot-configurator/screenshots/coreboot-configurator.gif A util/coreboot-configurator/screenshots/coreboot-configurator.png A util/coreboot-configurator/src/application/aboutwindow.cpp A util/coreboot-configurator/src/application/aboutwindow.h A util/coreboot-configurator/src/application/aboutwindow.ui A util/coreboot-configurator/src/application/categories.yaml A util/coreboot-configurator/src/application/configuration.cpp A util/coreboot-configurator/src/application/configuration.h A util/coreboot-configurator/src/application/coreboot_configurator.cpp A util/coreboot-configurator/src/application/coreboot_configurator.h A util/coreboot-configurator/src/application/coreboot_configurator.ui A util/coreboot-configurator/src/application/images.qrc A util/coreboot-configurator/src/application/main.cpp A util/coreboot-configurator/src/application/meson.build A util/coreboot-configurator/src/application/qtyaml.h A util/coreboot-configurator/src/application/toggle-off.svg A util/coreboot-configurator/src/application/toggle-on.svg A util/coreboot-configurator/src/application/toggleswitch.cpp A util/coreboot-configurator/src/application/toggleswitch.h A util/coreboot-configurator/src/meson.build A util/coreboot-configurator/src/static/aboutIcon.png A util/coreboot-configurator/src/static/coreboot-configurator.desktop A util/coreboot-configurator/src/static/coreboot_configurator.svg A util/coreboot-configurator/src/static/meson.build A util/coreboot-configurator/src/static/org.coreboot.nvramtool.policy A util/coreboot-configurator/src/static/org.coreboot.reboot.policy 44 files changed, 3,197 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/58854/20 -- To view, visit https://review.coreboot.org/c/coreboot/+/58854 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie654f6aca57a792be0c295afc081a95ed4d875d1 Gerrit-Change-Number: 58854 Gerrit-PatchSet: 20 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: [WIP] util: Add coreboot Configurator
by build bot (Jenkins) (Code Review) 04 Nov '21

04 Nov '21

1 0

Change in coreboot[master]: [WIP] util: Add coreboot Configurator
by Sean Rhodes (Code Review) 04 Nov '21

04 Nov '21

Attention is currently required from: Sean Rhodes, Martin Roth, Tim Wawrzynczak, Angel Pons. Hello build bot (Jenkins), Martin Roth, Tim Wawrzynczak, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/58854 to look at the new patch set (#19). Change subject: [WIP] util: Add coreboot Configurator ...................................................................... [WIP] util: Add coreboot Configurator A simply GUI to change settings in coreboot's CBFS, via the nvramtool utility. Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: Ie654f6aca57a792be0c295afc081a95ed4d875d1 --- A util/coreboot-configurator/README.md A util/coreboot-configurator/contrib/PKGBUILD A util/coreboot-configurator/contrib/README.md A util/coreboot-configurator/contrib/debian/changelog A util/coreboot-configurator/contrib/debian/compat A util/coreboot-configurator/contrib/debian/control A util/coreboot-configurator/contrib/debian/copyright A util/coreboot-configurator/contrib/debian/files A util/coreboot-configurator/contrib/debian/rules A util/coreboot-configurator/contrib/debian/source/format A util/coreboot-configurator/contrib/flatpak/coreboot-configurator.json A util/coreboot-configurator/contrib/flatpak/org.coreboot.coreboot-configurator.json A util/coreboot-configurator/meson.build A util/coreboot-configurator/meson_options.txt A util/coreboot-configurator/screenshots/coreboot-configurator.gif A util/coreboot-configurator/screenshots/coreboot-configurator.png A util/coreboot-configurator/src/Documentation.txt A util/coreboot-configurator/src/application/aboutwindow.cpp A util/coreboot-configurator/src/application/aboutwindow.h A util/coreboot-configurator/src/application/aboutwindow.ui A util/coreboot-configurator/src/application/categories.yaml A util/coreboot-configurator/src/application/configuration.cpp A util/coreboot-configurator/src/application/configuration.h A util/coreboot-configurator/src/application/coreboot_configurator.cpp A util/coreboot-configurator/src/application/coreboot_configurator.h A util/coreboot-configurator/src/application/coreboot_configurator.ui A util/coreboot-configurator/src/application/images.qrc A util/coreboot-configurator/src/application/main.cpp A util/coreboot-configurator/src/application/meson.build A util/coreboot-configurator/src/application/qtyaml.h A util/coreboot-configurator/src/application/toggle-off.svg A util/coreboot-configurator/src/application/toggle-on.svg A util/coreboot-configurator/src/meson.build A util/coreboot-configurator/src/static/aboutIcon.png A util/coreboot-configurator/src/static/coreboot-configurator.desktop A util/coreboot-configurator/src/static/coreboot_configurator.svg A util/coreboot-configurator/src/static/meson.build A util/coreboot-configurator/src/static/org.coreboot.nvramtool.policy A util/coreboot-configurator/src/static/org.coreboot.reboot.policy 39 files changed, 2,927 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/58854/19 -- To view, visit https://review.coreboot.org/c/coreboot/+/58854 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie654f6aca57a792be0c295afc081a95ed4d875d1 Gerrit-Change-Number: 58854 Gerrit-PatchSet: 19 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: [WIP] util: Add coreboot Configurator
by build bot (Jenkins) (Code Review) 04 Nov '21

04 Nov '21

Attention is currently required from: Sean Rhodes, Martin Roth, Tim Wawrzynczak, Angel Pons. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58854 ) Change subject: [WIP] util: Add coreboot Configurator ...................................................................... Patch Set 18: (363 comments) File util/coreboot-configurator/src/Documentation.txt: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/67610e79_c1967b96 PS18, Line 5: This allows `coreboot-configurator` to display them in a relavant tab, with a nice 'relavant' may be misspelled - perhaps 'relevant'? File util/coreboot-configurator/src/application/aboutwindow.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/ff424c8b_c32a3a28 PS18, Line 16: public: spaces required around that ':' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/9d041fb9_100b1f3c PS18, Line 17: explicit aboutWindow(QWidget *parent = nullptr); need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/a13e8886_36d832a4 PS18, Line 21: Ui::aboutWindow *ui; need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/fad83149_43d44e2b PS18, Line 21: Ui::aboutWindow *ui; labels should not be indented File util/coreboot-configurator/src/application/configuration.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/cff05ad6_75a4d3a8 PS18, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/3aaf693f_29a2f0a3 PS18, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/df3d5702_6009cd10 PS18, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/9594e2f5_04f8dee5 PS18, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/1d2ed6e3_ee3b1d62 PS18, Line 15: QMap<QString,QString> fromNvramTool(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/aab6f8e3_8bae2001 PS18, Line 15: QMap<QString,QString> fromNvramTool(); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/1199d4ea_15526077 PS18, Line 15: QMap<QString,QString> fromNvramTool(); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/32de4057_6ceb31e9 PS18, Line 17: QMap<QString,QString> mocked(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/ccfe89ca_b8a2de19 PS18, Line 17: QMap<QString,QString> mocked(); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/36e6aa78_5efd40b6 PS18, Line 17: QMap<QString,QString> mocked(); spaces required around that '>' (ctx:VxW) File util/coreboot-configurator/src/application/coreboot_configurator.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/f7adafe8_c660b06c PS18, Line 29: public: spaces required around that ':' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/bc0013d0_4e5a55a1 PS18, Line 30: coreboot_configurator(QWidget *parent = nullptr); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/c0a8ca73_34fcfcdc PS18, Line 30: coreboot_configurator(QWidget *parent = nullptr); need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/51f58a21_fb9b11c8 PS18, Line 37: void showEvent(QShowEvent *ev); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/d4c2ed34_d28ad1a5 PS18, Line 37: void showEvent(QShowEvent *ev); need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/5a089be4_88277215 PS18, Line 38: void closeEvent(QCloseEvent *ev); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/0fd343b9_833f28a9 PS18, Line 42: void closeWindow(int result); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/f02834f8_55206472 PS18, Line 43: void saveAndClose(void); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/488ff046_9b5699cf PS18, Line 46: void getSettings(void); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/efd58864_26da3c1b PS18, Line 47: void getFromFile(void); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/728cecde_ed856dc3 PS18, Line 48: void displaySettings(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/bb92b59a_0864ae38 PS18, Line 48: void displaySettings(); Bad function definition - void displaySettings() should probably be void displaySettings(void) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/c14df4f0_279f88e4 PS18, Line 51: void writeSettings(void); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/2e868e50_1b848ea3 PS18, Line 52: void writeToFile(const QString& out_file); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/faec4b14_5d80970c PS18, Line 52: void writeToFile(const QString& out_file); need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/abc888ec_79c75efb PS18, Line 55: void updateValue(const QString& name); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/af621226_549f6601 PS18, Line 55: void updateValue(const QString& name); need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/8e4d62a2_f92242be PS18, Line 59: QString m_fileName; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/b6d85b1d_d7e51bad PS18, Line 61: QMap<QString, QString> m_values; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/e07f2d0a_819e6d4e PS18, Line 61: QMap<QString, QString> m_values; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/cb0d1639_e1caeb93 PS18, Line 61: QMap<QString, QString> m_values; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/8ad343a2_a3900684 PS18, Line 64: QMap<QString, QVBoxLayout*> m_tabs; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/02c300ea_d790bbad PS18, Line 64: QMap<QString, QVBoxLayout*> m_tabs; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/f4680ef4_7b3fcaf8 PS18, Line 64: QMap<QString, QVBoxLayout*> m_tabs; spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/b86b1ec1_4efb5498 PS18, Line 67: YAML::Node m_categories; labels should not be indented Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/a3916c84_1cb2a25c PS18, Line 70: QComboBox *textToDisplay(const QString &in_string); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/c74f84f7_f31cbe35 PS18, Line 70: QComboBox *textToDisplay(const QString &in_string); need consistent spacing around '&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/997270f5_d70154ee PS18, Line 71: QCheckBox *checkToDisplay(const QString &in_string); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/bb47acf7_2a152cd2 PS18, Line 71: QCheckBox *checkToDisplay(const QString &in_string); need consistent spacing around '&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/6c8e75b0_8c5f75ce PS18, Line 73: Ui::coreboot_configurator *ui; need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/74569a79_76ce3b82 PS18, Line 73: Ui::coreboot_configurator *ui; labels should not be indented File util/coreboot-configurator/src/application/qtyaml.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/46ef2350_2095f948 PS18, Line 17: template<> spaces required around that '<' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/85db086b_5ef69ccd PS18, Line 17: template<> spaces required around that '>' (ctx:OxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/52f634a4_12c8e8a2 PS18, Line 18: struct convert<QString> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/fe2baa73_7941499f PS18, Line 18: struct convert<QString> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/4b663e88_4d700897 PS18, Line 20: static Node encode(const QString& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/65a935c0_a9300806 PS18, Line 20: static Node encode(const QString& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/979680f8_5d882987 PS18, Line 20: static Node encode(const QString& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/177fefea_d0db6b53 PS18, Line 21: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/4cc843d1_21ef3bc9 PS18, Line 22: return Node(rhs.toStdString()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/e8238bcf_379feeae PS18, Line 22: return Node(rhs.toStdString()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/a1694f6f_c575479b PS18, Line 23: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/14b5cb27_4c87dfa0 PS18, Line 25: static bool decode(const Node& node, QString& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/4d610b3c_2e211b95 PS18, Line 25: static bool decode(const Node& node, QString& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/0836661c_2338b4eb PS18, Line 25: static bool decode(const Node& node, QString& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/7589a158_1b5e1653 PS18, Line 25: static bool decode(const Node& node, QString& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/53bc738b_b7073c21 PS18, Line 26: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/f66b1ae0_049e02cd PS18, Line 27: if (!node.IsScalar()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/09b6f31c_57fa694b PS18, Line 27: if (!node.IsScalar()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/7d009938_d21225e4 PS18, Line 27: if (!node.IsScalar()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/ee144fa2_d992b0e9 PS18, Line 28: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/6bd36905_3fc7b4e0 PS18, Line 28: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/aa0eb3d0_01275cd7 PS18, Line 29: rhs = QString::fromStdString(node.Scalar()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/2584a766_907b2fa9 PS18, Line 29: rhs = QString::fromStdString(node.Scalar()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/2386e3b8_a6ed163b PS18, Line 30: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/6da97ff1_efaa3886 PS18, Line 30: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/9b96185b_fe4a68aa PS18, Line 31: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/2f1428bb_6ea83b48 PS18, Line 35: template<typename Key, typename Value> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/68c0200d_a56542cb PS18, Line 35: template<typename Key, typename Value> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/7fd5926b_80305681 PS18, Line 36: struct convert<QMap<Key, Value> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/15f4d4a2_8c10bc53 PS18, Line 36: struct convert<QMap<Key, Value> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/f393c2cf_62233325 PS18, Line 36: struct convert<QMap<Key, Value> > spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/579f6a44_a6634739 PS18, Line 38: static Node encode(const QMap<Key,Value>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/c4156aab_b79d609a PS18, Line 38: static Node encode(const QMap<Key,Value>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/5b3f06c7_5e8c351f PS18, Line 38: static Node encode(const QMap<Key,Value>& rhs) space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/3a6c6c3a_522681e8 PS18, Line 38: static Node encode(const QMap<Key,Value>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/f4a92ed8_3ee98dc5 PS18, Line 38: static Node encode(const QMap<Key,Value>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/ce529e34_dd344d89 PS18, Line 38: static Node encode(const QMap<Key,Value>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/fff6f3db_bf32c58f PS18, Line 38: static Node encode(const QMap<Key,Value>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/17a639a7_1c9e19e1 PS18, Line 39: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/28048744_5d51996e PS18, Line 40: Node node(NodeType::Map); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/acacb841_aa8a9bf2 PS18, Line 40: Node node(NodeType::Map); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/fd046516_2142ae16 PS18, Line 41: auto it = rhs.constBegin(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/8eb9fbd8_9efc2b32 PS18, Line 41: auto it = rhs.constBegin(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/ef9605ea_715a5397 PS18, Line 42: while (it != rhs.constEnd()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/e7e40fad_59a3182f PS18, Line 42: while (it != rhs.constEnd()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/c7c87e73_757388b0 PS18, Line 42: while (it != rhs.constEnd()) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/f63ff7ac_860216ec PS18, Line 42: while (it != rhs.constEnd()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/556a0801_286e45eb PS18, Line 43: { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/f957eccc_18e02ebf PS18, Line 43: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/89cd58aa_7d98d4fb PS18, Line 44: node.force_insert(it.key(), it.value()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/0dd18327_202d14ea PS18, Line 44: node.force_insert(it.key(), it.value()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/6e9c3a05_914acde6 PS18, Line 45: ++it; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/f074959b_69b5e169 PS18, Line 45: ++it; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/28990bcf_b45cf609 PS18, Line 46: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/1c5dc09f_9a39fa0e PS18, Line 46: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/8163b967_d1bbd129 PS18, Line 47: return node; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/cced4ba5_2a759108 PS18, Line 47: return node; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/42d2061a_af4a57ba PS18, Line 48: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/da1e1b68_d679550a PS18, Line 50: static bool decode(const Node& node, QMap<Key, Value>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/2d11f22e_8a5eab49 PS18, Line 50: static bool decode(const Node& node, QMap<Key, Value>& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/ef490e21_fe71c6c2 PS18, Line 50: static bool decode(const Node& node, QMap<Key, Value>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/69f50b9f_14ba2182 PS18, Line 50: static bool decode(const Node& node, QMap<Key, Value>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/8b6d28ca_ea1625b2 PS18, Line 50: static bool decode(const Node& node, QMap<Key, Value>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/e0172713_fe536e1b PS18, Line 50: static bool decode(const Node& node, QMap<Key, Value>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/d6cfc298_3acd3fac PS18, Line 50: static bool decode(const Node& node, QMap<Key, Value>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/ef129480_f299fc5e PS18, Line 51: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/4d6673b3_2f3a958f PS18, Line 52: if (!node.IsMap()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/563005d5_61f8f012 PS18, Line 52: if (!node.IsMap()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/7d780f03_3270ec25 PS18, Line 52: if (!node.IsMap()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/5f093af9_0e5ad841 PS18, Line 53: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/060b6f44_e63a6d3b PS18, Line 53: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/7b0e89c3_a904bf0e PS18, Line 55: rhs.clear(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/b748050c_c1667107 PS18, Line 55: rhs.clear(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/2af4dfc6_3ce809f2 PS18, Line 56: const_iterator it = node.begin(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/31496571_8980cc5b PS18, Line 56: const_iterator it = node.begin(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/82f0238e_7215c79e PS18, Line 57: while (it != node.end()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/0178921e_979d5a0d PS18, Line 57: while (it != node.end()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/ca91f5b3_f4bedbf2 PS18, Line 57: while (it != node.end()) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/853e4094_bdeffc66 PS18, Line 57: while (it != node.end()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/3ac67f1e_a94961c7 PS18, Line 58: { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/8f7abd88_ff0dbc4a PS18, Line 58: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/4f9950e6_46f6c79f PS18, Line 59: rhs[it->first.as<Key>()] = it->second.as<Value>(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/d4794c17_6a46ecd1 PS18, Line 59: rhs[it->first.as<Key>()] = it->second.as<Value>(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/4a7cee86_0e18e209 PS18, Line 59: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/65866707_c5a5446b PS18, Line 59: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/ff67fa64_7c754a72 PS18, Line 59: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/387a98a9_faf73207 PS18, Line 59: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/edd9c1a1_5796d350 PS18, Line 60: ++it; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/9c601da1_dce14e12 PS18, Line 60: ++it; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/fecace56_fd259af9 PS18, Line 61: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/32fa17c7_433fc7e0 PS18, Line 61: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/3f4241b9_2ed2228c PS18, Line 62: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/08653d7c_83adc85a PS18, Line 62: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/4d33b682_bd7ae215 PS18, Line 63: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/dc35fed4_6c4b6468 PS18, Line 67: template<typename T> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/03097e32_760a2e31 PS18, Line 67: template<typename T> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/3aa1aeef_11ec3699 PS18, Line 68: struct convert<QVector<T> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/293d55d9_20cf2b27 PS18, Line 68: struct convert<QVector<T> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/9ed7528a_ee1eddaa PS18, Line 68: struct convert<QVector<T> > spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/f64c4d77_e05f9792 PS18, Line 70: static Node encode(const QVector<T>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/7be1e9e2_54bf16a9 PS18, Line 70: static Node encode(const QVector<T>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/ecde5df6_a352908b PS18, Line 70: static Node encode(const QVector<T>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/a4f332f5_d1d622be PS18, Line 70: static Node encode(const QVector<T>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/9d643979_7488a686 PS18, Line 70: static Node encode(const QVector<T>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/e3e2adae_44fdfd66 PS18, Line 70: static Node encode(const QVector<T>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/d069596a_d09cd33f PS18, Line 71: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/8b74d08f_7583d5f5 PS18, Line 72: Node node(NodeType::Sequence); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/ce3443bd_b0e83cd2 PS18, Line 72: Node node(NodeType::Sequence); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/4bc23783_193b35c4 PS18, Line 73: foreach (T value, rhs) { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/185f1623_8481857c PS18, Line 73: foreach (T value, rhs) { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/6a077c35_d9b94bfe PS18, Line 73: foreach (T value, rhs) { space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/6a37e3b8_afee23c2 PS18, Line 74: node.push_back(value); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/ae8a0178_a4944cda PS18, Line 74: node.push_back(value); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/040d4eb9_be2c6446 PS18, Line 75: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/9abc6bfc_55a2517d PS18, Line 75: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/db576afc_7e194deb PS18, Line 76: return node; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/840c0436_2c60c4f5 PS18, Line 76: return node; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/60205b59_6c4350de PS18, Line 77: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/6fb26953_f7612263 PS18, Line 79: static bool decode(const Node& node, QVector<T>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/5f724b13_0e1b1176 PS18, Line 79: static bool decode(const Node& node, QVector<T>& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/e2a0cf28_02ab8885 PS18, Line 79: static bool decode(const Node& node, QVector<T>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/713b3f67_ca33d928 PS18, Line 79: static bool decode(const Node& node, QVector<T>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/c450d5b0_00abcf59 PS18, Line 79: static bool decode(const Node& node, QVector<T>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/35c83d8a_2b77b08d PS18, Line 79: static bool decode(const Node& node, QVector<T>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/a214e766_1f380e84 PS18, Line 79: static bool decode(const Node& node, QVector<T>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/3c16895d_13a165cf PS18, Line 80: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/7db4370c_35bd0a64 PS18, Line 81: if (!node.IsSequence()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/53ed0b27_4fa58ee8 PS18, Line 81: if (!node.IsSequence()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/370342c5_25a441e4 PS18, Line 81: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/81f4ae44_819627c8 PS18, Line 82: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/4fcebab9_0155bf30 PS18, Line 82: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/9ba0102c_b07341e4 PS18, Line 84: rhs.clear(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/76cf2e17_3b34ea04 PS18, Line 84: rhs.clear(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/03e32853_191629f7 PS18, Line 85: const_iterator it = node.begin(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/a2ad7e24_bbe93f9e PS18, Line 85: const_iterator it = node.begin(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/32849343_0a94754e PS18, Line 86: while (it != node.end()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/9a866e2a_d670d8fa PS18, Line 86: while (it != node.end()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/5913027e_7e84b10c PS18, Line 86: while (it != node.end()) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/c104ad71_692a144b PS18, Line 86: while (it != node.end()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/8d360921_bef6fd08 PS18, Line 87: { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/32f85fda_476fb517 PS18, Line 87: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/84d848f7_b3a449ac PS18, Line 88: rhs.push_back(it->as<T>()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/ecd1fd0a_0586eb8a PS18, Line 88: rhs.push_back(it->as<T>()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/81a6b779_0ab5a35c PS18, Line 88: rhs.push_back(it->as<T>()); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/63d79759_d7b7e8fd PS18, Line 88: rhs.push_back(it->as<T>()); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/86ac1c8b_50dd6a0f PS18, Line 89: ++it; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/ac7a41ff_1ff85d6d PS18, Line 89: ++it; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/7b14d89b_00bea572 PS18, Line 90: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/ffab223f_4c71df88 PS18, Line 90: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/9f9367f5_c7a1664e PS18, Line 91: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/76a10274_71b514a2 PS18, Line 91: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/ff1fd083_08512275 PS18, Line 92: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/3446c089_8f4dee31 PS18, Line 96: template<typename T> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/8f94faba_5f2f3c6e PS18, Line 96: template<typename T> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/59c285ac_34f3004a PS18, Line 97: struct convert<QList<T> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/1ac5e6c1_e248c322 PS18, Line 97: struct convert<QList<T> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/b057cd17_18abd7d4 PS18, Line 97: struct convert<QList<T> > spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/ee4a8ba9_5c969b20 PS18, Line 99: static Node encode(const QList<T>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/f9d1863b_857815f2 PS18, Line 99: static Node encode(const QList<T>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/10d957a6_4596fe69 PS18, Line 99: static Node encode(const QList<T>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/2d3c4aeb_df8a216b PS18, Line 99: static Node encode(const QList<T>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/eeb901dc_f4dedb40 PS18, Line 99: static Node encode(const QList<T>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/b244c023_f3b4cf26 PS18, Line 99: static Node encode(const QList<T>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/184720af_539af6d4 PS18, Line 100: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/321b63a8_d65077de PS18, Line 101: Node node(NodeType::Sequence); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/92df22e5_b4e2da9b PS18, Line 101: Node node(NodeType::Sequence); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/3667fa53_354c17f3 PS18, Line 102: foreach (T value, rhs) { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/2936da79_0e0b23ed PS18, Line 102: foreach (T value, rhs) { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/caededcb_60ea0f75 PS18, Line 102: foreach (T value, rhs) { space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/9fc161dc_c77a43af PS18, Line 103: node.push_back(value); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/4292c007_8a571d30 PS18, Line 103: node.push_back(value); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/791203c8_7252d4bd PS18, Line 104: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/56bca7da_1b76894b PS18, Line 104: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/d0bb225b_a0b16491 PS18, Line 105: return node; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/d2123318_10f4de64 PS18, Line 105: return node; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/481e1c8c_60980286 PS18, Line 106: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/93610a15_b930367c PS18, Line 108: static bool decode(const Node& node, QList<T>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/0fa7362f_bf5da725 PS18, Line 108: static bool decode(const Node& node, QList<T>& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/dd95eee3_899ae74d PS18, Line 108: static bool decode(const Node& node, QList<T>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/01817f2c_938125ee PS18, Line 108: static bool decode(const Node& node, QList<T>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/74b60bec_f26d0263 PS18, Line 108: static bool decode(const Node& node, QList<T>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/bd837144_855f0970 PS18, Line 108: static bool decode(const Node& node, QList<T>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/a30bcb51_3da92b97 PS18, Line 108: static bool decode(const Node& node, QList<T>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/5d51ee37_869723b7 PS18, Line 109: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/be592b35_7e1def36 PS18, Line 110: if (!node.IsSequence()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/0785e3d0_13cf2f7b PS18, Line 110: if (!node.IsSequence()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/ab1ce4e4_30dbfb79 PS18, Line 110: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/9edfb12f_685fd324 PS18, Line 111: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/81e0ce2b_ce396193 PS18, Line 111: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/2fefb496_284fdeb8 PS18, Line 113: rhs.clear(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/b83aa4f9_a22fa600 PS18, Line 113: rhs.clear(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/de33ae08_b72bb476 PS18, Line 114: const_iterator it = node.begin(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/01281864_8ac701a7 PS18, Line 114: const_iterator it = node.begin(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/41bb6d48_27eb3617 PS18, Line 115: while (it != node.end()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/97f9a178_666541de PS18, Line 115: while (it != node.end()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/bc14f9d5_d668891b PS18, Line 115: while (it != node.end()) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/db318032_4b80942f PS18, Line 115: while (it != node.end()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/fc8a53a9_b73b6cb8 PS18, Line 116: { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/a9d1c952_09d47062 PS18, Line 116: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/c0d82b75_b7c5f698 PS18, Line 117: rhs.push_back(it->as<T>()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/7896f5b4_6215938c PS18, Line 117: rhs.push_back(it->as<T>()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/9e0e8f2d_e9f475cf PS18, Line 117: rhs.push_back(it->as<T>()); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/8be51cfa_d486730e PS18, Line 117: rhs.push_back(it->as<T>()); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/34669606_af1ecd3f PS18, Line 118: ++it; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/4b63ded4_8fbce494 PS18, Line 118: ++it; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/85a524e3_06c32c84 PS18, Line 119: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/a0ecc92f_b5078a29 PS18, Line 119: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/b21dbade_5aa64859 PS18, Line 120: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/eddd678b_82ba3be8 PS18, Line 120: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/6d2872b5_cb44449e PS18, Line 121: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/540f10ba_66c1aa44 PS18, Line 125: template<typename T, typename U> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/2b368a66_6b2af40d PS18, Line 125: template<typename T, typename U> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/89ca37e9_7ea105d1 PS18, Line 126: struct convert<QPair<T,U> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/38c66153_26651025 PS18, Line 126: struct convert<QPair<T,U> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/01652117_d4a687ea PS18, Line 126: struct convert<QPair<T,U> > space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/43b0330b_003bc2a1 PS18, Line 126: struct convert<QPair<T,U> > spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/87d7f2c5_3d3112c9 PS18, Line 128: static Node encode(const QPair<T,U>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/c12d69e6_3d07b88f PS18, Line 128: static Node encode(const QPair<T,U>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/aed168f6_111b215f PS18, Line 128: static Node encode(const QPair<T,U>& rhs) space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/6e0f61bf_6d73e80e PS18, Line 128: static Node encode(const QPair<T,U>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/55e61d9a_590d275d PS18, Line 128: static Node encode(const QPair<T,U>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/8e44f1f3_eb477216 PS18, Line 128: static Node encode(const QPair<T,U>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/4bec29a7_2d65d829 PS18, Line 128: static Node encode(const QPair<T,U>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/fb3bea5b_e458a5c5 PS18, Line 129: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/b9008825_36bb3cfb PS18, Line 130: Node node(NodeType::Sequence); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/c1110bcf_60c38132 PS18, Line 130: Node node(NodeType::Sequence); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/8957ce73_d934deac PS18, Line 131: node.push_back(rhs.first); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/ebb692e9_b9de0fc6 PS18, Line 131: node.push_back(rhs.first); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/13c88f60_50f70ac7 PS18, Line 132: node.push_back(rhs.second); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/dc06136c_a0c6f4e0 PS18, Line 132: node.push_back(rhs.second); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/ea777d4b_b3b913d6 PS18, Line 133: return node; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/92c3c533_fbde45a1 PS18, Line 133: return node; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/3de710eb_d25ff247 PS18, Line 134: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/ca5bf938_6ebd5970 PS18, Line 136: static bool decode(const Node& node, QPair<T,U>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/b359414d_e24644c4 PS18, Line 136: static bool decode(const Node& node, QPair<T,U>& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/51b835f0_2f5a4b82 PS18, Line 136: static bool decode(const Node& node, QPair<T,U>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/0370f693_727a556c PS18, Line 136: static bool decode(const Node& node, QPair<T,U>& rhs) space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/872fdeac_14e157f0 PS18, Line 136: static bool decode(const Node& node, QPair<T,U>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/924bb73e_782a7a6e PS18, Line 136: static bool decode(const Node& node, QPair<T,U>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/197cabc9_178de977 PS18, Line 136: static bool decode(const Node& node, QPair<T,U>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/d2200f52_ca69e3b9 PS18, Line 136: static bool decode(const Node& node, QPair<T,U>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/83759662_9ef59787 PS18, Line 137: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/14930287_c3df266c PS18, Line 138: if (!node.IsSequence()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/59222551_176edd34 PS18, Line 138: if (!node.IsSequence()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/f9f3a17e_9e3054dd PS18, Line 138: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/35519de5_cf32ae0b PS18, Line 139: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/6fb9f456_85d55fdd PS18, Line 139: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/526b5039_0029c740 PS18, Line 140: if (node.size() != 2) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/4e3c2634_3d8ce788 PS18, Line 140: if (node.size() != 2) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/22e936e2_7cd90f4f PS18, Line 140: if (node.size() != 2) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/2cee7416_8d3cf30c PS18, Line 141: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/53affa18_09148a78 PS18, Line 141: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/090ea2fe_77240ded PS18, Line 143: rhs.first = node[0].as<T>(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/f3f2d0b2_00d18c1a PS18, Line 143: rhs.first = node[0].as<T>(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/484498d5_bffe0058 PS18, Line 143: rhs.first = node[0].as<T>(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/7143f49d_6d31309c PS18, Line 143: rhs.first = node[0].as<T>(); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/e10e9be0_50d34b87 PS18, Line 144: rhs.second = node[1].as(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/f74199ab_41e6afe3 PS18, Line 144: rhs.second = node[1].as(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/1c955937_675a8c3e PS18, Line 144: rhs.second = node[1].as(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/a479aa03_69ac2924 PS18, Line 144: rhs.second = node[1].as(); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/dfea659e_6e8a2768 PS18, Line 145: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/1d224564_052c3eb9 PS18, Line 145: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/e1746f60_b64fe7c1 PS18, Line 146: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/6cebb0e5_01817fed PS18, Line 150: template<> spaces required around that '<' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/e43b8830_5e417605 PS18, Line 150: template<> spaces required around that '>' (ctx:OxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/9f07a948_e143461f PS18, Line 151: struct convert<QStringList> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/64f7651a_18301797 PS18, Line 151: struct convert<QStringList> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/4046c320_795d8d8f PS18, Line 153: static Node encode(const QStringList& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/88701038_4aefeec7 PS18, Line 153: static Node encode(const QStringList& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/7c1bdd68_37b939c0 PS18, Line 153: static Node encode(const QStringList& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/a7fc4667_6dde655b PS18, Line 154: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/018a3a4d_6f652673 PS18, Line 155: Node node(NodeType::Sequence); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/2aa9e876_4bce82a7 PS18, Line 155: Node node(NodeType::Sequence); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/146782ae_47c0ce05 PS18, Line 156: for (const auto &value: rhs) { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/6e493e3a_b6e97904 PS18, Line 156: for (const auto &value: rhs) { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/7192431f_96d9cd27 PS18, Line 156: for (const auto &value: rhs) { suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/1d78795e_c7905d93 PS18, Line 156: for (const auto &value: rhs) { need consistent spacing around '&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/2b6d91f5_bbc7af20 PS18, Line 156: for (const auto &value: rhs) { spaces required around that ':' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/36d5ccab_30ffdaf3 PS18, Line 156: for (const auto &value: rhs) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/23a61533_4ae370d9 PS18, Line 157: node.push_back(value); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/5a2861b3_635234e5 PS18, Line 157: node.push_back(value); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/c2040dc7_053813ab PS18, Line 158: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/2362fd06_5b07a549 PS18, Line 158: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/c536685f_24eb01ba PS18, Line 159: return node; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/dab6c21b_266f94a5 PS18, Line 159: return node; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/3f7533b9_efda5e1e PS18, Line 160: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/46752210_7b172a43 PS18, Line 162: static bool decode(const Node& node, QStringList& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/e32e8b99_eb679721 PS18, Line 162: static bool decode(const Node& node, QStringList& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/ad5b1415_fcb3e656 PS18, Line 162: static bool decode(const Node& node, QStringList& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/11cbbc78_82c45255 PS18, Line 162: static bool decode(const Node& node, QStringList& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/0461882f_27487c62 PS18, Line 163: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/c7f1638a_9c9334c9 PS18, Line 164: if (!node.IsSequence()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/8d0ac77b_c9ebfb42 PS18, Line 164: if (!node.IsSequence()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/1f79805a_a81144f1 PS18, Line 164: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/c62f1d6b_480580cb PS18, Line 165: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/4e5de43a_9c741d41 PS18, Line 165: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/51595ed3_f09bd642 PS18, Line 167: rhs.clear(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/054e7fa7_d6506cde PS18, Line 167: rhs.clear(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/881d04b4_2cdf9513 PS18, Line 168: const_iterator it = node.begin(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/185f3143_755fec5d PS18, Line 168: const_iterator it = node.begin(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/1424bcfc_d4e4d567 PS18, Line 169: while (it != node.end()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/d5053b6a_8f4a5016 PS18, Line 169: while (it != node.end()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/357f0bed_4871d061 PS18, Line 169: while (it != node.end()) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/368cbacb_7109183c PS18, Line 169: while (it != node.end()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/e8b5b405_6e4e0855 PS18, Line 170: { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/1bcbfeaa_8cb700eb PS18, Line 170: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/e2ac9d61_6bfa9d50 PS18, Line 171: rhs.push_back(it->as<QString>()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/f24de8a3_358ff5ae PS18, Line 171: rhs.push_back(it->as<QString>()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/40beac4d_e49971f9 PS18, Line 171: rhs.push_back(it->as<QString>()); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/9229cd13_731fc0cf PS18, Line 171: rhs.push_back(it->as<QString>()); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/a1fe7c9c_c867cf6e PS18, Line 172: ++it; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/575d1940_d6b00fca PS18, Line 172: ++it; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/eda695e3_9adcc0f7 PS18, Line 173: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/c8ae5a25_c8a70974 PS18, Line 173: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/0c3167ea_b0b3b866 PS18, Line 174: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/b293ac1b_46075156 PS18, Line 174: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/127eced6_076c833c PS18, Line 175: } please, no spaces at the start of a line -- To view, visit https://review.coreboot.org/c/coreboot/+/58854 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie654f6aca57a792be0c295afc081a95ed4d875d1 Gerrit-Change-Number: 58854 Gerrit-PatchSet: 18 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com> Gerrit-Comment-Date: Thu, 04 Nov 2021 22:06:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [WIP] util: Add coreboot Configurator
by Sean Rhodes (Code Review) 04 Nov '21

04 Nov '21

Attention is currently required from: Sean Rhodes, Martin Roth, Tim Wawrzynczak, Angel Pons. Hello build bot (Jenkins), Martin Roth, Tim Wawrzynczak, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/58854 to look at the new patch set (#18). Change subject: [WIP] util: Add coreboot Configurator ...................................................................... [WIP] util: Add coreboot Configurator A simply GUI to change settings in coreboot's CBFS, via the nvramtool utility. Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: Ie654f6aca57a792be0c295afc081a95ed4d875d1 --- A util/coreboot-configurator/README.md A util/coreboot-configurator/contrib/PKGBUILD A util/coreboot-configurator/contrib/README.md A util/coreboot-configurator/contrib/debian/changelog A util/coreboot-configurator/contrib/debian/compat A util/coreboot-configurator/contrib/debian/control A util/coreboot-configurator/contrib/debian/copyright A util/coreboot-configurator/contrib/debian/files A util/coreboot-configurator/contrib/debian/rules A util/coreboot-configurator/contrib/debian/source/format A util/coreboot-configurator/contrib/flatpak/coreboot-configurator.json A util/coreboot-configurator/contrib/flatpak/org.coreboot.coreboot-configurator.json A util/coreboot-configurator/meson.build A util/coreboot-configurator/meson_options.txt A util/coreboot-configurator/screenshots/coreboot-configurator.gif A util/coreboot-configurator/screenshots/coreboot-configurator.png A util/coreboot-configurator/src/Documentation.txt A util/coreboot-configurator/src/application/aboutwindow.cpp A util/coreboot-configurator/src/application/aboutwindow.h A util/coreboot-configurator/src/application/aboutwindow.ui A util/coreboot-configurator/src/application/categories.yaml A util/coreboot-configurator/src/application/configuration.cpp A util/coreboot-configurator/src/application/configuration.h A util/coreboot-configurator/src/application/coreboot_configurator.cpp A util/coreboot-configurator/src/application/coreboot_configurator.h A util/coreboot-configurator/src/application/coreboot_configurator.ui A util/coreboot-configurator/src/application/images.qrc A util/coreboot-configurator/src/application/main.cpp A util/coreboot-configurator/src/application/meson.build A util/coreboot-configurator/src/application/qtyaml.h A util/coreboot-configurator/src/application/toggle-off.svg A util/coreboot-configurator/src/application/toggle-on.svg A util/coreboot-configurator/src/meson.build A util/coreboot-configurator/src/static/aboutIcon.png A util/coreboot-configurator/src/static/coreboot-configurator.desktop A util/coreboot-configurator/src/static/coreboot_configurator.svg A util/coreboot-configurator/src/static/meson.build A util/coreboot-configurator/src/static/org.coreboot.nvramtool.policy A util/coreboot-configurator/src/static/org.coreboot.reboot.policy 39 files changed, 2,928 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/58854/18 -- To view, visit https://review.coreboot.org/c/coreboot/+/58854 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie654f6aca57a792be0c295afc081a95ed4d875d1 Gerrit-Change-Number: 58854 Gerrit-PatchSet: 18 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: [WIP] util: Add coreboot Configurator
by build bot (Jenkins) (Code Review) 04 Nov '21

04 Nov '21

Attention is currently required from: Martin Roth, Tim Wawrzynczak, Angel Pons. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58854 ) Change subject: [WIP] util: Add coreboot Configurator ...................................................................... Patch Set 17: (363 comments) File util/coreboot-configurator/src/Documentation.txt: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/376f2b40_9aef7ef6 PS17, Line 5: This allows `coreboot-configurator` to display them in a relavant tab, with a nice 'relavant' may be misspelled - perhaps 'relevant'? File util/coreboot-configurator/src/application/aboutwindow.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/f931a053_2c133584 PS17, Line 16: public: spaces required around that ':' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/74589d23_7dc04bfa PS17, Line 17: explicit aboutWindow(QWidget *parent = nullptr); need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/a6eed756_949b168c PS17, Line 21: Ui::aboutWindow *ui; need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/dbe15a52_3818187d PS17, Line 21: Ui::aboutWindow *ui; labels should not be indented File util/coreboot-configurator/src/application/configuration.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/2402c964_86fc6a3f PS17, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/c2c3b345_3f2ac576 PS17, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/2c9975be_32beceba PS17, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/da733590_eee31c7b PS17, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/89d61568_06b14ed0 PS17, Line 15: QMap<QString,QString> fromNvramTool(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/62769c00_41a8fe73 PS17, Line 15: QMap<QString,QString> fromNvramTool(); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/1bc2a894_556238ba PS17, Line 15: QMap<QString,QString> fromNvramTool(); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/4299a2b2_dce4e058 PS17, Line 17: QMap<QString,QString> mocked(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/183a7ce7_225026c1 PS17, Line 17: QMap<QString,QString> mocked(); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/fefaec30_8e03841e PS17, Line 17: QMap<QString,QString> mocked(); spaces required around that '>' (ctx:VxW) File util/coreboot-configurator/src/application/coreboot_configurator.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/c76498c7_d068dc55 PS17, Line 29: public: spaces required around that ':' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/e5e735f0_cbdf22c8 PS17, Line 30: coreboot_configurator(QWidget *parent = nullptr); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/14f71b5c_9dffea0a PS17, Line 30: coreboot_configurator(QWidget *parent = nullptr); need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/b49e11a3_0d6709ca PS17, Line 37: void showEvent(QShowEvent *ev); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/da778496_586326c4 PS17, Line 37: void showEvent(QShowEvent *ev); need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/b6cdb72a_fc93061a PS17, Line 38: void closeEvent(QCloseEvent *ev); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/0095f689_76d91a5e PS17, Line 42: void closeWindow(int result); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/052020b4_74e19574 PS17, Line 43: void saveAndClose(void); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/1f7039bc_8c3b52c5 PS17, Line 46: void getSettings(void); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/1c3b4692_ec236001 PS17, Line 47: void getFromFile(void); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/35eebe8f_4df9a34f PS17, Line 48: void displaySettings(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/6ba33467_166e6560 PS17, Line 48: void displaySettings(); Bad function definition - void displaySettings() should probably be void displaySettings(void) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/ced4c179_49b79288 PS17, Line 51: void writeSettings(void); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/cc344570_13e5c38f PS17, Line 52: void writeToFile(const QString& out_file); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/993d05ac_8c51a21e PS17, Line 52: void writeToFile(const QString& out_file); need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/1f212068_7204c93e PS17, Line 55: void updateValue(const QString& name); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/8b9a49e3_c708e474 PS17, Line 55: void updateValue(const QString& name); need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/576e0478_17b3bd31 PS17, Line 59: QString m_fileName; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/40674d70_24db1aaf PS17, Line 61: QMap<QString, QString> m_values; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/2c4f1b82_eeeddb35 PS17, Line 61: QMap<QString, QString> m_values; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/56808026_bb4ffe8d PS17, Line 61: QMap<QString, QString> m_values; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/29807035_a85be9ff PS17, Line 64: QMap<QString, QVBoxLayout*> m_tabs; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/7a8f7546_d8aac578 PS17, Line 64: QMap<QString, QVBoxLayout*> m_tabs; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/91e10193_e5533100 PS17, Line 64: QMap<QString, QVBoxLayout*> m_tabs; spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/05d1f431_947c7317 PS17, Line 67: YAML::Node m_categories; labels should not be indented Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/c0ed2721_924d9e9b PS17, Line 70: QComboBox *textToDisplay(const QString &in_string); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/98616e34_805d5fc6 PS17, Line 70: QComboBox *textToDisplay(const QString &in_string); need consistent spacing around '&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/087ef333_5d0382cb PS17, Line 71: QCheckBox *checkToDisplay(const QString &in_string); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/1e045c44_9e675d61 PS17, Line 71: QCheckBox *checkToDisplay(const QString &in_string); need consistent spacing around '&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/3d41ea98_964cd789 PS17, Line 73: Ui::coreboot_configurator *ui; need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/fd71412f_6a8653c1 PS17, Line 73: Ui::coreboot_configurator *ui; labels should not be indented File util/coreboot-configurator/src/application/qtyaml.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/7aff3115_db16dcab PS17, Line 30: template<> spaces required around that '<' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/b87e70c1_dee8533e PS17, Line 30: template<> spaces required around that '>' (ctx:OxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/e2908213_9e018cbf PS17, Line 31: struct convert<QString> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/229e5725_b5bbdee5 PS17, Line 31: struct convert<QString> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/3d949064_21a7e949 PS17, Line 33: static Node encode(const QString& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/b302b4e1_6cc2dc0a PS17, Line 33: static Node encode(const QString& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/506ae53a_2e065733 PS17, Line 33: static Node encode(const QString& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/e469b129_161c5f27 PS17, Line 34: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/dddc7c29_b55d2ff8 PS17, Line 35: return Node(rhs.toStdString()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/70a80c4b_e7130789 PS17, Line 35: return Node(rhs.toStdString()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/59f0d051_a714508d PS17, Line 36: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/85d77b5b_e962c7ff PS17, Line 38: static bool decode(const Node& node, QString& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/8dec33bb_407eb561 PS17, Line 38: static bool decode(const Node& node, QString& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/cfe054ca_0c7f0156 PS17, Line 38: static bool decode(const Node& node, QString& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/27625da2_f42f5554 PS17, Line 38: static bool decode(const Node& node, QString& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/ca37cf47_136fbc57 PS17, Line 39: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/4daed6e2_ad8da58f PS17, Line 40: if (!node.IsScalar()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/db9f94c5_057fc9ed PS17, Line 40: if (!node.IsScalar()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/f2ae67e1_751edee1 PS17, Line 40: if (!node.IsScalar()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/bfc97adb_22a4afac PS17, Line 41: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/852d1669_b0687df9 PS17, Line 41: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/403d9614_5b01f946 PS17, Line 42: rhs = QString::fromStdString(node.Scalar()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/d0acd101_59c0439d PS17, Line 42: rhs = QString::fromStdString(node.Scalar()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/72f0cf49_c8bf1fe0 PS17, Line 43: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/ce3467db_5a9fb6b6 PS17, Line 43: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/41a88a87_a884d5b9 PS17, Line 44: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/3a773c85_985d6d99 PS17, Line 48: template<typename Key, typename Value> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/bdd31793_8dea0dcf PS17, Line 48: template<typename Key, typename Value> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/9aeced3c_8ed1ea29 PS17, Line 49: struct convert<QMap<Key, Value> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/d3935873_ffdd4cc0 PS17, Line 49: struct convert<QMap<Key, Value> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/312a66eb_0f085e07 PS17, Line 49: struct convert<QMap<Key, Value> > spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/73b23b98_7436c371 PS17, Line 51: static Node encode(const QMap<Key,Value>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/bac637ac_5e10be7b PS17, Line 51: static Node encode(const QMap<Key,Value>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/b12c16ad_836dc037 PS17, Line 51: static Node encode(const QMap<Key,Value>& rhs) space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/59a68e42_4e4f6ada PS17, Line 51: static Node encode(const QMap<Key,Value>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/eb1a14e2_e6a967e4 PS17, Line 51: static Node encode(const QMap<Key,Value>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/42a2abdd_43c1725a PS17, Line 51: static Node encode(const QMap<Key,Value>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/f9676f28_b6aae740 PS17, Line 51: static Node encode(const QMap<Key,Value>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/ba704ce8_71341d3c PS17, Line 52: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/e9718967_dc9cb1a2 PS17, Line 53: Node node(NodeType::Map); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/3525ce9a_41617173 PS17, Line 53: Node node(NodeType::Map); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/032878df_e9ca508d PS17, Line 54: auto it = rhs.constBegin(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/12405656_c4911dd9 PS17, Line 54: auto it = rhs.constBegin(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/2893f016_b12a0c2e PS17, Line 55: while (it != rhs.constEnd()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/f6b834f2_eda0228b PS17, Line 55: while (it != rhs.constEnd()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/e4b926d9_06888743 PS17, Line 55: while (it != rhs.constEnd()) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/0fccea69_0de17b85 PS17, Line 55: while (it != rhs.constEnd()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/b3a169e2_e289108f PS17, Line 56: { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/bcf584c0_1f613cb9 PS17, Line 56: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/7e616098_44b091c4 PS17, Line 57: node.force_insert(it.key(), it.value()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/e512d874_c40d0084 PS17, Line 57: node.force_insert(it.key(), it.value()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/89d7dd23_b9e56508 PS17, Line 58: ++it; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/9eb1feb4_41ccbc5f PS17, Line 58: ++it; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/160dffe6_02800eff PS17, Line 59: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/3b59a3a5_4d59b370 PS17, Line 59: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/eaa3578a_7af98f53 PS17, Line 60: return node; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/8ec02a6a_e115efc2 PS17, Line 60: return node; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/147c5bdf_f2f5b3e0 PS17, Line 61: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/8abb0dc3_5cb172e2 PS17, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/823f3cdb_a2c737ae PS17, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/ae6b6e49_ab00fb01 PS17, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/b0630fe3_f790bccb PS17, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/fcf469f1_e5f0cad4 PS17, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/9e83532a_5e7931ec PS17, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/cfef95a7_b434791f PS17, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/88cb33f1_5ce02803 PS17, Line 64: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/15f0c565_e85cd246 PS17, Line 65: if (!node.IsMap()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/78f30859_cdb0665a PS17, Line 65: if (!node.IsMap()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/bf6ebb93_aae317ed PS17, Line 65: if (!node.IsMap()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/2ef559ad_44584294 PS17, Line 66: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/1deab9f3_8d01f380 PS17, Line 66: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/fa17ac8e_d79834f4 PS17, Line 68: rhs.clear(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/52483f4d_3ff469ae PS17, Line 68: rhs.clear(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/838ccf0a_8b9d37cb PS17, Line 69: const_iterator it = node.begin(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/395b3bd4_cced058f PS17, Line 69: const_iterator it = node.begin(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/64f00323_54b8a0f3 PS17, Line 70: while (it != node.end()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/acbad4a9_d9b40f54 PS17, Line 70: while (it != node.end()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/f55a5297_179ea693 PS17, Line 70: while (it != node.end()) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/57a5d100_79016feb PS17, Line 70: while (it != node.end()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/41eace56_5c3b1424 PS17, Line 71: { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/c4ef5499_b947427f PS17, Line 71: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/e28f9bf6_8bc95d5e PS17, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/193e3574_b9588ccb PS17, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/58334569_dc8c91f6 PS17, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/fe973961_31359904 PS17, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/3e5c4ea9_9b2dee94 PS17, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/7cee221b_63807b03 PS17, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/ea46bf18_34d85392 PS17, Line 73: ++it; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/5f29125f_44e168e5 PS17, Line 73: ++it; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/fc1571eb_e6d7b750 PS17, Line 74: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/fe520c8a_4ca61ce7 PS17, Line 74: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/0e602cb7_27617316 PS17, Line 75: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/a2d93870_bfd26c2f PS17, Line 75: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/0af48cd5_bee2d2cf PS17, Line 76: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/6da9b02f_4ebcdcdf PS17, Line 80: template<typename T> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/7f6b1e61_a1190db2 PS17, Line 80: template<typename T> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/f9685bc0_6227b4af PS17, Line 81: struct convert<QVector<T> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/3ba72824_fd8aa05b PS17, Line 81: struct convert<QVector<T> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/d9a3549d_ad43996e PS17, Line 81: struct convert<QVector<T> > spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/ea1c3e52_3bc975b3 PS17, Line 83: static Node encode(const QVector<T>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/66f3e165_b4ca8649 PS17, Line 83: static Node encode(const QVector<T>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/c5b99e07_15ed3c16 PS17, Line 83: static Node encode(const QVector<T>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/b0893783_17b5eb3c PS17, Line 83: static Node encode(const QVector<T>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/00b70a0f_5e5c4864 PS17, Line 83: static Node encode(const QVector<T>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/460d2dff_601ae66e PS17, Line 83: static Node encode(const QVector<T>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/7977abe8_3b8c6078 PS17, Line 84: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/6b87e042_e22147b8 PS17, Line 85: Node node(NodeType::Sequence); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/3eaeae06_8e2b2310 PS17, Line 85: Node node(NodeType::Sequence); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/5e7f9f35_b27ecfa9 PS17, Line 86: foreach (T value, rhs) { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/e896c607_147cb2e3 PS17, Line 86: foreach (T value, rhs) { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/049e5880_4de1bb3c PS17, Line 86: foreach (T value, rhs) { space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/97c9e7f2_1bd7c4f0 PS17, Line 87: node.push_back(value); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/3ae4bf15_df9f8ac1 PS17, Line 87: node.push_back(value); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/ddd685e1_836656ce PS17, Line 88: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/09011248_5b62c59d PS17, Line 88: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/03d6773f_5b281947 PS17, Line 89: return node; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/2b2df1fe_fc29196f PS17, Line 89: return node; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/2b2af1b7_b197bf4d PS17, Line 90: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/8c5db439_d7c61f94 PS17, Line 92: static bool decode(const Node& node, QVector<T>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/1aed2938_fcc9edfe PS17, Line 92: static bool decode(const Node& node, QVector<T>& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/03129a6c_e1eb1080 PS17, Line 92: static bool decode(const Node& node, QVector<T>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/8803794d_6730f7be PS17, Line 92: static bool decode(const Node& node, QVector<T>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/172fa2d8_d5f20267 PS17, Line 92: static bool decode(const Node& node, QVector<T>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/16172231_c118d694 PS17, Line 92: static bool decode(const Node& node, QVector<T>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/d655d312_fd254605 PS17, Line 92: static bool decode(const Node& node, QVector<T>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/4be19cac_d6cee545 PS17, Line 93: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/6087cc58_822540a6 PS17, Line 94: if (!node.IsSequence()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/8b7140b9_71cfbd25 PS17, Line 94: if (!node.IsSequence()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/57d21cbd_abb8e52b PS17, Line 94: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/39860af4_378a4aa1 PS17, Line 95: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/69d5ae1a_17339024 PS17, Line 95: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/947c2d3e_166e0a49 PS17, Line 97: rhs.clear(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/587d5384_3e8e1fc1 PS17, Line 97: rhs.clear(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/49951195_e731d9dc PS17, Line 98: const_iterator it = node.begin(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/cd9f2377_b8d45f1c PS17, Line 98: const_iterator it = node.begin(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/860e25dd_8b53375b PS17, Line 99: while (it != node.end()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/9f58a344_9774a289 PS17, Line 99: while (it != node.end()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/1b041cd3_0939ff52 PS17, Line 99: while (it != node.end()) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/35b26379_ae5c94a8 PS17, Line 99: while (it != node.end()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/f5e7e0cb_1d5cf427 PS17, Line 100: { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/53f9a68e_bd7da15d PS17, Line 100: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/b6a61837_29b80a17 PS17, Line 101: rhs.push_back(it->as<T>()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/1093f53a_be1d529b PS17, Line 101: rhs.push_back(it->as<T>()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/02bca8e7_6df57b67 PS17, Line 101: rhs.push_back(it->as<T>()); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/64416c04_1e2de3de PS17, Line 101: rhs.push_back(it->as<T>()); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/39cf0c3c_b7c15cdf PS17, Line 102: ++it; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/ce3f6755_546bb8f3 PS17, Line 102: ++it; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/feb43d48_f04e290a PS17, Line 103: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/6306ec1d_3f0de8f6 PS17, Line 103: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/9a826ccf_1fb6d0cc PS17, Line 104: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/103c3962_02d6ce41 PS17, Line 104: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/40a745a6_4d7ddeaf PS17, Line 105: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/b77d06f1_4cb41891 PS17, Line 109: template<typename T> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/3c064155_64bd4f36 PS17, Line 109: template<typename T> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/0de79aee_ec1cbb2d PS17, Line 110: struct convert<QList<T> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/b217958c_af73393c PS17, Line 110: struct convert<QList<T> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/71885e4a_f3cee630 PS17, Line 110: struct convert<QList<T> > spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/8b198b7e_0b431102 PS17, Line 112: static Node encode(const QList<T>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/a0b3beab_14027eb5 PS17, Line 112: static Node encode(const QList<T>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/0d924140_875785f6 PS17, Line 112: static Node encode(const QList<T>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/d204963d_604202c2 PS17, Line 112: static Node encode(const QList<T>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/71a8ad33_b67539ee PS17, Line 112: static Node encode(const QList<T>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/66cddf99_89921171 PS17, Line 112: static Node encode(const QList<T>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/54be98e0_7fff4b8a PS17, Line 113: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/46e20e92_0a0336e9 PS17, Line 114: Node node(NodeType::Sequence); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/955a868c_d40573a1 PS17, Line 114: Node node(NodeType::Sequence); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/9042ed90_9ca7c1ab PS17, Line 115: foreach (T value, rhs) { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/66257a28_2f6975eb PS17, Line 115: foreach (T value, rhs) { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/6b887be1_375441bc PS17, Line 115: foreach (T value, rhs) { space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/e763804f_cab63a5d PS17, Line 116: node.push_back(value); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/e2767015_66cfc8f2 PS17, Line 116: node.push_back(value); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/96ab872e_e90fbad3 PS17, Line 117: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/cddfed02_4cab757d PS17, Line 117: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/7449b146_ca3009a0 PS17, Line 118: return node; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/97f29d61_05ad4a09 PS17, Line 118: return node; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/faa05713_89360d7e PS17, Line 119: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/39e18461_d93c8bf4 PS17, Line 121: static bool decode(const Node& node, QList<T>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/05b187bc_9ea6a122 PS17, Line 121: static bool decode(const Node& node, QList<T>& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/3c869955_eca2aacc PS17, Line 121: static bool decode(const Node& node, QList<T>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/11957ee4_ef042a8e PS17, Line 121: static bool decode(const Node& node, QList<T>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/3c315001_63602bb1 PS17, Line 121: static bool decode(const Node& node, QList<T>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/9644f581_e04cae24 PS17, Line 121: static bool decode(const Node& node, QList<T>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/2c4d454a_0dd682d7 PS17, Line 121: static bool decode(const Node& node, QList<T>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/ecc33505_fe998664 PS17, Line 122: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/d5c7b960_989d53f7 PS17, Line 123: if (!node.IsSequence()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/6186eff9_00ff60c1 PS17, Line 123: if (!node.IsSequence()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/a2b0c3cc_d285fab2 PS17, Line 123: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/e01e0ceb_8772b830 PS17, Line 124: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/99000f08_81c6d260 PS17, Line 124: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/79d4f960_dd8df4dc PS17, Line 126: rhs.clear(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/e5df6bea_846175e4 PS17, Line 126: rhs.clear(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/157451a5_9828c416 PS17, Line 127: const_iterator it = node.begin(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/ba5836c6_fe88652f PS17, Line 127: const_iterator it = node.begin(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/c453c63b_7d33ccac PS17, Line 128: while (it != node.end()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/6a3980b8_cde50744 PS17, Line 128: while (it != node.end()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/53b9ad60_8634df1a PS17, Line 128: while (it != node.end()) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/5940407a_529e450b PS17, Line 128: while (it != node.end()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/399fe327_7c764bec PS17, Line 129: { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/74163152_fb31429d PS17, Line 129: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/d22a0af7_21a49a8a PS17, Line 130: rhs.push_back(it->as<T>()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/2fad82a2_a23894fa PS17, Line 130: rhs.push_back(it->as<T>()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/3acbcf3b_ac8a3ec2 PS17, Line 130: rhs.push_back(it->as<T>()); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/1763e06a_58fda5a4 PS17, Line 130: rhs.push_back(it->as<T>()); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/b67ff080_3ea9aa35 PS17, Line 131: ++it; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/11b542f2_34d046f6 PS17, Line 131: ++it; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/29ef0c09_ab8a9ff1 PS17, Line 132: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/1a39524e_048c455a PS17, Line 132: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/ac76e860_e019de2c PS17, Line 133: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/e52ab4c5_78fd99a9 PS17, Line 133: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/17e96cc3_f443e8bd PS17, Line 134: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/ace646a7_6ba680d5 PS17, Line 138: template<typename T, typename U> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/cfccf1bc_d8ac358c PS17, Line 138: template<typename T, typename U> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/3f867e22_9d6f9c3b PS17, Line 139: struct convert<QPair<T,U> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/1669ee56_504057c5 PS17, Line 139: struct convert<QPair<T,U> > spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/fcc70d87_4f58bac3 PS17, Line 139: struct convert<QPair<T,U> > space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/8d885158_63c4ee34 PS17, Line 139: struct convert<QPair<T,U> > spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/c5bd9a56_9b29f517 PS17, Line 141: static Node encode(const QPair<T,U>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/82ae500d_950827b5 PS17, Line 141: static Node encode(const QPair<T,U>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/eb8e1f78_1a4f6113 PS17, Line 141: static Node encode(const QPair<T,U>& rhs) space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/b1dccd36_34ed8c44 PS17, Line 141: static Node encode(const QPair<T,U>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/dabcf5c7_04dcf668 PS17, Line 141: static Node encode(const QPair<T,U>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/1f4456de_bf8a5618 PS17, Line 141: static Node encode(const QPair<T,U>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/12f11b42_99a4f4d4 PS17, Line 141: static Node encode(const QPair<T,U>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/f6b14808_406d6f03 PS17, Line 142: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/30b0dab6_0b984e78 PS17, Line 143: Node node(NodeType::Sequence); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/9537772c_9764b81c PS17, Line 143: Node node(NodeType::Sequence); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/afabe097_d63ba5c8 PS17, Line 144: node.push_back(rhs.first); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/81f99079_a8e159a0 PS17, Line 144: node.push_back(rhs.first); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/bcb1a4ac_824afc87 PS17, Line 145: node.push_back(rhs.second); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/9810d191_85287327 PS17, Line 145: node.push_back(rhs.second); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/b61dd8a9_c6fda40f PS17, Line 146: return node; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/9a7f8944_edecab62 PS17, Line 146: return node; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/99b305c0_257dfddf PS17, Line 147: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/b34b9df3_18bbe6bb PS17, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/f4f1a7a2_46d40296 PS17, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/7d10e3df_6b59ca57 PS17, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/8ee38b8a_7ac0c69b PS17, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/831a5fb1_bd21a852 PS17, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/a7219702_9081dd34 PS17, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/6473d8e1_71e62e76 PS17, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/6e2e8788_3340951d PS17, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/98855a80_512d33c9 PS17, Line 150: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/9c4ff2cd_530c054a PS17, Line 151: if (!node.IsSequence()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/2874865f_04f60972 PS17, Line 151: if (!node.IsSequence()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/4274834c_5709116b PS17, Line 151: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/04690969_714f3be6 PS17, Line 152: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/49057dd1_70649c38 PS17, Line 152: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/1a80d817_982a1609 PS17, Line 153: if (node.size() != 2) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/2f4d05e0_dbb0fc37 PS17, Line 153: if (node.size() != 2) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/a40f21da_2c478520 PS17, Line 153: if (node.size() != 2) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/30a2e5a5_28addc47 PS17, Line 154: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/690dd382_b2ecbec3 PS17, Line 154: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/04784e13_e6c08c59 PS17, Line 156: rhs.first = node[0].as<T>(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/64739469_af96b1f2 PS17, Line 156: rhs.first = node[0].as<T>(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/ba507c2c_8b935959 PS17, Line 156: rhs.first = node[0].as<T>(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/d085d483_179de32e PS17, Line 156: rhs.first = node[0].as<T>(); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/91bfcf1d_afe4f8f9 PS17, Line 157: rhs.second = node[1].as(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/4ed62790_ced127ad PS17, Line 157: rhs.second = node[1].as(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/77b089c8_ade8ceba PS17, Line 157: rhs.second = node[1].as(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/b0603cdc_e39881fe PS17, Line 157: rhs.second = node[1].as(); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/17c6cdd5_a4a790b4 PS17, Line 158: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/61f36559_9fbd0c88 PS17, Line 158: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/11caf865_19cd69a9 PS17, Line 159: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/d6a5e668_b8174615 PS17, Line 163: template<> spaces required around that '<' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/61539a80_0440e1ba PS17, Line 163: template<> spaces required around that '>' (ctx:OxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/0caf00b4_00c962bf PS17, Line 164: struct convert<QStringList> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/6749c388_dcd41608 PS17, Line 164: struct convert<QStringList> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/172e2b04_3ccc5ffb PS17, Line 166: static Node encode(const QStringList& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/e922a041_b1f5d4b3 PS17, Line 166: static Node encode(const QStringList& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/541b61c0_e90341ba PS17, Line 166: static Node encode(const QStringList& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/642ba76e_04371196 PS17, Line 167: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/0db9276a_0c93a23a PS17, Line 168: Node node(NodeType::Sequence); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/532390fe_64bd42c1 PS17, Line 168: Node node(NodeType::Sequence); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/cd28a42e_9def7f4f PS17, Line 169: for (const auto &value: rhs) { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/cc4483f9_3fcd6f18 PS17, Line 169: for (const auto &value: rhs) { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/07637008_6f1cc04f PS17, Line 169: for (const auto &value: rhs) { suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/97f7bc46_4c9afecb PS17, Line 169: for (const auto &value: rhs) { need consistent spacing around '&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/5dd46ac0_588b4809 PS17, Line 169: for (const auto &value: rhs) { spaces required around that ':' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/36cb597e_db3721cf PS17, Line 169: for (const auto &value: rhs) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/c85860e3_6680670a PS17, Line 170: node.push_back(value); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/491455a3_61137aa8 PS17, Line 170: node.push_back(value); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/0c2ae819_3a8388b0 PS17, Line 171: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/4048f77a_fae9d7d3 PS17, Line 171: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/6ef1515e_9cd847d7 PS17, Line 172: return node; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/51924258_d9c387b4 PS17, Line 172: return node; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/13194b05_7a6d3afb PS17, Line 173: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/c70b2bb3_5aaca276 PS17, Line 175: static bool decode(const Node& node, QStringList& rhs) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/868cbd71_1133fe0b PS17, Line 175: static bool decode(const Node& node, QStringList& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/d89e3075_fd87f7bc PS17, Line 175: static bool decode(const Node& node, QStringList& rhs) need consistent spacing around '&' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/df6975af_afb444ad PS17, Line 175: static bool decode(const Node& node, QStringList& rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/74dafbe6_f6c5f5fb PS17, Line 176: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/562713ac_f4876e32 PS17, Line 177: if (!node.IsSequence()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/c3853d00_27f5c52e PS17, Line 177: if (!node.IsSequence()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/3c73807d_4cfa3b31 PS17, Line 177: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/6c3e46ff_72b0dc98 PS17, Line 178: return false; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/f22b0de4_f556495a PS17, Line 178: return false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/e887b80f_b6692c56 PS17, Line 180: rhs.clear(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/5f209c67_bf94745f PS17, Line 180: rhs.clear(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/002c8a02_71446dc9 PS17, Line 181: const_iterator it = node.begin(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/e4210cf5_f15c26ad PS17, Line 181: const_iterator it = node.begin(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/382bf65c_8f4f039e PS17, Line 182: while (it != node.end()) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/d1909c41_b5cbf318 PS17, Line 182: while (it != node.end()) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/83cc4312_cdcd6e6a PS17, Line 182: while (it != node.end()) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/c0e214a9_61a98687 PS17, Line 182: while (it != node.end()) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/366f0e55_6b3c9dea PS17, Line 183: { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/483a1014_e401efaa PS17, Line 183: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/b1f1ebae_052bdb63 PS17, Line 184: rhs.push_back(it->as<QString>()); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/ed9efd56_eab06cf6 PS17, Line 184: rhs.push_back(it->as<QString>()); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/b6e3de4c_f91b1d05 PS17, Line 184: rhs.push_back(it->as<QString>()); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/ade46e51_cb60a410 PS17, Line 184: rhs.push_back(it->as<QString>()); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/ca986d53_218276f6 PS17, Line 185: ++it; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/65f3b20d_3192ad6a PS17, Line 185: ++it; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/ef9d559f_651722f7 PS17, Line 186: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/b3039f07_6fefacc5 PS17, Line 186: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/18c67666_b41192e4 PS17, Line 187: return true; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/ca5b7d28_036919ea PS17, Line 187: return true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/1a584657_fcc179fe PS17, Line 188: } please, no spaces at the start of a line -- To view, visit https://review.coreboot.org/c/coreboot/+/58854 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie654f6aca57a792be0c295afc081a95ed4d875d1 Gerrit-Change-Number: 58854 Gerrit-PatchSet: 17 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com> Gerrit-Comment-Date: Thu, 04 Nov 2021 21:52:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [WIP] util: Add coreboot Configurator
by Sean Rhodes (Code Review) 04 Nov '21

04 Nov '21

Attention is currently required from: Martin Roth, Tim Wawrzynczak, Angel Pons. Hello build bot (Jenkins), Martin Roth, Tim Wawrzynczak, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/58854 to look at the new patch set (#17). Change subject: [WIP] util: Add coreboot Configurator ...................................................................... [WIP] util: Add coreboot Configurator A simply GUI to change settings in coreboot's CBFS, via the nvramtool utility. Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: Ie654f6aca57a792be0c295afc081a95ed4d875d1 --- A util/coreboot-configurator/README.md A util/coreboot-configurator/contrib/PKGBUILD A util/coreboot-configurator/contrib/README.md A util/coreboot-configurator/contrib/debian/changelog A util/coreboot-configurator/contrib/debian/compat A util/coreboot-configurator/contrib/debian/control A util/coreboot-configurator/contrib/debian/copyright A util/coreboot-configurator/contrib/debian/files A util/coreboot-configurator/contrib/debian/rules A util/coreboot-configurator/contrib/debian/source/format A util/coreboot-configurator/contrib/flatpak/coreboot-configurator.json A util/coreboot-configurator/contrib/flatpak/org.coreboot.coreboot-configurator.json A util/coreboot-configurator/meson.build A util/coreboot-configurator/meson_options.txt A util/coreboot-configurator/screenshots/coreboot-configurator.gif A util/coreboot-configurator/screenshots/coreboot-configurator.png A util/coreboot-configurator/src/Documentation.txt A util/coreboot-configurator/src/application/aboutwindow.cpp A util/coreboot-configurator/src/application/aboutwindow.h A util/coreboot-configurator/src/application/aboutwindow.ui A util/coreboot-configurator/src/application/categories.yaml A util/coreboot-configurator/src/application/configuration.cpp A util/coreboot-configurator/src/application/configuration.h A util/coreboot-configurator/src/application/coreboot_configurator.cpp A util/coreboot-configurator/src/application/coreboot_configurator.h A util/coreboot-configurator/src/application/coreboot_configurator.ui A util/coreboot-configurator/src/application/images.qrc A util/coreboot-configurator/src/application/main.cpp A util/coreboot-configurator/src/application/meson.build A util/coreboot-configurator/src/application/qtyaml.h A util/coreboot-configurator/src/application/toggle-off.svg A util/coreboot-configurator/src/application/toggle-on.svg A util/coreboot-configurator/src/meson.build A util/coreboot-configurator/src/static/aboutIcon.png A util/coreboot-configurator/src/static/coreboot-configurator.desktop A util/coreboot-configurator/src/static/coreboot_configurator.svg A util/coreboot-configurator/src/static/meson.build A util/coreboot-configurator/src/static/org.coreboot.nvramtool.policy A util/coreboot-configurator/src/static/org.coreboot.reboot.policy 39 files changed, 2,958 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/58854/17 -- To view, visit https://review.coreboot.org/c/coreboot/+/58854 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie654f6aca57a792be0c295afc081a95ed4d875d1 Gerrit-Change-Number: 58854 Gerrit-PatchSet: 17 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: spd: Add new LP5 parts and generate SPDs
by Reka Norman (Code Review) 04 Nov '21

04 Nov '21

Attention is currently required from: Paul Menzel, Tim Wawrzynczak. Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58929 ) Change subject: spd: Add new LP5 parts and generate SPDs ...................................................................... Patch Set 3: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/58929/comment/f3178d6c_14ff15b1 PS2, Line 12: MT62F512M32D2DR-031 WT:B : MT62F1G32D4DR-031 WT:B : H9JCNNNCP3MLYR-N6E > Please add the vendors. Done File spd/lp5/memory_parts.json: https://review.coreboot.org/c/coreboot/+/58929/comment/a4fe8e4a_8769dd13 PS2, Line 19: 2, > Perhaps I'm misunderstanding the datasheet, but isn't this also 1 like the 512M32? I was basing this off Table 2 in the datasheet, which shows 2 ranks per channel. Also, the block diagram in Figure 3 shows 2 CSs for each channel: CS0_A/B and CS1_A/B. https://review.coreboot.org/c/coreboot/+/58929/comment/8638de8d_743b3398 PS2, Line 27: 4, > I only see one ZQ ball per package on this part. I know for LP4x there was one ZQ ball per die, so this was used as an indicator of the number of dies. But I think it's different for LP5 because multiple dies can share a ZQ ball. From 16.6 ZQ Wiring in JESD209-5B: > LPDDR5 devices are designed to allow up to NZQ die within a single package to connect to a common ZQ resource. When multiple die share a ZQ resource, one die is designated as the Initiator die. The block diagram on this part's datasheet also shows 4 dies sharing a single ZQ pin. I might be missing something, but based on the LP5 tables in advisory #616599, I think for LP5 the dies per package is literally just the number of physical dies. I.e. since the datasheet says QDP and show 4 dies in the block diagram, diesPerPackage should be 4. -- To view, visit https://review.coreboot.org/c/coreboot/+/58929 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifbcadfb78281b2b78a61a9b61180c421748193a0 Gerrit-Change-Number: 58929 Gerrit-PatchSet: 3 Gerrit-Owner: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-CC: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Thu, 04 Nov 2021 21:29:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: spd: Add new LP5 parts and generate SPDs
by Reka Norman (Code Review) 04 Nov '21

04 Nov '21

Attention is currently required from: Reka Norman. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/58929 to look at the new patch set (#3). Change subject: spd: Add new LP5 parts and generate SPDs ...................................................................... spd: Add new LP5 parts and generate SPDs Add the parts below which will be used by the brya variant Vell. Add the parts to memory_parts.json and generate the SPDs using spd_gen. Micron MT62F512M32D2DR-031 WT:B Micron MT62F1G32D4DR-031 WT:B Hynix H9JCNNNCP3MLYR-N6E Generated using: util/spd_tools/bin/spd_gen spd/lp5/memory_parts.json lp5 BUG=b:204284866 TEST=None Change-Id: Ifbcadfb78281b2b78a61a9b61180c421748193a0 Signed-off-by: Reka Norman <rekanorman(a)google.com> --- M spd/lp5/memory_parts.json M spd/lp5/set-0/parts_spd_manifest.generated.txt A spd/lp5/set-0/spd-1.hex A spd/lp5/set-0/spd-2.hex 4 files changed, 99 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/58929/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/58929 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifbcadfb78281b2b78a61a9b61180c421748193a0 Gerrit-Change-Number: 58929 Gerrit-PatchSet: 3 Gerrit-Owner: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-CC: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2021